Author: ericwf
Date: Sat May 7 00:37:31 2016
New Revision: 268850
URL: http://llvm.org/viewvc/llvm-project?rev=268850&view=rev
Log:
Fix memory_resource build for _LIBCPP_HAS_NO_THREADS
Modified:
libcxx/trunk/src/experimental/memory_resource.cpp
Modified: libcxx/trunk/src/experimental/memory
EricWF closed this revision.
EricWF added a comment.
This was committed in r264191.
http://reviews.llvm.org/D18347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak created this revision.
ahatanak added reviewers: rjmccall, rsmith, manmanren.
ahatanak added a subscriber: cfe-commits.
The assert was committed in r183967. After r231508 made changes to promote
constant temporaries to globals, the assert fires when a std::initializer_list
is constructe
Author: ericwf
Date: Fri May 6 22:24:31 2016
New Revision: 268844
URL: http://llvm.org/viewvc/llvm-project?rev=268844&view=rev
Log:
Update TS implementation status page
Modified:
libcxx/trunk/www/ts1z_status.html
Modified: libcxx/trunk/www/ts1z_status.html
URL:
http://llvm.org/viewvc/llvm-
Author: chapuni
Date: Fri May 6 22:12:30 2016
New Revision: 268843
URL: http://llvm.org/viewvc/llvm-project?rev=268843&view=rev
Log:
Update \param corresponding to r268819. [-Wdocumentation]
Modified:
cfe/trunk/include/clang/Lex/ModuleMap.h
Modified: cfe/trunk/include/clang/Lex/ModuleMap.h
Author: ericwf
Date: Fri May 6 22:12:24 2016
New Revision: 268842
URL: http://llvm.org/viewvc/llvm-project?rev=268842&view=rev
Log:
Change allocator::allocate to throw length_error, not bad_alloc
Modified:
libcxx/trunk/include/memory
libcxx/trunk/test/std/utilities/memory/default.alloca
Author: ericwf
Date: Fri May 6 22:09:55 2016
New Revision: 268841
URL: http://llvm.org/viewvc/llvm-project?rev=268841&view=rev
Log:
Add experimental container alias templates for PMRs
Added:
libcxx/trunk/include/experimental/deque
libcxx/trunk/include/experimental/forward_list
libcxx
Author: ericwf
Date: Fri May 6 21:33:25 2016
New Revision: 268839
URL: http://llvm.org/viewvc/llvm-project?rev=268839&view=rev
Log:
Fix one more usage of _LIBCPP_HAS_NO_EXCEPTIONS
Modified:
libcxx/trunk/src/experimental/memory_resource.cpp
Modified: libcxx/trunk/src/experimental/memory_reso
Author: ericwf
Date: Fri May 6 21:30:21 2016
New Revision: 268838
URL: http://llvm.org/viewvc/llvm-project?rev=268838&view=rev
Log:
Fix typo it _LIBCPP_NO_EXCEPTIONS macro
Modified:
libcxx/trunk/include/exception
Modified: libcxx/trunk/include/exception
URL:
http://llvm.org/viewvc/llvm-pro
On Fri, May 6, 2016 at 4:20 PM, Matt Arsenault via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 05/06/2016 02:42 PM, David Majnemer via cfe-commits wrote:
>
>> This example looks wrong to me. It doesn't seem meaningful for a function
>> to be both readonly and convergent, because converge
jlebar added a comment.
While I think this is 100% the right thing to do, I am worried about breaking
existing targets. Maybe we need an escape valve, at least until we get that
sorted out? Unless you're pretty confident this isn't happening / will be easy
enough to fix.
Co
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting before committing.
http://reviews.llvm.org/D20007
___
cfe-commits mailing list
cfe-commits@lists.llvm.
dcoughlin added inline comments.
Comment at:
llvm/tools/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp:229
@@ -228,3 +228,3 @@
BT_stackleak.reset(
-new BuiltinBug(this, "Stack address stored into global variable",
- "Stack address
Author: bruno
Date: Fri May 6 18:58:58 2016
New Revision: 268825
URL: http://llvm.org/viewvc/llvm-project?rev=268825&view=rev
Log:
[CrashReproducer] Always use realpath for destination
When running reproducer scripts we need that original symlinks from the
source filesystem are reproduced in the
On 05/06/2016 12:11 PM, Anastasia Stulova via cfe-commits wrote:
I was just wondering whether it would make sense to restrict the usage of the attribute
to OpenCL language i.e. to add "let LangOpts = [OpenCL];" in the attribute
definition.
This seems to be a pointless arbitrary restriction to
Author: bruno
Date: Fri May 6 18:21:50 2016
New Revision: 268819
URL: http://llvm.org/viewvc/llvm-project?rev=268819&view=rev
Log:
[CrashReproducer] Change module map callback signature. NFC
Use a StringRef instead of a FileEntry in the moduleMapAddHeader
callback to allow more flexibility on wh
Author: bruno
Date: Fri May 6 18:21:57 2016
New Revision: 268820
URL: http://llvm.org/viewvc/llvm-project?rev=268820&view=rev
Log:
[VFS] Add dump methods to the VFS overlay tree
Useful when debugging issues within the VFS overlay.
Modified:
cfe/trunk/lib/Basic/VirtualFileSystem.cpp
Modifie
On 05/06/2016 02:42 PM, David Majnemer via cfe-commits wrote:
This example looks wrong to me. It doesn't seem meaningful for a
function to be both readonly and convergent, because convergent means
the call has some side-effect visible to other threads and readonly
means the call has no side-eff
On 05/06/2016 02:53 PM, Richard Smith via cfe-commits wrote:
It looks like we added the noduplicate attribute to clang to support
OpenCL's barrier function. Did we get the semantics for it wrong for
its intended use case?
Yes. Noduplicate is essentially deprecated in favor of convergent.
nodupl
saugustine created this revision.
saugustine added a reviewer: rnk.
saugustine added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Treat qualifiers on elaborated types for qualtypenames appropriately.
http://reviews.llvm.org/D20040
Files:
lib/Tooling/Core/QualTypeNames.cpp
un
Author: rsmith
Date: Fri May 6 18:14:07 2016
New Revision: 268817
URL: http://llvm.org/viewvc/llvm-project?rev=268817&view=rev
Log:
[modules] Attempt to improve performance for declaration merging without a Sema
object in C. Rather than using the DeclContext (which is very slow because it
trigger
tra created this revision.
tra added reviewers: jingyue, jlebar, rnk.
tra added a subscriber: cfe-commits.
While __shared__ variables look like any other variable with a static storage
class to compiler, they behave differently on device side.
* one instance is created per block of GPUS, so stan
tra added a comment.
In http://reviews.llvm.org/D20034#423945, @jlebar wrote:
> What are we supposed to do if we encounter a static __shared__ variable in an
> HD function? Presumably that also should be an error if we invoke the HD
> function from the device?
nvcc produces an error only of
jlebar added a comment.
What are we supposed to do if we encounter a static __shared__ variable in an
HD function? Presumably that also should be an error if we invoke the HD
function from the device?
http://reviews.llvm.org/D20034
___
cfe-commit
On Fri, May 6, 2016 at 2:42 PM, David Majnemer
wrote:
> On Fri, May 6, 2016 at 2:36 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Fri, May 6, 2016 at 1:56 PM, Ettore Speziale via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Hello,
>>>
>>> > In the
On Fri, May 6, 2016 at 5:43 PM, Yaron Keren via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Nico,
>
> In other tests, {{/|}} or {{/|\\}} are used match the forward or
> backward slash(es). clang escapes \ so we get two of them in output and
> four in the LIT test.
>
> It would be nic
Hi Nico,
In other tests, {{/|}} or {{/|\\}} are used match the forward or
backward slash(es). clang escapes \ so we get two of them in output and
four in the LIT test.
It would be nice to have more elegant construct for this general problem,
to avoid tests like:
"{{.*}}/Inputs/mingw_mingw_or
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D19666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
yaxunl added inline comments.
Comment at: lib/Headers/opencl-c.h:14057
@@ +14056,3 @@
+event_t __attribute__((overloadable)) async_work_group_copy(__local float2
*dst, const __global float2 *src, size_t num_elements, event_t event);
+event_t __attribute__((overloadable)) async_wo
On Fri, May 6, 2016 at 2:36 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, May 6, 2016 at 1:56 PM, Ettore Speziale via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Hello,
>>
>> > In the case of foo, there could be a problem.
>> > If you do not mark it c
Author: ericwf
Date: Fri May 6 16:35:06 2016
New Revision: 268801
URL: http://llvm.org/viewvc/llvm-project?rev=268801&view=rev
Log:
Tweak --param=no_default_flags=true to still add -Ilibcxx/test/support
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libcxx/tes
On Fri, May 6, 2016 at 1:56 PM, Ettore Speziale via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hello,
>
> > In the case of foo, there could be a problem.
> > If you do not mark it convergent, the LLVM sink pass push the call to
> foo to the then branch of the ternary operator, hence the pr
yaxunl marked 5 inline comments as done.
yaxunl added a comment.
> I agree with Xiuli, if we don't have generic implementation with i8*, the
> libraries would have to contain every possible implementation of each AS
> conversion builtin including user defined types (which we don't even know
>
tra created this revision.
tra added reviewers: jingyue, jlebar.
tra added a subscriber: cfe-commits.
According to CUDA programming guide (v7.5):
> E.2.9.4: Within the body of a __device__ or __global__ function, only
> __shared__ variables may be declared with static storage class.
http://re
Author: nico
Date: Fri May 6 16:17:32 2016
New Revision: 268797
URL: http://llvm.org/viewvc/llvm-project?rev=268797&view=rev
Log:
Fix sysroot-prefix.c on Windows (/ vs \).
Modified:
cfe/trunk/test/Preprocessor/sysroot-prefix.c
Modified: cfe/trunk/test/Preprocessor/sysroot-prefix.c
URL:
htt
Author: mren
Date: Fri May 6 16:04:01 2016
New Revision: 268793
URL: http://llvm.org/viewvc/llvm-project?rev=268793&view=rev
Log:
Availability: set location when creating attribute for tvos, watchos.
When inferring availability attributes for tvos, watchos from ios, we
use the same source locati
Hello,
> In the case of foo, there could be a problem.
> If you do not mark it convergent, the LLVM sink pass push the call to foo to
> the then branch of the ternary operator, hence the program has been
> incorrectly optimized.
>
> Really? It looks like the problem is that you lied to the comp
Anastasia added a comment.
In http://reviews.llvm.org/D19932#422374, @yaxunl wrote:
> In http://reviews.llvm.org/D19932#421961, @pxli168 wrote:
>
> > Could we output a generic function in CodeGen?
> > This seems to have no big difference to have a lot of declaration in an
> > opencl c header fi
On Wed, May 4, 2016 at 5:47 PM, Ettore Speziale via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hello,
>
> > I would appreciate a bit more background on this attribute's
> > semantics. How would a user know when to add this attribute to their
> > function definition? Are there other attribu
Author: mren
Date: Fri May 6 14:57:16 2016
New Revision: 268786
URL: http://llvm.org/viewvc/llvm-project?rev=268786&view=rev
Log:
Availability: attach the note to the declaration with the attributes.
Sometimes, the declaration we found has inherited availability
attributes, attaching the note to
I think it could be useful for CUDA too.
On Friday, May 6, 2016, Anastasia Stulova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Ettore,
>
> LGTM generally!
>
> I was just wondering whether it would make sense to restrict the usage of
> the attribute to OpenCL language i.e. to add "l
Author: compnerd
Date: Fri May 6 14:39:00 2016
New Revision: 268784
URL: http://llvm.org/viewvc/llvm-project?rev=268784&view=rev
Log:
test: attempt to repair windows build
Replace use of /dev/null with /var/empty. lit will substitute the /dev/null
include path resulting in failures. Use a path
Author: mren
Date: Fri May 6 14:35:02 2016
New Revision: 268781
URL: http://llvm.org/viewvc/llvm-project?rev=268781&view=rev
Log:
ObjC kindof: set the type of a conditional expression when involving kindof.
When either LHS or RHS is a kindof type, we return a kindof type.
rdar://problem/2051378
Author: compnerd
Date: Fri May 6 14:13:55 2016
New Revision: 268777
URL: http://llvm.org/viewvc/llvm-project?rev=268777&view=rev
Log:
Frontend: support -I=path for sysroot expansion
From the GCC manpage:
-I dir
... If dir begins with =, then the = will be replaced by the sysroot prefix;
Anastasia added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:3519
@@ +3518,3 @@
+ / 100);
+const char *VerSpec = (VerMajor + std::string (".") +
VerMinor).c_str();
+Diag(Tok, DiagID) << VerSpec << PrevSpec << i
Hi Ettore,
LGTM generally!
I was just wondering whether it would make sense to restrict the usage of the
attribute to OpenCL language i.e. to add "let LangOpts = [OpenCL];" in the
attribute definition.
Thanks!
Anastasia
-Original Message-
From: Ettore Speziale [mailto:speziale.ett...
Author: dcoughlin
Date: Fri May 6 13:24:50 2016
New Revision: 268773
URL: http://llvm.org/viewvc/llvm-project?rev=268773&view=rev
Log:
[analyzer] Add tests for Objective-C class properties
Add basic tests to ensure the analyzer has support for class properties. This
is a test-only change.
rdar:
Author: dcoughlin
Date: Fri May 6 13:13:30 2016
New Revision: 268768
URL: http://llvm.org/viewvc/llvm-project?rev=268768&view=rev
Log:
[www][analyzer] Update recommended suppression mechanism for localization.
Based on feedback from Jordan Rose, make the recommended suppression function
be 'sta
Author: jvesely
Date: Fri May 6 13:02:30 2016
New Revision: 268766
URL: http://llvm.org/viewvc/llvm-project?rev=268766&view=rev
Log:
math: Add erf ported from amd-builtins
The scalar float/double function bodies are a direct copy/paste,
aside from the removed (optional) code in float function bo
michael_miller updated this revision to Diff 56439.
michael_miller added a comment.
Switched to using getAsCXXRecordDecl.
http://reviews.llvm.org/D19993
Files:
clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
test/clang-tidy/cppcoreguidelines-pro-type-member-init-cxx98.cpp
test/cla
Author: dcoughlin
Date: Fri May 6 12:51:34 2016
New Revision: 268764
URL: http://llvm.org/viewvc/llvm-project?rev=268764&view=rev
Log:
[www][analyzer] Add FAQ about suppression of missing localization diagnostic.
Modified:
cfe/trunk/www/analyzer/faq.html
Modified: cfe/trunk/www/analyzer/faq
etienneb added a comment.
Get back to this solution.
comments?
http://reviews.llvm.org/D19871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
etienneb updated this revision to Diff 56428.
etienneb added a comment.
fix unittests
http://reviews.llvm.org/D19871
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: un
etienneb updated this revision to Diff 56427.
etienneb added a comment.
revert to previous solution
http://reviews.llvm.org/D19871
Files:
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: unittests/ASTMatchers/AS
Author: rsmith
Date: Fri May 6 11:48:29 2016
New Revision: 268749
URL: http://llvm.org/viewvc/llvm-project?rev=268749&view=rev
Log:
More fixes to codeblock formatting in documentation.
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/
majnemer added a comment.
In http://reviews.llvm.org/D19654#423382, @andreybokhanko wrote:
> David, thank you for the thorough review! -- it definitely made the patch
> stronger and me even more paranoid than the rest of Intel. :-)
Thanks for implementing this :)
>
>
> In http://reviews.l
etienneb added a comment.
Aaron? minus re-generation of the doc.
Is that what you want to see?
note: returned types for both getLength are not the same (APInt vs unsigned
int).
I took the 'hasSize'-Matcher approach to let overloaded operators do the job
for dispatching types.
note: there is a
etienneb updated this revision to Diff 56425.
etienneb added a comment.
fix unittests
http://reviews.llvm.org/D19876
Files:
include/clang/ASTMatchers/ASTMatchers.h
include/clang/ASTMatchers/ASTMatchersInternal.h
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: unittests/ASTMatchers/ASTMa
etienneb updated this revision to Diff 56423.
etienneb added a comment.
merging hasSize
http://reviews.llvm.org/D19876
Files:
include/clang/ASTMatchers/ASTMatchers.h
include/clang/ASTMatchers/ASTMatchersInternal.h
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: unittests/ASTMatchers/AST
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good!
http://reviews.llvm.org/D18745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
rmaprath added a comment.
@espositofulvio: Thanks for the patch! :)
Committed as r268734.
Repository:
rL LLVM
http://reviews.llvm.org/D11781
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
rmaprath closed this revision.
rmaprath added a comment.
@EricWF: Thanks for taking the time to review! :)
Committed as r268734. The bots seem to be happy.
http://reviews.llvm.org/D19412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
etienneb added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1578
@@ +1577,3 @@
+/// \endcode
+AST_MATCHER_P(StringLiteral, lengthIs, unsigned, N) {
+ return Node.getLength() == N;
etienneb wrote:
> aaron.ballman wrote:
> > etienneb wrote:
Anastasia added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:3519
@@ +3518,3 @@
+ / 100);
+const char *VerSpec = (VerMajor + std::string (".") +
VerMinor).c_str();
+Diag(Tok, DiagID) << VerSpec << PrevSpec << i
Thanks for reverting (I started it, but your fingers are faster than
mine...)
I will look at the reproducer.
Yours,
Andrey
On Fri, May 6, 2016 at 5:41 PM, Nico Weber wrote:
> I verified that this is due to this change. I filed
> https://llvm.org/bugs/show_bug.cgi?id=27666 with a reduced repro
I verified that this is due to this change. I filed
https://llvm.org/bugs/show_bug.cgi?id=27666 with a reduced repro and
reverted this change in r268736.
On Fri, May 6, 2016 at 9:52 AM, Nico Weber wrote:
> We're getting this crash now with a regression range of 268724:268729 --
> i.e. almost cer
Author: nico
Date: Fri May 6 09:34:29 2016
New Revision: 268736
URL: http://llvm.org/viewvc/llvm-project?rev=268736&view=rev
Log:
Revert r268727, it caused PR27666.
Modified:
cfe/trunk/include/clang/AST/Type.h
cfe/trunk/include/clang/Basic/AddressSpaces.h
cfe/trunk/include/clang/Basi
Author: asiri
Date: Fri May 6 09:06:29 2016
New Revision: 268734
URL: http://llvm.org/viewvc/llvm-project?rev=268734&view=rev
Log:
Refactor pthread usage of libcxx.
This patch extracts out all the pthread dependencies of libcxx into the
new header __threading_support. The motivation is to make i
We're getting this crash now with a regression range of 268724:268729 --
i.e. almost certainly this change:
FAILED: obj/net/dns/net.mdns_client.obj
ninja -t msvc -e environment.x64 --
"..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" -m64 /nologo
/showIncludes /FC @obj\net\dns\net.mdns_c
Prazek added a comment.
In http://reviews.llvm.org/D19105#422702, @Quuxplusone wrote:
> It seems like this proposed diagnostic and fixit, statistically speaking, is
> *never* correct.
> In the cases where there is a code issue to be corrected, the diagnosable
> issue really seems to involve da
bcraig added a comment.
r268732
http://reviews.llvm.org/D19936
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bcraig
Date: Fri May 6 08:29:46 2016
New Revision: 268732
URL: http://llvm.org/viewvc/llvm-project?rev=268732&view=rev
Log:
Adding omitted column to invalid loc diagnostic.
note_fe_backend_invalid_loc expects three arguments (file, line, column),
and will assert when only given two. The
staronj added inline comments.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:56
@@ +55,3 @@
+ "converting integer literal to "
+ "bool%select{| inside a macro}0, use bool literal instead");
+
alexfh wrote:
> Can you
bogden added a comment.
I think this fix is OK, but I'm not clear on why we need both C and D, so
perhaps it is important that the function does not have a return statement.
http://reviews.llvm.org/D20014
___
cfe-commits mailing list
cfe-commits@li
staronj updated this revision to Diff 56395.
staronj marked 3 inline comments as done.
http://reviews.llvm.org/D18745
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseBoolLiteralsCheck.cpp
clang-tidy/modernize/UseBoolLiteralsC
bogden created this revision.
bogden added a reviewer: EricWF.
bogden added a subscriber: cfe-commits.
This test contains a non-void function with no explicit return,
causing it to fail when built with -Werror=return-type. This patch adds
a return to the function.
http://reviews.llvm.org/D20014
Author: nhaustov
Date: Fri May 6 04:15:24 2016
New Revision: 268718
URL: http://llvm.org/viewvc/llvm-project?rev=268718&view=rev
Log:
AMDGPU/SI: Use amdgpu_kernel calling convention for OpenCL kernels.
Reviewers: tstellarAMD, arsenm
Subscribers: cfe-commits
Differential Revision: http://review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268718: AMDGPU/SI: Use amdgpu_kernel calling convention for
OpenCL kernels. (authored by nhaustov).
Changed prior to commit:
http://reviews.llvm.org/D19918?vs=56141&id=56389#toc
Repository:
rL LLVM
Author: abataev
Date: Fri May 6 07:04:14 2016
New Revision: 268729
URL: http://llvm.org/viewvc/llvm-project?rev=268729&view=rev
Log:
[OPENMP 4.5] Tests for 'private|firstprivates' clauses in 'taskloop' directive.
Added tests for codegen for private|firstprivate clauses in taskloop-based
directi
Author: aaronballman
Date: Fri May 6 06:56:57 2016
New Revision: 268728
URL: http://llvm.org/viewvc/llvm-project?rev=268728&view=rev
Log:
s/codeblock/code-block to fix the Sphinx build.
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org
andreybokhanko added a comment.
David, thank you for the thorough review! -- it definitely made the patch
stronger and me even more paranoid than the rest of Intel. :-)
In http://reviews.llvm.org/D19654#422445, @majnemer wrote:
> FYI, we will also want to update `getAddrOfCXXCatchHandler` and
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268727: [MSVC] Implementation of __unaligned as a proper
type qualifier (authored by asbokhan).
Changed prior to commit:
http://reviews.llvm.org/D19654?vs=55588&id=56401#toc
Repository:
rL LLVM
http
Author: asbokhan
Date: Fri May 6 06:47:55 2016
New Revision: 268727
URL: http://llvm.org/viewvc/llvm-project?rev=268727&view=rev
Log:
[MSVC] Implementation of __unaligned as a proper type qualifier
This patch implements __unaligned (MS extension) as a proper type qualifier
(before that, it was i
filcab updated this revision to Diff 56396.
filcab added a comment.
Address Richard's comments.
Final Windows fixes (force a Linux target so our mangled label matches).
http://reviews.llvm.org/D19666
Files:
docs/UndefinedBehaviorSanitizer.rst
include/clang/Driver/Options.td
include/clang/
bkramer added inline comments.
Comment at: include-fixer/find-all-symbols/FindAllSymbols.h:16
@@ +15,3 @@
+#include "llvm/ADT/StringRef.h"
+
+#include
No space between #includes in LLVM.
Comment at: include-fixer/find-all-symbols/PragmaCommentHa
Author: abataev
Date: Fri May 6 04:40:08 2016
New Revision: 268721
URL: http://llvm.org/viewvc/llvm-project?rev=268721&view=rev
Log:
[OPENMP 4.0] Codegen for 'declare simd' directive.
OpenMP 4.0 adds support for elemental functions using declarative
directive '#pragma omp declare simd'. Patch ad
alexfh added a comment.
In http://reviews.llvm.org/D19865#423140, @flx wrote:
> In http://reviews.llvm.org/D19865#419905, @flx wrote:
>
> > In http://reviews.llvm.org/D19865#419830, @alexfh wrote:
> >
> > > Is it a workaround to avoid breaking the code by incorrect fixes?
> >
> >
> > Yes. We can'
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with one nit.
Comment at: test/clang-tidy/google-default-arguments.cpp:10
@@ +9,3 @@
+ void f(int I, int J = 5);
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: default a
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D20011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
hokein added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:31
@@ +30,3 @@
+// Convenience utility to get a RecordDecl from a QualType.
+const RecordDecl *getCanonicalRecordDecl(const QualType &Type) {
+ if (const auto *RT = Type.getCanonical
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: ABataev.
DmitryPolukhin added a subscriber: cfe-commits.
Support OpenMP version 4.5 syntax for #pragma omp declare target.
Syntax:
#pragma omp declare target (extended-list) new-line
or
#pragma omp declare target clause[ [
filcab added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2385-2386
@@ +2384,4 @@
+FilenameString = FilenameString.substr(I - E);
+ else
+FilenameString = llvm::sys::path::filename(FilenameString);
+} else if (PathComponentsToStrip > 0) {
--
92 matches
Mail list logo
