This revision was automatically updated to reflect the committed changes.
Closed by commit rL267855: Add missing newline in clang-rename output.
(authored by klimek).
Changed prior to commit:
http://reviews.llvm.org/D18957?vs=53222&id=55380#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
Author: klimek
Date: Thu Apr 28 01:46:44 2016
New Revision: 267855
URL: http://llvm.org/viewvc/llvm-project?rev=267855&view=rev
Log:
Add missing newline in clang-rename output.
Patch by Miklos Vajna.
Differential Revision: http://reviews.llvm.org/D18957
Modified:
clang-tools-extra/trunk/cla
klimek added a reviewer: djasper.
Comment at: lib/Format/AffectedRangeManager.cpp:103
@@ -102,1 +102,3 @@
AnnotatedLine *Line, const AnnotatedLine *PreviousLine) {
+ assert(Line && "does not contain any line");
+
Perhaps we should change this to take a Line&
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:300-301
@@ -299,3 +299,4 @@
+ assert(SM && "SourceManager is NULL, cannot iterate through the
diagnostics");
for (std::vector::iterator DI = Diags.begin(),
LGTM
ht
hansonw added reviewers: compnerd, skalinichev.
hansonw added a comment.
Adding you guys since you reviewed some recent changes :)
http://reviews.llvm.org/D17841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
hansonw updated this revision to Diff 55378.
hansonw added a comment.
Rebase
http://reviews.llvm.org/D17841
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_diagnostics.py
Index: bindings/python/tests/cindex/test_diagnostics.py
==
twoh updated this revision to Diff 55377.
twoh added a comment.
Addressing comments from @joerg. Two versions of the test provided, one for an
architecture with signed char(x86_64) and the other for an architecture with
unsigned char(powerpc64).
http://reviews.llvm.org/D19062
Files:
include
djasper added inline comments.
Comment at: lib/Format/AffectedRangeManager.h:68
@@ +67,2 @@
+#endif // LLVM_CLANG_LIB_FORMAT_AFFECTEDRANGEMANAGER_H
+#
??
http://reviews.llvm.org/D19587
___
cfe-commits mailing list
c
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Otherwise looks good.
http://reviews.llvm.org/D19587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
EricWF closed this revision.
EricWF added a comment.
r267852.
http://reviews.llvm.org/D19619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Apr 27 22:17:56 2016
New Revision: 267852
URL: http://llvm.org/viewvc/llvm-project?rev=267852&view=rev
Log:
Remove names of unreferenced parameters. Patch from s...@microsoft.com
Modified:
libcxx/trunk/test/std/algorithms/alg.sorting/alg.min.max/minmax_init_list_comp
chapuni added a subscriber: chapuni.
Comment at:
clang-tools-extra/trunk/unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp:333
@@ +332,3 @@
+ static const char Code[] = R"(
+ typedef unsigned size_t;
+ typedef struct { int x; } X;
size_t
EricWF closed this revision.
EricWF added a comment.
r267844.
http://reviews.llvm.org/D19620
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: chapuni
Date: Wed Apr 27 21:45:21 2016
New Revision: 267845
URL: http://llvm.org/viewvc/llvm-project?rev=267845&view=rev
Log:
CGOpenMPRuntime.h: Prune extra comma in \param. [-Wdocumentation]
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRu
Author: ericwf
Date: Wed Apr 27 21:45:11 2016
New Revision: 267844
URL: http://llvm.org/viewvc/llvm-project?rev=267844&view=rev
Log:
Add braces, move braces, and rename variables to avoid shadowing. Patch from
s...@microsoft.com
Modified:
libcxx/trunk/test/std/algorithms/alg.sorting/alg.sor
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I hope the actual warning says 'meow' in all cases.
http://reviews.llvm.org/D19620
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
dyung added a comment.
In http://reviews.llvm.org/D19048#414568, @aprantl wrote:
> Thanks!
>
> Is there anything meaningful that could be CHECKed here?
> Usually a crash means that we previously had a code path without test
> coverage.
This was definitely a code path without test coverage.
W
EricWF closed this revision.
EricWF added a comment.
r267843. This warning seems a bit silly though.
http://reviews.llvm.org/D19622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Apr 27 21:18:48 2016
New Revision: 267843
URL: http://llvm.org/viewvc/llvm-project?rev=267843&view=rev
Log:
Provide member function definitions to avoid warnings. Patch from
s...@microsoft.com
Modified:
libcxx/trunk/test/std/utilities/meta/meta.rel/is_nothrow_callabl
Author: chapuni
Date: Wed Apr 27 21:15:16 2016
New Revision: 267841
URL: http://llvm.org/viewvc/llvm-project?rev=267841&view=rev
Log:
FindAllSymbolsTest.CTypedefTest: Tweak for LLP64 like x86_64-win32.
In file included from symbol.cc:1:
symbols.h:2:24: error: typedef redefinition with differe
chh closed this revision.
chh added a comment.
Was submitted in r267832 | chh | 2016-04-27 18:09:09 -0700 (Wed, 27 Apr 2016)
http://reviews.llvm.org/D19393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
EricWF closed this revision.
EricWF added a comment.
r267838.
http://reviews.llvm.org/D19621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Apr 27 21:00:52 2016
New Revision: 267838
URL: http://llvm.org/viewvc/llvm-project?rev=267838&view=rev
Log:
Rename function parameters to avoid shadowing. Patch from s...@microsoft.com
Modified:
libcxx/trunk/test/std/thread/futures/futures.async/async.pass.cpp
Modifi
EricWF closed this revision.
EricWF added a comment.
Committed in r267836. I must say it's pretty cool to review and commit a patch
from *the* STL. Never thought that would happen when I started programming.
http://reviews.llvm.org/D19618
___
cfe-c
Author: ericwf
Date: Wed Apr 27 20:49:03 2016
New Revision: 267836
URL: http://llvm.org/viewvc/llvm-project?rev=267836&view=rev
Log:
Guard Clang and GCC specific pragmas. Patch from s...@microsoft.com
Modified:
libcxx/trunk/test/std/depr/depr.c.headers/stdio_h.pass.cpp
libcxx/trunk/test/s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267835: Fix include path in ClangTidy.cpp. (authored by
srhines).
Changed prior to commit:
http://reviews.llvm.org/D19249?vs=54587&id=55368#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19249
Fi
Author: srhines
Date: Wed Apr 27 20:42:12 2016
New Revision: 267835
URL: http://llvm.org/viewvc/llvm-project?rev=267835&view=rev
Log:
Fix include path in ClangTidy.cpp.
Summary:
https://llvm.org/bugs/show_bug.cgi?id=27355
To compile with other binary output directory structures in build systems l
Author: chh
Date: Wed Apr 27 20:09:09 2016
New Revision: 267832
URL: http://llvm.org/viewvc/llvm-project?rev=267832&view=rev
Log:
[analyzer] Move Checkers.inc to clang/include/...
Simplify sharing of Checkers.inc with other files like ClangTidy.cpp.
Differential Revision: http://reviews.llvm.org
ariccio marked an inline comment as done.
ariccio added a comment.
Wrongly `#if defined` out test is now fixed.
http://reviews.llvm.org/D18073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
ariccio updated this revision to Diff 55366.
ariccio added a comment.
Conditionally check Windows methods on Windows.
Is this what you're thinking of? It's kinda ugly - I was hoping to avoid the
`#if`s - but it does only check the Windows functions on Windows builds only.
http://reviews.llvm.o
rsmith added inline comments.
Comment at: lib/Driver/ToolChains.cpp:722
@@ +721,3 @@
+if (BeginSDK != StringRef::npos && EndSDK != StringRef::npos) {
+ StringRef SDK = isysroot.slice(BeginSDK + 5, EndSDK);
+ if (!SDK.startswith(getPlatformFamily()))
rsmith added a subscriber: rsmith.
Comment at: lib/Driver/ToolChains.cpp:718-720
@@ +717,5 @@
+StringRef isysroot = A->getValue();
+// Assume SDK has path: SOME_PATH/SDKs/PlatformXX.YY.sdk
+size_t BeginSDK = isysroot.rfind("SDKs/");
+size_t EndSDK = isysroot.rfind(
Author: chapuni
Date: Wed Apr 27 19:53:30 2016
New Revision: 267830
URL: http://llvm.org/viewvc/llvm-project?rev=267830&view=rev
Log:
clang/test/CodeGenCXX/cfi-blacklist.cpp: Exclude ms targets. They would be
non-cfi.
Modified:
cfe/trunk/test/CodeGenCXX/cfi-blacklist.cpp
Modified: cfe/trunk
Huh. There are strange interactions here, which makes me even more nervous
about testing fewer cases.
As it happens, the test as written did not exercise all 3 modified paths.
Because 'struct S2' had all its members marked with nodebug, none of the
static-member references caused debug info for
Author: chapuni
Date: Wed Apr 27 19:39:48 2016
New Revision: 267828
URL: http://llvm.org/viewvc/llvm-project?rev=267828&view=rev
Log:
clang-tools-extra/test/clang-tidy/cppcoreguidelines-pro-type-member-init-cxx98.cpp:
Appease ms targets with -fno-delayed-template-parsing.
Modified:
clang-to
rsmith added a comment.
LGTM
http://reviews.llvm.org/D18271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added inline comments.
Comment at: lib/Parse/ParseTemplate.cpp:151-153
@@ -149,1 +150,5 @@
+ if (isSpecialization)
+TemplateParmScopePtr->setFlags(TemplateParmScopePtr->getFlags() ^
+ Scope::TemplateParamScope);
+
Us
Author: pcc
Date: Wed Apr 27 19:18:30 2016
New Revision: 267824
URL: http://llvm.org/viewvc/llvm-project?rev=267824&view=rev
Log:
Driver: only produce CFI -fvisibility= error when compiling.
The -fvisibility= flag only affects compile jobs, so there's no need to
error out because of it if we aren
aprantl closed this revision.
aprantl added a comment.
Thanks! Committed as 267464, 267633, 267630, 267612, 267611.
Repository:
rL LLVM
http://reviews.llvm.org/D19443
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
ahatanak updated this revision to Diff 55356.
ahatanak added a comment.
Made a couple of changes to distinguish between an explicit specialization
('template<>') and a template declaration which doesn't have a named template
parameter (see the variable template fn0 in test case vartemplate-lambd
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Since http://reviews.llvm.org/D19393 is approved, this patch also looks fine.
http://reviews.llvm.org/D19249
___
cfe-commits mailing list
cfe-com
rnk updated this revision to Diff 55359.
rnk added a comment.
- address comments
http://reviews.llvm.org/D18271
Files:
include/clang/Basic/Diagnostic.h
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/AnalysisBasedWa
Author: sfantao
Date: Wed Apr 27 18:14:30 2016
New Revision: 267814
URL: http://llvm.org/viewvc/llvm-project?rev=267814&view=rev
Log:
[OpenMP] Code generation for target exit data directive
Summary:
This patch adds support for the target exit data directive code generation.
Given that, apart fro
sfantao updated this revision to Diff 55352.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D17369
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_exit_data_codegen.cpp
Index: test/OpenMP/target_exit_data_
sfantao updated this revision to Diff 55349.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D17368
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_enter_data_codegen.cpp
Index: test/OpenMP/target_enter_dat
Author: sfantao
Date: Wed Apr 27 18:07:29 2016
New Revision: 267812
URL: http://llvm.org/viewvc/llvm-project?rev=267812&view=rev
Log:
[OpenMP] Code generation for target enter data directive
Summary: This patch adds support for the target enter data directive code
generation.
Reviewers: hfinkel
Author: sfantao
Date: Wed Apr 27 17:58:19 2016
New Revision: 267811
URL: http://llvm.org/viewvc/llvm-project?rev=267811&view=rev
Log:
[OpenMP] Code generation for target data directive
Summary:
This patch adds support for the target data directive code generation.
Part of the already existent fu
sfantao updated this revision to Diff 55347.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D17367
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_data_codegen.cpp
Index: test/OpenMP/target_data_codegen.cp
beanz added a comment.
Ping?
http://reviews.llvm.org/D18088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4692-4694
@@ +4691,5 @@
+ llvm::Value *ElemSize;
+ if (auto *PTy = BaseTy->getAs()) {
+ElemSize = CGF.getTypeSize(PTy->getPointeeType().getCanonicalType());
On Wed, Apr 27, 2016 at 3:24 PM, Paul Robinson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> probinson added a comment.
>
> In http://reviews.llvm.org/D19567#413997, @dblaikie wrote:
>
> > For 3 code paths (that seem fairly independent from one another) I'd
> only really expect to see 3 v
steven_wu added a comment.
Ping.
http://reviews.llvm.org/D17392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sfantao
Date: Wed Apr 27 17:28:32 2016
New Revision: 267805
URL: http://llvm.org/viewvc/llvm-project?rev=267805&view=rev
Log:
Remove unused LangOpts private variable in HeaderSearch.
Was causing warnings during the build.
Modified:
cfe/trunk/include/clang/Lex/HeaderSearch.h
cfe/
howard.hinnant added a subscriber: howard.hinnant.
howard.hinnant added a comment.
When in doubt, I find initializing to nan a safe thing to do. Either the code
is correct, or the nan will find the bug.
http://reviews.llvm.org/D19623
___
cfe-commi
Author: probinson
Date: Wed Apr 27 17:18:46 2016
New Revision: 267804
URL: http://llvm.org/viewvc/llvm-project?rev=267804&view=rev
Log:
Minor test simplification (per David Blaikie suggestion).
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-nodebug.cpp
Modified: cfe/trunk/test/CodeGenCXX/deb
probinson added a comment.
In http://reviews.llvm.org/D19567#413997, @dblaikie wrote:
> For 3 code paths (that seem fairly independent from one another) I'd only
> really expect to see 3 variables in the test - one to exercise each codepath.
> What's the reason for the larger set of test cases?
Fat archives is the big thing. Since we can do fat multi-stage builds using
llvm-ar isn’t really ideal.
-Chris
> On Apr 27, 2016, at 3:16 PM, Rafael Espíndola
> wrote:
>
> BTW, do you know what is missing in llvm-ar? I know of fat archive
> support, but if there is something else could you op
BTW, do you know what is missing in llvm-ar? I know of fat archive
support, but if there is something else could you open a bug report?
Cheers,
Rafael
On 27 April 2016 at 14:52, Chris Bieneman via cfe-commits
wrote:
> Author: cbieneman
> Date: Wed Apr 27 13:52:48 2016
> New Revision: 267756
>
>
Author: rsmith
Date: Wed Apr 27 16:57:05 2016
New Revision: 267802
URL: http://llvm.org/viewvc/llvm-project?rev=267802&view=rev
Log:
[modules] When diagnosing a missing module import, suggest adding a #include if
the current language doesn't have an import syntax and we can figure out a
suitable f
STL_MSFT added a comment.
I'd be happy to deal with this in another way. Would you accept
_MSC_VER-guarded pragmas to silence such warnings? I didn't see an easy way to
rework the logic here so that the variables are obviously initialized on every
codepath, which would be the ideal pragma-less
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: include/clang/Basic/DiagnosticGroups.td:341-342
@@ +340,4 @@
+
+def ShadowFieldInConstructor : DiagGroup<"shadow-field-in-constructor">;
+def ShadowFieldInConstructorModified :
DiagGroup<"
rsmith added a subscriber: rsmith.
rsmith added a comment.
I don't know how the libc++ folks feel about this, but our usual policy in
Clang and LLVM is that we don't add bogus initializers to shut up incorrect
"maybe used uninitialized" compiler warnings, because these initializers
prevent tool
This appears to be a different direction from what we'd agreed upon. Please
update the original thread with discussion and your intentions and a
breakdown of costs, long-term maintainability, and your plans here.
Thanks.
On Mon, Apr 18, 2016 at 2:07 PM Eric Christopher via cfe-commits <
cfe-commi
apelete updated this revision to Diff 55327.
apelete added a comment.
[scan-build] fix logic error warnings emitted on clang code base
Changes since last revision:
- lib/Format/AffectedRangeManager.cpp: moved the fixes from
lib/Format/Format.cpp:AffectedRangeManager::nonPPLineAffected() here si
STL_MSFT created this revision.
STL_MSFT added reviewers: mclow.lists, EricWF.
STL_MSFT added a subscriber: cfe-commits.
[libc++] Void-cast runtime-unused variables.
Also, remove unused names in exception handlers and remove an unused array.
Fixes MSVC "warning C4101: unreferenced local variable
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libc++] Initialize local doubles to 0.0.
(Zero is a strict subset of garbage.)
Fixes MSVC "warning C4701: potentially uninitialized local variable 'meow'
used".
http://revi
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libc++] Implement the member functions of a local struct.
Fixes MSVC "warning C4822: local class member function does not have a body".
http://reviews.llvm.org/D19622
Files:
aprantl added a comment.
Thanks!
Is there anything meaningful that could be CHECKed here?
Usually a crash means that we previously had a code path without test coverage.
http://reviews.llvm.org/D19048
___
cfe-commits mailing list
cfe-commits@lists.
STL_MSFT created this revision.
STL_MSFT added reviewers: mclow.lists, EricWF.
STL_MSFT added a subscriber: cfe-commits.
[libc++] Rename function parameters to avoid shadowing.
Fixes MSVC "warning C4459: declaration of 'meow' hides global declaration".
http://reviews.llvm.org/D19621
Files:
te
STL_MSFT created this revision.
STL_MSFT added reviewers: mclow.lists, EricWF.
STL_MSFT added a subscriber: cfe-commits.
[libc++] Add braces, move braces, and rename variables to avoid shadowing.
Fixes MSVC "warning C4456: declaration of 'meow' hides previous local
declaration".
http://reviews.
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libc++] Remove the names of unreferenced parameters.
Fixes MSVC "warning C4100: unreferenced formal parameter".
http://reviews.llvm.org/D19619
Files:
test/std/algorithms/a
STL_MSFT created this revision.
STL_MSFT added reviewers: mclow.lists, EricWF.
STL_MSFT added a subscriber: cfe-commits.
[libc++] Consistently guard "#pragma clang" with "#if defined(__clang__)".
Similarly, consistently guard "#pragma GCC" with "#if defined(__GNUC__)".
Fixes MSVC "warning C4068:
dyung added a comment.
ping
http://reviews.llvm.org/D19048
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added a comment.
LGTM! Thanks!
http://reviews.llvm.org/D18963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: pcc
Date: Wed Apr 27 15:49:44 2016
New Revision: 267788
URL: http://llvm.org/viewvc/llvm-project?rev=267788&view=rev
Log:
Revert unnecessary tblgen change.
Modified:
cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp
Modified: cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp
URL:
http://llv
Author: rksimon
Date: Wed Apr 27 15:43:32 2016
New Revision: 267786
URL: http://llvm.org/viewvc/llvm-project?rev=267786&view=rev
Log:
Wdocumentation fix
Modified:
clang-tools-extra/trunk/include-fixer/tool/ClangIncludeFixer.cpp
Modified: clang-tools-extra/trunk/include-fixer/tool/ClangInclud
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267784: Rework interface for bitset-using features to use a
notion of LTO visibility. (authored by pcc).
Changed prior to commit:
http://reviews.llvm.org/D18635?vs=54439&id=55307#toc
Repository:
rL L
Author: pcc
Date: Wed Apr 27 15:39:53 2016
New Revision: 267784
URL: http://llvm.org/viewvc/llvm-project?rev=267784&view=rev
Log:
Rework interface for bitset-using features to use a notion of LTO visibility.
Bitsets, and the compiler features they rely on (vtable opt, CFI),
only have visibility w
thakis added a subscriber: thakis.
thakis added a comment.
Thanks for the patch! To add to your proposed todo list (which sounds great):
All these stack-using pragmas aren't serialized to pch files at the moment
either. Maybe you want to work on that too (either serialize the stacks, or
emit a
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: docs/ControlFlowIntegrity.rst:268-269
@@ -262,1 +267,4 @@
+Normally, the compiler will disable CFI checks for classes that do not
+have hidden LTO visibility. With this flag enabled, the
rmaprath added inline comments.
Comment at: src/algorithm.cpp:51
@@ -50,3 +50,3 @@
#ifndef _LIBCPP_HAS_NO_THREADS
-static pthread_mutex_t __rs_mut = PTHREAD_MUTEX_INITIALIZER;
+static mutex __rs_mut;
#endif
bcraig wrote:
> rmaprath wrote:
> > mclow.lists wrote:
uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D19432
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
nlewycky added a subscriber: nlewycky.
Comment at: clang-tidy/readability/MisleadingIndentationCheck.cpp:31
@@ +30,3 @@
+ Result.SourceManager->getExpansionColumnNumber(ElseLoc))
+diag(ElseLoc, "potentional dangling else");
+}
Typo of "potential" as "pote
joerg added a comment.
Looking again at the failure mode, I think the best approach is to go back to
the original test case and just select a fixed target. The problematic IR
difference is purely an ABI choice of the target and not even related to
-fsigned-char vs -funsigned-char. As such, the
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks this is a nice cleanup!
Comment at: include/clang/Sema/Sema.h:338-342
@@ +337,7 @@
+PSK_Reset = 0x0,// #pragma ()
+PSK_Set = 0x1,
bcraig added inline comments.
Comment at: src/algorithm.cpp:51
@@ -50,3 +50,3 @@
#ifndef _LIBCPP_HAS_NO_THREADS
-static pthread_mutex_t __rs_mut = PTHREAD_MUTEX_INITIALIZER;
+static mutex __rs_mut;
#endif
rmaprath wrote:
> mclow.lists wrote:
> > What happened to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267772: Set the default C standard to C99 when targeting the
PS4. (authored by ssrivastava).
Changed prior to commit:
http://reviews.llvm.org/D19003?vs=54956&id=55299#toc
Repository:
rL LLVM
http://
Author: ssrivastava
Date: Wed Apr 27 14:53:03 2016
New Revision: 267772
URL: http://llvm.org/viewvc/llvm-project?rev=267772&view=rev
Log:
Set the default C standard to C99 when targeting the PS4.
Patch by Douglas Yung!
Differential Revision: http://reviews.llvm.org/D19003
Modified:
cfe/trun
rmaprath added a comment.
> On a bikeshed note: is `<__os_support>` the right name? Or should it be
> something like `<__thread>` or `<__threading_support>`?
I went with `__os_support` in case if we'd want to group further external
dependencies (like, for example, if some non-c POSIX calls a
pcc added a comment.
Ping.
http://reviews.llvm.org/D18635
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek removed rL LLVM as the repository for this revision.
Prazek updated this revision to Diff 55295.
http://reviews.llvm.org/D19183
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/MakeSharedCheck.cpp
clang-tidy/modernize/MakeSharedCheck.h
clang-tidy/modernize/MakeSmartP
So it seems that there is an agreement that Clang don't need this MSVC
"feature" so I'll revert my patch tomorrow when I get to the office.
On Wed, Apr 27, 2016 at 10:09 PM, Stephan T. Lavavej <
s...@exchange.microsoft.com> wrote:
> [Richard Smith]
> > You can find a description of the problem in
davidxl accepted this revision.
davidxl added a reviewer: davidxl.
davidxl added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D19612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
eraman created this revision.
eraman added a reviewer: vsk.
eraman added subscribers: cfe-commits, davidxl.
http://reviews.llvm.org/D19612
Files:
lib/CodeGen/CMakeLists.txt
lib/CodeGen/CoverageMappingGen.cpp
Index: lib/CodeGen/CoverageMappingGen.cpp
==
Prazek updated this revision to Diff 55287.
http://reviews.llvm.org/D18274
Files:
clang-tidy/CMakeLists.txt
clang-tidy/boost/BoostTidyModule.cpp
clang-tidy/boost/CMakeLists.txt
clang-tidy/plugin/CMakeLists.txt
clang-tidy/tool/CMakeLists.txt
clang-tidy/tool/ClangTidyMain.cpp
docs/Rel
Prazek marked 3 inline comments as done.
Prazek added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D19183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jlebar
Date: Wed Apr 27 14:12:56 2016
New Revision: 267764
URL: http://llvm.org/viewvc/llvm-project?rev=267764&view=rev
Log:
Call TargetMachine::addEarlyAsPossiblePasses from BackendUtil.
Summary:
As of D18614, TargetMachine exposes a hook to add a set of passes that should
be run as earl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267764: Call TargetMachine::addEarlyAsPossiblePasses from
BackendUtil. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D18617?vs=53415&id=55290#toc
Repository:
rL LLVM
http://
[Richard Smith]
> You can find a description of the problem in http://llvm.org/PR27337
> Brief summary:
> The WTL bug is the missing 'public' on the second base class on this line:
> https://sourceforge.net/p/wtl/code/HEAD/tree/trunk/wtl/Samples/MDIDocVw/mainfrm.h#l636
> The C1xx bug is that it ac
Prazek updated this revision to Diff 55280.
http://reviews.llvm.org/D18136
Files:
clang-tidy/boost/BoostTidyModule.cpp
clang-tidy/boost/CMakeLists.txt
clang-tidy/boost/UseToStringCheck.cpp
clang-tidy/boost/UseToStringCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy/checks/boost-use-to-st
1 - 100 of 195 matches
Mail list logo
