Re: [PATCH] D19524: [OpenCL] Fix pipe type dump.

pxli168 updated this revision to Diff 55161. pxli168 added a comment. Add test and fix some old test. http://reviews.llvm.org/D19524 Files: lib/AST/ASTDumper.cpp lib/AST/TypePrinter.cpp test/Misc/ast-dump-pipe.cl test/SemaOpenCL/invalid-access-qualifier.cl test/SemaOpenCL/invalid-pipe

[PATCH] D19577: [clang-tidy] Enhance misc-suspicious-string-compare by matching string.compare

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. This patch added the support for method "compare" on string-like classes. The LLVM stringRef is supported. The checker assume that StringRef is returning -1, 0 or 1. Which is not the case

Re: [PATCH] D19524: [OpenCL] Fix pipe type dump.

pxli168 added a comment. I will add a test and send a new version. http://reviews.llvm.org/D19524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r267534 - [MSVC] PR27337: allow static_cast from private base to derived for WTL

On Tue, Apr 26, 2016 at 7:04 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Visual Studio 2015 (19.00.23720.0) reports: > > error C2243: 'static_cast': conversion from 'B *' to 'A *' exists, but is > inaccessible > Right, it's the other direction ('A *' to 'B *') that t

Re: r267534 - [MSVC] PR27337: allow static_cast from private base to derived for WTL

Visual Studio 2015 (19.00.23720.0) reports: error C2243: 'static_cast': conversion from 'B *' to 'A *' exists, but is inaccessible On Tue, Apr 26, 2016 at 6:33 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > As noted in PR27337, this only occurs in one WTL sample, and we

[libcxx] r267654 - Fix = that should have been == in test. Thanks to STL@microsoft for the catch

Author: marshall Date: Tue Apr 26 20:46:43 2016 New Revision: 267654 URL: http://llvm.org/viewvc/llvm-project?rev=267654&view=rev Log: Fix = that should have been == in test. Thanks to STL@microsoft for the catch Modified: libcxx/trunk/test/std/containers/associative/map/compare.pass.cpp Mod

Re: [PATCH] D19565: [libc++] Fix an accidental assignment within assert() that should have been equality.

mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 267654. http://reviews.llvm.org/D19565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18641: [PP] Handle #include_next after include found relative to current one same as GCC

rsmith added a comment. I'm a little concerned about the possibility of this breaking uses of this feature on platforms where Clang is the system compiler. For instance, this pattern would be broken by your change: // stddef.h #include "stddef-helper.h" // stddef-helper.h #include_ne

Re: [PATCH] D19565: [libc++] Fix an accidental assignment within assert() that should have been equality.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Whoops! LGTM. http://reviews.llvm.org/D19565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

Re: r267534 - [MSVC] PR27337: allow static_cast from private base to derived for WTL

As noted in PR27337, this only occurs in one WTL sample, and we have no evidence that it actually occurs in real code. Have you seen uses of this in the wild? We generally don't want to add compatibility for MSVC bugs unless there's some real-world motivation. On Tue, Apr 26, 2016 at 2:21 AM, Dmit

Re: [PATCH] D19003: Set C99 as default C Standard for PS4 target

probinson accepted this revision. probinson added a reviewer: probinson. probinson added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D19003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D19327: Keep invalid function body as part of the AST

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5044-5045 @@ -5043,4 +5043,4 @@ // function template specialization, add it to the scope stack. - if (New->getDeclName() && AddToScope && - !(D.isRedeclaration() && New->isInvalidDecl())) { + if (New->getDe

Re: [PATCH] D19552: Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4

Sunil_Srivastava closed this revision. Sunil_Srivastava added a comment. Submitted as r267625. http://reviews.llvm.org/D19552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19567: PR21823: 'nodebug' attribute on global/static variables

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM on the attribute part. Someone else should pipe up if the debug info part look

[PATCH] D19567: PR21823: 'nodebug' attribute on global/static variables

probinson created this revision. probinson added reviewers: dblaikie, aprantl. probinson added a subscriber: cfe-commits. 'nodebug' on a function will currently suppress all debug info for the function and its contents. 'nodebug on a static-duration variable will currently suppress debug info for

Re: r267464 - Module Debugging: Fix the condition for determining whether a template

> On Apr 26, 2016, at 4:11 PM, Richard Smith wrote: > > On Tue, Apr 26, 2016 at 3:10 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Apr 25, 2016, at 5:34 PM, Richard Smith > > wrote: >> >> On Mon, Apr 25, 2016 at 1:52 PM, A

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

rmaprath updated this revision to Diff 55127. rmaprath added a comment. Addressing review comments from @bcraig: Adjusted according to the changes of http://reviews.llvm.org/D19412. This patch is now mostly trivial. There is a small catch in that, this version of the API takes pointer-to-point

r267633 - Module debugging: Add an assertion.

Author: adrian Date: Tue Apr 26 18:42:43 2016 New Revision: 267633 URL: http://llvm.org/viewvc/llvm-project?rev=267633&view=rev Log: Module debugging: Add an assertion. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewv

r267632 - PR27513: When determining which declaration to put into an exported lookup

Author: rsmith Date: Tue Apr 26 18:40:43 2016 New Revision: 267632 URL: http://llvm.org/viewvc/llvm-project?rev=267632&view=rev Log: PR27513: When determining which declaration to put into an exported lookup table for a module / PCH, never map from a normal declaration of a class to an injected-cl

r267630 - Module debugging: Also correctly handle typedef'd foward-declared members.

Author: adrian Date: Tue Apr 26 18:37:38 2016 New Revision: 267630 URL: http://llvm.org/viewvc/llvm-project?rev=267630&view=rev Log: Module debugging: Also correctly handle typedef'd foward-declared members. Thanks again to Richard Smith for pointing this out. Modified: cfe/trunk/lib/CodeGen/

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

rmaprath updated this revision to Diff 55119. rmaprath added a comment. Addressing review comments from @bcraig: In the earlier patch, I tried to keep the `__os_support` header to a minimum by not exposing the internal pthread dependencies (in library sources) in this header. This however blew

r267625 - Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4

Author: ssrivastava Date: Tue Apr 26 18:19:00 2016 New Revision: 267625 URL: http://llvm.org/viewvc/llvm-project?rev=267625&view=rev Log: Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4 This is an addendum to r229921. Modified: cfe/trunk/lib/Analysis/FormatString.c

Re: r267464 - Module Debugging: Fix the condition for determining whether a template

On Tue, Apr 26, 2016 at 3:10 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Apr 25, 2016, at 5:34 PM, Richard Smith wrote: > > On Mon, Apr 25, 2016 at 1:52 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: adrian >> Date: Mon Apr

[PATCH] D19565: [libc++] Fix an accidental assignment within assert() that should have been equality.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libc++] Fix an accidental assignment within assert() that should have been equality. Fixes MSVC "warning C4706: assignment within conditional expression". http://reviews.llv

Re: [PATCH] D19552: Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4

Sunil_Srivastava added a comment. I had put these 'h' test lines to test the first of my changes, and this sufficed, but you are correct. I should add %y too. I am going to add '%hr' and '%hy'. Comment at: test/Sema/format-strings-freebsd.c:39 @@ -35,1 +38,3 @@ + freebsd_kern

Re: r267464 - Module Debugging: Fix the condition for determining whether a template

> On Apr 25, 2016, at 5:34 PM, Richard Smith wrote: > > On Mon, Apr 25, 2016 at 1:52 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Mon Apr 25 15:52:40 2016 > New Revision: 267464 > > URL: http://llvm.org/viewvc/llvm-project?rev=267464&v

r267612 - Module debugging: Add testcase for member classes of class template specializations.

Author: adrian Date: Tue Apr 26 16:58:23 2016 New Revision: 267612 URL: http://llvm.org/viewvc/llvm-project?rev=267612&view=rev Log: Module debugging: Add testcase for member classes of class template specializations. Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp cfe/trunk/test/Modul

r267611 - Module debugging: Use the definition to determine module-defined types.

Author: adrian Date: Tue Apr 26 16:58:18 2016 New Revision: 267611 URL: http://llvm.org/viewvc/llvm-project?rev=267611&view=rev Log: Module debugging: Use the definition to determine module-defined types. Follow-up to r267464. Thanks to Richard Smith for pointing this out! Modified: cfe/trun

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 55103. apelete added a comment. [scan-build] fix logic error warnings emitted on clang code base Chnages since last revision: - lib/Format/Format.cpp: removed all changes, redenderd obsolete by upstream. http://reviews.llvm.org/D19385 Files: lib/AST/Dec

Re: [PATCH] D17933: Set MaxAtomicInlineWidth properly for i386, i486, and x86-64 cpus without cmpxchg16b.

jyknight added a comment. ping again. http://reviews.llvm.org/D17933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19175: Fix for PR27015 (variable template initialized with a generic lambda expression)

On Tue, Apr 26, 2016 at 1:55 PM, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ahatanak added a comment. > > I'm looking for a way to avoid the assert in > Sema::PerformDependentDiagnostics that is fired when a template parameter > doesn't have a name. > > In order to avoid

r267604 - Test commit

Author: epilk Date: Tue Apr 26 15:55:48 2016 New Revision: 267604 URL: http://llvm.org/viewvc/llvm-project?rev=267604&view=rev Log: Test commit Modified: cfe/trunk/lib/Sema/SemaStmt.cpp Modified: cfe/trunk/lib/Sema/SemaStmt.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/Sem

Re: [PATCH] D19175: Fix for PR27015 (variable template initialized with a generic lambda expression)

ahatanak added a comment. I'm looking for a way to avoid the assert in Sema::PerformDependentDiagnostics that is fired when a template parameter doesn't have a name. In order to avoid the assert, CXXRecordDecl::isDependentLambda() should return true for the old lambda class, and in order to do

r267601 - Try to get at_file_missing.c passing after LLVM r267556.

Author: nico Date: Tue Apr 26 15:40:23 2016 New Revision: 267601 URL: http://llvm.org/viewvc/llvm-project?rev=267601&view=rev Log: Try to get at_file_missing.c passing after LLVM r267556. r267556 made backslashes escape the next character unconditionally in rsp files. This test echos a path into

Re: [PATCH] D19552: Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM. Comment at: test/Sema/format-strings-freebsd.c:39 @@ -35,1 +38,3 @@ + freebsd_kernel_printf("%hr", h); // no-warning + // %y expects an int It's nice to a

Re: [PATCH] D18136: boost-use-to-string check

Prazek added a comment. Alex, if you accept this revision, please accept this also http://reviews.llvm.org/D18274 http://reviews.llvm.org/D18136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: [PATCH] D18136: boost-use-to-string check

Prazek updated this revision to Diff 55077. Prazek marked an inline comment as done. Prazek added a comment. I hope it is final http://reviews.llvm.org/D18136 Files: clang-tidy/boost/BoostTidyModule.cpp clang-tidy/boost/CMakeLists.txt clang-tidy/boost/UseToStringCheck.cpp clang-tidy/boo

Re: [PATCH] D18136: boost-use-to-string check

Prazek marked 5 inline comments as done. Comment at: clang-tidy/boost/UseToStringCheck.cpp:60 @@ +59,3 @@ + else +return; + alexfh wrote: > Please add a reduced test case for this. I don't see it crashing right now on the same test when it was crashing before

[PATCH] D19552: Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4

Sunil_Srivastava created this revision. Sunil_Srivastava added a reviewer: dim. Sunil_Srivastava added a subscriber: cfe-commits. Herald added a subscriber: emaste. This is an addendum to r229921. http://reviews.llvm.org/D19552 Files: lib/Analysis/FormatString.cpp test/Sema/format-strings-f

[clang-tools-extra] r267592 - [clang-tidy] Now adding correct misc-move-const-arg documentation ; ]

Author: alexfh Date: Tue Apr 26 14:33:49 2016 New Revision: 267592 URL: http://llvm.org/viewvc/llvm-project?rev=267592&view=rev Log: [clang-tidy] Now adding correct misc-move-const-arg documentation ;] + brushed the code a bit and renamed the test file to match the check name Added: clang-to

[libcxx] r267591 - Apparently XFAIL tests that are supposed to fail to compile can be problematic. They still get compiled, and if the compile succeeds, the buildbots complain. Replace the XFAIL with

Author: marshall Date: Tue Apr 26 14:29:35 2016 New Revision: 267591 URL: http://llvm.org/viewvc/llvm-project?rev=267591&view=rev Log: Apparently XFAIL tests that are supposed to fail to compile can be problematic. They still get compiled, and if the compile succeeds, the buildbots complain. Rep

Re: [PATCH] D19071: [OpenCL] Add predefined macros.

This revision was automatically updated to reflect the committed changes. Closed by commit rL267590: [OpenCL] Add predefined macros. (authored by yaxunl). Changed prior to commit: http://reviews.llvm.org/D19071?vs=55016&id=55066#toc Repository: rL LLVM http://reviews.llvm.org/D19071 Files:

r267590 - [OpenCL] Add predefined macros.

Author: yaxunl Date: Tue Apr 26 14:25:46 2016 New Revision: 267590 URL: http://llvm.org/viewvc/llvm-project?rev=267590&view=rev Log: [OpenCL] Add predefined macros. OpenCL spec requires __OPENCL_C_VERSION__ to be defined based on -cl-std option. This patch implements that. The patch also define

[clang-tools-extra] r267587 - [clang-tidy] Added misc-move-const-arg docs.

Author: alexfh Date: Tue Apr 26 13:48:59 2016 New Revision: 267587 URL: http://llvm.org/viewvc/llvm-project?rev=267587&view=rev Log: [clang-tidy] Added misc-move-const-arg docs. Added: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-move-const-arg.rst Modified: clang-tools-extra/trunk

r267584 - [CMake] Use just-built clang and build iOS support when building stage2

Author: cbieneman Date: Tue Apr 26 13:39:20 2016 New Revision: 267584 URL: http://llvm.org/viewvc/llvm-project?rev=267584&view=rev Log: [CMake] Use just-built clang and build iOS support when building stage2 The Apple stage2 build should include compiler-rt iOS libraries and be built with the st

Re: r267496 - [lanai] Update handling of structs in arguments to be passed in registers.

On Tue, Apr 26, 2016 at 6:49 AM, Jacques Pienaar wrote: > Thanks for fixing this. My apologies for breaking this and not noticing & > fixing it earlier. > no problem. > Is there any way to test the Windows build without a Windows machine at my > disposal? > Not that I know of. My workflow for

Re: [PATCH] D17820: Clang Code Completion Filtering

benlangmuir added a comment. Overall approach seems good to me, but this needs tests. Other feedback inline. Comment at: include/clang/Sema/CodeCompleteConsumer.h:920 @@ +919,3 @@ +CodeCompletionResult Results) { +return true; + } --

[PATCH] D19547: [clang-tidy] Add FixIt for swapping arguments in string-constructor-checker.

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. Arguments can be swapped using fixit when they are not in macros. This is the same implementation than SwappedArguments. Some code got lifted to be reused. Others checks are not safe to b

Re: [PATCH] D19299: lower __builtin_expect() directly to prof metadata instead of LLVM intrinsic

spatel abandoned this revision. spatel added a comment. Abandoning. The feedback on the dev list was that handling the builtin_expect() in clang is ugly, so it's better to pay a small cost in LLVM to do it. Note that the current llvm.expect lowering pass doesn't actually work for anything but

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

rnk updated this revision to Diff 55044. rnk added a comment. - Implement suggestions to avoid warning twice http://reviews.llvm.org/D18271 Files: include/clang/Basic/Diagnostic.h include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.

[clang-tools-extra] r267576 - [Release notes] Mention Clang-tidy misc-fold-init-type check.

Author: eugenezelenko Date: Tue Apr 26 12:54:00 2016 New Revision: 267576 URL: http://llvm.org/viewvc/llvm-project?rev=267576&view=rev Log: [Release notes] Mention Clang-tidy misc-fold-init-type check. Highlighting consistency in Clang-tidy misc-fold-init-type check documentation. Modified:

[clang-tools-extra] r267574 - [clang-tidy] New checker for redundant expressions.

Author: etienneb Date: Tue Apr 26 12:30:30 2016 New Revision: 267574 URL: http://llvm.org/viewvc/llvm-project?rev=267574&view=rev Log: [clang-tidy] New checker for redundant expressions. Summary: This checker finds redundant expression on both side of a binary operator. The current implementatio

Re: [PATCH] D19541: Fix generation of documentation for UndefinedBehaviorSanitizer.

etienneb added a comment. This got fixed. Abandoning this change. http://reviews.llvm.org/D19541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19541: Fix generation of documentation for UndefinedBehaviorSanitizer.

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. The text is mis-aligned. http://reviews.llvm.org/D19541 Files: docs/UndefinedBehaviorSanitizer.rst Index: docs/UndefinedBehaviorSanitizer.rst ==

[PATCH] D19539: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a type with a template parameter as a base class.

michael_miller created this revision. michael_miller added reviewers: hokein, aaron.ballman, alexfh. michael_miller added a subscriber: cfe-commits. Fixed a crash in cppcoreguidelines-pro-type-member-init when encountering a type that uses one of its template parameters as a base when compiling f

Re: [PATCH] D19451: [clang-tidy] New checker for redundant expressions.

etienneb added inline comments. Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:21 @@ +20,3 @@ + +static bool AreIdenticalExpr(const Expr *Left, const Expr *Right) { + if (!Left || !Right) alexfh wrote: > This is to some degree similar to comparing `llvm

Re: [PATCH] D19451: [clang-tidy] New checker for redundant expressions.

etienneb updated this revision to Diff 55028. etienneb marked 2 inline comments as done. etienneb added a comment. address alexfh comments. http://reviews.llvm.org/D19451 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/RedundantExpressionCheck.cpp

[clang-tools-extra] r267570 - [clang-tidy] Enhance misc-suspicious-string-compare to move down false-positives.

Author: etienneb Date: Tue Apr 26 11:53:21 2016 New Revision: 267570 URL: http://llvm.org/viewvc/llvm-project?rev=267570&view=rev Log: [clang-tidy] Enhance misc-suspicious-string-compare to move down false-positives. Summary: The checker was noisy when running over llvm code base. This patch is

Re: [PATCH] D19497: [clang-tidy] Enhance misc-suspicious-string-compare to move down false-positives.

etienneb updated this revision to Diff 55025. etienneb marked an inline comment as done. etienneb added a comment. address alexfh comments. http://reviews.llvm.org/D19497 Files: clang-tidy/misc/SuspiciousStringCompareCheck.cpp test/clang-tidy/misc-suspicious-string-compare.c test/clang-ti

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

sbenza added inline comments. Comment at: include/clang/AST/DeclCXX.h:1830 @@ -1829,2 +1829,3 @@ unsigned size_overridden_methods() const; + const ArrayRef overridden_methods() const; Return type should have have toplevel `const`. Comment a

[PATCH] D19536: [CodeGenObjCXX] Fix handling of blocks in lambda

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a subscriber: cfe-commits. This fixes a crash that occurs when a block nested in a c++ lambda captures a reference that is captured by the enclosing lambda. rdar://problem/18586651 http://reviews.llvm.org/D19536

[libcxx] r267567 - #include in all the regex tests, and remove all mentions of __cpluplus (use TEST_STD_VERS and/or XFAIL instead). No functional change

Author: marshall Date: Tue Apr 26 11:24:44 2016 New Revision: 267567 URL: http://llvm.org/viewvc/llvm-project?rev=267567&view=rev Log: #include in all the regex tests, and remove all mentions of __cpluplus (use TEST_STD_VERS and/or XFAIL instead). No functional change Modified: libcxx/trunk

Re: [PATCH] D18957: clang-rename: add missing newline at the end of 'found name:'

vmiklos added a comment. Thanks! Is there anything I have to do to get this actually committed or I just have to be patient? http://reviews.llvm.org/D18957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

Re: [PATCH] D19071: [OpenCL] Add predefined macros.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! http://reviews.llvm.org/D19071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D18265: [clang-tidy] New: checker misc-unconventional-assign-operator replacing misc-assign-operator-signature

sbenza added inline comments. Comment at: clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp:69 @@ +68,3 @@ +void UnconventionalAssignOperatorCheck::check(const MatchFinder::MatchResult &Result) { + if (const auto *RetStmt = Result.Nodes.getNodeAs("returnStmt")) { +diag(R

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

sbaranga added inline comments. Comment at: test/Sema/arm_vfma.c:1 @@ -1,2 +1,2 @@ -// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple thumbv7-none-eabi -target-feature +neon -target-feature +vfp4 -fsyntax-

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

sbaranga updated this revision to Diff 55018. sbaranga added a comment. Address the latest review comments (which means rolling back to the last change). http://reviews.llvm.org/D18963 Files: lib/Basic/Targets.cpp test/CodeGen/arm-neon-fma.c test/Preprocessor/arm-acle-6.5.c test/Sema/a

Re: [PATCH] D18953: [ms][dll] #26935 Defining a dllimport function should cause it to be exported

majnemer added a subscriber: majnemer. Comment at: test/SemaCXX/dllimport.cpp:179 @@ -140,1 +178,3 @@ +template +int ExternVarTmplDeclInit = 1; avt77 wrote: > rnk wrote: > > Can you check with MSVC 2015 update 2 actually does with definitions of > > dllimport

Re: [PATCH] D19451: [clang-tidy] New checker for redundant expressions.

etienneb added a comment. In http://reviews.llvm.org/D19451#412017, @alexfh wrote: > In http://reviews.llvm.org/D19451#411990, @alexfh wrote: > > > BTW, have you seen the `alpha.core.IdenticalExpr` static analyzer checker? > > > Anna, Jordan, and whoever else is interested in the > `alpha.core.I

Re: [PATCH] D19071: [OpenCL] Add predefined macros.

yaxunl updated this revision to Diff 55016. yaxunl marked 4 inline comments as done. yaxunl added a comment. Add CHECK-NOT for `__FAST_RELAXED_MATH__`. http://reviews.llvm.org/D19071 Files: lib/Frontend/CompilerInvocation.cpp lib/Frontend/InitPreprocessor.cpp test/Frontend/std.cl test/F

[PATCH] D19534: [clang-tidy] new google-default-arguments check

courbet created this revision. courbet added a reviewer: alexfh. courbet added a subscriber: cfe-commits. To check the google style guide rule here: https://google.github.io/styleguide/cppguide.html#Default_Arguments http://reviews.llvm.org/D19534 Files: clang-tidy/google/CMakeLists.txt clan

Re: [PATCH] D18953: [ms][dll] #26935 Defining a dllimport function should cause it to be exported

avt77 added a comment. It seems the latest MSVC changed the support of several features covering in this patch: more investigations needed. Comment at: test/SemaCXX/dllimport.cpp:179 @@ -140,1 +178,3 @@ +template +int ExternVarTmplDeclInit = 1; rnk wrote: >

Re: [PATCH] D19478: Remove assert mandating you can only use SPIR target with OpenCL

Anastasia added a comment. Committed in r267561! http://reviews.llvm.org/D19478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r267561 - [SPIR] Remove an assert mandating SPIR for OpenCL sources only.

Author: stulova Date: Tue Apr 26 10:14:01 2016 New Revision: 267561 URL: http://llvm.org/viewvc/llvm-project?rev=267561&view=rev Log: [SPIR] Remove an assert mandating SPIR for OpenCL sources only. SPIR target can be used for C/C++ inputs too (i.e. in OpenCL compatible mode for the libs creation

Re: [PATCH] D19220: [Concepts] Pass requires-clause to ActOnTemplateParameterList; NFC

hubert.reinterpretcast added a comment. Ping. http://reviews.llvm.org/D19220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r267560 - [OpenMP] Improve mappable expressions Sema.

Author: sfantao Date: Tue Apr 26 09:54:23 2016 New Revision: 267560 URL: http://llvm.org/viewvc/llvm-project?rev=267560&view=rev Log: [OpenMP] Improve mappable expressions Sema. Summary: This patch adds logic to save the components of mappable expressions in the clause that uses it, so that they

Re: [PATCH] D19482: [include-fixer] Add a find-all-symbols tool for include-fixer.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg with some minor comments remaining. Comment at: include-fixer/find-all-symbols/FindAllSymbols.cpp:47 @@ +46,3 @@ + const auto *RD = llvm::dyn_cast(Context); + a

Re: [PATCH] D19482: [include-fixer] Add a find-all-symbols tool for include-fixer.

hokein marked an inline comment as done. hokein added a comment. http://reviews.llvm.org/D19482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19524: [OpenCL] Fix pipe type dump.

Anastasia added a comment. Do you think we could add a test? For example similar to test/Misc/ast-dump-decl.c. We could have it for now in test/SemaOpenCL folder. http://reviews.llvm.org/D19524 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

Re: [PATCH] D19482: [include-fixer] Add a find-all-symbols tool for include-fixer.

hokein updated this revision to Diff 55003. hokein marked 3 inline comments as done. hokein added a comment. Address review comments. http://reviews.llvm.org/D19482 Files: include-fixer/CMakeLists.txt include-fixer/find-all-symbols/CMakeLists.txt include-fixer/find-all-symbols/FindAllSymb

Re: [PATCH] D19071: [OpenCL] Add predefined macros.

Anastasia added inline comments. Comment at: test/Preprocessor/predefined-macros.c:180 @@ +179,3 @@ +// CHECK-CL20: #define __OPENCL_C_VERSION__ 200 +// CHECK-FRM: #define __FAST_RELAXED_MATH__ 1 + Could we also add CHECK-NOT for all the above cases to make sure

Re: [PATCH] D17981: [clang-tidy] Fix clang-tidy to support parsing of assembly statements.

alexfh added a comment. Manuel, can you take a look at this? We need your input. http://reviews.llvm.org/D17981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19382: [OpenMP] Improve mappable expressions Sema.

sfantao updated this revision to Diff 55002. sfantao marked an inline comment as done. sfantao added a comment. - Explicitelly store canonical declaration when looking for unique declarations. http://reviews.llvm.org/D19382 Files: include/clang/AST/OpenMPClause.h lib/AST/OpenMPClause.cpp

Re: [PATCH] D19382: [OpenMP] Improve mappable expressions Sema.

sfantao marked 2 inline comments as done. sfantao added a comment. Hi Alexey, Thanks for the review. Comment at: lib/AST/OpenMPClause.cpp:546 @@ +545,3 @@ + for (auto *D : Declarations) { +assert( +(!D || D->isCanonicalDecl()) && ABataev wrote: > s

Re: [PATCH] D18300: [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in-class initializer

alexfh added a comment. In http://reviews.llvm.org/D18300#412003, @flx wrote: > I should free up again soon, just caught the flu though. Maybe next week? > Feel free to commit before then. Just tried it, and the patch doesn't apply cleanly. Leaving this to you. Repository: rL LLVM http://

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

bcraig added a subscriber: bcraig. Comment at: src/mutex.cpp:31 @@ +30,3 @@ +#else +#error "Not implemented for the selected thread API." +#endif Can't we just check for _LIBCPP_THREAD_API_PTHREAD once at the top of the file and #error as necessary there? I

Re: [PATCH] D18821: Add modernize-bool-to-integer-conversion

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. In http://reviews.llvm.org/D18821#403117, @Prazek wrote: > In http://reviews.llvm.org/D18821#402686, @Prazek wrote: > > > In http://reviews.llvm.org/D18821#398843, @alexfh wrote: > >

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

bcraig added a subscriber: bcraig. bcraig added a comment. Note: My opinion doesn't count for much as far as community acceptance goes. I'm fine with the idea. I think there is at least one significant conformance hurdle that you will need to address though. I also have some commentary on th

r267557 - Update test after LLVM r267556.

Author: nico Date: Tue Apr 26 08:54:29 2016 New Revision: 267557 URL: http://llvm.org/viewvc/llvm-project?rev=267557&view=rev Log: Update test after LLVM r267556. Modified: cfe/trunk/test/Driver/at_file.c cfe/trunk/test/Driver/at_file.c.args Modified: cfe/trunk/test/Driver/at_file.c URL:

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

alexfh added a comment. One more nit. Comment at: clang-tidy/ClangTidyOptions.h:233 @@ -200,2 +232,3 @@ - ClangTidyOptions getOptions(llvm::StringRef FileName) override; + std::vector getRawOptions( + llvm::StringRef FileName) override; clang-format? C

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one nit. Thank you for implementing this! Comment at: clang-tidy/tool/ClangTidyMain.cpp:320 @@ +319,3 @@ + if (ExplainConfig) { +std::vector +Raw

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

hokein marked an inline comment as done. hokein added a comment. http://reviews.llvm.org/D18694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r267496 - [lanai] Update handling of structs in arguments to be passed in registers.

Thanks for fixing this. My apologies for breaking this and not noticing & fixing it earlier. Is there any way to test the Windows build without a Windows machine at my disposal? On Mon, Apr 25, 2016 at 6:59 PM, Kostya Serebryany wrote: > Hopefully fixed by r267513. > > On Mon, Apr 25, 2016 at 6:

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

hokein added inline comments. Comment at: clang-tidy/ClangTidyOptions.cpp:235 @@ +234,3 @@ +if (Iter != CachedOptions.end()) { + RawOptions.push_back(Iter->second); + break; alexfh wrote: > This seems to be changing the caching logic. Consider this d

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. In http://reviews.llvm.org/D19249#408437, @chh wrote: > This change depends on http://reviews.llvm.org/D19393. I'm personally fine with the solution in http://reviews.llvm.org/D1939

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

hokein updated this revision to Diff 55001. hokein marked 8 inline comments as done. hokein added a comment. Address comments. http://reviews.llvm.org/D18694 Files: clang-tidy/ClangTidyOptions.cpp clang-tidy/ClangTidyOptions.h clang-tidy/tool/ClangTidyMain.cpp test/clang-tidy/Inputs/exp

Re: [PATCH] D19451: [clang-tidy] New checker for redundant expressions.

alexfh added a comment. In http://reviews.llvm.org/D19451#411990, @alexfh wrote: > BTW, have you seen the `alpha.core.IdenticalExpr` static analyzer checker? Anna, Jordan, and whoever else is interested in the `alpha.core.IdenticalExpr` checker (lib/StaticAnalyzer/Checkers/IdenticalExprChecker

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

sbaranga added inline comments. Comment at: lib/Basic/Targets.cpp:4710 @@ -4709,1 +4709,3 @@ const std::vector &FeaturesVec) const override { +if (CPU == "") + CPU = "generic"; rengolin wrote: > This change is unrelated and may bring sid

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

rmaprath updated this revision to Diff 54999. rmaprath added a comment. Minor cleanup + Gentle ping. http://reviews.llvm.org/D19412 Files: include/__config include/__mutex_base include/__os_support include/mutex include/thread src/algorithm.cpp src/condition_variable.cpp src/mem

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

rengolin added inline comments. Comment at: lib/Basic/Targets.cpp:4710 @@ -4709,1 +4709,3 @@ const std::vector &FeaturesVec) const override { +if (CPU == "") + CPU = "generic"; This change is unrelated and may bring side effects into cla

  1   2   >