ABataev added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:2789-2797
@@ +2788,11 @@
+// \brief Expression associated with the component.
+Expr *AssociatedExpression;
+// \brief Declaration associated with the declaration. If the component
does
+//
anemet created this revision.
anemet added reviewers: aaron.ballman, rsmith.
anemet added subscribers: hfinkel, cfe-commits.
This is similar to other loop pragmas like 'vectorize'. Currently it
only has state values: distribute(enable) and distribute(disable). When
one of these is specified the
Author: abataev
Date: Thu Apr 21 22:56:56 2016
New Revision: 267101
URL: http://llvm.org/viewvc/llvm-project?rev=267101&view=rev
Log:
[OPENMP] Fix for LCV in simd directives in explicit clauses.
If loop control variable for simd-based directives is explicitly marked
as linear/lastprivate in claus
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:696
@@ -695,1 +695,3 @@
+assert(ArgExpr && "cannot get the type of a NULL expression");
+
LGTM
http://reviews.llvm.org/D19278
___
zaks.anna added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/CMakeLists.txt:3
@@ +2,3 @@
+ -I ${CMAKE_CURRENT_SOURCE_DIR}/../../../
+ SOURCE ../../../../lib/StaticAnalyzer/Checkers/Checkers.td
+ TARGET ClangSACheckers)
srhines wrote:
> Ann
Yes, thank you very much!
vedant
> On Apr 21, 2016, at 5:43 PM, Nico Weber wrote:
>
> Does r267089 help?
>
> On Thu, Apr 21, 2016 at 5:56 PM, Vedant Kumar wrote:
> Hm, here's something weird --
>
> The test passes if I change this RUN line:
>
> // RUN: %clang_cl -Werror /Ycpchfile.h /FI
Author: eugenis
Date: Thu Apr 21 20:04:55 2016
New Revision: 267093
URL: http://llvm.org/viewvc/llvm-project?rev=267093&view=rev
Log:
Cleanup: move visibility/linkage attributes to the first declaration.
http://reviews.llvm.org/D15404
Modified:
libcxx/trunk/include/complex
libcxx/trunk/i
eugenis closed this revision.
eugenis added a comment.
r267093
Thanks for your help!
Repository:
rL LLVM
http://reviews.llvm.org/D15404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
EricWF added a comment.
Still LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D15404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Thu Apr 21 19:49:12 2016
New Revision: 267091
URL: http://llvm.org/viewvc/llvm-project?rev=267091&view=rev
Log:
Fix LWG issue #2106: move_iterators returning prvalues
Modified:
libcxx/trunk/include/iterator
libcxx/trunk/test/std/iterators/predef.iterators/move.iterat
Author: ericwf
Date: Thu Apr 21 19:47:15 2016
New Revision: 267090
URL: http://llvm.org/viewvc/llvm-project?rev=267090&view=rev
Log:
Fix C++03 build breakage
Modified:
libcxx/trunk/test/std/containers/sequences/array/array.special/swap.pass.cpp
Modified:
libcxx/trunk/test/std/containers/seq
Author: nico
Date: Thu Apr 21 19:38:09 2016
New Revision: 267089
URL: http://llvm.org/viewvc/llvm-project?rev=267089&view=rev
Log:
Try to get test passing on OS X (see comment at top of file).
Modified:
cfe/trunk/test/Driver/cl-pch.cpp
Modified: cfe/trunk/test/Driver/cl-pch.cpp
URL:
http://
Does r267089 help?
On Thu, Apr 21, 2016 at 5:56 PM, Vedant Kumar wrote:
> Hm, here's something weird --
>
> The test passes if I change this RUN line:
>
> // RUN: %clang_cl -Werror /Ycpchfile.h /FIpchfile.h /c -###
> %S/Inputs/file.prof
>
> To this:
>
> // RUN: %clang_cl -Werror /Ycpchfi
Author: chapuni
Date: Thu Apr 21 19:33:39 2016
New Revision: 267087
URL: http://llvm.org/viewvc/llvm-project?rev=267087&view=rev
Log:
clangTidyReadabilityModule: Add clangTidyUtils in libdeps, corresponding to
r267003.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/CMakeLists.txt
srhines added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/CMakeLists.txt:3
@@ +2,3 @@
+ -I ${CMAKE_CURRENT_SOURCE_DIR}/../../../
+ SOURCE ../../../../lib/StaticAnalyzer/Checkers/Checkers.td
+ TARGET ClangSACheckers)
Anna should probably d
steven_wu updated this revision to Diff 54597.
steven_wu added a comment.
Thanks Vedant!
Address all of your review in this update.
http://reviews.llvm.org/D17392
Files:
include/clang/CodeGen/BackendUtil.h
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
includ
Author: ericwf
Date: Thu Apr 21 19:15:18 2016
New Revision: 267085
URL: http://llvm.org/viewvc/llvm-project?rev=267085&view=rev
Log:
Complete LWG issue #2016. Allocators must be nothrow swappable
Modified:
libcxx/trunk/test/std/containers/associative/map/map.special/swap_noexcept.pass.cpp
vsk added a subscriber: vsk.
vsk added a comment.
Just a few nitpicks.
Comment at: lib/CodeGen/BackendUtil.cpp:785
@@ +784,3 @@
+ llvm::WriteBitcodeToFile(M, OS, /* ShouldPreserveUseListOrder */ true);
+ ModuleData = ArrayRef((uint8_t*)OS.str().data(),
+
Author: ericwf
Date: Thu Apr 21 18:38:59 2016
New Revision: 267079
URL: http://llvm.org/viewvc/llvm-project?rev=267079&view=rev
Log:
Add is_swappable/is_nothrow_swappable traits
Added:
libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_nothrow_swappable.pass.cpp
libcxx/t
Author: ericwf
Date: Thu Apr 21 18:00:33 2016
New Revision: 267076
URL: http://llvm.org/viewvc/llvm-project?rev=267076&view=rev
Log:
Make ios_base::failure visibility specified consistent
Modified:
libcxx/trunk/include/ios
Modified: libcxx/trunk/include/ios
URL:
http://llvm.org/viewvc/llvm-
Author: ericwf
Date: Thu Apr 21 17:54:21 2016
New Revision: 267074
URL: http://llvm.org/viewvc/llvm-project?rev=267074&view=rev
Log:
Fix most GCC attribute ignored warnings
Modified:
libcxx/trunk/include/__config
libcxx/trunk/include/__functional_base
libcxx/trunk/include/bitset
l
chh added a comment.
See dependent change of ClangTidy.cpp in http://reviews.llvm.org/D19393.
http://reviews.llvm.org/D19393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chh added a comment.
This change depends on http://reviews.llvm.org/D19393.
http://reviews.llvm.org/D19249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chh updated this revision to Diff 54587.
http://reviews.llvm.org/D19249
Files:
clang-tidy/ClangTidy.cpp
Index: clang-tidy/ClangTidy.cpp
===
--- clang-tidy/ClangTidy.cpp
+++ clang-tidy/ClangTidy.cpp
@@ -58,7 +58,7 @@
#define GET_C
chh created this revision.
chh added reviewers: srhines, alexfh.
chh added a subscriber: cfe-commits.
Herald added subscribers: danalbert, tberghammer.
https://llvm.org/bugs/show_bug.cgi?id=27355
To compile with other binary output directory structures in build systems like
Android.
Allow clang-t
Hm, here's something weird --
The test passes if I change this RUN line:
// RUN: %clang_cl -Werror /Ycpchfile.h /FIpchfile.h /c -###
%S/Inputs/file.prof
To this:
// RUN: %clang_cl -Werror /Ycpchfile.h /FIpchfile.h /c -###
/%S/Inputs/file.prof
The output I get with the original RUN li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267062: [CUDA] removed unneeded __nvvm_reflect_anchor()
(authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D19074?vs=53618&id=54585#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
Author: tra
Date: Thu Apr 21 16:40:27 2016
New Revision: 267062
URL: http://llvm.org/viewvc/llvm-project?rev=267062&view=rev
Log:
[CUDA] removed unneeded __nvvm_reflect_anchor()
Since r265060 LLVM infers correct __nvvm_reflect attributes, so
explicit declaration of __nvvm_reflect() is no longer n
Author: bruening
Date: Thu Apr 21 16:32:04 2016
New Revision: 267059
URL: http://llvm.org/viewvc/llvm-project?rev=267059&view=rev
Log:
[esan] EfficiencySanitizer driver flags
Summary:
Adds a framework to enable the instrumentation pass for the new
EfficiencySanitizer ("esan") family of tools. Ad
No, removing -Werror doesn't help.
What's strange is that this doesn't reproduce on my machine -- just on the bots.
I'll poke around a bit more.
vedant
> On Apr 21, 2016, at 2:08 PM, Nico Weber wrote:
>
> Does removing -Werror help? All the bots on http://lab.llvm.org:8011/console
> look hap
aaron.ballman added a comment.
This looks reasonable to me, but you should wait for @zaks.anna to sign off.
http://reviews.llvm.org/D18073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
rtrieu added a subscriber: rtrieu.
rtrieu added a comment.
Have you looked at http://reviews.llvm.org/D6561 which was a previous attempt
at this warning?
http://reviews.llvm.org/D19312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Author: rtrieu
Date: Thu Apr 21 16:04:55 2016
New Revision: 267054
URL: http://llvm.org/viewvc/llvm-project?rev=267054&view=rev
Log:
Split interesting warnings off from -Wfloat-conversion
Restructure the implict floating point to integer conversions so that
interesting sub-groups are under differ
Does removing -Werror help? All the bots on http://lab.llvm.org:8011/console
look happy.
On Thu, Apr 21, 2016 at 4:58 PM, Vedant Kumar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Nico,
>
> This seems to be causing a test failure on one of our bots:
>
>
> http://lab.llvm.org:8080/gre
Hi Nico,
This seems to be causing a test failure on one of our bots:
http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/17279/testReport/junit/Clang/Driver/cl_pch_cpp/
Command Output (stderr):
--
/Users/buildslave/jenkins/sharedspace/phase1@2/llvm/tools/clang/test/Driver/cl-pch.c
Author: nico
Date: Thu Apr 21 14:59:10 2016
New Revision: 267040
URL: http://llvm.org/viewvc/llvm-project?rev=267040&view=rev
Log:
clang-cl: Don't assert on using /Yc with non-source files, PR27450
Move phase handling after input type validation.
Modified:
cfe/trunk/lib/Driver/Driver.cpp
mgehre added a comment.
Ping
http://reviews.llvm.org/D15031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apelete created this revision.
apelete added reviewers: rjmccall, zaks.anna, rsmith.
apelete added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Fixing another set of "Logic error" warnings of the type "Called c++
object pointer is null" reported by Clang Static Analyzer on the
fol
eugenis added a comment.
This change does not affect libc++.so on Linux in any way.
Repository:
rL LLVM
http://reviews.llvm.org/D15404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
eugenis updated this revision to Diff 54562.
eugenis added a comment.
Updates with Eric's patch from
https://gist.github.com/EricWF/487e5b1de2bb320e93fbb3c9c758b013
without the iostream changes.
Repository:
rL LLVM
http://reviews.llvm.org/D15404
Files:
include/complex
include/experimenta
EricWF added a comment.
So you pointed out that my changes to the streams is not ABI compatible.
Obviously that cannot be a part of this patch then.
Repository:
rL LLVM
http://reviews.llvm.org/D15404
___
cfe-commits mailing list
cfe-commits@list
eugenis added a comment.
Yes, I'd like to try.
I think this is blocked on the changes that move visibility attributes to the
first declaration, right?
Also, re: cfi-commits thread for r255177, it appears that on Mac we can neither
hide nor expose existing methods (i.e. if something was hidden, i
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4393-4431
@@ +4392,41 @@
+/// retrieved from the provided map clause expression.
+DeclarationMapInfoEntry(const Expr *MCE, OpenMPMapClauseKind MapType,
+
I was using spec-run where the command line has the pathless filename.
The source in Atam's command-line has the absolute path.
In meta-data creation, we used Module's getSourceFileName() which has the
source name appeared in the command line (in this case, a full patch name).
While in Clang's se
xur added a comment.
I was using spec-run where the command line has the pathless filename.
The source in Atam's command-line has the absolute path.
In meta-data creation, we used Module's getSourceFileName() which has the
source name appeared in the command line (in this case, a full patch name)
steven_wu updated this revision to Diff 54559.
steven_wu added a comment.
Ping.
Rebase the patch over trunk and tweak the testcase.
http://reviews.llvm.org/D17392
Files:
include/clang/CodeGen/BackendUtil.h
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
includ
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: caomhin, cfe-commits.
This patch adds logic to save the components of mappable expressions in the
clause that uses it, so that they don't have to be recompute
EricWF added a comment.
Sorry about the long delay in reviewing this. @eugenis Are you still
able/willing to proceed with this?
Repository:
rL LLVM
http://reviews.llvm.org/D14411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
anemet added a comment.
> How did you build povray?
> can you show me your command line in building (for example, csg.cpp) for
> both--fprofile-instr-use and -fprofile-instr-generate?
Sent it in an email.
http://reviews.llvm.org/D18624
___
cfe
Author: etienneb
Date: Thu Apr 21 13:15:35 2016
New Revision: 267027
URL: http://llvm.org/viewvc/llvm-project?rev=267027&view=rev
Log:
[clang-tidy] Fix broken build bot.
Summary:
There is a build bot that doesn't support 'constexpr'.
```
FAILED: C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe /nolo
yaxunl updated this revision to Diff 54552.
yaxunl added a comment.
Revised as Anastasia suggested.
http://reviews.llvm.org/D19071
Files:
lib/Frontend/CompilerInvocation.cpp
lib/Frontend/InitPreprocessor.cpp
test/Frontend/std.cl
test/Frontend/stdlang.c
test/Preprocessor/predefined-mac
Author: eugenezelenko
Date: Thu Apr 21 13:13:09 2016
New Revision: 267026
URL: http://llvm.org/viewvc/llvm-project?rev=267026&view=rev
Log:
[Release Notes] Mention Clang-tidy misc-string-constructor and
misc-suspicious-string-compare checks.
Fix excessive line in misc-string-constructor document
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
There is a build bot that doesn't support 'constexpr'.
```
FAILED: C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe /nologo /TP /DWIN32
/D_WINDOWS /W4 -wd4141 -wd4146 -wd4180 -wd4244 -wd425
xur added a comment.
I tried http://reviews.llvm.org/D17864 and http://reviews.llvm.org/D18624 with
the latest trunk of r267006 on a clean
client.
The built compiler works fine with povray.
the meta data only has the files name.
How did you build povray?
can you show me your command line in bui
I tried D17864 and D18624 with the latest trunk of r267006 on a clean
client.
The built compiler works fine with povray.
the meta data only has the files name.
How did you build povray?
can you show me your command line in building (for example, csg.cpp) for
both--fprofile-instr-use and -fprofile
Anastasia added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:418
@@ +417,3 @@
+// A shared OpenCL header file requires a macro to indicate the language
+// standard. As a workaround, __CLANG_OPENCL_C_VERSION__ is defined for
+// OpenCL v1.0 and v1.1.
Author: etienneb
Date: Thu Apr 21 12:28:08 2016
New Revision: 267011
URL: http://llvm.org/viewvc/llvm-project?rev=267011&view=rev
Log:
[clang-tidy] New checker to detect suspicious string constructor.
Summary:
Checker to validate string constructor parameters.
A common mistake is to swap paramet
sbenza added inline comments.
Comment at: lib/AST/ASTContext.cpp:1279
@@ -1282,1 +1278,3 @@
+const ASTContext::CXXMethodVector *
+ASTContext::overridden_methods(const CXXMethodDecl *Method) const {
llvm::DenseMap::const_iterator Pos
It would be simpler to retur
etienneb updated this revision to Diff 54532.
etienneb added a comment.
rebased
http://reviews.llvm.org/D19146
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/StringConstructorCheck.cpp
clang-tidy/misc/StringConstructorCheck.h
docs/clang-tidy/c
davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D19299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: etienneb
Date: Thu Apr 21 12:19:36 2016
New Revision: 267009
URL: http://llvm.org/viewvc/llvm-project?rev=267009&view=rev
Log:
[clang-tidy] Add new checker for comparison with runtime string functions.
Summary:
This checker is validating suspicious usage of string compare functions.
Exam
etienneb updated this revision to Diff 54531.
etienneb added a comment.
fix integration
http://reviews.llvm.org/D18703
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/SuspiciousStringCompareCheck.cpp
clang-tidy/misc/SuspiciousStringCompareCheck.h
alexfh added a comment.
Now the problem is that the check changed behavior, but the tests are not
updated. Do the tests still pass? If yes, we need to add tests for this
behavior. If no, please fix the tests.
http://reviews.llvm.org/D19194
___
cfe
Kessoufi marked an inline comment as done.
Kessoufi added a comment.
Done
http://reviews.llvm.org/D19194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Kessoufi updated this revision to Diff 54524.
Kessoufi added a comment.
removed the redundant matcher
http://reviews.llvm.org/D19194
Files:
clang-tidy/modernize/PassByValueCheck.cpp
Index: clang-tidy/modernize/PassByValueCheck.cpp
=
etienneb updated this revision to Diff 54526.
etienneb marked 2 inline comments as done.
etienneb added a comment.
rebased
http://reviews.llvm.org/D18703
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/SuspiciousStringCompareCheck.cpp
clang-tidy/
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/misc/FoldInitTypeCheck.cpp:23
@@ +22,3 @@
+ // Note: Right now we check only builtin types.
+ const auto BuiltinTypeWithId = [](const char *id) {
+return hasCanon
Author: etienneb
Date: Thu Apr 21 11:57:56 2016
New Revision: 267003
URL: http://llvm.org/viewvc/llvm-project?rev=267003&view=rev
Log:
[clang-tidy] Cleanup some ast-matchers and lift some to utils.
Summary:
Little cleanup to lift-out and to remove some frequently used
ast-matchers.
Some of these
srhines added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:61
@@ -60,3 +60,3 @@
FULLNAME,
-#include "../../../lib/StaticAnalyzer/Checkers/Checkers.inc"
+#include "Checkers.inc"
#undef CHECKER
alexfh wrote:
> As it is, the change leaves almost no conte
etienneb updated this revision to Diff 54522.
etienneb added a comment.
rebased, merge: http://reviews.llvm.org/D19262
http://reviews.llvm.org/D19200
Files:
clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp
clang-tidy/misc/IncorrectRoundings.cpp
clang-tidy/misc/MacroParenthesesCheck.
faisalv added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:175
@@ -152,2 +174,3 @@
+ Expr *RequiresClause;
public:
Yuk - this entire guy (FizedSizeTemplateParameterListStorage) seems quite
fragile (dependent on object layout) - are the gains
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/ClangTidy.cpp:61
@@ -60,3 +60,3 @@
FULLNAME,
-#include "../../../lib/StaticAnalyzer/Checkers/Checkers.inc"
+#include "Checkers.inc"
#undef CHECKER
courbet updated this revision to Diff 54514.
courbet added a comment.
Regenerate doc.
http://reviews.llvm.org/D19324
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTContext.h
include/clang/AST/DeclCXX.h
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTContext.cpp
lib
courbet marked an inline comment as done.
courbet added a comment.
http://reviews.llvm.org/D19324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
courbet updated this revision to Diff 54512.
courbet marked 4 inline comments as done.
courbet added a comment.
- add overridden_methods() to CXXMethodDecl and plumbing.
- Use range-based for loop for iterating over overridden methods.
http://reviews.llvm.org/D19324
Files:
include/clang/AST/A
courbet added a comment.
Thanks !
http://reviews.llvm.org/D19362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:30
@@ +29,3 @@
+
+ Finder->addMatcher(implicitCastExpr(hasIntegerLiteralCastToBool,
+ unless(ha
On 4/21/2016 9:46 AM, Renato Golin wrote:
On 21 April 2016 at 14:58, Krzysztof Parzyszek via cfe-commits
wrote:
Same thing on Hexagon:
http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/37972
Trying to fix in r266993.
It worked! Thanks!
-Krzysztof
--
Qualcomm Innovation Center, I
alexfh added a subscriber: alexfh.
alexfh requested changes to this revision.
alexfh added a reviewer: alexfh.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/PassByValueCheck.cpp:166
@@ -150,3 +165,3 @@
hasDeclaration(cxxCo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266992: [Clang-tidy] Fix for crash in
modernize-raw-string-literal check (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D19331?vs=54401&id=54504#toc
Repository:
rL LLVM
http:
sbenza added a comment.
Thanks for doing this!
I think we want the version that iterates all parents.
Otherwise it will have problems with templates.
That is, you won't know which `FunctionDecl` you will get: the template or the
instantiation. And you might need one or the other specifically.
alexfh added a comment.
In http://reviews.llvm.org/D19201#403585, @Prazek wrote:
> Do you know guys is it possible to get to noexcept source location, or we
> have to do by hand using lexer?
If it might be possible to get the location of `noexcept(expression)` using
`FunctionProtoType::getNoE
On 21 April 2016 at 14:58, Krzysztof Parzyszek via cfe-commits
wrote:
> Same thing on Hexagon:
> http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/37972
Trying to fix in r266993.
--renato
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: rengolin
Date: Thu Apr 21 09:40:06 2016
New Revision: 266993
URL: http://llvm.org/viewvc/llvm-project?rev=266993&view=rev
Log:
[x86] Force mixes asm syntax test to check for x86
Modified:
cfe/trunk/test/CodeGen/inline-asm-mixed-style.c
Modified: cfe/trunk/test/CodeGen/inline-asm-mixe
Author: alexfh
Date: Thu Apr 21 09:39:12 2016
New Revision: 266992
URL: http://llvm.org/viewvc/llvm-project?rev=266992&view=rev
Log:
[Clang-tidy] Fix for crash in modernize-raw-string-literal check
Summary:
Clang-tidy modernize-raw-string-literal check crashes on run-time assert while
it is eval
Author: kparzysz
Date: Thu Apr 21 09:30:04 2016
New Revision: 266989
URL: http://llvm.org/viewvc/llvm-project?rev=266989&view=rev
Log:
[Hexagon] Define architecture version macros for hexagonv55
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/Preprocessor/hexagon-predefines.c
Mo
Author: aaronballman
Date: Thu Apr 21 08:51:07 2016
New Revision: 266986
URL: http://llvm.org/viewvc/llvm-project?rev=266986&view=rev
Log:
Clarify memory ownership semantics; NFC.
Patch by Clement Courbet
Modified:
cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.cpp
cfe/trunk/unittests/A
filcab added a comment.
The patch needs to get through clang-format.
Should we deal with typeid and dynamic_cast, since they're mentioned in the
same paragraph in the standard?
Comment at: lib/Sema/SemaDeclCXX.cpp:3895
@@ +3894,3 @@
+ // Check if member call is actually to
On 4/21/2016 7:49 AM, Renato Golin via cfe-commits wrote:
MS-style inline assembly is not available: No available targets are
compatible with this triple.
http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/11538
Same thing on Hexagon:
http://lab.llvm.org:8011/builders/clang-hexago
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r266986, thank you!
http://reviews.llvm.org/D19362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
courbet added a comment.
Thanks! Would you mind submitting this for me ?
http://reviews.llvm.org/D19362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! Thank you for the cleanup, this is more clear about the ownership
semantics.
http://reviews.llvm.org/D19362
___
cfe-commits
courbet created this revision.
courbet added a reviewer: aaron.ballman.
courbet added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Statically specify ownership of verifiers in tests. NFC
http://reviews.llvm.org/D19362
Files:
unittests/ASTMatchers/ASTMatchersTest.cpp
unittest
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724
@@ +3723,3 @@
+ bool Matched = false;
+ for (auto It = Node.begin_overridden_methods();
+ It != Node.end_overridden_methods(); ++It) {
courbet wrote:
> aaron.ball
courbet added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724
@@ +3723,3 @@
+ bool Matched = false;
+ for (auto It = Node.begin_overridden_methods();
+ It != Node.end_overridden_methods(); ++It) {
aaron.ballman wrote:
> Can you ra
courbet added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:2084
@@ +2083,3 @@
+ Code1, ForEachOverriddenInClass("C"),
+ new VerifyIdIsBoundTo("override", "f", 1)));
+ EXPECT_TRUE(matchAndVerifyResultTrue(
aaron.ballman wrote:
>
Author: mzuckerm
Date: Thu Apr 21 07:47:27 2016
New Revision: 266983
URL: http://llvm.org/viewvc/llvm-project?rev=266983&view=rev
Log:
[Clang][AVX512][BuiltIn] Adding intrinsics of VGATHER{DPS|DPD} ,
VPGATHER{QD|QQ|DD|DQ} and VGATHERPF{0|1}{DPS|QPS|DPD|QPD} instruction set .
Differential Revisio
baloghadamsoftware added a comment.
I will run it, once we are approaching the final version. This one is more of a
question than a real patch.
http://reviews.llvm.org/D19357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
On 21 April 2016 at 11:59, Denis Zobnin via cfe-commits
wrote:
> Author: dzobnin
> Date: Thu Apr 21 05:59:18 2016
> New Revision: 266976
>
> URL: http://llvm.org/viewvc/llvm-project?rev=266976&view=rev
> Log:
> Correctly parse GCC-style asm line following MS-style asm line.
>
> Quit parsing MS-sty
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a comment.
Please be sure to run clang\docs\tools\dump_ast_matchers.py to regenerate the
documentation as well.
http://reviews.llvm.org/D19357
___
cfe-commits mailing list
cfe-com
1 - 100 of 118 matches
Mail list logo
