This revision was automatically updated to reflect the committed changes.
Closed by commit rL265868: [Concepts] Implement subsection [dcl.spec.concept]p7
of the Concepts TS (authored by nwilson).
Changed prior to commit:
http://reviews.llvm.org/D18221?vs=53103&id=53110#toc
Repository:
rL LLV
Author: nwilson
Date: Fri Apr 8 21:55:27 2016
New Revision: 265868
URL: http://llvm.org/viewvc/llvm-project?rev=265868&view=rev
Log:
[Concepts] Implement subsection [dcl.spec.concept]p7 of the Concepts TS
Summary: A program shall not declare an explicit instantiation (14.8.2), an
explicit speci
weimingz updated this revision to Diff 53105.
weimingz added a comment.
per Alex's suggestion, split into 2 flags:
-ffile-macro-prefix-to-remove=xxx : remove matched prefix
-ffile-macro-basename-only : remove the whole dir part
http://reviews.llvm.org/D17741
Files:
include/clang/Driver/Optio
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/readability-redundant-inline.rst:6
@@ +5,3 @@
+
+This check flags redundant 'inline' specifiers.
+It flags 'inline' on member functions defined inside a class definition like
Please use `` fo
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
http://reviews.llvm.org/D18914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
nwilson updated this revision to Diff 53103.
nwilson added a comment.
- Address Aaron's comments by putting comments next to the magic numbers
http://reviews.llvm.org/D18221
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaTemplate.cpp
test/CXX/concep
mgehre created this revision.
mgehre added reviewers: sbenza, bkramer, aaron.ballman, alexfh.
mgehre added a subscriber: cfe-commits.
This check flags redundant 'inline' specifiers.
It flags 'inline' on member functions defined inside a class definition
like
.. code-block:: c++
struct S {
i
aprantl closed this revision.
aprantl marked an inline comment as done.
aprantl added a comment.
265860+265861
http://reviews.llvm.org/D18808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: cbieneman
Date: Fri Apr 8 17:48:18 2016
New Revision: 265864
URL: http://llvm.org/viewvc/llvm-project?rev=265864&view=rev
Log:
[Perf-Training] Reworked workflow improvements for order-file generation
This is re-landing r260742. I've reworked the conditionals so that it only hits
when ta
weimingz added a subscriber: weimingz.
weimingz added a comment.
Sounds good. Will do.
Thanks for reviewing
http://reviews.llvm.org/D17741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Sounds good. Will do.
Thanks for reviewing
On 4/8/2016 11:46 AM, Alex Rosenberg wrote:
alexr added a subscriber: alexr.
alexr added a comment.
There are multiple features in this patch that should be considered separately.
Please split the patch.
That said, I don't think we want to add a fun
Author: adrian
Date: Fri Apr 8 17:43:06 2016
New Revision: 265862
URL: http://llvm.org/viewvc/llvm-project?rev=265862&view=rev
Log:
Use NoDebug compile units to mark debug metadata used only for sample-based
profiling and optimization remarks and indicate that no debug info shall
be emitted for t
mgehre updated this revision to Diff 53097.
mgehre added a comment.
Update for renaming in http://reviews.llvm.org/D15031
http://reviews.llvm.org/D15032
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguidel
Author: rsmith
Date: Fri Apr 8 16:54:32 2016
New Revision: 265857
URL: http://llvm.org/viewvc/llvm-project?rev=265857&view=rev
Log:
Remove unused functions from ASTWriter interface.
Modified:
cfe/trunk/include/clang/Serialization/ASTWriter.h
cfe/trunk/lib/Serialization/ASTWriter.cpp
Mod
Author: ericwf
Date: Fri Apr 8 16:52:32 2016
New Revision: 265856
URL: http://llvm.org/viewvc/llvm-project?rev=265856&view=rev
Log:
Update filesystem status
Modified:
libcxx/trunk/www/ts1z_status.html
Modified: libcxx/trunk/www/ts1z_status.html
URL:
http://llvm.org/viewvc/llvm-project/libc
mgehre updated this revision to Diff 53092.
mgehre added a comment.
Fix assert in LocalScope::const_iterator::distance when using goto to jump over
trivially constructable variable declarations
Added two test cases for this
http://reviews.llvm.org/D15031
Files:
include/clang/Analysis/Analysi
djasper added inline comments.
Comment at: include/clang/Format/Format.h:769
@@ -768,1 +768,3 @@
+/// \brief Returns the replacements corresponding to applying and fixing
+/// \p Replaces.
I am actually not sure that fixReplacements is the right terminology here
Author: rsmith
Date: Fri Apr 8 15:53:26 2016
New Revision: 265848
URL: http://llvm.org/viewvc/llvm-project?rev=265848&view=rev
Log:
PR25501: Delay loading visible updates for a declaration until after we've
processed update records. If an update record adds a definition, we need to
merge that wit
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good, thanks! Sorry for the delays/mthanks for the chat on IRC (summary:
no worse than what we have today, more explicit, maybe we can find an
alternative and/or more compact represe
Author: kromanova
Date: Fri Apr 8 15:45:48 2016
New Revision: 265844
URL: http://llvm.org/viewvc/llvm-project?rev=265844&view=rev
Log:
Add doxygen comments to emmintrin.h's intrinsics. Only around 25% of the
intrinsics in this file are documented now. The patches for the rest of the
intrisics i
echristo added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2371
@@ +2370,3 @@
+
+Not all targets support this attribute. ELF targets support this attribute
when using binutils v2.20.1 or higher and glibc v2.11.1 or higher. Non-ELF
targets currently do not supp
probinson added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2371
@@ +2370,3 @@
+
+Not all targets support this attribute. ELF targets support this attribute
when using binutils v2.20.1 or higher and glibc v2.11.1 or higher. Non-ELF
targets currently do not sup
Author: dcoughlin
Date: Fri Apr 8 14:59:16 2016
New Revision: 265839
URL: http://llvm.org/viewvc/llvm-project?rev=265839&view=rev
Log:
[analyzer] Teach trackNullOrUndefValue about calls to property accessors.
Teach trackNullOrUndefValue() how to look through PseudoObjectExprs to find
the underly
echristo added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2371
@@ +2370,3 @@
+
+Not all targets support this attribute. ELF targets support this attribute
when using binutils v2.20.1 or higher and glibc v2.11.1 or higher. Non-ELF
targets currently do not supp
Author: rsmith
Date: Fri Apr 8 14:57:40 2016
New Revision: 265838
URL: http://llvm.org/viewvc/llvm-project?rev=265838&view=rev
Log:
[modules] Handle merged fields in designated initializers.
Modified:
cfe/trunk/lib/Sema/SemaInit.cpp
cfe/trunk/test/Modules/Inputs/merge-decl-context/a.h
jyknight added a comment.
ping.
http://reviews.llvm.org/D17933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexr added a subscriber: alexr.
alexr added a comment.
There are multiple features in this patch that should be considered separately.
Please split the patch.
That said, I don't think we want to add a fundamental new preprocessor feature
like __FILE_BASENAME__ without at least getting some ear
On Fri, Apr 8, 2016, 10:45 AM Paul Robinson <
paul_robin...@playstation.sony.com> wrote:
> probinson added inline comments.
>
>
> Comment at: include/clang/Basic/AttrDocs.td:2371
> @@ +2370,3 @@
> +
> +Not all targets support this attribute. ELF targets support this
> attribute w
Author: wmi
Date: Fri Apr 8 12:42:32 2016
New Revision: 265816
URL: http://llvm.org/viewvc/llvm-project?rev=265816&view=rev
Log:
Always have clang pass -pie-level and -pic-level values to the code generator.
Patch by tmsriram!
Differential Revision: http://reviews.llvm.org/D18843
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265816: Always have clang pass -pie-level and -pic-level
values to the code generator. (authored by wmi).
Changed prior to commit:
http://reviews.llvm.org/D18843?vs=52945&id=53038#toc
Repository:
rL
probinson added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2371
@@ +2370,3 @@
+
+Not all targets support this attribute. ELF targets support this attribute
when using binutils v2.20.1 or higher and glibc v2.11.1 or higher. Non-ELF
targets currently do not sup
Author: eugenezelenko
Date: Fri Apr 8 12:21:27 2016
New Revision: 265813
URL: http://llvm.org/viewvc/llvm-project?rev=265813&view=rev
Log:
[Release Notes] Sort checks alphabetically.
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/trunk/docs/ReleaseNotes.
rnk added inline comments.
Comment at: test/SemaCXX/MicrosoftExtensions.cpp:89
@@ -84,1 +88,3 @@
+void foo_unaligned(int arg) {}
+void foo_unaligned(__unaligned int *arg) {}
Surely we can come up with some tougher overloading test cases. I noticed MSVC
generate
Author: compnerd
Date: Fri Apr 8 11:52:05 2016
New Revision: 265807
URL: http://llvm.org/viewvc/llvm-project?rev=265807&view=rev
Log:
Move EABIVersion from CodeGenOptions to TargetOptions
It is possible to argue that the EABIVersion field is similar in spirit to the
ABI field in TargetOptions.
d.zobnin.bugzilla added a comment.
Friendly ping, please take a look.
Thank you,
Denis Zobnin
http://reviews.llvm.org/D18657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
andreybokhanko updated this revision to Diff 53022.
andreybokhanko added a comment.
This patch implements "__unaligned" as a qualifier (as per David Majnemer's
request).
Most of the changes are miscellaneous small stuff one has to add when adding a
new qualifier.
Other notable things are:
- O
joerg added a subscriber: joerg.
Comment at: include/clang/Basic/AttrDocs.td:2066
@@ -2065,3 +2065,3 @@
let Content = [{
Clang supports the GNU style ``__attribute__((interrupt))`` attribute on
x86/x86-64 targets.The compiler generates function entry and exit sequences
--
bader added a comment.
In http://reviews.llvm.org/D17821#394708, @bader wrote:
> In http://reviews.llvm.org/D17821#394620, @Anastasia wrote:
>
> > Yes, I think it's better to go in a separate commit, not to complicate this
> > one too much. Also since there are not many comment here, I think we
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265783: [OpenCL] Complete image types support. (authored by
bader).
Changed prior to commit:
http://reviews.llvm.org/D17821?vs=51303&id=53021#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17821
Author: bader
Date: Fri Apr 8 08:40:33 2016
New Revision: 265783
URL: http://llvm.org/viewvc/llvm-project?rev=265783&view=rev
Log:
[OpenCL] Complete image types support.
I. Current implementation of images is not conformant to spec in the following
points:
1. It makes no distinction with resp
Author: aaronballman
Date: Fri Apr 8 07:21:58 2016
New Revision: 265782
URL: http://llvm.org/viewvc/llvm-project?rev=265782&view=rev
Log:
Silencing a 32-bit shift implicit conversion warning from MSVC; NFC.
Modified:
cfe/trunk/lib/CodeGen/SwiftCallingConv.cpp
Modified: cfe/trunk/lib/CodeGen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265774: [clang-tidy]
cppcoreguidelines-interfaces-global-init (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D18649?vs=53001&id=53010#toc
Repository:
rL LLVM
http://reviews.l
Author: alexfh
Date: Fri Apr 8 04:51:06 2016
New Revision: 265774
URL: http://llvm.org/viewvc/llvm-project?rev=265774&view=rev
Log:
[clang-tidy] cppcoreguidelines-interfaces-global-init
Summary:
This check flags initializers of globals that access extern objects, and
therefore can lead to order
courbet added a comment.
That'd be great. Thanks all for the review.
http://reviews.llvm.org/D18649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
courbet updated this revision to Diff 53001.
courbet added a comment.
Rebase on HEAD for submission.
http://reviews.llvm.org/D18649
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguidelines/InterfacesGlobal
michael_miller marked 4 inline comments as done.
michael_miller added a comment.
In http://reviews.llvm.org/D18584#395208, @alexfh wrote:
> Looks good from my side. Please wait for the Aaron's approval.
>
> Thank you for working on this!
No problem! Thanks for taking the time to review and give
alexfh added a comment.
(if you do, please rebase the patch on top of HEAD)
http://reviews.llvm.org/D18649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good! Thank you for the new check!
Do you need me to submit the patch for you?
http://reviews.llvm.org/D18649
___
cfe-commits mailing list
alexfh accepted this revision.
alexfh added a comment.
Looks good from my side. Please wait for the Aaron's approval.
Thank you for working on this!
http://reviews.llvm.org/D18584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
courbet added inline comments.
Comment at: test/clang-tidy/cppcoreguidelines-interfaces-global-init.cpp:7
@@ +6,3 @@
+
+extern int ExternGlobal;
+static int GlobalScopeBadInit1 = ExternGlobal;
alexfh wrote:
> What happens if you add:
>
> extern int ExternGlobal
courbet updated this revision to Diff 52999.
courbet added a comment.
Add unit test for multiple declaration then definition.
http://reviews.llvm.org/D18649
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoregu
curdeius added a subscriber: curdeius.
curdeius added a comment.
Minor remark.
Comment at: docs/clang-tidy/checks/list.rst:7
@@ -6,2 +6,3 @@
.. toctree::
+ boost-use-to-string
cert-dcl03-c (redirects to misc-static-assert)
toctree directive needs the
52 matches
Mail list logo
