ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D17019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Is it possible to test this?
On Mar 2, 2016 6:26 PM, "Sean Callanan via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: spyffe
> Date: Wed Mar 2 20:22:05 2016
> New Revision: 262576
>
> URL: http://llvm.org/viewvc/llvm-project?rev=262576&view=rev
> Log:
> Caught and fixed a typo in r2
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:9071
@@ +9070,3 @@
+/// 0 if it is inconclusive.
+static int CheckArrayExpressionReferToWholeSize(Sema &SemaRef, const Expr *E,
+QualType BaseQTy) {
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:49-51
@@ -48,2 +48,5 @@
TargetRegion,
+/// \brief Region that do not require function outlining and uses
+/// information from a inner scope.
+InlinedInnerReg
sfantao updated this revision to Diff 49712.
sfantao marked 4 inline comments as done.
sfantao added a comment.
- Remove InnerInlineRegion Kind. Improve comments and other two minor edits.
http://reviews.llvm.org/D17019
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGStmtOpenMP.cpp
t
Author: rjmccall
Date: Thu Mar 3 00:39:32 2016
New Revision: 262587
URL: http://llvm.org/viewvc/llvm-project?rev=262587&view=rev
Log:
Semantic analysis for the swiftcall calling convention.
I've tried to keep the infrastructure behind parameter ABI
treatments fairly general.
Added:
cfe/trun
ariccio added a comment.
Hmm. This seems to be because `wchar_t` is enabled by `-fms-compatibility`.
@aaron.ballman do you have any idea how to define `wchar_t` without
`-fms-compatibility`?
http://reviews.llvm.org/D17688
___
cfe-commits mailing l
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:49-51
@@ -48,2 +48,5 @@
TargetRegion,
+/// \brief Region that do not require function outlining and uses
+/// information from a inner scope.
+InlinedInnerRegion,
};
Do
sfantao updated this revision to Diff 49709.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Allow array expressions whose memory contiguous checks are inconclusive.
- Add C test to check the constant expressions no longer can prove bounds in
array sections.
http://reviews.
sfantao added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7787-7789
@@ -7786,5 +7786,5 @@
"bit fields cannot be used to specify storage in a map clause">;
-def err_omp_array_section_in_rightmost_expression : Error<
- "array section can only be assoc
Author: akirtzidis
Date: Wed Mar 2 23:33:48 2016
New Revision: 262583
URL: http://llvm.org/viewvc/llvm-project?rev=262583&view=rev
Log:
[test] Re-enable asan on the test, stack usage should be lower.
Modified:
cfe/trunk/test/Index/index-many-logical-ops.c
Modified: cfe/trunk/test/Index/inde
Author: akirtzidis
Date: Wed Mar 2 23:33:54 2016
New Revision: 262584
URL: http://llvm.org/viewvc/llvm-project?rev=262584&view=rev
Log:
[index] Report references of ObjC super class/protocols in interfaces and
protocols.
Modified:
cfe/trunk/lib/Index/IndexDecl.cpp
cfe/trunk/test/Index/C
Author: abataev
Date: Wed Mar 2 23:21:39 2016
New Revision: 262582
URL: http://llvm.org/viewvc/llvm-project?rev=262582&view=rev
Log:
[OPENMP 4.0] Initial support for 'omp declare reduction' construct.
Add parsing, sema analysis and serialization/deserialization for 'declare
reduction' construct
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262582: [OPENMP 4.0] Initial support for 'omp declare
reduction' construct. (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D11182?vs=45149&id=49707#toc
Repository:
rL LLVM
h
Author: abataev
Date: Wed Mar 2 21:52:24 2016
New Revision: 262578
URL: http://llvm.org/viewvc/llvm-project?rev=262578&view=rev
Log:
[OPENMP 4.5] Initial support for data members in 'linear' clause.
OpenMP 4.5 allows to privatize data members of current class in member
functions. Patch adds init
I will talk to someone about this tomorrow to see if I can get a
better feel, thank you for the reminder.
~Aaron
On Wed, Mar 2, 2016 at 8:44 PM, Reid Kleckner via cfe-commits
wrote:
> rnk accepted this revision.
> rnk added a comment.
> This revision is now accepted and ready to land.
>
> lgtm
>
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Sorry for the delay, LGTM
Comment at: lib/Sema/SemaExpr.cpp:377
@@ +376,3 @@
+ auto *DRD = dyn_cast(CurContext);
+ if ((LangOpts.OpenMP != 0u) && (DRD != nullptr) &&
+
Author: spyffe
Date: Wed Mar 2 20:22:05 2016
New Revision: 262576
URL: http://llvm.org/viewvc/llvm-project?rev=262576&view=rev
Log:
Caught and fixed a typo in r262572.
I should have checked and imported D's in-class initializer.
Instead I accidentally used ToField's in-class initializer,
which i
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D17444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added a comment.
The second: you should not update the diff. When a patch is uploaded, the
assumption is that all tests pass:)
http://reviews.llvm.org/D17688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: spyffe
Date: Wed Mar 2 19:21:28 2016
New Revision: 262572
URL: http://llvm.org/viewvc/llvm-project?rev=262572&view=rev
Log:
Fixed a problem where the ASTImporter mishandled in-class initializers.
Previously, the ASTImporter, when copying a FieldDecl, would make the
new FieldDecl use the
ariccio added a comment.
In http://reviews.llvm.org/D17688#366883, @zaks.anna wrote:
> Please, do not submit patches for review before they pass all tests.
Whoops, sorry. Should I been a bit clearer that check-all hadn't finished when
I updated the diff, or should I not update the diff at all
jpienaar updated this revision to Diff 49688.
jpienaar added a comment.
Removed unused variables in LanaiTargetInfo.
http://reviews.llvm.org/D17002
Files:
lib/Basic/Targets.cpp
lib/CodeGen/TargetInfo.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.cpp
lib/Driver/T
Author: kromanova
Date: Wed Mar 2 18:20:11 2016
New Revision: 262565
URL: http://llvm.org/viewvc/llvm-project?rev=262565&view=rev
Log:
This patch adds doxygen comments for all the intrinsincs in the header file
tmmintrin.h.
The doxygen comments are automatically generated based on Sony's intrin
Author: hans
Date: Wed Mar 2 18:19:35 2016
New Revision: 262564
URL: http://llvm.org/viewvc/llvm-project?rev=262564&view=rev
Log:
Creating release candidate final from release_380 branch
Added:
libunwind/tags/RELEASE_380/final/
- copied from r262563, libunwind/branches/release_38/
___
Author: hans
Date: Wed Mar 2 18:19:17 2016
New Revision: 262558
URL: http://llvm.org/viewvc/llvm-project?rev=262558&view=rev
Log:
Creating release candidate final from release_380 branch
Added:
libcxxabi/tags/RELEASE_380/final/ (props changed)
- copied from r262557, libcxxabi/branche
Author: hans
Date: Wed Mar 2 18:19:14 2016
New Revision: 262557
URL: http://llvm.org/viewvc/llvm-project?rev=262557&view=rev
Log:
Creating release candidate final from release_380 branch
Added:
libcxx/tags/RELEASE_380/final/ (props changed)
- copied from r262556, libcxx/branches/rele
Author: nico
Date: Wed Mar 2 18:17:35 2016
New Revision: 262552
URL: http://llvm.org/viewvc/llvm-project?rev=262552&view=rev
Log:
Serialize `pragma pointers_to_members` state.
Like r262539, but for pointers_to_members.
Added:
cfe/trunk/test/PCH/pragma-pointers_to_members.cpp
Modified:
c
zaks.anna added a comment.
Please, do not submit patches for review before they pass all tests.
http://reviews.llvm.org/D17688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added a comment.
Generate a preprocessed file and keep copying the definitions from there until
you reach the types compiler knows about.
http://reviews.llvm.org/D17688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
Author: rjmccall
Date: Wed Mar 2 18:10:03 2016
New Revision: 262551
URL: http://llvm.org/viewvc/llvm-project?rev=262551&view=rev
Log:
Improve some infrastructure for extended parameter infos and
fix a bug with the instantiation of ns_consumed parameter
attributes in ARC.
Modified:
cfe/trunk/
ariccio added a comment.
Hmm, check-all produced a number of issues, which I think stem from the
following warning:
File C:\LLVM\llvm\tools\clang\test\Analysis\malloc.c Line 16: unknown type
name 'wchar_t'
(with a bunch of instances of that)
...so how do I declare/define `wchar_t` properly?
Ok, gave that a try in r262541.
On Wed, Mar 2, 2016 at 1:20 PM, Daniel Jasper wrote:
> Feel free to change. I have no idea what I am doing here.
>
> On Wed, Mar 2, 2016 at 12:55 PM, Nico Weber wrote:
>
>> (A different fix would've been to just add /Fp%.pch to set the output
>> path to be not ne
Author: nico
Date: Wed Mar 2 17:29:29 2016
New Revision: 262541
URL: http://llvm.org/viewvc/llvm-project?rev=262541&view=rev
Log:
clang-cl pch test: Instead of copying the input, use /Fp to not write into the
test directory.
Also fix a bug with /Fp and absolute paths uncovered by this.
Follow-u
Author: nico
Date: Wed Mar 2 17:22:00 2016
New Revision: 262539
URL: http://llvm.org/viewvc/llvm-project?rev=262539&view=rev
Log:
Serialize `pragma ms_struct` state.
pragma ms_struct has an effect on struct decls, and the effect is serialized
correctly already. But the "is ms_struct currently o
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
I can commit this in your behalf.
http://reviews.llvm.org/D17688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
ariccio updated this revision to Diff 49674.
ariccio added a comment.
Added newly checked variants to the malloc checks.
(Running the check-all suite now, will update with results)
http://reviews.llvm.org/D17688
Files:
llvm/tools/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
llvm/too
ariccio added a comment.
In http://reviews.llvm.org/D17688#366011, @ariccio wrote:
> In http://reviews.llvm.org/D17688#365951, @zaks.anna wrote:
>
> > ls ./clang/test/Analysis/malloc*
>
>
> Ah, ok. Would it be ok if (for _strdup & _alloca) I just do this at the
> beginning:
>
> #if defined(_WI
djasper closed this revision.
djasper added a comment.
Submitted as r262534.
http://reviews.llvm.org/D17385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Wed Mar 2 16:44:03 2016
New Revision: 262534
URL: http://llvm.org/viewvc/llvm-project?rev=262534&view=rev
Log:
clang-format: [JS] Optionally re-quote string literals.
Turns "foo" into 'foo' (or vice versa, depending on configuration).
This makes it more convenient to follow
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: lib/Format/Format.cpp:1140
@@ +1139,3 @@
+
+ void insertReplacement(SourceLocation Start, unsigned Length,
+ StringRef Repla
Author: dcoughlin
Date: Wed Mar 2 16:01:03 2016
New Revision: 262526
URL: http://llvm.org/viewvc/llvm-project?rev=262526&view=rev
Log:
[analyzer] Move ObjCSuperDeallocChecker out of the alpha package.
It will now be on by default on Darwin.
rdar://problem/6953275
Modified:
cfe/trunk/lib/St
Author: dcoughlin
Date: Wed Mar 2 15:50:54 2016
New Revision: 262524
URL: http://llvm.org/viewvc/llvm-project?rev=262524&view=rev
Log:
[analyzer] Move ObjCDeallocChecker out of the alpha package.
It will now be on by default on Darwin.
rdar://problem/6927496
Modified:
cfe/trunk/lib/StaticA
Author: dcoughlin
Date: Wed Mar 2 15:22:48 2016
New Revision: 262520
URL: http://llvm.org/viewvc/llvm-project?rev=262520&view=rev
Log:
[analyzer] Fix capitalization in ObjCSuperDeallocChecker diagnostic.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp
cfe/trun
On Wed, Mar 2, 2016 at 4:14 PM, Julian Bangert wrote:
> Here is a patch to SVN with the requested changes (documentation, renamed
> and added to registry):
LGTM!
~Aaron
>
> Index: docs/LibASTMatchersReference.html
> ===
> --- docs/
Here is a patch to SVN with the requested changes (documentation, renamed
and added to registry):
Index: docs/LibASTMatchersReference.html
===
--- docs/LibASTMatchersReference.html (revision 262512)
+++ docs/LibASTMatchersReference.ht
In case my MUA messed up the formatting, see the attached
On Wed, Mar 2, 2016 at 1:14 PM Julian Bangert wrote:
> Here is a patch to SVN with the requested changes (documentation, renamed
> and added to registry):
>
> Index: docs/LibASTMatchersReference.html
>
Feel free to change. I have no idea what I am doing here.
On Wed, Mar 2, 2016 at 12:55 PM, Nico Weber wrote:
> (A different fix would've been to just add /Fp%.pch to set the output path
> to be not next to the inputs.)
>
> On Wed, Mar 2, 2016 at 6:27 AM, Daniel Jasper via cfe-commits <
> cfe-com
Author: tra
Date: Wed Mar 2 15:03:20 2016
New Revision: 262516
URL: http://llvm.org/viewvc/llvm-project?rev=262516&view=rev
Log:
Fixed test failure platforms with name mangling different from Linux.
* Run cc with -triple x86_64-linux-gnu to make symbol mangling predictable.
* Use temporary file a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262515: [PGO] Change profile use cc1 option to handle IR
level profiles (authored by xur).
Changed prior to commit:
http://reviews.llvm.org/D17737?vs=49655&id=49664#toc
Repository:
rL LLVM
http://re
Author: xur
Date: Wed Mar 2 14:59:36 2016
New Revision: 262515
URL: http://llvm.org/viewvc/llvm-project?rev=262515&view=rev
Log:
[PGO] Change profile use cc1 option to handle IR level profiles
This patch changes cc1 option for PGO profile use from
-fprofile-instr-use= to -fprofile-instrument-use
Thanks!
On Wed, Mar 2, 2016 at 6:27 AM, Daniel Jasper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: djasper
> Date: Wed Mar 2 08:26:59 2016
> New Revision: 262487
>
> URL: http://llvm.org/viewvc/llvm-project?rev=262487&view=rev
> Log:
> test/Driver/cl-pch-errorhandling.cpp: Copy
(A different fix would've been to just add /Fp%.pch to set the output path
to be not next to the inputs.)
On Wed, Mar 2, 2016 at 6:27 AM, Daniel Jasper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: djasper
> Date: Wed Mar 2 08:26:59 2016
> New Revision: 262487
>
> URL: http://ll
erik.pilkington added a comment.
Ping!
http://reviews.llvm.org/D17451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Wed, Mar 2, 2016 at 12:06 PM, Aaron Ballman via cfe-commits
wrote:
> On Wed, Mar 2, 2016 at 2:01 PM, Julian Bangert via cfe-commits
> wrote:
>> This adds a matcher for C++ in Class initializers.
>>
>> ---
>> include/clang/ASTMatchers/ASTMatchers.h | 14 ++
>> unittests/ASTMatche
On Wed, Mar 2, 2016 at 2:01 PM, Julian Bangert via cfe-commits
wrote:
> This adds a matcher for C++ in Class initializers.
>
> ---
> include/clang/ASTMatchers/ASTMatchers.h | 14 ++
> unittests/ASTMatchers/ASTMatchersTest.cpp | 7 +++
> 2 files changed, 21 insertions(+)
>
> dif
LegalizeAdulthood added a comment.
I need to update from review comments and upload a new diff.
http://reviews.llvm.org/D7982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
akyrtzi added a comment.
In http://reviews.llvm.org/D17820#366638, @milianw wrote:
> But, we currently always request code completion at a word start boundary so
> nothing would change for us. That said, I see how this patch could be seen as
> a breaking behavior change, and thus should probabl
kzhuravl-AMD updated this revision to Diff 49652.
kzhuravl-AMD added a comment.
Review Feedback - Updated diff
http://reviews.llvm.org/D17764
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
li
milianw added a comment.
@akyrtzi raises a very valid point - I did not think about that. KDevelop uses
the clang-c API and does fuzzy matching on top of the results, e.g. for
camel-case matching. But, we currently always request code completion at a word
start boundary so nothing would change
kzhuravl-AMD marked 10 inline comments as done.
kzhuravl-AMD added a comment.
Review Feedback
Comment at: include/clang/Basic/Attr.td:993-998
@@ +992,8 @@
+
+def AMDGPUToolsInsertNops : InheritableAttr {
+ let Spellings = [GNU<"amdgpu_tools_insert_nops">];
+ let Documentation
milianw added a subscriber: milianw.
milianw added a comment.
I'm not yet acquainted enough with the code at hand, but I wonder whether I'm
understanding the code correctly:
Could it be that you only filter before printing to the output stream? The
other consumers, e.g. the one used by the clan
This adds a matcher for C++ in Class initializers.
---
include/clang/ASTMatchers/ASTMatchers.h | 14 ++
unittests/ASTMatchers/ASTMatchersTest.cpp | 7 +++
2 files changed, 21 insertions(+)
diff --git a/include/clang/ASTMatchers/ASTMatchers.h
b/include/clang/ASTMatchers/ASTMatc
akyrtzi added a comment.
We should not bake-in filtering into the clang CodeComplete API. What kind of
filtering to use should be on a higher level, different clients may want
different filtering, e.g. prefix filtering, fuzzy filtering, etc.
Repository:
rL LLVM
http://reviews.llvm.org/D1782
davidxl accepted this revision.
davidxl added a comment.
lgtm
http://reviews.llvm.org/D17737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Wed Mar 2 13:38:24 2016
New Revision: 262508
URL: http://llvm.org/viewvc/llvm-project?rev=262508&view=rev
Log:
fix test from r262506
Modified:
cfe/trunk/test/PCH/pragma-detect_mismatch.c
Modified: cfe/trunk/test/PCH/pragma-detect_mismatch.c
URL:
http://llvm.org/viewvc/ll
xur updated this revision to Diff 49655.
xur added a comment.
Integrated with Sean's review comments.
-Rong
http://reviews.llvm.org/D17737
Files:
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
include/clang/Frontend/CodeGenO
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Sorry, I've been waffling on this, but I think this is fine.
Thanks!
-eric
http://reviews.llvm.org/D17183
___
cfe-commits mailing list
cfe-
thakis added a comment.
Also landed a very similar change for the very similar detect_mismatch pragma
in r262506. (The other missing serialized pragmas will use a different
approach.)
http://reviews.llvm.org/D17799
___
cfe-commits mailing list
cfe
Author: nico
Date: Wed Mar 2 13:28:54 2016
New Revision: 262506
URL: http://llvm.org/viewvc/llvm-project?rev=262506&view=rev
Log:
Serialize `#pragma detect_mismatch`.
This is like r262493, but for pragma detect_mismatch instead of pragma comment.
The two pragmas have similar behavior, so use the
Author: kcc
Date: Wed Mar 2 13:16:54 2016
New Revision: 262503
URL: http://llvm.org/viewvc/llvm-project?rev=262503&view=rev
Log:
[libFuzzer] allow -fsanitize-coverage=0 (disables all coverage)
Modified:
cfe/trunk/lib/Driver/SanitizerArgs.cpp
cfe/trunk/test/Driver/fsanitize-coverage.c
Mo
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:256-296
@@ -255,26 +255,43 @@
/// \brief RAII for emitting code of OpenMP constructs.
class InlinedOpenMPRegionRAII {
CodeGenFunction &CGF;
+ /// \brief Saves the varaibles that were forced to be loca
sfantao updated this revision to Diff 49653.
sfantao added a comment.
Use new innermost scope API for the emission of the num_teams and thread_limit
expressions.
http://reviews.llvm.org/D17019
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/teams_codegen.c
Anastasia updated this revision to Diff 49651.
Anastasia added a comment.
Improved message text!
http://reviews.llvm.org/D17345
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/Parser/opencl-storage-class.cl
test/SemaOpenCL/storageclass-cl20.cl
test/SemaOpe
silvas added a comment.
I agree, David's suggestion has simplified things. This LGTM (with a couple
nits) but I'll let David give the final approval.
Comment at: lib/CodeGen/CodeGenModule.cpp:153
@@ +152,3 @@
+ if (CodeGenOpts.hasProfileClangUse()) {
+assert(!CodeGenOpts.P
benlangmuir added a comment.
This LGTM, but I would like Richard to take a look too.
http://reviews.llvm.org/D17299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe abandoned this revision.
jbcoe added a comment.
rendered obsolete by http://reviews.llvm.org/D17811
Repository:
rL LLVM
http://reviews.llvm.org/D17772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
On Wed, Mar 2, 2016 at 10:36 AM, Benjamin Kramer
wrote:
> In theory yes, in practice that needs a bit of build system tweaking
> to either build clang-tidy into clang or as a shared library. Then it
> can be used like any regular Clang plugin.
>
I haven't looked at this patch in detail - soundds
xur updated this revision to Diff 49647.
xur marked an inline comment as done.
xur added a comment.
I think David's suggestion to use one cc1 option -fprofile-instrument-use-path
is a very good idea.
I update the patch to get rid of -fprofille-instrument-use.
The profile kind is now set by check
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262499: [CUDA] Do not generate unnecessary runtime init
code. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D17780?vs=49539&id=49646#toc
Repository:
rL LLVM
http://reviews.llvm
In theory yes, in practice that needs a bit of build system tweaking
to either build clang-tidy into clang or as a shared library. Then it
can be used like any regular Clang plugin.
It will also slow down clang significantly, but I consider that a bug ;)
On Wed, Mar 2, 2016 at 6:21 PM, David Blai
vsk added a comment.
Gentle ping.
For context, we've had a few situations where corrupt pch files trigger
surprising assertion failures in our world builds.
http://reviews.llvm.org/D17299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262498: [CUDA] Emit host-side 'shadows' for device-side
global variables (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D17779?vs=49561&id=49645#toc
Repository:
rL LLVM
http://r
Author: tra
Date: Wed Mar 2 12:28:50 2016
New Revision: 262498
URL: http://llvm.org/viewvc/llvm-project?rev=262498&view=rev
Log:
[CUDA] Emit host-side 'shadows' for device-side global variables
... and register them with CUDA runtime.
This is needed for commonly used cudaMemcpy*() APIs that use
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Does it make http://reviews.llvm.org/D17772 obsolete?
http://reviews.llvm.org/D17811
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: tra
Date: Wed Mar 2 12:28:53 2016
New Revision: 262499
URL: http://llvm.org/viewvc/llvm-project?rev=262499&view=rev
Log:
[CUDA] Do not generate unnecessary runtime init code.
Differential Revision: http://reviews.llvm.org/D17780
Modified:
cfe/trunk/lib/CodeGen/CGCUDANV.cpp
cfe/t
Anastasia created this revision.
Anastasia added a reviewer: bader.
Anastasia added subscribers: cfe-commits, pekka.jaaskelainen, yaxunl.
Follow up from the earlier discussion via cfe-dev regarding incomplete images
support in Clang:
http://lists.llvm.org/pipermail/cfe-dev/2016-February/047187.ht
CrisCristescu created this revision.
CrisCristescu added reviewers: clang-c, benlangmuir, akyrtzi.
CrisCristescu added a subscriber: cfe-commits.
CrisCristescu set the repository for this revision to rL LLVM.
CrisCristescu changed the visibility of this Differential Revision from "Public
(No Login
LegalizeAdulthood abandoned this revision.
LegalizeAdulthood added a comment.
Discarding due to inaction by reviewers.
http://reviews.llvm.org/D10013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
LegalizeAdulthood added a comment.
Squeak. This has been waiting on review for over two weeks
http://reviews.llvm.org/D16529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis closed this revision.
thakis added a comment.
r262493, thanks!
http://reviews.llvm.org/D17799
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Wed Mar 2 11:28:48 2016
New Revision: 262493
URL: http://llvm.org/viewvc/llvm-project?rev=262493&view=rev
Log:
Serialize `#pragma comment`.
`#pragma comment` was handled by Sema calling a function on ASTConsumer, and
CodeGen then implementing this function and writing things t
Would this also be usable as a way to run clang-tidy checks as part of
normal compilation? (some things in clang-tidy aren't there because the FP
is too high to be a hard error on old codebases (but might be viable once a
codebase is able to be cleaned up (like several have been with LLVM)) or
beca
ikudrin created this revision.
ikudrin added reviewers: mclow.lists, howard.hinnant, EricWF.
ikudrin added a subscriber: cfe-commits.
Throwing an exception for the first time may lead to calling calloc to allocate
memory for __cxa_eh_globals. If the memory pool at that moment is exhausted, it
re
hubert.reinterpretcast added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:1658
@@ -1657,1 +1657,3 @@
} else if (FromType->isRealFloatingType() && ToType->isRealFloatingType()) {
+// FIXME: disable conversions between long double and __float128 if
+// their rep
sbenza created this revision.
sbenza added a reviewer: alexfh.
sbenza added a subscriber: cfe-commits.
Add check misc-dangling-handle to detect dangling references in value
handlers like std::experimental::string_view.
It provides a configuration option to specify other handle types that
should al
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D15267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Thanks, lgtm.
http://reviews.llvm.org/D16628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D17799
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 49620.
ioeric added a comment.
- Removed definitions that were forgotten.
http://reviews.llvm.org/D17761
Files:
include/clang/Basic/SourceManager.h
include/clang/Format/Format.h
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Replaceme
1 - 100 of 126 matches
Mail list logo
