hintonda updated this revision to Diff 49281.
hintonda added a comment.
When checking record initialization, maintain a vector of remaining
fields that were not explicitly initialized and check only those
fields to see if they can be default initialized.
http://reviews.llvm.org/D17407
Files:
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.
Thanks. LGTM.
http://reviews.llvm.org/D17622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
logan accepted this revision.
logan added a comment.
LGTM. It is good to go now.
@timonvo, do you have commit access? Or, do you need some assistance?
http://reviews.llvm.org/D15883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Sorry for arriving late to party :-)
Thank you for great check! I found a quite lot of such problems in my code
base, but I'd like to make suggestion for further improvements: PR26756.
Repository:
rL LLVM
htt
ryee88 updated this revision to Diff 49280.
ryee88 added a comment.
Moved test to a file that checks for similar diagnostics.
http://reviews.llvm.org/D16949
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaOverload.cpp
test/SemaCXX/overload-call.cpp
Index: test/SemaCXX/over
Author: rsmith
Date: Fri Feb 26 20:36:43 2016
New Revision: 262105
URL: http://llvm.org/viewvc/llvm-project?rev=262105&view=rev
Log:
Fix bug in using shadow decl checking: a using shadow decl should not conflict
with a prior UsingDecl -- those should not even really be found by the lookup
here, ex
rsmith added a comment.
We stand no hope of being bug-for-bug compatible with MSVC's constant
expression evaluator -- we should assume there will be expressions that we
evaluate as a constant and they do not, and vice versa. For reference, we have
the same problem between code built by Clang an
Hello everyone,
LLVM buildmaster will be updated and restarted after 8 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sfantao
Date: Fri Feb 26 18:01:58 2016
New Revision: 262094
URL: http://llvm.org/viewvc/llvm-project?rev=262094&view=rev
Log:
[OpenMP] Fix parsing of delete map clause modifier in C++ mode.
Summary: The map modifier 'delete' is parser in c++ mode as a delete keyword,
which requires speci
rnk added a comment.
Richard really is the constexpr owner so I'd like him to chime in if he can.
Comment at: include/clang/AST/Decl.h:1092
@@ -1091,3 +1091,3 @@
/// succeeded, 0 otherwise.
- APValue *evaluateValue() const;
- APValue *evaluateValue(SmallVectorImpl &Notes) c
hintonda added a comment.
Current diff is incorrect, but I did find the problem.
When iterating over the fields of a record, we use an iterator. The problem is
that if we use a designator, we reset the iterator value, so we can no longer
check Field != FieldEnd if the designators are out of or
sfantao updated this revision to Diff 49249.
sfantao marked 2 inline comments as done.
sfantao added a comment.
Remove extra braces.
Waiting on dependency.
http://reviews.llvm.org/D17369
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
t
sfantao updated this revision to Diff 49247.
sfantao marked 2 inline comments as done.
sfantao added a comment.
Remove extra braces.
Waiting on dependency.
http://reviews.llvm.org/D17368
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
t
xur updated this revision to Diff 49243.
xur added a comment.
Sean, Thanks for the review and suggestions.
Here is the patch that only adds -fprofile-instrument=llvm.
I'll have another patch using your suggestion on cc1 options for profile use
compilation.
http://reviews.llvm.org/D17622
File
sfantao updated this revision to Diff 49244.
sfantao marked 2 inline comments as done.
sfantao added a comment.
Remove extra braces.
Waiting on dependency.
http://reviews.llvm.org/D17367
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
t
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7767-7768
@@ -7766,4 +7766,4 @@
"bit fields cannot be used to specify storage in a map clause">;
-def err_omp_array_section_in_rightmost_expression : Error<
- "
sfantao updated this revision to Diff 49239.
sfantao marked 3 inline comments as done.
sfantao added a comment.
Use better disgnostic message and OMPArraySectionExpr::getBaseOriginalType.
http://reviews.llvm.org/D17547
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaOpenMP.cp
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM.
I will commit this a bit later, when I'll be around to watch the bots.
http://reviews.llvm.org/D17637
___
cfe-commits mailing list
cfe-co
yaxunl added inline comments.
Comment at: lib/AST/ASTContext.cpp:7605
@@ -7604,3 +7604,3 @@
// If two types are identical, they are compatible.
if (LHSCan == RHSCan)
return LHS;
Anastasia wrote:
> I feel like the AS check should be lifted here instead,
yaxunl updated this revision to Diff 49232.
yaxunl marked 7 inline comments as done.
yaxunl added a comment.
Revised as Anastasis suggested.
Modified mergeTypes() for un-handled case.
Separate sema tests for condition operator to a new file.
Repository:
rL LLVM
http://reviews.llvm.org/D17412
Author: cbieneman
Date: Fri Feb 26 15:23:59 2016
New Revision: 262071
URL: http://llvm.org/viewvc/llvm-project?rev=262071&view=rev
Log:
[CMake] Only configure Native target in stage 1, configure all in other stages
This patch causes the 3-stage build pipeline to only build a host compiler in
the
yaxunl added inline comments.
Comment at: lib/Sema/SemaCast.cpp:2317
@@ +2316,3 @@
+// OpenCL v2.0 s6.13.10 - Allow casts from '0' to event_t type.
+if (Self.getLangOpts().OpenCL && DestType->isEventT()) {
+ llvm::APSInt intValue;
tstellarAMD wrote:
>
Author: cbieneman
Date: Fri Feb 26 15:04:41 2016
New Revision: 262065
URL: http://llvm.org/viewvc/llvm-project?rev=262065&view=rev
Log:
[CMake] Add BINUTILS_INCDIR to the default passthrough list for multi-stage
builds
This is needed to build the gold plugin in multi-stage builds.
Patch by Mike
LegalizeAdulthood added a subscriber: LegalizeAdulthood.
Comment at: docs/clang-tidy/checks/misc-suspicious-semicolon.rst:48-49
@@ +47,4 @@
+
+while(readWhitespace());
+ Token t = readNextToken();
+
In this documentation, can we please format code so that
ahatanak added a comment.
> After going a bit through the log, I think that there is no reason for clang
> to not detect it, probably the check was just forgotten.
>
> This patch is the check.
Which part of your patch (in SemaStmtAsm.cpp) is supposed to catch that? I
applied this patch and
tstellarAMD added a comment.
Comment at: lib/Sema/SemaCast.cpp:2317
@@ +2316,3 @@
+// OpenCL v2.0 s6.13.10 - Allow casts from '0' to event_t type.
+if (Self.getLangOpts().OpenCL && DestType->isEventT()) {
+ llvm::APSInt intValue;
A similar patch ha
majnemer added a subscriber: majnemer.
Comment at: lib/Sema/SemaCast.cpp:2318
@@ +2317,3 @@
+if (Self.getLangOpts().OpenCL && DestType->isEventT()) {
+ llvm::APSInt intValue;
+ if (SrcExpr.get()->EvaluateAsInt(intValue, Self.Context)) {
Please name t
ashi1 updated this revision to Diff 49219.
ashi1 marked an inline comment as done.
ashi1 added a comment.
Revised with Xiuli Pan's comments.
http://reviews.llvm.org/D17578
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCast.cpp
test/CodeGenOpenCL/event_t.cl
test/SemaOpen
Author: rnk
Date: Fri Feb 26 13:51:02 2016
New Revision: 262056
URL: http://llvm.org/viewvc/llvm-project?rev=262056&view=rev
Log:
[dllexport] Sort out emission order of delayed exported classes
Relands r260194 with a fix. If we have a template that transitions from
an extern template to an explic
Author: probinson
Date: Fri Feb 26 13:34:01 2016
New Revision: 262052
URL: http://llvm.org/viewvc/llvm-project?rev=262052&view=rev
Log:
Fix Clang tests that used CHECK-NEXT-NOT and CHECK-DAG-NOT.
FileCheck actually doesn't support combo suffixes.
Differential Revision: http://reviews.llvm.org/D17
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262052: Fix Clang tests that used CHECK-NEXT-NOT and
CHECK-DAG-NOT. (authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D17589?vs=48999&id=49217#toc
Repository:
rL LLVM
http://
> On 2016-Feb-24, at 10:01, Aaron Ballman wrote:
>
> On Tue, Feb 23, 2016 at 6:39 PM, Duncan P. N. Exon Smith
> wrote:
>>
>>> On 2016-Feb-23, at 11:18, Aaron Ballman wrote:
>>>
>>> On Tue, Feb 23, 2016 at 1:52 PM, Manman Ren wrote:
This patch looks good to me. But I am not sure if Aaro
Author: dexonsmith
Date: Fri Feb 26 13:27:00 2016
New Revision: 262050
URL: http://llvm.org/viewvc/llvm-project?rev=262050&view=rev
Log:
SemaCXX: Support templates in availability attributes
If the availability context is `FunctionTemplateDecl`, we should look
through it to the `FunctionDecl`. T
timonvo updated this revision to Diff 49215.
timonvo added a comment.
That's basically the Diff 48015 I had at some point. Reverted back to it now.
Now this patch doesn't declare any macros anymore.
http://reviews.llvm.org/D15883
Files:
lib/Headers/unwind.h
Index: lib/Headers/unwind.h
=
ahatanak updated this revision to Diff 49213.
ahatanak added a comment.
ping and rebase.
http://reviews.llvm.org/D15599
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGStmt.cpp
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGen/attr-naked.c
test/CodeGenCXX/attr-n
mprobst updated this revision to Diff 49214.
mprobst added a comment.
- Move code closer together by piping Replacements into the FormatTokenLexer.
- remove sstream import
- * Treat JavaScript single quoted string literals as tok::string_literal, not
http://reviews.llvm.org/D17385
Files:
incl
steven_wu added subscribers: doug.gregor, rjmccall.
steven_wu added reviewers: rjmccall, doug.gregor.
steven_wu added a comment.
Looking through the subscript sounds fine but I would like to know if this is
indeed the only case that is being ignored because of OpaqueValueExpr and if
everything i
Author: ssrivastava
Date: Fri Feb 26 12:01:12 2016
New Revision: 262042
URL: http://llvm.org/viewvc/llvm-project?rev=262042&view=rev
Log:
Minor tweak to match the overall style.
Modified:
cfe/trunk/test/Sema/bitfield-layout.c
Modified: cfe/trunk/test/Sema/bitfield-layout.c
URL:
http://llvm.
Anastasia added a comment.
Joey Gouly!
Thanks!
http://reviews.llvm.org/D17578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
I think we are not covering all the possible cases with tests now! May be we
could also create a separate cl file since it becomes quite large.
Comment at: lib/AST/ASTContext.cpp:7605
@@ -7604,3 +7604,3 @@
// If two types are identical, they are co
Author: compnerd
Date: Fri Feb 26 10:34:01 2016
New Revision: 262030
URL: http://llvm.org/viewvc/llvm-project?rev=262030&view=rev
Log:
Basic: fix __USER_LABEL_PREFIX__ on Cygwin
Adjust the user label prefix for cygwin x86_64.
Resolves PR26744.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
c
djasper added a comment.
Sounds like a good plan. Should also mention the corresponding style guide
reference in the commit message:
https://google.github.io/styleguide/javascriptguide.xml?showone=Strings#Strings
http://reviews.llvm.org/D17385
___
yaxunl added a comment.
Hi Anastasia/Richard,
I found this issue when investigating some codegen issues in Clang -cc1 with
-emit-llvm. I need to pass an llvm option -print-after-all to the LLVM pass
manager which is used to run the optimization passes before emitting llvm.
However it did not w
yaxunl marked 2 inline comments as done.
Comment at: lib/Sema/SemaExpr.cpp:6194-6203
@@ +6193,12 @@
+
+ incompatTy = S.Context.getPointerType(
+ S.Context.getAddrSpaceQualType(S.Context.VoidTy, ResultAddrSpace));
+ LHS = S.ImpCastExprToType(LHS.get(), incompatTy
Author: andyg
Date: Fri Feb 26 09:35:16 2016
New Revision: 262025
URL: http://llvm.org/viewvc/llvm-project?rev=262025&view=rev
Log:
Reduce false positives in printf/scanf format checker
Summary:
The printf/scanf format checker is a little over-zealous in handling the
conditional operator. This
Author: hokein
Date: Fri Feb 26 09:34:35 2016
New Revision: 262024
URL: http://llvm.org/viewvc/llvm-project?rev=262024&view=rev
Log:
[clang-tidy] Fix an assertion failure in `modernize-use-nullptr` check.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262024: [clang-tidy] Fix an assertion failure in
`modernize-use-nullptr` check. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D17640?vs=49186&id=49187#toc
Repository:
rL LLVM
hokein updated this revision to Diff 49186.
hokein added a comment.
Correct test code format.
http://reviews.llvm.org/D17640
Files:
clang-tidy/modernize/UseNullptrCheck.cpp
test/clang-tidy/modernize-use-nullptr.cpp
Index: test/clang-tidy/modernize-use-nullptr.cpp
==
>
> Nice, the behavior now seems nicely isolated. Is this a purely stylistic
> kind of change or do you think every JS developer working on any kind of
> codebase will want it? Generally this feels like something we should
> carefully enable with a dedicated style option. Where can I find more
> in
tstellarAMD created this revision.
tstellarAMD added a reviewer: arsenm.
tstellarAMD added a subscriber: cfe-commits.
http://reviews.llvm.org/D17645
Files:
lib/Basic/Targets.cpp
test/Driver/r600-mcpu.cl
Index: test/Driver/r600-mcpu.cl
=
joelkevinjones added a comment.
The FIXME comment doesn't make sense to me. I'm not sure what sanitizer
arguments would be passed to the assembler.
http://reviews.llvm.org/D16538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
On Tue, Feb 23, 2016 at 5:14 PM, Richard Smith wrote:
> On Tue, Feb 23, 2016 at 8:28 AM, H.J. Lu wrote:
>> On Tue, Feb 23, 2016 at 8:15 AM, Michael Matz wrote:
>>> Hi,
>>>
>>> On Tue, 23 Feb 2016, H.J. Lu wrote:
>>>
I thought
---
An empty type is a type where it and all of it
alexfh added a comment.
In http://reviews.llvm.org/D16535#362761, @xazax.hun wrote:
> In http://reviews.llvm.org/D16535#362726, @alexfh wrote:
>
> > I think, the check can be submitted as is and guards against spurious
> > errors on invalid AST can be added as a follow up.
>
>
> This check is al
xazax.hun added a comment.
In http://reviews.llvm.org/D16535#362726, @alexfh wrote:
> I think, the check can be submitted as is and guards against spurious errors
> on invalid AST can be added as a follow up.
This check is already submitted. However I did not found any API in tidy to
check wh
Author: aaronballman
Date: Fri Feb 26 07:39:38 2016
New Revision: 262013
URL: http://llvm.org/viewvc/llvm-project?rev=262013&view=rev
Log:
Fixing an issue with the code block so that it does not appear as a list.
Modified:
cfe/trunk/include/clang/Basic/AttrDocs.td
Modified: cfe/trunk/include
Author: aaronballman
Date: Fri Feb 26 07:30:58 2016
New Revision: 262012
URL: http://llvm.org/viewvc/llvm-project?rev=262012&view=rev
Log:
Giving this attribute documentation group a heading; fixes a documentation
generation error.
Modified:
cfe/trunk/include/clang/Basic/AttrDocs.td
Modifie
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good! Thank you for coming up with the reduced test.
Repository:
rL LLVM
http://reviews.llvm.org/D17640
___
cfe-commits mailing list
cfe
alexfh added a comment.
I think, the check can be submitted as is and guards against spurious errors on
invalid AST can be added as a follow up.
Repository:
rL LLVM
http://reviews.llvm.org/D16535
___
cfe-commits mailing list
cfe-commits@lists.ll
cycheng created this revision.
cycheng added reviewers: kbarton, nemanjai, hfinkel.
cycheng added subscribers: cfe-commits, tjablin.
Issue: https://llvm.org/bugs/show_bug.cgi?id=26720
Fix compile error when building ffmpeg for PowerPC64LE because of some
vec_vsx_ld/vec_vsx_st intrinsics are not
omtcyf0 added a comment.
Hm. Seems like this **is** either me using `run-clang-tidy.py` wrong or it
working not properly, because I still get compilation errors. I believe I've
done the same thing yesterday using the older tree and I didn't get any.
Thus said, everything's alright if the AST is
omtcyf0 added a comment.
In http://reviews.llvm.org/D16535#362689, @alexfh wrote:
> In http://reviews.llvm.org/D16535#362685, @omtcyf0 wrote:
>
> > @xazax.hun did you actually run the tool on the LLVM codebase?
> >
> > Because this check generates **tons** of false-positive reports during
> > co
alexfh added a comment.
Having said that, it makes sense to handle invalid AST in the check somehow
(e.g. completely disable the check), so it doesn't generate spurious errors.
Repository:
rL LLVM
http://reviews.llvm.org/D16535
___
cfe-commits m
alexfh added a comment.
In http://reviews.llvm.org/D16535#362685, @omtcyf0 wrote:
> @xazax.hun did you actually run the tool on the LLVM codebase?
>
> Because this check generates **tons** of false-positive reports during
> codebase analysis.
>
> See the minimal example below.
>
> omtcyf0-lapt
andreybokhanko added a comment.
@majnemer, this error in the header is now gone. Thank you! On to more errors!
;-)
Yours,
Andrey
Repository:
rL LLVM
http://reviews.llvm.org/D17619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
omtcyf0 added a subscriber: omtcyf0.
omtcyf0 added a comment.
@xazax.hun did you actually run the tool on the LLVM codebase?
Because this check generates **tons** of false-positive reports during codebase
analysis.
See the minimal example below.
omtcyf0-laptop:playground omtcyf0$ cat main.cp
Author: vvassilev
Date: Fri Feb 26 04:43:34 2016
New Revision: 261999
URL: http://llvm.org/viewvc/llvm-project?rev=261999&view=rev
Log:
Test commit.
Modified:
cfe/trunk/lib/Serialization/ASTReaderDecl.cpp
Modified: cfe/trunk/lib/Serialization/ASTReaderDecl.cpp
URL:
http://llvm.org/viewvc/ll
Anastasia added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7211
@@ +7210,3 @@
+
+/// SPIR uses emitTargetMD to emit spir spec requried metadate.
+void SPIRTargetCodeGenInfo::emitTargetMD(const Decl *D, llvm::GlobalValue *GV,
Could you change the comme
Anastasia added a comment.
Could you please change my role to the Subscriber and add Joey as a reviewer
please.
http://reviews.llvm.org/D17578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: alexfh
Date: Fri Feb 26 04:24:29 2016
New Revision: 261998
URL: http://llvm.org/viewvc/llvm-project?rev=261998&view=rev
Log:
[clang-tidy] Minor change in the doc
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
Modified: clang-tools-extra/trunk/docs/clang-tidy/index.rst
UR
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks!
-eric
http://reviews.llvm.org/D13980
___
cfe-commits mailing list
cfe-commits@lists.llvm
Author: hokein
Date: Fri Feb 26 03:19:33 2016
New Revision: 261991
URL: http://llvm.org/viewvc/llvm-project?rev=261991&view=rev
Log:
[clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.
Summary:
The clang-tidy will trigger an assertion if it's not in the building directo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261991: [clang-tidy] Fix a crash issue when clang-tidy runs
with compilation database. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D17335?vs=49159&id=49164#toc
Repository:
rsmith added inline comments.
Comment at: lib/Basic/Targets.cpp:2603
@@ -2599,3 +2602,3 @@
case CK_i386:
case CK_i486:
case CK_i586:
echristo wrote:
> Waiting for rsmith to comment here.
>
>
This seems fine to me.
http://reviews.llvm.org/D13980
___
djasper added a comment.
Nice, the behavior now seems nicely isolated. Is this a purely stylistic kind
of change or do you think every JS developer working on any kind of codebase
will want it? Generally this feels like something we should carefully enable
with a dedicated style option. Where c
hokein updated this revision to Diff 49159.
hokein marked an inline comment as done.
hokein added a comment.
Nit: correct a comment.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test/cl
erik65536 added a comment.
I do not have commit access.
http://reviews.llvm.org/D17621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Do you have commit access?
http://reviews.llvm.org/D17621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
erik65536 updated this revision to Diff 49155.
erik65536 added a comment.
Change is() || is() to isOneOf() and added a test case.
http://reviews.llvm.org/D17621
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
echristo added a comment.
Can you add an explicit test for soft/hard-float.
One inline comment as well, waiting on Richard to pipe up.
-eric
Comment at: lib/Basic/Targets.cpp:2603
@@ -2599,3 +2602,3 @@
case CK_i386:
case CK_i486:
case CK_i586:
Waiting
79 matches
Mail list logo
