Could someone provide a feedback?
Thanks,
--Serge
2016-01-26 20:55 GMT+06:00 Serge Pavlov :
> sepavloff created this revision.
> sepavloff added a subscriber: cfe-commits.
>
> Declaration of friend function may depend on template parameters,
> however it does not become a template function:
>
>
djasper added a comment.
Thanks for looking at this.
Please also add a test in unittests/Format/FormatTest.cpp.
Comment at: lib/Format/TokenAnnotator.cpp:507
@@ -506,3 +506,3 @@
!Line.First->isOneOf(tok::kw_enum, tok::kw_case)) {
-if (Tok->Previous->is
silvas added a comment.
Thanks for splitting this out.
I think the `-fprofile-instrument=llvm` is straightforward and uncontroversial.
Let's focus this review on that and split the others into a separate review.
But a quick preview of my thoughs about `-fprofile-instrument={llvm,clang}-use`:
I
rtrieu added a comment.
This seems rather strange. Usually, a OpaqueValueExpr will hold an expression
that is held elsewhere in the AST. However, in this case, it appears that all
the references to --i are all behind OpaqueValueExpr's, so they aren't
processed.
`-CStyleCastExpr 0x5675d30
pxli168 added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:6194-6203
@@ +6193,12 @@
+
+ incompatTy = S.Context.getPointerType(
+ S.Context.getAddrSpaceQualType(S.Context.VoidTy, ResultAddrSpace));
+ LHS = S.ImpCastExprToType(LHS.get(), incompatTy,
+
Author: ahatanak
Date: Thu Feb 25 23:07:00 2016
New Revision: 261976
URL: http://llvm.org/viewvc/llvm-project?rev=261976&view=rev
Log:
[Driver] Disable frame pointer elimination by default if target is
x86_64-pc-win32-macho.
rdar://problem/24470634
Modified:
cfe/trunk/lib/Driver/Tools.cpp
rtrieu accepted this revision.
rtrieu added a comment.
This revision is now accepted and ready to land.
LGTM
The other issues brought up in this review can go in follow up patches.
http://reviews.llvm.org/D15636
___
cfe-commits mailing list
cfe-comm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261975: [MSVC Compat] Don't evaluate member base expressions
w/o side effects (authored by majnemer).
Changed prior to commit:
http://reviews.llvm.org/D17619?vs=49109&id=49150#toc
Repository:
rL LLVM
Author: majnemer
Date: Thu Feb 25 22:23:19 2016
New Revision: 261975
URL: http://llvm.org/viewvc/llvm-project?rev=261975&view=rev
Log:
[MSVC Compat] Don't evaluate member base expressions w/o side effects
A member expression's base doesn't always have an impact on what the
member decl would evalu
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2736-2738
@@ +2735,5 @@
+ const Expr *IfCond = nullptr;
+ if (auto *C = S.getSingleClause()) {
+IfCond = C->getCondition();
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2758-2760
@@ +2757,5 @@
+ const Expr *IfCond = nullptr;
+ if (auto *C = S.getSingleClause()) {
+IfCond = C->getCondition();
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D17629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2781-2783
@@ +2780,5 @@
+ const Expr *IfCond = nullptr;
+ if (auto *C = S.getSingleClause()) {
+IfCond = C->getCondition();
+ }
+
Remov
Author: dcoughlin
Date: Thu Feb 25 21:41:31 2016
New Revision: 261970
URL: http://llvm.org/viewvc/llvm-project?rev=261970&view=rev
Log:
[analyzer] Prune some incorrect \param doc comment annotations.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp
cfe/trunk/lib/Static
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D17170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4002
@@ +4001,3 @@
+static llvm::Value *
+emitNumTeamsClauseForTargetDirective(CodeGenFunction &CGF,
+ const OMPExecutableDirective &D,
I still don't lik
Thanks a lot!
Steven
> On Feb 25, 2016, at 7:12 PM, Peter Collingbourne wrote:
>
> (I don't understand why this flag needs to exist, but) I've implemented a
> fix in r261960.
>
> Peter
>
> On Thu, Feb 25, 2016 at 06:50:52PM -0800, Steven Wu wrote:
>> Hi Peter
>>
>> I notice after this comm
ABataev added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7767-7768
@@ -7766,4 +7766,4 @@
"bit fields cannot be used to specify storage in a map clause">;
-def err_omp_array_section_in_rightmost_expression : Error<
- "array section can only be assoc
Author: chapuni
Date: Thu Feb 25 21:15:09 2016
New Revision: 261962
URL: http://llvm.org/viewvc/llvm-project?rev=261962&view=rev
Log:
OpenMPClause.h: Fix typo in \param. [-Wdocumentation]
Modified:
cfe/trunk/include/clang/AST/OpenMPClause.h
Modified: cfe/trunk/include/clang/AST/OpenMPClause.
Author: chapuni
Date: Thu Feb 25 21:15:13 2016
New Revision: 261963
URL: http://llvm.org/viewvc/llvm-project?rev=261963&view=rev
Log:
Checkers/CheckObjCDealloc.cpp: Prune "\param". [-Wdocumentation]
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp
Modified: cfe/trunk/lib/
Author: pxl
Date: Thu Feb 25 21:13:03 2016
New Revision: 261961
URL: http://llvm.org/viewvc/llvm-project?rev=261961&view=rev
Log:
[OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr
Summary:
OpenCL access qualifiers are now not only used for image types, refine it to
avoid misleading,
Add
(I don't understand why this flag needs to exist, but) I've implemented a
fix in r261960.
Peter
On Thu, Feb 25, 2016 at 06:50:52PM -0800, Steven Wu wrote:
> Hi Peter
>
> I notice after this commit, I can no longer use cmake option
> -DCLANG_TOOL_DRIVER_BUILD=OFF to choose not to build and link
Author: pcc
Date: Thu Feb 25 21:07:33 2016
New Revision: 261960
URL: http://llvm.org/viewvc/llvm-project?rev=261960&view=rev
Log:
Make vtables_blacklist dependency conditional on existence of clang target.
Modified:
cfe/trunk/runtime/CMakeLists.txt
Modified: cfe/trunk/runtime/CMakeLists.txt
Hi Peter
I notice after this commit, I can no longer use cmake option
-DCLANG_TOOL_DRIVER_BUILD=OFF to choose not to build and link the clang driver.
When using -DCLANG_TOOL_DRIVER_BUILD=OFF, clang target will not exist so cmake
will error on the line:
> +add_dependencies(clang vtables_blacklis
pxli168 marked an inline comment as done.
pxli168 added a comment.
I think this is just a small change to help identify the which standard llvm-ir
is using.
And there is a SPIRV branch from Khronos
https://github.com/KhronosGroup/SPIRV-LLVM
We can start there and try to merge the spir-v support
On Tue, Feb 16, 2016 at 10:45 PM, David Blaikie wrote:
>
>
> On Tue, Feb 16, 2016 at 10:01 PM, Ryan Yee via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> ryee88 updated this revision to Diff 48149.
>> ryee88 added a comment.
>>
>> Keeping the number of test files to a minimum makes sens
pxli168 updated this revision to Diff 49136.
http://reviews.llvm.org/D17596
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGenOpenCL/spir_version.cl
Index: test/CodeGenOpenCL/spir_version.cl
===
--- /dev/null
+++ test/CodeGenOpenCL/
ryee88 added a comment.
any comments?
http://reviews.llvm.org/D16949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: caomhin, fraggamuffin, cfe-commits.
The map modifier 'delete' is parser in c++ mode as a delete keyword, which
requires special handling in the map clause par
steven_wu created this revision.
steven_wu added reviewers: rtrieu, thakis.
steven_wu added a subscriber: cfe-commits.
-Wfor-loop-analysis was incorrectly warning about certain cases because
the DeclMatcher is not looking pass OpaqueValueExpr.
http://reviews.llvm.org/D17627
Files:
lib/Sema/Sem
Author: dcoughlin
Date: Thu Feb 25 18:47:42 2016
New Revision: 261945
URL: http://llvm.org/viewvc/llvm-project?rev=261945&view=rev
Log:
[analyzer] Shorten ObjcSuperDeallocChecker diagnostics.
Change "use of 'self' after it has been freed with call to [super dealloc]" to
"use of 'self' after it ha
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks terrible, please commit :)
http://reviews.llvm.org/D17619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: dcoughlin
Date: Thu Feb 25 18:23:41 2016
New Revision: 261944
URL: http://llvm.org/viewvc/llvm-project?rev=261944&view=rev
Log:
[analyzer] Fix a memory error in r261935 caught by the Windows bots.
It was using a temporary StringRef after its underlying storage was freed.
Modified:
cf
jpienaar added reviewers: eliben, jyknight, chandlerc.
jpienaar updated this revision to Diff 49119.
jpienaar added a comment.
Updated preprocessor test init.c to use -match-full-lines.
http://reviews.llvm.org/D17002
Files:
lib/Basic/Targets.cpp
lib/CodeGen/TargetInfo.cpp
lib/Driver/Drive
Author: alexfh
Date: Thu Feb 25 17:57:30 2016
New Revision: 261940
URL: http://llvm.org/viewvc/llvm-project?rev=261940&view=rev
Log:
Remove a blank line at EOF. NFC
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/readability-redundant-string-init.rst
Modified:
clang-tools-extra/tr
Author: alexfh
Date: Thu Feb 25 17:57:23 2016
New Revision: 261939
URL: http://llvm.org/viewvc/llvm-project?rev=261939&view=rev
Log:
Add a new check, readability-redundant-string-init, that checks unnecessary
string initializations.
Reviewers: hokein, alexfh
Subscribers: cfe-commits
Patch by S
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261939: Add a new check, readability-redundant-string-init,
that checks unnecessary… (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D17586?vs=49114&id=49118#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
dcoughlin marked an inline comment as done.
Closed by commit rL261935: [analyzer] Warn on use of 'self' after call to to
[super dealloc]. (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D17528?vs
Author: dcoughlin
Date: Thu Feb 25 17:36:52 2016
New Revision: 261935
URL: http://llvm.org/viewvc/llvm-project?rev=261935&view=rev
Log:
[analyzer] Warn on use of 'self' after call to to [super dealloc].
Referring to 'self' after a call to [super dealloc] is a use-after-free in
Objective-C because
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp:165
@@ +164,3 @@
+ if (Desc.empty())
+Desc = "use of 'self' after it is freed with call to [super dealloc]";
+
zaks.anna wrote:
> Does "has been freed" sound
alexfh accepted this revision.
alexfh added a comment.
Looks good!
I'll commit the patch for you.
http://reviews.llvm.org/D17586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis updated the summary for this revision.
eugenis updated this revision to Diff 49115.
eugenis added a comment.
OK, done. Please take another look.
This is inferior to the original patch in terms of functionality, but the
implementation is a lot simpler.
Repository:
rL LLVM
http://revie
shuaiwang marked an inline comment as done.
shuaiwang added a comment.
http://reviews.llvm.org/D17586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shuaiwang updated this revision to Diff 49114.
shuaiwang added a comment.
CHECK-FIXES for macro tests
http://reviews.llvm.org/D17586
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/Re
alexfh added inline comments.
Comment at: test/clang-tidy/readability-redundant-string-init.cpp:69
@@ +68,3 @@
+#define M(x) x
+#define N { std::string s = ""; }
+
Please add a CHECK-FIXES to ensure the macro definition hasn't changed and that
the macro invocatio
Create a new review here:
http://reviews.llvm.org/D17622
Thanks,
-Rong
On Wed, Feb 24, 2016 at 9:22 PM, Sean Silva wrote:
> silvas added a comment.
>
> In http://reviews.llvm.org/D15829#360006, @xur wrote:
>
>> Here is the new patch that removes the auto detection of profile kind.
>>
>> In this
xur added a comment.
Create a new review here:
http://reviews.llvm.org/D17622
Thanks,
-Rong
http://reviews.llvm.org/D15829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xur created this revision.
xur added reviewers: davidxl, silvas, justinruggles.
xur added subscribers: cfe-commits, xur, mcrosier, davidxl, slingn.
This patch expands cc1 option -fprofile-instrument= with three new values:
(1) -fprofile-instrument=llvm
This enables IR PGO instrumentation.
(2) -fpr
Author: dcoughlin
Date: Thu Feb 25 15:15:16 2016
New Revision: 261929
URL: http://llvm.org/viewvc/llvm-project?rev=261929&view=rev
Log:
[analyzer] Reapply r261917 with a fix.
This reapplies "[analyzer] Make ObjCDeallocChecker path sensitive." (r261917)
with a fix for an error on some bots about s
majnemer updated this revision to Diff 49109.
majnemer added a comment.
- Refactor this change.
http://reviews.llvm.org/D17619
Files:
lib/AST/ExprConstant.cpp
test/SemaCXX/ms-const-member-expr.cpp
Index: test/SemaCXX/ms-const-member-expr.cpp
shuaiwang updated this revision to Diff 49108.
shuaiwang added a comment.
more test cases
http://reviews.llvm.org/D17586
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTid
shuaiwang marked 3 inline comments as done.
shuaiwang added a comment.
http://reviews.llvm.org/D17586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Thu Feb 25 14:17:03 2016
New Revision: 261926
URL: http://llvm.org/viewvc/llvm-project?rev=261926&view=rev
Log:
more status updates
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-proje
Author: marshall
Date: Thu Feb 25 14:15:47 2016
New Revision: 261925
URL: http://llvm.org/viewvc/llvm-project?rev=261925&view=rev
Log:
Added tests to make sure that the categorization traits work on incomplete types
Modified:
libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.cat/arr
erik65536 created this revision.
erik65536 added reviewers: djasper, klimek.
erik65536 added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
http://reviews.llvm.org/D17621
Files:
lib/Format/TokenAnnotator.cpp
Index: lib/Format/TokenAnnotator.cpp
==
majnemer updated this revision to Diff 49103.
majnemer added a comment.
- Add support for static data members too.
http://reviews.llvm.org/D17619
Files:
lib/AST/ExprConstant.cpp
test/SemaCXX/ms-const-member-expr.cpp
Index: test/SemaCXX/ms-const-member-expr.cpp
=
majnemer created this revision.
majnemer added reviewers: rsmith, andreybokhanko.
majnemer added a subscriber: cfe-commits.
A member expression's base doesn't always have an impact on what the
member decl would evaluate to. In such a case, the base is used as a
poor man's scope qualifier.
This f
Author: dcoughlin
Date: Thu Feb 25 13:13:43 2016
New Revision: 261921
URL: http://llvm.org/viewvc/llvm-project?rev=261921&view=rev
Log:
Revert "[analyzer] Make ObjCDeallocChecker path sensitive."
This reverts commit r261917. It broke the bots.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261917: [analyzer] Make ObjCDeallocChecker path sensitive.
(authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D17511?vs=48995&id=49097#toc
Repository:
rL LLVM
http://reviews.l
Author: dcoughlin
Date: Thu Feb 25 12:55:24 2016
New Revision: 261917
URL: http://llvm.org/viewvc/llvm-project?rev=261917&view=rev
Log:
[analyzer] Make ObjCDeallocChecker path sensitive.
Convert the ObjCDeallocChecker to be path sensitive. The primary
motivation for this change is to prevent fals
Author: cbieneman
Date: Thu Feb 25 12:39:19 2016
New Revision: 261911
URL: http://llvm.org/viewvc/llvm-project?rev=261911&view=rev
Log:
[CMake] Fixing install-clang-headers dependencies to depend on generating the
headers.
Modified:
cfe/trunk/lib/Headers/CMakeLists.txt
Modified: cfe/trunk/l
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:804
@@ +803,3 @@
+/// Returns true if there is a call to -dealloc anywhere on the stack and false
+/// otherwise. If true, it also sets \param SelfValOut to the value of
+/// 'self' in th
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you for fixing this!
http://reviews.llvm.org/D17335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Thanks! r261897.
On Fri, Feb 26, 2016 at 1:55 AM Alexander Kornienko
wrote:
> I've committed r261893 that adds stub headers and points the tool to the
> right search directory. If the solution works, this commit can be reverted.
>
> On Thu, Feb 25, 2016 at 2:12 AM, NAKAMURA Takumi via cfe-commit
yaxunl accepted this revision.
yaxunl added a comment.
LGTM. Thanks.
http://reviews.llvm.org/D16876
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: chapuni
Date: Thu Feb 25 10:59:59 2016
New Revision: 261897
URL: http://llvm.org/viewvc/llvm-project?rev=261897&view=rev
Log:
Revert r261814, "check-clang-tools: Introduce the feature target-headers",
corresponding to r261893.
Modified:
clang-tools-extra/trunk/test/clang-tidy/modern
Author: marshall
Date: Thu Feb 25 10:55:58 2016
New Revision: 261896
URL: http://llvm.org/viewvc/llvm-project?rev=261896&view=rev
Log:
Update the status of a N4089 and a couple issues
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.
Author: marshall
Date: Thu Feb 25 10:50:51 2016
New Revision: 261894
URL: http://llvm.org/viewvc/llvm-project?rev=261894&view=rev
Log:
Another chunk of N4089
Modified:
libcxx/trunk/include/memory
Modified: libcxx/trunk/include/memory
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/inc
I've committed r261893 that adds stub headers and points the tool to the
right search directory. If the solution works, this commit can be reverted.
On Thu, Feb 25, 2016 at 2:12 AM, NAKAMURA Takumi via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chapuni
> Date: Wed Feb 24 19:12:57
Let's see if r261893 fixes this.
On Thu, Feb 25, 2016 at 4:31 PM, Alexander Kornienko
wrote:
> Yes, I know. Trying to come up with a good solution.
>
> On Thu, Feb 25, 2016 at 4:59 AM, Sean Silva wrote:
>
>> This or r261737 seem to be causing a bot failure:
>> http://lab.llvm.org:8011/builders/
Author: alexfh
Date: Thu Feb 25 10:46:54 2016
New Revision: 261893
URL: http://llvm.org/viewvc/llvm-project?rev=261893&view=rev
Log:
[clang-tidy] Adding headers needed in modernize-deprecated-headers tests
Added:
clang-tools-extra/trunk/test/clang-tidy/Inputs/modernize-deprecated-headers/
Author: benlangmuir
Date: Thu Feb 25 10:36:26 2016
New Revision: 261887
URL: http://llvm.org/viewvc/llvm-project?rev=261887&view=rev
Log:
Add FieldNames to __NSConstantString_tag
Since consumers of the AST may expect fields to be named.
Patch by Brad King!
Modified:
cfe/trunk/lib/AST/ASTCon
Seems like this test got flagged as 'slow' by Google's internal
infrastructure - and that makes me wonder about whether it's appropriate to
have in the lit test suite - we really want to keep these tests as fast as
possible.
I think we're generally OK committing iterator invalidation fixes without
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
Pls revise by Anastasia's comments. Otherwise LGTM.
We have two options about SPIR-V support:
1. drop SPIR support and move on to SPIR-V
2. keep supporting both SPIR and SPIR-V
Option 1 is cl
ddkilzer added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:804
@@ +803,3 @@
+/// Returns true if there is a call to -dealloc anywhere on the stack and false
+/// otherwise. If true, it also sets \param SelfValOut to the value of
+/// 'self' in the
ddkilzer added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:804
@@ +803,3 @@
+/// Returns true if there is a call to -dealloc anywhere on the stack and false
+/// otherwise. If true, it also sets \param SelfValOut to the value of
+/// 'self' in the
Alexander_Droste added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MPI-Checker/MPIChecker.cpp:46
@@ +45,3 @@
+ExplodedNode *ErrorNode = Ctx.generateNonFatalErrorNode(State, &Tag);
+BReporter->reportDoubleNonblocking(PreCallEvent, *Req, MR, ExplNode);
+Ctx.
Anastasia added a comment.
I was just wondering with SPIRV coming these days, how long should we be
supporting and maintaining previous SPIR versions. Might be worth clarifying
that...
Comment at: lib/CodeGen/TargetInfo.cpp:7022
@@ -7021,1 +7021,3 @@
+class SPIRTargetCodeGen
hokein marked 3 inline comments as done.
Comment at: test/clang-tidy/clang-tidy-run-with-database.cpp:16
@@ +15,3 @@
+// RUN: FileCheck -input-file=%T/compilation-database-test/a/b.cpp %s
-check-prefix=CHECK-FIX2
+// RUN: FileCheck -input-file=%T/compilation-database-test/b/b.cpp
hokein updated this revision to Diff 49060.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test/clang-tidy/Inputs/compilation-database/tem
Author: marshall
Date: Thu Feb 25 09:27:13 2016
New Revision: 261875
URL: http://llvm.org/viewvc/llvm-project?rev=261875&view=rev
Log:
No, really - test the constructor
Modified:
libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.dltr/unique.ptr.dltr.dflt1/convert_ctor.pass.cpp
Mo
Yes, I know. Trying to come up with a good solution.
On Thu, Feb 25, 2016 at 4:59 AM, Sean Silva wrote:
> This or r261737 seem to be causing a bot failure:
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/636
>
> -- Sean Silva
>
> On Wed, Feb 24, 2016 a
AndyG added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:3923-3924
@@ +3922,4 @@
+ PartialDiagnostic PDiag = S.PDiag(diag::warn_printf_data_arg_not_used);
+ for (unsigned i = 1; i < DiagnosticExprs.size(); ++i)
+PDiag << DiagnosticExprs[i]->getSourceRange();
+
Author: marshall
Date: Thu Feb 25 09:25:29 2016
New Revision: 261874
URL: http://llvm.org/viewvc/llvm-project?rev=261874&view=rev
Log:
Add test to ensure that the converting constructor in N4089 is present and
working
Added:
libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.dltr/
alexfh added inline comments.
Comment at: clang-tidy/readability/RedundantStringInitCheck.cpp:26
@@ +25,3 @@
+void RedundantStringInitCheck::registerMatchers(
+ast_matchers::MatchFinder *Finder) {
+ if (!getLangOpts().CPlusPlus)
nit: `ast_matchers::` can be o
AndyG updated this revision to Diff 49058.
AndyG marked 5 inline comments as done.
AndyG added a comment.
Updated patch according to the comments made. Also spotted a corner-case where
a double-diagnostic was produced, for example in the following where one string
has too few arguments and the
alexfh added inline comments.
Comment at: test/clang-tidy/clang-tidy-run-with-database.cpp:2
@@ +1,3 @@
+// REQUIRES: shell
+// RUN: mkdir -p %T/compilation-database-test
+// RUN: mkdir -p %T/compilation-database-test/include
You don't need to create the root dire
aaron.ballman closed this revision.
aaron.ballman added a comment.
Thanks! I've commit in r261872.
http://reviews.llvm.org/D17575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Thu Feb 25 09:14:09 2016
New Revision: 261872
URL: http://llvm.org/viewvc/llvm-project?rev=261872&view=rev
Log:
Replace a compiler-specific approach to determining the presence of a getDecl()
member function with one that does not require compiler-specific workarounds;
logan added inline comments.
Comment at: lib/Headers/unwind.h:61
@@ +60,3 @@
+#define _UNWIND_ARM_EHABI 0
+#endif
+
compnerd wrote:
> logan wrote:
> > logan wrote:
> > > compnerd wrote:
> > > > logan wrote:
> > > > > compnerd wrote:
> > > > > > logan wrote:
> > >
hokein updated this revision to Diff 49054.
hokein added a comment.
Simplify test code.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test/clang-tidy/Inputs/compilation-database/template
AndyG added a comment.
Second bump :o)
http://reviews.llvm.org/D17149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Thu Feb 25 08:31:10 2016
New Revision: 261868
URL: http://llvm.org/viewvc/llvm-project?rev=261868&view=rev
Log:
[clang-tidy] update links to Google Code Style in docs
Summary: Because of the recent Google Code shutdown links to the Google Code
Style up there are no longer re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261868: [clang-tidy] update links to Google Code Style in
docs (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D17602?vs=49048&id=49052#toc
Repository:
rL LLVM
http://reviews.
omtcyf0 added inline comments.
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,2 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
All parameters should be named, with identical names in the declaratio
hokein added inline comments.
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,2 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
All parameters should be named, with identical names in the declaration
omtcyf0 added a comment.
Thank you very much, @hokein!
http://reviews.llvm.org/D17602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein accepted this revision.
hokein added a comment.
LGTM. I will commit the patch for you @omtcyf0.
http://reviews.llvm.org/D17602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyf0 added inline comments.
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,2 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
All parameters should be named, with identical names in the declaratio
alexfh added a comment.
Hajian, if you have no concerns, could you commit the patch? Thanks!
http://reviews.llvm.org/D17602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 123 matches
Mail list logo
