pxli168 added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5046
@@ +5045,3 @@
+ if (D->hasAttr()) {
+S.Diag(Attr.getLoc(), diag::err_opencl_multiple_access_qualifiers)
+<< D->getSourceRange();
Anastasia wrote:
> Yes, I think attribute would
pxli168 updated this revision to Diff 48648.
http://reviews.llvm.org/D17436
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExpr.cpp
lib/Sema/SemaType.cpp
test/SemaOpenCL/invalid-block.cl
Index: test/SemaOpenCL/invalid-block.cl
=
pxli168 marked 11 inline comments as done.
pxli168 added a comment.
Block is an OpenCL v2.0 feature, I think all test should be handled only for
CL2.0 or newer version.
Comment at: lib/Sema/SemaDecl.cpp:6714
@@ +6713,3 @@
+ // supported in OpenCL C: Blocks with variadic argume
On 21 Feb 2016 8:21 p.m., "Faisal Vali" wrote:
>
> On Sun, Feb 21, 2016 at 10:06 PM, Richard Smith
wrote:
> > On 21 Feb 2016 6:29 p.m., "Faisal Vali via cfe-commits"
> > wrote:
> >>
> >> Author: faisalv
> >> Date: Sun Feb 21 20:24:29 2016
> >> New Revision: 261506
> >>
> >> URL: http://llvm.org/
pxli168 requested changes to this revision.
pxli168 added a comment.
This revision now requires changes to proceed.
It seems this patch will check block for CL1.2 or eailer? But the spec
reference is for OpenCL v2.0.
http://reviews.llvm.org/D16928
Author: mren
Date: Sun Feb 21 22:47:24 2016
New Revision: 261512
URL: http://llvm.org/viewvc/llvm-project?rev=261512&view=rev
Log:
Addressing review comments for r261163.
Use "strict" instead of "nopartial". Also make strictly not-introduced
share the same diagnostics as Obsolete and Unavailable.
On Sun, Feb 21, 2016 at 10:06 PM, Richard Smith wrote:
> On 21 Feb 2016 6:29 p.m., "Faisal Vali via cfe-commits"
> wrote:
>>
>> Author: faisalv
>> Date: Sun Feb 21 20:24:29 2016
>> New Revision: 261506
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=261506&view=rev
>> Log:
>> Fix PR24473 : Tea
On 21 Feb 2016 6:29 p.m., "Faisal Vali via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> Author: faisalv
> Date: Sun Feb 21 20:24:29 2016
> New Revision: 261506
>
> URL: http://llvm.org/viewvc/llvm-project?rev=261506&view=rev
> Log:
> Fix PR24473 : Teach clang to remember to substitute into
Author: faisalv
Date: Sun Feb 21 20:24:29 2016
New Revision: 261506
URL: http://llvm.org/viewvc/llvm-project?rev=261506&view=rev
Log:
Fix PR24473 : Teach clang to remember to substitute into member variable
templates referred to within dependent qualified ids.
In passing also fix a semi-related
flx created this revision.
flx added a reviewer: alexfh.
flx added a subscriber: cfe-commits.
flx set the repository for this revision to rL LLVM.
The patch uses [[ http://reviews.llvm.org/D17488 | D17488 ]] as diff base. Once
D17488 is submitted I'll update the diffbase to head.
Repository:
r
carlo.bertolli added a comment.
Thanks - waiting for dependence http://reviews.llvm.org/D17019 before commit.
Repository:
rL LLVM
http://reviews.llvm.org/D17148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
carlo.bertolli added a comment.
Just wanted to add that tgt_target_teams needs the values for num_teams and
thread_limit because, for some accelerators, it is necessary to know those
values in advance, before teams gets actually executed. For instance, on Nvidia
GPUs we launch one CUDA block fo
On Sun, Feb 21, 2016 at 02:26:30AM +, Eugene Zelenko via cfe-commits wrote:
> Another idea: to replace limits.h with limits and also replace its
> defines with their C++ counterparts. For example, INT_MIN with
> numeric_limits::min().
I'm not sure how useful it is to write four times as much
ayartsev added a comment.
In http://reviews.llvm.org/D17091#358022, @rizsotto.mailinglist wrote:
> the semicolon at the end of line 39 is an issue for PEP8. please remove it.
Done.
Committed as r261480, thanks for the review.
http://reviews.llvm.org/D17091
Author: ayartsev
Date: Sun Feb 21 11:04:26 2016
New Revision: 261480
URL: http://llvm.org/viewvc/llvm-project?rev=261480&view=rev
Log:
[analyzer][scan-build] Non-existing directory for scan-build output.
Makes scan-build successfully accept non-existing output directories provided
via "-o" optio
milianw closed this revision.
milianw added a comment.
closing then, since this has been landed
http://reviews.llvm.org/D13388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda updated this revision to Diff 48617.
hintonda added a comment.
- Fix remaining test failures caused by linkage errors.
http://reviews.llvm.org/D17362
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/CXX/drs/dr3xx.cpp
test/Sema/pr23090-crash-on-invali
Author: mzuckerm
Date: Sun Feb 21 08:00:11 2016
New Revision: 261471
URL: http://llvm.org/viewvc/llvm-project?rev=261471&view=rev
Log:
[CLANG] [AVX512] [BUILTIN] Adding pmovzx{b|d|w}{w|d|q}{128|256|512} builtin to
clang
Differential Revision: http://reviews.llvm.org/D16961
Modified:
cfe/tr
On Sat, Feb 20, 2016 at 10:48 PM, Richard Smith wrote:
> On 20 Feb 2016 10:01 p.m., "H.J. Lu" wrote:
>>
>> On Sat, Feb 20, 2016 at 9:47 PM, Richard Smith
>> wrote:
>> > On 20 Feb 2016 6:54 p.m., "H.J. Lu" wrote:
>> >>
>> >> On Sat, Feb 20, 2016 at 4:57 PM, Matthijs van Duin
>> >> wrote:
>> >>
omtcyf0 marked 3 inline comments as done.
omtcyf0 added a comment.
http://reviews.llvm.org/D17484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyf0 updated this revision to Diff 48613.
omtcyf0 added a comment.
Thanks for a review, Richard!
Fixed all the issues you pointed to!
Thanks for the hint, Eugene!
I'll try to add this functionality to this check later on.
http://reviews.llvm.org/D17484
Files:
clang-tidy/modernize/CMakeLis
21 matches
Mail list logo
