pxli168 created this revision.
pxli168 added reviewers: Anastasia, pekka.jaaskelainen.
pxli168 added a subscriber: cfe-commits.
Add Sema checks for opencl 2.0 new features: Block.
http://reviews.llvm.org/D17436
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sem
Author: majnemer
Date: Fri Feb 19 01:15:33 2016
New Revision: 261312
URL: http://llvm.org/viewvc/llvm-project?rev=261312&view=rev
Log:
Correct typos after acting on invalid subscript expressions
Modified:
cfe/trunk/lib/Parse/ParseExpr.cpp
cfe/trunk/test/SemaCXX/typo-correction.cpp
Modifi
should probably have test coverage
On Thu, Feb 18, 2016 at 6:46 PM, Eugene Zelenko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Eugene.Zelenko created this revision.
> Eugene.Zelenko added reviewers: alexfh, xazax.hun, aaron.ballman.
> Eugene.Zelenko added a subscriber: cfe-commits.
> E
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261309: ARM: fix VFP asm constraints (authored by jfb).
Changed prior to commit:
http://reviews.llvm.org/D17349?vs=48363&id=48453#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17349
Files:
cfe/
Author: jfb
Date: Fri Feb 19 00:54:47 2016
New Revision: 261310
URL: http://llvm.org/viewvc/llvm-project?rev=261310&view=rev
Log:
Add test.
Added:
cfe/trunk/test/CodeGen/arm-vfp-asm-constraint.c
Added: cfe/trunk/test/CodeGen/arm-vfp-asm-constraint.c
URL:
http://llvm.org/viewvc/llvm-project/
Author: jfb
Date: Fri Feb 19 00:54:45 2016
New Revision: 261309
URL: http://llvm.org/viewvc/llvm-project?rev=261309&view=rev
Log:
ARM: fix VFP asm constraints
Summary:
Rich Felker was sad that clang used 'w' and 'P' for VFP constraints when GCC
documents them as 't' and 'w':
https://gcc.gnu.or
pxli168 updated this revision to Diff 48452.
pxli168 added a comment.
Refine the pipe parse to solve the problem the attribute for pipe will be
handled twice within Declarator
http://reviews.llvm.org/D16040
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision is now accepted and ready to land.
Yeah, constraint validation is not one of the highlights of the current
implementation. This seems reasonable enough to merge I think.
http://reviews
Author: nico
Date: Thu Feb 18 20:51:07 2016
New Revision: 261301
URL: http://llvm.org/viewvc/llvm-project?rev=261301&view=rev
Log:
Fix SemaTemplate/instantiate-field.cpp after r261297.
For templates, fields can have incomplete types:
template
struct A2 {
struct B;
B b;
};
Don't t
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, xazax.hun, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
While working with LLDB code I noticed that readability-container-size-empty
does
dcoughlin updated this revision to Diff 48447.
dcoughlin added a comment.
Addressed additional comments from Anna offline:
- "[super dealloc] called again" is OK as a path note but not good as an error
message. I've changed it to "[super dealloc] should not be called multiple
times".
- Added a
jfb added a comment.
Is this ready to land? I'm hoping to get it into the 3.8 branch since it
affects musl libc's latest release.
http://reviews.llvm.org/D17349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
thakis closed this revision.
thakis added a comment.
Thanks! Landed the cxx_dr_status.html update in r261295 and this change in
r261297.
http://reviews.llvm.org/D16552
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: nico
Date: Thu Feb 18 19:52:46 2016
New Revision: 261297
URL: http://llvm.org/viewvc/llvm-project?rev=261297&view=rev
Log:
Implement the likely resolution of core issue 253.
C++11 requires const objects to have a user-provided constructor, even for
classes without any fields. DR 253 relax
Author: nico
Date: Thu Feb 18 19:49:39 2016
New Revision: 261295
URL: http://llvm.org/viewvc/llvm-project?rev=261295&view=rev
Log:
Update cxx_dr_status.html with today's cwg_index.html.
Created by:
cd www
curl -O http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_index.html
./make_cxx_dr_status
Mod
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D17313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
silvas added a comment.
Apologies for the delay. At this point, I think that this patch has evolved
enough that it is best to start a new patch. I think the steps forward are:
- Have cc1 accept -fprofile-instrument=llvm (requires no driver changes, but is
enough for developers to test by being
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261293: [analyzer] Add checker callback for beginning of
function. (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D17418?vs=48406&id=48438#toc
Repository:
rL LLVM
http://r
Author: dcoughlin
Date: Thu Feb 18 19:35:10 2016
New Revision: 261293
URL: http://llvm.org/viewvc/llvm-project?rev=261293&view=rev
Log:
[analyzer] Add checker callback for beginning of function.
Add a checker callback that is called when the analyzer starts analyzing a
function either at the top
dcoughlin marked an inline comment as done.
dcoughlin added a comment.
http://reviews.llvm.org/D17418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Thu Feb 18 19:15:08 2016
New Revision: 261292
URL: http://llvm.org/viewvc/llvm-project?rev=261292&view=rev
Log:
[Sema] PR25181 Fix crash when method declaration with throw spec fails to parse
correctly
Fixes crash referenced in PR25181 where dyn_cast is called on a null
instanc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261292: [Sema] PR25181 Fix crash when method declaration
with throw spec fails to… (authored by rnk).
Changed prior to commit:
http://reviews.llvm.org/D17072?vs=47923&id=48435#toc
Repository:
rL LLVM
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM with a request for a tiny other improvement in the documentation.
Thanks!
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SubEngine.h:111
@@ -103,3 +110
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good, thanks. I like the new approach of avoiding the creation of a
LateParsedMethodDeclaration if we couldn't get a NamedDecl back. I'll land it
soon.
http://reviews.llvm.org/D17072
Author: rnk
Date: Thu Feb 18 18:56:56 2016
New Revision: 261290
URL: http://llvm.org/viewvc/llvm-project?rev=261290&view=rev
Log:
Add call to find_package to load LLVM dependencies
ClangConfig requires LLVMConfig, so add find_package call in
ClangConfig so find_package(clang REQUIRED CONFIG) will
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261290: Add call to find_package to load LLVM dependencies
(authored by rnk).
Changed prior to commit:
http://reviews.llvm.org/D13622?vs=37031&id=48431#toc
Repository:
rL LLVM
http://reviews.llvm.or
This was already fixed in r261285.
On Thu, Feb 18, 2016 at 4:31 PM, Oleksiy Vyalov via cfe-commits
wrote:
> ovyalov added a subscriber: ovyalov.
> ovyalov added a comment.
>
> It seems this CL broke LLDB CMake build bot -
> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/
ovyalov added a subscriber: ovyalov.
ovyalov added a comment.
It seems this CL broke LLDB CMake build bot -
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/11554
Could you take a look?
Repository:
rL LLVM
http://reviews.llvm.org/D3976
__
Author: rtrieu
Date: Thu Feb 18 18:15:50 2016
New Revision: 261285
URL: http://llvm.org/viewvc/llvm-project?rev=261285&view=rev
Log:
Fix my typo from r261278
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trun
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM!
If it's convenient, it'd be nice to check in a new cxx_dr_status.html without
your change first, as a separate commit, so it's more obvious which parts of
the file are changed b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261278: Add -Wcomma warning to Clang. (authored by rtrieu).
Changed prior to commit:
http://reviews.llvm.org/D3976?vs=21170&id=48419#toc
Repository:
rL LLVM
http://reviews.llvm.org/D3976
Files:
cf
Author: rtrieu
Date: Thu Feb 18 17:58:40 2016
New Revision: 261278
URL: http://llvm.org/viewvc/llvm-project?rev=261278&view=rev
Log:
Add -Wcomma warning to Clang.
-Wcomma will detect and warn on most uses of the builtin comma operator. It
currently whitelists the first and third statements of th
thakis updated this revision to Diff 48418.
thakis added a comment.
Thanks! All done.
http://reviews.llvm.org/D16552
Files:
include/clang/AST/DeclCXX.h
lib/AST/ASTImporter.cpp
lib/AST/DeclCXX.cpp
lib/Sema/SemaInit.cpp
lib/Serialization/ASTReaderDecl.cpp
lib/Serialization/ASTWriter.c
akyrtzi added a subscriber: akyrtzi.
akyrtzi added a comment.
If I apply just the test changes without the rest of the changes, I don't see
any failures, so I'm not sure these are effective tests.
http://reviews.llvm.org/D17029
___
cfe-commits mail
rsmith added inline comments.
Comment at: lib/AST/DeclCXX.cpp:396-425
@@ -394,1 +395,32 @@
+bool CXXRecordDecl::allowConstDefaultInitSlow() const {
+ assert(getDefinition() && "only call this on completed records");
+ if (hasUserProvidedDefaultConstructor()) {
+data().setA
akyrtzi added a subscriber: akyrtzi.
akyrtzi added a comment.
Doesn't this mean that _all_ of the Importer.FromDiag() calls will be ignored
by VerifyDiagnosticConsumer ? Why specifically change only this two and what
are we going to do with the others ?
This seems more like needing a fix higher
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:2716
@@ +2715,3 @@
+ if (Ops.LHS->getType() != RHS->getType()) {
+bool isSigned =
dyn_cast(Ops.E)->getRHS()->getType().getTypePtr()->isSignedIntegerType();
+RHS = Builder.CreateIntCast(RHS, Ops.LHS-
akyrtzi added a subscriber: akyrtzi.
akyrtzi accepted this revision.
akyrtzi added a reviewer: akyrtzi.
akyrtzi added a comment.
This revision is now accepted and ready to land.
LGTM, committed in r261274.
http://reviews.llvm.org/D16923
___
cfe-comm
Author: akirtzidis
Date: Thu Feb 18 17:08:36 2016
New Revision: 261274
URL: http://llvm.org/viewvc/llvm-project?rev=261274&view=rev
Log:
[ASTImporter] Implement missing VisitAccessSpecDecl function in ASTImporter
class.
Patch by Elisavet Sakellari!
Modified:
cfe/trunk/lib/AST/ASTImporter.cp
rjmccall added a comment.
LGTM.
http://reviews.llvm.org/D17023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Thu, Feb 18, 2016 at 6:35 AM, Michael Matz wrote:
> Hi,
>
> On Tue, 16 Feb 2016, H.J. Lu wrote:
>
>> Here is the new definition:
>>
>> An empty type is a type where it and all of its subobjects (recursively)
>> are of class, structure, union, or array type. No memory slot nor
>> register shoul
bcraig created this revision.
bcraig added reviewers: rubenvb, yaron.keren, jroelofs, howard.hinnant,
mclow.lists.
bcraig added a subscriber: cfe-commits.
This is one part of many of a locale refactor. See
http://reviews.llvm.org/D17146 for an idea of where this is going.
For the locale refactor
On Thu, Feb 18, 2016 at 6:35 AM, Michael Matz wrote:
> Hi,
>
> On Tue, 16 Feb 2016, H.J. Lu wrote:
>
>> Here is the new definition:
>>
>> An empty type is a type where it and all of its subobjects (recursively)
>> are of class, structure, union, or array type. No memory slot nor
>> register shoul
dcoughlin created this revision.
dcoughlin added a reviewer: zaks.anna.
dcoughlin added a subscriber: cfe-commits.
Add a checker callback that is called when the analyzer starts analyzing a
function either at the top level or when inlined. This will be used by a
follow-on patch making the DeallocC
Author: rtrieu
Date: Thu Feb 18 16:34:54 2016
New Revision: 261271
URL: http://llvm.org/viewvc/llvm-project?rev=261271&view=rev
Log:
Remove use of builtin comma operator.
Cleanup for upcoming Clang warning -Wcomma. No functionality change intended.
Modified:
cfe/trunk/lib/Analysis/FormatStr
bcraig created this revision.
bcraig added reviewers: jroelofs, danalbert, mclow.lists.
bcraig added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer, jfb.
This is one part of many of a locale refactor. See
http://reviews.llvm.org/D17146 for an idea of where th
eugenis added a comment.
This lets us support the following case:
module A checks vcalls and casts, with diagnostics
module B checks vcalls but not casts (but it still has bitsets for vtables),
with diagnostics
then a cast check from module A with a target in module B should print
diagnostics in
bruno updated this revision to Diff 48397.
bruno added a comment.
Updated the patch, with the following changes:
Handle ".", ".." and "./" with trailing slashes while collecting files
to be dumped into the vfs overlay directory.
Include the support for symlinks into components. Given the
bcraig updated this revision to Diff 48396.
bcraig added a comment.
Prior version doesn't apply to master. The context was dirty from some
unsubmitted patches.
http://reviews.llvm.org/D17410
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
bcraig created this revision.
bcraig added reviewers: mclow.lists, EricWF, danalbert, jroelofs.
bcraig added a subscriber: cfe-commits.
Prior to this patch, setting LIBCXXABI_LIBDIR_SUFFIX would confuse the
check-libcxxabi target. libc++abi.* would get output to lib instead of
lib${LIBCXXABI_LI
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261260: [Sema] Fix bug in TypeLocBuilder::pushImpl (authored
by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D16843?vs=48387&id=48392#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
Author: ahatanak
Date: Thu Feb 18 15:05:09 2016
New Revision: 261260
URL: http://llvm.org/viewvc/llvm-project?rev=261260&view=rev
Log:
[Sema] Fix bug in TypeLocBuilder::pushImpl
The code in TypeLocBuilder::pushImpl wasn't correctly handling the case
where an element that has an 8-byte alignment w
sfantao added a comment.
Hi Alexey,
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932
@@ +3900,34 @@
+// Reference types are ignored for mapping purposes.
+if (auto *RefTy = ExprTy->getAs())
+ ExprTy = RefTy->getPointeeType().getCanonicalType();
+
+// Given
hintonda created this revision.
hintonda added a reviewer: rsmith.
hintonda added a subscriber: cfe-commits.
Remove assert that fired whenever initialization lists had
errors, and pass VerifyOnly=false to PerformEmptyInit so we'll get diagnostics.
http://reviews.llvm.org/D17407
Files:
lib/Sema
manmanren added a comment.
Thanks Akira,
LGTM.
Manman
http://reviews.llvm.org/D16843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak updated this revision to Diff 48387.
ahatanak added a comment.
Fix indentation.
http://reviews.llvm.org/D16843
Files:
lib/Sema/TypeLocBuilder.cpp
test/SemaObjCXX/typeloc-data-alignment.mm
Index: test/SemaObjCXX/typeloc-data-alignment.mm
Author: kparzysz
Date: Thu Feb 18 14:30:40 2016
New Revision: 261253
URL: http://llvm.org/viewvc/llvm-project?rev=261253&view=rev
Log:
Missed a spot in r261251, also ignore attributes on all pointer parameters
Modified:
cfe/trunk/test/CodeGen/ms-intrinsics.c
Modified: cfe/trunk/test/CodeGen/
Author: dlj
Date: Thu Feb 18 14:27:16 2016
New Revision: 261252
URL: http://llvm.org/viewvc/llvm-project?rev=261252&view=rev
Log:
Use Backend_EmitMCNull for null codegen unit tests.
Using Backend_EmitLL attemps to create a file with an empty filename.
This is problematic in certain environments:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261252: Use Backend_EmitMCNull for null codegen unit tests.
(authored by dlj).
Changed prior to commit:
http://reviews.llvm.org/D17405?vs=48380&id=48386#toc
Repository:
rL LLVM
http://reviews.llvm.o
ahatanak updated this revision to Diff 48384.
ahatanak added a comment.
Address Manman's review comments. Handle elements with "LocalAlignment == 8"
similarly to those with "LocalAlignment == 4".
http://reviews.llvm.org/D16843
Files:
lib/Sema/TypeLocBuilder.cpp
test/SemaObjCXX/typeloc-data
rsmith added a subscriber: rsmith.
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D17405
___
cfe-commits mailing list
cfe-commits@
Author: kparzysz
Date: Thu Feb 18 14:02:03 2016
New Revision: 261251
URL: http://llvm.org/viewvc/llvm-project?rev=261251&view=rev
Log:
Make test less prone to attribute changes
Modified:
cfe/trunk/test/CodeGen/ms-intrinsics.c
Modified: cfe/trunk/test/CodeGen/ms-intrinsics.c
URL:
http://llvm
dlj created this revision.
dlj added a subscriber: cfe-commits.
Using Backend_EmitLL attemps to create a file with an empty filename.
This is problematic in certain environments: an empty filename may be
illegal, or the default output path may not be writable (in the case
where an empty filename w
carlo.bertolli updated this revision to Diff 48379.
carlo.bertolli marked 4 inline comments as done.
carlo.bertolli added a comment.
Partially address comments to replace schedule type with schedule num in
interface of static function generating call to kmpc_for_static_init. Still
waiting for up
carlo.bertolli added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:187-208
@@ -185,30 +186,24 @@
+
+public:
/// \brief Values for bit flags used in the ident_t to describe the fields.
/// All enumeric elements are named and described in accordance with the code
sfantao added a comment.
Hi Alexey
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3799-3806
@@ -3780,4 +3798,10 @@
OffloadEntriesInfoManager.registerTargetRegionEntryInfo(
DeviceID, FileID, ParentName, Line, OutlinedFn, OutlinedFnID);
}
+/// \brief Emit the num_teams c
Author: dcoughlin
Date: Thu Feb 18 13:37:39 2016
New Revision: 261248
URL: http://llvm.org/viewvc/llvm-project?rev=261248&view=rev
Log:
[analyzer] Include comment mistakenly left out of r261243. NFC.
It explains why we can't just synthesize bodies of setters in BodyFarm.
Modified:
cfe/trunk/
thakis closed this revision.
thakis added a comment.
261247
http://reviews.llvm.org/D17397
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Thu Feb 18 13:32:54 2016
New Revision: 261247
URL: http://llvm.org/viewvc/llvm-project?rev=261247&view=rev
Log:
Make deprecation message for -fsanitize-coverage= with numeric argument
friendlier.
http://reviews.llvm.org/D17397
Modified:
cfe/trunk/lib/Driver/SanitizerArgs.
thakis updated this revision to Diff 48376.
thakis added a comment.
update test
http://reviews.llvm.org/D16552
Files:
include/clang/AST/DeclCXX.h
lib/AST/ASTImporter.cpp
lib/AST/DeclCXX.cpp
lib/Sema/SemaInit.cpp
lib/Serialization/ASTReaderDecl.cpp
lib/Serialization/ASTWriter.cpp
t
thakis added inline comments.
Comment at: lib/AST/DeclCXX.cpp:403-413
@@ +402,13 @@
+ for (const auto *F : fields()) {
+if (F->hasInClassInitializer() || F->isMutable() || F->isUnnamedBitfield())
+ continue;
+if (CXXRecordDecl *FieldType = F->getType()->getAsCXXRecor
thakis added a comment.
thanks!
Comment at: include/clang/AST/DeclCXX.h:405-416
@@ -404,1 +404,14 @@
+enum AllowConstDefInitKind {
+ ACDI_Unknown,
+ ACDI_Yes,
+ ACDI_No,
+};
+unsigned AllowConstDefaultInit : 3;
+AllowConstDefInitKind allowCons
thakis updated this revision to Diff 48373.
thakis marked an inline comment as done.
thakis added a comment.
address comments
http://reviews.llvm.org/D16552
Files:
include/clang/AST/DeclCXX.h
lib/AST/ASTImporter.cpp
lib/AST/DeclCXX.cpp
lib/Sema/SemaInit.cpp
lib/Serialization/ASTReader
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3799-3806
@@ -3780,4 +3798,10 @@
OffloadEntriesInfoManager.registerTargetRegionEntryInfo(
DeviceID, FileID, ParentName, Line, OutlinedFn, OutlinedFnID);
}
+/// \brief Emit the num_teams clause
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932
@@ +3900,34 @@
+// Reference types are ignored for mapping purposes.
+if (auto *RefTy = ExprTy->getAs())
+ ExprTy = RefTy->getPointeeType().getCanonicalType();
+
+// Given that an
Author: dcoughlin
Date: Thu Feb 18 13:13:30 2016
New Revision: 261243
URL: http://llvm.org/viewvc/llvm-project?rev=261243&view=rev
Log:
[analyzer] Improve modeling of ObjC synthesized property setters.
When modeling a call to a setter for a property that is synthesized to be
backed by an instance
jfb added a comment.
Added a test.
Constraint validation is lacking in LLVM: it doesn't check that the input
variable matches the constraint. I do pass `mfpmath vfp` to the test in case
this gets fixed, but it's not strictly necessary right now.
The following is currently accepted:
int oops
carlo.bertolli updated this revision to Diff 48369.
carlo.bertolli added a comment.
Addressed latest comments.
Repository:
rL LLVM
http://reviews.llvm.org/D17148
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/teams_codege
carlo.bertolli marked 4 inline comments as done.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4426-4431
@@ +4425,8 @@
+ SourceLocation Loc) {
+ llvm::Value *PushNumTeamsArgs[] = {
+ emitUpdateLocation(CGF, Loc), getThreadID(CGF, Loc), N
rsmith added inline comments.
Comment at: include/clang/AST/DeclCXX.h:405-416
@@ -404,1 +404,14 @@
+enum AllowConstDefInitKind {
+ ACDI_Unknown,
+ ACDI_Yes,
+ ACDI_No,
+};
+unsigned AllowConstDefaultInit : 3;
+AllowConstDefInitKind allowConstDef
sfantao added a comment.
Hi Alexey,
Thanks for the feedback!
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932
@@ +3900,34 @@
+// Reference types are ignored for mapping purposes.
+if (auto *RefTy = ExprTy->getAs())
+ ExprTy = RefTy->getPointeeType().getCanonic
kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.
LGTM
Thanks!
I don't see much value in doing this, but also don't mind.
http://reviews.llvm.org/D17397
___
cfe-commits mailing list
cfe-commits@lists.
jfb updated this revision to Diff 48363.
jfb added a comment.
- Add test.
http://reviews.llvm.org/D17349
Files:
lib/Basic/Targets.cpp
test/CodeGen/arm-vfp-asm-constraint.c
Index: test/CodeGen/arm-vfp-asm-constraint.c
===
--- /
Anastasia added a comment.
@Mats, I think I would prefer not to add even more special handling (i.e. error
in this case) for printf.
I will look into adding it as a Builtin instead. However, I would prefer to
remove it from this change and submit a separate patch as it doesn't belong to
Clang
thakis created this revision.
thakis added a reviewer: kcc.
thakis added a subscriber: cfe-commits.
http://reviews.llvm.org/D17397
Files:
lib/Driver/SanitizerArgs.cpp
test/Driver/fsanitize-coverage.c
Index: test/Driver/fsanitize-coverage.c
davidxl added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:150
@@ -149,2 +149,3 @@
- if (!CodeGenOpts.InstrProfileInput.empty()) {
+ if (!CodeGenOpts.hasProfileIRInstr() &&
+ !CodeGenOpts.InstrProfileInput.empty()) {
Better to use if (CodeGe
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D16012#351827, @rsmith wrote:
> I'm definitely sympathetic to making `StringLiteralParser` expose information
> [...]
I was unaware of this class; so far I have only studied the classes appearing
in the AST.
I did notice that the
Hi all
I put up some patches for embedding bitcode inside the object file
(-fembed-bitcode) option. As I described in the dev list before, the new option
can create normal object file with bitcode embedded in a special section. You
can easily recreate the same object file with the embedded bitc
thakis added inline comments.
Comment at: include/clang/AST/DeclCXX.h:410
@@ +409,3 @@
+};
+unsigned AllowConstDefaultInit : 3;
+AllowConstDefInitKind allowConstDefInitKind() {
This should be :2 of course.
http://reviews.llvm.org/D16552
__
manmanren added a comment.
> If Capacity is not a multiple of 8, (LocalSize + NumBytesAtAlign4) % 8
> doesn't tell you whether the new element will be 8-byte aligned. For example,
> if Capacity==36, NumBytesAtAlign4==4, and LocalSize==8, (LocalSize +
> NumBytesAtAlign4) equals 12 but padding
Author: bcraig
Date: Thu Feb 18 11:37:33 2016
New Revision: 261230
URL: http://llvm.org/viewvc/llvm-project?rev=261230&view=rev
Log:
Split locale management out of ibm/xlocale.h. NFCI
This is one part of many of a locale refactor. See
http://reviews.llvm.org/D17146 for an idea of where this is go
Author: bcraig
Date: Thu Feb 18 11:40:16 2016
New Revision: 261231
URL: http://llvm.org/viewvc/llvm-project?rev=261231&view=rev
Log:
Split locale management out of newlib/xlocale.h. NFCI
This is one part of many of a locale refactor. See
http://reviews.llvm.org/D17146 for an idea of where this is
steven_wu created this revision.
steven_wu added a subscriber: cfe-commits.
steven_wu added a dependency: D17390: Introduce -fembed-bitcode driver option.
Teach clang to embed bitcode inside bitcode. When -fembed-bitcode cc1
option is used, clang will embed both the input bitcode and cc1
commandli
steven_wu abandoned this revision.
steven_wu added a comment.
I accidentally send this patch with everything in it. I will send out patch in
small chunks instead.
http://reviews.llvm.org/D17389
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
steven_wu created this revision.
steven_wu added a subscriber: cfe-commits.
This is the clang driver part of the change to embedded bitcode. This
includes:
1. -fembed-bitcode option which breaks down the compilation into two
stages. The first stage emits optimized bitcode and the second stage
comp
steven_wu created this revision.
steven_wu added a subscriber: cfe-commits.
Herald added subscribers: dschuff, jfb.
Teach clang to embed bitcode inside bitcode. When -fembed-bitcode cc1
option is used, clang will embed both the input bitcode and cc1
commandline into the bitcode in special sections
aaron.ballman created this revision.
aaron.ballman added reviewers: alexfh, sbenza.
aaron.ballman added a subscriber: cfe-commits.
This patch adds a check for the CERT secure coding rule: FLP30-C. Do not use
floating-point variables as loop counters. It flags any for loop induction
expression th
mprobst updated this revision to Diff 48338.
mprobst added a comment.
Fixed typo.
http://reviews.llvm.org/D17385
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
===
--- u
On Thu, Feb 18, 2016 at 8:47 AM, Akira Hatanaka wrote:
> On Thu, Feb 18, 2016 at 8:10 AM, Manman Ren wrote:
>
>>
>>
>> On Wed, Feb 17, 2016 at 10:33 PM, Akira Hatanaka
>> wrote:
>>
>>> ahatanak added a comment.
>>>
>>> OK, I now understand what you meant.
>>>
>>> > How about the following?
>>>
On Thu, Jan 14, 2016 at 5:36 AM, Daniel Jasper via cfe-commits
wrote:
> Author: djasper
> Date: Thu Jan 14 07:36:46 2016
> New Revision: 257763
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257763&view=rev
> Log:
> clang-format: Fix incorrectly enforced linebreak with ColumnLimit 0.
>
> Before:
1 - 100 of 142 matches
Mail list logo
