danielmarjamaki marked 2 inline comments as done.
Comment at: docs/clang-tidy/checks/readability-non-const-parameter.rst:15
@@ +14,3 @@
+
+ // warning here; p should be const
+ char f1(char *p) {
LegalizeAdulthood wrote:
> With pointers, there are always two lay
On Tue, Feb 16, 2016 at 10:01 PM, Ryan Yee via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> ryee88 updated this revision to Diff 48149.
> ryee88 added a comment.
>
> Keeping the number of test files to a minimum makes sense.
>
> Couldn't find an existing test for this diagnostic.
That woul
Ugh... That is most scary. Do you happen to know if this occurred with Gold,
GNU ld or both? I had tested this patch on Darwin, FreeBSD and Linux with GNU
ld. For that error to happen it means that the linker isn't handling
-order_file as an invalid argument instead it is treating it as a "-o" a
ryee88 updated this revision to Diff 48149.
ryee88 added a comment.
Keeping the number of test files to a minimum makes sense.
Couldn't find an existing test for this diagnostic. I did find a
cxx-reference.cpp that tests reference diagnostics so this seems like a
reasonable location for this ne
ABataev added a comment.
Carlo, thanks for the patch! Please update the code to trunk HEAD
Comment at: lib/CodeGen/CGOpenMPRuntime.h:677
@@ -676,1 +676,3 @@
+ virtual bool isStaticNonchunked(OpenMPDistScheduleClauseKind ScheduleKind,
+ bool Ch
On Thu, Feb 4, 2016 at 8:12 PM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Thu Feb 4 22:12:40 2016
> New Revision: 259874
>
> URL: http://llvm.org/viewvc/llvm-project?rev=259874&view=rev
> Log:
> CodeGen: correct Windows ARM C++ assertion
>
compnerd added a comment.
This change seems fine to me as is, just waiting to iron out the macro
situation with @logan before accepting it.
Comment at: lib/Headers/unwind.h:61
@@ +60,3 @@
+#define _UNWIND_ARM_EHABI 0
+#endif
+
logan wrote:
> Since this is `unwi
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3901-3932
@@ +3900,34 @@
+// Reference types are ignored for mapping purposes.
+if (auto *RefTy = ExprTy->getAs())
+ ExprTy = RefTy->getPointeeType().getCanonicalType();
+
+// Given that an
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3811-3818
@@ -3789,1 +3810,10 @@
DeviceID, FileID, ParentName, Line, Column, OutlinedFn, OutlinedFnID);
+
+ // If the current target region has a teams region enclosed, we need to get
+ // the numb
jlebar updated this revision to Diff 48143.
jlebar added a comment.
Fix typo.
http://reviews.llvm.org/D17313
Files:
lib/CodeGen/CGCall.cpp
test/CodeGenCUDA/convergent.cu
test/CodeGenCUDA/device-var-init.cu
Index: test/CodeGenCUDA/device-var-init.cu
===
FYI, I had to revert this in r261054 because it caused Linux links to write
the output to 'rder_file' in all cases. See that commit for some details,
and I think several build bots hit this as well. Happy to chat to help
figure out what to do long term.
-Chandler
On Fri, Feb 12, 2016 at 1:41 PM C
Author: chandlerc
Date: Tue Feb 16 20:13:35 2016
New Revision: 261054
URL: http://llvm.org/viewvc/llvm-project?rev=261054&view=rev
Log:
[cmake] Revert r260742 (and r260744) to improve order file support.
This appears to be passing '-Wl,-order_file' to Linux link commands,
which then causes the li
Btw, thanks to nlewycky to pointing this out.
-- Sean Silva
On Tue, Feb 16, 2016 at 6:08 PM, Sean Silva via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: silvas
> Date: Tue Feb 16 20:08:19 2016
> New Revision: 261053
>
> URL: http://llvm.org/viewvc/llvm-project?rev=261053&view=rev
>
Author: silvas
Date: Tue Feb 16 20:08:19 2016
New Revision: 261053
URL: http://llvm.org/viewvc/llvm-project?rev=261053&view=rev
Log:
[AttrDocs.td] Fix up some reST syntax.
Modified:
cfe/trunk/include/clang/Basic/AttrDocs.td
Modified: cfe/trunk/include/clang/Basic/AttrDocs.td
URL:
http://llv
Author: davidxl
Date: Tue Feb 16 18:59:01 2016
New Revision: 261047
URL: http://llvm.org/viewvc/llvm-project?rev=261047&view=rev
Log:
Test simplification
Modified:
cfe/trunk/test/Profile/def-assignop.cpp
Modified: cfe/trunk/test/Profile/def-assignop.cpp
URL:
http://llvm.org/viewvc/llvm-proj
Author: davidxl
Date: Tue Feb 16 18:58:13 2016
New Revision: 261046
URL: http://llvm.org/viewvc/llvm-project?rev=261046&view=rev
Log:
Restrengthen tests relaxed in r259955
Modified:
cfe/trunk/test/CoverageMapping/ir.c
cfe/trunk/test/CoverageMapping/unused_names.c
Modified: cfe/trunk/test
jlebar created this revision.
jlebar added reviewers: rnk, majnemer.
jlebar added subscribers: tra, cfe-commits.
We need the notion of convergent functions -- which may expose
convergent behavior to callers -- and convergent calls, which are calls
where we would like to preserve convergent behavio
Author: mehdi_amini
Date: Tue Feb 16 18:42:20 2016
New Revision: 261045
URL: http://llvm.org/viewvc/llvm-project?rev=261045&view=rev
Log:
Teach clang to use the ThinLTO pipeline
Summary: Use the new pipeline implemented in D17115
Reviewers: tejohnson
Subscribers: joker.eph, cfe-commits
Differe
doug.gregor added a comment.
The approach and patch look okay to me, but can we give "UnavailableCheck" a
less ambiguous name? For example, "TreatUnavailableAsInvalid"?
http://reviews.llvm.org/D15314
___
cfe-commits mailing list
cfe-commits@lists.l
Author: arsenm
Date: Tue Feb 16 18:27:27 2016
New Revision: 261042
URL: http://llvm.org/viewvc/llvm-project?rev=261042&view=rev
Log:
amdgcn: Use new workitem intrinsics
Added:
libclc/trunk/amdgcn/lib/workitem/
libclc/trunk/amdgcn/lib/workitem/get_group_id.ll
libclc/trunk/amdgcn/lib/wo
Author: arsenm
Date: Tue Feb 16 18:27:31 2016
New Revision: 261043
URL: http://llvm.org/viewvc/llvm-project?rev=261043&view=rev
Log:
Add .gitignore for build directories
Added:
libclc/trunk/.gitignore
Added: libclc/trunk/.gitignore
URL:
http://llvm.org/viewvc/llvm-project/libclc/trunk/.giti
rsmith closed this revision.
rsmith added a comment.
Committed as r261034.
http://reviews.llvm.org/D16930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Tue Feb 16 18:04:04 2016
New Revision: 261034
URL: http://llvm.org/viewvc/llvm-project?rev=261034&view=rev
Log:
Improve diagnostics for ill-formed literal operator declarations.
Patch by Erik Pilkington!
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
jpienaar added inline comments.
Comment at: test/CodeGen/lanai-arguments.c:1
@@ +1,2 @@
+// RUN: %clang_cc1 -triple wasm32-unknown-unknown %s -emit-llvm -o - \
+// RUN: | FileCheck %s -check-prefix=LANAI
eliben wrote:
> why wasm triple?
Fixed, thanks.
http://r
jpienaar updated the summary for this revision.
jpienaar updated this revision to Diff 48119.
jpienaar marked an inline comment as done.
jpienaar added a comment.
Herald added a subscriber: joker.eph.
Move mregparm check to Tools.cpp and correct triple used in test.
http://reviews.llvm.org/D1700
On Tue, Feb 16, 2016 at 3:36 PM, Richard Smith wrote:
> On Tue, Feb 16, 2016 at 1:48 PM, H.J. Lu wrote:
>> On Tue, Feb 16, 2016 at 1:45 PM, Richard Smith wrote:
>>> On Tue, Feb 16, 2016 at 1:21 PM, H.J. Lu wrote:
On Tue, Feb 16, 2016 at 1:15 PM, Richard Smith
wrote:
> On Tue, Fe
On Tue, Feb 16, 2016 at 1:48 PM, H.J. Lu wrote:
> On Tue, Feb 16, 2016 at 1:45 PM, Richard Smith wrote:
>> On Tue, Feb 16, 2016 at 1:21 PM, H.J. Lu wrote:
>>> On Tue, Feb 16, 2016 at 1:15 PM, Richard Smith
>>> wrote:
On Tue, Feb 16, 2016 at 1:10 PM, H.J. Lu wrote:
> On Tue, Feb 16, 2
rsmith added a comment.
The direction here looks fine to me.
Comment at: lib/Sema/SemaInit.cpp:369
@@ +368,3 @@
+ ND = dyn_cast(ND->getParent())) {
+if (S.getStdNamespace()->InEnclosingNamespaceSetOf(ND))
+ return true;
I wonder if this recursion
thakis updated this revision to Diff 48115.
thakis added a comment.
Ok, that was just a bug. Now all libstdc++5.3 cases I tried build. Still not
production-quality, but the overall direction won't change. If you want to
comment on that, please do, else I'll ping this again after I've cleaned it
bcraig added a comment.
So does this latest revision get the check-mark of approval?
http://reviews.llvm.org/D15539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig marked an inline comment as done.
bcraig added a comment.
http://reviews.llvm.org/D16545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig marked 6 inline comments as done.
bcraig added a comment.
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig updated this revision to Diff 48113.
bcraig added a comment.
Addressed EricWF's feedback (hopefully).
http://reviews.llvm.org/D16544
Files:
test/CMakeLists.txt
test/libcxx/test/config.py
test/libcxx/test/target_info.py
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
===
Thanks. I'll commit using a MIPS ifdef in the morning and merge once it's
through the buildbots.
From: Marshall Clow [mclow.li...@gmail.com]
Sent: 16 February 2016 22:37
To: Daniel Sanders; h...@chromium.org; mclow.li...@gmail.com
Cc: cfe-commits@lists.llvm
bcraig updated this revision to Diff 48112.
bcraig added a comment.
Addressed EricWF's feedback.
http://reviews.llvm.org/D16545
Files:
CMakeLists.txt
test/CMakeLists.txt
test/libcxxabi/test/config.py
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
=
logan added a comment.
In general, it looks good to me if the comments are addressed.
Sorry for not replying responsively. Not sure why I missed the follow-up
e-mails after @rengolin's reply.
Comment at: lib/Headers/unwind.h:61
@@ +60,3 @@
+#define _UNWIND_ARM_EHABI 0
+#endif
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Let's wrap it in a MIPS ifdef for the moment, and then, post-release we can see
if that can be relaxed.
Given that, LGTM.
http://reviews.llvm.org/D17132
george.burgess.iv updated this revision to Diff 48111.
george.burgess.iv added a comment.
- Reworded docs update
- Added support for `reinterpret_cast`s of overloaded functions in both C and
C++
- Added general facility in `Sema` to query if an overloaded expression can
resolve to being not-over
mclow.lists added a comment.
> Any objections to using the original sizes, but constructing the objects at
> global scope?
I think that should work.
http://reviews.llvm.org/D15539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
jbcoe added a comment.
It's more than the warning because it offers fixits. Other than that it should
be the same. Using the same code as used to warn on deprecated special members
would be a great idea. I'm not too sure where to start looking and how much of
Sema is exposed to clang-tidy thoug
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261018: [CUDA] pass debug options to ptxas. (authored by
tra).
Changed prior to commit:
http://reviews.llvm.org/D17111?vs=47680&id=48108#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17111
Files
Author: tra
Date: Tue Feb 16 16:03:20 2016
New Revision: 261018
URL: http://llvm.org/viewvc/llvm-project?rev=261018&view=rev
Log:
[CUDA] pass debug options to ptxas.
ptxas optimizations are disabled if we need to generate debug info
as ptxas does not accept '-g' otherwise.
Differential Revision:
Hi Ben,
> FYI, this change and the LLVM version have each broken my libcxx
> builds. I cross compile from Linux x64 to Hexagon, and my host machine
> doesn't have . The LLVM change was particularly offensive
> because I wasn't planning on building LLVM itself.
There's no change on the LLVM side
Hi Ben,
Does 'this change' refer to r260235 or r260961?
From: cfe-commits [cfe-commits-boun...@lists.llvm.org] on behalf of Craig, Ben
via cfe-commits [cfe-commits@lists.llvm.org]
Sent: 16 February 2016 21:09
To: cfe-commits@lists.llvm.org
Subject: Re: [li
thakis updated this revision to Diff 48107.
thakis added a comment.
Checkpointing; not production quality. I tried implementing the general DR 253
rule, and this patch mostly does that. It currently walks all fields and all
bases for every const record decl; there should probably be a cache for
dsanders added a comment.
Sorry for the early ping but I need to fix this for rc3 (which Hans is hoping
to tag mid-week) and I'm stuck as long as the requirement that the C++ tests in
r260527 fail without my patch is in place.
I'm happy to make this '#ifdef __mips__' if that helps.
http://rev
On Tue, Feb 16, 2016 at 1:45 PM, Richard Smith wrote:
> On Tue, Feb 16, 2016 at 1:21 PM, H.J. Lu wrote:
>> On Tue, Feb 16, 2016 at 1:15 PM, Richard Smith wrote:
>>> On Tue, Feb 16, 2016 at 1:10 PM, H.J. Lu wrote:
On Tue, Feb 16, 2016 at 1:02 PM, Richard Smith
wrote:
> On Tue, Fe
On Tue, Feb 16, 2016 at 1:21 PM, H.J. Lu wrote:
> On Tue, Feb 16, 2016 at 1:15 PM, Richard Smith wrote:
>> On Tue, Feb 16, 2016 at 1:10 PM, H.J. Lu wrote:
>>> On Tue, Feb 16, 2016 at 1:02 PM, Richard Smith
>>> wrote:
On Tue, Feb 16, 2016 at 12:25 PM, H.J. Lu wrote:
> On Tue, Feb 16,
On Tue, Feb 16, 2016 at 1:15 PM, Richard Smith wrote:
> On Tue, Feb 16, 2016 at 1:10 PM, H.J. Lu wrote:
>> On Tue, Feb 16, 2016 at 1:02 PM, Richard Smith wrote:
>>> On Tue, Feb 16, 2016 at 12:25 PM, H.J. Lu wrote:
On Tue, Feb 16, 2016 at 12:22 PM, Richard Smith
wrote:
> On Tue,
carlo.bertolli updated this revision to Diff 48100.
carlo.bertolli added a comment.
Address comments and rebase over new version of http://reviews.llvm.org/D17148.
Repository:
rL LLVM
http://reviews.llvm.org/D17170
Files:
include/clang/AST/StmtOpenMP.h
lib/CodeGen/CGOpenMPRuntime.cpp
l
On Tue, Feb 16, 2016 at 1:10 PM, H.J. Lu wrote:
> On Tue, Feb 16, 2016 at 1:02 PM, Richard Smith wrote:
>> On Tue, Feb 16, 2016 at 12:25 PM, H.J. Lu wrote:
>>> On Tue, Feb 16, 2016 at 12:22 PM, Richard Smith
>>> wrote:
On Tue, Feb 16, 2016 at 10:24 AM, H.J. Lu wrote:
>
> On Fri,
Is this anything more than the -Wdeprecated warning? (could we split out
the -Wdeprecated warning that deals with the deprecated implicit special
member generation, then just use that warning for this clang-tidy check?)
On Thu, Feb 11, 2016 at 3:16 PM, Jonathan B Coe via cfe-commits <
cfe-commits@
dblaikie added a comment.
Thanks - please commit when ready
http://reviews.llvm.org/D15977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Tue Feb 16 15:06:10 2016
New Revision: 261009
URL: http://llvm.org/viewvc/llvm-project?rev=261009&view=rev
Log:
Missing semicolons are kind of important. Who knew?
Modified:
cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.cpp
Modified: cfe/trunk/unittests/ASTMatche
On Tue, Feb 16, 2016 at 1:02 PM, Richard Smith wrote:
> On Tue, Feb 16, 2016 at 12:25 PM, H.J. Lu wrote:
>> On Tue, Feb 16, 2016 at 12:22 PM, Richard Smith
>> wrote:
>>> On Tue, Feb 16, 2016 at 10:24 AM, H.J. Lu wrote:
On Fri, Feb 12, 2016 at 11:39 AM, H.J. Lu wrote:
> On Fri,
FYI, this change and the LLVM version have each broken my libcxx
builds. I cross compile from Linux x64 to Hexagon, and my host machine
doesn't have . The LLVM change was particularly offensive
because I wasn't planning on building LLVM itself.
I have since worked around the issue by making
aaron.ballman closed this revision.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Thanks for the review and suggestions! I've commit in r261008.
http://reviews.llvm.org/D17034
___
cfe-commits mailing list
cfe-commits
Author: aaronballman
Date: Tue Feb 16 15:02:23 2016
New Revision: 261008
URL: http://llvm.org/viewvc/llvm-project?rev=261008&view=rev
Log:
Add a nullPointerConstant() AST matcher to handle variations of null pointer
constants in one matcher.
Modified:
cfe/trunk/docs/LibASTMatchersReference.h
On Tue, Feb 16, 2016 at 12:25 PM, H.J. Lu wrote:
> On Tue, Feb 16, 2016 at 12:22 PM, Richard Smith wrote:
>> On Tue, Feb 16, 2016 at 10:24 AM, H.J. Lu wrote:
>>>
>>> On Fri, Feb 12, 2016 at 11:39 AM, H.J. Lu wrote:
>>> > On Fri, Feb 12, 2016 at 6:58 AM, Matthijs van Duin
>>> > wrote:
>>> >> On
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
I have addressed some of the comments and restructured the code as requested.
Let me know about further comments.
Thanks for making this a better patch!
Comment at: lib/CodeGen/CGOpenMPRuntime.h:669
carlo.bertolli added a comment.
I have addressed some of the comments and restructured the code as requested.
Let me know about further comments.
Thanks for making this a better patch!
Repository:
rL LLVM
http://reviews.llvm.org/D17170
___
cfe-co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261005: Stop using "template" when printing qualtype names
(authored by rnk).
Changed prior to commit:
http://reviews.llvm.org/D17214?vs=47854&id=48095#toc
Repository:
rL LLVM
http://reviews.llvm.or
Author: rnk
Date: Tue Feb 16 14:34:27 2016
New Revision: 261005
URL: http://llvm.org/viewvc/llvm-project?rev=261005&view=rev
Log:
Stop using "template" when printing qualtype names
Summary:
The keyword "template" isn't necessary when
printing a fully-qualified qualtype name, and, in fact,
results
On Tue, Feb 16, 2016 at 12:22 PM, Richard Smith wrote:
> On Tue, Feb 16, 2016 at 10:24 AM, H.J. Lu wrote:
>>
>> On Fri, Feb 12, 2016 at 11:39 AM, H.J. Lu wrote:
>> > On Fri, Feb 12, 2016 at 6:58 AM, Matthijs van Duin
>> > wrote:
>> >> On 11 February 2016 at 16:31, H.J. Lu wrote:
>> >>> struct
On Tue, Feb 16, 2016 at 10:24 AM, H.J. Lu wrote:
>
> On Fri, Feb 12, 2016 at 11:39 AM, H.J. Lu wrote:
> > On Fri, Feb 12, 2016 at 6:58 AM, Matthijs van Duin
> > wrote:
> >> On 11 February 2016 at 16:31, H.J. Lu wrote:
> >>> struct A {
> >>> static void foo (void) ();
> >>> static int xxx;
> >>>
--- a/lib/Sema/SemaLookup.cpp
+++ b/lib/Sema/SemaLookup.cpp
@@ -419,6 +419,25 @@ static bool isPreferredLookupResult(Sema &S,
Sema::LookupNameKind Kind,
}
}
+ // VarDecl can have incomplete array types, prefer the one with more complete
+ // array type.
+ if (VarDecl *DVD = dyn_cast(DUn
Hi Hans,
> Or is this comment on PR26059 all that needs to be done for 3.8?
That's correct. I wrote that comment in order to clarify which bits we should
merge in 3.8.
The latest commit:
- [libcxx] r260961 - Issue a warning instead of fatal errors when checks for
libatomic fail."
makes sure
On 16 Feb 2016, at 18:51, Hans Wennborg wrote:
>
> On Sun, Feb 14, 2016 at 8:14 AM, Dimitry Andric wrote:
>> On 14 Feb 2016, at 17:08, Dimitry Andric via cfe-commits
>> wrote:
>>>
>>> Author: dim
>>> Date: Sun Feb 14 10:08:20 2016
>>> New Revision: 260851
>>>
>>> URL: http://llvm.org/viewvc/
aaron.ballman marked 2 inline comments as done.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:4838
@@ +4837,3 @@
+ gnuNullExpr(), cxxNullPtrLiteralExpr(),
+ integerLiteral(equals(0), hasParent(expr(hasType(pointerType());
+}
Ah, good catch! No,
aaron.ballman updated this revision to Diff 48092.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Removed an unnecessary expr() matcher.
http://reviews.llvm.org/D17034
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTM
Or is this comment on PR26059 all that needs to be done for 3.8?
"Bug 26369, which has been fixed with r260961, requires the following
commits to get merged on the release branch:
- [libcxx] r260515 - Re-commit "Introduce a cmake module to figure out
whether we need to link with libatomic."
- [li
On Wed, Feb 10, 2016 at 2:50 AM, Alexey Bataev via cfe-commits
wrote:
> Author: abataev
> Date: Wed Feb 10 04:50:12 2016
> New Revision: 260370
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260370&view=rev
> Log:
> Fix PR26543: add a check for definition in CXXRecordDecl.
>
> Modified:
> cf
Do I understand correctly that there are still issues here's that are not fixed?
(I'm trying to understand if there is something here to merge for 3.8,
but I'm having trouble following these commits.)
On Tue, Feb 16, 2016 at 6:44 AM, Vasileios Kalintiris
wrote:
> I changed the type of message fr
sbenza added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:4838
@@ +4837,3 @@
+ gnuNullExpr(), cxxNullPtrLiteralExpr(),
+ expr(integerLiteral(equals(0),
hasParent(expr(hasType(pointerType()));
+}
aaron.ballman wrote:
> sbenza
aaron.ballman marked an inline comment as done.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:4838
@@ +4837,3 @@
+ gnuNullExpr(), cxxNullPtrLiteralExpr(),
+ expr(integerLiteral(equals(0),
hasParent(expr(hasType(pointerType()));
+}
sbenza wrote
Since this is just a wording change, presumably the diagnostic is already
tested in an existing file - perhaps you could exetendi that test to cover
this functionality (we try not to add new test files too much - better to
test functionality once/in one place as much as possible (both for ease of
r
saugustine requested a review of this revision.
saugustine added a comment.
Would you mind reviewing this, and checking it in if you find it acceptable?
http://reviews.llvm.org/D17214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
Author: rnk
Date: Tue Feb 16 13:16:28 2016
New Revision: 260994
URL: http://llvm.org/viewvc/llvm-project?rev=260994&view=rev
Log:
Exclude PCH/missing-file.cpp on Windows, it does not pass reliably
Tag the test with "REQUIRES: can-remove-opened-file", which is what we
use for the similar test Modu
Author: rnk
Date: Tue Feb 16 13:16:20 2016
New Revision: 260993
URL: http://llvm.org/viewvc/llvm-project?rev=260993&view=rev
Log:
[typo-correction] Apply name specifier corrections when forming a NNS
Previously we would leave behind the old name specifier prefix, which
creates an invalid AST. Ot
ping...
On 07/02/16 22:33, Vassil Vassilev wrote:
Improve a comment.
--Vassil
On 07/02/16 20:48, Vassil Vassilev wrote:
Would this patch be any better?
--Vassil
On 05/02/16 21:49, Richard Smith wrote:
This belongs in ASTDeclReader::attachPreviousDecl[Impl]. That's
where we propagate data that's
Author: nico
Date: Tue Feb 16 13:05:50 2016
New Revision: 260990
URL: http://llvm.org/viewvc/llvm-project?rev=260990&view=rev
Log:
clang-cl: Expose -isystem.
Like cl.exe, clang-cl allows adding system include directories via the
INCLUDE env var. Having a driver flag for this functionality is use
vsk created this revision.
vsk added reviewers: rsmith, benlangmuir.
vsk added a subscriber: cfe-commits.
If we try to read a corrupt pch, we can easily assert-fail or trigger invalid
memory accesses when manipulating ASTReader::RecordData objects. This problem
is easy enough to diagnose when asse
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGExpr.cpp:2937-2943
@@ -2936,2 +2936,9 @@
QualType BaseTy = Base.getType();
+ // If the base is a pointer, we actually need to compute the offset in the
+ // pointee.
+ if (BaseTy->isAnyPo
carlo.bertolli added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:759
@@ +758,3 @@
+ ///
+ void emitForStaticInitWithKMPSchedule(CodeGenFunction &CGF,
+SourceLocation Loc,
carlo.bertolli wrote:
> I added this
On Fri, Feb 12, 2016 at 11:39 AM, H.J. Lu wrote:
> On Fri, Feb 12, 2016 at 6:58 AM, Matthijs van Duin
> wrote:
>> On 11 February 2016 at 16:31, H.J. Lu wrote:
>>> struct A {
>>> static void foo (void) ();
>>> static int xxx;
>>> };
>>
>> What about it? It's an empty struct. (And it declares a f
On Sun, Feb 14, 2016 at 8:14 AM, Dimitry Andric wrote:
> On 14 Feb 2016, at 17:08, Dimitry Andric via cfe-commits
> wrote:
>>
>> Author: dim
>> Date: Sun Feb 14 10:08:20 2016
>> New Revision: 260851
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=260851&view=rev
>> Log:
>> As reported in http
eliben added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:6498
@@ +6497,3 @@
+
+ Class classify(QualType Ty) const;
+
jpienaar wrote:
> We only had one DefaultNumRegisterParameters that we supported
> (DefaultNumRegisterParameters=4) so I just propaga
jmolloy accepted this revision.
jmolloy added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D16929
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Marshall told me it's approved. Merged in r260983. Thanks, Hans
On Fri, Feb 12, 2016 at 10:34 AM, Hans Wennborg wrote:
> Marshall: ping?
>
> On Wed, Feb 3, 2016 at 5:08 PM, Hans Wennborg wrote:
>> I'm OK if Marshall is.
>>
>> Thanks,
>> Hans
>>
>> On Wed, Feb 3, 2016 at 4:59 PM, Duncan P. N. Exo
Author: hans
Date: Tue Feb 16 11:17:42 2016
New Revision: 260983
URL: http://llvm.org/viewvc/llvm-project?rev=260983&view=rev
Log:
Merging r259682:
r259682 | dexonsmith | 2016-02-03 11:30:20 -0800 (Wed, 03 Feb 2016) | 7 lines
sbenza added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:4838
@@ +4837,3 @@
+ gnuNullExpr(), cxxNullPtrLiteralExpr(),
+ expr(integerLiteral(equals(0),
hasParent(expr(hasType(pointerType()));
+}
is this expr() necessary?
ht
Marshall told me this one's approved. Merged in r260982. Thanks, Hans
On Fri, Feb 12, 2016 at 10:22 AM, Hans Wennborg wrote:
> Marshall: ping?
>
> On Mon, Feb 1, 2016 at 1:48 PM, Hans Wennborg wrote:
>> Marshall: ping?
>>
>> On Tue, Jan 26, 2016 at 11:08 AM, Hans Wennborg wrote:
>>> On Tue, Jan
Author: hans
Date: Tue Feb 16 11:16:15 2016
New Revision: 260982
URL: http://llvm.org/viewvc/llvm-project?rev=260982&view=rev
Log:
Merging r258107:
r258107 | marshall | 2016-01-18 16:50:37 -0800 (Mon, 18 Jan 2016) | 1 line
F
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM, thanks
http://reviews.llvm.org/D17272
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
aaron.ballman updated this revision to Diff 48075.
aaron.ballman added a comment.
Using the AST_MATCHER_FUNCTION macro instead.
Using Expr::isNullPointerConstant() turns out to have strange behavior with
implicit casts and nullptr, and also requires further restrictions (for
instance, it claims
Author: marshall
Date: Tue Feb 16 10:05:15 2016
New Revision: 260975
URL: http://llvm.org/viewvc/llvm-project?rev=260975&view=rev
Log:
Add some status
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-project/l
pawosm01 added a comment.
You're right, this patch smuggles elimination of two dead functions. I've
prepared alternative version of this patch which does not do that.
Repository:
rL LLVM
http://reviews.llvm.org/D16929
___
cfe-commits mailing lis
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5046
@@ +5045,3 @@
+ if (D->hasAttr()) {
+S.Diag(D->getLocation(), diag::err_opencl_multiple_access_qualifiers)
+<< D->getSourceRange();
That's why I think it should be pointin
Author: marshall
Date: Tue Feb 16 08:42:23 2016
New Revision: 260966
URL: http://llvm.org/viewvc/llvm-project?rev=260966&view=rev
Log:
Add some comments
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-project
I changed the type of message from fatal_error to warning in r260961. While the
test for atomics works fine in most cases, it fails because we include
and , and the user's host compiler might not provide them
during a bootstrap (see PR26631 and PR26622).
Does anyone have any idea how to tackle
1 - 100 of 122 matches
Mail list logo
