This revision was automatically updated to reflect the committed changes.
Closed by commit rL260665: [clang-tidy] improve misc-misplaced-widening-cast so
it also detects… (authored by danielmarjamaki).
Changed prior to commit:
http://reviews.llvm.org/D17140?vs=47640&id=47771#toc
Repository:
Hahnfeld added a comment.
In http://reviews.llvm.org/D15920#350401, @beanz wrote:
> Can you commit the test changes in a separate commit before committing the
> other changes? That way if something goes wrong the diff for the meat of the
> patch is a small diff.
Committed seperately in http:/
Author: danielmarjamaki
Date: Fri Feb 12 01:51:10 2016
New Revision: 260665
URL: http://llvm.org/viewvc/llvm-project?rev=260665&view=rev
Log:
[clang-tidy] improve misc-misplaced-widening-cast so it also detects
portability problems.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revis
Author: hahnfeld
Date: Fri Feb 12 01:48:37 2016
New Revision: 260662
URL: http://llvm.org/viewvc/llvm-project?rev=260662&view=rev
Log:
[CMake] Add option to switch default C++ stdlib
With this option one can optionally override the architecture dependent
default library to use if no -stdlib= is p
Author: hahnfeld
Date: Fri Feb 12 01:48:28 2016
New Revision: 260661
URL: http://llvm.org/viewvc/llvm-project?rev=260661&view=rev
Log:
tests: Add explicit -stdlib=libstdc++ to tests that require it
This will be needed for the next commit that allows to switch the default
C++ library which would o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260662: [CMake] Add option to switch default C++ stdlib
(authored by Hahnfeld).
Changed prior to commit:
http://reviews.llvm.org/D15920?vs=47441&id=47770#toc
Repository:
rL LLVM
http://reviews.llvm.
AndyG added a comment.
To be honest, the simple answer is because it was just as easy to do with
nesting as without (the code would still need to track the appearance of left
and right parentheses in order to correctly parse to the closing
right-parenthesis of the macro invocation in any case).
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:669-692
@@ -668,1 +668,26 @@
+ /// \brief Schedule types for 'omp for' loops (these enumerators are taken
from
+ /// the enum sched_type in kmp.h).
+ enum OpenMPSchedType {
+ /// \brief Lower boun
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4378-4398
@@ +4377,23 @@
+
+ const OMPNumTeamsClause *NT = TD.getSingleClause();
+ const OMPThreadLimitClause *TL = TD.getSingleClause();
+ if (NT || TL) {
+NumTeamsVal = (NT) ? CGF.EmitScalarExpr(NT
Hubert,
Thanks for the code review. Over the weekend I'll try to learn a bit
more about using Phabricator, but for now I'll reply here, and attach
a new patch.
a) *_MANT_DIG < 1 --> *_MANT_DIG < 2
That is a stricter check and I agree with your rationale. Done.
b) _MIN_EXP --> FLT_MIN_EXP
Done.
jyknight added a comment.
In http://reviews.llvm.org/D17183#351065, @yaron.keren wrote:
> We have tried to keep one copy of DataLayout around
> http://reviews.llvm.org/D11103
> Can it share the Module->getDataLayout() ?
We're at the beginning of clang here, before preprocessing. There's no
l
yaron.keren added a subscriber: yaron.keren.
yaron.keren added a comment.
We have tried to keep one copy of http://reviews.llvm.org/D11103
Can it share the Module->getDataLayout() ?
http://reviews.llvm.org/D17183
___
cfe-commits mailing list
cfe-com
LegalizeAdulthood added a comment.
If someone could review the changes and commit this corrected version for me,
that would be great.
Patch by Richard Thomson.
http://reviews.llvm.org/D16308
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
LegalizeAdulthood added a comment.
Squeak?
http://reviews.llvm.org/D16529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LegalizeAdulthood added a comment.
Squeak?
http://reviews.llvm.org/D16953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 2/11/16 7:24 PM, Hans Wennborg wrote:
On Mon, Nov 9, 2015 at 8:12 AM, Jonathan Roelofs via cfe-commits
wrote:
Author: jroelofs
Date: Mon Nov 9 10:12:56 2015
New Revision: 252474
URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev
Log:
Create install targets for scan-build and sc
jyknight created this revision.
jyknight added a reviewer: echristo.
jyknight added a subscriber: cfe-commits.
Use it to calculate UserLabelPrefix, instead of specifying it (often
incorrectly).
Note that the *actual* user label prefix has always come from the
DataLayout, and is handled within LLV
Author: echristo
Date: Thu Feb 11 20:22:53 2016
New Revision: 260647
URL: http://llvm.org/viewvc/llvm-project?rev=260647&view=rev
Log:
Update functions in clang supplied headers to use the compiler reserved
namespace for arguments.
Modified:
cfe/trunk/lib/Headers/__clang_cuda_cmath.h
cfe/
On Mon, Nov 9, 2015 at 8:12 AM, Jonathan Roelofs via cfe-commits
wrote:
> Author: jroelofs
> Date: Mon Nov 9 10:12:56 2015
> New Revision: 252474
>
> URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev
> Log:
> Create install targets for scan-build and scan-view
>
> http://reviews.llvm.o
I'm following the thread on r260235 to figure out what to merge in this series.
On Thu, Feb 11, 2016 at 7:09 AM, Vasileios Kalintiris via cfe-commits
wrote:
> Hi Hans,
>
> Can we merge this on the release branch? It's a re-commit of D16613's patch
> with the an additional option (-gcc-toolchain)
jbcoe created this revision.
jbcoe added a reviewer: akyrtzi.
jbcoe added a subscriber: cfe-commits.
jbcoe set the repository for this revision to rL LLVM.
Order of compilation database commands has changed causing test failure.
Reordering fixes the test `cindex.test_cdb.test_all_compilecommand`
flx added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:206
@@ +205,3 @@
+ // Do not propose fixes in macros since we cannot place them correctly.
+ if (Ctor->getLocStart().isMacroID())
+return;
alexfh wrote:
> IIUC wha
flx updated this revision to Diff 47757.
flx marked 2 inline comments as done.
http://reviews.llvm.org/D16517
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
clang-tidy/
Hi Jorge,
I responded to the initial commit with some comments here:
http://reviews.llvm.org/rL260577
-- HT
On Thu, Feb 11, 2016 at 7:53 PM, Jorge Teixeira
wrote:
> > You'll also need to change to only provide DECIMAL_DIG in C99
> onwards.
> Done!
>
> > All of our -std versions are that stand
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, arpith-jacob, carlo.bertolli, kkwli0.
sfantao added subscribers: caomhin, fraggamuffin, cfe-commits.
Unlike other outlined regions in OpenMP, offloading entry points have to have
be visible (external linkage) for the device
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D16973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
rsmith added a subscriber: rsmith.
Comment at: lib/Lex/PPMacroExpansion.cpp:1438-1440
@@ -1432,3 +1437,5 @@
- // Get the module name.
- PP.LexNonComment(Tok);
+ // It is possible that the macro invocation has a multiple-nested argument,
+ // for example: __has_featureX))
On Thu, Feb 11, 2016 at 4:53 PM, Jorge Teixeira
wrote:
>> You'll also need to change to only provide DECIMAL_DIG in C99
>> onwards.
> Done!
>
>> All of our -std versions are that standard plus applicable Defect
>> Reports. So -std=c89 includes TC1 and TC2, but not Amendment 1 (we
>> have -std=c9
Author: rsmith
Date: Thu Feb 11 19:15:33 2016
New Revision: 260639
URL: http://llvm.org/viewvc/llvm-project?rev=260639&view=rev
Log:
: do not define DECIMAL_DIG in -std=c89 mode; this macro was added in
C99.
Patch by Jorge Teixeira!
Modified:
cfe/trunk/lib/Headers/float.h
cfe/trunk/test
Author: hans
Date: Thu Feb 11 19:01:37 2016
New Revision: 260637
URL: http://llvm.org/viewvc/llvm-project?rev=260637&view=rev
Log:
UsersManual: update clang-cl commands
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/viewvc/llvm-project
> You'll also need to change to only provide DECIMAL_DIG in C99
> onwards.
Done!
> All of our -std versions are that standard plus applicable Defect
> Reports. So -std=c89 includes TC1 and TC2, but not Amendment 1 (we
> have -std=c94 for that, but the only difference from our C89 mode is
> the a
jlebar added a comment.
lgtm
http://reviews.llvm.org/D16870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra updated this revision to Diff 47753.
tra marked 14 inline comments as done.
tra added a comment.
Addressed @jlebar's comments.
http://reviews.llvm.org/D16870
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaCUDA.cpp
lib/Sema/SemaOverload.cpp
test/CodeGenCUDA/function-overload.cu
test
No worries, I got it here:
dzur:~/sources/llvm/tools/clang> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/cfe/trunk ...
M lib/Headers/f16cintrin.h
Committed r260631
Thanks!
-eric
On Thu, Feb 11, 2016 at 2:20 PM Romanova, Katya <
katya_roman...@playstation.sony.com> wrote:
>
Author: echristo
Date: Thu Feb 11 18:32:23 2016
New Revision: 260631
URL: http://llvm.org/viewvc/llvm-project?rev=260631&view=rev
Log:
Use __ before argument names in provided headers.
Modified:
cfe/trunk/lib/Headers/f16cintrin.h
Modified: cfe/trunk/lib/Headers/f16cintrin.h
URL:
http://llvm
Author: aizatsky
Date: Thu Feb 11 18:29:45 2016
New Revision: 260630
URL: http://llvm.org/viewvc/llvm-project?rev=260630&view=rev
Log:
[sancov] improved object files handling.
Documentation change for: http://reviews.llvm.org/D17169
Differential Revision: http://reviews.llvm.org/D17175
Modified
jingyue added a comment.
I'll defer to Justin's approval.
http://reviews.llvm.org/D16870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, Sep 8, 2015 at 1:06 AM, John McCall via cfe-commits
wrote:
> Author: rjmccall
> Date: Tue Sep 8 03:05:57 2015
> New Revision: 246985
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246985&view=rev
> Log:
> Compute and preserve alignment more faithfully in IR-generation.
Might be worth m
jbcoe updated this revision to Diff 47747.
jbcoe added a comment.
Add missing test for types - apologies for noise.
http://reviews.llvm.org/D15654
Files:
bindings/python/clang/cppmodel.py
bindings/python/tests/cppmodel/__init__.py
bindings/python/tests/cppmodel/test_classes.py
bindings/
jbcoe updated this revision to Diff 47745.
jbcoe added a comment.
I've added more python classes to handle types and free functions.
http://reviews.llvm.org/D15654
Files:
bindings/python/clang/cppmodel.py
bindings/python/tests/cppmodel/__init__.py
bindings/python/tests/cppmodel/test_class
On Thu, Feb 11, 2016 at 3:42 PM, Jorge Teixeira
wrote:
> Richard,
>
> Thanks and got it re: test filename and hosted mode.
>
> 1) AFAIK, C89/C90 does not define DECIMAL_DIG, so here is a revised
> patch, with minor comment modifications to explicitly list the (draft)
> normative references that I
This should be less broken in r260622. We no longer assume that glibc
provides non-broken declarations of the functions. =(
On Thu, Feb 11, 2016 at 3:50 PM, Richard Smith wrote:
> The problem here is that your version of glibc has broken clang
> support -- see https://sourceware.org/ml/glibc-cvs
Author: rsmith
Date: Thu Feb 11 17:51:02 2016
New Revision: 260622
URL: http://llvm.org/viewvc/llvm-project?rev=260622&view=rev
Log:
Instead of asking glibc to provide correct C++ signatures for
functions, ask it whether it did provide them after the fact. Some versions of
glibc fail to compile i
The problem here is that your version of glibc has broken clang
support -- see https://sourceware.org/ml/glibc-cvs/2014-q4/msg00215.html
It looks like we may need Clang to start claiming to be GCC 4.4 or
later to work around these glibc issues.
On Thu, Feb 11, 2016 at 2:58 PM, Alexey Samsonov wr
Richard,
Thanks and got it re: test filename and hosted mode.
1) AFAIK, C89/C90 does not define DECIMAL_DIG, so here is a revised
patch, with minor comment modifications to explicitly list the (draft)
normative references that I used.
2) This might also be a good time to ask you what does clang
Author: joerg
Date: Thu Feb 11 17:35:03 2016
New Revision: 260617
URL: http://llvm.org/viewvc/llvm-project?rev=260617&view=rev
Log:
Remove decision logic for old NetBSD development versions, the 7.0
release made this obsolete.
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Dr
On Wed, Feb 10, 2016 at 09:26:44PM -0500, Sidney San Martín via cfe-commits
wrote:
> > On Feb 10, 2016, at 8:05 PM, Joerg Sonnenberger
> > wrote:
> >
> > I'm not a big fan of this. Those calls are by the very definition
> > harmless, so they aggrevate the existing problem of stupid annotation.
Author: joerg
Date: Thu Feb 11 17:18:36 2016
New Revision: 260616
URL: http://llvm.org/viewvc/llvm-project?rev=260616&view=rev
Log:
Now that Sparc/Sparc64 backend is mostly usable, provide the same
linking defaults as other NetBSD targets, i.e. compiler_rt-in-libc and
libc++ as STL.
Modified:
jbcoe added a comment.
Tests are now more thorough and more readable.
Insertions are always pre-insertions as getting the correct post-insertion
position is ambiguous if end-of-line comments exist.
Repository:
rL LLVM
http://reviews.llvm.org/D16376
___
jbcoe retitled this revision from "clang-tidy check: rule-of-five" to
"clang-tidy check: misc-deprecated-special-member-functions".
jbcoe updated the summary for this revision.
jbcoe set the repository for this revision to rL LLVM.
jbcoe updated this revision to Diff 47735.
jbcoe added a comment.
hubert.reinterpretcast added inline comments.
/cfe/trunk/test/Headers/float.c:113 This check is invalid. The requirement that
the set of values of the "smaller" types is a subset of the set of values the
"larger" type does not establish the relationship being checked here. In
particular, a larg
bcraig added a comment.
In http://reviews.llvm.org/D17146#350382, @mclow.lists wrote:
> > I'm open to recommendations on ways to test this that are better than
> > "Submit, watch build bots, revert as necessary".
>
>
> My suggestion is to do this incrementally.
> Implement the infrastructure bi
I see bogus boostrap build failures when we're trying to use just-built
Clang to build libc++:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/22540/steps/bootstrap%20clang/logs/stdio
Do you think it can be related to one of your changes? I'm pretty sure the
contents of /usr/inclu
hubert.reinterpretcast added a subscriber: cfe-commits.
Users:
rsmith (Author)
http://reviews.llvm.org/rL260577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.
Sorry that the change to overload resolution turned out to be problematic. :)
One nit, and this LGTM.
Comment at: lib/Sema/SemaExpr.cpp:7580
@@ +7579,3
jlebar added a comment.
Mostly comments on comments.
Comment at: lib/Sema/SemaCUDA.cpp:71
@@ -70,3 +70,3 @@
// H - handled in (x)
-// Preferences: b-best, f-fallback, l-last resort, n-never.
+// Preferences: +:native, *:host-device, o:same side, .:wrong side, -:never.
//
Author: rsmith
Date: Thu Feb 11 16:18:10 2016
New Revision: 260610
URL: http://llvm.org/viewvc/llvm-project?rev=260610&view=rev
Log:
Remove bogus check that larger floating point types have smaller minimum
normalized exponents. That's not true for double versus double double.
Modified:
cfe/tr
Sure. I’ll change it. Do you mind if I do it when I’m back from vacation (i.e.
a couple of weeks from now)?
I will send a patch.
Thank you!
Katya.
From: Eric Christopher [mailto:echri...@gmail.com]
Sent: Wednesday, February 10, 2016 5:08 PM
To: Romanova, Katya; cfe-commits@lists.llvm.org
Subject:
Author: dcoughlin
Date: Thu Feb 11 16:13:20 2016
New Revision: 260608
URL: http://llvm.org/viewvc/llvm-project?rev=260608&view=rev
Log:
[analyzer] Improve pattern matching in ObjCDealloc checker.
Look through PseudoObjectExpr and OpaqueValueExprs when scanning for
release-like operations. This co
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
Please also add a test that a `-Weverything` on the command line can be
overridden by a `#pragma clang diagnostic ignored "-Weverything"`, even for a
diagnostic with no warning flag. (Th
On Thu, Feb 11, 2016 at 10:50:29AM -0500, Ed Maste via llvm-commits wrote:
> On 8 February 2016 at 18:08, Joseph Myers wrote:
> > On Mon, 8 Feb 2016, H.J. Lu wrote:
> >
> >> >> I was referring to program properties:
> >> >>
> >> >> https://groups.google.com/forum/#!topic/generic-abi/fyIXttIsYc8
>
bcraig added inline comments.
Comment at: test/libcxx/test/config.py:469
@@ +468,3 @@
+if cxx_library_root:
+abs_path = cxx_library_root + "/libc++.a"
+self.cxx.link_flags += [abs_path]
EricWF wrote:
> Why no
Author: ericwf
Date: Thu Feb 11 15:45:53 2016
New Revision: 260601
URL: http://llvm.org/viewvc/llvm-project?rev=260601&view=rev
Log:
Fix LWG issue 2469 - Use piecewise construction in unordered_map::operator[].
unordered_map's allocator may only be used to construct objects of 'value_type',
or in
tra requested a review of this revision.
tra added a comment.
This revision is now accepted and ready to land.
@jingyue, @jlebar: can you take a look at the updated version?
http://reviews.llvm.org/D16870
___
cfe-commits mailing list
cfe-commits@lis
carlo.bertolli created this revision.
carlo.bertolli added reviewers: ABataev, fraggamuffin, kkwli0.
carlo.bertolli added subscribers: sfantao, arpith-jacob, cfe-commits.
carlo.bertolli set the repository for this revision to rL LLVM.
This patch provide basic implementation of codegen for teams di
Author: tnorthover
Date: Thu Feb 11 15:31:51 2016
New Revision: 260596
URL: http://llvm.org/viewvc/llvm-project?rev=260596&view=rev
Log:
Relax recently added clang version checks.
You can override the value of these during CMake, and we often use sentinels
with more than one digit (not to mention
benlangmuir added a comment.
> Now, we try to use the new YAML file + cache from a new clang invocation.
> When the FileManager requests status in (2) for the path
> "/install-dir/bin/../lib/clang/3.8.0/include/altivec.h" neither
> "remove_dots()" nor "realpath()" would be able to resolve it to
Author: rengolin
Date: Thu Feb 11 15:22:57 2016
New Revision: 260595
URL: http://llvm.org/viewvc/llvm-project?rev=260595&view=rev
Log:
[AArch64] Fix libunwind build when using GNU assembler
Use x29 and x30 for fp and lr respectively.
This does not change the code generation with integrated asm
b
yaxunl updated this revision to Diff 47716.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Revised as Anastasia suggested.
Changed comments.
http://reviews.llvm.org/D16686
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticP
bob.wilson created this revision.
bob.wilson added reviewers: cfe-commits, george.burgess.iv, doug.gregor, rsmith.
Herald added a subscriber: mcrosier.
This is a follow-up to PR26085. That was fixed in r257710 but the testcase
there was incomplete. There is a related issue where the overload reso
jlebar accepted this revision.
Comment at: lib/Driver/Tools.cpp:10696
@@ +10695,3 @@
+// ptxas does not accept -g option if optimization is enabled, so we ignore
+// compiler's -O* options if we want debug info.
+CmdArgs.push_back("-g");
Nit: ignore th
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
Sorry, this fell out of my radar. I'm ok with the changes. Ping me when you
commit so I can monitor the bot for a while.
http://reviews.llvm.org/D14293
Sunil_Srivastava updated this revision to Diff 47707.
Sunil_Srivastava added a comment.
Hi Richard,
> Can you move the special case code out of DiagnosticsEngine and into the
> pragma handler for now?
Yes. This is that approach.
http://reviews.llvm.org/D15095
Files:
lib/Lex/Pragma.cpp
t
bruno added a comment.
> I don't think this is the right approach. If we don't canonicalize the
> source path then:
>
> - looking up the path *without* the .. won't work, which means anything that
> looks up a realpath will fail
If we canonicalize, then it needs to be done in two places:
rengolin added a comment.
In http://reviews.llvm.org/D17124#350229, @mcrosier wrote:
> Committed r260555.
It would have been better to commit the LLVM parts first. Now, there will be a
range where kyro will be accepted by Clang but broken when it gets to setup the
target.
--renato
http://r
dsanders added a comment.
The table is apparently inside locale-archive and it looks like C and C++ both
share this table. At this point I'm satisfied that the table also contains
information that C++ isn't interested in and it's this data that regex_word
collides with.
Are you happy to lift t
Author: rsmith
Date: Thu Feb 11 14:36:47 2016
New Revision: 260583
URL: http://llvm.org/viewvc/llvm-project?rev=260583&view=rev
Log:
XFAIL this test for PPC64 for now. It looks like the *_MIN_EXP macros are in
fact defined incorrectly for that target.
Modified:
cfe/trunk/test/Headers/float.c
sbenza created this revision.
sbenza added a reviewer: alexfh.
sbenza added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Add matcher hasAnyName as an optimization over anyOf(hasName(),...)
http://reviews.llvm.org/D17163
Files:
docs/LibASTMatchersReference.html
docs/tools/dum
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 260581.
Repository:
rL LLVM
http://reviews.llvm.org/D17076
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: cbertol
Date: Thu Feb 11 14:12:28 2016
New Revision: 260581
URL: http://llvm.org/viewvc/llvm-project?rev=260581&view=rev
Log:
Add parse+sema and regression test for OpenMP firstprivate clause of target
directive
Added:
cfe/trunk/test/OpenMP/target_firstprivate_messages.cpp
Modified:
On Thu, Feb 11, 2016 at 11:04 AM, Ben Langmuir wrote:
> FYI I changed this to early-exit again in r260563 to fix implicit builds.
> It’s not safe to keep reading if we haven’t told ReadOptionsBlock to expect
> failures, since it will itself early-exit, leaving the stream in the middle
> of a block
Thanks, I modified the test to also test C89 and C99 modes and
committed this as r260577.
On Thu, Feb 11, 2016 at 11:29 AM, Jorge Teixeira
wrote:
> Here is a revised test, which I renamed to c11-5_2_4_2_2p11.c instead
> of float.c because I am only checking a subset of what the standard
> mandate
Author: rsmith
Date: Thu Feb 11 13:57:37 2016
New Revision: 260577
URL: http://llvm.org/viewvc/llvm-project?rev=260577&view=rev
Log:
In C11, provide macros FLT_DECIMAL_DIG, DBL_DECIMAL_DIG, and LDBL_DECIMAL_DIG
in .
Patch by Jorge Teixeira!
Added:
cfe/trunk/test/Headers/float.c
Modified:
dsanders added a comment.
I haven't fully proven this yet (because I haven't found the table), but I
think that C and C++ are sharing the same table and we're colliding with a bit
that only makes sense to C. This would explain why your tests don't fail but
regex_word still collides with _ISgrap
carlo.bertolli removed rL LLVM as the repository for this revision.
carlo.bertolli updated this revision to Diff 47695.
carlo.bertolli added a comment.
Remove handling of reductions - not supported by this patch.
http://reviews.llvm.org/D17148
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/Code
> On Feb 11, 2016, at 11:04 AM, Ben Langmuir wrote:
>
> FYI I changed this to early-exit again in r260563 to fix implicit builds.
> It’s not safe to keep reading if we haven’t told ReadOptionsBlock to expect
> failures, since it will itself early-exit, leaving the stream in the middle
> of a
hintonda added a comment.
Thanks Marshall.
Btw, I don't have commit access, so if approved, could someone commit this for
me?
http://reviews.llvm.org/D16946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Should be fixed in r260570.
On Thu, Feb 11, 2016 at 11:28 AM, Richard Smith wrote:
> Argh, the glibc folks broke their string.h and wchar.h prototypes in
> this commit:
>
> https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8e2e833ac4d6509b152d6b8d74d388725717c56f
>
> On Thu, Feb 11, 2016 at 11:
Author: rsmith
Date: Thu Feb 11 13:40:06 2016
New Revision: 260570
URL: http://llvm.org/viewvc/llvm-project?rev=260570&view=rev
Log:
Work around regression in glibc 2.22: request that glibc provides the correct
prototypes for functions that are converted into overload sets in
C++. This matches th
mclow.lists added a comment.
This looks fine to me. I think this should be committed.
http://reviews.llvm.org/D16946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz added a comment.
Everything about this looks reasonable to me.
Can you commit the test changes in a separate commit before committing the
other changes? That way if something goes wrong the diff for the meat of the
patch is a small diff.
http://reviews.llvm.org/D15920
___
Here is a revised test, which I renamed to c11-5_2_4_2_2p11.c instead
of float.c because I am only checking a subset of what the standard
mandates for float.h, and because there were similar precedents, like
test/Preprocessor/c99-*.c. Feel free to override, though.
The first part checks for basic
mclow.lists added a comment.
> ctype_base is defining graph by combining alnum and punct instead of using
> the _IS* macro like the other bits.
Because that's how the standard (22.4.1) shows to do it :-)
> I'm not sure where it's getting the definition of classic_table. Presumably
> it's comi
Argh, the glibc folks broke their string.h and wchar.h prototypes in
this commit:
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8e2e833ac4d6509b152d6b8d74d388725717c56f
On Thu, Feb 11, 2016 at 11:02 AM, Ismail Donmez wrote:
> Hi,
>
> On Wed, Feb 10, 2016 at 2:59 AM, Richard Smith via cfe-c
Author: mren
Date: Thu Feb 11 13:19:18 2016
New Revision: 260567
URL: http://llvm.org/viewvc/llvm-project?rev=260567&view=rev
Log:
[PR26550] Use a different TBAA root for C++ vs C.
This commit changes the root from "Simple C/C++ TBAA" to "Simple C++ TBAA" for
C++.
The problem is that the type na
mclow.lists added a comment.
I am very much in favor of cleaning up this part of libc++.
Thanks for taking this on.
> I'm open to recommendations on ways to test this that are better than
> "Submit, watch build bots, revert as necessary".
My suggestion is to do this incrementally.
Implement t
FYI I changed this to early-exit again in r260563 to fix implicit builds. It’s
not safe to keep reading if we haven’t told ReadOptionsBlock to expect
failures, since it will itself early-exit, leaving the stream in the middle of
a block. It’s also a performance advantage to early exit when doi
Hi,
On Wed, Feb 10, 2016 at 2:59 AM, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Tue Feb 9 18:59:02 2016
> New Revision: 260337
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260337&view=rev
> Log:
> Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from
> and
AndyG added a comment.
Test comment -- just to see whether email notifications are sending properly
(it seems, for example, that cfe-commits wasn't notified of this patch...)
http://reviews.llvm.org/D17149
___
cfe-commits mailing list
cfe-commits@l
Author: benlangmuir
Date: Thu Feb 11 12:54:02 2016
New Revision: 260563
URL: http://llvm.org/viewvc/llvm-project?rev=260563&view=rev
Log:
[Modules] Early-exit if ReadOptionsBlock fails to avoid crashing
If we didn't tell ReadOptionsBlock to allow failures then we can't
assume that the stream is n
1 - 100 of 202 matches
Mail list logo
