alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks!
http://reviews.llvm.org/D16764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
ariccio added a comment.
All clear. Ready for landing?
http://reviews.llvm.org/D16873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ariccio updated this revision to Diff 47161.
ariccio added a comment.
Responded to comments (fixed the bug noticed in review), and changed names.
http://reviews.llvm.org/D16873
Files:
llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h
llvm/tools/clang/lib/StaticAna
ariccio marked 3 inline comments as done.
ariccio added a comment.
Alrighty, will update the diff momentarily.
http://reviews.llvm.org/D16873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260074: [Concepts] Implement a portion of Concepts
TS[dcl.spec.concept]p1 by (authored by nwilson).
Changed prior to commit:
http://reviews.llvm.org/D13357?vs=46863&id=47160#toc
Repository:
rL LLVM
Author: nwilson
Date: Sun Feb 7 23:34:00 2016
New Revision: 260074
URL: http://llvm.org/viewvc/llvm-project?rev=260074&view=rev
Log:
[Concepts] Implement a portion of Concepts TS[dcl.spec.concept]p1 by
diagnosing when 'concept' is specified on a function or template
specialization.
Since a conce
dcoughlin added a comment.
I think Aleksei is right and I was wrong.
If you follow his advice and move the call to
getStackOrCaptureRegionForDeclContext() to getVarRegion() and then pass the
StackFrameContext to what you currently name "getMemRegionStaticLocal" then
both methods have the very
flx updated this revision to Diff 47159.
flx marked 12 inline comments as done.
flx added a comment.
Thanks for the review, Alex!
This is an intermediate updated patch that addresses your detailed comments.
I'll rename the whole check in the next couple of days and will re-upload again.
http:/
Author: compnerd
Date: Sun Feb 7 21:50:18 2016
New Revision: 260071
URL: http://llvm.org/viewvc/llvm-project?rev=260071&view=rev
Log:
build: silence warnings in in-tree build
Avoid the developer warnings from cmake when configuring libc++ as part of the
LLVM layout. Setup the custom macro paths
LegalizeAdulthood added a comment.
It's been almost a week. Is there some reason this hasn't been committed yet?
http://reviews.llvm.org/D16308
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
ariccio added a comment.
Bump?
Comment at: llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:792
@@ -783,12 +791,3 @@
-// Treat other globals as GlobalInternal unless they are constants.
-} else {
- QualType GQT = D->getType();
- const Type *GT = GQT.get
LegalizeAdulthood updated this revision to Diff 47157.
LegalizeAdulthood marked 2 inline comments as done.
LegalizeAdulthood added a comment.
Update from review comments.
Added a bunch of test cases for non-printing characters, templates and macros.
Removed string literals containing newline (`\
LegalizeAdulthood marked 5 inline comments as done.
Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:96
@@ +95,3 @@
+ std::string Delimiter;
+ for (int Counter = 0; containsDelimiter(Bytes, Delimiter); ++Counter) {
+Delimiter = (Counter == 0) ? "lit" : "lit" + std:
Author: dcoughlin
Date: Sun Feb 7 18:28:24 2016
New Revision: 260066
URL: http://llvm.org/viewvc/llvm-project?rev=260066&view=rev
Log:
[analyzer] Avoid crash when attempting to evaluate binary operation on
LazyCompoundVal.
Instead, return UnknownValue if either operand is a nonloc::LazyCompound
Author: alexfh
Date: Sun Feb 7 18:19:29 2016
New Revision: 260065
URL: http://llvm.org/viewvc/llvm-project?rev=260065&view=rev
Log:
[clang-tidy] Reformatted docs + minor updates
Modified:
clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp
clang-tools-extra/trunk/docs/clang-tidy/in
Author: majnemer
Date: Sun Feb 7 16:42:05 2016
New Revision: 260062
URL: http://llvm.org/viewvc/llvm-project?rev=260062&view=rev
Log:
[MS ABI] Don't emit RTTI descriptors for dllimport vtables
A dllimport'd vtable always points one past the RTTI data, this means
that the initializer will never e
Author: djasper
Date: Sun Feb 7 16:17:13 2016
New Revision: 260060
URL: http://llvm.org/viewvc/llvm-project?rev=260060&view=rev
Log:
clang-format: [JS] Don't count shortened object literals as blocks.
Before:
f({a},
() => {
g(); //
});
After:
f({a}, () => {
g(); //
});
thakis added a comment.
Cool, lgtm. Maybe we'll have to downgrade this to a warning eventually since cl
allows it, but for now let's see how this goes.
Comment at: test/SemaCXX/dllimport.cpp:1269
@@ +1268,3 @@
+ virtual ~PR26506_test2() {}
+ constexpr PR26506_test2() {} // ex
majnemer added inline comments.
Comment at: test/SemaCXX/dllimport.cpp:1262
@@ -1261,1 +1261,3 @@
+struct __declspec(dllimport) PR26506_test1 {
+ virtual ~PR26506_test1() {}
thakis wrote:
> cl.exe seems to accept this – do you know how they do that? Do they jus
Author: nico
Date: Sun Feb 7 15:32:17 2016
New Revision: 260058
URL: http://llvm.org/viewvc/llvm-project?rev=260058&view=rev
Log:
Make nozlibcompress.c pass and reenable it.
Modified:
cfe/trunk/test/Driver/nozlibcompress.c
Modified: cfe/trunk/test/Driver/nozlibcompress.c
URL:
http://llvm.o
Author: djasper
Date: Sun Feb 7 15:22:16 2016
New Revision: 260057
URL: http://llvm.org/viewvc/llvm-project?rev=260057&view=rev
Log:
clang-format: [JS] Support @see annotations in JSDoc comments in Google
style.
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/Format
Author: nico
Date: Sun Feb 7 15:00:17 2016
New Revision: 260056
URL: http://llvm.org/viewvc/llvm-project?rev=260056&view=rev
Log:
Disable failing nozlibcompress.c
This test hasn't been running after it was added until r259976 made
"REQUIRES: nozlib" work, and now that the test runs it fails.
Mo
On Sun, Feb 7, 2016 at 12:48 PM, Florian Weimer wrote:
> * H. J. Lu:
>
>>> I tested GCC 5.3.1 and Clang 3.5.0.
>>>
>>> GCC Clang
>>> s0 non-emptynon-empty
>>> s1 non-emptyempty
>>> s2 non-emptyempty
>>> s3 emptyempty
>>> s4 emptyempty
>>> s5 no
Eugene.Zelenko abandoned this revision.
Eugene.Zelenko added a comment.
Obsoleted by http://reviews.llvm.org/D16953.
Repository:
rL LLVM
http://reviews.llvm.org/D16786
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
* H. J. Lu:
>> I tested GCC 5.3.1 and Clang 3.5.0.
>>
>> GCC Clang
>> s0 non-emptynon-empty
>> s1 non-emptyempty
>> s2 non-emptyempty
>> s3 emptyempty
>> s4 emptyempty
>> s5 non-emptyempty
>>
>> I believe s3, s4, s5 are non-empty according
On Sun, Feb 7, 2016 at 12:08 PM, Florian Weimer wrote:
> * H. J. Lu:
>
>>> Any syntactical array argument (at the C level) is should be passed as
>>> a pointer. The language appears to change that.
>>
>> I didn't use aggregate so that array is excluded here.
>>
>>> For 2., static members and non-
Improve a comment.
--Vassil
On 07/02/16 20:48, Vassil Vassilev wrote:
Would this patch be any better?
--Vassil
On 05/02/16 21:49, Richard Smith wrote:
This belongs in ASTDeclReader::attachPreviousDecl[Impl]. That's where
we propagate data that's supposed to be consistent across a
redeclaration
http://lab.llvm.org:8011/builders/clang-sphinx-docs is still broken:
http://lab.llvm.org:8011/builders/clang-sphinx-docs
FAILED: cd
/home/llvmbb/llvm-build-dir/clang-sphinx-docs/llvm/build/tools/clang/docs
&& /usr/bin/sphinx-build -b html -d
/home/llvmbb/llvm-build-dir/clang-sphinx-docs/llvm/build
davidxl updated this revision to Diff 47150.
davidxl added a comment.
Updated test case.
Another test case in profile-rt (pending) is : http://reviews.llvm.org/D16974
http://reviews.llvm.org/D16947
Files:
lib/CodeGen/CGClass.cpp
test/Profile/def-assignop.cpp
Index: test/Profile/def-assign
* H. J. Lu:
>> Any syntactical array argument (at the C level) is should be passed as
>> a pointer. The language appears to change that.
>
> I didn't use aggregate so that array is excluded here.
>
>> For 2., static members and non-data members do not count.
>
> They do count here. That is why I
ogoffart updated this revision to Diff 47146.
ogoffart added a comment.
Optimized by avoiding repeated call to getBody
http://reviews.llvm.org/D16973
Files:
lib/AST/ExprConstant.cpp
test/SemaCXX/constant-expression-cxx11.cpp
Index: test/SemaCXX/constant-expression-cxx11.cpp
===
Would this patch be any better?
--Vassil
On 05/02/16 21:49, Richard Smith wrote:
This belongs in ASTDeclReader::attachPreviousDecl[Impl]. That's where
we propagate data that's supposed to be consistent across a
redeclaration chain from earlier declarations to later ones.
There's another wrinkl
frutiger updated this revision to Diff 47143.
frutiger added a comment.
Fixes include guards.
http://reviews.llvm.org/D16970
Files:
test/std/utilities/allocator.adaptor/scoped.adaptor.operators/construct.pass.cpp
test/support/instrumentingallocators.h
Index: test/support/instrumentingallo
AlisdairM added a subscriber: AlisdairM.
Comment at: test/support/instrumentingallocators.h:25
@@ +24,3 @@
+~Instrumentation() {
+assert(allocs_.empty());
+}
Perhaps a loop, showing what leaked?
for (auto const& alloc : allocs_) {
std::cout <<
frutiger created this revision.
frutiger added reviewers: EricWF, mclow.lists.
frutiger added a subscriber: cfe-commits.
This commit introduces a new supporting allocator 'IA1' in
'support/instrumentingallocators.h' which tracks allocations and deallocations.
This commit also introduces a new tes
frutiger updated this revision to Diff 47141.
frutiger added a comment.
Added `operator==` and `operator!=`.
http://reviews.llvm.org/D16970
Files:
test/std/utilities/allocator.adaptor/scoped.adaptor.operators/construct.pass.cpp
test/support/instrumentingallocators.h
Index: test/support/in
On Sun, Feb 7, 2016 at 11:36 AM, H.J. Lu wrote:
> On Sun, Feb 7, 2016 at 11:31 AM, Florian Weimer wrote:
>> * H. J. Lu:
>>
>>> I am proposing to update Intel386, x86-64 and IA MCU psABIs to specify
>>> how to pass/return empty struct:
>>>
>>> 1. "collection". A collection is a structure, union o
ogoffart created this revision.
ogoffart added reviewers: rsmith, cfe-commits.
Fix a crash while parsing this code:
struct X {
friend constexpr int foo(X*) { return 12; }
static constexpr int j = foo(static_cast(nullptr));
};
I also added a test for the static fu
On Sun, Feb 7, 2016 at 11:31 AM, Florian Weimer wrote:
> * H. J. Lu:
>
>> I am proposing to update Intel386, x86-64 and IA MCU psABIs to specify
>> how to pass/return empty struct:
>>
>> 1. "collection". A collection is a structure, union or C++ class.
>> 2. "empty collection". An empty collecti
Author: akirtzidis
Date: Sun Feb 7 13:28:36 2016
New Revision: 260048
URL: http://llvm.org/viewvc/llvm-project?rev=260048&view=rev
Log:
[Frontend] Make the memory management of FrontendAction pointers explicit by
using unique_ptr.
Modified:
cfe/trunk/include/clang/ARCMigrate/ARCMTActions.h
hintonda added a comment.
ping
http://reviews.llvm.org/D13622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
* H. J. Lu:
> I am proposing to update Intel386, x86-64 and IA MCU psABIs to specify
> how to pass/return empty struct:
>
> 1. "collection". A collection is a structure, union or C++ class.
> 2. "empty collection". An empty collection is:
>a. A collection without member. Or
>b. A collec
hintonda added a comment.
Here's a snippet of code that will crash:
lass DB {};
template class RemovePolicy : public T {};
template >
class Crash : T, Policy {};
template
class Crash : public DB, public Policy {
public:
Crash(){}
};
http://reviews.llvm.org/D16971
hintonda created this revision.
hintonda added reviewers: doug.gregor, lvoufo.
hintonda added a subscriber: cfe-commits.
The code sets isPartialSpecialization = false instead of returning true, which
will cause a crash later when the missing template parameter is referenced.
http://reviews.llvm.
thakis added a comment.
Thanks for jumping on this so quickly! Hans can probably just stamp this, but I
lack the background, so I must ask:
Comment at: test/SemaCXX/dllimport.cpp:1262
@@ -1261,1 +1261,3 @@
+struct __declspec(dllimport) PR26506_test1 {
+ virtual ~PR26506_test
Author: akirtzidis
Date: Sun Feb 7 12:21:28 2016
New Revision: 260047
URL: http://llvm.org/viewvc/llvm-project?rev=260047&view=rev
Log:
[libclang] Add missing CINDEX_LINKAGE from a function.
Modified:
cfe/trunk/include/clang-c/Index.h
Modified: cfe/trunk/include/clang-c/Index.h
URL:
http:/
jbcoe added a comment.
The method I'm using to insert after a function declaration is flawed.
Advancing by one character is not always the right thing to do and won't handle
cases where there is a space before a semi-colon. I'll add extra tests and see
if I can come up with a neater way of hand
mssimpso closed this revision.
mssimpso added a comment.
Committed in r260044.
http://reviews.llvm.org/D16966
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mssimpso
Date: Sun Feb 7 11:14:03 2016
New Revision: 260044
URL: http://llvm.org/viewvc/llvm-project?rev=260044&view=rev
Log:
Make -fno-math-builtin a cc1 option
This patch makes -fno-math-builtin a frontend only option instead of a driver
option. The appropriate test case was committed
mssimpso created this revision.
mssimpso added a reviewer: mcrosier.
mssimpso added a subscriber: cfe-commits.
Herald added a subscriber: mcrosier.
This patch makes -fno-math-builtin a frontend only option instead of a driver
option. The appropriate test case was committed in r186899 when the fla
frutiger created this revision.
frutiger added reviewers: mclow.lists, EricWF.
frutiger added a subscriber: cfe-commits.
This commit adds the required constructor overloads and member functions to
make the supporting allocators actually valid allocators. The implementation
of 'allocate' defers to
ryee88 created this revision.
ryee88 added reviewers: doug.gregor, gribozavr, francisco.lopes.
ryee88 added a subscriber: cfe-commits.
Bug 14644 - clang confuses scope operator for global namespace giving extra
qualification on member
This is a fix for this bug: https://llvm.org/bugs/show_bug.cg
sdowney created this revision.
sdowney added a reviewer: reames.
sdowney added a subscriber: cfe-commits.
The LibASTMatchersReference documentation is an html file, not an rst
document, so is not produced by sphinx. Copy the html into the proper
location as part of the sphinx html doc generation.
Hi Renato,
This is not related with my patch, I'm afraid your buildbot won't go green
with the revert. This looks to be related with r259976. My patch triggered
the problem because it touched a CmakeList.txt. The code itself is
completely unrelated with the failure.
Dmitri Gribenko sent a follow
ichesnokov added inline comments.
Comment at: test/SemaOpenCL/implicit-typedef.cl:4
@@ +3,3 @@
+
+#if defined(TEST_WARNINGS)
+typedef atomic_int atomic_flag; // expected-warning {{redefinition of OpenCL
builtin typedef 'atomic_flag'}}
Thank you, Anastasia!
I just
ichesnokov updated this revision to Diff 47137.
ichesnokov added a comment.
Another warning text implemented for OpenCL.
Like: redefinition of OpenCL builtin typedef 'atomic_flag'
http://reviews.llvm.org/D16351
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/S
mcrosier accepted this revision.
mcrosier added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks, Frank.
http://reviews.llvm.org/D16966
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
reames added a comment.
This looks entirely reasonable to me, but I don't really know cmake. Can
someone with cmake knowledge take a quick look?
http://reviews.llvm.org/D16963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
Author: dcoughlin
Date: Sun Feb 7 10:55:44 2016
New Revision: 260043
URL: http://llvm.org/viewvc/llvm-project?rev=260043&view=rev
Log:
[analyzer] Invalidate destination of std::copy() and std::copy_backward().
Now that the libcpp implementations of these methods has a branch that doesn't
call
m
hintonda created this revision.
hintonda added reviewers: beanz, mclow.lists.
hintonda added a subscriber: cfe-commits.
A common error for new users it to checkout subprojects, like clang or
clang-tools-extra, into the wrong subdirectory. This change helps prevent
this, since the resulting buil
On 6 February 2016 at 06:52, Samuel Antao via cfe-commits
wrote:
> Author: sfantao
> Date: Sat Feb 6 00:52:48 2016
> New Revision: 259985
>
> URL: http://llvm.org/viewvc/llvm-project?rev=259985&view=rev
> Log:
> Re-apply r259977 - [OpenMP] Reorganize code to allow specialized code
> generation f
Author: rengolin
Date: Sun Feb 7 09:43:09 2016
New Revision: 260036
URL: http://llvm.org/viewvc/llvm-project?rev=260036&view=rev
Log:
Revert "Re-apply r259977 - [OpenMP] Reorganize code to allow specialized code
generation for different devices."
This reverts commit r259985, as it still fails o
ichesnokov added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:2716
@@ +2715,3 @@
+ if (Ops.LHS->getType() != RHS->getType()) {
+bool isSigned =
dyn_cast(Ops.E)->getRHS()->getType().getTypePtr()->isSignedIntegerType();
+RHS = Builder.CreateIntCast(RHS, Ops.LH
Empty struct value is passed differently in C and C++ on Intel386 and x86-64.
Different compilers use different calling conventions on the same platform:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60336
The same compiler behaves different on different platforms:
https://llvm.org/bugs/show_bug.
jbcoe created this revision.
jbcoe added reviewers: aaron.ballman, alexfh, djasper.
jbcoe added a subscriber: cfe-commits.
jbcoe set the repository for this revision to rL LLVM.
Replace std::bind with a lambda.
Not yet working for member functions.
Repository:
rL LLVM
http://reviews.llvm.org/
ichesnokov added a comment.
Please review the last version of patch.
http://reviews.llvm.org/D16539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov added inline comments.
Comment at: test/SemaOpenCL/ternary-implicit-casts.cl:10-11
@@ +9,4 @@
+kernel void implicit_cast_generic(global int* gint, local int* lint, int cond)
{
+ // will compile, ptr is generic and can accept global and local
+ int* ptr = co
ichesnokov added a comment.
It looks like there's more todo to close this bug.
Let's go back to bug discussion at: https://llvm.org/bugs/show_bug.cgi?id=19957
http://reviews.llvm.org/D16682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
Author: yrnkrn
Date: Sun Feb 7 06:44:35 2016
New Revision: 260028
URL: http://llvm.org/viewvc/llvm-project?rev=260028&view=rev
Log:
Use CodeGenModule::addReplacement() instead of directly accessing
Replacements[].
This helps when trying to debug who inserted into Replacements.
Modified:
cf
On 12/14/2015 10:03 PM, Alexander Shukaev wrote:
On 12/11/2015 04:40 PM, Daniel Jasper wrote:
Please submit patches to clang-format to reviews.llvm.org. Also, any
change
no matter how easy it is to deduce from the code itself deserves a proper
change description :-). Bullet points are fine.
Th
70 matches
Mail list logo
