ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D16758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
LegalizeAdulthood updated this revision to Diff 46507.
LegalizeAdulthood added a comment.
Move local function to anonymous namespace
http://reviews.llvm.org/D16308
Files:
clang-tidy/readability/SimplifyBooleanExprCheck.cpp
clang-tidy/readability/SimplifyBooleanExprCheck.h
docs/clang-tidy/
LegalizeAdulthood updated this revision to Diff 46506.
LegalizeAdulthood added a comment.
Inline Variable
http://reviews.llvm.org/D16308
Files:
clang-tidy/readability/SimplifyBooleanExprCheck.cpp
clang-tidy/readability/SimplifyBooleanExprCheck.h
docs/clang-tidy/checks/readability-simplify
LegalizeAdulthood updated this revision to Diff 46505.
LegalizeAdulthood added a comment.
Update from review comments.
trunk clang-format
http://reviews.llvm.org/D16308
Files:
clang-tidy/readability/SimplifyBooleanExprCheck.cpp
clang-tidy/readability/SimplifyBooleanExprCheck.h
docs/clang-
LegalizeAdulthood updated this revision to Diff 46504.
LegalizeAdulthood added a comment.
Update from comments
http://reviews.llvm.org/D16529
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/RawStringLiteralCheck.cpp
clang-tidy
LegalizeAdulthood added inline comments.
Comment at: docs/clang-tidy/checks/modernize-raw-string-literal.rst:46
@@ +45,3 @@
+editor. Trailing whitespace is likely to be stripped by editors and other
+tools, changing the meaning of the literal.
+
LegalizeAdulthood
LegalizeAdulthood marked an inline comment as done.
Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:79
@@ +78,3 @@
+ if (Text.find('R') < Text.find('"'))
+return false;
+
Take a look at http://en.cppreference.com/w/cpp/language/string_literal
Ther
gottesmm added inline comments.
Comment at: include/clang/Basic/Attr.td:540
@@ +539,3 @@
+ let Subjects = SubjectList<[Function]>;
+ let Documentation = [Undocumented];
+}
aaron.ballman wrote:
> Please, no undocumented new attributes. You should modify AttrDocs.
gottesmm added a comment.
I think that my response via email did not hit phabriactor. So sorry for the
delay.
Yes there is a forthcoming patch for CodeGen which will place an attribute on
the relevant functions. The attribute will be queried in the middle end
optimizer. The reason why there ha
Done in r258768.
On Sun, Jan 31, 2016 at 10:49 AM, Kim Gräsman wrote:
> On Sun, Jan 31, 2016 at 5:24 PM, Kim Gräsman
> wrote:
> > On Sun, Jan 31, 2016 at 2:50 PM, David Majnemer
> > wrote:
> >>
> >> It is the same issue as CWG defect report 1250:
> >> http://wg21.cmeerw.net/cwg/issue1250
> >>
Author: majnemer
Date: Sun Jan 31 19:33:17 2016
New Revision: 259335
URL: http://llvm.org/viewvc/llvm-project?rev=259335&view=rev
Log:
Mark DR1250 as implemented
We implemented this DR back in r258768 but forgot to mark it as
implemented.
Added:
cfe/trunk/test/CXX/drs/dr12xx.cpp
Modified:
> On Jan 29, 2016, at 6:02 AM, Aaron Ballman wrote:
>
> aaron.ballman added a subscriber: aaron.ballman.
> aaron.ballman added a reviewer: aaron.ballman.
> aaron.ballman added a comment.
>
> It's a bit strange to add an attribute that has absolutely no semantic effect
> whatsoever. Where is th
ehsan created this revision.
ehsan added a reviewer: rnk.
ehsan added a subscriber: cfe-commits.
This builds on the support being added to LLVM to import and export
registries from DLLs. This will allow us to pick up the registry
entries added in the DLL's copy of FrontendPluginRegistry.
This wi
arpith-jacob created this revision.
arpith-jacob added reviewers: hfinkel, kkwli0, sfantao, carlo.bertolli, ABataev.
arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin.
This patch enhances Sema to check for the following restriction:
OpenMP 4.5 [2.17 Nesting of Regions]
If a targe
On Sun, Jan 31, 2016 at 5:24 PM, Kim Gräsman wrote:
> On Sun, Jan 31, 2016 at 2:50 PM, David Majnemer
> wrote:
>>
>> It is the same issue as CWG defect report 1250:
>> http://wg21.cmeerw.net/cwg/issue1250
>>
>> I forget how to tell how far back a DR applies but I'd guess this one goes
>> as far b
Hi Anton,
Okey, nevermore.
But what to do with a bug which needs simply be closed (NABs)?
I believe they also need a review/approval.
Igor
-Original Message-
From: Anton Korobeynikov [mailto:an...@korobeynikov.info]
Sent: Sunday, January 31, 2016 8:19 PM
To: Igor
asl requested changes to this revision.
asl added a comment.
This revision now requires changes to proceed.
Please don't create empty review requests. This is ridiculous.
Repository:
rL LLVM
http://reviews.llvm.org/D16754
___
cfe-commits mailing
On Sun, Jan 31, 2016 at 2:50 PM, David Majnemer
wrote:
>
> It is the same issue as CWG defect report 1250:
> http://wg21.cmeerw.net/cwg/issue1250
>
> I forget how to tell how far back a DR applies but I'd guess this one goes
> as far back as C++11.
Thanks, I didn't know there was a DR for this.
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=25404
Repository:
rL LLVM
http://reviews.llvm.org/D16351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ichesnokov added a comment.
majnemer,
I'll try to find answer to your question tomorrow.
Repository:
rL LLVM
http://reviews.llvm.org/D16351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=26194
Repository:
rL LLVM
http://reviews.llvm.org/D16539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=19957
Repository:
rL LLVM
http://reviews.llvm.org/D16682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=10002
Repository:
rL LLVM
http://reviews.llvm.org/D16460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
On Sunday, January 31, 2016, Kim Gräsman wrote:
> Hi David,
>
> Should this be guarded by if(cxx14)? I think the complete type was
> required by earlier standards.
>
It is the same issue as CWG defect report 1250:
http://wg21.cmeerw.net/cwg/issue1250
I forget how to tell how far back a DR appli
ariccio updated this revision to Diff 46481.
ariccio marked 10 inline comments as done.
ariccio added a comment.
Removed extra spaces.
http://reviews.llvm.org/D16748
Files:
C:/LLVM/llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h
C:/LLVM/llvm/tools/clang/lib/Sta
ariccio added a comment.
Oops. The funny thing about the extra spaces is that I wasn't sure why there
were spaces after the casts already, so I figured that I should keep it that
way.
I shall fix.
http://reviews.llvm.org/D16748
___
cfe-commits m
alexfh added a comment.
In http://reviews.llvm.org/D16529#340240, @alexfh wrote:
> Also, please remove unrelated files from the patch.
Please ignore this part, I missed the new diff.
http://reviews.llvm.org/D16529
___
cfe-commits mailing list
cfe
alexfh added a comment.
Thank you for addressing (most of) the comments!
I have a few more comments and the comment about the implementation of
`asRawStringLiteral` still applies.
Also, please remove unrelated files from the patch.
Comment at: clang-tidy/modernize/RawStringLi
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=15785
Please review and close the bug.
Repository:
rL LLVM
http://reviews.llvm.org/D16754
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
ichesnokov created this revision.
ichesnokov added a reviewer: asl.
ichesnokov added a subscriber: cfe-commits.
ichesnokov set the repository for this revision to rL LLVM.
Not a bug, thus empty patch. Older patch handles the case.
Please look at comments at: https://llvm.org/bugs/show_bug.cgi?id=1
Hi David,
Should this be guarded by if(cxx14)? I think the complete type was required
by earlier standards.
- Kim
Den 26 jan 2016 2:40 fm skrev "David Majnemer via cfe-commits" <
cfe-commits@lists.llvm.org>:
> Author: majnemer
> Date: Mon Jan 25 19:37:01 2016
> New Revision: 258768
>
> URL: http
ichesnokov added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:1799
@@ -1798,2 +1798,3 @@
case LangAS::opencl_constant: ASString = "CLconstant"; break;
+ case LangAS::opencl_generic: ASString = "CLgeneric"; break;
// ::= "CU" [ "device" | "constant"
ichesnokov added a comment.
Please review and commit.
Repository:
rL LLVM
http://reviews.llvm.org/D16574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov added a comment.
Please review and commit.
Repository:
rL LLVM
http://reviews.llvm.org/D16460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov added a comment.
Please review and commit.
There's no patch, but only unit tests.
Repository:
rL LLVM
http://reviews.llvm.org/D16682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
35 matches
Mail list logo
