Author: arsenm
Date: Tue Jan 26 00:37:54 2016
New Revision: 258794
URL: http://llvm.org/viewvc/llvm-project?rev=258794&view=rev
Log:
AMDGPU: Add amdgcn cube builtins
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def
cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn.cl
Modified: cfe/t
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D16553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D16527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
pxli168 added a comment.
Hi,
Email was sent, hope this can be merged into llvm release3.8.
Thanks
Xiuli
http://reviews.llvm.org/D15914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Author: pxl
Date: Mon Jan 25 22:03:48 2016
New Revision: 258782
URL: http://llvm.org/viewvc/llvm-project?rev=258782&view=rev
Log:
Recommit: R258773 [OpenCL] Pipe builtin functions
Fix arc patch fuzz error.
Summary:
Support for the pipe built-in functions for OpenCL 2.0.
The pipe builtin functions
Hello everyone,
LLVM buildmaster will be updated and restarted after 9 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D16498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: rtrieu
Date: Mon Jan 25 20:51:55 2016
New Revision: 258778
URL: http://llvm.org/viewvc/llvm-project?rev=258778&view=rev
Log:
Fix -Wnull-conversion for long macros.
Move the function to get a macro name from DiagnosticRenderer.cpp to Lexer.cpp
so that other files can use it. Lexer now has
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: hans, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Herald added a subscriber: klimek.
I checked this patch on my own build on RHEL 6. Regressions
Sorry about this broken commit. The arc tool patch fuzz seems to have something
wrong and I am re-patching it by hand.
From: David Majnemer [mailto:david.majne...@gmail.com]
Sent: Tuesday, January 26, 2016 10:27 AM
To: Xiuli Pan
Cc: cfe-commits
Subject: Re: r258773 - [OpenCL] Pipe builtin f
Thanks for the suggestion! I converted the test to a -### test and
recommitted. Also rewrote the existing test (which I guess was failing for
another reason than what the author intended since it was merely checking
for an error return code...)
On Mon, Jan 25, 2016 at 9:16 PM, Nico Weber wrote:
Reverted in r258775, it broke the build bots:
http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/43853
On Mon, Jan 25, 2016 at 6:06 PM, Xiuli Pan via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: pxl
> Date: Mon Jan 25 20:06:04 2016
> New Revision: 258773
>
> URL: http://llvm.
Author: ehsan
Date: Mon Jan 25 20:23:05 2016
New Revision: 258776
URL: http://llvm.org/viewvc/llvm-project?rev=258776&view=rev
Log:
Recommit the test for r258720 using -###
Modified:
cfe/trunk/test/Driver/unknown-arg.c
Modified: cfe/trunk/test/Driver/unknown-arg.c
URL:
http://llvm.org/viewv
Author: majnemer
Date: Mon Jan 25 20:22:31 2016
New Revision: 258775
URL: http://llvm.org/viewvc/llvm-project?rev=258775&view=rev
Log:
Revert "[OpenCL] Pipe builtin functions"
This reverts commit r258773, it broke the build bots:
http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/43853
Re
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6. Regressions were OK.
Repository:
rL LLVM
Since it isn't a -### test, the test probably just needs a `// REQUIRES:
x86-registered-target`? Is adding -### a possibility?
On Mon, Jan 25, 2016 at 8:51 PM, Ehsan Akhgari via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ehsan
> Date: Mon Jan 25 19:51:47 2016
> New Revision: 25877
Author: pxl
Date: Mon Jan 25 20:06:04 2016
New Revision: 258773
URL: http://llvm.org/viewvc/llvm-project?rev=258773&view=rev
Log:
[OpenCL] Pipe builtin functions
Summary:
Support for the pipe built-in functions for OpenCL 2.0.
The pipe builtin functions may have infinite kinds of element types, o
echristo added a comment.
Honestly if they've been reviewed like that internally I'm ok with you just
committing them - especially if they look like this.
The only concerns I'd have are in the case of "This intrinsic corresponds to
the instruction" (side note, use the "the"? I commented on a c
OK, I reverted the test in r258772.
Looking at the log, it's really not clear to me what's going on. I'd
appreciate your help figuring this out. :-)
On Mon, Jan 25, 2016 at 8:09 PM, Ehsan Akhgari
wrote:
> Ouch, sorry about that! I'm afk right now, I would appreciate if you can
> revert it for
Author: ehsan
Date: Mon Jan 25 19:51:47 2016
New Revision: 258772
URL: http://llvm.org/viewvc/llvm-project?rev=258772&view=rev
Log:
Revert the test for r258720 temporarily
This test is failing on a bot for reasons that are unclear to me.
Reverting for now...
Modified:
cfe/trunk/test/Driver/u
Author: majnemer
Date: Mon Jan 25 19:39:17 2016
New Revision: 258769
URL: http://llvm.org/viewvc/llvm-project?rev=258769&view=rev
Log:
[Sema] Remove stray semicolons.
No functional change is intended.
Modified:
cfe/trunk/lib/Sema/SemaDeclCXX.cpp
Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp
Author: majnemer
Date: Mon Jan 25 19:37:01 2016
New Revision: 258768
URL: http://llvm.org/viewvc/llvm-project?rev=258768&view=rev
Log:
[Sema] Incomplete types are OK for covariant returns
Per C++14 [class.virtual]p8, it is OK for the return type's class type
to be incomplete so long as the return
kromanova added a reviewer: craig.topper.
kromanova added a comment.
Hello,
I have a lot of intrinsic header files with doxygen documentation that I will
be submitting in the near future.
We have been reviewing this internally at SCE to make sure the patch it in the
best shape before submitting
Author: majnemer
Date: Mon Jan 25 19:12:17 2016
New Revision: 258762
URL: http://llvm.org/viewvc/llvm-project?rev=258762&view=rev
Log:
[MS Compat] Don't crash if __GetExceptionInfo is in global scope
__GetExceptionInfo triggered Sema::LazilyCreateBuiltin which tries to
create a non-templated func
Ouch, sorry about that! I'm afk right now, I would appreciate if you can
revert it for me. I will look at fixing this tomorrow.
On Jan 25, 2016 6:49 PM, "Renato Golin" wrote:
> On 25 January 2016 at 21:14, Ehsan Akhgari via cfe-commits
> wrote:
> > Author: ehsan
> > Date: Mon Jan 25 15:14:52 201
ygao added a comment.
A gentle ping.
http://reviews.llvm.org/D16365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manmanren created this revision.
manmanren added reviewers: echristo, rafael, ahatanak.
manmanren added a subscriber: cfe-commits.
It can happen that frontend emits error message when releasing the builder.
When that happens, we emit the error message and continue to invoke backend.
Backend will
george.burgess.iv added a comment.
> I am generally not clear about the scope of this patch. Is it intended for
> OpenCL or C++?
Sorry for the lack of clarity; I was mildly confused about what parts of the
OpenCL spec apply to extended vectors when compiling code as C/C++. I think I
have a be
george.burgess.iv updated this revision to Diff 45930.
george.burgess.iv marked an inline comment as done.
george.burgess.iv added a comment.
- Added diagnostics that prohibit vectors of booleans in OpenCL
- Added tests for extended vectors of bools in C (previously existed only in
C++)
- Clarifi
xur updated this revision to Diff 45929.
xur marked an inline comment as done.
xur added a comment.
Here is the new patch. Changes from previous patch are:
(1) rename codegen option ProfileInstrGenerate to ClangProfInstrGen to avoid
the name confusion (Davidxl). This option is for clang instrumen
kromanova created this revision.
kromanova added reviewers: gribozavr, jroelofs, gaoyunzhong, craig.topper.
kromanova added subscribers: silvas, echristo, cfe-commits.
kromanova set the repository for this revision to rL LLVM.
Hello,
Here is the patch with the doxygen comments for the intrinsincs
Author: eugenis
Date: Mon Jan 25 17:45:37 2016
New Revision: 258749
URL: http://llvm.org/viewvc/llvm-project?rev=258749&view=rev
Log:
Fix use of constexpr std::pair that's not in C++11.
Modified:
cfe/trunk/lib/CodeGen/CGExpr.cpp
Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp
URL:
http://llvm.or
On 25 January 2016 at 21:14, Ehsan Akhgari via cfe-commits
wrote:
> Author: ehsan
> Date: Mon Jan 25 15:14:52 2016
> New Revision: 258720
>
> URL: http://llvm.org/viewvc/llvm-project?rev=258720&view=rev
> Log:
> [MSVC Compat] Only warn for unknown clang-cl arguments
Hi Eshan,
Not sure you've see
eugenis closed this revision.
eugenis added a comment.
Thanks! Committed as
http://reviews.llvm.org/rL258745
Repository:
rL LLVM
http://reviews.llvm.org/D15699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: eugenis
Date: Mon Jan 25 17:34:52 2016
New Revision: 258745
URL: http://llvm.org/viewvc/llvm-project?rev=258745&view=rev
Log:
[cfi] Cross-DSO CFI diagnostic mode (clang part)
* Runtime diagnostic data for cfi-icall changed to match the rest of
cfi checks
* Layout of all CFI diagnostic d
ahatanak added a comment.
Maybe we can just remove -Wpadded from buildit's command line for now? If we
decide in the future it's worthwhile to use -Wpadded, we can put it back and
commit this patch. Also in that case we should make sure cmake uses the option
too.
http://reviews.llvm.org/D1589
Author: jlebar
Date: Mon Jan 25 16:52:31 2016
New Revision: 258737
URL: http://llvm.org/viewvc/llvm-project?rev=258737&view=rev
Log:
[CUDA] Add -target to cuda-constructor-alias.cu test so it doesn't fail on Mac.
The test was checking that we passed -mconstructor-alias to host
compilation, but th
eugenis added inline comments.
Comment at: test/CodeGen/cfi-check-fail.c:18
@@ +17,3 @@
+// CHECK: [[TRAP]]
+// CHECK-NEXT: call void @llvm.trap()
+// CHECK-NEXT: unreachable
Right.
It fails.
I've removed the ":" after all label names.
Repository:
rL LLVM
eugenis updated this revision to Diff 45920.
Repository:
rL LLVM
http://reviews.llvm.org/D15699
Files:
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/CodeGenModule.cpp
lib/Driver/Tools.cpp
test/CodeGen/cfi-check-fail.c
test/CodeGen/cfi-ic
Author: mren
Date: Mon Jan 25 16:37:47 2016
New Revision: 258735
URL: http://llvm.org/viewvc/llvm-project?rev=258735&view=rev
Log:
Update comments to match the implementation.
Modified:
cfe/trunk/lib/CodeGen/CGObjCMac.cpp
Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp
URL:
http://llvm.org/vi
Author: jlebar
Date: Mon Jan 25 16:36:35 2016
New Revision: 258733
URL: http://llvm.org/viewvc/llvm-project?rev=258733&view=rev
Log:
[CUDA] Disable ctor/dtor aliases in device code.
Summary: NVPTX doesn't support aliases, so don't generate them.
Reviewers: tra
Subscribers: cfe-commits, jhen, ec
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258733: [CUDA] Disable ctor/dtor aliases in device code.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16499?vs=45779&id=45918#toc
Repository:
rL LLVM
http://reviews.llvm.o
Author: jlebar
Date: Mon Jan 25 16:36:37 2016
New Revision: 258734
URL: http://llvm.org/viewvc/llvm-project?rev=258734&view=rev
Log:
[CUDA] Don't generate aliases for static extern "C" functions.
Summary:
These aliases are done to support inline asm, but there's nothing we can
do: NVPTX doesn't s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258734: [CUDA] Don't generate aliases for static extern "C"
functions. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16501?vs=45781&id=45919#toc
Repository:
rL LLVM
http://
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: bkramer, echristo, jhen, cfe-commits.
Turns out the variadic function checking added in r258643 was too strict
for some existing users; give them an escape valve. When
-fcuda-allow-variadic-functions is passed,
manmanren added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:1998
@@ +1997,3 @@
+ if (auto *T = EntryBB->getTerminator())
+T->eraseFromParent();
+
Yes, you are right.
http://reviews.llvm.org/D15599
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: test/CodeGen/cfi-check-fail.c:17
@@ +16,3 @@
+
+// CHECK: [[TRAP]]:
+// CHECK-NEXT: call void @llvm.trap()
Does this match in a -asserts build?
Author: mren
Date: Mon Jan 25 15:52:26 2016
New Revision: 258727
URL: http://llvm.org/viewvc/llvm-project?rev=258727&view=rev
Log:
Move ObjCPropertyDecl to before ObjCContainerDecl.
After we add ObjCPropertyDecl::isClassProperty, we can use it in
ObjCContainerDecl to define filter to iterate over
Eugene.Zelenko added a comment.
Just encountered next situation in my work code base:
void Function() {
...
if (Condition) {
}
else
return;
}
http://reviews.llvm.org/D16259
___
cfe-commits mailing list
cfe-commits@lists.l
ahatanak updated this revision to Diff 45910.
ahatanak added a comment.
Address review comments from Hans and Manman.
http://reviews.llvm.org/D15599
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGStmt.cpp
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGen/attr-nak
ahatanak added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:1954
@@ +1953,3 @@
+ // Erase all allocas and their users.
+ for (auto I = EntryBB->begin(); &*I != &*AllocaInsertPt; ++I)
+if (auto Alloca = dyn_cast(&*I))
hans wrote:
> would decla
Alexander_Droste added inline comments.
Comment at: tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:662
@@ +661,3 @@
+else if (auto SV =
+ER->getIndex().getAs()) {
+llvm::SmallString<8> buf;
xazax.hun wrote:
> These are the only cases that ca
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258720: [MSVC Compat] Only warn for unknown clang-cl
arguments (authored by ehsan).
Changed prior to commit:
http://reviews.llvm.org/D16511?vs=45796&id=45906#toc
Repository:
rL LLVM
http://reviews.l
Author: ehsan
Date: Mon Jan 25 15:14:52 2016
New Revision: 258720
URL: http://llvm.org/viewvc/llvm-project?rev=258720&view=rev
Log:
[MSVC Compat] Only warn for unknown clang-cl arguments
Summary:
MSVC's driver accepts all unknown arguments but warns about them. clang
by default rejects all unkno
On 25 January 2016 at 11:03, Yunzhong Gao
wrote:
> ygao added a comment.
>
> Thanks, Rafael!
> I did verify that the test would fail without my fix. But what do I need to
> do to make buildbots turn on the new lit parameter?
That I do not know. Mike?
Cheers,
Rafael
_
Thanks for the reviews! Will address both when landing.
On Mon, Jan 25, 2016 at 2:34 PM, Hans Wennborg wrote:
> hans added a subscriber: hans.
> hans added a comment.
>
> Maybe this behavior should be called out in the Command-Line Options
> section under clang-cl in docs/UsersManual.rst?
>
>
>
On Mon, Jan 25, 2016 at 11:00 AM, Xinliang David Li
wrote:
> On Fri, Jan 22, 2016 at 1:43 PM, Sean Silva wrote:
> > silvas added a comment.
> >
> > In http://reviews.llvm.org/D15829#333902, @davidxl wrote:
> >
> >> For the longer term, one possible solution is to make FE based
> >> instrumentat
On Mon, Jan 25, 2016 at 12:52 PM, Rong Xu wrote:
> OK. Now I understand what you meant. I was trying to avoid driver changes.
> It seems you are saying I can change the driver to support cc1 options more
> cleanly. This can be done.
>
Great! Sorry for the confusion.
-- Sean Silva
> Thanks,
>
>
xur added a subscriber: xur.
xur added a comment.
OK. Now I understand what you meant. I was trying to avoid driver changes.
It seems you are saying I can change the driver to support cc1 options more
cleanly. This can be done.
Thanks,
Rong
http://reviews.llvm.org/D15829
___
OK. Now I understand what you meant. I was trying to avoid driver changes.
It seems you are saying I can change the driver to support cc1 options more
cleanly. This can be done.
Thanks,
Rong
On Jan 25, 2016 12:43, "Sean Silva" wrote:
> silvas added inline comments.
>
>
> Commen
ebaker355 added a comment.
Ping. Anyone have an opinion on this?
http://reviews.llvm.org/D16066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
silvas added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:487
@@ +486,3 @@
+ // Opts.ProfileInstrGenerate will be used for Clang instrumentation only.
+ if (!Opts.ProfileIRInstr)
+Opts.ProfileInstrGenerate = Args.hasArg(OPT_fprofile_instr_generate) ||
---
Merged in r258715.
On Mon, Jan 25, 2016 at 11:39 AM, Hans Wennborg wrote:
> Joerg, do you want to go ahead and merge this to 3.8 with
> utils/release/merge.sh? (Or let me know if you'd prefer me to do it.)
>
> On Sun, Jan 24, 2016 at 11:29 PM, Richard Smith wrote:
>> Approved for branch.
>>
>> O
kimgr added a subscriber: kimgr.
kimgr added a comment.
Cool check, I like how it pays attention to indentation!
I found some minor doc nits, see inline.
Comment at: docs/clang-tidy/checks/misc-suspicious-semicolon.rst:8-9
@@ +7,4 @@
+the code. More specifically, it looks for `
arpith-jacob marked 5 inline comments as done.
arpith-jacob added a comment.
Patch fixed.
http://reviews.llvm.org/D16527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kromanova removed rL LLVM as the repository for this revision.
kromanova updated this revision to Diff 45902.
kromanova added a comment.
SCE's techinical writer, Craig Flores, did the code review and suggested a few
changes to the documentation.
http://reviews.llvm.org/D15999
Files:
lib/Head
thakis created this revision.
thakis added a reviewer: rsmith.
thakis added a subscriber: cfe-commits.
libstdc++ is using `= default` instead of `{}` for more and more of its
container classes, because they think DR 253 should be accepted
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60284). Sin
rtrieu added a comment.
Hi Andy,
Could you give some motivation for this patch? From your example:
printf(minimal ? "%i\n" : "%i: %s\n", code, msg);
I would expect the first format string to produce a warning that msg is not
used.
http://reviews.llvm.org/D15636
davidxl added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:440
@@ +439,3 @@
+ if (CodeGenOpts.ProfileIRInstr) {
+// Should not have ProfileInstrGenerate set -- it is for clang
+// instrumentation only.
xur wrote:
> silvas wrote:
> > Then chang
Author: aaronballman
Date: Mon Jan 25 14:00:53 2016
New Revision: 258714
URL: http://llvm.org/viewvc/llvm-project?rev=258714&view=rev
Log:
Add support to the misc-assert-side-effect check for MSVC-style assert macros,
which use !! instead of an if statement or a conditional operator.
Modified:
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
OK. If someone attempts to rely on this feature in CUDA it will be obviously
broken due to the missing C-style mangled name. We can deal with it then.
http://reviews.llvm.org/D16501
jlebar added a comment.
In http://reviews.llvm.org/D16501#335225, @tra wrote:
> Failing silently is not a good idea. At the very least there should produce
> an error.
> The right thing to do here, IMO, would be to generate a stub with alias name
> that just jumps to or calls aliasee.
Discus
Author: probinson
Date: Mon Jan 25 13:46:40 2016
New Revision: 258712
URL: http://llvm.org/viewvc/llvm-project?rev=258712&view=rev
Log:
LTO via the gold plugin needs to be told about debugger tuning.
Differential Revision: http://reviews.llvm.org/D16094
Modified:
cfe/trunk/lib/Driver/Tools.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258712: LTO via the gold plugin needs to be told about
debugger tuning. (authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D16094?vs=44575&id=45893#toc
Repository:
rL LLVM
htt
Joerg, do you want to go ahead and merge this to 3.8 with
utils/release/merge.sh? (Or let me know if you'd prefer me to do it.)
On Sun, Jan 24, 2016 at 11:29 PM, Richard Smith wrote:
> Approved for branch.
>
> On 23 Jan 2016 11:56 p.m., "Joerg Sonnenberger"
> wrote:
>>
>> On Sat, Jan 16, 2016 at
hans added a subscriber: hans.
hans added a comment.
Maybe this behavior should be called out in the Command-Line Options section
under clang-cl in docs/UsersManual.rst?
http://reviews.llvm.org/D16511
___
cfe-commits mailing list
cfe-commits@lists.
tra added a comment.
Failing silently is not a good idea. At the very least there should produce an
error.
The right thing to do here, IMO, would be to generate a stub with alias name
that just jumps to or calls aliasee.
http://reviews.llvm.org/D16501
___
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D16499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig created this revision.
bcraig added reviewers: mclow.lists, jroelofs, EricWF.
bcraig added a subscriber: cfe-commits.
This change leverages framework changes made in libcxx. See those changes for
more details. (http://reviews.llvm.org/D16544)
Some Mac specific logic for testing against l
bcraig created this revision.
bcraig added reviewers: mclow.lists, EricWF, jroelofs.
bcraig added a subscriber: cfe-commits.
NOTE: related libc++abi changes are in a different patch that will be posted
shortly.
Tested with static libcxx and libcxxabi against custom embedded target.
Tested with st
ygao added a comment.
Thanks, Rafael!
I did verify that the test would fail without my fix. But what do I need to do
to make buildbots turn on the new lit parameter?
http://reviews.llvm.org/D15705
___
cfe-commits mailing list
cfe-commits@lists.llvm
On Fri, Jan 22, 2016 at 1:43 PM, Sean Silva wrote:
> silvas added a comment.
>
> In http://reviews.llvm.org/D15829#333902, @davidxl wrote:
>
>> For the longer term, one possible solution is to make FE based
>> instrumentation only used for coverage testing which can be turned on
>> with -fcovera
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm other than the warning group.
Comment at: test/Misc/warning-flags.c:21
@@ -20,3 +20,3 @@
-CHECK: Warnings without flags (84):
+CHECK: Warnings without flags (85):
CHECK-NEXT
rafael closed this revision.
rafael added a comment.
258698
http://reviews.llvm.org/D16469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pekka.jaaskelainen added a comment.
> @Pekka, do you think it would make sense to include a description of the new
> OpenCL features in the release note too? Or shall we wait for the completion
> of OpenCL 2.0 support (hopefully in next release)? Could do both as well I
> guess. :)
Yes I th
Author: rafael
Date: Mon Jan 25 12:29:16 2016
New Revision: 258698
URL: http://llvm.org/viewvc/llvm-project?rev=258698&view=rev
Log:
Pass --wrap=pthread_create to linker for -fsplit-stack.
From
https://gcc.gnu.org/ml/gcc-patches/2010-09/msg01807.html
-fsplit-stack should pass --wrap=pthread_cre
dexonsmith updated this revision to Diff 45879.
dexonsmith added a comment.
Addressed Marshall's review comments: deferring to match_results::operator[]()
rather than duplicating the logic.
http://reviews.llvm.org/D16467
Files:
include/regex
test/std/re/re.results/re.results.form/form1.pas
dexonsmith created this revision.
dexonsmith added a reviewer: mclow.lists.
dexonsmith added a subscriber: cfe-commits.
This entire test was effectively disabled in r187636 with no relevant
explanation. The test passes for me just by removing the comment
markers.
http://reviews.llvm.org/D16541
cfe-commits added a comment.
Given your follow-up review, and the behaviour of
match_results::operator[], do you still have reservations?
http://reviews.llvm.org/D16467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Given your follow-up review, and the behaviour of
match_results::operator[], do you still have reservations?
> On 2016-Jan-25, at 08:19, Marshall Clow wrote:
>
> mclow.lists added a comment.
>
> Not crashing is good; but silently returning a "wrong" answer rubs me the
> wrong way. I'll do som
> On 2016-Jan-25, at 08:49, Marshall Clow wrote:
>
> mclow.lists added inline comments.
>
>
> Comment at: include/regex:5390
> @@ -5389,3 +5389,3 @@
> size_t __i = *__fmt_first - '0';
> -__out = _VSTD::copy(__matches_[__i].first,
> -
rafael accepted this revision.
rafael added a reviewer: rafael.
rafael added a comment.
This revision is now accepted and ready to land.
LGTM assuming you can get the test to fail by reverting the fix
http://reviews.llvm.org/D15705
___
cfe-commits m
hjl.tools added a comment.
Can you check it in for me? Thanks.
http://reviews.llvm.org/D16469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
Could you please copy us in CC?
@Pekka, do you think it would make sense to include a description of the new
OpenCL features in the release note too? Or shall we wait for the completion of
OpenCL 2.0 support (hopefully in next release)? Could do both as well I guess.
rafael added a subscriber: rafael.
rafael accepted this revision.
rafael added a reviewer: rafael.
rafael added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D16094
___
cfe-commits mailing list
cfe-commits@
rafael accepted this revision.
rafael added a reviewer: rafael.
rafael added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D16469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Ping!
On Wed, Jan 20, 2016 at 11:22 AM, Bruno Cardoso Lopes
wrote:
> bruno updated this revision to Diff 45421.
> bruno added a comment.
>
> Update patch after Richard comments
>
>
> http://reviews.llvm.org/D15173
>
> Files:
> include/clang/Lex/Preprocessor.h
> lib/Lex/PPCaching.cpp
> lib/P
Anastasia added a comment.
I am generally not clear about the scope of this patch. Is it intended for
OpenCL or C++?
As for OpenCL, boolean vector types are not permitted (Table 6.2). Also
conversions between vector types are disallowed in general (Section 6.2.2) but
unfortunately Clang doesn'
ygribov added inline comments.
Comment at: test/Driver/fsanitize.c:221
@@ +220,3 @@
+// RUN: %clang -target x86_64-apple-darwin10
-resource-dir=%S/Inputs/resource_dir -fsanitize=memory -fsanitize=thread,memory
%s -### 2>&1 | FileCheck %s --check-prefix=CHECK-MSAN-TSAN-MSAN-DARWI
Author: marshall
Date: Mon Jan 25 11:29:55 2016
New Revision: 258697
URL: http://llvm.org/viewvc/llvm-project?rev=258697&view=rev
Log:
Implement LWG#2385; remove the allocator-aware std::function::assign call. It
was useless, and didn't actually *do anything* with the allocator. Now it's
gone.
1 - 100 of 145 matches
Mail list logo
