[PATCH] D16309: Use getCharWidth() instead of magic number

danielmarjamaki created this revision. danielmarjamaki added a subscriber: cfe-commits. Use getCharWidth() instead of magic number to handle arbitrary char widths. no change in logical behaviour is intended when getCharWidth() is 8. http://reviews.llvm.org/D16309 Files: lib/Frontend/InitPrep

[PATCH] D16308: clang-tidy Enhance readability-simplify-boolean-expr check to handle implicit conversions of integral types to bool and member pointers

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: alexfh. LegalizeAdulthood added a subscriber: cfe-commits. Expand the simplify boolean expression check to handle implicit conversion of integral types to bool and improve the handling of implicit conversion of member po

Re: [PATCH] D8149: Add hasUnderlyingType narrowing matcher for TypedefDecls, functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

LegalizeAdulthood added a comment. Is there any reason we can't proceed with the patch as-is and then see if it can be refactored into an overload of `hasType`? http://reviews.llvm.org/D8149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

On Jan 7, 2016 7:13 PM, "Bruno Cardoso Lopes" wrote: > > bruno updated this revision to Diff 44306. > bruno added a comment. > > Hi Richard, > > Thanks for the detailed explanation, it now makes sense to me. I updated the patch with another approach! Let me know if it's the right direction. > > >

Re: [PATCH] D16286: [clang-tidy] Readability check for redundant parenthesis in return expression.

adek05 updated this revision to Diff 45228. adek05 added a comment. @LegalizeAdulthood, @Eugene.Zelenko and @omtcyf0 comments http://reviews.llvm.org/D16286 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/ReturnWithRedun

r258110 - Fix PR26134: When substituting into default template arguments, keep CurContext unchanged.

Author: faisalv Date: Mon Jan 18 21:58:55 2016 New Revision: 258110 URL: http://llvm.org/viewvc/llvm-project?rev=258110&view=rev Log: Fix PR26134: When substituting into default template arguments, keep CurContext unchanged. Or, do not set Sema's CurContext to the template declaration's when su

Re: [PATCH] D16280: [OpenMP] Detect implicit map type to report unspecified map type for target enter/exit data directives.

arpith-jacob marked 2 inline comments as done. arpith-jacob added a comment. http://reviews.llvm.org/D16280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16280: [OpenMP] Detect implicit map type to report unspecified map type for target enter/exit data directives.

arpith-jacob updated this revision to Diff 45227. arpith-jacob added a comment. Addressed comment: Do not cast bool to unsigned, use (IsMapTypeImplicit ? 1 : 0) instead. http://reviews.llvm.org/D16280 Files: include/clang/AST/OpenMPClause.h include/clang/Sema/Sema.h lib/AST/OpenMPClause.c

Re: [PATCH] D16279: [OpenMP] Parsing + sema for "target exit data" directive.

arpith-jacob updated this revision to Diff 45226. arpith-jacob added a comment. Addressed comments from similar patch for 'target enter data' directive. Added comment about 'target exit data'. Removed parens around 0. http://reviews.llvm.org/D16279 Files: include/clang-c/Index.h include/cl

Re: [PATCH] D15989: [OpenMP] Parsing + sema for "target enter data" and "target exit data" directives.

arpith-jacob marked 4 inline comments as done. arpith-jacob added a comment. http://reviews.llvm.org/D15989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15989: [OpenMP] Parsing + sema for "target enter data" and "target exit data" directives.

arpith-jacob updated this revision to Diff 45225. arpith-jacob added a comment. HasMapClause() is now static. Removed comment about 'target exit data'. Modified: just if(*I != nullptr && (*I)->getClauseKind() == OMPC_map) Done: Remove parens around 0 http://reviews.llvm.org/D15989 Files: incl

Re: r226298 - [AVX512] Add intrinsics for masked aligned FP loads and stores

> On Jan 18, 2016, at 6:00 PM, Adam Nemet wrote: > > >> On Jan 18, 2016, at 5:28 PM, Hal Finkel wrote: >> >> - Original Message - >>> From: "Adam Nemet" >>> To: cfe-comm...@cs.uiuc.edu >>> Sent: Friday, January 16, 2015 12:51:50 PM >>> Subject: r226298 - [AVX512] Add intrinsics for m

r258108 - [AVX512] Fix typo in r226298

Author: anemet Date: Mon Jan 18 20:02:25 2016 New Revision: 258108 URL: http://llvm.org/viewvc/llvm-project?rev=258108&view=rev Log: [AVX512] Fix typo in r226298 Hal noticed that the double/float got mixed up on the parameters for these. Modified: cfe/trunk/lib/Headers/avx512fintrin.h Modif

Re: r226298 - [AVX512] Add intrinsics for masked aligned FP loads and stores

> On Jan 18, 2016, at 5:28 PM, Hal Finkel wrote: > > - Original Message - >> From: "Adam Nemet" >> To: cfe-comm...@cs.uiuc.edu >> Sent: Friday, January 16, 2015 12:51:50 PM >> Subject: r226298 - [AVX512] Add intrinsics for masked aligned FP loads and >> stores >> >> Author: anemet >

Re: [PATCH] D16264: For FreeBSD, use _p variants of libraries for linking C++ programs

dws added a comment. I will try this out on a system running FreeBSD HEAD (as of r294306) and see how it does. http://reviews.llvm.org/D16264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D16307: [CUDA] Handle -O options (more) correctly.

jlebar updated this revision to Diff 45223. jlebar added a comment. Update comment http://reviews.llvm.org/D16307 Files: lib/Driver/Tools.cpp test/Driver/cuda-external-tools.cu Index: test/Driver/cuda-external-tools.cu === ---

Re: [PATCH] D16307: [CUDA] Handle -O options (more) correctly.

jlebar updated this revision to Diff 45222. jlebar added a comment. Map -Os, -Oz to -O2, rather than -O3. http://reviews.llvm.org/D16307 Files: lib/Driver/Tools.cpp test/Driver/cuda-external-tools.cu Index: test/Driver/cuda-external-tools.cu

Re: r226298 - [AVX512] Add intrinsics for masked aligned FP loads and stores

- Original Message - > From: "Adam Nemet" > To: cfe-comm...@cs.uiuc.edu > Sent: Friday, January 16, 2015 12:51:50 PM > Subject: r226298 - [AVX512] Add intrinsics for masked aligned FP loads and > stores > > Author: anemet > Date: Fri Jan 16 12:51:50 2015 > New Revision: 226298 > > UR

Re: [clang-tools-extra] r258098 - [clang-tidy] Fixed wording ("clang-tidy check", not "clang-tidy checker")

No worries, I reviewed at least some of these changes and haven't found the issues, but was later pointed to them by a community member ;) On Mon, Jan 18, 2016 at 11:58 PM, Aaron Ballman wrote: > On Mon, Jan 18, 2016 at 5:51 PM, Alexander Kornienko via cfe-commits > wrote: > > Author: alexfh >

Re: [PATCH] D15853: [PGO]: Simplify coverage data lowering code

davidxl added a comment. I missed the review comments earlier. The local var name is fixed. The getCoverageNamesVarName API name will be fixed later. Regarding to your question: the patch does not not change the behavior of the name handling. For all used functions, their names are handled in

[libcxx] r258107 - Fix PR#26175. Thanks to Josh Petrie for the report and the patch. Reviewed as http://reviews.llvm.org/D16262

Author: marshall Date: Mon Jan 18 18:50:37 2016 New Revision: 258107 URL: http://llvm.org/viewvc/llvm-project?rev=258107&view=rev Log: Fix PR#26175. Thanks to Josh Petrie for the report and the patch. Reviewed as http://reviews.llvm.org/D16262 Modified: libcxx/trunk/include/regex libcxx/

r258106 - Fix local variable name /NFC

Author: davidxl Date: Mon Jan 18 18:49:06 2016 New Revision: 258106 URL: http://llvm.org/viewvc/llvm-project?rev=258106&view=rev Log: Fix local variable name /NFC Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp cfe/trunk/lib/CodeGen/CoverageMappingGen.h Modified: cfe/trunk/lib/Cod

Re: [PATCH] D16307: [CUDA] Handle -O options (more) correctly.

At a quick glance Os and Oz should probably map to O2. On Mon, Jan 18, 2016, 4:19 PM Justin Lebar wrote: > jlebar created this revision. > jlebar added a reviewer: tra. > jlebar added subscribers: jhen, echristo, cfe-commits. > > Previously we'd crash the driver if you passed -O0. Now we try to

[PATCH] D16307: [CUDA] Handle -O options (more) correctly.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: jhen, echristo, cfe-commits. Previously we'd crash the driver if you passed -O0. Now we try to handle all of clang's various optimization flags in a sane way. http://reviews.llvm.org/D16307 Files: lib/Driver

Re: [libcxx] [PATCH] unordered_map: Avoid unnecessary mallocs when no insert occurs

ping > On 2016-Jan-11, at 16:23, Duncan P. N. Exon Smith > wrote: > > ping > >> On 2016-Jan-04, at 12:37, Duncan P. N. Exon Smith >> wrote: >> >> ping >> >>> On 2015-Dec-17, at 13:56, Duncan P. N. Exon Smith >>> wrote: >>> >>> On 2015-Dec-16, at 14:42, Duncan P. N. Exon Smith >>

Re: [clang-tools-extra] r258098 - [clang-tidy] Fixed wording ("clang-tidy check", not "clang-tidy checker")

On Mon, Jan 18, 2016 at 5:51 PM, Alexander Kornienko via cfe-commits wrote: > Author: alexfh > Date: Mon Jan 18 16:51:09 2016 > New Revision: 258098 > > URL: http://llvm.org/viewvc/llvm-project?rev=258098&view=rev > Log: > [clang-tidy] Fixed wording ("clang-tidy check", not "clang-tidy checker")

[clang-tools-extra] r258098 - [clang-tidy] Fixed wording ("clang-tidy check", not "clang-tidy checker")

Author: alexfh Date: Mon Jan 18 16:51:09 2016 New Revision: 258098 URL: http://llvm.org/viewvc/llvm-project?rev=258098&view=rev Log: [clang-tidy] Fixed wording ("clang-tidy check", not "clang-tidy checker") Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl03-c.rst clang-to

Re: [PATCH] D16286: [clang-tidy] Readability check for redundant parenthesis in return expression.

LegalizeAdulthood added inline comments. Comment at: clang-tidy/readability/ReturnWithRedundantParensCheck.cpp:41-44 @@ +40,6 @@ + + // Complex expression can be surrounded by parenthesis for readability + if (isComplexExpression(ParenExpression->getSubExpr())) { +return; +

r258097 - fix formatting; NFC

Author: spatel Date: Mon Jan 18 16:15:33 2016 New Revision: 258097 URL: http://llvm.org/viewvc/llvm-project?rev=258097&view=rev Log: fix formatting; NFC Modified: cfe/trunk/lib/CodeGen/CGCall.cpp Modified: cfe/trunk/lib/CodeGen/CGCall.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/l

Re: [PATCH] D16248: [Clang-tidy] rename misc-inefficient-algorithm to performance-inefficient-algorithm

Eugene.Zelenko updated the summary for this revision. Eugene.Zelenko removed rL LLVM as the repository for this revision. Eugene.Zelenko updated this revision to Diff 45209. Eugene.Zelenko added a comment. Add redirect documentation for old check name. http://reviews.llvm.org/D16248 Files: cl

Re: [PATCH][Modules][PR26179]

Thanks! Could you check it in? -- Vassil On 18/01/16 21:38, Richard Smith via cfe-commits wrote: LGTM On Jan 18, 2016 12:06 PM, "Vassil Vassilev" > wrote: Attaching v3 of the patch. Added your case to the current test and fixed my silly non-array mistake.

r258077 - The destructor name should be matched to ~Foo instead of Foo.

Author: aaronballman Date: Mon Jan 18 14:47:02 2016 New Revision: 258077 URL: http://llvm.org/viewvc/llvm-project?rev=258077&view=rev Log: The destructor name should be matched to ~Foo instead of Foo. Modified: cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.cpp Modified: cfe/trunk/unittests

r258072 - Add an AST matcher for checking whether a function is defaulted.

Author: aaronballman Date: Mon Jan 18 14:37:44 2016 New Revision: 258072 URL: http://llvm.org/viewvc/llvm-project?rev=258072&view=rev Log: Add an AST matcher for checking whether a function is defaulted. Patch by Jonathan Coe. Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/tru

[PATCH] D16301: Allow mode attribute for member variables again

sberg created this revision. sberg added reviewers: ABataev, aaron.ballman. sberg added a subscriber: cfe-commits. ...after r257868 "PR26111: segmentation fault with __attribute__((mode(QI))) on function declaration" (presumably accidentally) restricted it to variables and typedefs, excluding me

Re: [PATCH][Modules][PR26179]

LGTM On Jan 18, 2016 12:06 PM, "Vassil Vassilev" wrote: > Attaching v3 of the patch. Added your case to the current test and fixed > my silly non-array mistake. > -- Vassil > On 18/01/16 20:38, Richard Smith wrote: > > Please also add a test case that your old patch would have failed on, such > a

r258070 - Augments r258042; changes the AST matcher tests to use matchesNot and EXPECT_TRUE instead of EXPECT_FALSE. Adds a matcher test to ensure that static member functions are properly handled. Ge

Author: aaronballman Date: Mon Jan 18 14:28:57 2016 New Revision: 258070 URL: http://llvm.org/viewvc/llvm-project?rev=258070&view=rev Log: Augments r258042; changes the AST matcher tests to use matchesNot and EXPECT_TRUE instead of EXPECT_FALSE. Adds a matcher test to ensure that static member f

Re: [PATCH][Modules][PR26179]

Attaching v3 of the patch. Added your case to the current test and fixed my silly non-array mistake. -- Vassil On 18/01/16 20:38, Richard Smith wrote: Please also add a test case that your old patch would have failed on, such as: m1.h: extern int a[]; m2.h: extern int a[5]; x.cc: #include

r258066 - [TableGen] Merge the SuperClass Record and SMRange vector a single vector. This removes the state needed to manage the extract vector. NFC

Author: ctopper Date: Mon Jan 18 13:52:54 2016 New Revision: 258066 URL: http://llvm.org/viewvc/llvm-project?rev=258066&view=rev Log: [TableGen] Merge the SuperClass Record and SMRange vector a single vector. This removes the state needed to manage the extract vector. NFC Modified: cfe/trunk

Re: r257827 - [CMake] Set SVN_REVISION if CLANG_APPEND_VC_REV=On

CLANG_APPEND_VC_REV doesn't appear to be checked anywhere. Were the two ifs supposed to check it instead of SVN_VERSION? The way it is now if the first if body executes, the second if does too since add_version_info_from_vcs sets SVN_VERSION and thus satisfies the second if. On Mon, Jan 18, 2016 a

Fwd: Re: [PATCH][Modules][PR26179]

+ // the when comparing #1 and #2 we should go through their elements types. Typo "the when" + QualType VarXTy = VarX->getType(); + QualType VarYTy = VarY->getType(); + if (VarXTy->isIncompleteArrayType() || VarYTy->isIncompleteArrayType()) +return C.hasSameType(C.getA

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

On Tue, Jan 05, 2016 at 05:27:34AM +, Timon Van Overveldt via cfe-commits wrote: > Adds a number of constants, defined in the ARM EHABI spec, to the Clang > lib/Headers/unwind.h header. This is prerequisite for landing > http://reviews.llvm.org/D15781, as previously discussed there. IMO they

r258061 - [analyzer] Nullability: Look through implicit casts when suppressing warnings on return.

Author: dcoughlin Date: Mon Jan 18 12:53:33 2016 New Revision: 258061 URL: http://llvm.org/viewvc/llvm-project?rev=258061&view=rev Log: [analyzer] Nullability: Look through implicit casts when suppressing warnings on return. In r256567 I changed the nullability checker to suppress warnings about

[PATCH] D16298: Improve test coverage of -Wdouble-promotion

rob.lougher created this revision. rob.lougher added a reviewer: gbiv. rob.lougher added a subscriber: cfe-commits. The -Wdouble-promotion warning was added to clang in r251588 (fixing PR15109). The added test, however, only covered a subset of the cases where implicit conversion can occur (ass

Re: [PATCH] D15373: Fix for bug 25786 - Assertion "Chunk.Kind == DeclaratorChunk::Function" failed with regparm attribute.

a.makarov updated this revision to Diff 45178. a.makarov added a comment. I've updated the patch. Now, I've updated the function unwrapping mechanism to work properly with AttributedType. Please, re-review the patch. http://reviews.llvm.org/D15373 Files: lib/Sema/SemaType.cpp test/CodeGen/

r258039 - [analyzer] Fix an off-by-one in evalIntegralCast()

Author: dergachev Date: Mon Jan 18 04:17:16 2016 New Revision: 258039 URL: http://llvm.org/viewvc/llvm-project?rev=258039&view=rev Log: [analyzer] Fix an off-by-one in evalIntegralCast() Make sure that we do not add SymbolCast at the very boundary of the range in which the cast would not certainl

[PATCH][Modules][PR26179]

Hi, Could somebody review the attached patch. It fixes https://llvm.org/bugs/show_bug.cgi?id=26179 Many thanks! Vassil From 947a163ab4e13c44625085dd51faa656b72de3ac Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Sat, 16 Jan 2016 23:52:40 +0100 Subject: [PATCH] [modules] Teach clang to

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

timonvo added a comment. Logan, how should we proceed here? Can you approve the patch? I also have no committer rights to the project, so does that mean you (or someone else) need to commit it on my behalf? http://reviews.llvm.org/D15883 ___ cfe-c

Re: [PATCH] D15373: Fix for bug 25786 - Assertion "Chunk.Kind == DeclaratorChunk::Function" failed with regparm attribute.

a.makarov updated this revision to Diff 45179. a.makarov added a comment. Oops, forgot to drop svn properties. Done. Sorry for noise. http://reviews.llvm.org/D15373 Files: lib/Sema/SemaType.cpp test/CodeGen/pr25786.c test/Sema/pr25786.c Index: lib/Sema/SemaType.cpp ==

[PATCH] D16270: [clang-tidy] Python scripts shebang fixes

omtcyf0 created this revision. omtcyf0 added reviewers: klimek, alexfh. omtcyf0 added a subscriber: cfe-commits. This patch fixes shebang lines in Python script files. Most Python scripts in LLVM & Clang are using this shebang line. [[ https://mail.python.org/pipermail/tutor/2007-June/054816.htm

Re: [PATCH] D16270: [clang-tidy] Python scripts shebang fixes

omtcyf0 added a comment. @alexfh, yes, please! That'll be very nice. http://reviews.llvm.org/D16270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16262: [libc++] Treat trailing backslashes in a regex pattern as invalid.

jpetrie created this revision. jpetrie added a reviewer: mclow.lists. jpetrie added a subscriber: cfe-commits. std::regex should throw std::regex_error if constructed with a pattern ending in a trailing backslash, since a trailing backlash is not a valid escape sequence. http://reviews.llvm.org

Re: [PATCH] D16183: Added CheckName field to YAML report

Elijah_Th marked 2 inline comments as done. Elijah_Th added a comment. What kind of wrapper should it be? I was thinking of this kind: class ExtendedReplacement : public Replacement { public: ExtendedReplacement(StringRef CheckName, Replacement &R); StringRef getCheckName() const {

Re: [PATCH] D16179: [clang-tidy] Handle decayed types and other improvements in VirtualNearMiss check.

LegalizeAdulthood added a subscriber: LegalizeAdulthood. Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:54-55 @@ -53,16 +53,4 @@ // Both types must be pointers or references to classes. - if (const auto *DerivedPT = DerivedReturnTy->getAs()) { -if (const auto *Base

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

bcraig added a comment. ping http://reviews.llvm.org/D15539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16006: [libcxxabi] Teach cxa_demangle about Hexagon's long double size

bcraig added a reviewer: mclow.lists. bcraig added a comment. ping http://reviews.llvm.org/D16006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16007: [libcxxabi] Make test tolerant of uncommon floating literal demanglings

bcraig added a reviewer: mclow.lists. bcraig added a comment. ping http://reviews.llvm.org/D16007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16295: Change of UserLabelPrefix default value from "_" to ""

rafael added a comment. Thanks for working on this, but many of the changes setting the prefix to "_" look wrong. Comment at: lib/Basic/Targets.cpp:801 @@ -818,2 +800,3 @@ LongDoubleFormat = &llvm::APFloat::PPCDoubleDouble; +UserLabelPrefix = "_"; }

Re: [PATCH] D16262: [libc++] Treat trailing backslashes in a regex pattern as invalid.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This looks good to me. A quick search for `\\` in regex didn't find any other obvious instances of this anti-pattern. For the record, the bug is https://llvm.org/bugs/show_bug.cgi?

[PATCH] D16295: Change of UserLabelPrefix default value from "_" to ""

andreybokhanko created this revision. andreybokhanko added reviewers: rafael, rjmccall. andreybokhanko added subscribers: cfe-commits, rafael. @rafael proposed (http://reviews.llvm.org/D16138#325739) to change UserLablePrefix's default from "_" to "", as latter value happens much more often. Thi

Re: [PATCH] D15914: [OpenCL] Pipe builtin functions

Anastasia added a comment. A few nitpicks here, otherwise it seems we are in a good shape. I hope this will hit trunk soon. :) Comment at: lib/CodeGen/CGBuiltin.cpp:1966 @@ -1965,1 +1965,3 @@ } + + case Builtin::BIread_pipe: Can you put a comment with the s

Re: [PATCH] D16047: [OpenCL] Add Sema checks for OpenCL 2.0

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:7255 @@ -7209,3 +7254,3 @@ return PtrPtrKernelParam; -return PointeeType.getAddressSpace() == 0 ? PrivatePtrKernelParam - : PtrKernelParam; +// Now generi

RE: r257827 - [CMake] Set SVN_REVISION if CLANG_APPEND_VC_REV=On

Thanks, that did the trick. I've removed the workaround from LLVMLinux. > -Original Message- > From: cbiene...@apple.com [mailto:cbiene...@apple.com] On Behalf Of > Chris Bieneman > Sent: 15 January 2016 17:55 > To: Daniel Sanders > Cc: cfe-commits@lists.llvm.org > Subject: Re: r257827 - [

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia added a comment. I think some tests for new diagnostics are still missing? Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7676 @@ +7675,3 @@ +def err_opencl_invalid_read_write : Error< + "access qualifier read_write can not be used for %0 %select{|before CL2.

[PATCH] Happy new year 2016 !

Hi This updates the copyright year in LICENSE.TXT Attached the DIFF file with this message Index: LICENSE.TXT === --- LICENSE.TXT (revision 258045) +++ LICENSE.TXT (working copy) @@ -4,7 +4,7 @@ University of Illinois/NCSA Open Sou

Re: [PATCH] D16179: [clang-tidy] Handle decayed types and other improvements in VirtualNearMiss check.

alexfh added inline comments. Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:240 @@ -247,2 +239,3 @@ unsigned EditDistance = -BaseMD->getName().edit_distance(DerivedMD->getName()); +StringRef(BaseMD->getNameAsString()) +.edit_

Re: [PATCH] D16270: [clang-tidy] Python scripts shebang fixes

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! Do you need me to submit the patch? http://reviews.llvm.org/D16270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

r258042 - Add forEachArgumentWithParam AST matcher.

Author: klimek Date: Mon Jan 18 05:20:09 2016 New Revision: 258042 URL: http://llvm.org/viewvc/llvm-project?rev=258042&view=rev Log: Add forEachArgumentWithParam AST matcher. The new matcher allows users to provide a matcher for both the argument of a CallExpr/CxxConstructExpr a well as the ParmV

Re: [PATCH] D16178: [analyzer] A quick fix on top of D12901/r257464

This revision was automatically updated to reflect the committed changes. Closed by commit rL258039: [analyzer] Fix an off-by-one in evalIntegralCast() (authored by dergachev). Changed prior to commit: http://reviews.llvm.org/D16178?vs=44842&id=45159#toc Repository: rL LLVM http://reviews.l

Re: r257934 - [CMake] Support generation of linker order files using dtrace

It did, thanks! On 15 January 2016 at 23:28, Chris Bieneman wrote: > That should be fixed with r257948. > > -Chris > >> On Jan 15, 2016, at 3:19 PM, Renato Golin wrote: >> >> On 15 January 2016 at 21:21, Chris Bieneman via cfe-commits >> wrote: >>> Author: cbieneman >>> Date: Fri Jan 15 15:21:1