r258003 - [MS ABI] Don't crash while mangling recursive lambdas

2016-01-16 Thread David Majnemer via cfe-commits
Author: majnemer Date: Sun Jan 17 01:09:24 2016 New Revision: 258003 URL: http://llvm.org/viewvc/llvm-project?rev=258003&view=rev Log: [MS ABI] Don't crash while mangling recursive lambdas We might get into bad situations where we try to embed the signature of an inner lambda into an outer lambda

Re: [PATCH] D16102: Bug 25496 - clang++ -pg links with -lc++ instead of -lc++_p

2016-01-16 Thread Dimitry Andric via cfe-commits
dim commandeered this revision. dim added a reviewer: dws. dim added a comment. Going to abandon this review in favor of http://reviews.llvm.org/D16264. http://reviews.llvm.org/D16102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D16264: For FreeBSD, use _p variants of libraries for linking C++ programs

2016-01-16 Thread Dimitry Andric via cfe-commits
dim created this revision. dim added reviewers: compnerd, davide, dws, emaste. dim added subscribers: rpokala, cfe-commits. Herald added a subscriber: emaste. As reported in https://llvm.org/bugs/show_bug.cgi?id=25496, on FreeBSD, C++ programs compiled for profiling (using `-pg`) should be linked

Re: [PATCH] D16158: [CMake] Add clang's targets to LLVM's export set when not building standalone

2016-01-16 Thread don hinton via cfe-commits
hintonda added a comment. Sorry the previous change caused this configuration to break. However, I'm not sure about adding LLVMExports here. Shouldn't that be handled in llvm/CMakeLists.txt? In fact, this looks like a cmake bug (or feature) that won't let you export a target that depends on

Re: [PATCH] D16259: Add clang-tidy readability-redundant-return check

2016-01-16 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Thank you for this check! https://llvm.org/bugs/show_bug.cgi?id=21984 waited to be implemented for so looong time :-) By the word, other return related readability check idea: https://llvm.org/bugs/show_bug.cgi?i

[PATCH] D16261: [CUDA] Only allow __global__ on free functions and static member functions.

2016-01-16 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: cfe-commits, echristo, jhen. Warn for NVCC compatibility if you declare a static member function or inline function as __global__. http://reviews.llvm.org/D16261 Files: include/clang/Basic/DiagnosticSemaKinds

Re: r257982 - [libclang] Add missing CINDEX_LINKAGE from some new APIs in Index.h.

2016-01-16 Thread Argyrios Kyrtzidis via cfe-commits
> On Jan 16, 2016, at 1:15 AM, Ismail Donmez wrote: > > On Sat, Jan 16, 2016 at 5:01 AM, Argyrios Kyrtzidis via cfe-commits > wrote: >> Author: akirtzidis >> Date: Fri Jan 15 21:01:20 2016 >> New Revision: 257982 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=257982&view=rev >> Log: >> [li

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

2016-01-16 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 45077. hokein marked an inline comment as done. hokein added a comment. Format code style. http://reviews.llvm.org/D16113 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/google/GlobalNamesInHeadersCheck.cpp clang-tidy/google/GlobalN

Re: [PATCH] D16179: [clang-tidy] Handle decayed types and other improvements in VirtualNearMiss check.

2016-01-16 Thread Gábor Horváth via cfe-commits
xazax.hun added inline comments. Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:240 @@ -247,2 +239,3 @@ unsigned EditDistance = -BaseMD->getName().edit_distance(DerivedMD->getName()); +StringRef(BaseMD->getNameAsString()) +.ed

Re: r257947 - Avoid self-assignment of SmallString, trigger UB behavior down the road.

2016-01-16 Thread Joerg Sonnenberger via cfe-commits
Hello Richard, can this be merged into 3.8? It creates some trivial noise under valgrind. Joerg On Fri, Jan 15, 2016 at 10:29:34PM -, Joerg Sonnenberger via cfe-commits wrote: > Author: joerg > Date: Fri Jan 15 16:29:34 2016 > New Revision: 257947 > > URL: http://llvm.org/viewvc/llvm-projec

Re: [PATCH] D16179: [clang-tidy] Handle decayed types and other improvements in VirtualNearMiss check.

2016-01-16 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:54-55 @@ -53,16 +53,4 @@ // Both types must be pointers or references to classes. - if (const auto *DerivedPT = DerivedReturnTy->getAs()) { -if (const auto *BasePT = BaseReturnTy->getAs())

Re: [PATCH] D15989: [OpenMP] Parsing + sema for "target enter data" and "target exit data" directives.

2016-01-16 Thread Arpith Jacob via cfe-commits
arpith-jacob updated this revision to Diff 45075. arpith-jacob added a comment. Created a distinct patch for 'target enter data'. Added nesting test cases where the unstructured statement is nested in various regions. Removed extraneous comments. http://reviews.llvm.org/D15989 Files: include

Re: [PATCH] D15989: [OpenMP] Parsing + sema for "target enter data" and "target exit data" directives.

2016-01-16 Thread Arpith Jacob via cfe-commits
arpith-jacob updated this revision to Diff 45074. arpith-jacob added a comment. Created a distinct patch for 'target enter data'. Added nesting test cases where the unstructured statement is nested in various regions. http://reviews.llvm.org/D15989 Files: include/clang-c/Index.h include/cl

Re: r257982 - [libclang] Add missing CINDEX_LINKAGE from some new APIs in Index.h.

2016-01-16 Thread Ismail Donmez via cfe-commits
On Sat, Jan 16, 2016 at 5:01 AM, Argyrios Kyrtzidis via cfe-commits wrote: > Author: akirtzidis > Date: Fri Jan 15 21:01:20 2016 > New Revision: 257982 > > URL: http://llvm.org/viewvc/llvm-project?rev=257982&view=rev > Log: > [libclang] Add missing CINDEX_LINKAGE from some new APIs in Index.h. > >

r257989 - clang/test/Driver/darwin-multiarch-arm.c: Appease the case that "ld.exe" exists on %PATH% on win32.

2016-01-16 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Sat Jan 16 02:35:53 2016 New Revision: 257989 URL: http://llvm.org/viewvc/llvm-project?rev=257989&view=rev Log: clang/test/Driver/darwin-multiarch-arm.c: Appease the case that "ld.exe" exists on %PATH% on win32. Modified: cfe/trunk/test/Driver/darwin-multiarch-arm.c Mo