pxli168 updated this revision to Diff 44312.
pxli168 added a comment.
1. Refine the def of BUILTIN with LANGBUITIN with new OCLC_LANG
2. Remove mangler for the hard coded builtin function name
3. Fix some bugs.
http://reviews.llvm.org/D15914
Files:
include/clang/Basic/Builtins.def
include/c
Author: djasper
Date: Fri Jan 8 01:06:07 2016
New Revision: 257154
URL: http://llvm.org/viewvc/llvm-project?rev=257154&view=rev
Log:
clang-format: [JS] Support more ES6 classes.
Before:
foo = class {
constructor() {}
}
;
After:
foo = class {
constructor() {}
};
Modified:
pxli168 added a comment.
So here is the summary about the inline comments:
1. What kind of prototype should codegen output for these functions?
2. What function names should these builtins have in llvm ir?
3. Access for pipe use image's for now, and will be refined.
4. What rules should we follow
I think lldb was calling the setBases method. It could probably be easily
fixed, but I don't normally contribute to lldb and thus don't have a local
copy to commit with.
On Thu, Jan 7, 2016 at 6:58 PM, David Blaikie wrote:
>
>
> On Thu, Dec 24, 2015 at 4:36 PM, Craig Topper via cfe-commits <
> c
Author: jlebar
Date: Thu Jan 7 21:33:04 2016
New Revision: 257142
URL: http://llvm.org/viewvc/llvm-project?rev=257142&view=rev
Log:
[CUDA] Split out tests for unused-arg warnings from cuda-options.cu.
Summary: Trying to make this test a bit more manageable.
Reviewers: tra
Subscribers: cfe-comm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257142: [CUDA] Split out tests for unused-arg warnings from
cuda-options.cu. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D15974?vs=44270&id=44309#toc
Repository:
rL LLVM
h
jlebar added a comment.
This actually has a subtle issue not found with existing unit tests:
BuildJobsForAction has an outparam and we don't set it on cache hit.
Please hold off reviewing this until I fix the problem.
http://reviews.llvm.org/D15960
__
jlebar added a comment.
Changed to move ownership into Compilation, as discussed earlier today. Please
have a look.
http://reviews.llvm.org/D15911
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
jlebar updated this revision to Diff 44308.
jlebar retitled this revision from "Move ownership of Action objects into
Compilation.
" to "Move ownership of Action objects into Compilation.".
jlebar added a comment.
Clear both Actions and OwningActions in
Compilation::initCompilationForDiagnostics
jlebar updated this revision to Diff 44307.
jlebar added a comment.
Switch to maintaining ownership of the Actions within the Compilation.
http://reviews.llvm.org/D15911
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
lib/Driver/Acti
bruno updated this revision to Diff 44306.
bruno added a comment.
Hi Richard,
Thanks for the detailed explanation, it now makes sense to me. I updated the
patch with another approach! Let me know if it's the right direction.
http://reviews.llvm.org/D15173
Files:
include/clang/Lex/Preprocess
On Thu, Dec 24, 2015 at 4:36 PM, Craig Topper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ctopper
> Date: Thu Dec 24 18:36:02 2015
> New Revision: 256403
>
> URL: http://llvm.org/viewvc/llvm-project?rev=256403&view=rev
> Log:
> Revert r256399 "[Sema] ArrayRef-ize ActOnBaseSpecif
Presumably this only applies when using implicit modules builds, not when
using explicit modules builds. (though I'm not sure what the current
behavior of -gmodules is with explicit modules, maybe it's
untested/broken/etc anyway)
On Tue, Dec 22, 2015 at 2:37 PM, Adrian Prantl via cfe-commits <
cfe
arpith-jacob added inline comments.
Comment at: lib/Parse/ParseOpenMP.cpp:42
@@ -37,1 +41,3 @@
+ {OMPD_unknown /*target exit*/, OMPD_unknown /*data*/,
+ OMPD_target_exit_data},
{OMPD_for, OMPD_simd, OMPD_for_simd},
I have written this code based
arpith-jacob created this revision.
arpith-jacob added reviewers: kkwli0, sfantao, fraggamuffin, hfinkel, ABataev,
carlo.bertolli.
arpith-jacob added a subscriber: cfe-commits.
This patch adds parsing and sema support for "#pragma omp target enter data"
and "#pragma omp target exit data" directi
rsmith added a comment.
This should be checked and diagnosed in Sema, not in CodeGen.
Comment at: lib/CodeGen/CGDeclCXX.cpp:323-324
@@ +322,4 @@
+
+ // The constructor function has no parameters,
+ if (CD->getNumParams() != 0)
+return false;
What if the co
On Fri, Dec 18, 2015 at 2:40 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Fri Dec 18 16:40:25 2015
> New Revision: 256049
>
> URL: http://llvm.org/viewvc/llvm-project?rev=256049&view=rev
> Log:
> Split RequireCompleteType into a function that actu
Test case?
On Fri, Dec 18, 2015 at 11:44 AM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Fri Dec 18 13:44:31 2015
> New Revision: 256012
>
> URL: http://llvm.org/viewvc/llvm-project?rev=256012&view=rev
> Log:
> Add a defensive check for a nullptr.
>
dcoughlin commandeered this revision.
dcoughlin edited reviewers, added: ddkilzer; removed: dcoughlin.
dcoughlin added a comment.
I am commandeering this revision!
http://reviews.llvm.org/D5023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pcc created this revision.
pcc added a reviewer: rsmith.
pcc added a subscriber: cfe-commits.
http://reviews.llvm.org/D15985
Files:
lib/AST/ExprConstant.cpp
test/CodeGenCXX/global-init.cpp
Index: test/CodeGenCXX/global-init.cpp
probinson added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning()
echristo added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning() !
Interesting. Do we run test/asan/TestCases/suppressions-interceptor.cc on
Windows? Seems so: I don't see an XFAIL there, and it also uses
suppressions, but with single quote, followed by double quote:
%env_asan_opts=suppressions='"%t.supp"'
Why does it work there?
On Tue, Dec 22, 2015 at 4:35 PM
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D15974
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson added a comment.
FTR, the previous wiring-up-thru-Clang patches put the there-must-be-a-tuning
decision in the driver; CC1 does not assume or require a non-default tuning.
http://reviews.llvm.org/D15881
___
cfe-commits mailing list
cfe-co
probinson added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:363-370
@@ -362,2 +362,10 @@
+// Convenience functions for debugger tuning.
+static bool tuneForGDB(CodeGenOptions &Opts) {
+ return Opts.getDebuggerTuning() == CodeGenOptions::DebuggerKindGDB;
+}
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D15589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
echristo added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning() !
probinson updated this revision to Diff 44278.
probinson marked an inline comment as done.
http://reviews.llvm.org/D15881
Files:
lib/Frontend/CompilerInvocation.cpp
test/CodeGenCXX/debug-info-anon-namespace.cpp
Index: test/CodeGenCXX/debug-info-anon-namespace.cpp
aaboud created this revision.
aaboud added reviewers: probinson, aprantl, echristo, dblaikie.
aaboud added a subscriber: cfe-commits.
This is the full implementation in Clang of the proposal:
http://lists.llvm.org/pipermail/llvm-dev/2015-December/093313.html
http://reviews.llvm.org/D15977
Files:
jlebar updated this revision to Diff 44272.
jlebar marked 2 inline comments as done.
jlebar added a comment.
Address review comments.
http://reviews.llvm.org/D15911
Files:
include/clang/Driver/Action.h
include/clang/Driver/Driver.h
include/clang/Driver/Util.h
lib/Driver/Action.cpp
lib
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Trying to make this test a bit more manageable.
http://reviews.llvm.org/D15974
Files:
test/Driver/cuda-options.cu
test/Driver/cuda-unused-arg-warning.cu
Index: test/Driver/cuda-unused-arg-war
echristo added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:363-370
@@ -362,2 +362,10 @@
+// Convenience functions for debugger tuning.
+static bool tuneForGDB(CodeGenOptions &Opts) {
+ return Opts.getDebuggerTuning() == CodeGenOptions::DebuggerKindGDB;
+}
+
aaron.ballman closed this revision.
aaron.ballman added a comment.
For cleanliness. ;-)
http://reviews.llvm.org/D15958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
For posterity :)
http://reviews.llvm.org/D15958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
emaste added a comment.
> Sure, I was just making it the same as LLVM's default.
Yeah, the defaults ought to be the same; it turns out this change was just
premature.
http://reviews.llvm.org/D15967
___
cfe-commits mailing list
cfe-commits@lists.l
Author: dim
Date: Thu Jan 7 16:09:47 2016
New Revision: 257104
URL: http://llvm.org/viewvc/llvm-project?rev=257104&view=rev
Log:
Turn off lldb debug tuning by default for FreeBSD
Summary:
This is the clang part of D15966. In rL256104, debugger tuning was
added to the clang driver, and again the
probinson added a comment.
Sure, I was just making it the same as LLVM's default.
Now that it's wired up through clang, people who want LLDB can use -glldb to
get the same effect.
http://reviews.llvm.org/D15967
___
cfe-commits mailing list
cfe-comm
emaste accepted this revision.
emaste added a comment.
This revision is now accepted and ready to land.
I advocated for the lldb tuning by default on FreeBSD originally, but I didn't
fully understand the implications. It turns out we're just not ready yet. So,
LGTM.
http://reviews.llvm.org/D15
dim created this revision.
dim added reviewers: emaste, probinson.
dim added a subscriber: cfe-commits.
Herald added a subscriber: emaste.
This is the clang part of D15966. In rL256104, debugger tuning was
added to the clang driver, and again the default for FreeBSD was set to
lldb. The default
aaron.ballman added a comment.
Good catches! I've fixed those issues, and commit in r257097 (I thought I had
the LG, but now notice I don't -- if this is a problem, I will revert).
http://reviews.llvm.org/D15958
___
cfe-commits mailing list
cfe-com
Author: aaronballman
Date: Thu Jan 7 14:59:26 2016
New Revision: 257097
URL: http://llvm.org/viewvc/llvm-project?rev=257097&view=rev
Log:
Properly track that a character literal is UTF-8, and pretty print the prefix
properly.
Added:
cfe/trunk/test/Misc/ast-print-char-literal.cpp
cfe/tru
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D15953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
tstellarAMD updated this revision to Diff 44249.
tstellarAMD added a comment.
Use ld.lld alias instead of '-flavor gnu'
http://reviews.llvm.org/D15953
Files:
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/Driver/amdgpu-toolchain.c
Index: test/Driver/amdgpu-toolchain.c
=
tcanens added inline comments.
Comment at: include/string:2826-2827
@@ -2787,13 +2825,4 @@
#endif
-size_type __old_sz = size();
-difference_type __ip = __pos - begin();
-for (; __first != __last; ++__first)
-push_back(*__first);
-pointer __p = __get_pointe
tcanens added inline comments.
Comment at: include/string:2673
@@ -2654,1 +2672,3 @@
+ basic_string __temp (__first, __last, __alloc());
+ append(__temp.begin(), __temp.end());
return *this;
Likewise - should probably be `append(__temp.data(), __t
saugustine updated this revision to Diff 44245.
saugustine marked 4 inline comments as done.
saugustine added a comment.
- Update docs. Handle keywords and anonymous namespaces.
http://reviews.llvm.org/D15861
Files:
include/clang/Tooling/Core/QualTypeNames.h
lib/Tooling/Core/CMakeLists.txt
nwilson added a comment.
Ping. Now that the holidays are over-ish, as Aaron said in one of his Patches.
http://reviews.llvm.org/D13357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jlebar
Date: Thu Jan 7 13:38:29 2016
New Revision: 257090
URL: http://llvm.org/viewvc/llvm-project?rev=257090&view=rev
Log:
Remove extraneous "Note t" in comment.
Added in r167571.
Modified:
cfe/trunk/include/clang/Driver/ToolChain.h
Modified: cfe/trunk/include/clang/Driver/ToolCha
rsmith added a comment.
Thanks!
You also need to update ASTWriterDecl.cpp's construction of
`CharacterLiteralAbbrev` to allow three bits of `Kind` rather than two. (You
should be able to repro this with a PCH test pretty-printing a `U'x'` literal.)
Comment at: lib/Sema/SemaTe
On Wed, Jan 6, 2016 at 4:22 PM, Bruno Cardoso Lopes wrote:
> bruno updated this revision to Diff 44180.
> bruno added a comment.
>
> Hi Richard,
>
> Thanks for the comments. Updated the patch!
>
> In http://reviews.llvm.org/D15173#313235, @rsmith wrote:
>
> > I think that this will leave us with
Author: aaronballman
Date: Thu Jan 7 13:00:54 2016
New Revision: 257085
URL: http://llvm.org/viewvc/llvm-project?rev=257085&view=rev
Log:
Correcting the comment in a header file; NFC.
Modified:
cfe/trunk/include/clang/AST/BuiltinTypes.def
Modified: cfe/trunk/include/clang/AST/BuiltinTypes.d
ahatanak added a comment.
ping
http://reviews.llvm.org/D15599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson added a comment.
Ping. I did want to get this finished off (moving all triple-based decisions to
tuning-based decisions) before 3.8 branches.
http://reviews.llvm.org/D15881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
alexfh added a comment.
A few more comments.
Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:22
@@ +21,3 @@
+
+bool VirtualNearMissCheck::isOverrideMethod(const CXXMethodDecl *MD) {
+ return MD->size_overridden_methods() > 0 || MD->hasAttr();
This should b
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
It'll be great to finalize fix before 3.8 branching (planned at January 13).
http://reviews.llvm.org/D15506
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
hokein added a comment.
In http://reviews.llvm.org/D15710#321198, @aaron.ballman wrote:
> LGTM, thank you for working on this!
Ping @Alexfh. After the patch gets merged, I will work on the configuration of
header file extension.
http://reviews.llvm.org/D15710
_
tcanens added inline comments.
Comment at: include/string:2677-2678
@@ +2676,4 @@
+#endif
+for (; __first != __last; ++__first)
+push_back(*__first);
+
If an exception is thrown after a `push_back()` causes reallocation, existing
iterators/poi
ruiu added a comment.
You can use "ld.lld" which is a symlink to lld instead of "lld -flavor gnu".
http://reviews.llvm.org/D15953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists marked an inline comment as done.
mclow.lists added a comment.
http://reviews.llvm.org/D15862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists updated this revision to Diff 44220.
mclow.lists added a comment.
Fixed a problem in the `__is_exactly_input_iterator` trait where it would fail
to compile if `<_Iter>` was not an iterator.
Added the cases for `append`, `insert`, and `replace`.
I have updated the tests (not included
It looks like that's just wasmate. I'll accelerate its deletion.
On Wed, Jan 6, 2016 at 6:41 PM, JF Bastien wrote:
> Hi Dan,
>
> I think this change (or one of the surrounding ones) broken compiling C
> code with WebAssembly.
>
> Errors look like: error at line 3: unknown section: .text.foobar
aaron.ballman added a comment.
(Sorry, fat fingered the original response.)
In http://reviews.llvm.org/D15456#320946, @rsmith wrote:
> I'm unconvinced this meets the bar for an on-by-default warning. Your
> suggested workaround for correct-but-diagnosed code doesn't seem to work: if
> I have
>
aaron.ballman added a comment.
In http://reviews.llvm.org/D15456#320946, @rsmith wrote:
> I'm unconvinced this meets the bar for an on-by-default warning. Your
> suggested workaround for correct-but-diagnosed code doesn't seem to work: if
> I have
>
> struct X {
> X(const volatile X&);
>
Anastasia added inline comments.
Comment at: include/clang/Basic/Builtins.def:1255
@@ -1254,1 +1254,3 @@
+// OpenCL 2.0 Pipe functions.
+// We need the variadic prototype, since the packet type could be anything.
Could we put reference to spec section?
Author: sfantao
Date: Thu Jan 7 08:58:16 2016
New Revision: 257065
URL: http://llvm.org/viewvc/llvm-project?rev=257065&view=rev
Log:
[OpenMP] Fix issue in the offloading metadata testing.
- Allow device ID to be signed.
- Add missing semicolon to some of the CHECK directives.
Thanks to Amjad
Author: djasper
Date: Thu Jan 7 08:36:11 2016
New Revision: 257062
URL: http://llvm.org/viewvc/llvm-project?rev=257062&view=rev
Log:
clang-format: Support weird lambda macros.
Before:
MACRO((AA & a) { return 1; });
After:
MACRO((AA &a) { return 1; });
Modified:
cfe/trunk/lib/Format/Tok
Hi Samuel,
I noticed that the two tests you added in the below commit have a minor issue.
"target_codegen_registration_naming.cpp" is failing on my local machine (Win32).
"target_codegen_registration.cpp" is not failing, but it contain "CHECK..."
lines with wrong syntax that make FileCheck ignore
Author: djasper
Date: Thu Jan 7 06:53:59 2016
New Revision: 257057
URL: http://llvm.org/viewvc/llvm-project?rev=257057&view=rev
Log:
Add missing -no-canonical-prefixes.
Modified:
cfe/trunk/test/Driver/wasm-toolchain.c
Modified: cfe/trunk/test/Driver/wasm-toolchain.c
URL:
http://llvm.org/vi
congliu updated this revision to Diff 44197.
congliu added a comment.
- Corrected naming styles; Used clang-format; Add doc to .h
- Removed useless parentheses, braces around one-line ifs.
- Added doc; Corrected style and typos for test.
- Implemented c++ [class.virtual]p7. But has bug.
- Support
Author: skalinichev
Date: Thu Jan 7 03:20:40 2016
New Revision: 257043
URL: http://llvm.org/viewvc/llvm-project?rev=257043&view=rev
Log:
[libclang] Handle AutoType in clang_getTypeDeclaration
Differential Revision: http://reviews.llvm.org/D13001
Added:
cfe/trunk/test/Index/print-type-declar
hokein updated this revision to Diff 44193.
hokein added a comment.
Address Aaron's comments.
http://reviews.llvm.org/D15710
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/DefinitionsInHeadersCheck.cpp
clang-tidy/misc/DefinitionsInHeadersCheck.h
clang-tidy/misc/MiscTidyModule.cpp
72 matches
Mail list logo
