dougk created this revision.
dougk added reviewers: thakis, probinson.
dougk added a subscriber: cfe-commits.
Something like this was suggested in http://reviews.llvm.org/D13221
http://reviews.llvm.org/D15882
Files:
lib/Frontend/CompilerInvocation.cpp
test/Driver/debug-options.c
Index: tes
pxli168 added inline comments.
Comment at: lib/AST/ASTContext.cpp:3121
@@ +3120,3 @@
+QualType ASTContext::getPipeType(QualType T) const {
+ // Unique pointers, to guarantee there is only one pointer of a particular
+ // structure.
Anastasia wrote:
> Could we up
probinson created this revision.
probinson added reviewers: echristo, dblaikie, aprantl.
probinson added a subscriber: cfe-commits.
GDB and LLDB don't mind if we omit the explicit import of an anonymous
namespace.
http://reviews.llvm.org/D15881
Files:
lib/Frontend/CompilerInvocation.cpp
te
Author: rsmith
Date: Mon Jan 4 19:21:53 2016
New Revision: 256803
URL: http://llvm.org/viewvc/llvm-project?rev=256803&view=rev
Log:
Avoid walking all the declarations in the TU when a tag is declared in function
prototype scope in a function definition.
Modified:
cfe/trunk/lib/Sema/SemaDecl.
tra added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:1235-1236
@@ -1235,8 +1234,4 @@
// different type.
-// FIXME: Support for variables is not implemented yet.
-if (isa(D.getDecl()))
- GV = cast(GetAddrOfGlobal(D,
/*IsForDefinition=*/true));
-
ygao added a comment.
> What I would suggest is:
>
> Check that this test fails at least on windows with your patch
>
> reverted. If so, commit it. BTW, don't you need to drop the "|
> FileCheck" to cause a crash?
Hmm, even with the pipe removed, I still have difficulty reproducing the
On Mon, Jan 4, 2016 at 4:04 PM, Roland McGrath wrote:
> Kostya, do you remember the exact original case in glibc for 22830 and
> what glibc change fixed it?
>
Sadly, no.
I only know that the code was reduced from the code that was setting these
attributes for strtol.
I vaguely recall the case,
Kostya, do you remember the exact original case in glibc for 22830 and
what glibc change fixed it?
I vaguely recall the case, but not enough to find the actual change
and compare it to the new scenarios.
I suspect that the original case was easy to fix because it was just
that the hidden_proto magi
Author: majnemer
Date: Mon Jan 4 18:08:41 2016
New Revision: 256797
URL: http://llvm.org/viewvc/llvm-project?rev=256797&view=rev
Log:
Remove an unused parameter
No functionality change is intended
Modified:
cfe/trunk/include/clang/Sema/Sema.h
cfe/trunk/lib/Parse/ParseStmtAsm.cpp
cfe
rsmith added inline comments.
Comment at: include/clang/Tooling/Core/QualTypeNames.h:32
@@ +31,3 @@
+namespace TypeName {
+///\brief Convert the type into one with fully qualified template
+/// arguments.
Please ensure there's a space between each `/// ` and the c
Author: majnemer
Date: Mon Jan 4 17:51:15 2016
New Revision: 256795
URL: http://llvm.org/viewvc/llvm-project?rev=256795&view=rev
Log:
[ms-inline-asm] Handle dependent identifiers in inline asm
Build up a dependent expression for MS-style inline assembly if the
identifier's type is dependent.
Th
Thanks for checking, Nick!
+Roland, FYI (recent changes in clang break compilation of all of the
glibc),
similar to https://llvm.org/bugs/show_bug.cgi?id=22830#c1
On Mon, Jan 4, 2016 at 3:21 PM, Nick Lewycky wrote:
> On 01/04/2016 01:40 PM, Kostya Serebryany wrote:
>
>>
>>
>> On Thu, Dec 17, 201
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256793: Remove setting of inlinehint and cold attributes
based on profile data (authored by eraman).
Changed prior to commit:
http://reviews.llvm.org/D15726?vs=43479&id=43937#toc
Repository:
rL LLVM
Author: eraman
Date: Mon Jan 4 17:32:28 2016
New Revision: 256793
URL: http://llvm.org/viewvc/llvm-project?rev=256793&view=rev
Log:
Remove setting of inlinehint and cold attributes based on profile data
NFC. These hints are only used for inlining and the inliner now uses
the same criteria to ide
aaron.ballman added a comment.
Ping now that the holidays are somewhat over-ish.
http://reviews.llvm.org/D15456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 01/04/2016 01:40 PM, Kostya Serebryany wrote:
On Thu, Dec 17, 2015 at 5:03 PM, Richard Smith mailto:rich...@metafoo.co.uk>> wrote:
On Thu, Dec 17, 2015 at 3:59 PM, Nick Lewycky via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
On 12/17/2015 10:47 AM, Kostya Serebry
Hello everyone,
Below are some buildbot numbers for the last week of 12/27/2015 -
01/02/2016.
Thanks
Galina
Number of commits by project:
project | commits
---+---
llvm | 102
cfe |
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM, and thanks for all of the iteration.
-eric
http://reviews.llvm.org/D15223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
tcanens added a subscriber: tcanens.
Comment at: include/string:2523
@@ +2522,3 @@
+ call_input();
+ basic_string temp(__first, __last);
+this->swap(temp);
This default constructs the allocator, but the allocator may not be default
constructible.
Author: eugenezelenko
Date: Mon Jan 4 15:25:10 2016
New Revision: 256780
URL: http://llvm.org/viewvc/llvm-project?rev=256780&view=rev
Log:
Fix typo.
Modified:
clang-tools-extra/trunk/docs/index.rst
Modified: clang-tools-extra/trunk/docs/index.rst
URL:
http://llvm.org/viewvc/llvm-project/cl
nlewycky added a subscriber: nlewycky.
nlewycky added a comment.
(I'm not doing a full review, I just happened to notice a couple things when
skimming.)
Comment at: lib/Tooling/Core/QualTypeNames.cpp:250
@@ +249,3 @@
+// There are probably other cases ...
+if (const Tag
thakis created this revision.
thakis added a reviewer: rsmith.
thakis added a subscriber: cfe-commits.
As far as I can tell, doing
#define HAVE_FOO_BAR defined(FOO) && defined(BAR)
#if HAVE_FOO
...
#endif
has undefined behavior per [cpp.cond]p4. In practice, it can have different
ping
> On 2015-Dec-17, at 13:56, Duncan P. N. Exon Smith
> wrote:
>
>
>> On 2015-Dec-16, at 14:42, Duncan P. N. Exon Smith
>> wrote:
>>
>> This is a follow-up to r239666: "Fix PR12999 - unordered_set::insert
>> calls operator new when no insert occurs". That fix didn't apply to
>> `unorder
> On 2016-Jan-04, at 12:02, Marshall Clow via cfe-commits
> wrote:
>
> mclow.lists updated this revision to Diff 43906.
> mclow.lists added a comment.
>
> Howard suggested a fix for the "is incremental" problem in the type trait. I
> also added assignable.
>
>
> http://reviews.llvm.org/D1586
mclow.lists added a comment.
ping?
http://reviews.llvm.org/D15121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists updated this revision to Diff 43906.
mclow.lists added a comment.
Howard suggested a fix for the "is incremental" problem in the type trait. I
also added assignable.
http://reviews.llvm.org/D15862
Files:
include/algorithm
include/iterator
include/string
Index: include/string
mclow.lists marked an inline comment as done.
mclow.lists added a comment.
http://reviews.llvm.org/D15862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I've finally had time to circle back to this, and just sent a version of
this through reviews.llvm.org.
It is highly edited, and we may as well start from scratch. In particular,
my usecase has no need for all the desugaring, so I have removed it all. So
no std::vector special casing, and no desug
mclow.lists added inline comments.
Comment at: include/string:1211
@@ +1210,3 @@
+// noexcept(declval<_Iter>().operator++()) &&
+// noexcept(++(declval<_Iter>())) &&
+ noexcept(declval<_Iter>() == declval<_Iter>()) &&
This is not quite right yet.
mclow.lists created this revision.
mclow.lists added reviewers: howard.hinnant, EricWF, rsmith.
mclow.lists added a subscriber: cfe-commits.
libc++'s basic_string class assumes that iterator operations on the iterators
that are passed to it don't throw. This is wrong, and means that we don't mee
Author: ab
Date: Mon Jan 4 13:35:40 2016
New Revision: 256772
URL: http://llvm.org/viewvc/llvm-project?rev=256772&view=rev
Log:
[libcxx] Fix typo in darwin target_info.py introduced by r256621.
Modified:
libcxx/trunk/test/libcxx/test/target_info.py
Modified: libcxx/trunk/test/libcxx/test/ta
timshen added a comment.
Ping?
http://reviews.llvm.org/D15589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: lib/AST/ASTContext.cpp:3121
@@ +3120,3 @@
+QualType ASTContext::getPipeType(QualType T) const {
+ // Unique pointers, to guarantee there is only one pointer of a particular
+ // structure.
Could we update the comment
george.burgess.iv updated this revision to Diff 43900.
george.burgess.iv added a comment.
Rebased
http://reviews.llvm.org/D15590
Files:
include/clang/Sema/Overload.h
include/clang/Sema/Sema.h
lib/Sema/SemaExpr.cpp
lib/Sema/SemaOverload.cpp
test/CodeGenCXX/pass-object-size.cpp
test/S
Nice!
is a fuzzer for clang-tidy possible/desirable?
similar to what we have for clang and clang-format
(tools/clang-format/fuzzer, ./tools/clang-fuzzer)
On Tue, Dec 29, 2015 at 8:14 AM, Alexander Kornienko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: alexfh
> Date: Tue Dec 29
jeanphilippeD added a comment.
Thanks,
Would you be happy to commit it for me since i do not have commit access.
http://reviews.llvm.org/D15266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
jhen created this revision.
jhen added reviewers: tra, jlebar.
jhen added a subscriber: cfe-commits.
Value, type, and instantiation dependence were not being handled
correctly for CUDAKernelCallExpr AST nodes. As a result, if an undeclared
identifier was used in the triple-angle-bracket kernel cal
george.burgess.iv added a comment.
Ping :)
http://reviews.llvm.org/D15721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.burgess.iv added a comment.
Ping :)
http://reviews.llvm.org/D14877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.burgess.iv added a comment.
Ping :)
http://reviews.llvm.org/D15721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LegalizeAdulthood added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:4990
@@ +4989,3 @@
+ EXPECT_TRUE(matches("typedef int hasUnderlyingTypeTest;",
+ typedefDecl(hasUnderlyingType(asString("int");
+ EXPECT_TRUE(
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256762: Add some overlooked optnone tests, and tighten up an
existing test. (authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D15704?vs=43416&id=43891#toc
Repository:
rL LLVM
Author: probinson
Date: Mon Jan 4 11:03:58 2016
New Revision: 256762
URL: http://llvm.org/viewvc/llvm-project?rev=256762&view=rev
Log:
Add some overlooked optnone tests, and tighten up an existing test.
Differential Revision: http://reviews.llvm.org/D15704
Added:
cfe/trunk/test/CodeGenCXX/o
alexfh added a comment.
Looks like you've forgotten to upload a new patch.
http://reviews.llvm.org/D15823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Mon Jan 4 10:10:36 2016
New Revision: 256759
URL: http://llvm.org/viewvc/llvm-project?rev=256759&view=rev
Log:
clang-format: [JS] Support more ES6 default exports.
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trunk/unittests/Format/FormatTestJS.cpp
Modifie
alexfh added inline comments.
Comment at: docs/clang-tidy/checks/misc-definitions-in-headers.rst:19
@@ +18,3 @@
+ }
+
+ // error
hokein wrote:
> About the internal linkage variable definition, how about only warning the
> variable in unnamed namespace?
>
> T
alexfh added inline comments.
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:52
@@ +51,3 @@
+
+ // Internal linkage variable and function definitions are allowed:
+ // const int a = 1;
I'd say "ignored for now" instead of "allowed". We might want to
Author: djasper
Date: Mon Jan 4 09:51:56 2016
New Revision: 256758
URL: http://llvm.org/viewvc/llvm-project?rev=256758&view=rev
Log:
clang-format: [JS] Support ES6 exports of array literals.
Before:
export default[aaa,
bb
hokein marked an inline comment as done.
Comment at: docs/clang-tidy/checks/misc-definitions-in-headers.rst:19
@@ +18,3 @@
+ }
+
+ // error
About the internal linkage variable definition, how about only warning the
variable in unnamed namespace?
The const/st
On Wed, Dec 30, 2015 at 12:28 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Dec 29, 2015 at 11:17:28PM -, Nico Weber via cfe-commits wrote:
> > Author: nico
> > Date: Tue Dec 29 17:17:27 2015
> > New Revision: 256596
> >
> > URL: http://llvm.org/viewvc/l
hokein updated this revision to Diff 43887.
hokein added a comment.
Add !inMainFile check.
http://reviews.llvm.org/D15710
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/DefinitionsInHeadersCheck.cpp
clang-tidy/misc/DefinitionsInHeadersCheck.h
clang-tidy/misc/MiscTidyModule.cpp
alexfh added inline comments.
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:25
@@ +24,3 @@
+ SourceLocation ExpansionLoc = SM.getExpansionLoc(Node.getLocStart());
+ StringRef Filename = SM.getFilename(ExpansionLoc);
+ return Filename.endswith(".h") || Filename.endsw
alexfh added inline comments.
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:25
@@ +24,3 @@
+ SourceLocation ExpansionLoc = SM.getExpansionLoc(Node.getLocStart());
+ StringRef Filename = SM.getFilename(ExpansionLoc);
+ return Filename.endswith(".h") || Filename.endsw
alexfh added inline comments.
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:25
@@ +24,3 @@
+ SourceLocation ExpansionLoc = SM.getExpansionLoc(Node.getLocStart());
+ StringRef Filename = SM.getFilename(ExpansionLoc);
+ return Filename.endswith(".h") || Filename.endsw
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:25
@@ +24,3 @@
+ SourceLocation ExpansionLoc = SM.getExpansionLoc(Node.getLocStart());
+ StringRef Filename = SM.getFilename(ExpansionLoc);
+ return Filename.endswith(".h") || Fil
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:25
@@ +24,3 @@
+ SourceLocation ExpansionLoc = SM.getExpansionLoc(Node.getLocStart());
+ StringRef Filename = SM.getFilename(ExpansionLoc);
+ return Filename.endswith(".h") || Filenam
alexfh added inline comments.
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:24
@@ +23,3 @@
+ .bind("name-decl"),
+ this);
+}
We're looking at the problem from different angles. My view is that a
reasonable file naming convention (wh
bcraig added a comment.
Ping.
If desired, I could provide an alternative implementation where all the structs
are allocated at global scope with their original padding.
http://reviews.llvm.org/D15539
___
cfe-commits mailing list
cfe-commits@lists.l
labrinea updated the summary for this revision.
labrinea updated this revision to Diff 43885.
labrinea added a comment.
Disabled optimizers.
http://reviews.llvm.org/D15223
Files:
test/CodeGen/aarch64-v8.1a-neon-intrinsics.c
test/CodeGen/arm-v8.1a-neon-intrinsics.c
Index: test/CodeGen/arm-v
aaron.ballman closed this revision.
aaron.ballman added a comment.
I've commit in r256756, thanks!
http://reviews.llvm.org/D15805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 43886.
hokein added a comment.
Move header file check to AST matcher.
http://reviews.llvm.org/D15710
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/DefinitionsInHeadersCheck.cpp
clang-tidy/misc/DefinitionsInHeadersCheck.h
clang-tidy/misc/MiscT
Author: aaronballman
Date: Mon Jan 4 08:31:14 2016
New Revision: 256756
URL: http://llvm.org/viewvc/llvm-project?rev=256756&view=rev
Log:
Rename the CERT namespace to cert, and update some checkers to use this
namespace consistently.
Patch thanks to Haojian Wu!
Modified:
clang-tools-extra/
bsmith updated this revision to Diff 43884.
bsmith added a comment.
Rebase patch against latest changes made to ARMv8-M targeting, specifically the
removal of 'B' as a profile.
Repository:
rL LLVM
http://reviews.llvm.org/D15283
Files:
lib/Basic/Targets.cpp
lib/Driver/Tools.cpp
test/Dr
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:31
@@ +30,3 @@
+ // inline function with external linkage, class template, non-static function
+ // template, static data member of a class template, member function of a
+ // class t
hokein added inline comments.
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:31
@@ +30,3 @@
+ // inline function with external linkage, class template, non-static function
+ // template, static data member of a class template, member function of a
+ // class template
hokein added a comment.
In http://reviews.llvm.org/D15805#318646, @aaron.ballman wrote:
> In http://reviews.llvm.org/D15805#318624, @hokein wrote:
>
> > > Yes, but just the namespaces as you do in this patch (not anything in
> > > user documentation, for instance). This patch LG; if you need me
andreybokhanko added a comment.
Ping!
http://reviews.llvm.org/D15686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Mon Jan 4 07:11:41 2016
New Revision: 256753
URL: http://llvm.org/viewvc/llvm-project?rev=256753&view=rev
Log:
clang-format: [JS] Improve empty array literal detection.
Previously, the [] in the following example were recognized as an array
subscript leading to weird indent
aaron.ballman added a comment.
In http://reviews.llvm.org/D15805#318624, @hokein wrote:
> > Yes, but just the namespaces as you do in this patch (not anything in user
> > documentation, for instance). This patch LG; if you need me to commit on
> > your behalf, I'm happy to do so.
>
>
> Done. Bu
Author: djasper
Date: Mon Jan 4 06:41:11 2016
New Revision: 256750
URL: http://llvm.org/viewvc/llvm-project?rev=256750&view=rev
Log:
clang-format: Fix corner case in builder-type call formatting.
Before:
return .aaa(a,
congliu marked 20 inline comments as done.
Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:59
@@ +58,3 @@
+bool VirtualNearMissCheck::isOverrideMethod(const CXXMethodDecl *MD){
+ return MD->size_overridden_methods() > 0 || MD->hasAttr();
+}
alexfh wrote:
> W
Author: dim
Date: Mon Jan 4 04:17:48 2016
New Revision: 256742
URL: http://llvm.org/viewvc/llvm-project?rev=256742&view=rev
Log:
Convert test/CXX/lex/lex.literal/lex.string/p4.cpp back to DOS line
endings, since the file is supposed to have them, according to its
comments. Also set its svn:eol-s
djasper added a comment.
I actually have more thoughts on this. If we go down this road, there are many
more options that people might envision. Maybe they don't want to wrap the
initializer list, if there is just one initializer. Maybe they want to align
the initializers somewhere after the co
djasper added a comment.
The Google and Unity style guides have explicit examples of using the one-line
version. The other style guide (at least to me) isn't clear on forbidding what
clang-format currently does.
My gut feeling is that it is not worth the cost of renaming and extending the
curr
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D15266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
hokein added a comment.
> Yes, but just the namespaces as you do in this patch (not anything in user
> documentation, for instance). This patch LG; if you need me to commit on your
> behalf, I'm happy to do so.
Done. But My account has no write access to the code repo. Can I commit the
patch
hokein updated this revision to Diff 43870.
hokein added a comment.
Rename: 'CERT' => 'cert'
http://reviews.llvm.org/D15805
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/SetLongJmpCheck.cpp
clang-tidy/cert/SetLongJmpCheck.h
clang-tidy/cert/StaticObjectExceptionCheck.cpp
cl
77 matches
Mail list logo
