DmitryPolukhin updated this revision to Diff 43775.
DmitryPolukhin marked 8 inline comments as done.
DmitryPolukhin added a comment.
Fixed comments.
http://reviews.llvm.org/D15524
Files:
include/clang/AST/DeclBase.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/cla
Author: chandlerc
Date: Wed Dec 30 00:38:29 2015
New Revision: 256630
URL: http://llvm.org/viewvc/llvm-project?rev=256630&view=rev
Log:
[ptr-traits] Add another complete type that is necessary for at least
some of the build bots. Still can't reproduce these failures locally.
Modified:
cfe/tru
Author: chandlerc
Date: Wed Dec 30 00:21:02 2015
New Revision: 256629
URL: http://llvm.org/viewvc/llvm-project?rev=256629&view=rev
Log:
[ptr-traits] Some compilers (older Clang? unsure) on build bots need
this constructor to be out of line in order to not require the complete
type of TemplateDecl.
Author: majnemer
Date: Tue Dec 29 23:40:32 2015
New Revision: 256623
URL: http://llvm.org/viewvc/llvm-project?rev=256623&view=rev
Log:
[MS ABI] Add variable templates to the NameBackReferences
Only function template specializations are exempt from being added to
the NameBackReferences. Redundant
Author: majnemer
Date: Tue Dec 29 23:13:03 2015
New Revision: 256622
URL: http://llvm.org/viewvc/llvm-project?rev=256622&view=rev
Log:
[MS ABI] Improve our mangling of pass_object_size
We didn't add the artificial pass_object_size arguments to the
backreference map which bloated the size of mangl
EricWF added a comment.
I re-added the feature myself in r256621.
http://reviews.llvm.org/D15813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Tue Dec 29 22:45:42 2015
New Revision: 256621
URL: http://llvm.org/viewvc/llvm-project?rev=256621&view=rev
Log:
Fix locale feature testing in test suite.
Modified:
libcxx/trunk/test/libcxx/test/target_info.py
Modified: libcxx/trunk/test/libcxx/test/target_info.py
URL:
h
Author: jyknight
Date: Tue Dec 29 21:58:33 2015
New Revision: 256619
URL: http://llvm.org/viewvc/llvm-project?rev=256619&view=rev
Log:
Fix alignment issue in CodeGenFunction::PopCleanupBlock.
It was copying an EHCleanupStack::Cleanup object into a
SmallVector, with a comment saying that SmallVect
ABataev added a comment.
Hello Michael,
Thanks for working on this. I still think we don't need OMPDeclareTargetDecl
here and we can handle everything with an attribute. Try to implement
everything just with an attribute and without OMPDeclareTargetDecl.
http://reviews.llvm.org/D15321
_
Author: chandlerc
Date: Tue Dec 29 21:40:23 2015
New Revision: 256615
URL: http://llvm.org/viewvc/llvm-project?rev=256615&view=rev
Log:
[ptr-traits] Add #includes of headers rather than forward declarations
for types which are used as pointees in PointerUnions, PointerIntPairs,
and DenseMap pointe
Author: ericwf
Date: Tue Dec 29 21:39:03 2015
New Revision: 256614
URL: http://llvm.org/viewvc/llvm-project?rev=256614&view=rev
Log:
Revert r256606 due to compiler-rt sanitizer bot failures
Modified:
libcxx/trunk/CMakeLists.txt
libcxx/trunk/cmake/Modules/HandleOutOfTreeLLVM.cmake
Modifie
Author: chandlerc
Date: Tue Dec 29 21:33:22 2015
New Revision: 256613
URL: http://llvm.org/viewvc/llvm-project?rev=256613&view=rev
Log:
[ptr-traits] Move a class definition up to the top of this header so it
can be referenced as part of a PointerIntPair.
This is part of a series of patches to all
Author: chandlerc
Date: Tue Dec 29 21:24:14 2015
New Revision: 256612
URL: http://llvm.org/viewvc/llvm-project?rev=256612&view=rev
Log:
[ptr-traits] Move methods manipulating PointerUnions, DenseMap pointer
keys, and PointerIntPairs where the pointee types are incomplete
out-of-line to where we ha
Author: chandlerc
Date: Tue Dec 29 21:09:25 2015
New Revision: 256611
URL: http://llvm.org/viewvc/llvm-project?rev=256611&view=rev
Log:
[ptr-traits] Switch the Redeclarable template to using a void pointer in
its PointerUnion rather than an ASTContext pointer.
Using pointers with PointerUnion rea
Author: chandlerc
Date: Tue Dec 29 21:00:23 2015
New Revision: 256610
URL: http://llvm.org/viewvc/llvm-project?rev=256610&view=rev
Log:
[ptr-traits] Switch from a really wasteful SmallDenseMap of
SmallVector<.., 16> (16) objects to a simple SmallVector of pairs.
This no longer de-duplicates t
Author: chandlerc
Date: Tue Dec 29 20:51:00 2015
New Revision: 256609
URL: http://llvm.org/viewvc/llvm-project?rev=256609&view=rev
Log:
[ptr-traits] Stop using two bogus types as stand-ins for flags
indicating the nature of the default argument in a ParmVarDecl.
Instead, this adds a proper enum s
Author: jyknight
Date: Tue Dec 29 20:27:28 2015
New Revision: 256608
URL: http://llvm.org/viewvc/llvm-project?rev=256608&view=rev
Log:
[TrailingObjects] Convert CastExpr and subclasses.
Modified:
cfe/trunk/include/clang/AST/Expr.h
cfe/trunk/include/clang/AST/ExprCXX.h
cfe/trunk/includ
Author: rsmith
Date: Tue Dec 29 19:06:52 2015
New Revision: 256607
URL: http://llvm.org/viewvc/llvm-project?rev=256607&view=rev
Log:
Clean up this code, NFC.
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
Modified: cfe/trunk/lib/Sema/SemaChecking.cpp
URL:
http://llvm.org/viewvc/llvm-project/
Author: ericwf
Date: Tue Dec 29 19:02:38 2015
New Revision: 256606
URL: http://llvm.org/viewvc/llvm-project?rev=256606&view=rev
Log:
Cleanup CMake for out-of-tree builds
Modified:
libcxx/trunk/CMakeLists.txt
libcxx/trunk/cmake/Modules/HandleOutOfTreeLLVM.cmake
Modified: libcxx/trunk/CMak
Hello everyone,
Below are some buildbot numbers for the last week of 12/20/2015 -
12/26/2015.
Thanks
Galina
Number of commits by project:
project | commits
---+---
llvm | 150
cfe |
Author: dcoughlin
Date: Tue Dec 29 18:08:59 2015
New Revision: 256605
URL: http://llvm.org/viewvc/llvm-project?rev=256605&view=rev
Log:
[analyzer] Handle another Android assert function.
Android's assert can call both the __assert and __assert2 functions under the
cover, but
the NoReturnFunction
EricWF added a comment.
This is NOT correct and it's breaking bots. I don't want to revert it because
I really like the change but it needs to be fixed quickly.
@bcraig You removed the logic that tests if a system provides a given locale.
We use this information to enable/disable tests. Please
Author: dcoughlin
Date: Tue Dec 29 17:44:19 2015
New Revision: 256603
URL: http://llvm.org/viewvc/llvm-project?rev=256603&view=rev
Log:
[analyzer] Suppress nullability warning for _Nonnull locals zero-initialized by
ObjC ARC.
Prevent the analyzer from warning when a _Nonnnull local variable is i
Author: rsmith
Date: Tue Dec 29 17:42:34 2015
New Revision: 256602
URL: http://llvm.org/viewvc/llvm-project?rev=256602&view=rev
Log:
When a namespace alias redeclares a using declaration, point the diagnostic at
the using declaration not at the thing it's using.
Modified:
cfe/trunk/lib/Sema/S
Author: rsmith
Date: Tue Dec 29 17:34:32 2015
New Revision: 256601
URL: http://llvm.org/viewvc/llvm-project?rev=256601&view=rev
Log:
Model NamespaceAliasDecls as having their nominated namespace as an underlying
declaration. This fixes an issue where we would reject (due to a claimed
ambiguity) a
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: test/SemaCXX/warn-literal-conversion.cpp:49-50
@@ +48,4 @@
+ // values.
+ bool b3 = 0.0f;
+ bool b4 = 0.0;
+}
What about
bool b5 = 1.0;
bool b6 = 2.0;
? Arguably a
On Tue, Dec 29, 2015 at 6:28 PM, Richard Smith
wrote:
> On Tue, Dec 29, 2015 at 3:23 PM, Nico Weber wrote:
>
>> On Tue, Dec 29, 2015 at 6:16 PM, Richard Smith via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> On Tue, Dec 29, 2015 at 3:06 PM, Nico Weber via cfe-commits <
>>> cfe-comm
Author: nico
Date: Tue Dec 29 17:30:42 2015
New Revision: 256600
URL: http://llvm.org/viewvc/llvm-project?rev=256600&view=rev
Log:
Address review comment on r256595
Modified:
cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td
URL
On Tue, Dec 29, 2015 at 3:23 PM, Nico Weber wrote:
> On Tue, Dec 29, 2015 at 6:16 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Tue, Dec 29, 2015 at 3:06 PM, Nico Weber via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: nico
>>> Date: Tue Dec
Author: nico
Date: Tue Dec 29 17:23:38 2015
New Revision: 256599
URL: http://llvm.org/viewvc/llvm-project?rev=256599&view=rev
Log:
Fix test from r256596
Modified:
cfe/trunk/test/Lexer/msdos-cpm-eof.c
Modified: cfe/trunk/test/Lexer/msdos-cpm-eof.c
URL:
http://llvm.org/viewvc/llvm-project/cfe
On Tue, Dec 29, 2015 at 6:16 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Dec 29, 2015 at 3:06 PM, Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: nico
>> Date: Tue Dec 29 17:06:17 2015
>> New Revision: 256595
>>
>> URL: http://llv
Author: ericwf
Date: Tue Dec 29 17:19:00 2015
New Revision: 256598
URL: http://llvm.org/viewvc/llvm-project?rev=256598&view=rev
Log:
Fix test failure in 32 bit mode
Modified:
libcxx/trunk/test/libcxx/experimental/any/small_type.pass.cpp
Modified: libcxx/trunk/test/libcxx/experimental/any/sma
Author: ericwf
Date: Tue Dec 29 17:18:27 2015
New Revision: 256597
URL: http://llvm.org/viewvc/llvm-project?rev=256597&view=rev
Log:
Mark LWG defect #2367 as complete
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/llvm-p
Author: nico
Date: Tue Dec 29 17:17:27 2015
New Revision: 256596
URL: http://llvm.org/viewvc/llvm-project?rev=256596&view=rev
Log:
Emit a -Wmicrosoft warning when treating ^Z as EOF in MS mode.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticGroups.td
cfe/trunk/include/clang/Basic/Diagn
On Tue, Dec 29, 2015 at 3:06 PM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nico
> Date: Tue Dec 29 17:06:17 2015
> New Revision: 256595
>
> URL: http://llvm.org/viewvc/llvm-project?rev=256595&view=rev
> Log:
> Emit a -Wmicrosoft warning when pasting /##/ into a comm
Author: nico
Date: Tue Dec 29 17:06:17 2015
New Revision: 256595
URL: http://llvm.org/viewvc/llvm-project?rev=256595&view=rev
Log:
Emit a -Wmicrosoft warning when pasting /##/ into a comment token in MS mode.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticGroups.td
cfe/trunk/include/cl
Author: bcraig
Date: Tue Dec 29 17:01:07 2015
New Revision: 256594
URL: http://llvm.org/viewvc/llvm-project?rev=256594&view=rev
Log:
[libcxx] Fixing the Mac / Darwin build
Modified:
libcxx/trunk/test/libcxx/test/target_info.py
Modified: libcxx/trunk/test/libcxx/test/target_info.py
URL:
http
Author: bcraig
Date: Tue Dec 29 16:55:55 2015
New Revision: 256592
URL: http://llvm.org/viewvc/llvm-project?rev=256592&view=rev
Log:
[libcxx] Fixing silly mistake from last commit.
Tested on Linux x86_64 targeting Linux x86_64.
Modified:
libcxx/trunk/test/libcxx/test/target_info.py
Modified
Author: bcraig
Date: Tue Dec 29 16:43:17 2015
New Revision: 256591
URL: http://llvm.org/viewvc/llvm-project?rev=256591&view=rev
Log:
[libcxx] Fixing the Linux sanitizer builds
Modified:
libcxx/trunk/test/libcxx/test/target_info.py
Modified: libcxx/trunk/test/libcxx/test/target_info.py
URL:
Author: jyknight
Date: Tue Dec 29 16:31:18 2015
New Revision: 256590
URL: http://llvm.org/viewvc/llvm-project?rev=256590&view=rev
Log:
[TrailingObjects] Convert OffsetOfExpr.
That necessitated moving the OffsetOfNode class out of OffsetOfExpr.
Modified:
cfe/trunk/include/clang/AST/Expr.h
bcraig closed this revision.
bcraig added a comment.
Committed as r256588.
Thanks for the quick review!
http://reviews.llvm.org/D15813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: majnemer
Date: Tue Dec 29 16:25:14 2015
New Revision: 256589
URL: http://llvm.org/viewvc/llvm-project?rev=256589&view=rev
Log:
[MS ABI] Invent a mangling for reference temporaries
MSVC is non-conforming and doesn't have a mangling for these. Invent
our own to unblock folks using clang.
Author: bcraig
Date: Tue Dec 29 16:21:38 2015
New Revision: 256588
URL: http://llvm.org/viewvc/llvm-project?rev=256588&view=rev
Log:
[libcxx] Refactoring target_info.py
This patch makes it easier to support running the lit tests for new and
unusual platforms. It will break existing users that set
LegalizeAdulthood updated this revision to Diff 43761.
LegalizeAdulthood added a comment.
Regenerate documentation from dump_ast_matchers.py
http://reviews.llvm.org/D8149
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
Author: rsmith
Date: Tue Dec 29 16:19:20 2015
New Revision: 256587
URL: http://llvm.org/viewvc/llvm-project?rev=256587&view=rev
Log:
Use consistent types for all bit-field members in the same bit-field so that
MSVC's bit-field packing algorithm packs them properly.
Modified:
cfe/trunk/includ
Author: jyknight
Date: Tue Dec 29 16:13:13 2015
New Revision: 256585
URL: http://llvm.org/viewvc/llvm-project?rev=256585&view=rev
Log:
[TrailingObjects] Convert Decl* classes.
Also remove now-redundant explicit alignment specification on some of
the classes converted prior to TrailingObjects auto
Author: majnemer
Date: Tue Dec 29 16:02:15 2015
New Revision: 256583
URL: http://llvm.org/viewvc/llvm-project?rev=256583&view=rev
Log:
[MS ABI] Add a mangling for _Complex
MSVC doesn't implement a mangling for C99's _Complex so we must invent
our own.
For now, treating it like a class type calle
Author: majnemer
Date: Tue Dec 29 16:02:10 2015
New Revision: 256582
URL: http://llvm.org/viewvc/llvm-project?rev=256582&view=rev
Log:
[MS ABI] Mark an unreachable path appropriately
No functional change is intended, just a small cleanup.
Modified:
cfe/trunk/lib/AST/MicrosoftMangle.cpp
Modi
aaron.ballman added a comment.
In http://reviews.llvm.org/D15814#317879, @Eugene.Zelenko wrote:
> This seems to me as specific case of Clang-tidy
> readability-implicit-bool-cast. May be this check should be entirely moved to
> Clang?
I think the reason why that is in clang-tidy is because it
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
This seems to me as specific case of Clang-tidy readability-implicit-bool-cast.
May be this check should be entirely moved to Clang?
http://reviews.llvm.org/D15814
_
jroelofs added a comment.
> This patch makes it easier to support running the lit tests for new and
> unusual platforms. It will break existing users that set LIBCXX_TARGET_INFO
> to anything other than the default. I think this is fine, because the old
> LIBCXX_TARGET_INFO wasn't terribly usef
jroelofs added a comment.
This is awesome!
LGTM with one nit: add a newline between each function definition, and two
between each class. It's a little crowded without that.
http://reviews.llvm.org/D15813
___
cfe-commits mailing list
cfe-commits@l
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, rtrieu, dblaikie.
aaron.ballman added a subscriber: cfe-commits.
When performing an implicit from float to bool, the floating point value must
be *exactly* zero in order for the conversion to result in 0. This does not
i
bcraig created this revision.
bcraig added reviewers: mclow.lists, jroelofs, danalbert, EricWF.
bcraig added a subscriber: cfe-commits.
Herald added a subscriber: emaste.
This patch makes it easier to support running the lit tests for new and
unusual platforms. It will break existing users that s
aaron.ballman added inline comments.
Comment at: include/clang/AST/DeclBase.h:563
@@ +562,3 @@
+ /// \brief Return true if this declaration is a definition of alias or ifunc.
+ bool hasDefiningAttr() const;
+
rjmccall wrote:
> aaron.ballman wrote:
> > I think th
rjmccall added inline comments.
Comment at: include/clang/AST/DeclBase.h:563
@@ +562,3 @@
+ /// \brief Return true if this declaration is a definition of alias or ifunc.
+ bool hasDefiningAttr() const;
+
aaron.ballman wrote:
> I think this function and getDefini
Author: spatel
Date: Tue Dec 29 14:09:37 2015
New Revision: 256576
URL: http://llvm.org/viewvc/llvm-project?rev=256576&view=rev
Log:
fix typos; NFC
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
URL:
http://llvm.org/vi
aaron.ballman added inline comments.
Comment at: include/clang/AST/DeclBase.h:563
@@ +562,3 @@
+ /// \brief Return true if this declaration is a definition of alias or ifunc.
+ bool hasDefiningAttr() const;
+
I think this function and getDefiningAttr() can be de
Author: rsmith
Date: Tue Dec 29 13:43:10 2015
New Revision: 256575
URL: http://llvm.org/viewvc/llvm-project?rev=256575&view=rev
Log:
Teach typo correction to properly handle mapping declarations to their
underlying decls. Preserve the found declaration throughout, and only map to
the underlying de
rjmccall added a comment.
This looks great, thanks. A few minor comment tweaks and this will be ready to
commit.
Comment at: include/clang/AST/DeclBase.h:562
@@ -561,1 +561,3 @@
+ /// \brief Return true if this declaration is a definition of alias or ifunc.
+ bool hasDefin
mattsta updated this revision to Diff 43748.
mattsta added a comment.
Updated to include fix for:
Assertion failed: (InitialLoc.isValid()), function checkStmt, file
../llvm/tools/clang/tools/extra/clang-tidy/readability/BracesAroundStatementsCheck.cpp,
line 226.
Repository:
rL LLVM
http:
mattsta added a comment.
It's difficult to track down *why* the invalid locations are happening because
by the time we get to an invalid location, all source location information is
lost. The best I've been able to come up with is fixing the early return
conditions (which were previously impos
fraggamuffin updated this revision to Diff 43746.
fraggamuffin marked 3 inline comments as done.
fraggamuffin added a comment.
Fixed Comments from Dec 17.
http://reviews.llvm.org/D15321
Files:
include/clang/AST/DeclBase.h
include/clang/AST/DeclOpenMP.h
include/clang/AST/RecursiveASTVisito
Author: jyknight
Date: Tue Dec 29 12:15:14 2015
New Revision: 256570
URL: http://llvm.org/viewvc/llvm-project?rev=256570&view=rev
Log:
[TrailingObjects] Convert AST classes that had a ASTTemplateKWAndArgsInfo.
So, also:
- Moved the TemplateArgumentLoc array out of the
ASTTemplateKWAndArgsInfo
fraggamuffin marked 15 inline comments as done.
fraggamuffin added a comment.
Thanks for the pre-xmas review.
Comment at: include/clang/AST/DeclOpenMP.h:98
@@ +97,3 @@
+///
+class OMPDeclareTargetDecl : public Decl, public DeclContext {
+ friend class ASTDeclReader;
--
flx updated this revision to Diff 43743.
flx marked 2 inline comments as done.
http://reviews.llvm.org/D15623
Files:
clang-tidy/CMakeLists.txt
clang-tidy/Makefile
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/PerformanceTidyModule.cpp
clang-tidy/performance/UnnecessaryCop
andrew added a comment.
Can someone commit with the FIXME comment? I'm unable to do it myself.
Repository:
rL LLVM
http://reviews.llvm.org/D15791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Author: dcoughlin
Date: Tue Dec 29 11:40:49 2015
New Revision: 256567
URL: http://llvm.org/viewvc/llvm-project?rev=256567&view=rev
Log:
[analyzer] Nullability: allow cast to _Nonnull to suppress warning about
returning nil.
The nullability checker currently allows casts to suppress warnings when
aaron.ballman added a comment.
Fine by me -- I went with CERT since it's an acronym, but we don't do this for
LLVM, so this change makes sense. Thanks!
In http://reviews.llvm.org/D15805#317736, @alexfh wrote:
> In http://reviews.llvm.org/D15805#317657, @aaron.ballman wrote:
>
> > Fine by me --
alexfh added a comment.
In http://reviews.llvm.org/D15805#317657, @aaron.ballman wrote:
> Fine by me -- I went with CERT since it's an acronym, but we don't do this
> for LLVM, so this change makes sense. Thanks!
AFAIU, LLVM is not an acronym anymore ;) (but still an upper-case spelling is
th
On Tue, Dec 29, 2015 at 5:22 PM, Benjamin Kramer
wrote:
> On Tue, Dec 29, 2015 at 5:14 PM, Alexander Kornienko via cfe-commits
> wrote:
> > Author: alexfh
> > Date: Tue Dec 29 10:14:38 2015
> > New Revision: 256562
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=256562&view=rev
> > Log:
> >
alexfh added inline comments.
Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:5
@@ +4,2 @@
+.. meta::
+ :http-equiv=refresh: 0;URL=misc-new-delete-overloads.html
aaron.ballman wrote:
> alexfh wrote:
> > alexfh wrote:
> > > aaron.ballman wrote:
> > > > alex
Author: jyknight
Date: Tue Dec 29 10:44:11 2015
New Revision: 256564
URL: http://llvm.org/viewvc/llvm-project?rev=256564&view=rev
Log:
[TrailingObjects] Use a different technique to determine if a getDecl
member function exists on a class.
The previous trick depended on inheriting from the class
aaron.ballman added inline comments.
Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:5
@@ +4,2 @@
+.. meta::
+ :http-equiv=refresh: 0;URL=misc-new-delete-overloads.html
alexfh wrote:
> alexfh wrote:
> > aaron.ballman wrote:
> > > alexfh wrote:
> > > > Sinc
On Tue, Dec 29, 2015 at 5:14 PM, Alexander Kornienko via cfe-commits
wrote:
> Author: alexfh
> Date: Tue Dec 29 10:14:38 2015
> New Revision: 256562
>
> URL: http://llvm.org/viewvc/llvm-project?rev=256562&view=rev
> Log:
> [clang-tidy] Fix a use-after-free bug found by asan
>
> Modified:
>
>
Author: alexfh
Date: Tue Dec 29 10:14:38 2015
New Revision: 256562
URL: http://llvm.org/viewvc/llvm-project?rev=256562&view=rev
Log:
[clang-tidy] Fix a use-after-free bug found by asan
Modified:
clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp
Modified:
clang-tool
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:23
@@ +22,3 @@
+bool inHeaderFile(const SourceManager *SM, SourceLocation Location) {
+ StringRef Filename = SM->getFilename(SM->getExpansionLoc(Location));
+ return Filename.endswith(
alexfh added inline comments.
Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:5
@@ +4,2 @@
+.. meta::
+ :http-equiv=refresh: 0;URL=misc-new-delete-overloads.html
alexfh wrote:
> aaron.ballman wrote:
> > alexfh wrote:
> > > Since this is not a deprecated/ob
alexfh added inline comments.
Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:5
@@ +4,2 @@
+.. meta::
+ :http-equiv=refresh: 0;URL=misc-new-delete-overloads.html
aaron.ballman wrote:
> alexfh wrote:
> > Since this is not a deprecated/obsolete file, it migh
alexfh added inline comments.
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:23
@@ +22,3 @@
+bool inHeaderFile(const SourceManager *SM, SourceLocation Location) {
+ StringRef Filename = SM->getFilename(SM->getExpansionLoc(Location));
+ return Filename.endswith(".h") |
aaron.ballman added inline comments.
Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:5
@@ +4,2 @@
+.. meta::
+ :http-equiv=refresh: 0;URL=misc-new-delete-overloads.html
alexfh wrote:
> Since this is not a deprecated/obsolete file, it might be a good idea t
alexfh added inline comments.
Comment at: docs/clang-tidy/checks/cert-dcl54-cpp.rst:5
@@ +4,2 @@
+.. meta::
+ :http-equiv=refresh: 0;URL=misc-new-delete-overloads.html
Since this is not a deprecated/obsolete file, it might be a good idea to also
add a textual r
davide accepted this revision.
davide added a reviewer: davide.
davide added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Driver/Tools.cpp:941
@@ -940,3 +940,3 @@
- // The kext linker doesn't know how to deal with movw/movt.
- if (KernelOr
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:23
@@ +22,3 @@
+bool inHeaderFile(const SourceManager *SM, SourceLocation Location) {
+ StringRef Filename = SM->getFilename(SM->getExpansionLoc(Location));
+ return Filename.endswith(
omtcyf0 added a comment.
@alexfh, Thanks for the feedback!
What you said seems reasonable to me, I'll follow your advice and come up with
the proposed solution!
http://reviews.llvm.org/D15685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Fine by me -- I went with CERT since it's an acronym, but we don't do this for
LLVM, so this change makes sense. Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D15805
davide added a comment.
In http://reviews.llvm.org/D15791#317172, @dim wrote:
> @davide, any idea whether lld will be able to handle movt correctly? If so,
> we might want to make this dependent on `-fuse-ld=bfd` or `-fuse-ld=lld` ?
lld/AArch64 can't still handle that properly, so I'd rather
Author: alexfh
Date: Tue Dec 29 07:28:10 2015
New Revision: 256559
URL: http://llvm.org/viewvc/llvm-project?rev=256559&view=rev
Log:
[clang-tidy] Fix capitalization of the message in the example
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
Modified: clang-tools-extra/trunk/doc
alexfh added a comment.
In http://reviews.llvm.org/D15805#317629, @hokein wrote:
> I'm wondering whether should we rename `CERT` to `cert` to keep the same
> with other modules like misc and google.
SGTM. Aaron, do you see any reasons not to do this?
Repository:
rL LLVM
http://reviews.ll
alexfh added a comment.
Thank you for working on this!
A few minor comments.
Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:21
@@ +20,3 @@
+namespace {
+AST_MATCHER(VarDecl, isLocalVarDecl) { return Node.isLocalVarDecl(); }
+AST_MATCHER(QualType, isPointer
hokein added a comment.
I'm wondering whether should we rename `CERT` to `cert` to keep the same with
other modules like misc and google.
For adding a new check in CERT module, you need to use the upper name
explicitly via `python add_new_check.py CERT foo` rather than `python
add_new_check.py
alexfh added inline comments.
Comment at: clang-tidy/google/DefinitionsInHeadersCheck.cpp:52
@@ +51,3 @@
+// Inline function is allowed.
+if (funDecl->isInlined())
+ return;
hokein wrote:
> alexfh wrote:
> > This check can be done in the matcher.
> Th
Author: majnemer
Date: Tue Dec 29 05:45:58 2015
New Revision: 256556
URL: http://llvm.org/viewvc/llvm-project?rev=256556&view=rev
Log:
[MS ABI] Cleanup our mangling of vector types
We used to produce a type which demangled to:
union __clang_vec8_F
That 'F' is the mangling for 'short' but it is p
Author: majnemer
Date: Tue Dec 29 05:46:00 2015
New Revision: 256557
URL: http://llvm.org/viewvc/llvm-project?rev=256557&view=rev
Log:
[MS ABI] Implement a mangling for _Atomic types
MSVC doesn't implement a mangling for C11's _Atomic so we must invent
our own.
For now, treating it like a class
Author: majnemer
Date: Tue Dec 29 05:45:53 2015
New Revision: 256555
URL: http://llvm.org/viewvc/llvm-project?rev=256555&view=rev
Log:
[MS ABI] Cleanup the mangling of artifical types
Hand-rolling the mangling results in us not correctly adding names to
the backreference map.
Modified:
cfe/t
Nice! Didn't know about this feature.
On Mon, Dec 28, 2015 at 8:59 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: aaronballman
> Date: Mon Dec 28 13:59:15 2015
> New Revision: 256517
>
> URL: http://llvm.org/viewvc/llvm-project?rev=256517&view=rev
> Log:
> Orphan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256554: [clang-tidy] Don't generate duplicated blank line in
add_new_check.py script. (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D15803?vs=43717&id=43728#toc
Repository:
r
Author: alexfh
Date: Tue Dec 29 05:05:35 2015
New Revision: 256554
URL: http://llvm.org/viewvc/llvm-project?rev=256554&view=rev
Log:
[clang-tidy] Don't generate duplicated blank line in add_new_check.py script.
Reviewers: alexfh
Subscribers: cfe-commits
Patch by Haojian Wu!
Differential Revisi
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. I'll submit the patch for you.
Repository:
rL LLVM
http://reviews.llvm.org/D15803
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ABataev updated this revision to Diff 43727.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D15709
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
1 - 100 of 109 matches
Mail list logo
