rsmith added a comment.
+rjmccall for `@encode` and USR mangling.
Comment at: include/clang-c/Index.h:2879-2885
@@ -2878,8 +2878,9 @@
CXType_LongDouble = 23,
- CXType_NullPtr = 24,
- CXType_Overload = 25,
- CXType_Dependent = 26,
- CXType_ObjCId = 27,
- CXType_ObjCClass
RedX2501 added a comment.
Ping
http://reviews.llvm.org/D10834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
RedX2501 added a comment.
Ping
http://reviews.llvm.org/D10833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
John,
Your example won't be compiled at all. Clang and MSVC emit error
messages in this case.
The next code
struct A {
__declspec(property(get=GetX,put=SetX)) int x;
int GetX() const { return 0; }
void SetX(long y) {}
};
a.x = 5;
compiled fine by MSVC and clang and provides c
nemanjai added a comment.
Just a friendly reminder to the reviewers that this patch has been up for
almost a week with no review comments. Please take some time to review.
Repository:
rL LLVM
http://reviews.llvm.org/D15120
___
cfe-commits mailin
rjmccall added inline comments.
Comment at: lib/Sema/SemaPseudoObject.cpp:464
@@ -461,1 +463,3 @@
+ if (useSetterResultAsExprResult(result.get()))
+setResultToLastSemantic();
Sure, but that's not what I'm saying. I'm saying that the code, as you've
writte
ABataev updated this revision to Diff 42026.
ABataev marked 2 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D15174
Files:
lib/Sema/SemaPseudoObject.cpp
test/CodeGenCXX/ms-property.cpp
test/SemaCXX/ms-property-error.cpp
test/SemaCXX/ms-prop
ABataev added a comment.
Tests?
Repository:
rL LLVM
http://reviews.llvm.org/D15220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev marked 2 inline comments as done.
Comment at: lib/Sema/SemaPseudoObject.cpp:232
@@ -231,3 +231,3 @@
/// Return true if assignments have a non-void result.
-bool CanCaptureValue(Expr *exp) {
+bool CanCaptureValue(Expr *exp) const {
if (exp->isGLValue())
Author: faisalv
Date: Sun Dec 6 20:37:44 2015
New Revision: 254889
URL: http://llvm.org/viewvc/llvm-project?rev=254889&view=rev
Log:
Fix PR20334: invalid assertion while diagnosing list initialization failure
https://llvm.org/bugs/show_bug.cgi?id=20334
Unfortunately, clang currently checks for
majnemer added a comment.
This LGTM but @mclow.lists or @EricWF should give the final say-so.
http://reviews.llvm.org/D14814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sberg created this revision.
sberg added a reviewer: cfe-commits.
...as that is apparently what MSVC does
http://reviews.llvm.org/D15267
Files:
include/clang/AST/ASTConsumer.h
include/clang/Frontend/MultiplexConsumer.h
include/clang/Sema/Sema.h
lib/CodeGen/CodeGenAction.cpp
lib/CodeGen
jeanphilippeD added a comment.
Thanks a lot, I do not have commit access.
I'm happy for you to commit it when you have time.
http://reviews.llvm.org/D15062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
jeanphilippeD created this revision.
jeanphilippeD added a reviewer: djasper.
jeanphilippeD added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
clang-format break multi-line streams after std::endl.
It now also break for '\n', the suggested replacement for std::endl:
http://llvm.o
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D15062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
jeanphilippeD added a comment.
Hi Daniel,
Realized that I should have added you when I submitted it.
Not sure if this review slipped through, or you were too busy, or if this
change is not desired since the code was added to support JS.
Kind Regards,
Jean-Philippe.
http://reviews.llvm.org/D1506
Author: sepavloff
Date: Sun Dec 6 08:32:39 2015
New Revision: 254876
URL: http://llvm.org/viewvc/llvm-project?rev=254876&view=rev
Log:
[PGO] Instrument only base constructors and destructors.
Constructors and destructors may be represented by several functions
in IR. Only base structors correspo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254876: [PGO] Instrument only base constructors and
destructors. (authored by sepavloff).
Changed prior to commit:
http://reviews.llvm.org/D15158?vs=41744&id=42011#toc
Repository:
rL LLVM
http://rev
18 matches
Mail list logo
