Thanks!
Devin
> On Dec 3, 2015, at 9:27 PM, Craig Topper via cfe-commits
> wrote:
>
> Author: ctopper
> Date: Thu Dec 3 23:27:29 2015
> New Revision: 254704
>
> URL: http://llvm.org/viewvc/llvm-project?rev=254704&view=rev
> Log:
> Fix an unused variable warning in released builds. While there
Author: ctopper
Date: Thu Dec 3 23:27:29 2015
New Revision: 254704
URL: http://llvm.org/viewvc/llvm-project?rev=254704&view=rev
Log:
Fix an unused variable warning in released builds. While there use 'auto' to
simplify code.
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitiv
Author: ctopper
Date: Thu Dec 3 23:01:44 2015
New Revision: 254703
URL: http://llvm.org/viewvc/llvm-project?rev=254703&view=rev
Log:
[AST] ArrayRef-ize CompoundStmt::setStmts.
Modified:
cfe/trunk/include/clang/AST/Stmt.h
cfe/trunk/lib/AST/Stmt.cpp
cfe/trunk/lib/Serialization/ASTReade
Author: dcoughlin
Date: Thu Dec 3 23:00:36 2015
New Revision: 254702
URL: http://llvm.org/viewvc/llvm-project?rev=254702&view=rev
Log:
[analyzer] Support inlining lambda-converted blocks.
clang converts C++ lambdas to blocks with an implicit user-defined conversion
operator method on the lambda
Author: rsmith
Date: Thu Dec 3 21:00:44 2015
New Revision: 254699
URL: http://llvm.org/viewvc/llvm-project?rev=254699&view=rev
Log:
Don't assert if evaluation of an expression that we're syntactically required
to treat as an ICE results in undefined behavior. Instead, return the "natural"
result
Author: compnerd
Date: Thu Dec 3 20:15:02 2015
New Revision: 254692
URL: http://llvm.org/viewvc/llvm-project?rev=254692&view=rev
Log:
.gitignore: ignore vim swap files
Modified:
libcxxabi/trunk/.gitignore
Modified: libcxxabi/trunk/.gitignore
URL:
http://llvm.org/viewvc/llvm-project/libcxxa
Author: compnerd
Date: Thu Dec 3 20:14:58 2015
New Revision: 254691
URL: http://llvm.org/viewvc/llvm-project?rev=254691&view=rev
Log:
ibc++abi: mark visibility
Mark functions and types with the appropriate visibility. This is particularly
useful for environments which explicitly indicate origin
Author: compnerd
Date: Thu Dec 3 20:14:41 2015
New Revision: 254690
URL: http://llvm.org/viewvc/llvm-project?rev=254690&view=rev
Log:
c++abi: whitespace adjustment
Cleanup some code with clang-format to make the following change easier to
identify material difference. NFC.
Modified:
libcxx
joker.eph added a comment.
Talked with Duncan, we're not convinced about //-fthinlto-backend=...// for the
option name: the word //backend// does not seems right here. What about
//-fthinlto-index=...//?
Comment at: lib/CodeGen/CodeGenAction.cpp:822
@@ +821,3 @@
+ TheModu
rnk added a comment.
In http://reviews.llvm.org/D14180#300193, @martell wrote:
> @rnk you are correct.
> mingw-w64 has been updated accordingly
>
> http://sourceforge.net/p/mingw-w64/mingw-w64/ci/61c374ded91a7de66f42f85a9f0cf9ee20/
>
> So where do we go from here ?
Let's disable the _Interlo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254682: LLDB JIT needs android vector passing rules.
(authored by srhines).
Changed prior to commit:
http://reviews.llvm.org/D14639?vs=41654&id=41837#toc
Repository:
rL LLVM
http://reviews.llvm.org/
Author: srhines
Date: Thu Dec 3 19:39:30 2015
New Revision: 254682
URL: http://llvm.org/viewvc/llvm-project?rev=254682&view=rev
Log:
LLDB JIT needs android vector passing rules.
Summary:
Looking into some recent issues with LLDBs expression parser highlighted that
upstream clang passes vectors
danalbert added inline comments.
Comment at: docs/UndefinedBehaviorSanitizer.rst:128
@@ +127,3 @@
+ ``-fsanitize=undefined``.
+ - ``-fsanitize=integer``: Checks for undefined or suspicious integer
+ behavior.
rsmith wrote:
> danalbert wrote:
> > Suspicio
silvas accepted this revision.
silvas added a comment.
Thanks for working on this!
A tiny nit, but otherwise this LGTM.
Comment at: docs/UndefinedBehaviorSanitizer.rst:33
@@ +32,3 @@
+
+Use ``clang++`` to compile and link your program with ``-fsanitize=undefined``
+flag. Make s
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: docs/UndefinedBehaviorSanitizer.rst:128
@@ +127,3 @@
+ ``-fsanitize=undefined``.
+ - ``-fsanitize=integer``: Checks for undefined or suspicious integer
+ behavior.
---
Author: samsonov
Date: Thu Dec 3 18:38:13 2015
New Revision: 254672
URL: http://llvm.org/viewvc/llvm-project?rev=254672&view=rev
Log:
[Docs] Sanitizer docs migrated from code.google.com to github.com.
Modified:
cfe/trunk/docs/AddressSanitizer.rst
cfe/trunk/docs/LeakSanitizer.rst
cfe/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254670: [PowerPC] Fix calculating address of arguments on
stack for variadic func (authored by petarj).
Changed prior to commit:
http://reviews.llvm.org/D14871?vs=41613&id=41826#toc
Repository:
rL LL
Author: petarj
Date: Thu Dec 3 18:26:47 2015
New Revision: 254670
URL: http://llvm.org/viewvc/llvm-project?rev=254670&view=rev
Log:
[PowerPC] Fix calculating address of arguments on stack for variadic func
Fix calculating address of arguments larger than 32 bit on stack for
variadic functions (r
danalbert added inline comments.
Comment at: docs/UndefinedBehaviorSanitizer.rst:128
@@ +127,3 @@
+ ``-fsanitize=undefined``.
+ - ``-fsanitize=integer``: Checks for undefined or suspicious integer
+ behavior.
Suspicious here meaning that it also checks u
samsonov added a comment.
I agree with Richard here.
Repository:
rL LLVM
http://reviews.llvm.org/D15208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
I would expect that people who are using this for hardening would be upset
about a 5% binary size increase. I'm OK with having this behind a flag, though.
Repository:
rL LLVM
http://reviews.llvm.org/D15208
___
cfe-commits
Author: rsmith
Date: Thu Dec 3 17:24:04 2015
New Revision: 254663
URL: http://llvm.org/viewvc/llvm-project?rev=254663&view=rev
Log:
PR25731: namespace alias declarations can appear at block scope; ensure that we
do scope-based lookup when looking for redeclarations of them. Add some related
missi
Author: gbiv
Date: Thu Dec 3 15:15:22 2015
New Revision: 254650
URL: http://llvm.org/viewvc/llvm-project?rev=254650&view=rev
Log:
Fix pass_object_size test on Windows.
The tests were failing because the types of some member functions, when
printed, unexpectedly had "__attribute__((thiscall))" at
Author: gbiv
Date: Thu Dec 3 14:54:58 2015
New Revision: 254646
URL: http://llvm.org/viewvc/llvm-project?rev=254646&view=rev
Log:
Add tests for `&enable_if_function` diagnostics.
The introduction of pass_object_size fixed a few bugs related to taking
the address of a function with enable_if attr
joker.eph added a comment.
Looks good to me but I'd like another opinion on the name of
"-fthinlto-backend", Duncan?
Comment at: include/clang/Driver/Types.h:68
@@ -66,1 +67,3 @@
+ bool isLLVMIR(ID Id);
+
/// isCuda - Is this a CUDA input.
I guess you could
tejohnson updated this revision to Diff 41787.
tejohnson added a comment.
- Address more comments.
http://reviews.llvm.org/D15025
Files:
include/clang/CodeGen/BackendUtil.h
include/clang/Driver/Options.td
include/clang/Driver/Types.h
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen
tejohnson marked 4 inline comments as done.
tejohnson added a comment.
New patch coming I think addresses all your comments.
Thanks, Teresa
Comment at: lib/CodeGen/BackendUtil.cpp:290
@@ +289,3 @@
+ // setup for LTO compiles invoked via the gold plugin and the llvm-lto tool.
+
Author: cbieneman
Date: Thu Dec 3 13:47:25 2015
New Revision: 254642
URL: http://llvm.org/viewvc/llvm-project?rev=254642&view=rev
Log:
[CMake] Removing an unnecessary layer of variable indirection
This prevents passthrough variables from having values.
Modified:
cfe/trunk/runtime/CMakeLists
Author: dcoughlin
Date: Thu Dec 3 13:41:24 2015
New Revision: 254639
URL: http://llvm.org/viewvc/llvm-project?rev=254639&view=rev
Log:
[analyzer] Suppress stack address escape on CK_CopyAndAutoreleaseBlockObject.
Don't warn about addresses of stack-allocated blocks escaping if the block
region w
test case?
On Thu, Dec 3, 2015 at 11:20 AM, John Thompson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jtsoftware
> Date: Thu Dec 3 13:20:43 2015
> New Revision: 254635
>
> URL: http://llvm.org/viewvc/llvm-project?rev=254635&view=rev
> Log:
> Fixed header determination logic. W
Author: jtsoftware
Date: Thu Dec 3 13:20:43 2015
New Revision: 254635
URL: http://llvm.org/viewvc/llvm-project?rev=254635&view=rev
Log:
Fixed header determination logic. Was missing extensionless headers in coverage
check.
Modified:
clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp
Author: gbiv
Date: Thu Dec 3 13:19:09 2015
New Revision: 254632
URL: http://llvm.org/viewvc/llvm-project?rev=254632&view=rev
Log:
Add tests for pass_object_size.
These additions were meant to go in as a part of r254554; while it's
certainly nice to have new functionality, it's nicer if we have t
jyknight added a comment.
What's the status of this? It's showing bright red on my review dashboard, and
I'd like to clear it off. :) Am I expected to do anything else here, or is it
just waiting to be merged for the next release now (or, is it not going to be
after all)?
Users:
jyknight (A
Author: cbieneman
Date: Thu Dec 3 12:52:54 2015
New Revision: 254628
URL: http://llvm.org/viewvc/llvm-project?rev=254628&view=rev
Log:
[CMake] If you're not installing the libcxx library, exclude it from the "all"
target so it doesn't get built when you run "ninja install"
This is just a build
majnemer updated this revision to Diff 41781.
majnemer added a comment.
- Updated for LLVM changes
http://reviews.llvm.org/D15140
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGCleanup.h
lib/CodeGen/CGException.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/EHS
mcrosier created this revision.
mcrosier added reviewers: majnemer, doug.gregor, ddunbar, chandlerc,
bob.wilson, rnk, krememek.
mcrosier added a subscriber: cfe-commits.
The changes adds support for -fno-builtin-foo options.
This addresses PR4941 and rdar://6756912.
Please take a look.
Chad
thakis added a subscriber: thakis.
Comment at: cfe/trunk/lib/Frontend/CompilerInvocation.cpp:401
@@ -411,1 +400,3 @@
+.Case("limited", CodeGenOptions::LimitedDebugInfo)
+.Case("standalone", CodeGenOptions::FullDebugInfo));
}
This lets cc
Author: nico
Date: Thu Dec 3 11:44:51 2015
New Revision: 254622
URL: http://llvm.org/viewvc/llvm-project?rev=254622&view=rev
Log:
Fix Objective-C metadata for properties from class extensions after r251874
After, properties from class extensions no longer show up in
ObjCInterfaceDecl::properties
rjmccall added a comment.
Hmm. I think a better approach would be for buildAssignmentOperation to do
this; but before we figure out how to do that, we should make sure of the
language semantics we're implementing. Are the semantics that the result of an
assignment is always the result of the
On Thu, Dec 3, 2015 at 8:08 AM, Marshall Clow via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> mclow.lists added a comment.
>
> I ran this on LLVM + clang, and it changed calls in 61 files. The changed
> LLVM codebase compiled successfully, and passed all the tests.
>
> Re: @dblaikie's comm
Author: chapuni
Date: Thu Dec 3 10:03:34 2015
New Revision: 254614
URL: http://llvm.org/viewvc/llvm-project?rev=254614&view=rev
Log:
Fix clang/test/Sema/struct-packed-align.c. "Windows" is not MS compiler.
Modified:
cfe/trunk/test/Sema/struct-packed-align.c
Modified: cfe/trunk/test/Sema/str
carlo.bertolli updated this revision to Diff 41712.
carlo.bertolli marked 15 inline comments as done.
carlo.bertolli added a comment.
Thanks very much for your kind comments and patience at some trivial errors on
my side.
This new version of the patch addresses all your concerns and it removes
carlo.bertolli added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:667
@@ -666,3 +666,3 @@
OpenMPScheduleClauseKind Kind;
- /// \brief Start location of the schedule ind in source code.
+ /// \brief Start location of the schedule kind in source code.
Source
mclow.lists added a comment.
I ran this on LLVM + clang, and it changed calls in 61 files. The changed LLVM
codebase compiled successfully, and passed all the tests.
Re: @dblaikie's comment, I'd rather call such a beast `llvm::swap`, and it
would have to go into a header file that everyone alr
Author: nico
Date: Thu Dec 3 09:40:23 2015
New Revision: 254612
URL: http://llvm.org/viewvc/llvm-project?rev=254612&view=rev
Log:
Make check-clang depend on LTO.
r249143 added test/Driver/darwin-ld-lto.c which requires libLTO.dylib
to pass, but when running `ninja check-clang` in a fresh build d
Alexander_Droste added a comment.
Hi,
I think the points mentioned should be all addressed now.
The only thing left is that some of the more generic functionality
maybe should be moved from MPI-Checker related files to others.
Therefor, I need some advice where to put these functions (if necess
DmitryPolukhin added inline comments.
Comment at: lib/AST/RecordLayoutBuilder.cpp:1606
@@ -1605,1 +1605,3 @@
+} else if (ExplicitFieldAlign)
+ FieldOffset = llvm::RoundUpToAlignment(FieldOffset, ExplicitFieldAlign);
rjmccall wrote:
> Be sure to test spe
DmitryPolukhin updated this revision to Diff 41748.
http://reviews.llvm.org/D14980
Files:
lib/AST/RecordLayoutBuilder.cpp
test/Sema/bitfield-layout.c
Index: test/Sema/bitfield-layout.c
===
--- test/Sema/bitfield-layout.c
+++ tes
On 12/ 3/15 03:42 PM, Manuel Klimek wrote:
On Thu, Dec 3, 2015 at 1:15 PM Vladimir Voskresensky - Oracle via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Manuel
On 12/ 3/15 01:38 PM, Manuel Klimek via cfe-commits wrote:
> +if (!Compilations) {
> + llvm::err
Thank you, Justin.
2015-12-03 5:37 GMT+06:00 Justin Bogner :
> Serge Pavlov writes:
> > sepavloff created this revision.
> > sepavloff added a reviewer: bogner.
> > sepavloff added subscribers: cfe-commits, silvas.
> >
> > Constructors and destructors may be represented by several functions
> >
aizatsky added a comment.
I didn't really intend for review this yet - this was only experiment and I
also discovered a generic naming tidy check.
But putting this aside, is there an interest to have more style conformance
checks?
Repository:
rL LLVM
http://reviews.llvm.org/D15170
___
sepavloff updated this revision to Diff 41744.
sepavloff added a comment.
Changes according to reviewer's notes.
http://reviews.llvm.org/D15158
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGObjC.cpp
lib/CodeGen/CGStmt.cpp
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/CodeGenFunction.cpp
On Thu, Dec 3, 2015 at 1:15 PM Vladimir Voskresensky - Oracle via
cfe-commits wrote:
> Manuel
>
> On 12/ 3/15 01:38 PM, Manuel Klimek via cfe-commits wrote:
> > +if (!Compilations) {
> > + llvm::errs() << "Error while trying to load a compilation
> database:\n"
> > + <<
Manuel
On 12/ 3/15 01:38 PM, Manuel Klimek via cfe-commits wrote:
+if (!Compilations) {
+ llvm::errs() << "Error while trying to load a compilation database:\n"
+ << ErrorMessage << "Running without flags.\n";
+ Compilations.reset(
+ new FixedCompilationD
spetrovic added inline comments.
Comment at: lib/Driver/Tools.cpp:1439
@@ -1437,1 +1438,3 @@
+ ppc::FloatABI FloatABI = ppc::getPPCFloatABI(D, Args);
+ if (FloatABI == ppc::FloatABI::Soft &&
I'm planning to support soft float for ppc64. At this moment I don't
Author: kparzysz
Date: Thu Dec 3 06:03:56 2015
New Revision: 254606
URL: http://llvm.org/viewvc/llvm-project?rev=254606&view=rev
Log:
Unxfail passing test: test/CodeGenCXX/crash.cpp
Modified:
cfe/trunk/test/CodeGenCXX/crash.cpp
Modified: cfe/trunk/test/CodeGenCXX/crash.cpp
URL:
http://llvm
spetrovic updated this revision to Diff 41736.
spetrovic marked 3 inline comments as done.
http://reviews.llvm.org/D13351
Files:
lib/CodeGen/TargetInfo.cpp
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/CodeGen/ppc-sfvarargs.c
test/Driver/ppc-features.cpp
Index: test/Driver/ppc-features.
I've reverted the commit in r254605.
On Thu, Dec 3, 2015 at 11:20 AM, Alexander Kornienko
wrote:
> Please fix or revert this patch.
>
> On Wed, Dec 2, 2015 at 6:07 PM, Joerg Sonnenberger via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Thu, Nov 26, 2015 at 09:34:31AM -, Alexand
Author: alexfh
Date: Thu Dec 3 05:37:28 2015
New Revision: 254605
URL: http://llvm.org/viewvc/llvm-project?rev=254605&view=rev
Log:
Revert "Fix for merging decls in pragma weak Calling CheckFunctionDeclaration
so that 2 decls for the 'weak' are merged. Differential Revision:
http://reviews.llvm
Applied your patch, modified it a bit, and submitted r254599. Thanks!
On Thu, Dec 3, 2015 at 11:15 AM Russell Wallace
wrote:
> Okay - I don't understand how the class works well enough to be certain
> that will do the same thing, but if you do, I've no problem taking your
> word for it. Should I
Author: klimek
Date: Thu Dec 3 04:38:53 2015
New Revision: 254599
URL: http://llvm.org/viewvc/llvm-project?rev=254599&view=rev
Log:
Add fall-back mode for clang tools.
Run without flags if we cannot load a compilation database. This matches
the behavior of clang itself when simply called with a
Please fix or revert this patch.
On Wed, Dec 2, 2015 at 6:07 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Nov 26, 2015 at 09:34:31AM -, Alexander Musman via cfe-commits
> wrote:
> > Author: amusman
> > Date: Thu Nov 26 03:34:30 2015
> > New Revision: 2
Okay - I don't understand how the class works well enough to be certain
that will do the same thing, but if you do, I've no problem taking your
word for it. Should I resend the patch with that change?
On Thu, Dec 3, 2015 at 9:56 AM, Manuel Klimek wrote:
> -if (!Compilations)
> - llvm::r
-if (!Compilations)
- llvm::report_fatal_error(ErrorMessage);
+if (!Compilations) {
+ errs() << "Compilation database not found - using default options\n";
+ int argc = 1;
+ const char *argv[] = {"--"};
+ Compilations.reset(
+ FixedCompilationDatabase::load
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254596: PR25575: Make GCC 4.4+ comatible layout for packed
bit-fileds of char type… (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D14872?vs=41648&id=41724#toc
Repository:
rL
Author: abataev
Date: Thu Dec 3 03:34:49 2015
New Revision: 254596
URL: http://llvm.org/viewvc/llvm-project?rev=254596&view=rev
Log:
PR25575: Make GCC 4.4+ comatible layout for packed bit-fileds of char type,
patch by D. Polukhin
This CL is for discussion how to better fix bit-filed layout comp
66 matches
Mail list logo
