r254247 - [X86] Remove temporary variables from intrinsic macros. NFC

2015-11-28 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun Nov 29 00:50:33 2015 New Revision: 254247 URL: http://llvm.org/viewvc/llvm-project?rev=254247&view=rev Log: [X86] Remove temporary variables from intrinsic macros. NFC Modified: cfe/trunk/lib/Headers/avx512fintrin.h Modified: cfe/trunk/lib/Headers/avx512fintrin.h UR

Re: [PATCH] D14891: Replace assert with early-out in tryEmitFMulAdd

2015-11-28 Thread David Majnemer via cfe-commits
majnemer added a subscriber: majnemer. majnemer added a comment. Is it possible to have a test which covers this change? Comment at: lib/CodeGen/CGExprScalar.cpp:2568 @@ -2567,1 +2567,3 @@ + // that does not have any other uses. if (llvm::BinaryOperator* LHSBinOp = dyn_cast(

Re: [PATCH] D15007: [analyzer] Improve modelling of nullptr_t in the analyzer. Fix PR25414.

2015-11-28 Thread Devin Coughlin via cfe-commits
dcoughlin added a comment. Gabor, thanks for taking a look at this! I'm not sure `RegionStore::getBinding()` is the right place to put this logic. First, not all dereferences of a `std::nullptr_t` value go through `getBinding()`, so, for example, the following snippet triggers the assertion ev

Re: [PATCH] D14891: Replace assert with early-out in tryEmitFMulAdd

2015-11-28 Thread Steve Canon via cfe-commits
scanon added a comment. Friendly ping. http://reviews.llvm.org/D14891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[Static Analyzer] New checker hook: checkInitialState

2015-11-28 Thread Gabor Kozar via cfe-commits
Hi, Once, long ago, I started working on this checker callback, but forgot about it. I have decided to finish it now. Original discussion: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20131216/095565.html The motivation was (pipermail doesn't seem to have my original mail, for some rea

Re: [PATCH] D14325: [clang-format] Do not align assignments that aren't after the same number of commas. (Closes: 25329)

2015-11-28 Thread Beren Minor via cfe-commits
berenm added a comment. I don't have commit access, if you don't mind landing it for me :) http://reviews.llvm.org/D14325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits