r252586 - [X86] Remove temporary variables from macros in x86 intrinsic headers. Prevents duplicate names appearing from multiple macro expansions. NFC

2015-11-09 Thread Craig Topper via cfe-commits
Author: ctopper Date: Mon Nov 9 23:08:05 2015 New Revision: 252586 URL: http://llvm.org/viewvc/llvm-project?rev=252586&view=rev Log: [X86] Remove temporary variables from macros in x86 intrinsic headers. Prevents duplicate names appearing from multiple macro expansions. NFC Modified: cfe/tr

r252587 - [X86] Use setzero instead of set1(0) in a few places in intrinsic headers.

2015-11-09 Thread Craig Topper via cfe-commits
Author: ctopper Date: Mon Nov 9 23:08:08 2015 New Revision: 252587 URL: http://llvm.org/viewvc/llvm-project?rev=252587&view=rev Log: [X86] Use setzero instead of set1(0) in a few places in intrinsic headers. Modified: cfe/trunk/lib/Headers/avx2intrin.h cfe/trunk/lib/Headers/emmintrin.h

r252585 - [X86] Fix bad intrinsic header comment. NFC.

2015-11-09 Thread Craig Topper via cfe-commits
Author: ctopper Date: Mon Nov 9 23:08:00 2015 New Revision: 252585 URL: http://llvm.org/viewvc/llvm-project?rev=252585&view=rev Log: [X86] Fix bad intrinsic header comment. NFC. Modified: cfe/trunk/lib/Headers/__wmmintrin_pclmul.h Modified: cfe/trunk/lib/Headers/__wmmintrin_pclmul.h URL: h

Re: [PATCH] D13759: [Clang] Fix Clang-tidy modernize-use-auto warnings in headers and generated files; other minor cleanups.

2015-11-09 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko updated the summary for this revision. Eugene.Zelenko added a reviewer: aaron.ballman. Eugene.Zelenko updated this revision to Diff 39778. Eugene.Zelenko added a comment. Synchronize with current code. Repository: rL LLVM http://reviews.llvm.org/D13759 Files: include/clang/A

Re: [PATCH] D13854: Template class: emit better diagnostic in case of missing template argument list

2015-11-09 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/Sema/SemaCXXScopeSpec.cpp:775-787 @@ +774,15 @@ +if (ClassTemplateDecl *CTD = Found.getAsSingle()) { + TemplateParameterList *TPL = CTD->getTemplateParameters(); + assert(TPL && "NULL template parameter list"); + std

Re: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

2015-11-09 Thread David Blaikie via cfe-commits
On Mon, Nov 9, 2015 at 5:08 PM, Robinson, Paul < paul_robin...@playstation.sony.com> wrote: > | when/where/why are types acquired from the mangled names of ELF > symbols, rather than from corresponding DWARF? > > > > Pete, can you help me out here? David seems to want an ironclad case for > not b

Re: [PATCH] D13834: Produce a better diagnostic for global register variables

2015-11-09 Thread Akira Hatanaka via cfe-commits
ahatanak updated this revision to Diff 39774. ahatanak added a comment. Added comments to clarify what the code is doing. http://reviews.llvm.org/D13834 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/TargetInfo.h lib/Basic/Targets.cpp lib/Sema/SemaDecl.cpp test/

RE: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

2015-11-09 Thread Robinson, Paul via cfe-commits
| when/where/why are types acquired from the mangled names of ELF symbols, rather than from corresponding DWARF? Pete, can you help me out here? David seems to want an ironclad case for not being able to do something any other way, before he will let me put the template type parameters on the

r252571 - Use the generic Sparc CPU handling for Linux, FreeBSD and OpenBSD, too.

2015-11-09 Thread Joerg Sonnenberger via cfe-commits
Author: joerg Date: Mon Nov 9 18:40:29 2015 New Revision: 252571 URL: http://llvm.org/viewvc/llvm-project?rev=252571&view=rev Log: Use the generic Sparc CPU handling for Linux, FreeBSD and OpenBSD, too. This currently changes the default toward the more historic -Av8/-Av9, but as discussed with J

r252562 - Use the normal switch over getArch() approach and not a long if chain.

2015-11-09 Thread Joerg Sonnenberger via cfe-commits
Author: joerg Date: Mon Nov 9 18:23:12 2015 New Revision: 252562 URL: http://llvm.org/viewvc/llvm-project?rev=252562&view=rev Log: Use the normal switch over getArch() approach and not a long if chain. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: h

r252558 - [Driver] Use platform-appropriate profiling libraries for WatchOS, TVOS

2015-11-09 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Mon Nov 9 18:20:34 2015 New Revision: 252558 URL: http://llvm.org/viewvc/llvm-project?rev=252558&view=rev Log: [Driver] Use platform-appropriate profiling libraries for WatchOS, TVOS When adding profiling instrumentation, use libclang_rt.profile_tvos.a for TVOS targets and

Re: [PATCH] D14521: [Driver] Use platform-appropriate profiling libraries for WatchOS, TVOS

2015-11-09 Thread Tim Northover via cfe-commits
t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. This looks fine to me. Thanks for working on it! Tim. http://reviews.llvm.org/D14521 ___ cfe-commits mailing list cfe-commits@list

Re: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

2015-11-09 Thread David Blaikie via cfe-commits
On Mon, Nov 9, 2015 at 3:55 PM, Robinson, Paul < paul_robin...@playstation.sony.com> wrote: > | Why is matching by name insufficient/not correct? > > I'm told we look at the mangled names in the ELF symbol table, demangle > them, and look in the DWARF for the corresponding types. > Not quite sure

[PATCH] D14521: [Driver] Use platform-appropriate profiling libraries for WatchOS, TVOS

2015-11-09 Thread Vedant Kumar via cfe-commits
vsk created this revision. vsk added a reviewer: t.p.northover. vsk added a subscriber: cfe-commits. When adding profiling instrumentation, use `libclang_rt.profile_tvos.a` for TVOS targets and `libclang_rt.profile_watchos.a` for WatchOS targets. I've also fixed up a comment and added an assert(

RE: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

2015-11-09 Thread Robinson, Paul via cfe-commits
| Why is matching by name insufficient/not correct? I'm told we look at the mangled names in the ELF symbol table, demangle them, and look in the DWARF for the corresponding types. Now, the mangled name (for predefined types in particular) provides a type description, not the name-as-emitted-by

r252545 - Reorganise CPU handling for Sparc. When using -mcpu=v9 and co, __sparcv8

2015-11-09 Thread Joerg Sonnenberger via cfe-commits
Author: joerg Date: Mon Nov 9 17:39:45 2015 New Revision: 252545 URL: http://llvm.org/viewvc/llvm-project?rev=252545&view=rev Log: Reorganise CPU handling for Sparc. When using -mcpu=v9 and co, __sparcv8 is not defined for 32bit mode, but __sparcv9 is. Pass down the correct -target-cpu flags to t

Re: [PATCH] D9600: Add scan-build python implementation

2015-11-09 Thread Laszlo Nagy via cfe-commits
rizsotto.mailinglist added a comment. the latest update has the following improvements: - makes it work without installation. - pass the `SATestBuild.py` test harness against different projects with `--strictness 2` arguments. (coreutils-8.23, gawk-4.1.1, make-4.0, openssl-1.0.0s, patch-2.7.4,

Re: [PATCH] D13834: Produce a better diagnostic for global register variables

2015-11-09 Thread Eric Christopher via cfe-commits
echristo added a comment. My preference for this sort of thing would be an enum of failure reasons, but I guess this is ok for now. One inline request. -eric Comment at: lib/Basic/Targets.cpp:3978-3981 @@ +3977,6 @@ + bool &HasSizeMismatch)

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

2015-11-09 Thread Evgeniy Stepanov via cfe-commits
eugenis added a comment. is an interesting case. There are no cases of visibility attribute present on an out-of-class definition but missing on an in-class declaration, so nothing needs to be done for a switch to internal_linkage. Setting hidden visibility on an "extern template" method is pr

Re: [PATCH] D14354: Add new compiler flag to enable the generation of dwarf accelerator tables

2015-11-09 Thread Eric Christopher via cfe-commits
echristo added a comment. I think the basic idea on how to do this is to make sure all of the information is there from the front end and have the backend select how to emit based on the code gen flag for this. libLTO is terrible for this, but the schemes working for lld are showing progress in

Re: [PATCH] D14506: Porting shouldVisitImplicitCode to DataRecursiveASTVisitor.

2015-11-09 Thread Anna Zaks via cfe-commits
zaks.anna added a subscriber: zaks.anna. zaks.anna added a comment. Removed myself as a reviewer and added Argyrios instead. http://reviews.llvm.org/D14506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: [PATCH] D14354: Add new compiler flag to enable the generation of dwarf accelerator tables

2015-11-09 Thread Paul Robinson via cfe-commits
probinson added a comment. In http://reviews.llvm.org/D14354#285546, @dblaikie wrote: > Or Tamas can write the tuning patch - it seems like it'd be relatively > straightforward. Perhaps you can give an idea of what you think it'd look > like, Paul (what the command line syntax would be, etc)

r252523 - [CMake] Support passing CMAKE_VERBOSE_MAKEFILE through to bootstrap builds.

2015-11-09 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Mon Nov 9 16:43:10 2015 New Revision: 252523 URL: http://llvm.org/viewvc/llvm-project?rev=252523&view=rev Log: [CMake] Support passing CMAKE_VERBOSE_MAKEFILE through to bootstrap builds. This option enables full verbosity in recursive CMake builds. Modified: cfe/trun

Re: [PATCH] D14307: AMDGPU: Add support for 's' and 'v' asm constraints

2015-11-09 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Sure. You should probably work on the verification side of things as well if you expect to use this more. -eric http://reviews.llvm.org/D14307

[PATCH] D14517: Fix bug 25362 "cppcoreguidelines-pro-bounds-array-to-pointer-decay does not consider const"

2015-11-09 Thread Matthias Gehre via cfe-commits
mgehre created this revision. mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman. mgehre added a subscriber: cfe-commits. The current matcher is implicitCastExpr(unless(hasParent(explicitCastExpr( but the AST in the bug is `-CXXStaticCastExpr 0x2bb64f8 'void *const *' static_c

Re: [PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-09 Thread Chris Bieneman via cfe-commits
> On Nov 9, 2015, at 2:07 PM, Aaron Ballman wrote: > > aaron.ballman added inline comments. > > > Comment at: tools/driver/CMakeLists.txt:58 > @@ -62,1 +57,3 @@ > > +if(NOT MSVC) > + add_custom_target(install-clang > > beanz wrote: >> Can you change this to `

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

2015-11-09 Thread Eric Fiselier via cfe-commits
EricWF added a comment. No changes are needed in ``? Repository: rL LLVM http://reviews.llvm.org/D14409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-09 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: tools/driver/CMakeLists.txt:58 @@ -62,1 +57,3 @@ +if(NOT MSVC) + add_custom_target(install-clang beanz wrote: > Can you change this to `if(NOT CMAKE_CONFIGURATION_TYPES)`? > > With that it won't create the insta

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

2015-11-09 Thread Evgeniy Stepanov via cfe-commits
eugenis updated this revision to Diff 39751. eugenis added a comment. Rebase. Repository: rL LLVM http://reviews.llvm.org/D13925 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/AST/Decl.cpp

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

2015-11-09 Thread Evgeniy Stepanov via cfe-commits
eugenis updated this revision to Diff 39750. eugenis added a comment. Applied the same change to . No idea how I missed it. Repository: rL LLVM http://reviews.llvm.org/D14409 Files: include/istream include/ostream include/sstream include/streambuf Index: include/streambuf ==

Re: [PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-09 Thread Chris Bieneman via cfe-commits
beanz accepted this revision. This revision is now accepted and ready to land. Comment at: tools/driver/CMakeLists.txt:58 @@ -62,1 +57,3 @@ +if(NOT MSVC) + add_custom_target(install-clang Can you change this to `if(NOT CMAKE_CONFIGURATION_TYPES)`? With that it

Re: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

2015-11-09 Thread David Blaikie via cfe-commits
On Thu, Nov 5, 2015 at 11:05 AM, Robinson, Paul < paul_robin...@playstation.sony.com> wrote: > | What was your primary motivation? > > A similar concern to PR20455 from our own debugger. It much helps > matching up the forward declaration and definition to have the parameters > properly specified

Re: r252229 - Fix crash in EmitDeclMetadata mode

2015-11-09 Thread David Blaikie via cfe-commits
Any chance of a test case here? (I don't know much about this code, but I am a bit confused about why we'd ever need to visit a list of mangled names & look them up... ) On Thu, Nov 5, 2015 at 3:18 PM, Keno Fischer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: kfischer > Date: T

Re: [PATCH] D14354: Add new compiler flag to enable the generation of dwarf accelerator tables

2015-11-09 Thread David Blaikie via cfe-commits
Or Tamas can write the tuning patch - it seems like it'd be relatively straightforward. Perhaps you can give an idea of what you think it'd look like, Paul (what the command line syntax would be, etc) On Fri, Nov 6, 2015 at 11:16 AM, Paul Robinson via cfe-commits < cfe-commits@lists.llvm.org> wrot

Re: [PATCH] D12382: Extend linux header search to find libc++ headers in c++/vN for any N.

2015-11-09 Thread Evgeniy Stepanov via cfe-commits
eugenis closed this revision. eugenis added a comment. r252514 Repository: rL LLVM http://reviews.llvm.org/D12382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r252514 - Extend linux header search to find libc++ headers in c++/vN for any N.

2015-11-09 Thread Evgeniy Stepanov via cfe-commits
Author: eugenis Date: Mon Nov 9 15:10:54 2015 New Revision: 252514 URL: http://llvm.org/viewvc/llvm-project?rev=252514&view=rev Log: Extend linux header search to find libc++ headers in c++/vN for any N. Added: cfe/trunk/test/Driver/Inputs/basic_linux_libcxxv2_tree/ cfe/trunk/test/Driver

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

2015-11-09 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/Sema/SemaType.cpp:2621 @@ -2620,3 +2620,3 @@ // C++14 In generic lambdas allow 'auto' in their parameters. - if (ContainsPlaceholderType && + if (D.getDeclSpec().containsPlaceholderType() && (!SemaRef.getLangOpts().CPlusPlu

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

2015-11-09 Thread Richard Smith via cfe-commits
rsmith added a comment. Sorry for the long delay. This looks to be in good shape. Comment at: include/clang/AST/Type.h:1210 @@ +1209,3 @@ +/// Which keyword(s) were used to create an AutoType. +enum class AutoTypeKeyword : unsigned char { + /// \brief auto The

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

2015-11-09 Thread Akira Hatanaka via cfe-commits
ahatanak added a comment. Hi Renato In http://reviews.llvm.org/D14471#285138, @rengolin wrote: > I'm uncomfortable with this change, since it introduces a dependency between > the two calls, and that's fragile. Also, the nullptr fiddling is not a good > design overall. > > If there is a depend

[libcxx] r252509 - Mark LWG#2486 as complete. Eric did this as part of r242959

2015-11-09 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Nov 9 14:49:15 2015 New Revision: 252509 URL: http://llvm.org/viewvc/llvm-project?rev=252509&view=rev Log: Mark LWG#2486 as complete. Eric did this as part of r242959 Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: h

Re: [PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-09 Thread Ben Craig via cfe-commits
bcraig added a comment. In a text file, I have a big long cmake invocation. Part of that invocation is the following: -DCMAKE_INSTALL_PREFIX=c:/install/Tools The VC "INSTALL" project copies files there, in a very unix-y hierarchy (i.e. c:\install\Tools\bin, c:\install\Tools\include, c:\inst

Re: [PATCH] D13854: Template class: emit better diagnostic in case of missing template argument list

2015-11-09 Thread Davide Italiano via cfe-commits
davide added a comment. Gentle Monday morning ping :) Repository: rL LLVM http://reviews.llvm.org/D13854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D14506: Porting shouldVisitImplicitCode to DataRecursiveASTVisitor.

2015-11-09 Thread Ben Craig via cfe-commits
bcraig created this revision. bcraig added reviewers: zaks.anna, rsmith. bcraig added a subscriber: cfe-commits. Herald added a subscriber: klimek. RecursiveASTVisitor allows visitors to specify whether they wish to visit implicitly created code or not. I have ported that code over to DataRecursi

Re: [PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-09 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In http://reviews.llvm.org/D14502#285371, @aaron.ballman wrote: > In http://reviews.llvm.org/D14502#285305, @bcraig wrote: > > > Does this affect the presence or functionality of the "INSTALL" project? > > > There is no INSTALL project in MSVC from what I can see (b

Re: [PATCH] D13874: Atomics: support __c11_* calls on _Atomic struct types

2015-11-09 Thread Tim Northover via cfe-commits
t.p.northover closed this revision. t.p.northover added a comment. Thanks Saleem, committed in r252507. Comment at: lib/CodeGen/CGAtomic.cpp:782 @@ +781,3 @@ + LValue AtomicVal = MakeAddrLValue(Ptr, AtomicTy); + AtomicInfo Atomics(*this, AtomicVal); + compnerd

r252507 - Atomics: support __c11_* calls on _Atomic struct types.

2015-11-09 Thread Tim Northover via cfe-commits
Author: tnorthover Date: Mon Nov 9 13:56:35 2015 New Revision: 252507 URL: http://llvm.org/viewvc/llvm-project?rev=252507&view=rev Log: Atomics: support __c11_* calls on _Atomic struct types. When a struct's size is not a power of 2, the corresponding _Atomic() type is promoted to the nearest. W

Re: [PATCH] D14498: [Analyzer] Fix an assertion caused by r250237 (PR25392)

2015-11-09 Thread Devin Coughlin via cfe-commits
dcoughlin added a comment. Hi Sean, I just committed a slightly different fix that I already had prepared (r252506). That fix also handles the case when the ThisVal is a loc that can't be converted to a memory region. Thanks for looking into this and my apologies for the duplication of effort!

r252506 - [analyzer] Fix assertion failure invalidating on const member function calls (PR25392).

2015-11-09 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Mon Nov 9 13:50:29 2015 New Revision: 252506 URL: http://llvm.org/viewvc/llvm-project?rev=252506&view=rev Log: [analyzer] Fix assertion failure invalidating on const member function calls (PR25392). We now return early when the 'this' value cannot be converted to a MemRe

Re: [PATCH] D13673: Add initial support for the MUSL C library.

2015-11-09 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Yep. That's a flaky test. No need to worry. Repository: rL LLVM http://reviews.llvm.org/D13673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r252501 - Moving FileManager::removeDotPaths to llvm::sys::path::remove_dots

2015-11-09 Thread Mike Aizatsky via cfe-commits
Author: aizatsky Date: Mon Nov 9 13:12:18 2015 New Revision: 252501 URL: http://llvm.org/viewvc/llvm-project?rev=252501&view=rev Log: Moving FileManager::removeDotPaths to llvm::sys::path::remove_dots Differential Revision: http://reviews.llvm.org/D14394 Modified: cfe/trunk/include/clang/Ba

Re: [PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-09 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In http://reviews.llvm.org/D14502#285305, @bcraig wrote: > Does this affect the presence or functionality of the "INSTALL" project? There is no INSTALL project in MSVC from what I can see (before or after this patch), so I don't think that this affects that funct

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

2015-11-09 Thread Evgeniy Stepanov via cfe-commits
eugenis added a comment. Richard, are you OK with this? Repository: rL LLVM http://reviews.llvm.org/D13925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14419: [Extension --> Completeness] Relax rules for writeonce candidacy...

2015-11-09 Thread Larisse Voufo via cfe-commits
lvoufo updated this revision to Diff 39724. lvoufo added a comment. Fix patch (wrong one submitted initially). http://reviews.llvm.org/D14419 Files: include/clang/AST/DeclCXX.h lib/AST/DeclCXX.cpp lib/AST/Type.cpp test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invaria

Re: [PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-09 Thread Ben Craig via cfe-commits
bcraig added a subscriber: bcraig. bcraig added a comment. Does this affect the presence or functionality of the "INSTALL" project? http://reviews.llvm.org/D14502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

2015-11-09 Thread Vadym Doroshenko via cfe-commits
dvadym added a comment. Thanks for review comments! Could you please have an another look and help me with my questions? Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:10 @@ +9,3 @@ +void MoveConstantArgumentCheck::registerMatchers(MatchFinder* Finder) { + Finder->a

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

2015-11-09 Thread Vadym Doroshenko via cfe-commits
dvadym updated this revision to Diff 39717. dvadym marked 5 inline comments as done. dvadym added a comment. Addressed reviewers' comments 1.Change message generation on using diag() string substitution 2.Added copyright 3.Rebase http://reviews.llvm.org/D12031 Files: clang-tidy/misc/CMakeList

[PATCH] D14502: [PATCH] Do not create a clang-install target for MSVC solutions

2015-11-09 Thread Aaron Ballman via cfe-commits
aaron.ballman created this revision. aaron.ballman added a reviewer: beanz. aaron.ballman added a subscriber: cfe-commits. When generating an MSVC solution from CMake, it creates a clang-install project. We do not have any *-install targets as part of MSVC, so this seems out of place (not to men

[clang-tools-extra] r252496 - Rewording some of this documentation to describe the check instead of try to rationalize the behavior of the check. The links already provide sufficient rationale.

2015-11-09 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon Nov 9 12:04:34 2015 New Revision: 252496 URL: http://llvm.org/viewvc/llvm-project?rev=252496&view=rev Log: Rewording some of this documentation to describe the check instead of try to rationalize the behavior of the check. The links already provide sufficient rati

r252494 - Use "auto" when the type name is redundant

2015-11-09 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Mon Nov 9 11:53:06 2015 New Revision: 252494 URL: http://llvm.org/viewvc/llvm-project?rev=252494&view=rev Log: Use "auto" when the type name is redundant Summary: Use "auto" when the type name is redundant Reviewers: aaron.ballman Subscribers: cfe-commits Differential Rev

Re: [PATCH] D14501: Use "auto" when the type name is redundant

2015-11-09 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for tackling this! LGTM! ~Aaron http://reviews.llvm.org/D14501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

Re: r252488 - Adjust printQualifiedName to handle unscoped enums in a way similar to anonymous namespaces.

2015-11-09 Thread Alexander Kornienko via cfe-commits
On Mon, Nov 9, 2015 at 8:50 AM, Aaron Ballman wrote: > On Mon, Nov 9, 2015 at 11:45 AM, Alexander Kornienko via cfe-commits > wrote: > > Author: alexfh > > Date: Mon Nov 9 10:45:17 2015 > > New Revision: 252488 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=252488&view=rev > > Log: > > Ad

[PATCH] D14501: Use "auto" when the type name is redundant

2015-11-09 Thread Alexander Kornienko via cfe-commits
alexfh created this revision. alexfh added a reviewer: aaron.ballman. alexfh added a subscriber: cfe-commits. Use "auto" when the type name is redundant http://reviews.llvm.org/D14501 Files: lib/AST/Decl.cpp Index: lib/AST/Decl.cpp =

Re: r252488 - Adjust printQualifiedName to handle unscoped enums in a way similar to anonymous namespaces.

2015-11-09 Thread Aaron Ballman via cfe-commits
On Mon, Nov 9, 2015 at 11:45 AM, Alexander Kornienko via cfe-commits wrote: > Author: alexfh > Date: Mon Nov 9 10:45:17 2015 > New Revision: 252488 > > URL: http://llvm.org/viewvc/llvm-project?rev=252488&view=rev > Log: > Adjust printQualifiedName to handle unscoped enums in a way similar to > a

Re: [PATCH] D14459: Adjust printQualifiedName to handle unscoped enums in a way similar to anonymous namespaces.

2015-11-09 Thread Alexander Kornienko via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL252488: Adjust printQualifiedName to handle unscoped enums in a way similar to… (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D14459?vs=39605&id=39704#toc Repository: rL LLVM

r252489 - Fix the cmake build after r252474 broke it

2015-11-09 Thread Jonathan Roelofs via cfe-commits
Author: jroelofs Date: Mon Nov 9 10:47:09 2015 New Revision: 252489 URL: http://llvm.org/viewvc/llvm-project?rev=252489&view=rev Log: Fix the cmake build after r252474 broke it Modified: cfe/trunk/tools/scan-build/CMakeLists.txt cfe/trunk/tools/scan-view/CMakeLists.txt Modified: cfe/tru

r252488 - Adjust printQualifiedName to handle unscoped enums in a way similar to anonymous namespaces.

2015-11-09 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Mon Nov 9 10:45:17 2015 New Revision: 252488 URL: http://llvm.org/viewvc/llvm-project?rev=252488&view=rev Log: Adjust printQualifiedName to handle unscoped enums in a way similar to anonymous namespaces. Patch by Sterling Augustine! Differential revision: http://reviews.ll

Re: [PATCH] D9600: Add scan-build python implementation

2015-11-09 Thread Laszlo Nagy via cfe-commits
rizsotto.mailinglist updated this revision to Diff 39703. rizsotto.mailinglist added a comment. findings from compare from older Perl implementation http://reviews.llvm.org/D9600 Files: tools/scan-build-py/README.md tools/scan-build-py/libear/CMakeLists.txt tools/scan-build-py/libear/__in

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

2015-11-09 Thread Akira Hatanaka via cfe-commits
ahatanak updated this revision to Diff 39702. ahatanak added a comment. I ended up making a few more changes based on the feedback on the not_tail_called attribute: - Changed wording in docs and added a code example. - Made changes to detect both (naked,disable_tail_calls) and (disable_tail_cal

Re: [Diffusion] rL250657: Support linking against OpenMP runtime on FreeBSD.

2015-11-09 Thread Tom Stellard via cfe-commits
tstellarAMD edited projects, added 3.7.1-merged; removed 3.7-release. Users: dim (Author) 3.7-release (Auditor) cfe-commits (Auditor) tstellarAMD (Auditor) joerg (Auditor) rsmith (Auditor) http://reviews.llvm.org/rL250657 ___ cfe-commits

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

2015-11-09 Thread Renato Golin via cfe-commits
rengolin added a comment. Hi Akira, I'm uncomfortable with this change, since it introduces a dependency between the two calls, and that's fragile. Also, the nullptr fiddling is not a good design overall. If there is a dependency, I suggest you encode it directly into getAArch64TargetFeatures

[clang-tools-extra] r252485 - Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

2015-11-09 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Mon Nov 9 10:28:11 2015 New Revision: 252485 URL: http://llvm.org/viewvc/llvm-project?rev=252485&view=rev Log: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files. Summary: This patch depends on http://reviews.llvm.org/D14191 Reviewer

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

2015-11-09 Thread Jonathan Roelofs via cfe-commits
jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. r252474 http://reviews.llvm.org/D14403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

r252474 - Create install targets for scan-build and scan-view

2015-11-09 Thread Jonathan Roelofs via cfe-commits
Author: jroelofs Date: Mon Nov 9 10:12:56 2015 New Revision: 252474 URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev Log: Create install targets for scan-build and scan-view http://reviews.llvm.org/D14403 Added: cfe/trunk/tools/scan-build/CMakeLists.txt cfe/trunk/tools/scan-

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

2015-11-09 Thread Jonathan Roelofs via cfe-commits
jroelofs updated this revision to Diff 39693. jroelofs added a comment. Add flags to turn the new targets off. http://reviews.llvm.org/D14403 Files: tools/CMakeLists.txt tools/Makefile tools/scan-build/CMakeLists.txt tools/scan-build/Makefile tools/scan-build/scan-build tools/scan-v

[clang-tools-extra] r252471 - [clang-tidy] Fix message style (capitalization, trailing period).

2015-11-09 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Mon Nov 9 09:53:28 2015 New Revision: 252471 URL: http://llvm.org/viewvc/llvm-project?rev=252471&view=rev Log: [clang-tidy] Fix message style (capitalization, trailing period). Modified: clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp clang

Re: [PATCH] D14498: [Analyzer] Fix an assertion caused by r250237 (PR25392)

2015-11-09 Thread Sean Eveson via cfe-commits
seaneveson added a comment. Fix an assertion which occurs when getCXXThisVal() returns an Unknown SVal and the Analyzer tries to get the corresponding memory region. This assertion was reported in PR25392. The test case from this Bugzilla has been added. (Forgot to add cfe-commits when creatin

r252470 - Fixing SPHINX warnings with incorrect indentations.

2015-11-09 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon Nov 9 09:24:09 2015 New Revision: 252470 URL: http://llvm.org/viewvc/llvm-project?rev=252470&view=rev Log: Fixing SPHINX warnings with incorrect indentations. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Basic/AttrDocs.

Re: [PATCH] D14292: [libcxx] Make it possible to build a no-exceptions variant of libcxx.

2015-11-09 Thread Jonathan Roelofs via cfe-commits
jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D14292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [Diffusion] rL246882: Don't crash on a self-alias declaration

2015-11-09 Thread hfin...@anl.gov via cfe-commits
hfinkel added auditors: rjmccall. hfinkel added a comment. John is the right auditor for this, not me. Users: hfinkel (Author, Auditor) 3.7-release (Auditor) cfe-commits (Auditor) tstellarAMD (Auditor) rjmccall (Auditor) http://reviews.llvm.org/rL246882

Re: [PATCH] D12359: New warning -Wnonconst-parameter when a pointer parameter can be const

2015-11-09 Thread Daniel Marjamäki via cfe-commits
danielmarjamaki updated this revision to Diff 39679. danielmarjamaki marked 2 inline comments as done. danielmarjamaki added a comment. fixes of review comments http://reviews.llvm.org/D12359 Files: include/clang/AST/Decl.h include/clang/Basic/DiagnosticGroups.td include/clang/Basic/Diagn

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

2015-11-09 Thread Renato Golin via cfe-commits
rengolin closed this revision. rengolin added a comment. r252463 Repository: rL LLVM http://reviews.llvm.org/D14184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

2015-11-09 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. Ok, this patch LG. I'd really like to get rid of the current-file-dependent stuff in ClangTidyOptions though :) http://reviews.llvm.org/D14192 _

r252463 - [EABI] Add Clang support for -meabi flag

2015-11-09 Thread Renato Golin via cfe-commits
Author: rengolin Date: Mon Nov 9 06:40:41 2015 New Revision: 252463 URL: http://llvm.org/viewvc/llvm-project?rev=252463&view=rev Log: [EABI] Add Clang support for -meabi flag The -meabi flag to control LLVM EABI version. Without '-meabi' or with '-meabi default' imply LLVM triple default. With

Re: [PATCH] D13673: Add initial support for the MUSL C library.

2015-11-09 Thread Vasileios Kalintiris via cfe-commits
vkalintiris added a comment. Thanks for the review! Everything seems fine from the buildbots except for a single test that failed: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-debian/builds/730 The next build (731) of that buildbot was green. Is libc++::try_lock_shared_fo

[libcxx] r252458 - Make check-libcxx Py3-compatible.

2015-11-09 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Mon Nov 9 04:55:04 2015 New Revision: 252458 URL: http://llvm.org/viewvc/llvm-project?rev=252458&view=rev Log: Make check-libcxx Py3-compatible. Modified: libcxx/trunk/test/libcxx/test/tracing.py Modified: libcxx/trunk/test/libcxx/test/tracing.py URL: http://llvm.org/

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

2015-11-09 Thread Renato Golin via cfe-commits
rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rL LLVM http://reviews.llvm.org/D14184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [PATCH] D13673: Add initial support for the MUSL C library.

2015-11-09 Thread Vasileios Kalintiris via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL252457: Add initial support for the MUSL C library. (authored by vkalintiris). Changed prior to commit: http://reviews.llvm.org/D13673?vs=38788&id=39673#toc Repository: rL LLVM http://reviews.llvm.o

[libcxx] r252457 - Add initial support for the MUSL C library.

2015-11-09 Thread Vasileios Kalintiris via cfe-commits
Author: vkalintiris Date: Mon Nov 9 04:21:04 2015 New Revision: 252457 URL: http://llvm.org/viewvc/llvm-project?rev=252457&view=rev Log: Add initial support for the MUSL C library. Summary: This patch adds the LIBCXX_LIBC_IS_MUSL cmake option to allow the building of libcxx with the Musl C libra

Re: [PATCH] D13811: [clang-format] AllowShortFunctionsOnASingleLine: true/Empty didn't work with BreakBeforeBraces: Linux/Allman.

2015-11-09 Thread Marek Kurdej via cfe-commits
curdeius added a comment. Ping? http://reviews.llvm.org/D13811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

2015-11-09 Thread Serge Pavlov via cfe-commits
sepavloff added a comment. The patch requires tests. For instance, import of CXXBaseSpecifier can be tested along with static_cast: if a class indeed is a base, static_cast will be processed silent, otherwise a message must appear. ArraySubscript could be tested using constexpr function. Materi