Re: [PATCH] D14410: Cleanup: move all visibility attributes to the first declaration.

EricWF added a comment. Thank you so much! I was procrastination taking this on. Repository: rL LLVM http://reviews.llvm.org/D14410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r252274 - Cleanup foo.h headers and __config to work in C

Author: ericwf Date: Fri Nov 6 00:30:12 2015 New Revision: 252274 URL: http://llvm.org/viewvc/llvm-project?rev=252274&view=rev Log: Cleanup foo.h headers and __config to work in C Modified: libcxx/trunk/include/__config libcxx/trunk/include/errno.h libcxx/trunk/include/float.h li

Re: [PATCH] D14385: Correct atomic libcall support for __atomic_*_fetch builtins.

compnerd added a comment. Unfortunate that they have this crazy behavior. Comment at: lib/CodeGen/CGAtomic.cpp:901 @@ -897,1 +900,3 @@ + PostOp = llvm::Instruction::Add; +// Fall through. case AtomicExpr::AO__c11_atomic_fetch_add: I think we should

[PATCH] D14419: [Extension --> Completeness] Relax rules for writeonce candidacy...

lvoufo created this revision. lvoufo added reviewers: chandlerc, majnemer, dberlin, nlewycky. lvoufo added a subscriber: cfe-commits. After D14418, Remove restriction for writeonce semantics to objects with no non-trivial methods... http://reviews.llvm.org/D14419 Files: include/clang/AST/Dec

[PATCH] D14418: [Extension] Optimizing const objects with mutable fields.

lvoufo created this revision. lvoufo added reviewers: dberlin, chandlerc, nlewycky, majnemer. lvoufo added a subscriber: cfe-commits. Adapting solution from const members of non-const objects (D13618) http://reviews.llvm.org/D14418 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunctio

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

lvoufo updated this revision to Diff 39467. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp ==

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

lvoufo updated this revision to Diff 39466. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp ==

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

lvoufo updated this revision to Diff 39465. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/CodeGenModule.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp ==

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

lvoufo updated this revision to Diff 39464. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp === --- test

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Thu, Nov 5, 2015 at 1:12 PM, Richard Smith wrote: > On Wed, Nov 4, 2015 at 7:14 PM, Sean Silva via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Wed, Nov 4, 2015 at 1:07 PM, Richard Smith >> wrote: >> >>> On Sun, Nov 1, 2015 at 10:20 AM, Manuel Klimek >>> wrote: >>> On Fri,

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

lvoufo updated this revision to Diff 39463. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h test/CodeGenCXX/const-invariant.cpp Index: test/CodeGenCXX/const-invariant.cpp === --- test

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

Ping. On Thu, Oct 29, 2015 at 5:21 PM, Richard Smith wrote: > Hi, > > The attached patch undoes the revert of r249929, and adds an extension to > allow (and ) to work properly even in environments such > as iOS where the underlying libc does not provide C++'s const-correct > overloads of strchr

Re: [PATCH] D13263: Addition of __attribute__((pass_object_size)) to Clang

rsmith added a comment. As discussed off-line: 1. Can we avoid tracking the `pass_object_size` attributes in the canonical function type? As the only permitted use of a function with this attribute is as a direct callee in a function call, it seems like we'll always have the parameters to hand

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

lvoufo added a reviewer: majnemer. lvoufo updated this revision to Diff 39458. lvoufo added a comment. Reify computed invariant offsets, and while we're at it, cleanup InvariantArgs: move it out of CodeGenModule.h and remove Offsets member field since offsets are already in the start instruction

[PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis created this revision. eugenis added reviewers: EricWF, mclow.lists. eugenis added a subscriber: cfe-commits. eugenis set the repository for this revision to rL LLVM. Use __attribute__((internal_linkage)) instead of always_inline and visibility("hidden") when it is available. Repository:

[PATCH] D14410: Cleanup: move all visibility attributes to the first declaration.

eugenis created this revision. eugenis added reviewers: EricWF, mclow.lists. eugenis added a subscriber: cfe-commits. eugenis set the repository for this revision to rL LLVM. This change moves visibility attributes from out-of-class method definitions to in-class declaration. This is needed for a

[PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

eugenis created this revision. eugenis added reviewers: mclow.lists, EricWF. eugenis added a subscriber: cfe-commits. eugenis set the repository for this revision to rL LLVM. No point in pretending that these methods are hidden - they are actually exported from libc++.so. Extern template declarati

Re: [PATCH] D10009: Refactor: Simplify boolean conditional return statements in lib/ARCMigrate

This revision was automatically updated to reflect the committed changes. Closed by commit rL252261: Refactor: Simplify boolean conditional return statements in lib/ARCMigrate (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D10009?vs=26475&id=39450#toc Repository: rL L

r252261 - Refactor: Simplify boolean conditional return statements in lib/ARCMigrate

Author: alexfh Date: Thu Nov 5 19:26:37 2015 New Revision: 252261 URL: http://llvm.org/viewvc/llvm-project?rev=252261&view=rev Log: Refactor: Simplify boolean conditional return statements in lib/ARCMigrate Patch by Richard Thomson! (+a couple of modifications to address comments) Differential

Re: [PATCH] D14354: Add new compiler flag to enable the generation of dwarf accelerator tables

tberghammer added a comment. In http://reviews.llvm.org/D14354#282870, @probinson wrote: > So, currently you get accel tables by default for platforms that "tune" for > LLDB, currently Darwin and FreeBSD. > Are you wanting to use LLDB on another platform, or did you want accel > tables for a d

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

zaks.anna added inline comments. Comment at: www/analyzer/installation.html:103 @@ -102,3 +102,1 @@ -Currently these are not installed using make install, and -are located in $(SRCDIR)/tools/clang/tools/scan-build and jroelofs wrote: > @zaks.anna Do you know if

Re: [PATCH] D10008: Refactor: simplify boolean conditional return statements in lib/Analysis

This revision was automatically updated to reflect the committed changes. Closed by commit rL252256: Refactor: simplify boolean conditional return statements in lib/Analysis (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D10008?vs=26486&id=39448#toc Repository: rL LLV

r252256 - Refactor: simplify boolean conditional return statements in lib/Analysis

Author: alexfh Date: Thu Nov 5 19:08:38 2015 New Revision: 252256 URL: http://llvm.org/viewvc/llvm-project?rev=252256&view=rev Log: Refactor: simplify boolean conditional return statements in lib/Analysis Patch by Richard Thomson! Differential revision: http://reviews.llvm.org/D10008 Modified:

[clang-tools-extra] r252248 - [clang-tidy] readability-named-parameter: don't complain about implicit parameters

Author: alexfh Date: Thu Nov 5 18:19:21 2015 New Revision: 252248 URL: http://llvm.org/viewvc/llvm-project?rev=252248&view=rev Log: [clang-tidy] readability-named-parameter: don't complain about implicit parameters Fixes http://llvm.org/PR24464. Modified: clang-tools-extra/trunk/clang-tid

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

djasper added a comment. I'll let Manuel review this tomorrow. He expressed some concerns. http://reviews.llvm.org/D14192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

alexfh added a comment. PTAL http://reviews.llvm.org/D14192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

jroelofs added inline comments. Comment at: www/analyzer/installation.html:103 @@ -102,3 +102,1 @@ -Currently these are not installed using make install, and -are located in $(SRCDIR)/tools/clang/tools/scan-build and @zaks.anna Do you know if there was a particu

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

jroelofs updated this revision to Diff 39439. jroelofs added a comment. Update www too. http://reviews.llvm.org/D14403 Files: tools/CMakeLists.txt tools/Makefile tools/scan-build/scan-build tools/scan-view/Reporter.py tools/scan-view/ScanView.py www/analyzer/installation.html Index

[PATCH] D14403: Create install targets for scan-build and scan-view

jroelofs created this revision. jroelofs added reviewers: zaks.anna, beanz. jroelofs added a subscriber: cfe-commits. http://reviews.llvm.org/D14403 Files: tools/CMakeLists.txt tools/Makefile tools/scan-build/scan-build tools/scan-view/Reporter.py tools/scan-view/ScanView.py Index: too

Re: [PATCH] D14354: Add new compiler flag to enable the generation of dwarf accelerator tables

probinson added a subscriber: probinson. probinson added a comment. So, currently you get accel tables by default for platforms that "tune" for LLDB, currently Darwin and FreeBSD. Are you wanting to use LLDB on another platform, or did you want accel tables for a different debugger? (Eventually

r252229 - Fix crash in EmitDeclMetadata mode

Author: kfischer Date: Thu Nov 5 17:18:44 2015 New Revision: 252229 URL: http://llvm.org/viewvc/llvm-project?rev=252229&view=rev Log: Fix crash in EmitDeclMetadata mode Summary: This fixes a bug that's easily encountered in LLDB (https://llvm.org/bugs/show_bug.cgi?id=22875). The problem here is

Re: [PATCH] D13959: Fix crash in EmitDeclMetadata mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL252229: Fix crash in EmitDeclMetadata mode (authored by kfischer). Changed prior to commit: http://reviews.llvm.org/D13959?vs=38049&id=39426#toc Repository: rL LLVM http://reviews.llvm.org/D13959 F

Re: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

probinson added a comment. Building a debug clang before and after this change and comparing the sum of .debug_* sizes, shows just a shade under 1% increase. http://reviews.llvm.org/D14358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: [PATCH] D9556: [clang-tidy] Support for Static Analyzer plugins (clang part)

alexfh added a comment. In http://reviews.llvm.org/D9556#282718, @xazax.hun wrote: > Unfortunately I had no time to work on this patch, and after I did not finish > this the team I was working in took a different approach: running static > analyzer checker through clang and tidy checkers throug

r252223 - Better link for Library Fundamentals TS.

Author: rsmith Date: Thu Nov 5 16:21:52 2015 New Revision: 252223 URL: http://llvm.org/viewvc/llvm-project?rev=252223&view=rev Log: Better link for Library Fundamentals TS. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm-proj

Re: [PATCH] D14096: [clang-tidy] add new check cppcoreguidelines-pro-type-cstyle-cast

alexfh added a subscriber: alexfh. alexfh added a comment. A peanut gallery comment. Comment at: clang-tidy/cppcoreguidelines/ProTypeCstyleCastCheck.cpp:91 @@ +90,3 @@ + diag_builder << FixItHint::CreateReplacement(ParenRange, CastText); +} else + diag( ---

Re: [PATCH] D13746: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

alexfh added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:56 @@ +55,3 @@ +ArraySize = SizeArg.getAsIntegral(); + } + We can go for a local setting for now, and if we introduce global or module-wide options, w

Re: [PATCH] D14266: CodeGen: Update for debug info API change.Depends on D14265.

This revision was automatically updated to reflect the committed changes. Closed by commit rL252220: CodeGen: Update for debug info API change. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D14266?vs=39004&id=39414#toc Repository: rL LLVM http://reviews.llvm.org/D14266

r252220 - CodeGen: Update for debug info API change.

Author: pcc Date: Thu Nov 5 16:04:14 2015 New Revision: 252220 URL: http://llvm.org/viewvc/llvm-project?rev=252220&view=rev Log: CodeGen: Update for debug info API change. Differential Revision: http://reviews.llvm.org/D14266 Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/tes

Re: [PATCH] D13618: [Extension] Optimizing const member objects.

lvoufo removed a reviewer: majnemer. lvoufo updated this revision to Diff 39411. lvoufo added a comment. Remove commented out line -- Offsets not needed on invariant_end calls after all. http://reviews.llvm.org/D13618 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGe

r252215 - Fix CSS style name.

Author: rsmith Date: Thu Nov 5 15:42:07 2015 New Revision: 252215 URL: http://llvm.org/viewvc/llvm-project?rev=252215&view=rev Log: Fix CSS style name. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/www/cxx

r252216 - Fix incorrect status for P0012R1.

Author: rsmith Date: Thu Nov 5 15:42:32 2015 New Revision: 252216 URL: http://llvm.org/viewvc/llvm-project?rev=252216&view=rev Log: Fix incorrect status for P0012R1. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm-project/cfe

r252214 - Update C++ status page to match motions from Kona.

Author: rsmith Date: Thu Nov 5 15:41:06 2015 New Revision: 252214 URL: http://llvm.org/viewvc/llvm-project?rev=252214&view=rev Log: Update C++ status page to match motions from Kona. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc

Re: [PATCH] D9556: [clang-tidy] Support for Static Analyzer plugins (clang part)

xazax.hun added a comment. Unfortunately I had no time to work on this patch, and after I did not finish this the team I was working in took a different approach: running static analyzer checker through clang and tidy checkers through clang tidy. Initially we wanted to avoid this approach, beca

Re: [PATCH] D9556: [clang-tidy] Support for Static Analyzer plugins (clang part)

alexfh added a comment. http://reviews.llvm.org/D9555 depends on this patch. Are these two patches still interesting to someone? http://reviews.llvm.org/D9556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

Re: [PATCH] D9556: [clang-tidy] Support for Static Analyzer plugins (clang part)

alexfh added a comment. What's the state here? http://reviews.llvm.org/D9556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D7982: Add readability-duplicate-include check to clang-tidy

alexfh added a comment. What's the state of this patch? http://reviews.llvm.org/D7982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r252211 - PR25368: Replace workaround for build failure with modules enabled with a fix

Author: rsmith Date: Thu Nov 5 15:16:22 2015 New Revision: 252211 URL: http://llvm.org/viewvc/llvm-project?rev=252211&view=rev Log: PR25368: Replace workaround for build failure with modules enabled with a fix for the root cause. The 'using llvm::isa;' declaration in Basic/LLVM.h only pulls the d

Re: [PATCH] D8149: Add hasUnderlyingType narrowing matcher for TypedefDecls, functionProtoType matcher for FunctionProtoType nodes, extend parameterCountIs to FunctionProtoType nodes

alexfh added a comment. Richard, what's the state of this patch? http://reviews.llvm.org/D8149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Wed, Nov 4, 2015 at 7:14 PM, Sean Silva via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, Nov 4, 2015 at 1:07 PM, Richard Smith > wrote: > >> On Sun, Nov 1, 2015 at 10:20 AM, Manuel Klimek wrote: >> >>> On Fri, Oct 23, 2015 at 9:31 PM Sean Silva >>> wrote: >>> On Tue, Oct 2

Re: [PATCH] D10025: Refactor: Simplify boolean conditional return statements in clang-apply-replacements

alexfh closed this revision. alexfh added a comment. Committed revision 252207. http://reviews.llvm.org/D10025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r252207 - Refactor: Simplify boolean conditional return statements in clang-apply-replacements

Author: alexfh Date: Thu Nov 5 14:59:17 2015 New Revision: 252207 URL: http://llvm.org/viewvc/llvm-project?rev=252207&view=rev Log: Refactor: Simplify boolean conditional return statements in clang-apply-replacements Differential revision: http://reviews.llvm.org/D10025 Patch by Richard Thomso

r252206 - Improve macro dumping to preserve semantically-relevant spelling information.

Author: rsmith Date: Thu Nov 5 14:55:14 2015 New Revision: 252206 URL: http://llvm.org/viewvc/llvm-project?rev=252206&view=rev Log: Improve macro dumping to preserve semantically-relevant spelling information. Modified: cfe/trunk/lib/Lex/MacroInfo.cpp Modified: cfe/trunk/lib/Lex/MacroInfo.c

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

rengolin added inline comments. Comment at: lib/Driver/Tools.cpp:3415 @@ -3414,1 +3414,3 @@ + CmdArgs.push_back("-meabi"); + if (Arg *A = Args.getLastArg(options::OPT_meabi)) Shouldn't we only add the option if it was used in the command line? ===

Re: [PATCH] D14014: Checker of proper vfork usage

zaks.anna added a comment. Sounds good! http://reviews.llvm.org/D14014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r252201 - [WebAssembly] Update wasm builtin functions to match spec changes.

Author: djg Date: Thu Nov 5 14:16:37 2015 New Revision: 252201 URL: http://llvm.org/viewvc/llvm-project?rev=252201&view=rev Log: [WebAssembly] Update wasm builtin functions to match spec changes. The page_size operator has been removed from the spec, and the resize_memory operator has been chang

Re: [PATCH] D14352: Add diagnostics which fall under [dcl.spec.concept]p5

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D14352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[libcxx] r252199 - Mark LWG issue #2234. We already do this; no code change needed

Author: marshall Date: Thu Nov 5 13:57:50 2015 New Revision: 252199 URL: http://llvm.org/viewvc/llvm-project?rev=252199&view=rev Log: Mark LWG issue #2234. We already do this; no code change needed Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL

[libcxx] r252195 - Implement P0092R1 for C++1z

Author: marshall Date: Thu Nov 5 13:33:59 2015 New Revision: 252195 URL: http://llvm.org/viewvc/llvm-project?rev=252195&view=rev Log: Implement P0092R1 for C++1z Added: libcxx/trunk/test/std/utilities/time/time.duration/time.duration.alg/ libcxx/trunk/test/std/utilities/time/time.durati

r252187 - After some discussion, promote -fobjc-weak to a driver option.

Author: rjmccall Date: Thu Nov 5 13:19:56 2015 New Revision: 252187 URL: http://llvm.org/viewvc/llvm-project?rev=252187&view=rev Log: After some discussion, promote -fobjc-weak to a driver option. rdar://problem/23415863 Added: cfe/trunk/test/Driver/objc-weak.m Modified: cfe/trunk/inclu

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

eugenis added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:3407 @@ +3406,3 @@ + : ExpectedVariableOrFunction); +D->dropAttr(); + } aaron.ballman wrote: > Why is this dropping AlwaysInlineAttr instead of re

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

eugenis updated this revision to Diff 39389. eugenis marked an inline comment as done. eugenis added a comment. Added the new warning to a -W group. Repository: rL LLVM http://reviews.llvm.org/D13925 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic

RE: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

| What was your primary motivation? A similar concern to PR20455 from our own debugger. It much helps matching up the forward declaration and definition to have the parameters properly specified. | maybe it's possible to remangle the template using just the string name I have no idea what you'r

Re: [PATCH] D14354: Add new compiler flag to enable the generation of dwarf accelerator tables

Adding the dwarf accelerator tables is increasing the size of libclang.so (ToT) by ~12% so I don't think we want to generate them by default. Also these sections are not specified by any dwarf standard at the moment so emitting them by default would be strange in my opinion. On Thu, Nov 5, 2015 at

Re: [PATCH] D14352: Add diagnostics which fall under [dcl.spec.concept]p5

nwilson updated this revision to Diff 39386. nwilson added a comment. - replace hyphen and apostrophe with equivalent ASCII characters http://reviews.llvm.org/D14352 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.spec.conc

Re: [PATCH] D14354: Add new compiler flag to enable the generation of dwarf accelerator tables

tberghammer updated this revision to Diff 39385. tberghammer added a comment. Add a test (I have no experience writing clang tests so please let me know if I approach is wrong) http://reviews.llvm.org/D14354 Files: include/clang/Driver/Options.td lib/Driver/Tools.cpp test/Driver/dwarf-ac

Re: [PATCH] D14014: Checker of proper vfork usage

zaks.anna added a comment. Ok. Thanks! I'll commit shortly. http://reviews.llvm.org/D14014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

alexfh updated this revision to Diff 39376. alexfh marked an inline comment as done. alexfh added a comment. Addressed review comments. http://reviews.llvm.org/D14192 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyOptions.cpp clang-tidy/ClangTidyOptions.h test/clang-tidy/custom-dia

Re: [PATCH] D14192: Add ExtraArgs and ExtraArgsBefore options to enable clang warnings via configuration files.

alexfh added inline comments. Comment at: clang-tidy/ClangTidyOptions.h:89-93 @@ -86,1 +88,7 @@ + + /// \brief Add extra compilation arguments to the end of the list. + llvm::Optional ExtraArgs; + + /// \brief Add extra compilation arguments to the start of the list. + llvm::O

[PATCH] D14385: Correct atomic libcall support for __atomic_*_fetch builtins.

jyknight created this revision. jyknight added a reviewer: rsmith. jyknight added subscribers: majnemer, compnerd, cfe-commits, tstellarAMD. In r244063, I had caused these builtins to call the same-named library functions, __atomic_*_fetch_SIZE. However, this was incorrect: while those functions a

Re: [PATCH] D14384: [ARM] Clang gives unintended warning message for 'mthumb' + M-profiles

This revision was automatically updated to reflect the committed changes. Closed by commit rL252175: [ARM] Clang gives unintended warning message for 'mthumb' + M-profiles: (authored by alelab01). Changed prior to commit: http://reviews.llvm.org/D14384?vs=39370&id=39373#toc Repository: rL LL

r252175 - [ARM] Clang gives unintended warning message for 'mthumb' + M-profiles:

Author: alelab01 Date: Thu Nov 5 11:11:55 2015 New Revision: 252175 URL: http://llvm.org/viewvc/llvm-project?rev=252175&view=rev Log: [ARM] Clang gives unintended warning message for 'mthumb' + M-profiles: $ clang --target=armv7m-none-eabi -mthumb -march=armv7-m -c test.c clang-3.8: warning: arg

Re: [PATCH] D14384: [ARM] Clang gives unintended warning message for 'mthumb' + M-profiles

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. LGTM. Thanks! http://reviews.llvm.org/D14384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D14384: [ARM] Clang gives unintended warning message for 'mthumb' + M-profiles

labrinea created this revision. labrinea added reviewers: cfe-commits, rengolin. Herald added subscribers: rengolin, aemerson. ``` $ clang --target=armv7m-none-eabi -mthumb -march=armv7-m -c test.c clang-3.8: warning: argument unused during compilation: '-mthumb' ``` http://reviews.llvm.org/D1438

Re: [PATCH] D14354: Add new compiler flag to enable the generation of dwarf accelerator tables

On Wednesday, November 4, 2015, Tamas Berghammer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > tberghammer created this revision. > tberghammer added a reviewer: echristo. > tberghammer added a subscriber: cfe-commits. > > Add new compiler flag to enable the generation of dwarf accelerato

r252170 - Allow use of private headers in different sub-modules.

Author: klimek Date: Thu Nov 5 09:24:47 2015 New Revision: 252170 URL: http://llvm.org/viewvc/llvm-project?rev=252170&view=rev Log: Allow use of private headers in different sub-modules. Added: cfe/trunk/test/Modules/Inputs/private3/ cfe/trunk/test/Modules/Inputs/private3/private.h c

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:6609 @@ +6608,3 @@ + + if (NewVD->hasLocalStorage() && NewVD->hasAttr()) { +Diag(NewVD->getLocation(), diag::warn_internal_linkage_local_storage); Is there a reason this change cannot go i

Re: [PATCH] D14378: Fix another case where loop-convert wasn't handling correctly data members.

angelgarcia updated this revision to Diff 39350. angelgarcia added a comment. Update the method comment. http://reviews.llvm.org/D14378 Files: clang-tidy/modernize/LoopConvertCheck.cpp test/clang-tidy/modernize-loop-convert-extra.cpp Index: test/clang-tidy/modernize-loop-convert-extra.cpp

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex added a comment. (Ping? I verified yesterday that the patch still applies and passes regression tests.) http://reviews.llvm.org/D12686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D14014: Checker of proper vfork usage

ygribov added a comment. > I now also test for collaboration with security.InsecureAPI.vfork. Should probably clarify: I've added checks to testcase to verify that new checker properly interacts with (existing) InsecureAPI.vfork checker, http://reviews.llvm.org/D14014 _

Re: [PATCH] D14285: [x86] Additional small fix for MCU psABI support

This revision was automatically updated to reflect the committed changes. Closed by commit rL252156: [x86] Additional small fix for MCU psABI support (authored by asbokhan). Changed prior to commit: http://reviews.llvm.org/D14285?vs=39063&id=39347#toc Repository: rL LLVM http://reviews.llvm

r252156 - [x86] Additional small fix for MCU psABI support

Author: asbokhan Date: Thu Nov 5 06:43:09 2015 New Revision: 252156 URL: http://llvm.org/viewvc/llvm-project?rev=252156&view=rev Log: [x86] Additional small fix for MCU psABI support This patch fixes one more thing in MCU psABI support: LongDoubleWidth should be set to 64. Differential Revisio

Re: [PATCH] D14014: Checker of proper vfork usage

ygribov updated this revision to Diff 39345. ygribov added a comment. Moved to unix package (and thus enabled by default). I now also test for collaboration with security.InsecureAPI.vfork. http://reviews.llvm.org/D14014 Files: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerHelpers.h

[PATCH] D14378: Fix another case where loop-convert wasn't handling correctly data members.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: alexfh, cfe-commits. If the container expression was obtained from the point where "size" (which usually is a const method) is invoked, then the topmost node in this expression may be an impli

Re: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

On Wed, Nov 4, 2015 at 11:32 PM, Robinson, Paul < paul_robin...@playstation.sony.com> wrote: > Would citing PR20455 help? It wasn't actually my primary motivation but > it's not too far off. Having the template parameters there lets you know > what's going on in the DWARF, without having to fetc