Re: [PATCH] D13388: Add support for querying the visibility of a cursor

klimek added a comment. Sergey, I think you raised concerns whether this is necessary. What are your thoughts? http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D14198: Make the modernize-loop-convert's const-detection smarter.

klimek added inline comments. Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:371-373 @@ -370,1 +370,5 @@ +/// \brief Returns false when it can be guaranteed that no container element +/// is going to be modified due to this expression. +static bool canBeModified(ASTContex

Re: r251738 - [MSVC Compat] Permit conversions from pointer-to-function to pointer-to-object iff -fms-compatibility

I think we more commonly say "function pointer": $ grep 'pointer-to-function' include/clang/Basic/Diagnostic*td | wc -l 3 $ grep 'function pointer' include/clang/Basic/Diagnostic*td | wc -l 7 For "object pointer" and "pointer-to-object" it's currently a tie. For "member pointer" and

Re: [PATCH] D14212: Make hasLHS and hasRHS matchers available for ArraySubscriptExpr

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D14212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D14213: clang-format: Be slightly more cautious when formatting subsequent lines after a change. With r251474, clang-format could indent the entire rest of the file, if there is a missing

This revision was automatically updated to reflect the committed changes. Closed by commit rL251760: clang-format: Be slightly more cautious when formatting subsequent lines… (authored by djasper). Changed prior to commit: http://reviews.llvm.org/D14213?vs=38838&id=38839#toc Repository: rL L

r251760 - clang-format: Be slightly more cautious when formatting subsequent lines after a change. With r251474, clang-format could indent the entire rest of the file, if there is a missing closing br

Author: djasper Date: Sat Oct 31 19:27:35 2015 New Revision: 251760 URL: http://llvm.org/viewvc/llvm-project?rev=251760&view=rev Log: clang-format: Be slightly more cautious when formatting subsequent lines after a change. With r251474, clang-format could indent the entire rest of the file, if t

Re: [PATCH] D14213: clang-format: Be slightly more cautious when formatting subsequent lines after a change. With r251474, clang-format could indent the entire rest of the file, if there is a missing

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D14213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D14213: clang-format: Be slightly more cautious when formatting subsequent lines after a change. With r251474, clang-format could indent the entire rest of the file, if there is a missing clos

djasper created this revision. djasper added a reviewer: klimek. djasper added a subscriber: cfe-commits. Herald added a subscriber: klimek. With this change, clang-format stops formatting when either it leaves the current scope or when it comes back to the initial scope after going into a nested

Re: [PATCH] D14014: Checker of proper vfork usage

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/VforkChecker.cpp:45 @@ +44,3 @@ + CheckerContext &C) { + const Expr *CE = Call.getOriginExpr(); + ygribov wrote: > It seems that other checkers do more or l

r251738 - [MSVC Compat] Permit conversions from pointer-to-function to pointer-to-object iff -fms-compatibility

Author: majnemer Date: Sat Oct 31 03:42:14 2015 New Revision: 251738 URL: http://llvm.org/viewvc/llvm-project?rev=251738&view=rev Log: [MSVC Compat] Permit conversions from pointer-to-function to pointer-to-object iff -fms-compatibility We permit implicit conversion from pointer-to-function to p