zaks.anna added a comment.
Thanks for the patch!
Some minor comments inline.
What happens when this checker and the security.insecureAPI.vfork are enabled
at the same time?
Did you run this checker on a large body of code? Did it find any issues? What
is needed to turn this into a non-alpha c
ygribov added a comment.
Done!
http://reviews.llvm.org/D14014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Thanks!
2015-10-29 0:29 GMT+02:00 Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org>:
> Author: rnk
> Date: Wed Oct 28 17:29:52 2015
> New Revision: 251567
>
> URL: http://llvm.org/viewvc/llvm-project?rev=251567&view=rev
> Log:
> Fix the calling convention of Mingw64 long double values
Author: marshall
Date: Thu Oct 29 00:43:30 2015
New Revision: 251618
URL: http://llvm.org/viewvc/llvm-project?rev=251618&view=rev
Log:
Implement P0004R1 'Remove Deprecated iostreams aliases'
Modified:
libcxx/trunk/include/ios
libcxx/trunk/test/std/depr/depr.ios.members/io_state.pass.cpp
Author: davidxl
Date: Wed Oct 28 23:04:07 2015
New Revision: 251611
URL: http://llvm.org/viewvc/llvm-project?rev=251611&view=rev
Log:
Fix a soon to be invalid test
Remove a check that won't be valid when LLVM stops
emitting runtime hook user function.
Modified:
cfe/trunk/test/Profile/gcc-fla
Author: compnerd
Date: Wed Oct 28 22:52:14 2015
New Revision: 251603
URL: http://llvm.org/viewvc/llvm-project?rev=251603&view=rev
Log:
test: fix overzealous match
Accidentally made the test too strict.
Modified:
cfe/trunk/test/Driver/windows-cross.c
Modified: cfe/trunk/test/Driver/windows-c
Author: compnerd
Date: Wed Oct 28 22:36:45 2015
New Revision: 251600
URL: http://llvm.org/viewvc/llvm-project?rev=251600&view=rev
Log:
Driver: CrossWindows sanitizers link support
Add the required libraries to the linker invocation when building with
sanitizers.
Modified:
cfe/trunk/lib/Drive
Author: compnerd
Date: Wed Oct 28 22:36:42 2015
New Revision: 251599
URL: http://llvm.org/viewvc/llvm-project?rev=251599&view=rev
Log:
Driver: inline some small arrays
Use an initializer list to remove a couple of small static arrays. NFC.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified
Author: compnerd
Date: Wed Oct 28 22:36:38 2015
New Revision: 251598
URL: http://llvm.org/viewvc/llvm-project?rev=251598&view=rev
Log:
Driver: tweak CrossWindows sanitizer support
Indicate support for ASAN on the CrossWindows toolchain. Although this is
insufficient, this at least permits the ha
Author: dcoughlin
Date: Wed Oct 28 20:23:57 2015
New Revision: 251591
URL: http://llvm.org/viewvc/llvm-project?rev=251591&view=rev
Log:
[analyzer] Update analyzer website for release of checker-277.
Modified:
cfe/trunk/www/analyzer/index.html
cfe/trunk/www/analyzer/installation.html
c
Oh, that's fine. Sorry about that!
-- Carl Thanks for committing.
> On Oct 28, 2015, at 5:32 PM, George Burgess IV
> wrote:
>
> Committed as r251588 -- thanks again!
>
> FYI: I'm assuming that you meant to change the test to
> warn-double-promotion.c instead of leaving it as warn-double-pro
Committed as r251588 -- thanks again!
FYI: I'm assuming that you meant to change the test to
warn-double-promotion.c instead of leaving it as warn-double-promotion.cpp,
so I made that fix for you prior to committing. If this is isn't something
you wanted, please let me know. :)
2015-10-28 17:02 G
Author: gbiv
Date: Wed Oct 28 19:28:52 2015
New Revision: 251588
URL: http://llvm.org/viewvc/llvm-project?rev=251588&view=rev
Log:
[Sema] Implement -Wdouble-promotion for clang.
GCC has a warning called -Wdouble-promotion, which warns you when
an implicit conversion increases the width of a float
alexfh added inline comments.
Comment at: test/clang-tidy/modernize-use-default.cpp:139
@@ +138,3 @@
+
+struct O {
+ O() {
Can we choose a different name for it, that does not resemble a digit?
Comment at: test/clang-tidy/modernize-use-default.c
OK, here you go!
-- Carl
double-promotion-2.patch
Description: Binary data
> On Oct 28, 2015, at 4:53 PM, Carl Norum wrote:
>
>
>> On Oct 28, 2015, at 4:37 PM, George Burgess IV
>> wrote:
>>
>> Thanks for this patch! :) Just a few small nits:
>> - Is there a reason that test/SemaCXX/war
> On Oct 28, 2015, at 4:37 PM, George Burgess IV
> wrote:
>
> Thanks for this patch! :) Just a few small nits:
> - Is there a reason that test/SemaCXX/warn-double-promotion.cpp can't be at
> test/Sema/warn-double-promotion.c instead?
No reason; I just found warn-float-conversion.c in there an
Thanks for this patch! :) Just a few small nits:
- Is there a reason that test/SemaCXX/warn-double-promotion.cpp can't be at
test/Sema/warn-double-promotion.c instead?
- Can we make the warning message a bit more specific? Maybe something like
"implicit conversion increases floating-point precision
dcoughlin accepted this revision.
dcoughlin added a comment.
LGTM. Please commit. Thanks for tackling this, Sean!
http://reviews.llvm.org/D12358
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
tra updated this revision to Diff 38694.
tra added a comment.
Folded some arguments of BuildUniversalActions.
http://reviews.llvm.org/D13144
Files:
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
lib/Driver/Compilation.cpp
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
Author: rnk
Date: Wed Oct 28 18:06:42 2015
New Revision: 251576
URL: http://llvm.org/viewvc/llvm-project?rev=251576&view=rev
Log:
[WinEH] Mark calls inside cleanups as noinline
This works around PR25162. The MSVC tables make it very difficult to
correctly inline a C++ destructor that contains try
tra added inline comments.
Comment at: lib/Driver/Driver.cpp:503
@@ -502,3 +502,3 @@
if (TC.getTriple().isOSBinFormatMachO())
-BuildUniversalActions(C->getDefaultToolChain(), C->getArgs(), Inputs,
+BuildUniversalActions(*C, C->getDefaultToolChain(), C->getArgs(), Inputs
hubert.reinterpretcast added inline comments.
Comment at: include/clang/AST/Decl.h:1577
@@ -1576,2 +1576,3 @@
bool IsConstexpr : 1;
+ bool IsConcept : 1;
nwilson wrote:
> faisalv wrote:
> > My inclination would have been to add this bit to FunctionTemplateDe
Author: rnk
Date: Wed Oct 28 17:29:52 2015
New Revision: 251567
URL: http://llvm.org/viewvc/llvm-project?rev=251567&view=rev
Log:
Fix the calling convention of Mingw64 long double values
GCC uses the x87DoubleExtended model for long doubles, and passes them
indirectly by address through function
Author: benlangmuir
Date: Wed Oct 28 17:25:37 2015
New Revision: 251565
URL: http://llvm.org/viewvc/llvm-project?rev=251565&view=rev
Log:
Fix missing builtin identifier infos with PCH+modules
Use the *current* state of "is-moduleness" rather than the state at
serialization time so that if we read
dcoughlin added a comment.
LGTM. Can you update the summary to a commit message? Then I will commit.
Thanks for upstreaming!
http://reviews.llvm.org/D14014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
echristo added a comment.
Some inline comments for discussion.
Thanks!
-eric
Comment at: lib/Driver/Driver.cpp:503
@@ -502,3 +502,3 @@
if (TC.getTriple().isOSBinFormatMachO())
-BuildUniversalActions(C->getDefaultToolChain(), C->getArgs(), Inputs,
+BuildUniversalActi
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:692-693
@@ -691,4 +691,2 @@
CXXBasePaths Paths(false, false, false);
- if (RD->lookupInBases(
- [DeclName](const CXXBaseSpecifier *Specifier, CXXBasePath &Path) {
--
Thanks for the fix.
On Wed, Oct 28, 2015 at 11:20 AM, Matthias Braun via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: matze
> Date: Wed Oct 28 12:20:33 2015
> New Revision: 251529
>
> URL: http://llvm.org/viewvc/llvm-project?rev=251529&view=rev
> Log:
> Adapt to lit change in llvm r
On 28.10.2015 21:26, Devin Coughlin wrote:
On Oct 28, 2015, at 9:28 AM, Anton Yartsev via cfe-commits
wrote:
Author: ayartsev
Date: Wed Oct 28 11:28:57 2015
New Revision: 251524
URL: http://llvm.org/viewvc/llvm-project?rev=251524&view=rev
Log:
[analyzer] Make inclusion/exclusion of checkers
Author: ayartsev
Date: Wed Oct 28 15:43:39 2015
New Revision: 251552
URL: http://llvm.org/viewvc/llvm-project?rev=251552&view=rev
Log:
[analyzer] Preserve the order checkers were enabled/disabled.
In addition to r251524: preserve the order the checkers were enabled/disabled
to be deterministic.
Author: marshall
Date: Wed Oct 28 14:21:40 2015
New Revision: 251545
URL: http://llvm.org/viewvc/llvm-project?rev=251545&view=rev
Log:
Mark two Kona papers as 'in progress'
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/
eugenis added a comment.
In http://reviews.llvm.org/D13925#276626, @majnemer wrote:
> No diagnostic is issued for the following C test case:
>
> int x __attribute__((internal_linkage));
> int x __attribute__((common));
> int *f() { return &x; }
Thanks for noticing! Added missing attribute
eugenis updated this revision to Diff 38679.
Repository:
rL LLVM
http://reviews.llvm.org/D13925
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Sema/Sema.h
lib/AST/Decl.cpp
lib/Sema/Sema.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaDeclAttr.cpp
test/C
klimek added a comment.
In http://reviews.llvm.org/D14145#277222, @angelgarcia wrote:
> You can initialize an indirect base if it's virtual.
Cool, those cases would be useful to have as comment, for example:
// Make sure there are no additional initializations going on (for example, of
indirec
> On Oct 28, 2015, at 11:03 AM, Justin Bogner via cfe-commits
> wrote:
>
> Xinliang David Li via cfe-commits writes:
>> Author: davidxl
>> Date: Tue Oct 27 00:15:35 2015
>> New Revision: 251385
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=251385&view=rev
>> Log:
>> Create undef referenc
jhowarth added a comment.
The CMakeLists.txt change cited is in top-level of the clang sources and not in
the llvm top-level.
http://reviews.llvm.org/D13802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
ABataev added a comment.
In http://reviews.llvm.org/D13802#276755, @hfinkel wrote:
> In http://reviews.llvm.org/D13802#275471, @chandlerc wrote:
>
> > In http://reviews.llvm.org/D13802#274847, @ABataev wrote:
> >
> > > Hi Chandler, thanks for the review.
> > >
> > > In http://reviews.llvm.org/D13
ABataev added a comment.
In http://reviews.llvm.org/D13802#277270, @jhowarth wrote:
> The proposed patches here to change the default behavior of -fopenmp from
> -fopenmp=libgomp to -fopenmp=libomp seem to only handle the configure-based
> build. The following change required to switch over the
> On Oct 28, 2015, at 9:28 AM, Anton Yartsev via cfe-commits
> wrote:
>
> Author: ayartsev
> Date: Wed Oct 28 11:28:57 2015
> New Revision: 251524
>
> URL: http://llvm.org/viewvc/llvm-project?rev=251524&view=rev
> Log:
> [analyzer] Make inclusion/exclusion of checkers less ambiguous.
...
>
>
jhowarth added a subscriber: jhowarth.
jhowarth added a comment.
The proposed patches here to change the default behavior of -fopenmp from
-fopenmp=libgomp to -fopenmp=libomp seem to only handle the configure-based
build. The following change required to switch over the crake-based build to
def
Hi Eric, Richard,
Any news on this? The test is still broken, should we revert the commit for now?
Thanks,
Michael
> On Oct 24, 2015, at 1:18 AM, Eric Fiselier wrote:
>
> Hi Michael,
>
> Sorry I'm holding this patch up in review. The fix is quite "novel" and I
> want to make sure we get it r
Xinliang David Li via cfe-commits writes:
> Author: davidxl
> Date: Tue Oct 27 00:15:35 2015
> New Revision: 251385
>
> URL: http://llvm.org/viewvc/llvm-project?rev=251385&view=rev
> Log:
> Create undef reference to profile hook symbol
>
> Create undef reference to profile hook symbol when
> PGO
rjmccall added a comment.
Just a few comment suggestions, but functionally LGTM.
Comment at: lib/CodeGen/CGBuiltin.cpp:246
@@ -244,1 +245,3 @@
+// On little-Endian, high-double will be in low part of i128.
+// Therefore, on big-Endian we shift high part to low part.
Author: matze
Date: Wed Oct 28 12:20:33 2015
New Revision: 251529
URL: http://llvm.org/viewvc/llvm-project?rev=251529&view=rev
Log:
Adapt to lit change in llvm r251478-r251481
Sorry for the breakage.
Modified:
libcxx/trunk/test/libcxx/test/format.py
Modified: libcxx/trunk/test/libcxx/test/f
Author: d0k
Date: Wed Oct 28 12:16:26 2015
New Revision: 251528
URL: http://llvm.org/viewvc/llvm-project?rev=251528&view=rev
Log:
Move global classes into anonymous namespaces. NFC.
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
cfe/trunk/lib/CodeGen/CGCall.cpp
Modified: cfe/trunk/lib/AST/
angelgarcia added a comment.
You can initialize an indirect base if it's virtual.
http://reviews.llvm.org/D14145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a comment.
In http://reviews.llvm.org/D14145#277202, @angelgarcia wrote:
> > In which cases can this be false? (I assume if not all are copied?)
>
>
> This can be false is there is we do anything else than initializing the
> bases and members. So the previous code is there to ensure
Hello everyone,
I continue works to reduce buildbot noise.
E-mail notification has been changed in the buildmaster. Now it should not
count interrupted builds to figure out if notification should be send.
So, some people might want to reconsider the notification rules for their
personal notifiers.
Author: ayartsev
Date: Wed Oct 28 11:28:57 2015
New Revision: 251524
URL: http://llvm.org/viewvc/llvm-project?rev=251524&view=rev
Log:
[analyzer] Make inclusion/exclusion of checkers less ambiguous.
A checker may be enabled/disabled multiple times via -enable-checker and
-disable-checker scan-bu
angelgarcia added a comment.
> In which cases can this be false? (I assume if not all are copied?)
This can be false is there is we do anything else than initializing the
bases and members. So the previous code is there to ensure that we do that
and this is here to ensure that we *only* do that.
klimek added inline comments.
Comment at: clang-tidy/modernize/UseDefaultCheck.cpp:83-91
@@ +82,11 @@
+ const CXXMethodDecl *Method) {
+ if (Method->getNumParams() != 1)
+return false;
+ QualType ArgType = Method->getParamDecl(0)->getType();
+
+
klimek added a comment.
Please add unit tests :)
http://reviews.llvm.org/D14152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
angelgarcia updated this revision to Diff 38664.
angelgarcia added a comment.
Refactor most of the code to use AST matchers.
Note that now this change requires http://reviews.llvm.org/D14152 to be applied
first.
http://reviews.llvm.org/D14145
Files:
clang-tidy/modernize/UseDefaultCheck.cpp
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: cfe-commits, alexfh.
Herald added a subscriber: klimek.
This matchers are going to be used in modernize-use-default, but are generic
enough to be placed in ASTMatchers.h.
http://reviews.llvm.o
Author: djasper
Date: Wed Oct 28 09:51:09 2015
New Revision: 251520
URL: http://llvm.org/viewvc/llvm-project?rev=251520&view=rev
Log:
Change test to just define NULL instead of #including stddef.h. In some
test environments, even that builtin header isn't available. Also, this
makes it more consis
Thanks!
On Wed, Oct 28, 2015 at 4:51 AM Angel Garcia wrote:
> angelgarcia added a comment.
>
> OK, thanks! I will try to refactor some of the parts into AST matchers
> then. It will probably take some time, though.
>
>
> http://reviews.llvm.org/D14145
>
>
>
>
Author: d0k
Date: Wed Oct 28 08:54:16 2015
New Revision: 251514
URL: http://llvm.org/viewvc/llvm-project?rev=251514&view=rev
Log:
Put global classes into the appropriate namespace.
Most of the cases belong into an anonymous namespace. No functionality
change intended.
Modified:
cfe/trunk/inc
honggyu.kim added a comment.
In http://reviews.llvm.org/D12906#274724, @o.gyorgy wrote:
> Hi,
>
> You are right the diff is is based on the hash. We already tried to
> use an earlier hash generator (before the patch was introduced), which
> generates a slightly different plist, that is why the
angelgarcia added a comment.
OK, thanks! I will try to refactor some of the parts into AST matchers
then. It will probably take some time, though.
http://reviews.llvm.org/D14145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
klimek added a comment.
Generally, I feel like a lot of the code would be written better as ast
matchers (by adding new matchers if necessary). You can use
tooling::ast_matchers::matches if you want to do a match inside a callback.
Comment at: clang-tidy/modernize/UseDefaultCh
angelgarcia updated this revision to Diff 38648.
angelgarcia added a comment.
Small tweak.
http://reviews.llvm.org/D14145
Files:
clang-tidy/modernize/UseDefaultCheck.cpp
test/clang-tidy/modernize-use-default-copy.cpp
test/clang-tidy/modernize-use-default.cpp
Index: test/clang-tidy/modern
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: alexfh, cfe-commits.
the check will now warn when the user provided definitions of this functions is
equivalent to the explicitly defaulted ones.
http://reviews.llvm.org/D14145
Files:
clang
ygribov added a comment.
> > This is a valid concern because it greatly complicates enablement of
> > VforkChecker for a casual user.
>
>
> I think at the very least I can check that InsecureAPI is enable and issue a
> warning to user.
Actually I think that's not a huge problem. InsecureA
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251507: When running clang with an arm triple such as
'--target=thumbv7m-none-eabi' (authored by alelab01).
Changed prior to commit:
http://reviews.llvm.org/D14121?vs=38633&id=38643#toc
Repository:
r
Author: alelab01
Date: Wed Oct 28 05:10:03 2015
New Revision: 251507
URL: http://llvm.org/viewvc/llvm-project?rev=251507&view=rev
Log:
When running clang with an arm triple such as '--target=thumbv7m-none-eabi'
that has a thumb only CPU by default (cortex-m3), and when using the assembler,
the def
rengolin added a comment.
LGTM, thanks!
http://reviews.llvm.org/D14121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: chapuni
Date: Wed Oct 28 04:22:21 2015
New Revision: 251503
URL: http://llvm.org/viewvc/llvm-project?rev=251503&view=rev
Log:
clang-tools-extra/test/clang-tidy/modernize-redundant-void-arg.c: Use
provided by clang, instead of .
Modified:
clang-tools-extra/trunk/test/clang-tidy/moder
labrinea updated this revision to Diff 38633.
labrinea added a comment.
I think the patch is now in it's final shape:
- kept TY_PP_Asm check
- added darwin and armv7m in checks in tests
- cached IsMProfile
- used ARM::parseArchVersion
http://reviews.llvm.org/D14121
Files:
lib/Driver/ToolChai
68 matches
Mail list logo
