r250994 - clang driver toolchain refactoring

Author: davidxl Date: Thu Oct 22 01:15:31 2015 New Revision: 250994 URL: http://llvm.org/viewvc/llvm-project?rev=250994&view=rev Log: clang driver toolchain refactoring In this patch, the file static method addProfileRT is moved to be a virtual member function of base ToolChain class. This allows

Re: [PATCH] D13326: [PGO]: ToolChain class refactoring: move addProfileRT to be a virtal method: ToolChain::addProfileRTLibs

This revision was automatically updated to reflect the committed changes. Closed by commit rL250994: clang driver toolchain refactoring (authored by davidxl). Changed prior to commit: http://reviews.llvm.org/D13326?vs=38091&id=38092#toc Repository: rL LLVM http://reviews.llvm.org/D13326 Fi

r250993 - [coroutines] Initial stub Sema functionality for handling coroutine await / yield / return.

Author: rsmith Date: Thu Oct 22 01:13:50 2015 New Revision: 250993 URL: http://llvm.org/viewvc/llvm-project?rev=250993&view=rev Log: [coroutines] Initial stub Sema functionality for handling coroutine await / yield / return. Added: cfe/trunk/lib/Sema/SemaCoroutine.cpp cfe/trunk/test/Sema

Re: [PATCH] D13326: [PGO]: ToolChain class refactoring: move addProfileRT to be a virtal method: ToolChain::addProfileRTLibs

davidxl updated this revision to Diff 38091. davidxl added a comment. Updated patch. http://reviews.llvm.org/D13326 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp

Re: [PATCH] D13973: CFG: Delay creating Dtors for CompoundStmts which end in ReturnStmt

mgehre updated this revision to Diff 38090. mgehre added a comment. Fix formatting http://reviews.llvm.org/D13973 Files: lib/Analysis/CFG.cpp Index: lib/Analysis/CFG.cpp === --- lib/Analysis/CFG.cpp +++ lib/Analysis/CFG.cpp @@ -

[PATCH] D13973: CFG: Delay creating Dtors for CompoundStmts which end in ReturnStmt

mgehre created this revision. mgehre added a reviewer: krememek. mgehre added a subscriber: cfe-commits. VisitReturnStmt would create a new block with including Dtors, so the Dtors created in VisitCompoundStmts would be in an unreachable block. Example: struct S { ~S(); } void f() { S s;

Re: [clang-tools-extra] r250939 - [clang-tidy] add check cppcoreguidelines-pro-type-vararg

Fixed in r250986. On Thu, Oct 22, 2015 at 1:01 PM Manman Ren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > It seems that this commit breaks the following bot > http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/12461/ > > Manman > > On Oct 21, 2015, at 1:09 PM, Matthias G

r250992 - [coroutines] Add forgotten test for lexing coroutines keywords.

Author: rsmith Date: Thu Oct 22 00:21:12 2015 New Revision: 250992 URL: http://llvm.org/viewvc/llvm-project?rev=250992&view=rev Log: [coroutines] Add forgotten test for lexing coroutines keywords. Added: cfe/trunk/test/Lexer/coroutines.cpp Added: cfe/trunk/test/Lexer/coroutines.cpp URL: htt

r250991 - [coroutines] Add overloaded unary 'operator co_await'.

Author: rsmith Date: Thu Oct 22 00:12:22 2015 New Revision: 250991 URL: http://llvm.org/viewvc/llvm-project?rev=250991&view=rev Log: [coroutines] Add overloaded unary 'operator co_await'. Modified: cfe/trunk/include/clang/Basic/OperatorKinds.def cfe/trunk/lib/AST/ItaniumMangle.cpp cfe

r250987 - Change MacroInfo::setArgumentList to take an ArrayRef instead of pointer and size. While there use std::copy intead of a manual loop.

Author: ctopper Date: Wed Oct 21 23:59:52 2015 New Revision: 250987 URL: http://llvm.org/viewvc/llvm-project?rev=250987&view=rev Log: Change MacroInfo::setArgumentList to take an ArrayRef instead of pointer and size. While there use std::copy intead of a manual loop. Modified: cfe/trunk/incl

r250990 - Convert ActOnForwardProtocolDeclaration to take an ArrayRef and use a range-based for loop. NFC

Author: ctopper Date: Thu Oct 22 00:00:01 2015 New Revision: 250990 URL: http://llvm.org/viewvc/llvm-project?rev=250990&view=rev Log: Convert ActOnForwardProtocolDeclaration to take an ArrayRef and use a range-based for loop. NFC Modified: cfe/trunk/include/clang/Sema/Sema.h cfe/trunk/li

r250988 - Change FindProtocolDeclaration to take an ArrayRef and use a range-based for loop. NFC

Author: ctopper Date: Wed Oct 21 23:59:56 2015 New Revision: 250988 URL: http://llvm.org/viewvc/llvm-project?rev=250988&view=rev Log: Change FindProtocolDeclaration to take an ArrayRef and use a range-based for loop. NFC Modified: cfe/trunk/include/clang/Sema/Sema.h cfe/trunk/lib/Parse/P

r250989 - Use an ArrayRef instead of pointer and size throughout offsetof handling code. Also use a range-based for loop. NFC

Author: ctopper Date: Wed Oct 21 23:59:59 2015 New Revision: 250989 URL: http://llvm.org/viewvc/llvm-project?rev=250989&view=rev Log: Use an ArrayRef instead of pointer and size throughout offsetof handling code. Also use a range-based for loop. NFC Modified: cfe/trunk/include/clang/Sema/Sem

Re: [PATCH] D13326: [PGO]: ToolChain class refactoring: move addProfileRT to be a virtal method: ToolChain::addProfileRTLibs

davidxl added a comment. It turns out previous refactoring by another commit only covers half of the work. Will update the patch with Justin's comments and commit after testing. http://reviews.llvm.org/D13326 ___ cfe-commits mailing list cfe-commi

[clang-tools-extra] r250986 - clang-tools-extra/test/clang-tidy/cppcoreguidelines-pro-type-vararg.cpp: Tweak not to depend on out-of-tree header .

Author: chapuni Date: Wed Oct 21 23:51:47 2015 New Revision: 250986 URL: http://llvm.org/viewvc/llvm-project?rev=250986&view=rev Log: clang-tools-extra/test/clang-tidy/cppcoreguidelines-pro-type-vararg.cpp: Tweak not to depend on out-of-tree header . Modified: clang-tools-extra/trunk/test/c

r250985 - [coroutines] Add parsing support for co_await expression, co_yield expression,

Author: rsmith Date: Wed Oct 21 23:46:14 2015 New Revision: 250985 URL: http://llvm.org/viewvc/llvm-project?rev=250985&view=rev Log: [coroutines] Add parsing support for co_await expression, co_yield expression, co_await modifier on range-based for loop, co_return statement. Added: cfe/trunk/

r250984 - [coroutines] Fix description of LangOption for coroutines.

Author: rsmith Date: Wed Oct 21 23:42:51 2015 New Revision: 250984 URL: http://llvm.org/viewvc/llvm-project?rev=250984&view=rev Log: [coroutines] Fix description of LangOption for coroutines. Modified: cfe/trunk/include/clang/Basic/LangOptions.def Modified: cfe/trunk/include/clang/Basic/Lang

[clang-tools-extra] r250983 - clang-tools-extra/test/clang-tidy/modernize-use-default.cpp: Appease MS mode.

Author: chapuni Date: Wed Oct 21 23:32:21 2015 New Revision: 250983 URL: http://llvm.org/viewvc/llvm-project?rev=250983&view=rev Log: clang-tools-extra/test/clang-tidy/modernize-use-default.cpp: Appease MS mode. Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-use-default.cpp Modi

r250982 - [coroutines] Add feature-test macro for coroutines, defined to 1 to indicate

Author: rsmith Date: Wed Oct 21 23:27:47 2015 New Revision: 250982 URL: http://llvm.org/viewvc/llvm-project?rev=250982&view=rev Log: [coroutines] Add feature-test macro for coroutines, defined to 1 to indicate the implementation is incomplete. Modified: cfe/trunk/lib/Frontend/InitPreprocessor

Re: [clang-tools-extra] r250939 - [clang-tidy] add check cppcoreguidelines-pro-type-vararg

It seems that this commit breaks the following bot http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/12461/ Manman > On Oct 21, 2015, at 1:09 PM, Matthias Gehre via cfe-commits > wrote: > > Author: mg

r250980 - [coroutines] Add lexer support for co_await, co_yield, and co_return keywords.

Author: rsmith Date: Wed Oct 21 22:52:15 2015 New Revision: 250980 URL: http://llvm.org/viewvc/llvm-project?rev=250980&view=rev Log: [coroutines] Add lexer support for co_await, co_yield, and co_return keywords. Add -fcoroutines flag (just for -cc1 for now) to enable the feature. Early indications

r250977 - Fix a couple places where InsertText was being called with a pointer and size when it really expects a StringRef and a normally optional bool argument.

Author: ctopper Date: Wed Oct 21 22:13:10 2015 New Revision: 250977 URL: http://llvm.org/viewvc/llvm-project?rev=250977&view=rev Log: Fix a couple places where InsertText was being called with a pointer and size when it really expects a StringRef and a normally optional bool argument. The pointe

r250976 - Pass an ArrayRef instead of pointer and size. NFC

Author: ctopper Date: Wed Oct 21 22:13:07 2015 New Revision: 250976 URL: http://llvm.org/viewvc/llvm-project?rev=250976&view=rev Log: Pass an ArrayRef instead of pointer and size. NFC Modified: cfe/trunk/lib/Frontend/Rewrite/RewriteModernObjC.cpp cfe/trunk/lib/Frontend/Rewrite/RewriteObjC

Re: [PATCH] D13969: Tweak how -Wunused-value interacts with macros

thakis added a comment. Sorry about all the emails, I didn't realize that editing the description would send an update every time. Looks like phab's markup language doesn't support code blocks in lists (https://secure.phabricator.com/T4939). The description looks ok in email but broken on phab.

[PATCH] D13969: Tweak how -Wunused-value interacts with macros

thakis created this revision. thakis added a reviewer: rsmith. thakis added a subscriber: cfe-commits. 1. Make the warning more strict in C mode. r172696 added code to suppress warnings from macro expansions in system headers, which checks `SourceMgr.isMacroBodyExpansion(E->IgnoreParens()->getEx

r250971 - Change SortAndUniqueProtocols to operate directly on a SmallVector rather than taking a pointer and element count that it modifies. This paves the way to directly convert the small vector in

Author: ctopper Date: Wed Oct 21 20:56:18 2015 New Revision: 250971 URL: http://llvm.org/viewvc/llvm-project?rev=250971&view=rev Log: Change SortAndUniqueProtocols to operate directly on a SmallVector rather than taking a pointer and element count that it modifies. This paves the way to directly

r250970 - Use front() instead of [0] to make code more consistent with the next line that uses back().

Author: ctopper Date: Wed Oct 21 20:56:16 2015 New Revision: 250970 URL: http://llvm.org/viewvc/llvm-project?rev=250970&view=rev Log: Use front() instead of [0] to make code more consistent with the next line that uses back(). Modified: cfe/trunk/lib/Sema/SemaExpr.cpp Modified: cfe/trunk/li

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

eugenis added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:1580-1585 @@ -1577,3 +1579,8 @@ + + if (InternalLinkageAttr *Internal = D->getAttr()) { +S.Diag(Attr.getRange().getBegin(), diag::warn_attribute_ignored) +<< Attr.getName(); +S.Diag(Internal->get

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

eugenis updated this revision to Diff 38071. eugenis marked 2 inline comments as done. eugenis added a comment. This new version supports __attribute__((internal_linkage)) on classes and even namespaces! Repository: rL LLVM http://reviews.llvm.org/D13925 Files: include/clang/Basic/Attr.td

Re: [PATCH] D10677: Allow deque to handle incomplete types

eugenis added a comment. What kind of confirmation are you looking for? I've compiled the following code with 2 versions of : one as in this review, another the same but with __block_size initializers moved back into respective classes. Resulting object files are identical. #include int main

Re: [PATCH] D10677: Allow deque to handle incomplete types

> I'm pretty sure it only affects template evaluation order, and does not change the mangling of any name. I agree it doesn't change the mangling of any name. I just want to make sure that moving the initializer won't result in incompatible code gen. I'm sure I'm insane for being concerned about t

RE: [libcxx] r250319 - [libcxx] Make it drastically simpler to link libc++.

Thanks. I'll look to see if any other LLVM projects have bumped the CMake version to 3 yet. If so that's the direction I will head. On Oct 20, 2015 9:39 PM, "Hahnfeld, Jonas" wrote: > > -Original Message- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > >

r250963 - Fix use-after-free in ModuleManager

Author: benlangmuir Date: Wed Oct 21 18:12:45 2015 New Revision: 250963 URL: http://llvm.org/viewvc/llvm-project?rev=250963&view=rev Log: Fix use-after-free in ModuleManager When removing out-of-date modules we might have left behind a VisitOrder that contains pointers to freed ModuleFiles. This

r250955 - Enable ARC on the fragile runtime.

Author: rjmccall Date: Wed Oct 21 17:06:03 2015 New Revision: 250955 URL: http://llvm.org/viewvc/llvm-project?rev=250955&view=rev Log: Enable ARC on the fragile runtime. This is almost entirely a matter of just flipping a switch. 99% of the runtime support is available all the way back to when i

r250954 - [Driver] Alias -fvisibility=internal to -fvisibility=hidden

Author: rnk Date: Wed Oct 21 17:01:02 2015 New Revision: 250954 URL: http://llvm.org/viewvc/llvm-project?rev=250954&view=rev Log: [Driver] Alias -fvisibility=internal to -fvisibility=hidden The ELF symbol visibilities are: - internal: Not visibile across DSOs, cannot pass address across DSOs - hi

Re: [PATCH] D12686: Add support for GCC's '__auto_type' extension.

comex added a comment. One more ping. As far as I know, everything has been addressed. http://reviews.llvm.org/D12686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13959: Fix crash in EmitDeclMetadata mode

loladiro created this revision. loladiro added reviewers: rjmccall, labath. loladiro added a subscriber: cfe-commits. loladiro set the repository for this revision to rL LLVM. This fixes a bug that's easily encountered in LLDB (https://llvm.org/bugs/show_bug.cgi?id=22875). The problem here is tha

r250949 - MemorySanitizer does not require PIE.

Author: eugenis Date: Wed Oct 21 16:28:49 2015 New Revision: 250949 URL: http://llvm.org/viewvc/llvm-project?rev=250949&view=rev Log: MemorySanitizer does not require PIE. Since r249754 MemorySanitizer should work equally well for PIE and non-PIE executables on Linux/x86_64. Beware, with this ch

Re: [PATCH] D13610: [CodeGen] Fix CodeGenModule::CreateGlobalInitOrDestructFunction

ahatanak added a comment. The patch isn't fixing any serious bugs, but is fixing what seems to me inconsistencies in the code. It makes the following changes: 1. Currently, SetLLVMFunctionAttributes is called to add function attributes to the internal function definitions, but SetLLVMFunctionAt

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro added inline comments. Comment at: include/clang/Basic/Attr.td:1463 @@ +1462,3 @@ + let Spellings = [GNU<"unique_instantiation">]; + let Subjects = SubjectList<[Function, CXXRecord], ErrorDiag>; + let Documentation = [UniqueInstantiationDocs]; majnemer

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

majnemer added inline comments. Comment at: include/clang/Basic/Attr.td:1463 @@ +1462,3 @@ + let Spellings = [GNU<"unique_instantiation">]; + let Subjects = SubjectList<[Function, CXXRecord], ErrorDiag>; + let Documentation = [UniqueInstantiationDocs]; They wor

r250944 - Revert "MemorySanitizer does not require PIE."

Author: eugenis Date: Wed Oct 21 15:47:00 2015 New Revision: 250944 URL: http://llvm.org/viewvc/llvm-project?rev=250944&view=rev Log: Revert "MemorySanitizer does not require PIE." It actually does require PIE on some targets. Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp cfe/trunk/te

Re: [PATCH] D13913: Allow linking multiple bitcode files.

tra updated this revision to Diff 38046. tra added a comment. Added a comment about format of LinkModules vector. Added/cleaned up few comments in test files. http://reviews.llvm.org/D13913 Files: include/clang/Basic/LangOptions.def include/clang/CodeGen/CodeGenAction.h include/clang/Driv

Re: [PATCH] D13913: Allow linking multiple bitcode files.

tra marked an inline comment as done. tra added a comment. http://reviews.llvm.org/D13913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13640: [clang-tidy] Add new check cppcoreguidelines-pro-bounds-array-to-pointer-decay

mgehre marked an inline comment as done. Comment at: test/clang-tidy/cppcoreguidelines-pro-bounds-array-to-pointer-decay.cpp:13 @@ +12,3 @@ + +void pointerfun(int* p); +void arrayfun(int p[]); aaron.ballman wrote: > > Currently, the diag is > > ``` > > diag(Match

r250941 - MemorySanitizer does not require PIE.

Author: eugenis Date: Wed Oct 21 15:20:03 2015 New Revision: 250941 URL: http://llvm.org/viewvc/llvm-project?rev=250941&view=rev Log: MemorySanitizer does not require PIE. Since r249754 MemorySanitizer should work equally well for PIE and non-PIE executables. Beware, with this change -fsanitize=

Re: [PATCH] D13171: [CUDA] Added a wrapper header for inclusion of stock CUDA headers.

echristo accepted this revision. echristo added a comment. In http://reviews.llvm.org/D13171#272441, @tra wrote: > In http://reviews.llvm.org/D13171#272397, @echristo wrote: > > > I'm ignoring the content of the header, but this seems to be a not terrible > > way to do things. I gather that cuda

Re: [PATCH] D13954: CodeGen: Fix LLVM assertion if Swift and Clang emit Objective-C class reference in same LLVM module

rjmccall added a comment. It just occurred to me that there is a way to test this in Clang with the asm-label extension: int Foo_class asm("OBJC_CLASS_$_Foo"); Of course, you'll have to actually use it from somewhere, or define it, in order for it to actually show up in the IR and cause a co

Re: [PATCH] D13171: [CUDA] Added a wrapper header for inclusion of stock CUDA headers.

tra added a comment. In http://reviews.llvm.org/D13171#272397, @echristo wrote: > I'm ignoring the content of the header, but this seems to be a not terrible > way to do things. I gather that cuda_runtime.h is something that's typically > included by the driver by nvidia and not the client? C

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro set the repository for this revision to rL LLVM. loladiro updated this revision to Diff 38039. loladiro added a comment. Address review comments. Repository: rL LLVM http://reviews.llvm.org/D13330 Files: include/clang/AST/ASTContext.h include/clang/Basic/Attr.td include/clang/

Re: [PATCH] D13787: [clang-tidy] add check cppcoreguidelines-pro-type-vararg-use

This revision was automatically updated to reflect the committed changes. Closed by commit rL250939: [clang-tidy] add check cppcoreguidelines-pro-type-vararg (authored by mgehre). Changed prior to commit: http://reviews.llvm.org/D13787?vs=37925&id=38040#toc Repository: rL LLVM http://review

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro added inline comments. Comment at: include/clang/Basic/Attr.td:1463 @@ +1462,3 @@ + let Spellings = [GNU<"unique_instantiation">]; + let Subjects = SubjectList<[Function, CXXRecord], ErrorDiag>; + let Documentation = [UniqueInstantiationDocs]; majnemer

[clang-tools-extra] r250939 - [clang-tidy] add check cppcoreguidelines-pro-type-vararg

Author: mgehre Date: Wed Oct 21 15:09:02 2015 New Revision: 250939 URL: http://llvm.org/viewvc/llvm-project?rev=250939&view=rev Log: [clang-tidy] add check cppcoreguidelines-pro-type-vararg Summary: This check flags all calls to c-style vararg functions and all use of va_list, va_start and va_arg

[PATCH] D13954: CodeGen: Fix LLVM assertion if Swift and Clang emit Objective-C class reference in same LLVM module

slavapestov created this revision. slavapestov added a reviewer: cfe-commits. slavapestov set the repository for this revision to rL LLVM. This patch fixes an issue that can come up when Swift and Clang are emitting declarations into the same LLVM module. Objective-C class literals result in the

Re: [PATCH] D13610: [CodeGen] Fix CodeGenModule::CreateGlobalInitOrDestructFunction

echristo added a comment. Can you give me some more background here? I'm not sure I see what's wrong and what's going wrong. Thanks! -eric http://reviews.llvm.org/D13610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D13928: [CodeGen] Attach function attributes to Objective-c and OpenMP functions.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. I really wish this could be refactored in a better way, that said, this is better than it was and no harder to refactor at the end. Thanks. -eric http://reviews.llvm.org/D13928 _

r250935 - [Sema] Remove an unreachable llvm_unreachable

Author: majnemer Date: Wed Oct 21 14:48:47 2015 New Revision: 250935 URL: http://llvm.org/viewvc/llvm-project?rev=250935&view=rev Log: [Sema] Remove an unreachable llvm_unreachable No functionality change is intended. Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp Modified: cfe/trunk/lib/Sema

Re: [PATCH] D13171: [CUDA] Added a wrapper header for inclusion of stock CUDA headers.

echristo added a comment. I'm ignoring the content of the header, but this seems to be a not terrible way to do things. I gather that cuda_runtime.h is something that's typically included by the driver by nvidia and not the client? Also, tests? -eric http://reviews.llvm.org/D13171 ___

Re: [PATCH] D13913: Allow linking multiple bitcode files.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. One inline comment, otherwise LGTM. -eric Comment at: include/clang/CodeGen/CodeGenAction.h:28 @@ -27,3 +27,3 @@ std::unique_ptr TheModule; - llvm::Module *LinkModule

Re: [PATCH] D13144: [CUDA] propagate to CUDA sub-compilations target triple of opposite side.

echristo added a comment. Would this make more sense to put in the Compilation class rather than on the Action? It seems like it could go next to DefaultToolchain or could even be a separate toolchain itself so that all of the bits could be looked up? Thanks! -eric http://reviews.llvm.org/D1

r250932 - [Myriad]: Always add -L paths even if -nostdlib is set.

Author: dougk Date: Wed Oct 21 14:33:54 2015 New Revision: 250932 URL: http://llvm.org/viewvc/llvm-project?rev=250932&view=rev Log: [Myriad]: Always add -L paths even if -nostdlib is set. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/

Re: [PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

rjmccall added a comment. CurFuncDecl is supposed to be the enclosing user function. Things like outlined functions should be getting stored in CurCodeDecl; that's how it's done for blocks and lambdas. http://reviews.llvm.org/D12614 ___ cfe-commi

r250921 - Rename clang config.h include guard from CONFIG_H to CLANG_CONFIG_H

Author: yrnkrn Date: Wed Oct 21 13:16:01 2015 New Revision: 250921 URL: http://llvm.org/viewvc/llvm-project?rev=250921&view=rev Log: Rename clang config.h include guard from CONFIG_H to CLANG_CONFIG_H to make it different from LLVM config.h include guard. Modified: cfe/trunk/include/clang/Co

Re: [PATCH] D13731: [RFC][Analyzer] Supporting function attributes in .model files.

pgousseau added inline comments. Comment at: lib/Analysis/BodyFarm.h:43 @@ +42,3 @@ + /// \brief Merge the attributes found in model files. + /// Note, this adds all attributes found in the model file without any sanity + /// checks. zaks.anna wrote: > Why do w

r250919 - Fix and stylize the emission of GC/ARC ivar and GC block layout strings.

Author: rjmccall Date: Wed Oct 21 13:06:47 2015 New Revision: 250919 URL: http://llvm.org/viewvc/llvm-project?rev=250919&view=rev Log: Fix and stylize the emission of GC/ARC ivar and GC block layout strings. Specifically, handle under-aligned object references (by explicitly ignoring them, becaus

r250916 - In ARC, peephole the initialization of a __weak variable with

Author: rjmccall Date: Wed Oct 21 13:06:31 2015 New Revision: 250916 URL: http://llvm.org/viewvc/llvm-project?rev=250916&view=rev Log: In ARC, peephole the initialization of a __weak variable with a value loaded from a __weak variable into a call to objc_copyWeak or objc_moveWeak. Modified: c

r250918 - Unify the ObjC entrypoint caches.

Author: rjmccall Date: Wed Oct 21 13:06:43 2015 New Revision: 250918 URL: http://llvm.org/viewvc/llvm-project?rev=250918&view=rev Log: Unify the ObjC entrypoint caches. Modified: cfe/trunk/lib/CodeGen/CGCall.cpp cfe/trunk/lib/CodeGen/CGObjC.cpp cfe/trunk/lib/CodeGen/CodeGenFunction.h

r250917 - Some minor ARC diagnostic improvements.

Author: rjmccall Date: Wed Oct 21 13:06:38 2015 New Revision: 250917 URL: http://llvm.org/viewvc/llvm-project?rev=250917&view=rev Log: Some minor ARC diagnostic improvements. Modified: cfe/trunk/include/clang/AST/Type.h cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/li

Re: [PATCH] D13643: [Sema] Warn on ternary comparison

mgrabovsky updated this revision to Diff 37985. mgrabovsky added a comment. Fix comparisons with implicit casts and mismatched types http://reviews.llvm.org/D13643 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp test/Sema/bool-compare.c Index: test/Sema/bool-c

Re: [PATCH] D13643: [Sema] Warn on ternary comparison

mgrabovsky added a comment. In http://reviews.llvm.org/D13643#270813, @danielmarjamaki wrote: > If you're interested.. it does not currently warn about "1.0 < 2.0 < 3.0" as > far as I see. I have now fixed this for C, but the issue remains for C++ and I have absolutely no idea what's going on

Re: [PATCH] D13643: [Sema] Warn on ternary comparison

mgrabovsky added a comment. In http://reviews.llvm.org/D13643#272046, @danielmarjamaki wrote: > In http://reviews.llvm.org/D13643#271885, @danielmarjamaki wrote: > > > I tested this on 2199 debian projects.. and got 16 warnings. > > > > ftp://ftp.se.debian.org/debian/pool/main/t/tf5/tf5_5.0beta

Re: [PATCH] D13643: [Sema] Warn on ternary comparison

mgrabovsky updated this revision to Diff 37987. mgrabovsky added a comment. Correction for C++ tests http://reviews.llvm.org/D13643 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp test/Sema/bool-compare.c test/SemaCXX/bool-compare.cpp Index: test/SemaCXX/boo

Re: [PATCH] D13853: clang-format: Teach --sort-includes that #include and #import mean the same thing.

thakis closed this revision. thakis added a comment. r250909, thanks! http://reviews.llvm.org/D13853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r250909 - clang-format: Teach --sort-includes to interleave #include and #import.

Author: nico Date: Wed Oct 21 12:13:45 2015 New Revision: 250909 URL: http://llvm.org/viewvc/llvm-project?rev=250909&view=rev Log: clang-format: Teach --sort-includes to interleave #include and #import. clang accepts both #include and #import for includes (the latter having an implicit header gua

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

zaks.anna added a comment. Hi Daniel, Have you considered contributing this work to clang/llvm? http://reviews.llvm.org/D12906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

dkrupp added a comment. In http://reviews.llvm.org/D12906#272243, @zaks.anna wrote: > > > In http://reviews.llvm.org/D10305#224956, @zaks.anna wrote: > > > > > > > For example, you could keep the information about the reports in the > > > plist files and use those to > > > > > > > render th

Re: [PATCH] D13853: clang-format: Teach --sort-includes that #include and #import mean the same thing.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D13853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

zaks.anna added a comment. > > In http://reviews.llvm.org/D10305#224956, @zaks.anna wrote: > > > For example, you could keep the information about the reports in the plist > > files and use those to > > > render the reports in HTML. > > > If you're okay with adding HTML file name in

r250905 - Shrink DynTypedNode by one pointer from 40 to 32 bytes (on x86_64).

Author: d0k Date: Wed Oct 21 11:33:15 2015 New Revision: 250905 URL: http://llvm.org/viewvc/llvm-project?rev=250905&view=rev Log: Shrink DynTypedNode by one pointer from 40 to 32 bytes (on x86_64). The MemoizationData cache was introduced to avoid a series of enum compares at the cost of making D

Re: [PATCH] D13946: Shrink DynTypedNode by one pointer from 40 to 32 bytes (on x86_64).

This revision was automatically updated to reflect the committed changes. Closed by commit rL250905: Shrink DynTypedNode by one pointer from 40 to 32 bytes (on x86_64). (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D13946?vs=38023&id=38024#toc Repository: rL LLVM http:

r250903 - Update clang to match llvm r250901. OptTable constructor now takes an ArrayRef. NFC

Author: ctopper Date: Wed Oct 21 11:31:33 2015 New Revision: 250903 URL: http://llvm.org/viewvc/llvm-project?rev=250903&view=rev Log: Update clang to match llvm r250901. OptTable constructor now takes an ArrayRef. NFC Modified: cfe/trunk/lib/Driver/DriverOptions.cpp Modified: cfe/trunk/lib/

r250902 - Use StringRef instead of calling c_str and doing pointer math before eventually creating a StringRef. NFC

Author: ctopper Date: Wed Oct 21 11:31:31 2015 New Revision: 250902 URL: http://llvm.org/viewvc/llvm-project?rev=250902&view=rev Log: Use StringRef instead of calling c_str and doing pointer math before eventually creating a StringRef. NFC Modified: cfe/trunk/lib/Basic/TargetInfo.cpp Modifi

Re: [PATCH] D13853: clang-format: Teach --sort-includes that #include and #import mean the same thing.

thakis added a comment. djasper: Ping :-) http://reviews.llvm.org/D13853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13946: Shrink DynTypedNode by one pointer from 40 to 32 bytes (on x86_64).

sbenza accepted this revision. This revision is now accepted and ready to land. Comment at: include/clang/AST/ASTTypeTraits.h:300 @@ -288,2 +299,3 @@ if (ASTNodeKind::getFromNodeKind().isBaseOf(NodeKind)) -return cast(*reinterpret_cast(Storage)); +return cas

Re: [PATCH] D13946: Shrink DynTypedNode by one pointer from 40 to 32 bytes (on x86_64).

bkramer updated this revision to Diff 38023. bkramer added a comment. Update casts to avoid potential undefined behavior. Now every pointer goes through const void*. http://reviews.llvm.org/D13946 Files: include/clang/AST/ASTTypeTraits.h unittests/ASTMatchers/Dynamic/RegistryTest.cpp Inde

Re: [PATCH] D13946: Shrink DynTypedNode by one pointer from 40 to 32 bytes (on x86_64).

sbenza added inline comments. Comment at: include/clang/AST/ASTTypeTraits.h:250 @@ +249,3 @@ +return NodeKind.hasPointerIdentity() + ? *reinterpret_cast(Storage.buffer) + : nullptr; I'm not sure about this reinterpret_cast. We are n

[PATCH] D13946: Shrink DynTypedNode by one pointer from 40 to 32 bytes (on x86_64).

bkramer created this revision. bkramer added a reviewer: sbenza. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. The MemoizationData cache was introduced to avoid a series of enum compares at the cost of making DynTypedNode bigger. This change reverts to using an enum c

[clang-tools-extra] r250897 - Add modernize-use-default check to clang-tidy.

Author: angelgarcia Date: Wed Oct 21 07:58:15 2015 New Revision: 250897 URL: http://llvm.org/viewvc/llvm-project?rev=250897&view=rev Log: Add modernize-use-default check to clang-tidy. Summary: Add a check that replaces empty bodies of special member functions with '= default;'. For now, it is o

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

chandlerc added a comment. Some minor issues below. Also, Hans and Tom should have a glance at the release bits of this, I don't know any of that stuff. Also, there are still some bugs with check-libomp. The immediate one I noticed was that when i run it in a clean build with enough parallelism

Re: [PATCH] D13931: [Tooling] Add a utility function to replace one nested name with another.

klimek added inline comments. Comment at: include/clang/Tooling/Core/Lookup.h:37-38 @@ +36,4 @@ +/// \param FromDecl The declaration to which the nested name points. +/// \param ReplacementString The replacement nested name. Should be fully +/// qualified.

Re: [PATCH] D13643: [Sema] Warn on ternary comparison

danielmarjamaki added a comment. In http://reviews.llvm.org/D13643#271885, @danielmarjamaki wrote: > I tested this on 2199 debian projects.. and got 16 warnings. > > ftp://ftp.se.debian.org/debian/pool/main/t/tf5/tf5_5.0beta8.orig.tar.gz > expr.c:738:22: warning: comparisons such as 'a < b !=

Re: [PATCH] D13803: [OPENMP] Make -fopenmp to turn on OpenMP support by default, clang part

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM to land when http://reviews.llvm.org/D13802 lands. See my comments there. http://reviews.llvm.org/D13803 ___ cfe-commits mailing list

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

honggyu.kim added a comment. Hi Gabor, I was away from the office for 3 weeks so I couldn't catch up the issues but you almost completed the patch now. Thanks for this work! I just found a tiny problem and described it in the line comment so please have a look at it. Comment

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

honggyu.kim abandoned this revision. honggyu.kim added a comment. Hi Anna, I was away from the office for 3 weeks. Sorry for the late answer. In http://reviews.llvm.org/D12906#256215, @zaks.anna wrote: > I find it very confusing to have 2 different fields for bug identification - > issue_hash

RE: [Patch][OpenCL] Custom atomic Builtin check ignores address space of a non-atomic pointer

Hi Pekka, Are you ok with this change? Thanks, Anastasia -Original Message- From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Anastasia Stulova via cfe-commits Sent: 12 October 2015 16:00 To: 'Pekka Jääskeläinen'; cfe-commits@lists.llvm.org Subject: RE: [Patch][

Re: [PATCH] D13168: [OpenCL] OpenCL2.0 - Apply default address space rules

Anastasia added inline comments. Comment at: lib/Sema/SemaType.cpp:6282 @@ +6281,3 @@ +} else if (state.getCurrentChunkIndex() == 0 && + D.getContext() == Declarator::FileContext && + !D.isFunctionDeclarator() && !D.isFunctionDefinition() && ---

r250892 - [OpenCL] Add test for program scope variable restrictions in OpenCL v2.0

Author: stulova Date: Wed Oct 21 05:37:57 2015 New Revision: 250892 URL: http://llvm.org/viewvc/llvm-project?rev=250892&view=rev Log: [OpenCL] Add test for program scope variable restrictions in OpenCL v2.0 http://reviews.llvm.org/D13105 Added: cfe/trunk/test/SemaOpenCL/storageclass-cl20.cl

Re: r250831 - [AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap.

Thanks. On Wed, Oct 21, 2015 at 12:14 PM, Benjamin Kramer wrote: > Reverted for now in r250889. > > On Wed, Oct 21, 2015 at 12:07 PM, Daniel Jasper > wrote: > > I think we'll need to come up with a different solution. The problem is > that > > DynTypedNode is 5 times larger than the bare pointe

Re: r250831 - [AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap.

Reverted for now in r250889. On Wed, Oct 21, 2015 at 12:07 PM, Daniel Jasper wrote: > I think we'll need to come up with a different solution. The problem is that > DynTypedNode is 5 times larger than the bare pointer and we are storing many > more elements in the ParentMap. This means, this chan

r250889 - Revert "[AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap."

Author: d0k Date: Wed Oct 21 05:07:26 2015 New Revision: 250889 URL: http://llvm.org/viewvc/llvm-project?rev=250889&view=rev Log: Revert "[AST] Put TypeLocs and NestedNameSpecifierLocs into the ParentMap." Putting DynTypedNode in the ParentMap bloats its memory foot print. Before the void* key ha

  1   2   >