Ping^2
Il 12/09/2015 09:40, Abramo Bagnara ha scritto:
> Ping...
>
> Il 29/08/2015 10:01, Abramo Bagnara ha scritto:
>> Il 28/08/2015 23:27, Richard Smith ha scritto:
>>> On Tue, Aug 25, 2015 at 10:27 AM, Abramo Bagnara
>>> mailto:abramo.bagn...@bugseng.com>> wrote:
>>>
>>> Comparing the resu
Author: majnemer
Date: Thu Oct 8 01:31:22 2015
New Revision: 249660
URL: http://llvm.org/viewvc/llvm-project?rev=249660&view=rev
Log:
Update tests touched by r249656
These test updates almost exclusively around the change in behavior
around enum: enums without a definition are considered incompl
On Wed, Oct 7, 2015 at 7:34 PM Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Wed, Oct 7, 2015 at 12:05 PM, Joerg Sonnenberger via cfe-commits
> wrote:
> > On Tue, Oct 06, 2015 at 01:31:01PM -, Aaron Ballman via cfe-commits
> wrote:
> >> Log:
> >> Add a new module for
Author: dougk
Date: Thu Oct 8 00:25:03 2015
New Revision: 249658
URL: http://llvm.org/viewvc/llvm-project?rev=249658&view=rev
Log:
Use itostr(), not std::to_string() because of Android.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
http://llvm.org/v
Author: dougk
Date: Thu Oct 8 00:02:24 2015
New Revision: 249657
URL: http://llvm.org/viewvc/llvm-project?rev=249657&view=rev
Log:
Unbreak 'debug-options' test when builder is Darwin
Modified:
cfe/trunk/test/Driver/debug-options.c
Modified: cfe/trunk/test/Driver/debug-options.c
URL:
http:/
Author: majnemer
Date: Wed Oct 7 23:53:31 2015
New Revision: 249656
URL: http://llvm.org/viewvc/llvm-project?rev=249656&view=rev
Log:
[MSVC Compat] Enable ABI impacting non-conforming behavior independently of
-fms-compatibility
No ABI for C++ currently makes it possible to implement the standa
FYI, this caused a -Wdeclaration-after-statement warning that I fixed in
r249652.
On Wed, Oct 7, 2015 at 5:01 PM, Ehsan Akhgari via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ehsan
> Date: Wed Oct 7 19:01:20 2015
> New Revision: 249639
>
> URL: http://llvm.org/viewvc/llvm-project
Author: ctopper
Date: Wed Oct 7 22:37:36 2015
New Revision: 249652
URL: http://llvm.org/viewvc/llvm-project?rev=249652&view=rev
Log:
Fix a -Wdeclaration-after-statement warning.
Modified:
cfe/trunk/tools/c-index-test/c-index-test.c
Modified: cfe/trunk/tools/c-index-test/c-index-test.c
URL:
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:323
@@ +322,3 @@
+ /// far.
+ struct OffloadEntriesInfoManagerTy {
+CodeGenModule &CGM;
Maybe it is better to make it a class if it has some non-public members?
http://reviews.llvm.or
ABataev added a comment.
Ping
http://reviews.llvm.org/D13375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Wed Oct 7 22:02:09 2015
New Revision: 249649
URL: http://llvm.org/viewvc/llvm-project?rev=249649&view=rev
Log:
Fix incorrect parsing of arguments for nested functions. Reviewed as
http://reviews.llvm.org/D13192. Thanks to Anseny Kapoulkine for the patch.
Modified:
lib
sfantao added a comment.
In http://reviews.llvm.org/D9888#262325, @tra wrote:
> In http://reviews.llvm.org/D9888#257904, @sfantao wrote:
>
> > This diff refactors the original patch and is rebased on top of the latests
> > offloading changes inserted for CUDA.
> >
> > Here I don't touch the CUDA
rsmith added inline comments.
Comment at: include/clang/Basic/Attr.td:2098-2102
@@ +2097,7 @@
+ let Documentation = [OMPDeclareSimdDocs];
+ let AdditionalMembers = [{
+ void printPrettyPragma(raw_ostream &OS, const PrintingPolicy &Policy) const {
+OS << "\n";
+ }
+ }];
+}
Author: rnk
Date: Wed Oct 7 20:13:52 2015
New Revision: 249647
URL: http://llvm.org/viewvc/llvm-project?rev=249647&view=rev
Log:
[WinEH] Remove NewMSEH and enable its behavior by default
Testing has shown that it is at least as reliable as the old landingpad
pattern matching code.
Removed:
alexfh added inline comments.
Comment at: clang-tidy/rename_check.py:53
@@ +52,3 @@
+ return newFileName
+
+def getListOfFiles(clang_tidy_path):
ClockMan wrote:
> Not sure what you mean...
I meant that after that patch the module file name can be more complex.
H
sfantao added a comment.
Art, Jonas,
Thanks for the comments!
In http://reviews.llvm.org/D9888#261434, @Hahnfeld wrote:
> Currently trying to test, but
>
> 1. Offloading to the same target isn't supported (`x86_64-unknown-linux-gnu`
> as host and device) - this was working with `clang-omp` The
sfantao updated this revision to Diff 36816.
sfantao added a comment.
Make the offloading ELF sections consistent with what is in
http://reviews.llvm.org/D12614.
Fix bug in AtTopLevel flag, so that the bundling job is considered always top
level job.
Fix several typos.
http://reviews.llvm.or
samsonov added inline comments.
Comment at: runtime/CMakeLists.txt:41
@@ +40,3 @@
+
+ add_custom_target(compiler-rt-clear
+DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/compiler-rt-cleared
So, that's the target that you can invoke manually to clean compiler-rt build?
chapuni requested changes to this revision.
chapuni added a comment.
This revision now requires changes to proceed.
This change requires cmake-3.
With CMake-2.8.12.2,
CMake Error at
/home/tnakamura/fio/ninja/llvm-project/clang/CMakeLists.txt:560 (export):
export called with target "clangB
Author: rsmith
Date: Wed Oct 7 19:17:59 2015
New Revision: 249641
URL: http://llvm.org/viewvc/llvm-project?rev=249641&view=rev
Log:
When pretty-printing a C++11 literal operator, don't insert whitespace between
the "" and the suffix; that breaks names such as 'operator""if'. For symmetry,
also re
Author: rnk
Date: Wed Oct 7 19:17:45 2015
New Revision: 249640
URL: http://llvm.org/viewvc/llvm-project?rev=249640&view=rev
Log:
Don't emit exceptional stackrestore cleanups around inalloca functions
The backend restores the stack pointer after recovering from an
exception. This is similar to r
sfantao updated this revision to Diff 36812.
sfantao added a comment.
Rebase and fix typo in regression test directive.
http://reviews.llvm.org/D12614
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/LangOptions.def
include/clang/Basic/LangOptions.h
include/clang/
Author: ehsan
Date: Wed Oct 7 19:01:20 2015
New Revision: 249639
URL: http://llvm.org/viewvc/llvm-project?rev=249639&view=rev
Log:
Make clang_Cursor_getMangling not mangle if the declaration isn't mangled
Right now clang_Cursor_getMangling will attempt to mangle any
declaration, even if the decl
tra added a comment.
In http://reviews.llvm.org/D9888#257904, @sfantao wrote:
> This diff refactors the original patch and is rebased on top of the latests
> offloading changes inserted for CUDA.
>
> Here I don't touch the CUDA support. I tried, however, to have the
> implementation modular eno
chapuni added a comment.
I am testing this with cmake-2.8.12. I remember some issues would be there.
http://reviews.llvm.org/D13453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D13453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
jordan_rose resigned from this revision.
jordan_rose edited reviewers, added: beanz; removed: jordan_rose.
jordan_rose added a comment.
I just get things to build with CMake, and I'm not involved with Clang so much
these days. This is more about controlling what gets installed, which should be
c
chapuni added a reviewer: jordan_rose.
chapuni added a comment.
LGTM, but I haven't tested. I'll wait for 3rd opinion for several hours. :)
I thought it may be moved to an arbitrary subdirectory.
http://reviews.llvm.org/D13453
___
cfe-commits maili
On Wed, Oct 7, 2015 at 3:10 PM, Jun Bum Lim via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> junbuml added a comment.
>
> Thanks Richard for the comment.
>
> Initially, I intended to implement this in inliner by checking if a
> callsite is in exception handling regions. However, I decided no
zaks.anna added a comment.
I agree with Gabor. We should investigate how we can model the overflow on a
cast correctly.
http://reviews.llvm.org/D12901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
rsmith added inline comments.
Comment at: lib/Sema/SemaStmt.cpp:508-509
@@ -513,6 +507,4 @@
- DiagnoseUnusedExprResult(elseStmt);
-
return new (Context) IfStmt(Context, IfLoc, ConditionVar, ConditionExpr,
thenStmt, ElseLoc, elseStmt);
}
--
junbuml added a comment.
Thanks Richard for the comment.
Initially, I intended to implement this in inliner by checking if a callsite is
in exception handling regions. However, I decided not to implement this in
inliner because this kind of check should be performed for all callsites if we
imp
On Wed, Oct 7, 2015 at 1:48 PM, Duncan P. N. Exon Smith <
dexonsm...@apple.com> wrote:
>
> > On 2015-Oct-07, at 11:35, Akira Hatanaka wrote:
> >
> > ahatanak created this revision.
> > ahatanak added reviewers: dexonsmith, echristo.
> > ahatanak added a subscriber: cfe-commits.
> >
> > This patch
ClockMan updated this revision to Diff 36801.
ClockMan added a comment.
Corrected review issues.
Repository:
rL LLVM
http://reviews.llvm.org/D13440
Files:
clang-tidy/rename_check.py
Index: clang-tidy/rename_check.py
===
--- /
ClockMan marked 5 inline comments as done.
Comment at: clang-tidy/rename_check.py:53
@@ +52,3 @@
+ return newFileName
+
+def getListOfFiles(clang_tidy_path):
Not sure what you mean...
Repository:
rL LLVM
http://reviews.llvm.org/D13440
On Wed, Oct 7, 2015 at 2:59 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> rsmith added inline comments.
>
>
> Comment at: lib/Sema/SemaDecl.cpp:5902-5915
> @@ -5901,1 +5901,16 @@
> +
> + // C++ Concepts TS [dcl.spec.concept]p7: A program shall not
>
rsmith added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:5902-5915
@@ -5901,1 +5901,16 @@
+
+ // C++ Concepts TS [dcl.spec.concept]p7: A program shall not declare
[...]
+ // an explicit specialization, or a partial specialization of a concept
+ // definitio
aaron.ballman added a comment.
On Wed, Oct 7, 2015 at 5:08 PM, Tobias Langner
wrote:
> Hi,
>
> I incorporated most of your changes. There are 2 open issues
Thank you for your work on this! There are a few minor nitpicks still, but is
definitely moving forward nicely.
> - on one location
On Tue, Oct 6, 2015 at 3:31 PM, Jonathan Roelofs
wrote:
> On 10/6/15 4:03 PM, Richard Smith via cfe-commits wrote:
>
>> Author: rsmith
>> Date: Tue Oct 6 17:03:22 2015
>> New Revision: 249475
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=249475&view=rev
>> Log:
>> Remove unnecessary inline
Marshall: ping, does the below satisfy your concerns about the direction
here?
On Wed, Sep 16, 2015 at 2:04 PM, Richard Smith
wrote:
> On Mon, Sep 14, 2015 at 7:07 AM, Marshall Clow
> wrote:
>
>> mclow.lists added a comment.
>>
>> I have two concerns about this patch (w/o commenting on the actu
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks fine to me. Thanks for the patch (and the test case).
http://reviews.llvm.org/D13192
___
cfe-commits mailing list
cfe-commi
Hi,I incorporated most of your changes. There are 2 open issues- on one location I could not follow your advice, the compiler refused to compile the code. I chose a different approach and hope you like it.- the second thing is this MaterializeTemporary advice that you gave. I don’t fully understand
zaks.anna added a comment.
> Again I'm not sure this is worth checking for, based on the assumption that a
> reasonable const method won't modify the relevant object. What do people
> think?
These are heuristics. I think dealing with this case should not be a
pre-requisite for the patch. We c
Author: rnk
Date: Wed Oct 7 16:03:41 2015
New Revision: 249616
URL: http://llvm.org/viewvc/llvm-project?rev=249616&view=rev
Log:
[WinEH] Don't use lifetime markers for MS catch parameters
We don't have a good place to put them. Our previous spot was causing us
to optimize loads from the exceptio
randomcppprogrammer updated this revision to Diff 36795.
randomcppprogrammer marked 11 inline comments as done.
randomcppprogrammer added a comment.
Incorporated feedback from Aaron Ballmann
main changes:
- replaced isa followed by cast with dyn_cast
- reworked comments
- fixed typo in diagnosis
> On 2015-Oct-07, at 11:35, Akira Hatanaka wrote:
>
> ahatanak created this revision.
> ahatanak added reviewers: dexonsmith, echristo.
> ahatanak added a subscriber: cfe-commits.
>
> This patch makes changes to attach function attributes to the following
> functions created in CGBlocks.cpp:
>
beanz added a comment.
Ping?
http://reviews.llvm.org/D13399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Wed Oct 7 15:33:36 2015
New Revision: 249612
URL: http://llvm.org/viewvc/llvm-project?rev=249612&view=rev
Log:
Fixing links and reformatting code; NFC.
Patch by Marek Kurdej!
Modified:
clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/ProTypeConstCastCheck.cpp
kromanova added a comment.
Hi Pierre,
I noticed the same issue. When I downloaded a patch from
http://reviews.llvm.org/D11279, I had to manually add .keep files to make tests
to pass.
It's a Phabricator problem. The diff file that I uploaded to Phabricator
contains .keep files, however the di
On Wed, Oct 7, 2015 at 4:18 PM, Samuel Benzaquen wrote:
> sbenza added a comment.
>
> In http://reviews.llvm.org/D13510#261925, @aaron.ballman wrote:
>
>> In http://reviews.llvm.org/D13510#261825, @Eugene.Zelenko wrote:
>>
>> > I think it'll be fine to rename check without leaving traces of misc.
On Wed, Oct 7, 2015 at 10:09 PM, Jan Vesely wrote:
>
> This change breaks cmake build:
> undefined reference to `clang::DiagnosticIDs::DiagnosticIDs()'
> /home/jvesely/llvm/tools/clang/unittests/Driver/ToolChainTest.cpp:33:
> undefined reference to
> `clang::DiagnosticsEngine::DiagnosticsEngine(
Author: d0k
Date: Wed Oct 7 15:19:25 2015
New Revision: 249608
URL: http://llvm.org/viewvc/llvm-project?rev=249608&view=rev
Log:
Fix a shared CMake build by linking with libclangBasic.
Patch by Jan Vesely!
Modified:
cfe/trunk/unittests/Driver/CMakeLists.txt
Modified: cfe/trunk/unittests/Dr
sbenza added a comment.
In http://reviews.llvm.org/D13510#261925, @aaron.ballman wrote:
> In http://reviews.llvm.org/D13510#261825, @Eugene.Zelenko wrote:
>
> > I think it'll be fine to rename check without leaving traces of misc. Same
> > thing happened with modernize-shrink-to-fit.
>
>
> I thi
rsmith added a subscriber: rsmith.
rsmith added a comment.
This seems like something that's much better handled by the inliner. We should
presumably treat all the code that leads up to the throw as being cold, not
just the invocation of the throw-expression itself, and it seems like it should
b
mgehre added a comment.
The user will see [cppcoreguidelines-c-copy-assignment-signature] in warnings,
but there is no
docs/clang-tidy/checks/cppcoreguidelines-c-copy-assignment-signature.rst.
The user won't know that he needs to look for misc-assign-operator-signature.
Maybe create a link to
This change breaks cmake build:
undefined reference to `clang::DiagnosticIDs::DiagnosticIDs()'
/home/jvesely/llvm/tools/clang/unittests/Driver/ToolChainTest.cpp:33:
undefined reference to
`clang::DiagnosticsEngine::DiagnosticsEngine(llvm::IntrusiveRefCntPtr
const&, clang::DiagnosticOptions*, clang:
Author: djasper
Date: Wed Oct 7 14:56:12 2015
New Revision: 249598
URL: http://llvm.org/viewvc/llvm-project?rev=249598&view=rev
Log:
ASTMatchers: Keep AllCallbacks in a set instead of a vector
AllCallbacks is currently only used to call onStartOfTranslationUnit and
onEndOfTranslationUnit on them
djasper closed this revision.
djasper added a comment.
Submitted as r249598.
http://reviews.llvm.org/D13523
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Wed Oct 7 14:45:14 2015
New Revision: 249595
URL: http://llvm.org/viewvc/llvm-project?rev=249595&view=rev
Log:
Mark 2244 as 'Patch Ready', 2477 and 2487 as 'Complete'
Modified:
libcxx/trunk/www/kona.html
Modified: libcxx/trunk/www/kona.html
URL:
http://llvm.org/viewv
Author: marshall
Date: Wed Oct 7 14:41:24 2015
New Revision: 249593
URL: http://llvm.org/viewvc/llvm-project?rev=249593&view=rev
Log:
While researching LWG#2244, I noticed we weren't testing that eofbit was being
cleared. Now we are
Modified:
libcxx/trunk/test/std/input.output/iostream.for
alexfh added inline comments.
Comment at: clang-tidy/rename_check.py:3
@@ +2,3 @@
+#
+#===- add_new_check.py - clang-tidy check generator --*- python
-*--===#
+#
Please update the script name and description in the comment.
Comment at: c
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
That makes a lot of sense. LG
http://reviews.llvm.org/D13523
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
mgehre added a subscriber: mgehre.
Comment at: clang-tidy/rename_check.py:39
@@ +38,3 @@
+ if len(sys.argv) != 4:
+print('Usage: rename_check.py , e.g.\n')
+print('rename_check.py misc awesome-functions new-awesome-function\n')
Should be
```
Usage: renam
aaron.ballman added a comment.
This patch is looking much closer! Thank you for continuing to work on it.
I found several mechanical changes that need to be made, like style, comments,
formatting, isa<> followed by cast<>, etc. There is one logic issue regarding
materialized temporaries that I
Hi Doug,
On Wed, Sep 30, 2015 at 2:27 PM, Douglas Gregor via cfe-commits
wrote:
> Author: dgregor
> Date: Wed Sep 30 16:27:42 2015
> New Revision: 248949
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248949&view=rev
> Log:
> Don't inherit availability information when implementing a protocol
ahatanak created this revision.
ahatanak added reviewers: dexonsmith, echristo.
ahatanak added a subscriber: cfe-commits.
This patch makes changes to attach function attributes to the following
functions created in CGBlocks.cpp:
__copy_helper_block_
__destroy_helper_block_
__Block_byref_object_c
djasper created this revision.
djasper added a reviewer: klimek.
djasper added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
AllCallbacks is currently only used to call onStartOfTranslationUnit and
onEndOfTranslationUnit on them. In this (and any other scenario I can come up
with
dougk marked an inline comment as done.
dougk added a comment.
http://reviews.llvm.org/D13221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
In http://reviews.llvm.org/D13510#261825, @Eugene.Zelenko wrote:
> I think it'll be fine to rename check without leaving traces of misc. Same
> thing happened with modernize-shrink-to-fit.
I think the difference here is that many C++ Core Guideline checks are...
DavidEGrayson marked an inline comment as done.
DavidEGrayson added a comment.
Well, it has been another week. John, I don't have commit access, so can you
commit this? Thanks! Let me know if the patch doesn't apply cleanly or any
tests fail.
http://reviews.llvm.org/D12793
__
On Wed, Oct 7, 2015 at 12:05 PM, Joerg Sonnenberger via cfe-commits
wrote:
> On Tue, Oct 06, 2015 at 01:31:01PM -, Aaron Ballman via cfe-commits wrote:
>> Log:
>> Add a new module for the C++ Core Guidelines, and the first checker
>> for those guidelines: cppcoreguidelines-pro-type-reinterpret
spetrovic updated this revision to Diff 36763.
http://reviews.llvm.org/D13351
Files:
include/clang/Basic/TargetInfo.h
lib/Basic/Targets.cpp
lib/CodeGen/TargetInfo.cpp
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/CodeGen/ppc-sfvarargs.c
test/Driver/ppc-features.cpp
Index: test/Drive
angelgarcia created this revision.
angelgarcia added reviewers: klimek, bkramer.
angelgarcia added subscribers: alexfh, cfe-commits.
Prevent clang-tidy from applying fixes to errors that overlap with other
errors' fixes, with one exception: if one fix is completely contained inside
another one,
Author: djasper
Date: Wed Oct 7 12:00:20 2015
New Revision: 249567
URL: http://llvm.org/viewvc/llvm-project?rev=249567&view=rev
Log:
clang-format: Add include sorting capabilities to sublime, emacs and
clang-format-diff.py.
Modified:
cfe/trunk/tools/clang-format/clang-format-diff.py
cfe/
sbenza added inline comments.
Comment at:
test/clang-tidy/cppcoreguidelines-pro-type-static-cast-downcast.cpp:28
@@ +27,3 @@
+
+ auto P0 = static_cast(new Base());
+ // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: do not use static_cast to
downcast from a base to a derived class
Eugene.Zelenko added a comment.
I think it'll be fine to rename check without leaving traces of misc. Same
thing happened with modernize-shrink-to-fit.
http://reviews.llvm.org/D13510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
dblaikie added a subscriber: dblaikie.
dblaikie accepted this revision.
dblaikie added a reviewer: dblaikie.
This revision is now accepted and ready to land.
Comment at: test/Driver/clang-g-opts.c:33
@@ -22,5 +32,3 @@
-// CHECK-WITHOUT-G-NOT: "-g"
-// CHECK-WITH-G: "-g"
-// CHEC
On Tue, Oct 06, 2015 at 01:31:01PM -, Aaron Ballman via cfe-commits wrote:
> Log:
> Add a new module for the C++ Core Guidelines, and the first checker
> for those guidelines: cppcoreguidelines-pro-type-reinterpret-cast.
I wonder about the generality of this. Does it really make sense to flag
Author: d0k
Date: Wed Oct 7 10:48:01 2015
New Revision: 249556
URL: http://llvm.org/viewvc/llvm-project?rev=249556&view=rev
Log:
[VFS] Port driver tool chains to VFS.
There are still some loose ends here but it's sufficient so we can detect
GCC headers that are inside of a VFS.
Added:
cfe/t
Author: djasper
Date: Wed Oct 7 10:09:08 2015
New Revision: 249553
URL: http://llvm.org/viewvc/llvm-project?rev=249553&view=rev
Log:
clang-format: Fixed missing space between Obj-C for/in and a typecast.
Fixes this bug: https://llvm.org/bugs/show_bug.cgi?id=24504
TokenAnnotator::spaceRequiredBe
On Tue, Oct 6, 2015 at 4:51 PM, Aaron Ballman wrote:
> On Tue, Oct 6, 2015 at 4:49 PM, Joerg Sonnenberger via cfe-commits
> wrote:
>> On Tue, Oct 06, 2015 at 04:20:05PM -0400, Aaron Ballman via cfe-commits
>> wrote:
>>> On Tue, Oct 6, 2015 at 4:12 PM, Joerg Sonnenberger via cfe-commits
>>> wrot
Author: aaronballman
Date: Wed Oct 7 10:14:10 2015
New Revision: 249555
URL: http://llvm.org/viewvc/llvm-project?rev=249555&view=rev
Log:
Loosening the restriction on variadic function definitions so that extern "C"
function definitions are permissible.
Modified:
clang-tools-extra/trunk/cla
djasper closed this revision.
djasper added a comment.
Submitted as r249553. Sorry for the delay.
http://reviews.llvm.org/D12489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
berenm added inline comments.
Comment at: unittests/Format/FormatTest.cpp:8657
@@ +8656,3 @@
+ "};\n"
+ "int i = 0;\n"
+ "auto v = type{\n"
djasper wrote:
> So, it is kind of interesting that we (would) align with a lambd
djasper closed this revision.
djasper added a comment.
Submitted as r249552.
http://reviews.llvm.org/D13513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dougk marked an inline comment as done.
dougk added a comment.
James, you're right, 'gdwarf-2' followed by 'line-tables-only' works, but the
opposite order doesn't.
So it halfway works, which is better than not working at all.
Comment at: lib/Driver/Tools.cpp:2353
@@ +2352,3 @@
Author: djasper
Date: Wed Oct 7 10:03:26 2015
New Revision: 249552
URL: http://llvm.org/viewvc/llvm-project?rev=249552&view=rev
Log:
[clang-format] Stop alignment sequences on open braces and parens when
aligning assignments.
This was done correctly when aligning the declarations, but not when
a
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good, thank you.
Comment at: unittests/Format/FormatTest.cpp:8657
@@ +8656,3 @@
+ "};\n"
+ "int i = 0;\n"
+ "auto v = type{\
seaneveson marked 4 inline comments as done.
seaneveson added a comment.
There are some issues which haven't been resolved yet:
- There is a loss of precision for loops that need to be executed exactly
maxBlockVisitOnPath times, as the loop body is executed with the widened state
**instead** of
berenm created this revision.
berenm added a reviewer: djasper.
berenm added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This was done correctly when aligning the declarations, but not when aligning
assignments.
FIXME: The code between assignments and declarations alignment is
seaneveson updated this revision to Diff 36739.
seaneveson added a comment.
Updated to latest revision.
Change patch to widen all loops which do not exit.
Changed to widen on block entrance so the guard condition is accounted for
(thanks for the suggestion).
Updated tests to reflect changes.
ht
junbuml added a comment.
Is there any comment on this change? Note that with change, I observed about 6%
performance improvement in spec2006/xalancbmk. I will address any comment to
get this in.
http://reviews.llvm.org/D13304
___
cfe-commits maili
aaron.ballman created this revision.
aaron.ballman added reviewers: Eugene.Zelenko, alexfh, mgehre, sbenza.
aaron.ballman added a subscriber: cfe-commits.
Eugene pointed out to me that our existing misc-assign-operator-signature check
was almost perfectly implementing the C++ Core Guideline guida
On Wed, Oct 7, 2015 at 9:07 AM, Daniel Jasper wrote:
> Should be fixed now. Sorry about that.
No worries, thank you for the quick fix!
~Aaron
>
> On Wed, Oct 7, 2015 at 3:00 PM, Aaron Ballman
> wrote:
>>
>> I am now getting sphinx warnings from this commit:
>>
>>
>> /opt/llvm/build-llvm/src/ll
Should be fixed now. Sorry about that.
On Wed, Oct 7, 2015 at 3:00 PM, Aaron Ballman
wrote:
> I am now getting sphinx warnings from this commit:
>
>
> /opt/llvm/build-llvm/src/llvm/tools/clang/docs/ClangFormatStyleOptions.rst:159:
> ERROR: Error in "code-block" directive:
> maximum 1 argument(s)
Author: djasper
Date: Wed Oct 7 08:02:45 2015
New Revision: 249542
URL: http://llvm.org/viewvc/llvm-project?rev=249542&view=rev
Log:
clang-format: Hopefully fix code blocks in docs.
Otherwise I will have to install sphinx ;)..
Modified:
cfe/trunk/docs/ClangFormatStyleOptions.rst
cfe/tru
I am now getting sphinx warnings from this commit:
/opt/llvm/build-llvm/src/llvm/tools/clang/docs/ClangFormatStyleOptions.rst:159:
ERROR: Error in "code-block" directive:
maximum 1 argument(s) allowed, 3 supplied.
.. code-block:: c++
someLongFunction(argument1,
argument2);
/o
pgousseau added a comment.
For some reasons the patch file I get from the "download raw diff link" does
not contain the diff for the added .keep files? But the .keep files show up in
phabricator, so I guess it is a phabricator issue?
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
On Tue, Oct 6, 2015 at 5:31 PM, Matthias Gehre wrote:
> mgehre marked 2 inline comments as done.
>
>
> Comment at:
> test/clang-tidy/cppcoreguidelines-pro-
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
On Tue, Oct 6, 2015 at 5:46 PM, Matthias Gehre wrote:
> mgehre marked an inline comment as done.
> mgehre added a comment.
>
> I cannot think of any way to improve the usefu
1 - 100 of 122 matches
Mail list logo
