[libcxx] r249372 - Add comments for LWG issues 2219 and 2367

Author: ericwf Date: Mon Oct 5 23:12:30 2015 New Revision: 249372 URL: http://llvm.org/viewvc/llvm-project?rev=249372&view=rev Log: Add comments for LWG issues 2219 and 2367 Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL: http://llvm.org/viewvc/llvm-project/l

Re: [PATCH] D13408: Skip NonNull sema checks in unevaluated contexts.

EricWF added a comment. `DiagRuntimeBehavior` seems like a better way to do this. I'll commit that change. http://reviews.llvm.org/D13408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D12747: Implement [depr.c.headers]

EricWF added a comment. I think thing change will help us close a number out outstanding bugs. I don't have any fundamental objections to this approach. However the size of this patch scares me. I understand the changes are mostly mechanical but their size can hide things. For example has an

Re: [PATCH] D13408: Skip NonNull sema checks in unevaluated contexts.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This seems reasonable. I wonder if it might be better to also suppress warnings for dynamically-unreachable code (you can do this by changing the `Diag` calls inside `CheckNonNullArguments` t

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

rsmith added inline comments. Comment at: include/clang/AST/DeclOpenMP.h:95 @@ +94,3 @@ +/// #pragma omp declare reduction (foo : int,float : omp_out += omp_in) +/// initializer (omp_priv = 0) +/// \endcode I think automatic formatting has messed up your example.

[libcxx] r249363 - Mark 2259 and 2473 as complete. Add some more notes

Author: marshall Date: Mon Oct 5 18:27:10 2015 New Revision: 249363 URL: http://llvm.org/viewvc/llvm-project?rev=249363&view=rev Log: Mark 2259 and 2473 as complete. Add some more notes Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL: http://llvm.org/viewvc/ll

[PATCH] D13453: Always generate cmake config files

hintonda created this revision. hintonda added a reviewer: chapuni. hintonda added a subscriber: cfe-commits. Always generate and install cmake config files. Currently, cmake config files are only generated and installed when CLANG_BUILD_STANDALONE set, which means config file will not be genera

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

mgehre added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeStaticCastDowncastCheck.cpp:33 @@ +32,3 @@ + const auto *SourceDecl = SourceType->getPointeeCXXRecordDecl(); + if(!SourceDecl) +SourceDecl = SourceType->getAsCXXRecordDecl(); aaron

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

mgehre updated this revision to Diff 36567. mgehre marked 2 inline comments as done. mgehre added a comment. Simplify logic to check for BaseToDerived cast. Add test for object to reference cast. Fixed comments http://reviews.llvm.org/D13368 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

Re: [PATCH] D13419: Fix several problems at the intersection of template instantiations and visibility

loladiro updated this revision to Diff 36565. loladiro added a comment. Address review comment re loop structure. Reword comment that had a typo to both fix the typo and make the intent of the code more clear. Repository: rL LLVM http://reviews.llvm.org/D13419 Files: lib/AST/Decl.cpp li

Re: [PATCH] D13444: [clang-tidy] Clocky module and multiple check from my repository

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Will be good idea to review checks one by one. Checks should be named after function, not after author. If existing categories too wide, new one could be introduced, like performance (clocky-inefficient-container

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

mgehre marked an inline comment as done. Comment at: clang-tidy/cppcoreguidelines/ProTypeStaticCastDowncastCheck.cpp:53 @@ +52,3 @@ + } else { +diag(MatchedCast->getOperatorLoc(), "do not use static_cast to cast from base class to derived class."); + } aaro

Re: [PATCH] D13386: PR24115: Don't instantiate constexpr function templates in decltype

rsmith added a comment. Sorry, this is not OK; we need to eagerly instantiate within a `decltype` expression in some cases, and we should not be treating `decltype` as being different from any other unevaluated operand here. Example: template constexpr T f() { return 0; } decltype(char{f()}

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

mgehre updated this revision to Diff 36564. mgehre added a comment. Fixed space after // http://reviews.llvm.org/D13311 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCh

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

mgehre updated this revision to Diff 36561. mgehre added a comment. "arc diff" produced a invalid patch file (due to some file being "moved"?) This patch is manually generated by git format-patch. I checked that it applies cleanly against svn trunk. http://reviews.llvm.org/D13313 Files: clan

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

mgehre updated this revision to Diff 36557. mgehre added a comment. Rebased http://reviews.llvm.org/D13313 Files: clang-tidy/CMakeLists.txt clang-tidy/Makefile clang-tidy/add_new_check.py clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyMod

Re: r249314 - [VFS] Move class out of method so it looks less like Java.

On Mon, Oct 5, 2015 at 11:13 PM, Richard Smith wrote: > On Mon, Oct 5, 2015 at 6:55 AM, Benjamin Kramer via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: d0k >> Date: Mon Oct 5 08:55:09 2015 >> New Revision: 249314 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=249314&view=

Re: [PATCH] D13304: Avoid inlining in throw statement

junbuml updated this revision to Diff 36551. junbuml added a comment. Just minor cleaning. Please let me know any comment. http://reviews.llvm.org/D13304 Files: lib/CodeGen/CGCall.cpp lib/CodeGen/CGException.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h test/CodeGe

r249355 - Remove duplicated default arguments. NFC.

Author: d0k Date: Mon Oct 5 16:20:19 2015 New Revision: 249355 URL: http://llvm.org/viewvc/llvm-project?rev=249355&view=rev Log: Remove duplicated default arguments. NFC. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp URL: http://llv

Re: [PATCH] D12747: Implement [depr.c.headers]

Marshall, I think Richard has responded to your concerns. Anything left? This is blocking some things on our end. On Wed, Sep 16, 2015 at 2:04 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Sep 14, 2015 at 7:07 AM, Marshall Clow > wrote: > >> mclow.lists added a

Re: r249314 - [VFS] Move class out of method so it looks less like Java.

On Mon, Oct 5, 2015 at 6:55 AM, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Mon Oct 5 08:55:09 2015 > New Revision: 249314 > > URL: http://llvm.org/viewvc/llvm-project?rev=249314&view=rev > Log: > [VFS] Move class out of method so it looks less like

[libcxx] r249354 - Mark 2380 and 2384 as complete; no changes needed

Author: marshall Date: Mon Oct 5 16:11:20 2015 New Revision: 249354 URL: http://llvm.org/viewvc/llvm-project?rev=249354&view=rev Log: Mark 2380 and 2384 as complete; no changes needed Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL: http://llvm.org/viewvc/llvm

[libcxx] r249352 - Patch for 2466 is ready

Author: marshall Date: Mon Oct 5 16:08:49 2015 New Revision: 249352 URL: http://llvm.org/viewvc/llvm-project?rev=249352&view=rev Log: Patch for 2466 is ready Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/www/

[libcxx] r249349 - Fixed a possible overflow in a test of allocator::max_size().

Author: marshall Date: Mon Oct 5 15:50:25 2015 New Revision: 249349 URL: http://llvm.org/viewvc/llvm-project?rev=249349&view=rev Log: Fixed a possible overflow in a test of allocator::max_size(). Modified: libcxx/trunk/test/std/utilities/memory/default.allocator/allocator.members/max_size.p

Re: [PATCH] D13419: Fix several problems at the intersection of template instantiations and visibility

rsmith added inline comments. Comment at: lib/AST/Decl.cpp:1089 @@ -1086,10 +1088,3 @@ if (const FunctionDecl *fn = dyn_cast(ND)) { -// If the function is a specialization of a template with an -// explicit visibility attribute, use that. -if (FunctionTemplateSpecia

[libcxx] r249348 - Mark a couple more issues 'ready'

Author: marshall Date: Mon Oct 5 15:35:30 2015 New Revision: 249348 URL: http://llvm.org/viewvc/llvm-project?rev=249348&view=rev Log: Mark a couple more issues 'ready' Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL: http://llvm.org/viewvc/llvm-project/libcxx/

Re: [libcxx] r249226 - [libcxx] Use newest supported language dialect when running the test suite.

Thanks for looking into this, the builder is green again! http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_check/7586/ -- adrian ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r249347 - Mark 2072 as complete; we already do this

Author: marshall Date: Mon Oct 5 15:21:54 2015 New Revision: 249347 URL: http://llvm.org/viewvc/llvm-project?rev=249347&view=rev Log: Mark 2072 as complete; we already do this Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL: http://llvm.org/viewvc/llvm-project

r249346 - Fix the MSVC build.

Author: rafael Date: Mon Oct 5 15:20:50 2015 New Revision: 249346 URL: http://llvm.org/viewvc/llvm-project?rev=249346&view=rev Log: Fix the MSVC build. No idea what asymmetry MSVC is findind. Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp Modified: cfe/trunk/unittests/Basic/

[libcxx] r249345 - Patch ready for 2127

Author: marshall Date: Mon Oct 5 15:16:30 2015 New Revision: 249345 URL: http://llvm.org/viewvc/llvm-project?rev=249345&view=rev Log: Patch ready for 2127 Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/www/kon

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

aaron.ballman closed this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Thank you for the note about checks -- I hadn't noticed that. I've fixed and committed in r249343. Thank you for the quick review! ~Aaron http://reviews.llvm.org/D13446 __

[clang-tools-extra] r249343 - Adding a checker (cert-dcl50-cpp) that detects the definition of a C-style variadic function in C++ code. Corresponds to the CERT C++ secure coding rule: https://www.secu

Author: aaronballman Date: Mon Oct 5 15:08:59 2015 New Revision: 249343 URL: http://llvm.org/viewvc/llvm-project?rev=249343&view=rev Log: Adding a checker (cert-dcl50-cpp) that detects the definition of a C-style variadic function in C++ code. Corresponds to the CERT C++ secure coding rule: htt

Re: [PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

sbenza accepted this revision. sbenza added a comment. This revision is now accepted and ready to land. See comment regarding //CHECKs Comment at: test/clang-tidy/cert-variadic-function-def.cpp:4 @@ +3,3 @@ +// Variadic function definitions are diagnosed. +// CHECK-MESSAGES: :[[

Re: r249336 - Re-introduce the unique_ptr removed in r249328 and just make

On Mon, Oct 5, 2015 at 11:54 AM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Mon Oct 5 13:54:30 2015 > New Revision: 249336 > > URL: http://llvm.org/viewvc/llvm-project?rev=249336&view=rev > Log: > Re-introduce the unique_ptr removed in r249328 and

r249342 - Revert r107690 (for PR7417) and add a testcase that it breaks. The approach of

Author: rsmith Date: Mon Oct 5 15:05:21 2015 New Revision: 249342 URL: http://llvm.org/viewvc/llvm-project?rev=249342&view=rev Log: Revert r107690 (for PR7417) and add a testcase that it breaks. The approach of that change turns out to not be reasonable: mutating the AST of a parsed template duri

r249341 - Adding an AST node matcher for NonTypeTemplateParmDecl objects.

Author: aaronballman Date: Mon Oct 5 14:44:42 2015 New Revision: 249341 URL: http://llvm.org/viewvc/llvm-project?rev=249341&view=rev Log: Adding an AST node matcher for NonTypeTemplateParmDecl objects. Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/include/clang/ASTMatch

[PATCH] D13446: [PATCH] Add checker discouraging definition of variadic function definitions in C++

aaron.ballman created this revision. aaron.ballman added reviewers: alexfh, sbenza. aaron.ballman added a subscriber: cfe-commits. C-style variadic functions (using an ellipsis) can be dangerous in C++ due to the inherit lack of type safety with argument passing. Better alternatives exist, such

Re: [PATCH] D13445: [libcxx] Reexport std::bad_array_length symbols from libc++abi on OS X.

This revision was automatically updated to reflect the committed changes. Closed by commit rL249339: [libcxx] Reexport std::bad_array_length symbols from libc++abi on OS X. (authored by EricWF). Changed prior to commit: http://reviews.llvm.org/D13445?vs=36540&id=36541#toc Repository: rL LLVM

[libcxx] r249339 - [libcxx] Reexport std::bad_array_length symbols from libc++abi on OS X.

Author: ericwf Date: Mon Oct 5 14:28:48 2015 New Revision: 249339 URL: http://llvm.org/viewvc/llvm-project?rev=249339&view=rev Log: [libcxx] Reexport std::bad_array_length symbols from libc++abi on OS X. Summary: On OS X libc++ needs to reexport libc++abi's symbols in order for them to be provi

Re: [PATCH] D13445: [libcxx] Reexport std::bad_array_length symbols from libc++abi on OS X.

EricWF updated this revision to Diff 36540. EricWF added a comment. I moved the symbols into `lib/libc++abi2.exp` since we didn't anticipate the need to exclude them. http://reviews.llvm.org/D13445 Files: lib/CMakeLists.txt lib/libc++abi2.exp Index: lib/libc++abi2.exp

Re: [PATCH] D13445: [libcxx] Reexport std::bad_array_length symbols from libc++abi on OS X.

aprantl accepted this revision. aprantl added a reviewer: aprantl. aprantl added a comment. This revision is now accepted and ready to land. Grepping through the nm output of libc++abi it looks like bad_array_length is included in Xcode 7 and Xcode 6.4, which is also what is installed on the lab

r249338 - [sanitizer] Enable lsan for AArch64

Author: azanella Date: Mon Oct 5 14:16:42 2015 New Revision: 249338 URL: http://llvm.org/viewvc/llvm-project?rev=249338&view=rev Log: [sanitizer] Enable lsan for AArch64 Modified: cfe/trunk/lib/Driver/ToolChains.cpp Modified: cfe/trunk/lib/Driver/ToolChains.cpp URL: http://llvm.org/viewvc/

r249336 - Re-introduce the unique_ptr removed in r249328 and just make

Author: adrian Date: Mon Oct 5 13:54:30 2015 New Revision: 249336 URL: http://llvm.org/viewvc/llvm-project?rev=249336&view=rev Log: Re-introduce the unique_ptr removed in r249328 and just make ~CodeGenABITypes out-of-line, which should have the same effect. Thanks to David Blaikie for pointing t

[PATCH] D13445: [libcxx] Reexport std::bad_array_length symbols from libc++abi on OS X.

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. On OS X libc++ needs to reexport libc++abi's symbols in order for them to be provided. We explicitly list the symbols to reexport it libcxx/lib/libc++abi2.exp. This patch adds the symbols

[libcxx] r249334 - Add comments about the issues

Author: marshall Date: Mon Oct 5 13:48:10 2015 New Revision: 249334 URL: http://llvm.org/viewvc/llvm-project?rev=249334&view=rev Log: Add comments about the issues Modified: libcxx/trunk/www/kona.html Modified: libcxx/trunk/www/kona.html URL: http://llvm.org/viewvc/llvm-project/libcxx/trun

Fwd: r249328 - Undo the unique_ptr'fication of CodeGenABITypes::CGM introduced in r248762.

Oops, forgot to reply-all. Sorry Adrian. -- Forwarded message -- From: David Blaikie Date: Mon, Oct 5, 2015 at 11:45 AM Subject: Re: r249328 - Undo the unique_ptr'fication of CodeGenABITypes::CGM introduced in r248762. To: Adrian Prantl On Mon, Oct 5, 2015 at 11:43 AM, David

Re: r249328 - Undo the unique_ptr'fication of CodeGenABITypes::CGM introduced in r248762.

On Mon, Oct 5, 2015 at 10:41 AM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Mon Oct 5 12:41:16 2015 > New Revision: 249328 > > URL: http://llvm.org/viewvc/llvm-project?rev=249328&view=rev > Log: > Undo the unique_ptr'fication of CodeGenABITypes::CG

[libcxx] r249333 - Private page for status of Kona issues and papers. Will be deleted after the Kona meeting. Not to be linked to from other pages.

Author: marshall Date: Mon Oct 5 13:40:13 2015 New Revision: 249333 URL: http://llvm.org/viewvc/llvm-project?rev=249333&view=rev Log: Private page for status of Kona issues and papers. Will be deleted after the Kona meeting. Not to be linked to from other pages. Added: libcxx/trunk/www/kona

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

On Mon, Oct 5, 2015 at 11:37 AM, David Blaikie wrote: > > > On Mon, Oct 5, 2015 at 8:55 AM, Adrian Prantl wrote: > >> >> On Oct 2, 2015, at 3:24 PM, David Blaikie wrote: >> >> >> >> On Fri, Oct 2, 2015 at 3:21 PM, Adrian Prantl wrote: >> >>> >>> On Oct 2, 2015, at 3:01 PM, David Blaikie wrote

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

On Mon, Oct 5, 2015 at 8:55 AM, Adrian Prantl wrote: > > On Oct 2, 2015, at 3:24 PM, David Blaikie wrote: > > > > On Fri, Oct 2, 2015 at 3:21 PM, Adrian Prantl wrote: > >> >> On Oct 2, 2015, at 3:01 PM, David Blaikie wrote: >> >> >> >> On Fri, Oct 2, 2015 at 3:00 PM, Adrian Prantl wrote: >> >

Re: [PATCH] D13399: [CMake] Bug 14109 - CMake build for compiler-rt should use just-built clang

beanz added a comment. probinson, Not by itself, but this could be used as a step in that direction. The `CLANG_COMPILER_RT_CMAKE_ARGS` variable can be used to configure how compiler-rt is built with a great deal of flexibility, but the goal of this patch is to try and closely match how compil

Re: [PATCH] D13221: Make CompilerInvocation's use of the debug options more understandable.

On Mon, Oct 5, 2015 at 8:37 AM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > aprantl added a comment. > > Some bikeshedding about -di-kind={full|limited|line-tables}: > > 1. Is there a good reason not to spell out -debug-info-kind? > 2. "full" is misleading as it will still

Re: [PATCH] D13399: [CMake] Bug 14109 - CMake build for compiler-rt should use just-built clang

probinson added a subscriber: probinson. probinson added a comment. I'm a CMake ignoramus but functionally if I'm building a Clang cross-compiler, I'd want a cross-built compiler-rt but not run its tests even if LLVM_INCLUDE_TESTS is on. Does that make sense? If so, does this change make that

Re: [PATCH] D13134: [analyzer] Add keyboard shortcuts to report.html

dcoughlin added a comment. Thanks for the update. Unfortunately, we can't accept the mousetrap code. Any code contributed to clang needs to be under the UIUC license. The original copyright owner would need to contribute the code under that license. I think it would be fine to revert to your p

Re: [PATCH] D13399: [CMake] Bug 14109 - CMake build for compiler-rt should use just-built clang

beanz updated this revision to Diff 36532. beanz added a comment. - Cleanup based on feedback from samsonov http://reviews.llvm.org/D13399 Files: runtime/CMakeLists.txt Index: runtime/CMakeLists.txt === --- runtime/CMakeLists.tx

Re: [PATCH] D13318: Add a utility function to add target information to a command line

zarko updated this revision to Diff 36529. zarko added a comment. Copy a dependency from a test Makefile to its CMakeLists. http://reviews.llvm.org/D13318 Files: include/clang/Tooling/Tooling.h lib/Tooling/Tooling.cpp unittests/Tooling/CMakeLists.txt unittests/Tooling/ToolingTest.cpp I

Re: [PATCH] D13318: Add a utility function to add target information to a command line

zarko added a comment. I'd tested with the Makefile; it looks like CMakeLists for the unit tests isn't linking `${LLVM_TARGETS_TO_BUILD}`. I've updated the diff. http://reviews.llvm.org/D13318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13399: [CMake] Bug 14109 - CMake build for compiler-rt should use just-built clang

beanz added a comment. I will send updated patches shortly. Comments inline below. Comment at: runtime/CMakeLists.txt:33 @@ -32,1 +32,3 @@ + ) +set(cmake_3_4_USES_TERMINAL USES_TERMINAL 1) endif() samsonov wrote: > Should this also be named cmake_3_

r249328 - Undo the unique_ptr'fication of CodeGenABITypes::CGM introduced in r248762.

Author: adrian Date: Mon Oct 5 12:41:16 2015 New Revision: 249328 URL: http://llvm.org/viewvc/llvm-project?rev=249328&view=rev Log: Undo the unique_ptr'fication of CodeGenABITypes::CGM introduced in r248762. include/clang/CodeGenABITypes.h is in meant to be included by external users, but using a

Re: [PATCH] D13399: [CMake] Bug 14109 - CMake build for compiler-rt should use just-built clang

samsonov added inline comments. Comment at: runtime/CMakeLists.txt:33 @@ -32,1 +32,3 @@ + ) +set(cmake_3_4_USES_TERMINAL USES_TERMINAL 1) endif() Should this also be named cmake_3_4_USES_TERMINAL_OPTIONS? Comment at: runtime/CMakeList

[libcxx] r249325 - Implement LWG#2063, and update the issues links to point to the github generated pages

Author: marshall Date: Mon Oct 5 11:17:34 2015 New Revision: 249325 URL: http://llvm.org/viewvc/llvm-project?rev=249325&view=rev Log: Implement LWG#2063, and update the issues links to point to the github generated pages Modified: libcxx/trunk/include/string libcxx/trunk/test/std/strin

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

sbenza added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp:35 @@ +34,3 @@ + + //Array subscript on a pointer (not an array) is also pointer arithmetic + Finder->addMatcher( Space after // Comment

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

> On Oct 2, 2015, at 3:24 PM, David Blaikie wrote: > > > > On Fri, Oct 2, 2015 at 3:21 PM, Adrian Prantl > wrote: > >> On Oct 2, 2015, at 3:01 PM, David Blaikie > > wrote: >> >> >> >> On Fri, Oct 2, 2015 at 3:00 PM, Adrian Prantl >

Re: [PATCH] D13221: Make CompilerInvocation's use of the debug options more understandable.

aprantl added a comment. Some bikeshedding about -di-kind={full|limited|line-tables}: 1. Is there a good reason not to spell out -debug-info-kind? 2. "full" is misleading as it will still only emit debug info for types actually used by the program. I think "standalone" would be more descriptive.

Re: r249316 - [VFS] Add working directories to every virtual file system.

Never mind. My llvm and clang trees were out of sync. Diego. On Mon, Oct 5, 2015 at 11:15 AM, Diego Novillo wrote: > > > On Mon, Oct 5, 2015 at 9:55 AM, Benjamin Kramer via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: d0k >> Date: Mon Oct 5 08:55:20 2015 >> New Revision: 2

Re: r249316 - [VFS] Add working directories to every virtual file system.

On Mon, Oct 5, 2015 at 9:55 AM, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Mon Oct 5 08:55:20 2015 > New Revision: 249316 > > URL: http://llvm.org/viewvc/llvm-project?rev=249316&view=rev > Log: > [VFS] Add working directories to every virtual file s

Re: r249321 - Adding a narrowing AST matcher for FunctionDecl::isVariadic(), plus tests and documentation.

On 5 October 2015 at 15:51, Aaron Ballman wrote: > On Mon, Oct 5, 2015 at 10:49 AM, mats petersson > wrote: > > > > > > On 5 October 2015 at 15:41, Aaron Ballman via cfe-commits > > wrote: > >> > >> Author: aaronballman > >> Date: Mon Oct 5 09:41:27 2015 > >> New Revision: 249321 > >> > >> URL

Re: r249321 - Adding a narrowing AST matcher for FunctionDecl::isVariadic(), plus tests and documentation.

On Mon, Oct 5, 2015 at 10:49 AM, mats petersson wrote: > > > On 5 October 2015 at 15:41, Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Mon Oct 5 09:41:27 2015 >> New Revision: 249321 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=249321&view=rev >> Log: >> Adding

Re: r249321 - Adding a narrowing AST matcher for FunctionDecl::isVariadic(), plus tests and documentation.

On 5 October 2015 at 15:41, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Mon Oct 5 09:41:27 2015 > New Revision: 249321 > > URL: http://llvm.org/viewvc/llvm-project?rev=249321&view=rev > Log: > Adding a narrowing AST matcher for FunctionDecl::i

r249321 - Adding a narrowing AST matcher for FunctionDecl::isVariadic(), plus tests and documentation.

Author: aaronballman Date: Mon Oct 5 09:41:27 2015 New Revision: 249321 URL: http://llvm.org/viewvc/llvm-project?rev=249321&view=rev Log: Adding a narrowing AST matcher for FunctionDecl::isVariadic(), plus tests and documentation. Modified: cfe/trunk/docs/LibASTMatchersReference.html cf

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeStaticCastDowncastCheck.cpp:33 @@ +32,3 @@ + const auto *SourceDecl = SourceType->getPointeeCXXRecordDecl(); + if(!SourceDecl) +SourceDecl = SourceType->getAsCXXRecordDecl(); ---

Re: [PATCH] D13317: clang_Cursor_getMangling shouldn't mangle if the declaration isn't mangled

michaelwu updated this revision to Diff 36518. michaelwu added a comment. This uses clang_isInvalid in PrintMangledName instead of checking for CXCursor_UnexposedDecl. http://reviews.llvm.org/D13317 Files: test/Index/print-mangled-name.cpp tools/c-index-test/c-index-test.c tools/libclang

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

jroelofs added a comment. Design doc looks good! I think it captures all the design constraints well, and the proposed solution satisfies those constraints as far as I am concerned. Thumbs up from me... but I'll still defer the final 'LGTM' to @mclow.lists. http://reviews.llvm.org/D13407 __

Re: [PATCH] D13317: clang_Cursor_getMangling shouldn't mangle if the declaration isn't mangled

michaelwu marked 2 inline comments as done. michaelwu added a comment. http://reviews.llvm.org/D13317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r249319 - [VFS] Fix the windows build by including the right headers.

Author: d0k Date: Mon Oct 5 09:06:36 2015 New Revision: 249319 URL: http://llvm.org/viewvc/llvm-project?rev=249319&view=rev Log: [VFS] Fix the windows build by including the right headers. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cp

Re: [PATCH] D13398: [clang-tidy] add check cppcoreguidelines-pro-type-const-cast

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, despite being bizarrely restrictive guidance. ~Aaron http://reviews.llvm.org/D13398 ___ cfe-commits mailing list cfe-commits

r249318 - [VFS] Fix compilation on systems where time_t is not int64_t.

Author: d0k Date: Mon Oct 5 09:02:15 2015 New Revision: 249318 URL: http://llvm.org/viewvc/llvm-project?rev=249318&view=rev Log: [VFS] Fix compilation on systems where time_t is not int64_t. No functional change intended. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified: cfe/tr

Re: [PATCH] D13430: [VFS] Add an in-memory file system implementation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL249316: [VFS] Add working directories to every virtual file system. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D13430?vs=36509&id=36515#toc Repository: rL LLVM http://review

r249315 - [VFS] Add an in-memory file system implementation.

Author: d0k Date: Mon Oct 5 08:55:14 2015 New Revision: 249315 URL: http://llvm.org/viewvc/llvm-project?rev=249315&view=rev Log: [VFS] Add an in-memory file system implementation. This is a simple file system tree of memory buffers that can be filled by a client. In conjunction with an OverlayFS

r249316 - [VFS] Add working directories to every virtual file system.

Author: d0k Date: Mon Oct 5 08:55:20 2015 New Revision: 249316 URL: http://llvm.org/viewvc/llvm-project?rev=249316&view=rev Log: [VFS] Add working directories to every virtual file system. For RealFileSystem this is getcwd()/chdir(), the synthetic file systems can make up one for themselves. Ove

r249314 - [VFS] Move class out of method so it looks less like Java.

Author: d0k Date: Mon Oct 5 08:55:09 2015 New Revision: 249314 URL: http://llvm.org/viewvc/llvm-project?rev=249314&view=rev Log: [VFS] Move class out of method so it looks less like Java. No functionality change. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified: cfe/trunk/lib/B

Re: [PATCH] D13430: [VFS] Add an in-memory file system implementation.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Basic/VirtualFileSystem.cpp:1263-1265 @@ -957,5 +1262,5 @@ if (!F->useExternalName(UseExternalNames)) { // Provide a file wrapper that returns the

r249312 - clang-format: Small doc fix.

Author: djasper Date: Mon Oct 5 08:30:42 2015 New Revision: 249312 URL: http://llvm.org/viewvc/llvm-project?rev=249312&view=rev Log: clang-format: Small doc fix. Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst URL: http://llvm.org/v

Re: [PATCH] D13430: [VFS] Add an in-memory file system implementation.

bkramer marked 10 inline comments as done. Comment at: include/clang/Basic/VirtualFileSystem.h:286-288 @@ +285,5 @@ + } + std::error_code setCurrentWorkingDirectory(const Twine &Path) override { +WorkingDirectory = Path.str(); +return std::error_code(); + }

Re: [PATCH] D13430: [VFS] Add an in-memory file system implementation.

bkramer updated this revision to Diff 36509. bkramer added a comment. Rebased and addressed review comments. http://reviews.llvm.org/D13430 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp unittests/Basic/VirtualFileSystemTest.cpp unittests/Tooling/Rewriter

r249310 - [VFS] Remove setName from the file interface.

Author: d0k Date: Mon Oct 5 08:15:33 2015 New Revision: 249310 URL: http://llvm.org/viewvc/llvm-project?rev=249310&view=rev Log: [VFS] Remove setName from the file interface. This streamlines the interface a bit and makes Status more immutable. No functional change intended. Modified: cfe/t

r249308 - The Driver does not set the +strict-align flag when targeting

Author: alelab01 Date: Mon Oct 5 07:45:10 2015 New Revision: 249308 URL: http://llvm.org/viewvc/llvm-project?rev=249308&view=rev Log: The Driver does not set the +strict-align flag when targeting [ARM] armv6m + netbsd. Tests are misssing for armv6m + darwin as well. Differential Revision: http:/

Re: [PATCH] D13217: [ARM] The Driver does not set the +strict-align flag when targeting armv6m + netbsd

This revision was automatically updated to reflect the committed changes. Closed by commit rL249308: The Driver does not set the +strict-align flag when targeting (authored by alelab01). Changed prior to commit: http://reviews.llvm.org/D13217?vs=35883&id=36507#toc Repository: rL LLVM http:/

Re: [PATCH] D13192: Fix incorrect parsing of arguments for nested functions

arseny.kapoulkine added a comment. Ping. http://reviews.llvm.org/D13192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13134: [analyzer] Add keyboard shortcuts to report.html

skomski removed rL LLVM as the repository for this revision. skomski updated this revision to Diff 36490. skomski added a comment. Included mousetrap to get keyboard shortcuts working on all international keyboards. Fixed behaviour without hash path present: Jump to #Path1 on j or k http://revi

r249306 - [mips][p5600] Add -mcpu=p5600 option.

Author: dsanders Date: Mon Oct 5 07:24:30 2015 New Revision: 249306 URL: http://llvm.org/viewvc/llvm-project?rev=249306&view=rev Log: [mips][p5600] Add -mcpu=p5600 option. Summary: Reviewers: vkalintiris, atanasyan Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D12234

[clang-tools-extra] r249305 - Use better mocks in modernize-make-unique, and fix matcher.

Author: angelgarcia Date: Mon Oct 5 07:20:17 2015 New Revision: 249305 URL: http://llvm.org/viewvc/llvm-project?rev=249305&view=rev Log: Use better mocks in modernize-make-unique, and fix matcher. Summary: Add the second template argument to the unique_ptr mock, and update the matcher so that i

Re: [PATCH] D13433: Use better mocks in modernize-make-unique, and fix matcher.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D13433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D13433: Use better mocks in modernize-make-unique, and fix matcher.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: cfe-commits, alexfh. Add the second template argument to the unique_ptr mock, and update the matcher so that it only matches against cases where the second argument is the default. http://revi

r249302 - Use llvm::errc instead of std::errc.

Author: rafael Date: Mon Oct 5 06:49:35 2015 New Revision: 249302 URL: http://llvm.org/viewvc/llvm-project?rev=249302&view=rev Log: Use llvm::errc instead of std::errc. Modified: cfe/trunk/lib/Frontend/CompilerInstance.cpp Modified: cfe/trunk/lib/Frontend/CompilerInstance.cpp URL: http://l

RE: [Patch][OpenCL] Custom atomic Builtin check ignores address space of a non-atomic pointer

Thanks! Yes, I agree it might make sense to drop the default AS parameter value in getPointerTo(). It doesn't seem like there is an enormous amount of places that need to be changed! Cheers, Anastasia -Original Message- From: Pekka Jääskeläinen [mailto:pekka.jaaskelai...@tut.fi] Sent

Re: [PATCH] D13203: [Clang] - Massaging code to fix MSVS 2015 win32-release configuration

klimek added a comment. Note: with VS Professional 14.0.23107.0 D14REL I do not get this error. http://reviews.llvm.org/D13203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r249301 - [OpenCL] Fix casting a true boolean to an integer vector.

Author: stulova Date: Mon Oct 5 06:27:41 2015 New Revision: 249301 URL: http://llvm.org/viewvc/llvm-project?rev=249301&view=rev Log: [OpenCL] Fix casting a true boolean to an integer vector. OpenCL v1.1 s6.2.2: for the boolean value true, every bit in the result vector should be set. This chan

Re: [PATCH] D13430: [VFS] Add an in-memory file system implementation.

klimek added inline comments. Comment at: include/clang/Basic/VirtualFileSystem.h:286-288 @@ +285,5 @@ + } + std::error_code setCurrentWorkingDirectory(const Twine &Path) override { +WorkingDirectory = Path.str(); +return std::error_code(); + } Return e

Re: [PATCH] D13168: [OpenCL] OpenCL2.0 - Apply default address space rules

Anastasia added inline comments. Comment at: lib/Sema/SemaType.cpp:6282 @@ +6281,3 @@ +} else if (state.getCurrentChunkIndex() == 0 && + D.getContext() == Declarator::FileContext && + !D.isFunctionDeclarator() && !D.isFunctionDefinition() && ---

  1   2   >