r249229 - try to fix the ARM self host bots

Author: compnerd Date: Sat Oct 3 01:37:38 2015 New Revision: 249229 URL: http://llvm.org/viewvc/llvm-project?rev=249229&view=rev Log: try to fix the ARM self host bots The default target is ARM on the ARM self host bots. This is problematic since the behaviour on x86, x64 is different from ARM.

Re: [PATCH] D12854: [SourceManager] Support buffers that are not null-terminated

loladiro abandoned this revision. loladiro added a comment. Oh, I see it checks for the null terminator past the end of the given memory block on construction, but if the memory after changes later this just keeps running. Well, that's quite a trap, but I guess that's what you get for not under

Re: [PATCH] D12854: [SourceManager] Support buffers that are not null-terminated

loladiro added a comment. Hmm, you're right. And I am actually constructing it in such a way that it's supposed to have it, so I wonder why it ran off the rails here. Will take another look. Repository: rL LLVM http://reviews.llvm.org/D12854 __

r249228 - Replace double-negated !SourceLocation.isInvalid() with SourceLocation.isValid().

Author: yrnkrn Date: Sat Oct 3 00:15:57 2015 New Revision: 249228 URL: http://llvm.org/viewvc/llvm-project?rev=249228&view=rev Log: Replace double-negated !SourceLocation.isInvalid() with SourceLocation.isValid(). Modified: cfe/trunk/lib/ARCMigrate/ObjCMT.cpp cfe/trunk/lib/AST/TypeLoc.

r249227 - Driver: follow WoA ABI recommendations

Author: compnerd Date: Fri Oct 2 22:39:28 2015 New Revision: 249227 URL: http://llvm.org/viewvc/llvm-project?rev=249227&view=rev Log: Driver: follow WoA ABI recommendations The Windows on ARM ABI recommends that FPO be disabled. This is since the Windows on ARM ABI uses the FP for fast stack wa

Re: [PATCH] D11908: Clang support for -fthinlto.

> On 2015-Oct-02, at 08:59, Teresa Johnson wrote: > > On Fri, Oct 2, 2015 at 8:53 AM, Manuel Klimek wrote: >> klimek added a comment. >> >> In http://reviews.llvm.org/D11908#258570, @tejohnson wrote: >> >>> Sorry for the duplicate - my previous response didn't go to Duncan or Mehdi >>> for s

Re: r248953 - [Sema] Don't crash when friending an unqualified templated constructor

On Wed, Sep 30, 2015 at 3:07 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: majnemer > Date: Wed Sep 30 17:07:43 2015 > New Revision: 248953 > > URL: http://llvm.org/viewvc/llvm-project?rev=248953&view=rev > Log: > [Sema] Don't crash when friending an unqualified

Re: [PATCH] D12502: [libcxx] Better constain tuples constructors -- Fix PR23256 and PR22806

eugenis added a comment. FYI, I ran some tests and did not find any regressions and also confirmed that this change fixes the problem PR23256 was minimized from. Thanks for working on this! http://reviews.llvm.org/D12502 ___ cfe-commits mailing lis

Re: [PATCH] D13331: [libcxx] Use newest supported language dialect when running the test suite.

mclow.lists added a comment. Works for me. Now we need to do the same for clang. http://reviews.llvm.org/D13331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

EricWF abandoned this revision. EricWF added a comment. Abandoning in favor of http://reviews.llvm.org/D13407. http://reviews.llvm.org/D11963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF added subscribers: eugenis, asl, espositofulvio, ed. EricWF added a comment. Adding subscribes from the old patch to this one. http://reviews.llvm.org/D13407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[libcxx] r249226 - [libcxx] Use newest supported language dialect when running the test suite.

Author: ericwf Date: Fri Oct 2 21:32:23 2015 New Revision: 249226 URL: http://llvm.org/viewvc/llvm-project?rev=249226&view=rev Log: [libcxx] Use newest supported language dialect when running the test suite. Summary: Currently the test suite defaults to C++11 mode if no standard version is supp

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF added a comment. Oh, but don't review the design doc too closely. I'm still working on it. http://reviews.llvm.org/D13407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13217: [ARM] The Driver does not set the +strict-align flag when targeting armv6m + netbsd

labrinea added inline comments. Comment at: lib/Basic/Targets.cpp:4456 @@ -4455,3 +4455,1 @@ -if (ArchVersion < 6 || - (ArchVersion == 6 && ArchProfile == llvm::ARM::PK_M)) rengolin wrote: > Why is this not necessary any more? The logic is still nece

[PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

EricWF created this revision. EricWF added reviewers: mclow.lists, danalbert, jroelofs. EricWF added a subscriber: cfe-commits. Hi all, This patch is a successor to D11963. However it has changed dramatically and I felt it would be best to start a new review thread. Please read the design docum

Re: [libcxx] r248313 - Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

On Fri, Oct 2, 2015 at 1:58 PM, Eric Fiselier wrote: > Hi Tom, > > I would like this patch merged into 3.7.1. > Marshall can you please approve this? > Looks fine to me. -- Marshall > > /Eric > > On Tue, Sep 22, 2015 at 12:55 PM, Dimitry Andric via cfe-commits > wrote: > > Author: dim > > Da

Re: [PATCH] D13373: Emiting invariant.group.barrier for ctors bugfix

Thank you! On Fri, Oct 2, 2015 at 5:54 PM, NAKAMURA Takumi wrote: > chapuni added a subscriber: chapuni. > > > Comment at: test/CodeGenCXX/strict-vtable-pointers.cpp:145 > @@ +144,3 @@ > +// CHECK-CTORS: %[[THIS3:.*]] = bitcast i8* %[[THIS2]] to > %[[DynamicDerived]]* > +// CHEC

Re: [PATCH] D13221: Make CompilerInvocation's use of the debug options more understandable.

jyknight added a comment. This certainly seems a big improvement. However, I don't think that you actually fixed specifying both -gline-tables-only and a Dwarf version, because that requires actually handling multiple options from g_group, instead of just the last one. E.g. "-gdwarf-2 -g1" sho

[PATCH] D13406: [Clang] Fix Clang-tidy modernize-use-nullptr warnings in source directories; other minor cleanups.

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hans. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Please check it in if it's OK, because

Re: [PATCH] D13373: Emiting invariant.group.barrier for ctors bugfix

chapuni added a subscriber: chapuni. Comment at: test/CodeGenCXX/strict-vtable-pointers.cpp:145 @@ +144,3 @@ +// CHECK-CTORS: %[[THIS3:.*]] = bitcast i8* %[[THIS2]] to %[[DynamicDerived]]* +// CHECK-CTORS: %[[THIS4:.*]] = bitcast %[[DynamicDerived]]* %2 to %[[DynamicBase:.*]]* +/

r249223 - Fix clang/test/CodeGenCXX/strict-vtable-pointers.cpp for -Asserts. It missed something. :)

Author: chapuni Date: Fri Oct 2 19:50:12 2015 New Revision: 249223 URL: http://llvm.org/viewvc/llvm-project?rev=249223&view=rev Log: Fix clang/test/CodeGenCXX/strict-vtable-pointers.cpp for -Asserts. It missed something. :) Modified: cfe/trunk/test/CodeGenCXX/strict-vtable-pointers.cpp Mod

Re: [PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

sfantao updated this revision to Diff 36410. sfantao added a comment. Fix bug for when no offloading triples are specified. http://reviews.llvm.org/D12614 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Basic/LangOptions.def include/clang/Basic/LangOptions.h include/cl

r249215 - [libFuzzer] make LLVMFuzzerTestOneInput (the fuzzer target function) return int instead of void. (following llvm r249214)

Author: kcc Date: Fri Oct 2 18:34:37 2015 New Revision: 249215 URL: http://llvm.org/viewvc/llvm-project?rev=249215&view=rev Log: [libFuzzer] make LLVMFuzzerTestOneInput (the fuzzer target function) return int instead of void. (following llvm r249214) Modified: cfe/trunk/tools/clang-format/f

Re: [PATCH] D13221: Make CompilerInvocation's use of the debug options more understandable.

dougk added a comment. A few more remarks: - The code which emits line-tables-only seems to understand dwarf2 versus dwarf4, but due solely to the way that arguments were parsed, the dwarf version did not propagate through to the compiler invocation if you also specified line-tables-only. The

Re: [PATCH] D7297: [clang][Headers] _mm_stream_load_si128 should accept const arguments.

ab closed this revision. ab added a comment. Stumbled upon this while looking for the intel guide! Fixed in r249213. http://reviews.llvm.org/D7297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

r249213 - [Headers][X86] Fix stream_load (movntdqa) to accept const*.

Author: ab Date: Fri Oct 2 18:29:26 2015 New Revision: 249213 URL: http://llvm.org/viewvc/llvm-project?rev=249213&view=rev Log: [Headers][X86] Fix stream_load (movntdqa) to accept const*. Per Intel intrinsics guide: - _mm256_stream_load_si256 takes `__m256i const *' - _mm_stream_load_si128 takes

[PATCH] D13398: [clang-tidy] add check cppcoreguidelines-pro-type-const-cast

mgehre created this revision. mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman. mgehre added a subscriber: cfe-commits. mgehre added a dependency: D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast. This check flags all uses of const_cast in C++ code. Modify

r249205 - Don't nil check non-nil class receiver of AArch64 stret calls.

Author: ab Date: Fri Oct 2 17:41:59 2015 New Revision: 249205 URL: http://llvm.org/viewvc/llvm-project?rev=249205&view=rev Log: Don't nil check non-nil class receiver of AArch64 stret calls. I randomly came across this difference between AArch64 and other targets: on the latter, we don't emit ni

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

mgehre updated this revision to Diff 36404. mgehre added a comment. Fix typo http://reviews.llvm.org/D13311 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp cl

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

mgehre added a comment. Thank you for the review comments! Comment at: clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp:38 @@ +37,3 @@ + Finder->addMatcher( + arraySubscriptExpr(hasBase(implicitCastExpr(hasSourceExpression( + has

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

mgehre updated this revision to Diff 36403. mgehre marked 7 inline comments as done. mgehre added a comment. Incorporated comments Simplied matcher: Instead of checking argument types, just check that the result of the arithmetic operation is a pointer http://reviews.llvm.org/D13311 Files: c

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

On Fri, Oct 2, 2015 at 3:21 PM, Adrian Prantl wrote: > > On Oct 2, 2015, at 3:01 PM, David Blaikie wrote: > > > > On Fri, Oct 2, 2015 at 3:00 PM, Adrian Prantl wrote: > >> >> On Oct 2, 2015, at 2:58 PM, David Blaikie wrote: >> >> >> >> On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl wrote: >> >

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

> On Oct 2, 2015, at 3:01 PM, David Blaikie wrote: > > > > On Fri, Oct 2, 2015 at 3:00 PM, Adrian Prantl > wrote: > >> On Oct 2, 2015, at 2:58 PM, David Blaikie > > wrote: >> >> >> >> On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl >

Re: [PATCH] D13331: [libcxx] Use newest supported language dialect when running the test suite.

danalbert accepted this revision. danalbert added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D13331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

r249197 - Emiting invariant.group.barrier for ctors bugfix

Author: prazek Date: Fri Oct 2 17:12:40 2015 New Revision: 249197 URL: http://llvm.org/viewvc/llvm-project?rev=249197&view=rev Log: Emiting invariant.group.barrier for ctors bugfix Ensure that the vptr store in the most-derived constructor is not behind an invariant group barrier. Previously, th

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

djasper added a comment. No. I really don't want to have these two completely independent flags, so the patch needs changes, before it can go in. http://reviews.llvm.org/D10370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

On Fri, Oct 2, 2015 at 3:00 PM, Adrian Prantl wrote: > > On Oct 2, 2015, at 2:58 PM, David Blaikie wrote: > > > > On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl wrote: > >> >> On Oct 2, 2015, at 2:18 PM, David Blaikie wrote: >> >> This seems a little curious, so you'll have code like this: >> >

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

> On Oct 2, 2015, at 2:58 PM, David Blaikie wrote: > > > > On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl > wrote: > >> On Oct 2, 2015, at 2:18 PM, David Blaikie > > wrote: >> >> This seems a little curious, so you'll have code like this:

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl wrote: > > On Oct 2, 2015, at 2:18 PM, David Blaikie wrote: > > This seems a little curious, so you'll have code like this: > > decl foo > module > def bar >member foo pointer (references the declaration of foo outside the > module, i

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

On Fri, Oct 2, 2015 at 5:27 PM, Matthias Gehre wrote: > mgehre added a comment. > > I'm not sure what you mean by ToT. I rebased this against master @ > http://llvm.org/git/clang-tools-extra.git Top of Tree from the svn repository. I'm not certain how quickly the git mirror updates, but when I d

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

> On Oct 2, 2015, at 2:18 PM, David Blaikie wrote: > > This seems a little curious, so you'll have code like this: > > decl foo > module > def bar >member foo pointer (references the declaration of foo outside the > module, in the CU?) > Right. > Why is that preferable to DW

Re: Question about FunctionDecl::isVariadic()

On Fri, Oct 2, 2015 at 5:22 PM, mats petersson wrote: > > > On 2 October 2015 at 22:07, Aaron Ballman wrote: >> >> On Fri, Oct 2, 2015 at 4:01 PM, mats petersson >> wrote: >> > Since "varargs" often involve some kind of special passing mechanisms >> > [I've >> > seen implementations that build d

[libcxx] r249192 - [libcxx] Attempt to fix __throw_future_error in C++03

Author: ericwf Date: Fri Oct 2 16:25:15 2015 New Revision: 249192 URL: http://llvm.org/viewvc/llvm-project?rev=249192&view=rev Log: [libcxx] Attempt to fix __throw_future_error in C++03 Summary: Hi Marshall, Could you please test this patch and see if you run into the same linker errors we ta

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

mgehre added a comment. I'm not sure what you mean by ToT. I rebased this against master @ http://llvm.org/git/clang-tools-extra.git http://reviews.llvm.org/D13313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

mgehre updated this revision to Diff 36399. mgehre added a comment. rebased http://reviews.llvm.org/D13313 Files: clang-tidy/CMakeLists.txt clang-tidy/Makefile clang-tidy/add_new_check.py clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyMod

Re: Question about FunctionDecl::isVariadic()

On 2 October 2015 at 22:07, Aaron Ballman wrote: > On Fri, Oct 2, 2015 at 4:01 PM, mats petersson > wrote: > > Since "varargs" often involve some kind of special passing mechanisms > [I've > > seen implementations that build data block and pass a pointer to that, > > rather than passing on the s

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

This seems a little curious, so you'll have code like this: decl foo module def bar member foo pointer (references the declaration of foo outside the module, in the CU?) Why is that preferable to DWARF that looks more like the AST where the declaration of foo appears in the first m

Re: [PATCH] D13337: [libcxx] Attempt to fix __throw_future_error in C++03

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. I can't reproduce the error that I was getting. http://reviews.llvm.org/D13337 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D13157: Teach -Wtautological-overlap-compare about enums

On Fri, Oct 2, 2015 at 6:10 AM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Oct 1, 2015 at 5:18 PM, Richard Trieu wrote: > > I'm in favor of keeping the asserts around. Several times, I've seen > Clang > > crashers than languish in the bug tracker with an assert

Re: Question about FunctionDecl::isVariadic()

On Fri, Oct 2, 2015 at 4:01 PM, mats petersson wrote: > Since "varargs" often involve some kind of special passing mechanisms [I've > seen implementations that build data block and pass a pointer to that, > rather than passing on the stack, for example], or additional code in the > recipient funct

Re: [libcxx] r248313 - Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

Hi Tom, I would like this patch merged into 3.7.1. Marshall can you please approve this? /Eric On Tue, Sep 22, 2015 at 12:55 PM, Dimitry Andric via cfe-commits wrote: > Author: dim > Date: Tue Sep 22 13:55:37 2015 > New Revision: 248313 > > URL: http://llvm.org/viewvc/llvm-project?rev=248313&vi

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

dawn added a subscriber: dawn. dawn added a comment. Can someone please accept and commit this patch so we can use this feature? Thanks. http://reviews.llvm.org/D10370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

r249179 - [WebAssembly] Add a __builtin_wasm_resize_memory() intrinsic.

Author: djg Date: Fri Oct 2 15:20:01 2015 New Revision: 249179 URL: http://llvm.org/viewvc/llvm-project?rev=249179&view=rev Log: [WebAssembly] Add a __builtin_wasm_resize_memory() intrinsic. Modified: cfe/trunk/include/clang/Basic/BuiltinsWebAssembly.def cfe/trunk/lib/CodeGen/CGBuiltin.c

Re: Question about FunctionDecl::isVariadic()

Since "varargs" often involve some kind of special passing mechanisms [I've seen implementations that build data block and pass a pointer to that, rather than passing on the stack, for example], or additional code in the recipient function, I would say that `f2()` does not mean `f2(...)`. -- Mats

r249176 - [WebAssembly] Add a __builtin_wasm_memory_size() intrinsic.

Author: djg Date: Fri Oct 2 14:38:47 2015 New Revision: 249176 URL: http://llvm.org/viewvc/llvm-project?rev=249176&view=rev Log: [WebAssembly] Add a __builtin_wasm_memory_size() intrinsic. Modified: cfe/trunk/include/clang/Basic/BuiltinsWebAssembly.def cfe/trunk/lib/CodeGen/CGBuiltin.cpp

Question about FunctionDecl::isVariadic()

Given the following two function declarations: void f1(...); void f2(); It makes sense to me that isVariadic() returns true for f1 in both C and C++. It makes sense to me that isVariadic() returns false for f2 in C++. I am confused as to why it returns false instead of true for C, however. In C1

Re: [PATCH] D12508: [libcxx] Make it drastically simpler to link libc++.

EricWF added a comment. @mclow.lists ping. Do you think this is the right approach to fix linking the ABI library? @rsmith: I think you asked for this functionality a while ago. Any thoughts? http://reviews.llvm.org/D12508 ___ cfe-commits mailing l

r249166 - [Myriad]: Accept '-nostdlib' option

Author: dougk Date: Fri Oct 2 13:39:08 2015 New Revision: 249166 URL: http://llvm.org/viewvc/llvm-project?rev=249166&view=rev Log: [Myriad]: Accept '-nostdlib' option Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/myriad-toolchain.c Modified: cfe/trunk/lib/Driver/Tools.c

Re: [PATCH] D13373: Emiting invariant.group.barrier for ctors bugfix

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, but your commit message should be more descriptive than your current summary. Something like: Ensure that the vptr store in the most-derived constructor is not behind an invariant group

Re: [PATCH] D13373: Emiting invariant.group.barrier for ctors bugfix

Prazek updated the summary for this revision. Prazek updated this revision to Diff 36382. Prazek marked an inline comment as done. http://reviews.llvm.org/D13373 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/invariant.group-for-vptrs.cpp test/CodeGenCXX/strict-vtable-pointers.cpp Index: t

Re: [PATCH] D13217: [ARM] The Driver does not set the +strict-align flag when targeting armv6m + netbsd

rengolin added inline comments. Comment at: lib/Basic/Targets.cpp:4456 @@ -4455,3 +4455,1 @@ -if (ArchVersion < 6 || - (ArchVersion == 6 && ArchProfile == llvm::ARM::PK_M)) Why is this not necessary any more? http://reviews.llvm.org/D13217 _

r249159 - constify four getInstantiatedFromMemberTemplate() in DeclTemplate.h.

Author: yrnkrn Date: Fri Oct 2 12:38:57 2015 New Revision: 249159 URL: http://llvm.org/viewvc/llvm-project?rev=249159&view=rev Log: constify four getInstantiatedFromMemberTemplate() in DeclTemplate.h. Modified: cfe/trunk/include/clang/AST/DeclTemplate.h Modified: cfe/trunk/include/clang/AS

r249157 - Module debugging: Don't emit forward declarations in module scopes.

Author: adrian Date: Fri Oct 2 12:36:14 2015 New Revision: 249157 URL: http://llvm.org/viewvc/llvm-project?rev=249157&view=rev Log: Module debugging: Don't emit forward declarations in module scopes. A forward declaration inside a module header does not belong to the module. Modified: cfe/tr

r249155 - Remove unused variable.

Author: adrian Date: Fri Oct 2 12:36:03 2015 New Revision: 249155 URL: http://llvm.org/viewvc/llvm-project?rev=249155&view=rev Log: Remove unused variable. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewvc/llvm-proje

r249156 - Break long lines for readability.

Author: adrian Date: Fri Oct 2 12:36:10 2015 New Revision: 249156 URL: http://llvm.org/viewvc/llvm-project?rev=249156&view=rev Log: Break long lines for readability. Modified: cfe/trunk/test/Modules/ModuleDebugInfo.m Modified: cfe/trunk/test/Modules/ModuleDebugInfo.m URL: http://llvm.org/v

LLVM buildnaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted after 6 PM Pacific time today. Sorry for the noise. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13322: Add -f[no-]declspec to control recognition of __declspec as a keyword

wristow added inline comments. Comment at: lib/Driver/Tools.cpp:4663 @@ +4662,3 @@ + else if (Args.hasArg(options::OPT_fno_declspec)) +CmdArgs.push_back("-fno-declspec"); // Explicitly disabling __declspec. + But in the '-fno-declspec -fdeclspec' case, the 'i

Re: [PATCH] D13322: Add -f[no-]declspec to control recognition of __declspec as a keyword

wristow updated this revision to Diff 36373. wristow added a comment. Added 4 new tests, the verify the last -fdeclspec/-fno-declspec wins, both in the context of -fms-extensions and without -fms-extensions. http://reviews.llvm.org/D13322 Files: include/clang/Basic/LangOptions.def include/

r249154 - [OpenMP] Capture global variables in target regions.

Author: sfantao Date: Fri Oct 2 12:14:03 2015 New Revision: 249154 URL: http://llvm.org/viewvc/llvm-project?rev=249154&view=rev Log: [OpenMP] Capture global variables in target regions. All global variables that are not enclosed in a declare target region must be captured in the target region a

Re: [PATCH] D12262: [OpenMP] Capture global variables in target regions.

sfantao closed this revision. sfantao added a comment. Committed in r249154. Thanks! Samuel http://reviews.llvm.org/D12262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: r249141 - Revert "Add support for the new mips-mti-linux toolchain."

Thanks Yaron. I'll to figure out what's going wrong with the Linux buildbot and I'll re-commit the fixed patch tomorrow. - Vasileios From: Yaron Keren [yaron.ke...@gmail.com] Sent: 02 October 2015 17:46 To: Vasileios Kalintiris Cc: cfe-commits Subject: Re: r249141

Re: r249141 - Revert "Add support for the new mips-mti-linux toolchain."

The regular expression should match match clang.exe on Windows. 2015-10-02 18:00 GMT+03:00 Vasileios Kalintiris via cfe-commits < cfe-commits@lists.llvm.org>: > Author: vkalintiris > Date: Fri Oct 2 10:00:55 2015 > New Revision: 249141 > > URL: http://llvm.org/viewvc/llvm-project?rev=249141&vi

r249152 - constify ClassTemplatePartialSpecializationDecl::getInstantiatedFromMember and VarTemplatePartialSpecializationDecl::getInstantiatedFromMember.

Author: yrnkrn Date: Fri Oct 2 11:40:48 2015 New Revision: 249152 URL: http://llvm.org/viewvc/llvm-project?rev=249152&view=rev Log: constify ClassTemplatePartialSpecializationDecl::getInstantiatedFromMember and VarTemplatePartialSpecializationDecl::getInstantiatedFromMember. Modified: cfe/

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

aaron.ballman added a comment. Does not apply cleanly to ToT; can you rebase? ~Aaron http://reviews.llvm.org/D13313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

mgehre updated this revision to Diff 36372. mgehre added a comment. Shot to fast, fixed test. Now it's ready http://reviews.llvm.org/D13313 Files: clang-tidy/CMakeLists.txt clang-tidy/Makefile clang-tidy/add_new_check.py clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreg

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

mgehre updated this revision to Diff 36371. mgehre added a comment. Rebased Removed "(C++ Core Guidelines, rule Type.1)" from diagnostic Can someone please commit this? http://reviews.llvm.org/D13313 Files: clang-tidy/CMakeLists.txt clang-tidy/Makefile clang-tidy/add_new_check.py clang

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

sfantao closed this revision. sfantao added a comment. Committed in r249148! Thanks, Samuel http://reviews.llvm.org/D12871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r249148 - [OpenMP] Target directive host codegen.

Author: sfantao Date: Fri Oct 2 11:14:20 2015 New Revision: 249148 URL: http://llvm.org/viewvc/llvm-project?rev=249148&view=rev Log: [OpenMP] Target directive host codegen. This patch implements the outlining for offloading functions for code annotated with the OpenMP target directive. It uses

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp:48 @@ +47,3 @@ + diag(MatchedExpr->getExprLoc(), + "do not use pointer arithmetic (C++ Core Guidelines, rule Bounds.1)"); +} Can elide the pare

[PATCH] D13388: Add support for querying the visibility of a cursor

michaelwu created this revision. michaelwu added a subscriber: cfe-commits. This patch implements clang_getCursorVisibility which provides access to NamedDecl::getVisibility. It's been very useful for me when generating bindings. http://reviews.llvm.org/D13388 Files: include/clang-c/Index.h

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

zaks.anna added a comment. > Generating mangled names requires ASTContext which is not available during > the error reporting. BugReporter does have the ASTContext, so it would not > be a big change to add it to the DiagnosticConsumers though. And I think the > mangled name might contain too

Re: [PATCH] D11908: Clang support for -fthinlto.

On Fri, Oct 2, 2015 at 8:53 AM, Manuel Klimek wrote: > klimek added a comment. > > In http://reviews.llvm.org/D11908#258570, @tejohnson wrote: > >> Sorry for the duplicate - my previous response didn't go to Duncan or Mehdi >> for some reason. Trying again... >> >> In http://reviews.llvm.org/D119

Re: [PATCH] D11908: Clang support for -fthinlto.

On Fri, Oct 2, 2015 at 9:44 AM, Teresa Johnson via cfe-commits < cfe-commits@lists.llvm.org> wrote: As David mentioned, "inlineonly" is much too restrictive for what is > possible. I prefer to stick with "thin" since it refers to this new model > of keeping the whole program part very thin. > Agr

Re: [PATCH] D13246: Fix bug in modernize-use-nullptr.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D13246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeStaticCastDowncastCheck.cpp:33 @@ +32,3 @@ + + SubExpr = SubExpr->IgnoreParens(); + QualType SourceType = SubExpr->getType(); Will the type dependence check also look through pa

Re: [PATCH] D11908: Clang support for -fthinlto.

klimek added a comment. In http://reviews.llvm.org/D11908#258570, @tejohnson wrote: > Sorry for the duplicate - my previous response didn't go to Duncan or Mehdi > for some reason. Trying again... > > In http://reviews.llvm.org/D11908#258540, @klimek wrote: > > > Perhaps "sharded" would fit what

Re: [PATCH] D12901: [Static Analyzer] Intersecting ranges and 64 bit to 32 bit truncations causing "System is over constrained." assertions.

pgousseau added a comment. Ping ! http://reviews.llvm.org/D12901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

sbenza added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp:38 @@ +37,3 @@ + Finder->addMatcher( + arraySubscriptExpr(hasBase(implicitCastExpr(hasSourceExpression( + hasType(pointerType()).bind("e

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

sbenza added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-static-cast-downcast.cpp:19 @@ +18,3 @@ + // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: do not use static_cast to cast from base to derived. Use dynamic_cast instead. (C++ Core Guidelines, rule

r249143 - [DarwinDriver] Reapply: Use -lto_library to specify the path for libLTO.dylib

Author: bruno Date: Fri Oct 2 10:10:33 2015 New Revision: 249143 URL: http://llvm.org/viewvc/llvm-project?rev=249143&view=rev Log: [DarwinDriver] Reapply: Use -lto_library to specify the path for libLTO.dylib Reapply r248935. Usually, when using LTO with a clang installation newer than the syst

r249142 - Make test more resilient to FastIsel changes. NFC.

Author: adibiagio Date: Fri Oct 2 10:10:22 2015 New Revision: 249142 URL: http://llvm.org/viewvc/llvm-project?rev=249142&view=rev Log: Make test more resilient to FastIsel changes. NFC. Currently FastISel doesn't know how to select vector bitcasts. During instruction selection, fast-isel always

[PATCH] D13386: PR24115: Don't instantiate constexpr function templates in decltype

sberg created this revision. sberg added reviewers: cfe-commits, rsmith. As discussed in [[ https://llvm.org/bugs/show_bug.cgi?id=24115 | "llvm-nm fails to build with gcc 5.1's libstdc++," ]] both llvm-nm and LibreOffice fail to build against GCC 5.1 libstdc++, due to Clang trying (and failing)

r249141 - Revert "Add support for the new mips-mti-linux toolchain."

Author: vkalintiris Date: Fri Oct 2 10:00:55 2015 New Revision: 249141 URL: http://llvm.org/viewvc/llvm-project?rev=249141&view=rev Log: Revert "Add support for the new mips-mti-linux toolchain." This reverts commit r249137 because it broke the Windows buildbots and a Linux buildbot for LLD. Re

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL249140: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64]… (authored by alelab01). Changed prior to commit: http://reviews.llvm.org/D12633?vs=35628&id=36367#toc Repository: rL

r249140 - Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets.

Author: alelab01 Date: Fri Oct 2 09:56:37 2015 New Revision: 249140 URL: http://llvm.org/viewvc/llvm-project?rev=249140&view=rev Log: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets. Differential Revision: http://reviews.llvm.org/D12633 Modified: cfe/trunk

r249138 - Fix bogus comment.

Author: dougk Date: Fri Oct 2 09:41:38 2015 New Revision: 249138 URL: http://llvm.org/viewvc/llvm-project?rev=249138&view=rev Log: Fix bogus comment. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Dri

Re: [PATCH] D13340: Add support for the new mips-mti-linux toolchain.

This revision was automatically updated to reflect the committed changes. vkalintiris marked an inline comment as done. Closed by commit rL249137: Add support for the new mips-mti-linux toolchain. (authored by vkalintiris). Changed prior to commit: http://reviews.llvm.org/D13340?vs=36344&id=363

r249137 - Add support for the new mips-mti-linux toolchain.

Author: vkalintiris Date: Fri Oct 2 09:38:23 2015 New Revision: 249137 URL: http://llvm.org/viewvc/llvm-project?rev=249137&view=rev Log: Add support for the new mips-mti-linux toolchain. Summary: This new toolchain uses primarily LLVM-based tools, eg. compiler-rt, lld, libcxx, etc. Because of th

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

xazax.hun marked 9 inline comments as done. Comment at: lib/StaticAnalyzer/Core/BugId.cpp:29 @@ +28,3 @@ + +static std::string GetSignature(const FunctionDecl *Target) { + if (!Target) zaks.anna wrote: > Can/Should we use some existing machinery for this? For exa

[clang-tools-extra] r249136 - Taking a stab at fixing failing build bots that use make. Unfortunately, the build logs do not point to much useful information for tracking this down, such as:

Author: aaronballman Date: Fri Oct 2 09:28:44 2015 New Revision: 249136 URL: http://llvm.org/viewvc/llvm-project?rev=249136&view=rev Log: Taking a stab at fixing failing build bots that use make. Unfortunately, the build logs do not point to much useful information for tracking this down, such

  1   2   >