loladiro added inline comments.
Comment at: include/clang/Basic/Attr.td:1462
@@ +1461,3 @@
+def UniqueInstantiation : InheritableAttr {
+ let Spellings = [GCC<"unique_instantiation">];
+ let Subjects = SubjectList<[CXXRecord]>;
loladiro wrote:
> aaron.ballman wr
ABataev created this revision.
ABataev added a reviewer: rnk.
ABataev added a subscriber: cfe-commits.
Removes extra codegen for base expression of MS property call
http://reviews.llvm.org/D13375
Files:
lib/Sema/SemaPseudoObject.cpp
test/CodeGenCXX/ms-property.cpp
Index: lib/Sema/SemaPseudo
michaelwu updated this revision to Diff 36330.
michaelwu added a comment.
Thanks for the review. I switched to shouldMangleDeclName instead of
shouldMangleCXXName, and made it skip the frontend mangling instead of
returning an empty string. I tried making mangleName do that instead, but it
seem
hubert.reinterpretcast added inline comments.
Comment at: test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.concept/p7.cpp:4
@@ +3,3 @@
+template concept bool VCEI { true };
+template concept bool VCEI; // expected-error {{variable concept cannot
be explicitly instantiated}}
+
--
hubert.reinterpretcast added inline comments.
Comment at: test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.concept/p7.cpp:13
@@ +12,3 @@
+template concept bool FCEI() { return true; }
+template concept bool FCEI(); // expected-error {{function concept cannot
be explicitly instantiated}}
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249085: Don't adjust field offsets when using external
record layout. (authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D13276?vs=36054&id=36310#toc
Repository:
rL LLVM
http://
Author: zturner
Date: Thu Oct 1 17:08:02 2015
New Revision: 249085
URL: http://llvm.org/viewvc/llvm-project?rev=249085&view=rev
Log:
Don't adjust field offsets when using external record layout.
This was already being done when injecting the VBPtr, but not
when injecting the VFPtr. This fixes a
compnerd added inline comments.
Comment at: lib/Driver/Tools.cpp:4663
@@ +4662,3 @@
+ else if (Args.hasArg(options::OPT_fno_declspec))
+CmdArgs.push_back("-fno-declspec"); // Explicitly disabling __declspec.
+
@rsmith, so they are. I misread something and wa
nlewycky added a comment.
I can't meaningfully review this, but I see nothing wrong here.
Comment at: lib/CodeGen/CGClass.cpp:1378
@@ -1377,3 +1377,3 @@
- bool BaseVPtrsInitialized = false;
+ llvm::Value* const OldThis = CXXThisValue;
// Virtual base initializers first.
-
Prazek created this revision.
Prazek added reviewers: rsmith, nlewycky, rjmccall, majnemer.
Prazek added a subscriber: cfe-commits.
Please review asap
http://reviews.llvm.org/D13373
Files:
lib/CodeGen/CGClass.cpp
test/CodeGenCXX/invariant.group-for-vptrs.cpp
test/CodeGenCXX/strict-vtable-p
On Thu, Oct 1, 2015 at 6:01 AM, Renato Golin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Right, I reverted both commits on r249005. Please, let me know if you
> need help testing on ARM before the next commit. This looks like it
> could be tested on any 32-bit platform, though, so you s
Author: bwilson
Date: Thu Oct 1 20:05:29 2015
New Revision: 249116
URL: http://llvm.org/viewvc/llvm-project?rev=249116&view=rev
Log:
Be slightly more permissive when checking for type-erased blocks.
This is a patch from Doug that was inadvertently omitted from r241543.
Modified:
cfe/trunk/l
Author: cbieneman
Date: Thu Oct 1 19:56:53 2015
New Revision: 249115
URL: http://llvm.org/viewvc/llvm-project?rev=249115&view=rev
Log:
[CMake] Fixing clang bootstrap to use LLVM_RUNTIME_OUTPUT_INTDIR instead of
CMAKE_BINARY_DIR.
This should make bootstrap builds work with multi-configuration ge
Author: rsmith
Date: Thu Oct 1 19:49:37 2015
New Revision: 249114
URL: http://llvm.org/viewvc/llvm-project?rev=249114&view=rev
Log:
PR24921: checking explicitly-specified template arguments when matching a
partial specialization can perform conversions on the argument. Be sure we
start again from
Author: rsmith
Date: Thu Oct 1 19:46:58 2015
New Revision: 249113
URL: http://llvm.org/viewvc/llvm-project?rev=249113&view=rev
Log:
Explicitly delete a function that is supposed to never be called.
Modified:
cfe/trunk/include/clang/AST/TemplateBase.h
Modified: cfe/trunk/include/clang/AST/Te
zaks.anna added a comment.
This checker produces a lot of warnings! Have you analyzed how many are false
positives? Have you tried reporting these warnings?
It's hard to make use of the results you posted from the debian packages. For
most of them, I cannot tell if they are valid reports or fal
Author: chapuni
Date: Thu Oct 1 18:50:06 2015
New Revision: 249100
URL: http://llvm.org/viewvc/llvm-project?rev=249100&view=rev
Log:
Fix the *unchecked* commit.
Modified:
clang-tools-extra/trunk/CMakeLists.txt
Modified: clang-tools-extra/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249097: Fix the SSE4 byte sign extension in a cleaner way,
and more thoroughly (authored by chandlerc).
Changed prior to commit:
http://reviews.llvm.org/D13324?vs=36178&id=36321#toc
Repository:
rL LL
Author: chandlerc
Date: Thu Oct 1 18:40:12 2015
New Revision: 249097
URL: http://llvm.org/viewvc/llvm-project?rev=249097&view=rev
Log:
Fix the SSE4 byte sign extension in a cleaner way, and more thoroughly
test that our intrinsics behave the same under -fsigned-char and
-funsigned-char.
This fur
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054
@@ +3043,13 @@
+Sizes.push_back(Size);
+MapTypes.push_back(MapType);
+ }
+
+ // Keep track on whether the host function has to be executed.
+ auto OffloadErrorQType =
+ CGF.getCont
sfantao updated this revision to Diff 36317.
sfantao added a comment.
Address Alexey's remarks from last review.
http://reviews.llvm.org/D12871
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/CodeGenFunction.h
test/OpenMP/t
davidxl updated this revision to Diff 36316.
davidxl added a comment.
I have modified the implementation to not use linker script, so this clang
patch becomes strictly refactoring with NFC. I think it is still a good thing
to have this in so that similar tunings like this can be done in the futu
Author: rikka
Date: Thu Oct 1 17:38:51 2015
New Revision: 249090
URL: http://llvm.org/viewvc/llvm-project?rev=249090&view=rev
Log:
Don't try to get a CXXRecordDecl from a non-class TemplateSpecializationType.
With -fms-extensions it is possible to have a non-class record that is a
template speci
mgehre created this revision.
mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman.
mgehre added a subscriber: cfe-commits.
mgehre added a dependency: D13313: [clang-tidy] new check
cppcoreguidelines-pro-type-reinterpret-cast.
This check flags all usages of static_cast, where a base cla
dcoughlin added a comment.
Sean, I've committed this patch. You can update to trunk to get it.
Repository:
rL LLVM
http://reviews.llvm.org/D12993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
majnemer added a comment.
It seems our infrastructure is not up to the task of making this testable via
Clang, please commit.
http://reviews.llvm.org/D13276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
zaks.anna added a comment.
Could you address this:
Could you ask on the open source list if people are using "issue_hash" and if
they are Ok with us renaming it.
I'd suggest to suffix each issue hash field with the description of that hash.
For example, we would remove "issue_hash" and replace
wristow updated this revision to Diff 36307.
wristow added a comment.
Updated patch to change the Group of the diagnostic from f_Group to
f_clang_Group, and to change the string associated with the LANGOPT definition
of the flag. Also fixed a minor typo in a comment.
http://reviews.llvm.org/D
mgehre updated this revision to Diff 36305.
mgehre added a comment.
Remove inclusion of misc-no-reinterpret-cast in this patch set
http://reviews.llvm.org/D13311
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppc
wristow added inline comments.
Comment at: include/clang/Basic/LangOptions.def:93
@@ -92,2 +92,3 @@
LANGOPT(WChar , 1, CPlusPlus, "wchar_t keyword")
+LANGOPT(DeclSpecKeyword , 1, 0, "Microsoft __declspec keyword support")
BENIGN_LANGOPT(DollarIdents , 1, 1, "'$'
mgehre updated this revision to Diff 36300.
mgehre added a comment.
Port to cppcoreguidelines module.
Add checks for post/pre increment/decrement and array access.
http://reviews.llvm.org/D13311
Files:
clang-tidy/CMakeLists.txt
clang-tidy/Makefile
clang-tidy/add_new_check.py
clang-tidy/
davidxl added a comment.
ThinLTO is a perfectly good term to indicate what it tries to accomplish.
InlineOnly will narrow its scope. For instance, there is no reason why thinLTO
can not do fast summary based WPA in the future.
http://reviews.llvm.org/D11908
_
I'm in favor of keeping the asserts around. Several times, I've seen Clang
crashers than languish in the bug tracker with an assert in a generic
casting function. And no one fixes it until someone pokes at the backtrace
to find the source of the bad pointer, at which point it gets fixed quickly.
mgehre updated this revision to Diff 36296.
mgehre added a comment.
Read 'Check' suffix on ProTypeReinterpretCastCheck
http://reviews.llvm.org/D13313
Files:
clang-tidy/CMakeLists.txt
clang-tidy/Makefile
clang-tidy/add_new_check.py
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy
alexr added a subscriber: alexr.
alexr added a comment.
I realize that we've all been referring to this as ThinLTO, but is that
necessarily descriptive for users? What about inlineonly or something similar?
http://reviews.llvm.org/D11908
___
cfe-co
alexr added a subscriber: alexr.
alexr added a comment.
PowerPC has floating point hardware by definition. Is this some new variant?
http://reviews.llvm.org/D13351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
mgehre updated this revision to Diff 36294.
mgehre added a comment.
Fix add_new_check.py for capitalization of CppCoreGuidelinesTidyModule.cpp
http://reviews.llvm.org/D13313
Files:
clang-tidy/CMakeLists.txt
clang-tidy/Makefile
clang-tidy/add_new_check.py
clang-tidy/cppcoreguidelines/CMa
mgehre updated this revision to Diff 36291.
mgehre added a comment.
Renamed the check to cppcoreguidelines-pro-type-reinterpret-cast
http://reviews.llvm.org/D13313
Files:
clang-tidy/CMakeLists.txt
clang-tidy/Makefile
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelin
Author: dgregor
Date: Thu Oct 1 15:20:47 2015
New Revision: 249065
URL: http://llvm.org/viewvc/llvm-project?rev=249065&view=rev
Log:
Perform Objective-C lifetime adjustments before comparing deduced lambda result
types.
Objective-C ARC lifetime qualifiers are dropped when canonicalizing
functio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249063: [analyzer] Add TK_EntireMemSpace invalidation trait.
(authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D12993?vs=35170&id=36288#toc
Repository:
rL LLVM
http://reviews
Author: dcoughlin
Date: Thu Oct 1 15:09:11 2015
New Revision: 249063
URL: http://llvm.org/viewvc/llvm-project?rev=249063&view=rev
Log:
[analyzer] Add TK_EntireMemSpace invalidation trait.
This commit supports Sean Eveson's work on loop widening. It is NFC for now.
It adds a new TK_EntireMemSpace
> Next time, add Differential Revision: to your commit and
Phabricator will close the diff automatically.
Ooh, shiny. Thanks for letting me know!
> Doubling the expense for assert builds so that we get a slightly better
stack trace in the event our assumptions are wrong doesn't seem like a good
Author: dgregor
Date: Thu Oct 1 14:52:44 2015
New Revision: 249060
URL: http://llvm.org/viewvc/llvm-project?rev=249060&view=rev
Log:
Simplify Sema::DeduceFunctionTypeFromReturnExpr and eliminae a redundant check.
NFC
Modified:
cfe/trunk/lib/Sema/SemaStmt.cpp
Modified: cfe/trunk/lib/Sema/Se
On Thu, Oct 1, 2015 at 3:01 PM, Richard Trieu wrote:
> rtrieu added a comment.
>
> Next time, add
>
>> Differential Revision:
>
>
> to your commit and Phabricator will close the diff automatically.
>
> http://llvm.org/docs/Phabricator.html
>
>
>
> Comment at: lib/Analysis/CFG.cpp
rtrieu added a comment.
Next time, add
> Differential Revision:
to your commit and Phabricator will close the diff automatically.
http://llvm.org/docs/Phabricator.html
Comment at: lib/Analysis/CFG.cpp:99-104
@@ +98,8 @@
+ // Currently we're only given EnumConstantDecls or
On Thu, Oct 1, 2015 at 2:50 PM, George Burgess IV
wrote:
> george.burgess.iv closed this revision.
> george.burgess.iv marked 4 inline comments as done.
> george.burgess.iv added a comment.
>
> Changed code to address all feedback + committed as r249053. Thanks for the
> reviews!
>
>
> ==
george.burgess.iv closed this revision.
george.burgess.iv marked 4 inline comments as done.
george.burgess.iv added a comment.
Changed code to address all feedback + committed as r249053. Thanks for the
reviews!
Comment at: lib/Analysis/CFG.cpp:49
@@ +48,3 @@
+tryNormalizeBinar
Author: gbiv
Date: Thu Oct 1 13:47:52 2015
New Revision: 249053
URL: http://llvm.org/viewvc/llvm-project?rev=249053&view=rev
Log:
Teach -Wtautological-overlap-compare about enums
Prior to this patch, -Wtautological-overlap-compare would only warn us
if there was a sketchy logical comparison betw
sfantao updated this revision to Diff 36263.
sfantao added a comment.
This diff refactors the original patch and is rebased on top of the latests
offloading changes inserted for CUDA.
Here I don't touch the CUDA support. I tried, however, to have the
implementation modular enough so that it cou
Author: cbieneman
Date: Thu Oct 1 13:16:56 2015
New Revision: 249048
URL: http://llvm.org/viewvc/llvm-project?rev=249048&view=rev
Log:
[CMake] Don't include the test directories if CLANG_INCLUDE_TESTS is Off
This matches Clang's behavior.
Modified:
clang-tools-extra/trunk/CMakeLists.txt
Mo
I added !invariant.load to virtual functions load, so when optimizer see
case like this
%vtable = load ...
%1 = load (...) %vtable, !invariant.load !0
call %1(...)
%2 = load (...) %vtable, !invariant.load !0
call %2(...)
can merge the 2 virtual functions load into one like this:
%vtable = load
nwilson created this revision.
nwilson added reviewers: rsmith, hubert.reinterpretcast, aaron.ballman,
faisalv, fraggamuffin.
nwilson added a subscriber: cfe-commits.
http://reviews.llvm.org/D13357
Files:
include/clang/AST/Decl.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl
grimar updated this revision to Diff 36271.
grimar added a comment.
Added comment per review request.
http://reviews.llvm.org/D13203
Files:
ASTContext.cpp
Index: ASTContext.cpp
===
--- ASTContext.cpp
+++ ASTContext.cpp
@@ -364,1
On Thu, Oct 1, 2015 at 1:09 PM, Keno Fischer
wrote:
> loladiro added a comment.
>
> Thanks for the quick review.
>
>
>
> Comment at: include/clang/Basic/Attr.td:1462
> @@ +1461,3 @@
> +def UniqueInstantiation : InheritableAttr {
> + let Spellings = [GCC<"unique_instantiation">];
tejohnson updated this revision to Diff 36267.
tejohnson added a comment.
Address review comments.
Instead of -fthinlto use -flto=thin, and add in -flto=full as an alias to the
existing -flto. Add tests to check for proper overriding of -flto variants on
the command line, and convert grep tests
loladiro added a comment.
Thanks for the quick review.
Comment at: include/clang/Basic/Attr.td:1462
@@ +1461,3 @@
+def UniqueInstantiation : InheritableAttr {
+ let Spellings = [GCC<"unique_instantiation">];
+ let Subjects = SubjectList<[CXXRecord]>;
aaron.bal
zarko marked an inline comment as done.
zarko added a comment.
Thanks; would someone with commit access land this?
echristo: for a more concrete example, imagine a source code indexer that
collects up dependencies. This is a Clang tool that gets called by the build
system for each translation u
On Wed, Sep 30, 2015 at 2:33 PM, Duncan P. N. Exon Smith
wrote:
> +echristo, +espindola, +pcc
>
>> On 2015-Sep-30, at 12:39, Teresa Johnson wrote:
>>
>> On Wed, Sep 30, 2015 at 11:11 AM, Duncan P. N. Exon Smith
>> wrote:
>>>
On 2015-Sep-30, at 10:40, Teresa Johnson wrote:
On Wed,
Author: adrian
Date: Thu Oct 1 11:57:02 2015
New Revision: 249031
URL: http://llvm.org/viewvc/llvm-project?rev=249031&view=rev
Log:
Module debugging: Also emit Objective-C interfaces forward declarations
in their module scope when building a clang module.
Modified:
cfe/trunk/lib/CodeGen/CGDe
zarko updated this revision to Diff 36266.
zarko added a comment.
Address comment comments.
http://reviews.llvm.org/D13318
Files:
include/clang/Tooling/Tooling.h
lib/Tooling/Tooling.cpp
unittests/Tooling/ToolingTest.cpp
Index: unittests/Tooling/ToolingTest.cpp
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249030: Allow a ToolChain to compute the path of a
compiler-rt's component. (authored by vkalintiris).
Changed prior to commit:
http://reviews.llvm.org/D13339?vs=36225&id=36265#toc
Repository:
rL LLV
Author: vkalintiris
Date: Thu Oct 1 11:54:58 2015
New Revision: 249030
URL: http://llvm.org/viewvc/llvm-project?rev=249030&view=rev
Log:
Allow a ToolChain to compute the path of a compiler-rt's component.
Summary:
This patch moves getCompilerRT() from the clang::driver::tools namespace to
the To
aaron.ballman created this revision.
aaron.ballman added reviewers: alexfh, sbenza.
aaron.ballman added a subscriber: cfe-commits.
CERT produces a set of secure coding rules and recommendations for both C
(https://www.securecoding.cert.org/confluence/display/c/SEI+CERT+C+Coding+Standard)
and C++
spetrovic created this revision.
spetrovic added a reviewer: hfinkel.
spetrovic added a subscriber: cfe-commits.
This patch enables soft float support for ppc32 architecture and fixes the ABI
for variadic functions. This is first in set of patches for soft float support
in LLVM.
http://reviews
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM with a test added, see test/CodeGenCXX/override-layout.cpp for an example
of how to test external record layout.
http://reviews.llvm.org/D13276
___
majnemer added a subscriber: majnemer.
majnemer added a comment.
In http://reviews.llvm.org/D13203#257539, @klimek wrote:
> Not sure whether it makes sense to work around compiler bugs in CL. I assume
> this happens with clang from trunk? Is there a bug filed against CL?
We do this with some r
vkalintiris added inline comments.
Comment at: include/clang/Driver/ToolChain.h:147
@@ -145,1 +146,3 @@
+ const Multilib &getSelectedMultilib() const { return SelectedMultilib; }
+
atanasyan wrote:
> Do you need public access to this member function?
I discarde
vkalintiris updated this revision to Diff 36257.
vkalintiris marked 8 inline comments as done.
vkalintiris added a comment.
Thanks. The review comments are addressed in this update.
http://reviews.llvm.org/D13340
Files:
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains.
s.egerton updated this revision to Diff 36252.
s.egerton added a comment.
Responded to comments made on the mailing list.
http://reviews.llvm.org/D13100
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
--- lib/Driver/
neil.hickey created this revision.
neil.hickey added a reviewer: cfe-commits.
Changing behaviour of casting a true boolean to an integer vector for OpenCL.
The spec (6.2.2) states that if the boolean is true, every bit in the result
vector should be set. This change will treat the i1 value as si
rnk added a comment.
I think fundamentally we are doing too much declspec property lowering in Sema.
We might want to back up and figure out how to do it in IRGen. Right now we
have bugs like this, which are probably more important than new functionality:
https://llvm.org/bugs/show_bug.cgi?id=24
echristo added a comment.
BTW as Manuel is happy it's fine with me. Still curious though.
http://reviews.llvm.org/D13318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
In http://reviews.llvm.org/D13313#257506, @alexfh wrote:
> In http://reviews.llvm.org/D13313#257476, @aaron.ballman wrote:
>
> > As a slightly more broad question: I think we should have a
> > user-customizable way to categorize these checks so that you can
> > en
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added reviewers: rsmith, aaron.ballman.
Comment at: include/clang/Basic/Attr.td:1462
@@ +1461,3 @@
+def UniqueInstantiation : InheritableAttr {
+ let Spellings = [GCC<"unique_instantiation">];
+ let Subjects = Subjec
Author: d0k
Date: Thu Oct 1 10:02:15 2015
New Revision: 249019
URL: http://llvm.org/viewvc/llvm-project?rev=249019&view=rev
Log:
[VFS] Remove unused setters. NFC.
Modified:
cfe/trunk/include/clang/Basic/VirtualFileSystem.h
Modified: cfe/trunk/include/clang/Basic/VirtualFileSystem.h
URL:
ht
klimek added a reviewer: rsmith.
klimek added a comment.
+Richard, whom we need to validate AST changes to make sure they're benign.
http://reviews.llvm.org/D13344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
yaron.keren added a subscriber: yaron.keren.
yaron.keren added a comment.
clang can't generate Visual C++ debug info except line numbers yet, so building
with VC is essential to development on Windows. While most people and our bots
are still using VC 2013 going forward supporting VC 2015 (even
Author: angelgarcia
Date: Thu Oct 1 09:50:40 2015
New Revision: 249017
URL: http://llvm.org/viewvc/llvm-project?rev=249017&view=rev
Log:
Update clang-tidy documentation.
Summary:
Improve modernize-use-auto documentation
(https://llvm.org/bugs/show_bug.cgi?id=24962).
Add documentation for modern
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D13346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
mcrosier added a comment.
FWIW, a llvm based solution was discussed in http://reviews.llvm.org/D12979,
but the clang solution is obviously more robust and easier to implement.
Comment at: lib/CodeGen/CodeGenFunction.h:287
@@ +286,3 @@
+ // True if the current insertion point i
milianw added a comment.
Is there still an error reported for the invalid condition?
Anyhow, from my POV this is excellent and should fix a bunch of issues I've
seen when using clang-c in KDevelop. I never got around to investigating it,
but it always was related to conditionals. I'm pretty sur
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: alexfh, cfe-commits.
Improve modernize-use-auto documentation
(https://llvm.org/bugs/show_bug.cgi?id=24962).
Add documentation for modernize-make-unique.
http://reviews.llvm.org/D13346
Files:
klimek added a subscriber: klimek.
klimek added a comment.
Not sure whether it makes sense to work around compiler bugs in CL. I assume
this happens with clang from trunk? Is there a bug filed against CL?
http://reviews.llvm.org/D13203
___
cfe-comm
Author: hfinkel
Date: Thu Oct 1 08:39:49 2015
New Revision: 249009
URL: http://llvm.org/viewvc/llvm-project?rev=249009&view=rev
Log:
[PowerPC] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_* macros on all PPC cores
We support all __sync_val_compare_and_swap_* builtins (only 64-bit on 64-bit
targets) o
ogoffart created this revision.
ogoffart added a reviewer: cfe-commits.
This is quite useful for IDE's or other tools which would like to recover as
much as possible even if there are a few errors in the code, and discarding
the full 'if' bodies is unfortunate.
http://reviews.llvm.org/D13344
F
atanasyan added inline comments.
Comment at: include/clang/Driver/ToolChain.h:92
@@ -91,2 +91,3 @@
MultilibSet Multilibs;
+ Multilib SelectedMultilib;
This field is used by the `MipsToolChain` class only. If so, move it to that
class.
Comm
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM with a nit.
Comment at: include/clang/Driver/ToolChain.h:253
@@ -252,1 +252,3 @@
+ virtual SmallString<128> getCompilerRT(const llvm::opt::ArgList &Args,
+
alexfh added a comment.
A high-level comment: the "misc" module is the place for checks that we didn't
find (or create) a better category for. Here it's clear that we need a separate
category, so we need a `CppCoreGuidelinesModule` and the `cppcoreguidelines-`
check prefix. I also suggest using
Author: angelgarcia
Date: Thu Oct 1 08:08:21 2015
New Revision: 249006
URL: http://llvm.org/viewvc/llvm-project?rev=249006&view=rev
Log:
Prevent loop-convert from leaving empty lines after removing an alias
declaration.
Summary: This fixes https://llvm.org/bugs/show_bug.cgi?id=17716.
Reviewers
Right, I reverted both commits on r249005. Please, let me know if you
need help testing on ARM before the next commit. This looks like it
could be tested on any 32-bit platform, though, so you should be able
to get it passing on ARM if you test and make it pass on x86.
On 1 October 2015 at 09:44,
alexfh added a comment.
In http://reviews.llvm.org/D13313#256982, @vsk wrote:
> The patch lgtm. Has there been a discussion on cfe-dev about adopting these
> guidelines?
>
> I count well over 500 uses of reinterpret_cast in llvm+clang, so we might not
> all be on the same page on this.
I don'
Author: rengolin
Date: Thu Oct 1 07:58:41 2015
New Revision: 249005
URL: http://llvm.org/viewvc/llvm-project?rev=249005&view=rev
Log:
Revert "Decorating virtual functions load with invariant.load" and fix
This reverts commit r248982 as it was breaking the ARM buildbots and the fix
didn't work.
alexfh added a comment.
In http://reviews.llvm.org/D13313#257476, @aaron.ballman wrote:
> As a slightly more broad question: I think we should have a user-customizable
> way to categorize these checks so that you can enable/disable them with
> finer-grained control. Some of the existing checker
angelgarcia updated this revision to Diff 36234.
angelgarcia added a comment.
Change a comment.
http://reviews.llvm.org/D13342
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
clang-tidy/modernize/LoopConvertCheck.h
test/clang-tidy/modernize-loop-convert-extra.cpp
Index: test/clang-tidy/
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
apart from that LG
http://reviews.llvm.org/D13342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:455-457
@@ +454,5 @@
+///
+/// FIXME: if 'next_instruction' is a closing brace ('}'), after the
replacement
+/// it will be over-indented. But then, who would declare an alias and do
+/// nothing
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: alexfh, cfe-commits.
This fixes https://llvm.org/bugs/show_bug.cgi?id=17716.
http://reviews.llvm.org/D13342
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
clang-tidy/modernize/LoopConver
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added reviewers: aaron.ballman, alexfh.
aaron.ballman added a comment.
As a slightly more broad question: I think we should have a user-customizable
way to categorize these checks so that you can enable/disable them with
finer-graine
vkalintiris created this revision.
vkalintiris added reviewers: atanasyan, dsanders, rsmith.
vkalintiris added a subscriber: cfe-commits.
Herald added subscribers: dschuff, srhines, danalbert, tberghammer, jfb.
This new toolchain uses primarily LLVM-based tools, eg. compiler-rt, lld,
libcxx, etc.
vkalintiris created this revision.
vkalintiris added reviewers: atanasyan, rsmith.
vkalintiris added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
This patch moves getCompilerRT() from the clang::driver::tools namespace to
the ToolChain class. This is needed
1 - 100 of 137 matches
Mail list logo
