Prazek created this revision.
Prazek added reviewers: rsmith, majnemer, nlewycky, rjmccall.
Prazek added a subscriber: cfe-commits.
http://reviews.llvm.org/D13279
Files:
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/virtual-function-calls.cpp
Index: test/CodeGenCXX/virtual-function-calls.cpp
I think it's worth figuring out when this is called with the semantic or
syntactic version and why this can't lead to double visitation. Then add a
comment while you're changing the method so the next person doesn't have to
figure it all out :)
On Wed, Sep 30, 2015 at 12:15 AM Angel Garcia
wrote:
Author: dehao
Date: Tue Sep 29 20:03:10 2015
New Revision: 248869
URL: http://llvm.org/viewvc/llvm-project?rev=248869&view=rev
Log:
Fix the sample profile format that breaks in test
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/505
http://reviews.llvm.org/D1
alexfh added a comment.
In http://reviews.llvm.org/D12839#256179, @flx wrote:
> I had to convert the line endings of mis-move-constructor-init.cpp to unix
> style otherwise the test would not correctly work. This took a long time to
> debug since the checks failed complaining that error message
dcoughlin added a comment.
Thanks for the patch! This looks very useful. What browsers does the JavaScript
support?
One thing I noticed is that after immediately loading a new report page the 'j'
and 'k' shortcuts don't work for me. In Safari, I get:
TypeError: null is not an object (evaluat
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Please fix the patch and I can commit it for you.
Comment at: clang-tidy/utils/IncludeSorter.cpp:289
@@ +288,3 @@
+IncludeSorter::IncludeStyle
+IncludeSorter::toIn
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
One of the error messages still needs to be made more clear. Otherwise looks
good.
Thank you!
Comment at: clang-tidy/misc/NonCopyableObjects.cpp:88
@@ +87,3 @@
+ else if (E
zaks.anna requested changes to this revision.
zaks.anna added a comment.
This revision now requires changes to proceed.
I find it very confusing to have 2 different fields for bug identification -
issue_hash and BugId. Why do we need to treat the HTML reports differently from
plist files?
http
Author: rsmith
Date: Tue Sep 29 19:48:50 2015
New Revision: 248867
URL: http://llvm.org/viewvc/llvm-project?rev=248867&view=rev
Log:
Promote a warning on ill-formed code (redeclaration missing an exception
specification) to an error. No compiler other than Clang seems to allow this,
and it doesn't
zaks.anna added a comment.
We gave a talk about building checkers a while back; even though it does not
talk about the bug reporter visitors, it might be worth watching if you haven't
already seen it.
http://llvm.org/devmtg/2012-11/
Building a Checker in 24 hours
Comment at:
zturner created this revision.
zturner added a reviewer: majnemer.
zturner added a subscriber: cfe-commits.
injecting the VBPtr always behaves this way, but injecting the VFPtr was not.
This patch fixes that.
http://reviews.llvm.org/D13276
Files:
lib/AST/RecordLayoutBuilder.cpp
Index: lib/A
> On Sep 27, 2015, at 5:56 PM, Joerg Sonnenberger
> wrote:
> On Tue, Sep 08, 2015 at 08:06:00AM -, John McCall via cfe-commits wrote:
>> Author: rjmccall
>> Date: Tue Sep 8 03:05:57 2015
>> New Revision: 246985
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=246985&view=rev
>> Log:
>> Co
Author: rjmccall
Date: Tue Sep 29 18:55:17 2015
New Revision: 248862
URL: http://llvm.org/viewvc/llvm-project?rev=248862&view=rev
Log:
Don't crash when a reserved global placement operator new is paired
with a non-reserved operator delete in a new-expression.
Modified:
cfe/trunk/lib/CodeGen/C
zaks.anna added a comment.
> I think I understand, but to clarify:
> The fields that shouldn't be invalidated should still be added to
> ValuesToInvalidate, but with
> RegionAndSymbolInvalidationTraits::TK_PreserveContents set. This will result
> in
> checkConstPointerEscape being called
flx updated this revision to Diff 36049.
flx marked 3 inline comments as done.
flx added a comment.
I had to convert the line endings of mis-move-constructor-init.cpp to unix
style otherwise the test would not correctly work. This took a long time to
debug since the checks failed complaining tha
tra updated this revision to Diff 36048.
tra added a comment.
Renamed wrapper to cuda_runtime.h
Similarly to nvcc, automatically add "-include cuda_runtime.h" to CC1
invocations unless -nocudainc is specified.
http://reviews.llvm.org/D13171
Files:
lib/Driver/ToolChains.cpp
lib/Headers/CMak
On Tue, Sep 29, 2015 at 4:01 PM, Adrian Prantl wrote:
>
> On Sep 29, 2015, at 3:52 PM, David Blaikie wrote:
>
>
>
> On Tue, Sep 29, 2015 at 1:44 PM, Adrian Prantl via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: adrian
>> Date: Tue Sep 29 15:44:46 2015
>> New Revision: 248826
> On Sep 29, 2015, at 3:52 PM, David Blaikie wrote:
>
>
>
> On Tue, Sep 29, 2015 at 1:44 PM, Adrian Prantl via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: adrian
> Date: Tue Sep 29 15:44:46 2015
> New Revision: 248826
>
> URL: http://llvm.org/viewvc/llvm-project?rev=24
On Tue, Sep 29, 2015 at 1:44 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Tue Sep 29 15:44:46 2015
> New Revision: 248826
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248826&view=rev
> Log:
> CGDebugInfo: Don't reuse a reference into a DenseMa
Author: jyknight
Date: Tue Sep 29 17:28:44 2015
New Revision: 248836
URL: http://llvm.org/viewvc/llvm-project?rev=248836&view=rev
Log:
Move functions declared in ExprObjC.h into ExprObjC.cpp.
r51703 back in 2008 split out all the ObjC Expr subclasses from Expr.h
to a new ExprObjC.h file, but fail
Hi,
Please review the attached patch. It does not discard the full 'if' statement
if the condition is invalid.
This is quite useful for IDE's or other tools which would like to recover as
much as possible even if there are a few errors in the code, and discarding
the full 'if' bodies is unfor
angelgarcia added a comment.
Yes, it breaks a few tests:
FAIL: Clang :: Analysis/operator-calls.cpp (598 of 8596)
FAIL: Clang :: Analysis/misc-ps-region-store.cpp (599 of 8596)
FAIL: Clang :: Analysis/array-struct-region.c (602 of 8596)
http://reviews.llvm.org/D13249
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248828: Fix Clang-tidy modernize-use-nullptr warnings in
headers and generated files… (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D13187?vs=35789&id=36034#toc
Repository:
rL
Author: hans
Date: Tue Sep 29 15:56:43 2015
New Revision: 248828
URL: http://llvm.org/viewvc/llvm-project?rev=248828&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in headers and generated files;
other minor cleanups.
By Eugene Zelenko!
Differential Revision: http://reviews.llvm.or
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D13187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Author: adrian
Date: Tue Sep 29 15:44:46 2015
New Revision: 248826
URL: http://llvm.org/viewvc/llvm-project?rev=248826&view=rev
Log:
CGDebugInfo: Don't reuse a reference into a DenseMap if the DenseMap may
be modified in between. (NFC)
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
Modified
DavidEGrayson added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:303
@@ +302,3 @@
+// the first element is the bit width of an integer type and the second element
+// is true if the integer type is signed.
+static struct WidthAndSignedness
Sorry, I need
george.burgess.iv created this revision.
george.burgess.iv added a reviewer: rsmith.
george.burgess.iv added subscribers: cfe-commits, rsmith.
This was a fun patch :)
This patch adds the parameter attribute `pass_object_size` to Clang. The design
doc for this attribute is available here:
https:
Author: nemanjai
Date: Tue Sep 29 13:20:59 2015
New Revision: 248815
URL: http://llvm.org/viewvc/llvm-project?rev=248815&view=rev
Log:
Forgot to remove a FIXME that has been fixed. NFC.
Modified:
cfe/trunk/lib/Headers/altivec.h
Modified: cfe/trunk/lib/Headers/altivec.h
URL:
http://llvm.org/
Author: nemanjai
Date: Tue Sep 29 13:13:34 2015
New Revision: 248813
URL: http://llvm.org/viewvc/llvm-project?rev=248813&view=rev
Log:
Addition of interfaces the FE to conform to Table A-2 of ELF V2 ABI V1.1
This patch corresponds to review:
http://reviews.llvm.org/D13190
Implemented the followi
nemanjai closed this revision.
nemanjai added a comment.
Committed revision 248813.
Repository:
rL LLVM
http://reviews.llvm.org/D13190
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: aaronballman
Date: Tue Sep 29 12:32:36 2015
New Revision: 248808
URL: http://llvm.org/viewvc/llvm-project?rev=248808&view=rev
Log:
Added MSVC natvis visualizers for Type and QualType. These could probably be
improved, but anything is better than staring at hex values in the debugger.
Mod
klimek added inline comments.
Comment at: include/clang/AST/RecursiveASTVisitor.h:2097
@@ +2096,3 @@
+template
+bool RecursiveASTVisitor::TraverseInitListExpr(InitListExpr *S) {
+ TRY_TO(TraverseSyntacticInitListExpr(S));
Did you try putting an assert(S->isSeman
djasper added a comment.
What do you mean by "this looks good"?
http://reviews.llvm.org/D12492
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MyDeveloperDay added a comment.
I don't have permission to commit
This looks good though.
http://reviews.llvm.org/D12492
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: yrnkrn
Date: Tue Sep 29 11:51:08 2015
New Revision: 248807
URL: http://llvm.org/viewvc/llvm-project?rev=248807&view=rev
Log:
Fix typo.
Modified:
cfe/trunk/lib/Lex/Preprocessor.cpp
Modified: cfe/trunk/lib/Lex/Preprocessor.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Le
Author: delesley
Date: Tue Sep 29 11:24:18 2015
New Revision: 248805
URL: http://llvm.org/viewvc/llvm-project?rev=248805&view=rev
Log:
Thread Safety Analysis: allow capability attribute on unions.
Modified:
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/lib/Sema/SemaDeclAttr.cpp
cfe/
djasper added inline comments.
Comment at: unittests/Format/FormatTest.cpp:8699
@@ +8698,3 @@
+ Alignment));
+ Alignment.AlignConsecutiveAssignments = true;
+ verifyFormat("float something = 2000;\n"
berenm wrote:
> djasper wrote:
> > Can
berenm added inline comments.
Comment at: unittests/Format/FormatTest.cpp:8699
@@ +8698,3 @@
+ Alignment));
+ Alignment.AlignConsecutiveAssignments = true;
+ verifyFormat("float something = 2000;\n"
djasper wrote:
> Can you add a case (unl
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: alexfh, cfe-commits.
create TraverseSyntacticInitListExpr and TraverseSemanticInitListExpr.
http://reviews.llvm.org/D13249
Files:
include/clang/AST/RecursiveASTVisitor.h
Index: include/clan
Author: delesley
Date: Tue Sep 29 10:25:51 2015
New Revision: 248803
URL: http://llvm.org/viewvc/llvm-project?rev=248803&view=rev
Log:
Thread Safety Analysis: fix before/after checks so that they work on global
variables as well member variables.
Modified:
cfe/trunk/include/clang/Analysis/An
djasper added inline comments.
Comment at: lib/Format/WhitespaceManager.cpp:270
@@ +269,3 @@
+ if (Changes[i].NewlinesBefore > 1 || !FoundDeclarationOnLine ||
+ FoundLeftBraceOnLine || FoundLeftParenOnLine) {
+AlignSequence();
Generally, we d
djasper added a comment.
I think r248802 should make this mostly obsolete, but feel free to add the
tests :-).
http://reviews.llvm.org/D12492
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
djasper closed this revision.
djasper added a comment.
Submitted as r248802.
http://reviews.llvm.org/D13210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Tue Sep 29 09:57:55 2015
New Revision: 248802
URL: http://llvm.org/viewvc/llvm-project?rev=248802&view=rev
Log:
clang-format: Add a new brace style "custom" as well as flags to
control the individual braces. The existing choices for brace wrapping
are now merely presets for t
pekka.jaaskelainen requested changes to this revision.
This revision now requires changes to proceed.
Comment at: lib/Sema/SemaType.cpp:6166
@@ -6166,2 +6165,3 @@
attr.setUsedAsTypeAttr();
+ hasOpenCLAddressSpace = true;
break;
Should this be be
berenm marked 3 inline comments as done.
berenm added a comment.
http://reviews.llvm.org/D13081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
berenm updated this revision to Diff 35974.
berenm added a comment.
Fix arcanist messup...
http://reviews.llvm.org/D13081
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/Inputs/readability-identifier-naming/system/system-header.h
test/clang-tidy/Inputs/readability-
berenm updated this revision to Diff 35972.
berenm added a comment.
Address the latest comments, as well as useless code removal.
- Only the start of the token range is stored, so there is no need to care
about the end of the range. Remove the code that was trying to match the end of
the range
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: alexfh, cfe-commits.
https://llvm.org/bugs/show_bug.cgi?id=24960
modernize-use-nullptr would hit an assertion in some cases involving macros and
initializer lists, due to finding a node with m
Author: aaronballman
Date: Tue Sep 29 09:26:00 2015
New Revision: 248797
URL: http://llvm.org/viewvc/llvm-project?rev=248797&view=rev
Log:
Some of the build bots are unhappy about the overload of the global operator
new() because it was accidentally marked noexcept instead of noexcept(false).
Th
berenm added inline comments.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:545
@@ +544,3 @@
+ if (const auto *Loc = Result.Nodes.getNodeAs("typeLoc")) {
+if (const auto &Ref = Loc->getAs()) {
+ addUsage(NamingCheckFailures, Ref.getDecl(), Loc->getSourceRa
Author: aaronballman
Date: Tue Sep 29 08:38:00 2015
New Revision: 248794
URL: http://llvm.org/viewvc/llvm-project?rev=248794&view=rev
Log:
Silencing bot failures a more creative and definitive way.
Modified:
clang-tools-extra/trunk/test/clang-tidy/misc-new-delete-overloads-sized-dealloc.cpp
Author: aaronballman
Date: Tue Sep 29 08:20:26 2015
New Revision: 248792
URL: http://llvm.org/viewvc/llvm-project?rev=248792&view=rev
Log:
Hopefully silencing some built bot warnings. Note, this should be unsigned long
instead of unsigned int, but then *other* builds start to fail because of
dup
aaron.ballman marked 3 inline comments as done.
aaron.ballman added a comment.
In http://reviews.llvm.org/D13071#255446, @alexfh wrote:
> Looks good with a few comments.
>
> Thanks for the new check! Do you think whether this could be a compiler
> warning some day?
I thought about implementing
Author: aaronballman
Date: Tue Sep 29 08:12:21 2015
New Revision: 248791
URL: http://llvm.org/viewvc/llvm-project?rev=248791&view=rev
Log:
Adding a checker (misc-new-delete-overloads) that detects mismatched overloads
of operator new and operator delete. Corresponds to the CERT C++ secure coding
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/NonCopyableObjects.cpp:88
@@ +87,3 @@
+ else if (E)
+diag(E->getExprLoc(), "expression has suspicious type '%0'")
+<< BD->getName();
alexfh wrote:
> What's a "suspicious type" and why sh
Author: olesalscheider
Date: Tue Sep 29 01:39:09 2015
New Revision: 248780
URL: http://llvm.org/viewvc/llvm-project?rev=248780&view=rev
Log:
Implement tanh builtin
This is a port from the AMD builtin library.
Added:
libclc/trunk/generic/include/clc/math/tanh.h
libclc/trunk/generic/includ
alexfh added inline comments.
Comment at: clang-tidy/misc/NonCopyableObjects.cpp:88
@@ +87,3 @@
+ else if (E)
+diag(E->getExprLoc(), "expression has suspicious type '%0'")
+<< BD->getName();
What's a "suspicious type" and why should the user know abou
alexfh added inline comments.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:537
@@ +536,3 @@
+ return;
+Range.setBegin(Range.getBegin().getLocWithOffset(1));
+
There are cases where this will fail (`~ ClassName()` or `??-ClassName` or
`~\C
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with a few comments.
Thanks for the new check! Do you think whether this could be a compiler warning
some day?
Comment at: clang-tidy/misc/NewDeleteOverloadsCheck
Author: angelgarcia
Date: Tue Sep 29 04:36:41 2015
New Revision: 248785
URL: http://llvm.org/viewvc/llvm-project?rev=248785&view=rev
Log:
Create modernize-make-unique check.
Summary: create a check that replaces 'std::unique_ptr(new
type(args...))' with 'std::make_unique(args...)'. It was on the
angelgarcia updated this revision to Diff 35949.
angelgarcia added a comment.
Add a comment.
http://reviews.llvm.org/D13166
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/MakeUniqueCheck.cpp
clang-tidy/modernize/MakeUniqueCheck.h
clang-tidy/modernize/ModernizeTidyModule
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
apart from the comment, LG
Comment at: clang-tidy/modernize/MakeUniqueCheck.cpp:67-70
@@ +66,6 @@
+ SourceLocation ConstructCallEnd;
+ if (LAngle == StringRef::npos) {
+
berenm updated this revision to Diff 35946.
berenm added a comment.
Update the diff with the ProvideAutoLoad attribute.
Thanks @MyDeveloperDay for the review and tips!
http://reviews.llvm.org/D12407
Files:
tools/clang-format-vs/ClangFormat/ClangFormat.csproj
tools/clang-format-vs/ClangForm
labrinea added a comment.
ping
http://reviews.llvm.org/D12633
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper closed this revision.
djasper added a comment.
Submitted as r248782.
http://reviews.llvm.org/D13228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Tue Sep 29 02:53:08 2015
New Revision: 248782
URL: http://llvm.org/viewvc/llvm-project?rev=248782&view=rev
Log:
clang-format: Extend #include sorting functionality
Recognize the main module header as well as different #include categories.
This should now mimic the behavior o
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
djasper marked an inline comment as done.
Comment at: lib/Format/Format.cpp:1677
@@ +1676,3 @@
+unsigned Category;
+if (LookForMainHeader &&! Matches[1].startswith("<")) {
+ Category = 0;
klimek wrote:
> Run clang-format.
>
> Also, should
klimek added inline comments.
Comment at: lib/Format/Format.cpp:1665
@@ +1664,3 @@
+
+ // Create pre-compile regular expressions for the #include categories.
+ SmallVector CategoryRegexs;
pre-compiled
Comment at: lib/Format/Format.cpp:1677
@@ +
sunfish added a comment.
> In any case, that's not how clang deal with usage or even internal unexpected
> errors. It asserts, print error messages but does not crash on purpose.
> Having clang crash here does not seem like a good solution and will result in
> this issue continue to surface aga
73 matches
Mail list logo
