Yep. We'll make it better by limiting the size, but trivially copyable is
an improvement, as there are orders of magnitude more loops over small
copyable types than over large ones.
On Sat, Sep 26, 2015, 9:02 PM comex wrote:
> On Thu, Sep 24, 2015 at 7:28 AM, Manuel Klimek via cfe-commits
> wro
comex added a comment.
Ping?
http://reviews.llvm.org/D12686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Thu, Sep 24, 2015 at 7:28 AM, Manuel Klimek via cfe-commits
wrote:
> Fix loop-convert for trivially copyable types.
If I'm not misunderstanding the patch, "trivially copyable" by itself
seems like a suboptimal test. After all, "trivial" can still include
an expensive memcpy of a large struct.
Author: ctopper
Date: Sat Sep 26 22:44:08 2015
New Revision: 248678
URL: http://llvm.org/viewvc/llvm-project?rev=248678&view=rev
Log:
Use llvm::makeArrayRef. NFC.
Modified:
cfe/trunk/include/clang/AST/Type.h
cfe/trunk/include/clang/Analysis/Analyses/ThreadSafetyTIL.h
cfe/trunk/lib/AST
alexfh added a comment.
Please add a documentation file.
Comment at: clang-tidy/misc/NonCopyableObjects.cpp:21
@@ +20,3 @@
+ static const char *TypeNames[] = {
+"::pthread_cond_t",
+"::pthread_mutex_t",
How about making these lists configurable or addin
alexfh added a comment.
Please add a documentation file.
Comment at: clang-tidy/misc/NewDeleteOverloadsCheck.cpp:42
@@ +41,3 @@
+return Node.getNumParams() > 1;
+ else if (Node.getNumParams() == 1)
+return false;
Please no `else` after `return`.
http:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Should I submit this?
http://reviews.llvm.org/D13090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Anteru updated this revision to Diff 35810.
Anteru added a comment.
Here's an updated diff which should do the trick. If not, please tell me how to
improve -- this is my first change to Clang.
http://reviews.llvm.org/D6920
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Fo
echristo added a comment.
Bikeshed: it's part of the clang headers, do we really need "clang" in the
header name?
-eric
http://reviews.llvm.org/D13171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: vkalintiris
Date: Sat Sep 26 13:26:01 2015
New Revision: 248673
URL: http://llvm.org/viewvc/llvm-project?rev=248673&view=rev
Log:
unwind: Allow the building of libunwind for MIPS.
Summary:
Currently, libunwind doesn't support MIPS. However, with this patch
we do allow the library to build
MyDeveloperDay added a comment.
After a little digging, the problem is based on the fact that the extension
doesn't load until we use it, so the nBeforeSave won't fire, so after doing
Ctrl-R,Ctrl-F once it will work
This exact same problem is mentioned here
http://schmalls.com/2015/01/19/adven
Author: chapuni
Date: Sat Sep 26 06:17:32 2015
New Revision: 248666
URL: http://llvm.org/viewvc/llvm-project?rev=248666&view=rev
Log:
clang/test/Driver/arm-compiler-rt.c: Relax expressions for dos path.
Modified:
cfe/trunk/test/Driver/arm-compiler-rt.c
Modified: cfe/trunk/test/Driver/arm-com
Author: sanjoy
Date: Fri Sep 25 18:07:11 2015
New Revision: 248632
URL: http://llvm.org/viewvc/llvm-project?rev=248632&view=rev
Log:
Change arc-cxx11-init-list.mm to work with upcoming SCEV changes.
Summary:
The store being checked for in arc-cxx11-init-list.mm is a store to an
unescaped alloca.
sanjoy created this revision.
sanjoy added a reviewer: compnerd.
sanjoy added a subscriber: cfe-commits.
The store being checked for in arc-cxx11-init-list.mm is a store to an
unescaped alloca. After an uncoming change to ScalarEvolution, LLVM is
able to elide the store, so adjust the test accord
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248632: Change arc-cxx11-init-list.mm to work with upcoming
SCEV changes. (authored by sanjoy).
Changed prior to commit:
http://reviews.llvm.org/D13183?vs=35777&id=35778#toc
Repository:
rL LLVM
http
arseny.kapoulkine created this revision.
arseny.kapoulkine added a subscriber: cfe-commits.
For nested functions, local-name can be followed by function arguments; in
some cases the first argument starts with a digit (if it's a named type).
For example, this code:
void test() { struct g { void f
yaron.keren added a comment.
Hi Dan, it makes sense that output streams should not usually be mixed
together, especially if one is binary as you write.
This may or may not be a problem depending on what the user really wants. He
may want to mix the outputs for whatever purposes or it may usually
17 matches
Mail list logo
