Re: r247618 - C11 _Bool bitfield diagnostic

On Fri, Sep 18, 2015 at 10:19 PM, Richard Smith wrote: > On Fri, Sep 18, 2015 at 8:49 PM, Nico Weber wrote: > >> On Fri, Sep 18, 2015 at 5:06 PM, Richard Smith >> wrote: >> >>> On Wed, Sep 16, 2015 at 5:33 PM, Richard Smith >>> wrote: >>> On Wed, Sep 16, 2015 at 5:27 PM, Nico Weber via cf

r248085 - [Modules] More descriptive diagnostics for misplaced import directive

Author: sepavloff Date: Sat Sep 19 00:32:57 2015 New Revision: 248085 URL: http://llvm.org/viewvc/llvm-project?rev=248085&view=rev Log: [Modules] More descriptive diagnostics for misplaced import directive If an import directive was put into wrong context, the error message was obscure, complain

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

This revision was automatically updated to reflect the committed changes. Closed by commit rL248085: [Modules] More descriptive diagnostics for misplaced import directive (authored by sepavloff). Changed prior to commit: http://reviews.llvm.org/D11844?vs=35115&id=35161#toc Repository: rL LLV

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

On Fri, Sep 18, 2015 at 8:22 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > compnerd accepted this revision. > compnerd added a reviewer: compnerd. > compnerd added a comment. > This revision is now accepted and ready to land. > > Looks fine minus the one thing that

Re: r247618 - C11 _Bool bitfield diagnostic

On Fri, Sep 18, 2015 at 8:49 PM, Nico Weber wrote: > On Fri, Sep 18, 2015 at 5:06 PM, Richard Smith > wrote: > >> On Wed, Sep 16, 2015 at 5:33 PM, Richard Smith >> wrote: >> >>> On Wed, Sep 16, 2015 at 5:27 PM, Nico Weber via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> On Tue,

Re: [clang-tools-extra] r248080 - clang-tools-extra: Appease PR24881. [-Wdocumentation]

Thanks! -- Sean Silva On Fri, Sep 18, 2015 at 7:21 PM, NAKAMURA Takumi via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chapuni > Date: Fri Sep 18 21:21:28 2015 > New Revision: 248080 > > URL: http://llvm.org/viewvc/llvm-project?rev=248080&view=rev > Log: > clang-tools-extra: Appea

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

zaks.anna added a comment. Thanks for the fix! We'll commit shortly. Repository: rL LLVM http://reviews.llvm.org/D12119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r248083 - Driver: avoid unnecessary string ops

Author: compnerd Date: Fri Sep 18 23:33:38 2015 New Revision: 248083 URL: http://llvm.org/viewvc/llvm-project?rev=248083&view=rev Log: Driver: avoid unnecessary string ops Use an enumeration for the Floating Point ABIs supported on MIPS. This is replicating the ARM change to avoid string based t

Re: [PATCH] D10586: Add HSAIL support

arsenm updated this revision to Diff 35157. arsenm added a comment. Herald added a subscriber: rampitec. Update for trunk. Fix __builtin_hsail_gridsize/__builtin_hsail_gridsizel http://reviews.llvm.org/D10586 Files: include/clang/Basic/BuiltinsHSAIL.def include/clang/Basic/TargetBuiltins.h

Re: r247618 - C11 _Bool bitfield diagnostic

On Fri, Sep 18, 2015 at 5:06 PM, Richard Smith wrote: > On Wed, Sep 16, 2015 at 5:33 PM, Richard Smith > wrote: > >> On Wed, Sep 16, 2015 at 5:27 PM, Nico Weber via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> On Tue, Sep 15, 2015 at 5:50 PM, Richard Smith >>> wrote: >>> On T

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

compnerd accepted this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision is now accepted and ready to land. Looks fine minus the one thing that needs a quick look at. Comment at: include/clang/Driver/Options.td:952 @@ -951,1 +951,3 @@ def fn

[clang-tools-extra] r248080 - clang-tools-extra: Appease PR24881. [-Wdocumentation]

Author: chapuni Date: Fri Sep 18 21:21:28 2015 New Revision: 248080 URL: http://llvm.org/viewvc/llvm-project?rev=248080&view=rev Log: clang-tools-extra: Appease PR24881. [-Wdocumentation] \returns doesn't accept \li, but \parblock \li. Modified: clang-tools-extra/trunk/clang-apply-replaceme

r248079 - Add test that we correctly allow some non-letter unicode characters in

Author: rsmith Date: Fri Sep 18 21:14:12 2015 New Revision: 248079 URL: http://llvm.org/viewvc/llvm-project?rev=248079&view=rev Log: Add test that we correctly allow some non-letter unicode characters in identifiers, and extend existing test to also cover C++. Modified: cfe/trunk/test/Lexer/u

r248077 - Further simplify CGDebugInfo::getOrCreateModuleRef().

Author: adrian Date: Fri Sep 18 19:59:22 2015 New Revision: 248077 URL: http://llvm.org/viewvc/llvm-project?rev=248077&view=rev Log: Further simplify CGDebugInfo::getOrCreateModuleRef(). DIBuilder ignoers DICompileUnits that are passed in as scopes anyway. Modified: cfe/trunk/lib/CodeGen/CGDe

r248076 - Use std::move on these arguments.

Author: adrian Date: Fri Sep 18 19:59:19 2015 New Revision: 248076 URL: http://llvm.org/viewvc/llvm-project?rev=248076&view=rev Log: Use std::move on these arguments. Modified: cfe/trunk/include/clang/AST/ExternalASTSource.h Modified: cfe/trunk/include/clang/AST/ExternalASTSource.h URL: htt

Re: r248062 - CGDebugInfo: Make creating a skeleton CU in getOrCreateModuleRef optional.

> On Sep 18, 2015, at 5:47 PM, David Blaikie wrote: > > > > On Fri, Sep 18, 2015 at 5:45 PM, Adrian Prantl > wrote: > >> On Sep 18, 2015, at 5:11 PM, David Blaikie > > wrote: >> >> >> >> On Fri, Sep 18, 2015 at 4:01 PM, Adrian Prantl vi

Re: PATCH: Provide the compile commands of the JSON database in consistent order

LG in general; I think if we like the order to be deterministic we should try to come up with a unit test so nobody regresses this in the future. On Fri, Sep 18, 2015 at 4:44 PM Argyrios Kyrtzidis wrote: > Hi, > > I have found it useful for the getAllCompileCommands() to return the > commands in

Re: r248062 - CGDebugInfo: Make creating a skeleton CU in getOrCreateModuleRef optional.

On Fri, Sep 18, 2015 at 5:45 PM, Adrian Prantl wrote: > > On Sep 18, 2015, at 5:11 PM, David Blaikie wrote: > > > > On Fri, Sep 18, 2015 at 4:01 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: adrian >> Date: Fri Sep 18 18:01:45 2015 >> New Revision: 248062

Re: r248062 - CGDebugInfo: Make creating a skeleton CU in getOrCreateModuleRef optional.

> On Sep 18, 2015, at 5:11 PM, David Blaikie wrote: > > > > On Fri, Sep 18, 2015 at 4:01 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Fri Sep 18 18:01:45 2015 > New Revision: 248062 > > URL: http://llvm.org/viewvc/llvm-project?rev=24

Re: r248069 - Refactor ASTReader::getSourceDescriptor(const Module &) into a constructor

On Fri, Sep 18, 2015 at 5:10 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Fri Sep 18 19:10:32 2015 > New Revision: 248069 > > URL: http://llvm.org/viewvc/llvm-project?rev=248069&view=rev > Log: > Refactor ASTReader::getSourceDescriptor(const Modul

r248070 - Rename ASTSourceDescriptor::ModuleName to FullModuleName for clarity.

Author: adrian Date: Fri Sep 18 19:10:37 2015 New Revision: 248070 URL: http://llvm.org/viewvc/llvm-project?rev=248070&view=rev Log: Rename ASTSourceDescriptor::ModuleName to FullModuleName for clarity. Modified: cfe/trunk/include/clang/AST/ExternalASTSource.h cfe/trunk/lib/AST/ExternalAS

r248069 - Refactor ASTReader::getSourceDescriptor(const Module &) into a constructor

Author: adrian Date: Fri Sep 18 19:10:32 2015 New Revision: 248069 URL: http://llvm.org/viewvc/llvm-project?rev=248069&view=rev Log: Refactor ASTReader::getSourceDescriptor(const Module &) into a constructor of ASTSourceDescriptor. It was effectively a static function. NFC. Modified: cfe/tru

r248068 - Eliminate a redundant check.

Author: adrian Date: Fri Sep 18 19:10:25 2015 New Revision: 248068 URL: http://llvm.org/viewvc/llvm-project?rev=248068&view=rev Log: Eliminate a redundant check. Modified: cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperations.cpp Modified: cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperati

Re: r248062 - CGDebugInfo: Make creating a skeleton CU in getOrCreateModuleRef optional.

On Fri, Sep 18, 2015 at 4:01 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Fri Sep 18 18:01:45 2015 > New Revision: 248062 > > URL: http://llvm.org/viewvc/llvm-project?rev=248062&view=rev > Log: > CGDebugInfo: Make creating a skeleton CU in getOrCr

Re: r247618 - C11 _Bool bitfield diagnostic

On Wed, Sep 16, 2015 at 5:33 PM, Richard Smith wrote: > On Wed, Sep 16, 2015 at 5:27 PM, Nico Weber via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Tue, Sep 15, 2015 at 5:50 PM, Richard Smith >> wrote: >> >>> On Tue, Sep 15, 2015 at 12:38 PM, Nico Weber >>> wrote: >>> With t

Re: r248064 - Split off the binary literal warning into a subgroup of C++14 warnings

Can we arrange for this warning to also be controlled by the -Wgnu-binary-literal option, as it is outside C++ mode? On Fri, Sep 18, 2015 at 4:18 PM, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Fri Sep 18 18:18:39 2015 > New Revision: 248064 > > URL

PATCH: Provide the compile commands of the JSON database in consistent order

Hi, I have found it useful for the getAllCompileCommands() to return the commands in the order that they were provided in the JSON file. This is useful for debugging of issues and reduction of test cases. For example, an issue may show up due to the order that some commands were processed. It is

r248065 - [Static Analyzer] Fixed a false positive case in DynamicTypeChecker when dealing with forward declarations.

Author: xazax Date: Fri Sep 18 18:38:57 2015 New Revision: 248065 URL: http://llvm.org/viewvc/llvm-project?rev=248065&view=rev Log: [Static Analyzer] Fixed a false positive case in DynamicTypeChecker when dealing with forward declarations. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/Dyna

Re: [PATCH] D11279: Initial patch for PS4 toolchain

silvas added a subscriber: silvas. silvas added a comment. Once this lands, I think we can revert r247977 http://reviews.llvm.org/D11279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

r248064 - Split off the binary literal warning into a subgroup of C++14 warnings

Author: rtrieu Date: Fri Sep 18 18:18:39 2015 New Revision: 248064 URL: http://llvm.org/viewvc/llvm-project?rev=248064&view=rev Log: Split off the binary literal warning into a subgroup of C++14 warnings Binary literals predate C++14, but they are listed as a C++14 extension since this was the fi

Re: r248062 - CGDebugInfo: Make creating a skeleton CU in getOrCreateModuleRef optional.

> On Sep 18, 2015, at 4:01 PM, Adrian Prantl via cfe-commits > wrote: > > Author: adrian > Date: Fri Sep 18 18:01:45 2015 > New Revision: 248062 > > URL: http://llvm.org/viewvc/llvm-project?rev=248062&view=rev > Log: > CGDebugInfo: Make creating a skeleton CU in getOrCreateModuleRef optional.

r248062 - CGDebugInfo: Make creating a skeleton CU in getOrCreateModuleRef optional.

Author: adrian Date: Fri Sep 18 18:01:45 2015 New Revision: 248062 URL: http://llvm.org/viewvc/llvm-project?rev=248062&view=rev Log: CGDebugInfo: Make creating a skeleton CU in getOrCreateModuleRef optional. We don't want a skeleton CU when generating debug info for the module itself. NFC. Modif

Re: [PATCH] D12989: [CUDA] Added CUDA installation detector class.

tra added a comment. Any suggestions how to test this? http://reviews.llvm.org/D12989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12989: [CUDA] Added CUDA installation detector class.

tra created this revision. tra added a reviewer: echristo. tra added a subscriber: cfe-commits. The class searches for a CUDA installation directory and provides accessors for relevant bits of info about it. Added new option --cuda-path= which allows overriding default search paths. If it's not

Re: [PATCH] D9898: MismatchingNewDeleteDetector uses incorrect field, and finds no initializer

ismailp added a reviewer: majnemer. ismailp marked an inline comment as done. ismailp added a comment. Ping! http://reviews.llvm.org/D9898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

r248053 - Simplify the interface of PCHContainerGenerator and friends

Author: adrian Date: Fri Sep 18 17:10:59 2015 New Revision: 248053 URL: http://llvm.org/viewvc/llvm-project?rev=248053&view=rev Log: Simplify the interface of PCHContainerGenerator and friends by passing in a CompilerInstance instead of all its individual members. NFC. Modified: cfe/trunk/in

r248051 - Relax the test to get it passing with windows paths.

Author: rafael Date: Fri Sep 18 17:01:10 2015 New Revision: 248051 URL: http://llvm.org/viewvc/llvm-project?rev=248051&view=rev Log: Relax the test to get it passing with windows paths. Modified: cfe/trunk/test/Driver/amdgpu-toolchain.c Modified: cfe/trunk/test/Driver/amdgpu-toolchain.c URL:

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

ismailp added a comment. Thank you for reviewing! Repository: rL LLVM http://reviews.llvm.org/D12119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r248050 - Analyzer: Fix a crasher in UbigraphViz

Author: ismailp Date: Fri Sep 18 16:54:47 2015 New Revision: 248050 URL: http://llvm.org/viewvc/llvm-project?rev=248050&view=rev Log: Analyzer: Fix a crasher in UbigraphViz Summary: Name `Out` refers to the parameter. It is moved into the member `Out` in ctor-init. Dereferencing null pointer will

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

This revision was automatically updated to reflect the committed changes. Closed by commit rL248050: Analyzer: Fix a crasher in UbigraphViz (authored by ismailp). Changed prior to commit: http://reviews.llvm.org/D12119?vs=35141&id=35142#toc Repository: rL LLVM http://reviews.llvm.org/D12119

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

ismailp updated this revision to Diff 35141. ismailp added a comment. - Added a new test file instead of adding '-analyzer-viz-egraph-ubigraph' to an existing test. http://reviews.llvm.org/D12119 Files: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp test/Analysis/ubigraph-viz.cpp Index:

r248046 - Reduce indentation in the TargetInfo implementations and fix up

Author: echristo Date: Fri Sep 18 16:26:24 2015 New Revision: 248046 URL: http://llvm.org/viewvc/llvm-project?rev=248046&view=rev Log: Reduce indentation in the TargetInfo implementations and fix up a couple of macro builtin redefines. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/

Re: [PATCH] D12955: Fix assertion in inline assembler IR gen

aaron.ballman added a comment. Generally LGTM, with one question about guarding against overflow. Comment at: lib/Sema/SemaStmtAsm.cpp:447 @@ +446,3 @@ +// Make sure no more than one input constraint matches each output. +if (InputMatchedToOutput[TiedTo] != ~0U) { +

r248041 - [Static Analyzer] General type checker based on dynamic type information.

Author: xazax Date: Fri Sep 18 16:15:37 2015 New Revision: 248041 URL: http://llvm.org/viewvc/llvm-project?rev=248041&view=rev Log: [Static Analyzer] General type checker based on dynamic type information. Differential Revision: http://reviews.llvm.org/D12973 Added: cfe/trunk/lib/StaticAnal

Re: [PATCH] D12973: [Static Analyzer] General type checker based on dynamic type information.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248041: [Static Analyzer] General type checker based on dynamic type information. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12973?vs=35099&id=35134#toc Repository: rL LLV

r248043 - [CMake] Refactoring and cleaning up clang symlink generation.

Author: cbieneman Date: Fri Sep 18 16:15:54 2015 New Revision: 248043 URL: http://llvm.org/viewvc/llvm-project?rev=248043&view=rev Log: [CMake] Refactoring and cleaning up clang symlink generation. Generation of clang symlinks now uses add_clang_symlink macro which uses add_llvm_symlink. Also th

r248037 - Debug Info: Use the full module name as a key when caching DIModules.

Author: adrian Date: Fri Sep 18 16:06:14 2015 New Revision: 248037 URL: http://llvm.org/viewvc/llvm-project?rev=248037&view=rev Log: Debug Info: Use the full module name as a key when caching DIModules. The signature may not have been computed at the time the module reference is generated (e.g.: i

r248035 - Handle lld not being found in PATH.

Author: rafael Date: Fri Sep 18 15:55:58 2015 New Revision: 248035 URL: http://llvm.org/viewvc/llvm-project?rev=248035&view=rev Log: Handle lld not being found in PATH. Modified: cfe/trunk/test/Driver/amdgpu-toolchain.c Modified: cfe/trunk/test/Driver/amdgpu-toolchain.c URL: http://llvm.org

Re: [PATCH] D12981: [clang-cl]: Don't warn on /bigobj flag

thakis closed this revision. thakis added a comment. r248034, thanks! (with test) http://reviews.llvm.org/D12981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r248034 - clang-cl: Don't warn on /bigobj flag

Author: nico Date: Fri Sep 18 15:49:33 2015 New Revision: 248034 URL: http://llvm.org/viewvc/llvm-project?rev=248034&view=rev Log: clang-cl: Don't warn on /bigobj flag LLVM r217812 made it so that clang-cl implicitly creates bigobj files when needed, independent of this flag. It looks like cl has

Re: [PATCH] D12973: [Static Analyzer] General type checker based on dynamic type information.

zaks.anna accepted this revision. This revision is now accepted and ready to land. Comment at: test/Analysis/generics.m:239 @@ -238,3 +238,3 @@ NSArray *b = a; - NSString *str = [b getObjAtIndex: 0]; // expected-warning {{Conversion}} + NSString *str = [b getObjAtIndex: 0]; /

r248033 - Yet another try at fixing this at every bot.

Author: rafael Date: Fri Sep 18 15:44:09 2015 New Revision: 248033 URL: http://llvm.org/viewvc/llvm-project?rev=248033&view=rev Log: Yet another try at fixing this at every bot. This time handle " and - after clang and lld. Modified: cfe/trunk/test/Driver/amdgpu-toolchain.c Modified: cfe/tr

Re: [PATCH] D12981: [clang-cl]: Don't warn on /bigobj flag

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. LGTM Please also add this to the tests for ignored options in test/Driver/cl-options.c:221 http://reviews.llvm.org/D12981 ___ cfe-commits mailing l

r248031 - Relax this test further to pass in other bots.

Author: rafael Date: Fri Sep 18 15:35:53 2015 New Revision: 248031 URL: http://llvm.org/viewvc/llvm-project?rev=248031&view=rev Log: Relax this test further to pass in other bots. The problem this time was the /clang matching the InstalledDir line. Now we just use regular expressions which are m

[PATCH] D12982: Move routines for guessing mode/target from driver to ToolChain

zarko created this revision. zarko added reviewers: rnk, echristo. zarko added a subscriber: cfe-commits. zarko set the repository for this revision to rL LLVM. Herald added subscribers: srhines, danalbert, tberghammer. The Clang gcc-compatible driver (clang/tools/driver/driver.cpp) has some logic

r248029 - Fix test to pass when the directory name has lld in it.

Author: rafael Date: Fri Sep 18 15:22:36 2015 New Revision: 248029 URL: http://llvm.org/viewvc/llvm-project?rev=248029&view=rev Log: Fix test to pass when the directory name has lld in it. CHECK-LABEL assumes that there is only one occurrence of the match. The output looks like: clang version 3

[PATCH] D12981: [clang-cl]: Don't warn on /bigobj flag

thakis created this revision. thakis added a reviewer: hans. thakis added a subscriber: cfe-commits. LLVM r217812 made it so that clang-cl implicitly creates bigobj files when needed, independent of this flag. It looks like cl has this flag to produce obj flags compatible with MSVS 2003's linker

r248025 - Revert "[CMake] Refactoring and cleaning up clang symlink generation."

Author: cbieneman Date: Fri Sep 18 14:59:51 2015 New Revision: 248025 URL: http://llvm.org/viewvc/llvm-project?rev=248025&view=rev Log: Revert "[CMake] Refactoring and cleaning up clang symlink generation." This reverts commit r248015, because it broke bots. I'll revise and recommit. Added:

Re: [PATCH] D12725: [analyzer] A fix for substraction of an integer from a pointer.

xazax.hun added a comment. In http://reviews.llvm.org/D12725#248931, @NoQ wrote: > I've got no commit access yet, sorry, that's my first patch here actually :) No problem, I committed it in r248021. Thank you for your contribution! Repository: rL LLVM http://reviews.llvm.org/D12725

Re: [PATCH] D12725: [analyzer] A fix for substraction of an integer from a pointer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248021: [analyzer] A fix for substraction of an integer from a pointer. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12725?vs=34423&id=35122#toc Repository: rL LLVM http://

r248021 - [analyzer] A fix for substraction of an integer from a pointer.

Author: xazax Date: Fri Sep 18 14:13:22 2015 New Revision: 248021 URL: http://llvm.org/viewvc/llvm-project?rev=248021&view=rev Log: [analyzer] A fix for substraction of an integer from a pointer. Patch by Artem Dergachev! Differential Revision: http://reviews.llvm.org/D12725 Modified: cfe/

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

sfantao added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054 @@ +3043,13 @@ + + if (auto *VAT = dyn_cast(ElementType.getTypePtr())) { +auto VATInfo = CGF.getVLASize(VAT); +Size = llvm::ConstantInt::get( +CGM.SizeTy, +

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

sfantao updated this revision to Diff 35121. sfantao added a comment. Update if clause emission for target directive following Alexey's remark. http://reviews.llvm.org/D12871 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp lib/CodeGen/Co

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

rsmith added a comment. A separate patch for the ObjC cases is fine. http://reviews.llvm.org/D11844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

rsmith accepted this revision. rsmith added a reviewer: rsmith. Comment at: include/clang/Parse/Parser.h:2560-2562 @@ +2559,5 @@ + bool tryParseMisplacedModuleImport() { +tok::TokenKind Kind = Tok.getKind(); +if (Kind == tok::annot_module_begin || Kind == tok::annot_modul

Re: [PATCH] D12725: [analyzer] A fix for substraction of an integer from a pointer.

NoQ added a comment. I've got no commit access yet, sorry, that's my first patch here actually :) http://reviews.llvm.org/D12725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

sepavloff added a comment. Thanks for helpful notes! There are similar cases in Objective C. Should they be implemented in this patch or separate patch is OK? Comment at: include/clang/Basic/DiagnosticParseKinds.td:1016 @@ -1015,2 +1015,3 @@ "expected ';' after module name"

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

sepavloff updated this revision to Diff 35115. sepavloff added a comment. Updated patch. http://reviews.llvm.org/D11844 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Parse/Parser.h include/clang/Sema/Sema.h lib/Parse/ParseD

r248016 - [CMake] Set CLANG_LINKS_TO_CREATE in Apple-stage2.cmake so that we create cc and c++ links.

Author: cbieneman Date: Fri Sep 18 13:11:18 2015 New Revision: 248016 URL: http://llvm.org/viewvc/llvm-project?rev=248016&view=rev Log: [CMake] Set CLANG_LINKS_TO_CREATE in Apple-stage2.cmake so that we create cc and c++ links. Modified: cfe/trunk/cmake/caches/Apple-stage2.cmake Modified: c

r248015 - [CMake] Refactoring and cleaning up clang symlink generation.

Author: cbieneman Date: Fri Sep 18 13:09:15 2015 New Revision: 248015 URL: http://llvm.org/viewvc/llvm-project?rev=248015&view=rev Log: [CMake] Refactoring and cleaning up clang symlink generation. Generation of clang symlinks now uses add_clang_symlink macro which uses add_llvm_symlink. Also th

Re: [PATCH] D12725: [analyzer] A fix for substraction of an integer from a pointer.

xazax.hun added a comment. In http://reviews.llvm.org/D12725#243150, @NoQ wrote: > Thanks, fixed :) Can you commit this or do you need someone to commit this for you? http://reviews.llvm.org/D12725 ___ cfe-commits mailing list cfe-commits@lists.l

Re: [PATCH] D12901: [Static Analyzer] Intersecting ranges and 64 bit to 32 bit truncations causing "System is over constrained." assertions.

xazax.hun added a comment. Hi! Thank you for the patch! What happens if you factor the "index + 1" expression out into a separate variable? E.g.: unsigned temp = index + 1; and use temp in the condition? My impression is that, the ranges does not model the overflow behavior correctly (which i

[PATCH] D12973: [Static Analyzer] General type checker based on dynamic type information.

xazax.hun created this revision. xazax.hun added reviewers: zaks.anna, dcoughlin, jordan_rose. xazax.hun added a subscriber: cfe-commits. This patch adds a checker that utilizes the information that was collected by DynamicTypePropagation and warns when the static type contradicts the dynamic ty

r248005 - clang-cl: Use 'pc' for the vendor field in the default triple

Author: hans Date: Fri Sep 18 12:11:50 2015 New Revision: 248005 URL: http://llvm.org/viewvc/llvm-project?rev=248005&view=rev Log: clang-cl: Use 'pc' for the vendor field in the default triple Leaving it unset can make the triple look confusing, especially when using -m32 or -m64. Modified:

Re: [PATCH] D12916: [Static Analyzer] Use generics related information to infer dynamic types.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248002: [Static Analyzer] Use generics related information to infer dynamic types. (authored by xazax). Changed prior to commit: http://reviews.llvm.org/D12916?vs=35027&id=35095#toc Repository: rL LL

r248002 - [Static Analyzer] Use generics related information to infer dynamic types.

Author: xazax Date: Fri Sep 18 11:43:27 2015 New Revision: 248002 URL: http://llvm.org/viewvc/llvm-project?rev=248002&view=rev Log: [Static Analyzer] Use generics related information to infer dynamic types. Differential Revision: http://reviews.llvm.org/D12916 Modified: cfe/trunk/lib/Static

r248000 - Suppress amdgpu-toolchain.c for targeting ps4, for now. Investigating.

Author: chapuni Date: Fri Sep 18 11:21:27 2015 New Revision: 248000 URL: http://llvm.org/viewvc/llvm-project?rev=248000&view=rev Log: Suppress amdgpu-toolchain.c for targeting ps4, for now. Investigating. Modified: cfe/trunk/test/Driver/amdgpu-toolchain.c Modified: cfe/trunk/test/Driver/amdg

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

phillip.power added a comment. Hi Babati, We at Sony are interested in this feature so that our tools can suppress undesirable bug warnings. You described at the end of the summary that you have thought about introducing new hash calculation algorithms if needed. How do you expect this to wor

Re: [cfe-commits] r171885 - in /cfe/trunk/www/analyzer: annotations.html available_checks.html dev_cxx.html index.html xcode.html

Thanks, updated these links in r247999. In the future Anna's probably the right person to ping. Jordan > On Sep 17, 2015, at 6:57 , Aaron Ballman wrote: > > Sorry to resurrect an ancient commit, but... > > On Tue, Jan 8, 2013 at 2:29 PM, Jordan Rose wrote: >> Author: jrose >> Date: Tue Jan

r247999 - [analyzer] Update links to developer.apple.com.

Author: jrose Date: Fri Sep 18 11:12:16 2015 New Revision: 247999 URL: http://llvm.org/viewvc/llvm-project?rev=247999&view=rev Log: [analyzer] Update links to developer.apple.com. The content at the new links is /also/ a little dated, but that's our (Apple's) problem. Modified: cfe/trunk/www

r247997 - amdgpu-toolchain.c: Add a probe line temporally. Will revert later.

Author: chapuni Date: Fri Sep 18 10:56:16 2015 New Revision: 247997 URL: http://llvm.org/viewvc/llvm-project?rev=247997&view=rev Log: amdgpu-toolchain.c: Add a probe line temporally. Will revert later. Modified: cfe/trunk/test/Driver/amdgpu-toolchain.c Modified: cfe/trunk/test/Driver/amdgpu-

[PATCH] D12967: fix comments

hintonda created this revision. hintonda added a reviewer: alexfh. hintonda added a subscriber: cfe-commits. Herald added a subscriber: klimek. Fix example comments. http://reviews.llvm.org/D12967 Files: include/clang/Tooling/CommonOptionsParser.h Index: include/clang/Tooling/CommonOptionsPar

Re: [PATCH] D12571: [Analyzer] Fix assertions in commit r246345 (pr22954).

pgousseau added a comment. In http://reviews.llvm.org/D12571#248464, @dcoughlin wrote: > Here is a reduced test case: Very useful thanks ! Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:198 @@ +197,3 @@ + + // Return true if the destination buffer of the copy fun

r247995 - Use None instead of an explicit constructor.

Author: dougk Date: Fri Sep 18 10:23:16 2015 New Revision: 247995 URL: http://llvm.org/viewvc/llvm-project?rev=247995&view=rev Log: Use None instead of an explicit constructor. And remove a needless 'const' since ArrayRef is immutable. Both as suggested by dblaikie on cfe-commits. Modified:

Re: [PATCH] D12961: Update clang-tidy documentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL247987: Update clang-tidy documentation. (authored by angelgarcia). Changed prior to commit: http://reviews.llvm.org/D12961?vs=35080&id=35081#toc Repository: rL LLVM http://reviews.llvm.org/D12961

[clang-tools-extra] r247987 - Update clang-tidy documentation.

Author: angelgarcia Date: Fri Sep 18 09:08:57 2015 New Revision: 247987 URL: http://llvm.org/viewvc/llvm-project?rev=247987&view=rev Log: Update clang-tidy documentation. Summary: Update documentation of the modernize module with clang-modernize's documentation. Subscribers: cfe-commits, klimek

[PATCH] D12961: Update clang-tidy documentation.

angelgarcia created this revision. angelgarcia added subscribers: alexfh, klimek, cfe-commits. Update documentation of the modernize module with clang-modernize's documentation. http://reviews.llvm.org/D12961 Files: docs/clang-tidy/checks/modernize-loop-convert.rst docs/clang-tidy/checks/mo

Re: [PATCH] D12666: [LibClang] Fix clang_getCursorAvailability

milianw added a subscriber: milianw. milianw added a comment. Ping? Can someone please submit this upstream? http://reviews.llvm.org/D12666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D12726: [analyzer] A fix for symbolic element region index lifetime.

NoQ updated this revision to Diff 35067. NoQ added a comment. Thanks for the quick reply, sorry for the delay! Was afk for a couple of days. Yeah, right, in fact i didn't even fix the issue for store keys at all; only for store values and environment values. It also seems much harder to test st

Re: [PATCH] D10841: [Shave]: allow Clang to run the target linker.

dougk abandoned this revision. Comment at: lib/Driver/Tools.cpp:9110 @@ +9109,3 @@ + + const char *ToolsRoot = ::getenv("MV_TOOLS_DIR"); + // The version is numbered 'n.n.n.n' for arbitrary values that are opaque jyknight wrote: > Perhaps this should be a defaul

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

rengolin added a comment. Shouldn't we use -fplugin in the driver as well? Then translate to -load in cc1? Repository: rL LLVM http://reviews.llvm.org/D12903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

r247981 - Pass the relocation model to LLVM for assembler files.

Author: joerg Date: Fri Sep 18 06:13:43 2015 New Revision: 247981 URL: http://llvm.org/viewvc/llvm-project?rev=247981&view=rev Log: Pass the relocation model to LLVM for assembler files. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp cfe/trunk/tools/driver/cc1as_main.cpp Modified: cfe/t

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

john.brawn added a comment. In http://reviews.llvm.org/D12903#248453, @compnerd wrote: > Do you know if GCC requires the = or can you do -fplugin name.so ? GCC requires the =, or at least GCC 5.1.0 does when I tested it (you get "gcc: error: name.so: No such file or directory" and "gcc: error:

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

honggyu.kim added a comment. Hi Babati, Can you please rebase this patch based on http://reviews.llvm.org/D12673? It is just a whitespace cleanup patch and I wrote http://reviews.llvm.org/D12906 based on this patch after applying whitespace cleanup at the end of each line. http://reviews.llvm.o

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

honggyu.kim added a comment. Hi Anna and Gábor, I modified this patch based on http://reviews.llvm.org/D10305 following your comments. I think we can distinguish issue_hash and Bug ID. issue_hash is considered as a subset of Bug ID here. 1. issue_hash contains (1) column number (2) source lin

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

honggyu.kim updated the summary for this revision. honggyu.kim updated this revision to Diff 35070. http://reviews.llvm.org/D12906 Files: include/clang/StaticAnalyzer/Core/BugId.h lib/StaticAnalyzer/Core/BugId.cpp lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp lib/StaticAnalyzer/Core/PlistDi

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste marked 2 inline comments as done. Alexander_Droste added a comment. In http://reviews.llvm.org/D12761#248382, @zaks.anna wrote: > > > It's more user friendly to report this issue at the last point where the > > > request is available rather than the last line of the function. >

[PATCH] D12955: Fix assertion in inline assembler IR gen

amusman created this revision. amusman added reviewers: rsmith, aaron.ballman, ABataev. amusman added a subscriber: cfe-commits. Several inputs may not refer to one output constraint in inline assembler insertions, clang fails on assertion on such test case here: llvm/lib/IR/InlineAsm.cpp:46: ll

r247977 - clang/test/lit.cfg: *-ps4 doesn't have appropriate driver yet. Mark it as "non-clang-driver".

Author: chapuni Date: Fri Sep 18 03:11:36 2015 New Revision: 247977 URL: http://llvm.org/viewvc/llvm-project?rev=247977&view=rev Log: clang/test/lit.cfg: *-ps4 doesn't have appropriate driver yet. Mark it as "non-clang-driver". Modified: cfe/trunk/test/lit.cfg Modified: cfe/trunk/test/lit.c

r247976 - [OPENMP 4.0] Add 'if' clause for 'cancel' directive.

Author: abataev Date: Fri Sep 18 03:07:34 2015 New Revision: 247976 URL: http://llvm.org/viewvc/llvm-project?rev=247976&view=rev Log: [OPENMP 4.0] Add 'if' clause for 'cancel' directive. Add parsing, sema analysis and codegen for 'if' clause in 'cancel' directive. Added: cfe/trunk/test/OpenMP

  1   2   >