comex updated the summary for this revision.
comex updated this revision to Diff 34787.
comex added a comment.
Per vsk:
- Changed to an explicit switch, and changed ContainsPlaceholderType logic.
Note: Currently, GetDeclSpecTypeForDeclarator determines
ContainsPlaceholderType at two different l
On Mon, Sep 14, 2015 at 7:07 PM, Rachel Craik wrote:
> As of DR262, the C standard clarified that the width of a bit-field can
> not exceed that of the specified type, and this change was primarily to
> ensure that Clang correctly enforced this part of the standard. Looking at
> the C++11 standar
pekka.jaaskelainen accepted this revision.
pekka.jaaskelainen added a comment.
This revision is now accepted and ready to land.
The patch seems straightforward enough. BTW does someone know if anyone has
worked on the 'pipe' qualifier?
Comment at: lib/Serialization/ASTCommon.cp
On Mon, Sep 14, 2015 at 7:07 PM, Rachel Craik wrote:
> As of DR262, the C standard clarified that the width of a bit-field can
> not exceed that of the specified type, and this change was primarily to
> ensure that Clang correctly enforced this part of the standard. Looking at
> the C++11 standar
Author: awatry
Date: Mon Sep 14 22:56:21 2015
New Revision: 247661
URL: http://llvm.org/viewvc/llvm-project?rev=247661&view=rev
Log:
integer: Update integer limits to comply with spec
The values for the char/short/integer/long minimums were declared with
their actual values, not the definitions f
Sorry, I didn't notice while I was checking.
2015年9月15日(火) 12:29 Devin Coughlin via cfe-commits <
cfe-commits@lists.llvm.org>:
> Author: dcoughlin
> Date: Mon Sep 14 22:28:27 2015
> New Revision: 247660
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247660&view=rev
> Log:
> [analyzer] Restore b
jordan_rose added a comment.
Hm, interesting. I'm not sure this is even sufficient, though: what if I have a
FieldRegion that's a sub-region of an ElementRegion with a symbolic index?
RegionStore does everything by base regions, so we won't ever see that
intermediate region with the symbolic in
Author: dcoughlin
Date: Mon Sep 14 22:28:27 2015
New Revision: 247660
URL: http://llvm.org/viewvc/llvm-project?rev=247660&view=rev
Log:
[analyzer] Restore behavior change introduced by r247657.
r247657 fixed warnings about unused variables when compiling without asserts
but changed behavior. This
On Mon, Sep 14, 2015 at 6:03 PM, Richard Smith
wrote:
> On Mon, Sep 14, 2015 at 6:00 PM, David Majnemer via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: majnemer
>> Date: Mon Sep 14 20:00:55 2015
>> New Revision: 247651
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=247651&
Author: majnemer
Date: Mon Sep 14 21:36:41 2015
New Revision: 247659
URL: http://llvm.org/viewvc/llvm-project?rev=247659&view=rev
Log:
[MS ABI] Restore our warning for overwide bitfields using the MS ABI
This restores a diagnostic lost in r247651.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
As of DR262, the C standard clarified that the width of a bit-field can not
exceed that of the specified type, and this change was primarily to ensure
that Clang correctly enforced this part of the standard. Looking at the C+
+11 standard again, it states that although the specified width of a
bit
Author: chapuni
Date: Mon Sep 14 20:53:27 2015
New Revision: 247657
URL: http://llvm.org/viewvc/llvm-project?rev=247657&view=rev
Log:
ExprEngineObjC.cpp: Fix warnings. [-Wunused-variable]
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineObjC.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Co
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, rjmccall.
sfantao added subscribers: cfe-commits, Hahnfeld.
This patch rebases and creates a new revision for
http://reviews.llvm.org/D11361 as requested by John.
Here's the adapted original summary (the global captures is
On Mon, Sep 14, 2015 at 5:28 PM, Richard Smith
wrote:
> On Mon, Sep 14, 2015 at 5:18 PM, Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> This also fires for bool in C++ files, even though the commit message
>> saying C11 and _Bool. Given the test changes, I suppose that's i
On Mon, Sep 14, 2015 at 6:10 PM, David Majnemer
wrote:
> On Mon, Sep 14, 2015 at 6:01 PM, Richard Smith
> wrote:
>
>> On Mon, Sep 14, 2015 at 5:55 PM, David Majnemer > > wrote:
>>
>>> On Mon, Sep 14, 2015 at 5:40 PM, Richard Smith
>>> wrote:
>>>
On Mon, Sep 14, 2015 at 5:31 PM, David Majne
Author: chapuni
Date: Mon Sep 14 20:39:27 2015
New Revision: 247655
URL: http://llvm.org/viewvc/llvm-project?rev=247655&view=rev
Log:
ItaniumCXXABI.cpp: Fix a warning. [-Wunused-variable]
Modified:
cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp
Modified: cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp
URL:
Author: rsmith
Date: Mon Sep 14 20:28:55 2015
New Revision: 247654
URL: http://llvm.org/viewvc/llvm-project?rev=247654&view=rev
Log:
[modules] A using-declaration doesn't introduce a new entity, just a new name
for an existing entity, and as such a using-declaration doesn't need to
conflict with a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247653: [analyzer] Skip Pre/Post handlers for ObjC calls
when receiver is nil. (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D12123?vs=33836&id=34772#toc
Repository:
rL LL
Author: dcoughlin
Date: Mon Sep 14 20:13:53 2015
New Revision: 247653
URL: http://llvm.org/viewvc/llvm-project?rev=247653&view=rev
Log:
[analyzer] Skip Pre/Post handlers for ObjC calls when receiver is nil.
In Objective-C, method calls with nil receivers are essentially no-ops. They
do not fault
On Mon, Sep 14, 2015 at 6:01 PM, Richard Smith
wrote:
> On Mon, Sep 14, 2015 at 5:55 PM, David Majnemer
> wrote:
>
>> On Mon, Sep 14, 2015 at 5:40 PM, Richard Smith
>> wrote:
>>
>>> On Mon, Sep 14, 2015 at 5:31 PM, David Majnemer <
>>> david.majne...@gmail.com> wrote:
>>>
On Mon, Sep 14, 2
On Mon, Sep 14, 2015 at 6:00 PM, David Majnemer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: majnemer
> Date: Mon Sep 14 20:00:55 2015
> New Revision: 247651
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247651&view=rev
> Log:
> [MS ABI] Overwide bool bitfields should be permi
Author: majnemer
Date: Mon Sep 14 20:00:55 2015
New Revision: 247651
URL: http://llvm.org/viewvc/llvm-project?rev=247651&view=rev
Log:
[MS ABI] Overwide bool bitfields should be permitted
Overwide bool bitfields have eight bits of storage size, make sure we
take the padding into account when dete
On Mon, Sep 14, 2015 at 5:55 PM, David Majnemer
wrote:
> On Mon, Sep 14, 2015 at 5:40 PM, Richard Smith
> wrote:
>
>> On Mon, Sep 14, 2015 at 5:31 PM, David Majnemer > > wrote:
>>
>>> On Mon, Sep 14, 2015 at 5:28 PM, Richard Smith via cfe-commits <
>>> cfe-commits@lists.llvm.org> wrote:
>>>
Author: prazek
Date: Mon Sep 14 19:55:29 2015
New Revision: 247650
URL: http://llvm.org/viewvc/llvm-project?rev=247650&view=rev
Log:
small test bugfix
Modified:
cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp
Modified: cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp
URL:
http://llvm.org/v
On Mon, Sep 14, 2015 at 5:40 PM, Richard Smith
wrote:
> On Mon, Sep 14, 2015 at 5:31 PM, David Majnemer
> wrote:
>
>> On Mon, Sep 14, 2015 at 5:28 PM, Richard Smith via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> On Mon, Sep 14, 2015 at 5:18 PM, Nico Weber via cfe-commits <
>>> cf
rtrieu added a comment.
In http://reviews.llvm.org/D12379#245868, @zhengkai wrote:
> In http://reviews.llvm.org/D12379#245861, @rtrieu wrote:
>
> > In http://reviews.llvm.org/D12379#245850, @zhengkai wrote:
> >
> > > In http://reviews.llvm.org/D12379#245849, @rtrieu wrote:
> > >
> > > > Why are y
On Mon, Sep 14, 2015 at 5:31 PM, David Majnemer
wrote:
> On Mon, Sep 14, 2015 at 5:28 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Mon, Sep 14, 2015 at 5:18 PM, Nico Weber via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> This also fires for bool i
Prazek closed this revision.
Prazek added a comment.
Assume loads released.
http://reviews.llvm.org/D12865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: prazek
Date: Mon Sep 14 19:37:06 2015
New Revision: 247646
URL: http://llvm.org/viewvc/llvm-project?rev=247646&view=rev
Log:
Generating assumption loads of vptr after ctor call (fixed)
Generating call assume(icmp %vtable, %global_vtable) after constructor
call for devirtualization purpose
On Mon, Sep 14, 2015 at 5:28 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Sep 14, 2015 at 5:18 PM, Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> This also fires for bool in C++ files, even though the commit message
>> saying C11 and _Boo
On Mon, Sep 14, 2015 at 5:18 PM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> This also fires for bool in C++ files, even though the commit message
> saying C11 and _Bool. Given the test changes, I suppose that's intentional?
> This fires a lot on existing code, for example pr
Author: scanon
Date: Mon Sep 14 19:21:56 2015
New Revision: 247643
URL: http://llvm.org/viewvc/llvm-project?rev=247643&view=rev
Log:
Prevent implicit re-interpret casts between ExtVector and Scalar types.
Previously, in certain cases lax vector conversions could occur between scalar
floating-poi
It affects for targeting MS.
Tweaked one test in r247640. You can emulate to add -mms-bitfields.
On Tue, Sep 15, 2015 at 6:29 AM Rachel Craik via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rcraik
> Date: Mon Sep 14 16:27:36 2015
> New Revision: 247618
>
> URL: http://llvm.org/vie
zhengkai added a comment.
In http://reviews.llvm.org/D12379#245861, @rtrieu wrote:
> In http://reviews.llvm.org/D12379#245850, @zhengkai wrote:
>
> > In http://reviews.llvm.org/D12379#245849, @rtrieu wrote:
> >
> > > Why are you leaking the raw encoding of locations from the SourceManager?
> > >
This also fires for bool in C++ files, even though the commit message
saying C11 and _Bool. Given the test changes, I suppose that's intentional?
This fires a lot on existing code, for example protobuf:
../../third_party/protobuf/src/google/protobuf/extension_set.h:465:10:
error: width of bit-fiel
rtrieu added a comment.
In http://reviews.llvm.org/D12379#245850, @zhengkai wrote:
> In http://reviews.llvm.org/D12379#245849, @rtrieu wrote:
>
> > Why are you leaking the raw encoding of locations from the SourceManager?
> > This is an internal implementation detail and should not be relied on
Prazek added inline comments.
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:394-406
@@ +393,15 @@
+
+for (const auto &VtableComponent : VtableLayout.vtable_components()) {
+ if (VtableComponent.isRTTIKind()) {
+const CXXRecordDecl *RTTIDecl = VtableComponent.getRTTIDe
Prazek updated this revision to Diff 34761.
Prazek marked 3 inline comments as done.
http://reviews.llvm.org/D12865
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/vtable-assume-load.cpp
test/CodeGenCXX/vtable-available-exte
zhengkai added a comment.
In http://reviews.llvm.org/D12379#245849, @rtrieu wrote:
> Why are you leaking the raw encoding of locations from the SourceManager?
> This is an internal implementation detail and should not be relied on
> externally. SourceLocation is the typical way to use locatio
rtrieu added a comment.
Why are you leaking the raw encoding of locations from the SourceManager? This
is an internal implementation detail and should not be relied on externally.
SourceLocation is the typical way to use locations.
http://reviews.llvm.org/D12379
__
Author: chapuni
Date: Mon Sep 14 18:50:08 2015
New Revision: 247640
URL: http://llvm.org/viewvc/llvm-project?rev=247640&view=rev
Log:
clang/test/CodeGenCXX/2009-04-23-bool2.cpp: Avoid -mms-bitfields to add
explicit triple.
FIXME: Better way to cancel -mms-bitfields?
Modified:
cfe/trunk/test
zaks.anna requested changes to this revision.
zaks.anna added a comment.
This revision now requires changes to proceed.
Thanks for working on this!
Comments inline.
Comment at: tools/clang/lib/StaticAnalyzer/Checkers/Checkers.td:524
@@ +523,3 @@
+def MPIChecker : Checker<"MPI-C
From the driver point of view, how does it know if it is targeting
illumos or solaris? Do they use different triples?
In any case, if there is interest in the future this patch can be
extended to work on illumos by
* Creating a shouldUseCxaAtexitByDefault and passing in whatever
information is ne
Author: rafael
Date: Mon Sep 14 18:21:31 2015
New Revision: 247634
URL: http://llvm.org/viewvc/llvm-project?rev=247634&view=rev
Log:
[Solaris] Default to -fno-cxa-finalize.
There is no __cxa_finalize symbol available on recent Solaris OS
versions, so we need this flag to make non trivial C++ prog
majnemer added inline comments.
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:394-406
@@ +393,15 @@
+
+for (const auto &VtableComponent : VtableLayout.vtable_components()) {
+ if (VtableComponent.isRTTIKind()) {
+const CXXRecordDecl *RTTIDecl = VtableComponent.getRTTI
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:399-400
@@ +398,4 @@
+ return true;
+ }
+ else if (VtableComponent.isUsedFunctionPointerKind()) {
+co
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:419
@@ +418,3 @@
+ // assumption the user is trying to modernize their codebase.
+ if (getLangOpts().CPlusPlus) {
+Finder->addMatcher(makeArrayLoopMatcher(), this);
Now you c
Prazek updated this revision to Diff 34750.
http://reviews.llvm.org/D12865
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/vtable-assume-load.cpp
test/CodeGenCXX/vtable-available-externally.cpp
Index: test/CodeGenCXX/vtable
Prazek created this revision.
Prazek added reviewers: rsmith, rjmccall, hans, majnemer.
Prazek added a subscriber: cfe-commits.
http://reviews.llvm.org/D12865
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/vtable-assume-load.
jyknight added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3929
@@ +3928,3 @@
+: Generic_GCC(D, Triple, Args) {
+ // If a target of 'sparc-myriad-elf' is specified to clang, it wants to use
+ // 'sparc-myriad--elf' (note the unknown OS) as the canonical triple.
--
MyDeveloperDay updated this revision to Diff 34741.
MyDeveloperDay added a comment.
Handle subsequent catch statements
http://reviews.llvm.org/D12492
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/UnwrappedLineParser.cpp
unittest
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247624: [WebAssembly] Define the atomic type sizes (authored
by djg).
Changed prior to commit:
http://reviews.llvm.org/D12862?vs=34731&id=34739#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12862
Author: djg
Date: Mon Sep 14 16:56:37 2015
New Revision: 247624
URL: http://llvm.org/viewvc/llvm-project?rev=247624&view=rev
Log:
[WebAssembly] Define the atomic type sizes
WebAssembly's spec has now been updated to specify some guarantees
about lock free atomic accesses. Update clang to match.
Author: djg
Date: Mon Sep 14 16:54:32 2015
New Revision: 247623
URL: http://llvm.org/viewvc/llvm-project?rev=247623&view=rev
Log:
[WebAssembly] Simplify code by avoiding duplicating the default behavior.
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247622: [WebAssembly] Use "long long" for int_fast64_t and
int_least64_t on wasm64 (authored by djg).
Changed prior to commit:
http://reviews.llvm.org/D12861?vs=34727&id=34738#toc
Repository:
rL LLVM
Author: djg
Date: Mon Sep 14 16:49:41 2015
New Revision: 247622
URL: http://llvm.org/viewvc/llvm-project?rev=247622&view=rev
Log:
[WebAssembly] Use "long long" for int_fast64_t and int_least64_t on wasm64
This makes int_fast64_t and int_least64_t the same type as int64_t, and
eliminates a differe
On Mon, Sep 14, 2015 at 5:47 PM, Daniel Jasper wrote:
> Btw, I think generating them, potentially into several different headers to
> work around the compile time issue isn't such a bad idea.
I'm not going to start with this approach, but think it may be worth
exploring at some point. ;-)
~Aaron
On Mon, Sep 14, 2015 at 5:44 PM, Daniel Jasper wrote:
> Ok. I am happy with this then.
>
> (Just personally grumpy having to write
> cxxRecordDecl(has(cxxConstructorDecl(..))) in the future ;-) ).
I share your grumpiness about the cxxConstructorDecl, but probably
won't share it when we add objcCo
Btw, I think generating them, potentially into several different headers to
work around the compile time issue isn't such a bad idea.
On Mon, Sep 14, 2015 at 11:45 PM, Manuel Klimek wrote:
> Feel free to rename the AST nodes :)
>
> On Mon, Sep 14, 2015, 2:44 PM Daniel Jasper wrote:
>
>> Ok. I a
Feel free to rename the AST nodes :)
On Mon, Sep 14, 2015, 2:44 PM Daniel Jasper wrote:
> Ok. I am happy with this then.
>
> (Just personally grumpy having to write
> cxxRecordDecl(has(cxxConstructorDecl(..))) in the future ;-) ).
>
> On Mon, Sep 14, 2015 at 11:41 PM, Manuel Klimek wrote:
>
>>
Ok. I am happy with this then.
(Just personally grumpy having to write
cxxRecordDecl(has(cxxConstructorDecl(..))) in the future ;-) ).
On Mon, Sep 14, 2015 at 11:41 PM, Manuel Klimek wrote:
>
>
> On Mon, Sep 14, 2015 at 2:29 PM Aaron Ballman
> wrote:
>
>> On Mon, Sep 14, 2015 at 4:38 PM, Manue
On Mon, Sep 14, 2015 at 2:29 PM Aaron Ballman
wrote:
> On Mon, Sep 14, 2015 at 4:38 PM, Manuel Klimek wrote:
> >
> >
> > On Mon, Sep 14, 2015 at 12:26 PM Aaron Ballman
> > wrote:
> >>
> >> On Mon, Sep 14, 2015 at 2:45 PM, Daniel Jasper
> wrote:
> >> > By this point, I see that change might be
Author: eugenis
Date: Mon Sep 14 16:35:16 2015
New Revision: 247620
URL: http://llvm.org/viewvc/llvm-project?rev=247620&view=rev
Log:
Revert "Always_inline codegen rewrite" and 2 follow-ups.
Revert "Update cxx-irgen.cpp test to allow signext in alwaysinline functions."
Revert "[CodeGen] Remove wr
andreybokhanko added a comment.
OK -- I removed the check in Itanium ABI part, restored back the test and
committed the patch.
Thanks for reviewing!
Repository:
rL LLVM
http://reviews.llvm.org/D12402
___
cfe-commits mailing list
cfe-commits@lis
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247619: PR24595: Ignore calling convention modifiers for
structors in MS ABI. (authored by asbokhan).
Changed prior to commit:
http://reviews.llvm.org/D12402?vs=34477&id=34735#toc
Repository:
rL LLVM
Author: asbokhan
Date: Mon Sep 14 16:29:57 2015
New Revision: 247619
URL: http://llvm.org/viewvc/llvm-project?rev=247619&view=rev
Log:
PR24595: Ignore calling convention modifiers for structors in MS ABI.
MS compiler ignores calling convention modifiers for structors. This patch makes
clang do th
Author: rcraik
Date: Mon Sep 14 16:27:36 2015
New Revision: 247618
URL: http://llvm.org/viewvc/llvm-project?rev=247618&view=rev
Log:
C11 _Bool bitfield diagnostic
Summary: Implement DR262 (for C). This patch will mainly affect bitfields of
type _Bool
Reviewers: fraggamuffin, rsmith
Subscribers
On Mon, Sep 14, 2015 at 4:38 PM, Manuel Klimek wrote:
>
>
> On Mon, Sep 14, 2015 at 12:26 PM Aaron Ballman
> wrote:
>>
>> On Mon, Sep 14, 2015 at 2:45 PM, Daniel Jasper wrote:
>> > By this point, I see that change might be profitable overall. However,
>> > lets
>> > completely map this out. Chan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247617: [analyzer] Update SATestBuild.py to set -isysroot
for preprocessed files (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D12769?vs=34471&id=34733#toc
Repository:
rL
Author: dcoughlin
Date: Mon Sep 14 16:22:24 2015
New Revision: 247617
URL: http://llvm.org/viewvc/llvm-project?rev=247617&view=rev
Log:
[analyzer] Update SATestBuild.py to set -isysroot for preprocessed files
Update the static analyzer buildbot script to set -isysroot to the OS X SDK path
when an
klimek added a comment.
First round of comments; some things are still a bit confusing, so I hope
another round will help to weed them out.
Comment at: include/clang/Tooling/Core/Replacement.h:223-224
@@ -222,1 +222,4 @@
+/// \brief Merges to sets of replacements with the sec
jfb accepted this revision.
jfb added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D12862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
jfb accepted this revision.
jfb added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D12861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
sunfish created this revision.
sunfish added a reviewer: jfb.
sunfish added a subscriber: cfe-commits.
sunfish set the repository for this revision to rL LLVM.
Herald added subscribers: dschuff, jfb.
WebAssembly's spec has now been updated to specify some [guarantees about lock
free atomic access
dougk updated this revision to Diff 34729.
dougk added a comment.
Delete the overrides of getTool() and buildAssembler() in MyriadToolChain.
http://reviews.llvm.org/D12541
Files:
lib/Driver/Driver.cpp
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.cpp
lib/Driver/To
On Mon, Sep 14, 2015 at 12:26 PM Aaron Ballman
wrote:
> On Mon, Sep 14, 2015 at 2:45 PM, Daniel Jasper wrote:
> > By this point, I see that change might be profitable overall. However,
> lets
> > completely map this out. Changing just cxxRecordDecl() can actually
> increase
> > confusion in othe
cdavis5x added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3598
@@ -3599,1 +3597,3 @@
+Address CodeGenFunction::EmitVAArg(Address VAListAddr, QualType Ty, bool IsMS)
{
+ return CGM.getTypes().getABIInfo().EmitVAArg(*this, VAListAddr, Ty, IsMS);
}
rjmcca
sunfish created this revision.
sunfish added a reviewer: jfb.
sunfish added a subscriber: cfe-commits.
sunfish set the repository for this revision to rL LLVM.
Herald added subscribers: dschuff, jfb.
This makes int_fast64_t and int_least64_t the same type as int64_t, and
eliminates a difference b
cdavis5x updated this revision to Diff 34728.
cdavis5x added a comment.
Address review comments.
- Pull out `va_arg` emission on `__builtin_ms_va_arg` to its own method on
`ABIInfo`. That way, ABI implementers don't need to care that this extension
even exists.
- Attempt to push repeated `va_ar
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247614: [Static Analyzer] Turn on some nullability checks by
default. (authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D12858?vs=34720&id=34726#toc
Repository:
rL LLVM
http://re
Author: xazax
Date: Mon Sep 14 15:34:06 2015
New Revision: 247614
URL: http://llvm.org/viewvc/llvm-project?rev=247614&view=rev
Log:
[Static Analyzer] Turn on some nullability checks by default.
Differential Revision: http://reviews.llvm.org/D12858
Modified:
cfe/trunk/lib/Driver/Tools.cpp
M
Author: xazax
Date: Mon Sep 14 15:31:46 2015
New Revision: 247612
URL: http://llvm.org/viewvc/llvm-project?rev=247612&view=rev
Log:
[Static Analyzer] Nullability checker optimization.
Differential Revision: http://reviews.llvm.org/D12848
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/Nulla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247612: [Static Analyzer] Nullability checker optimization.
(authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D12848?vs=34693&id=34725#toc
Repository:
rL LLVM
http://reviews.llvm
Author: dougk
Date: Mon Sep 14 15:31:28 2015
New Revision: 247611
URL: http://llvm.org/viewvc/llvm-project?rev=247611&view=rev
Log:
Driver should forward at most one gdwarf-N flag to cc1as.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/integrated-as.s
Modified: cfe/trunk
dirty added a comment.
Ping?
http://reviews.llvm.org/D12774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo accepted this revision.
echristo added a comment.
One set of inline comments, and also:
test/Driver/Inputs/scei-ps4_tree/target/include_common/.keep
eh?
-eric
Comment at: lib/Driver/Tools.cpp:10025-10029
@@ +10024,7 @@
+ const char *Exec =
+#ifdef LLVM_ON_WIN32
+
zaks.anna added inline comments.
Comment at: test/Analysis/free.c:1
@@ -1,2 +1,2 @@
-// RUN: %clang_cc1 -analyze -analyzer-store=region
-analyzer-checker=core,unix.Malloc -fblocks -verify %s
+// RUN: %clang_cc1 -analyze -analyzer-store=region
-analyzer-checker=core,unix.Malloc -
r247603
On 7 September 2015 at 13:22, Xan López via cfe-commits
wrote:
> On Mon, Sep 07, 2015 at 09:07:41AM -0700, Saleem Abdulrasool wrote:
>> > Basically check that -lc is present when clang is called in a certain
>> > way I guess? Or something more sophisticated?
>>
>>
>> Yeah, that it is pres
Author: rafael
Date: Mon Sep 14 14:30:53 2015
New Revision: 247603
URL: http://llvm.org/viewvc/llvm-project?rev=247603&view=rev
Log:
[Solaris] Add -lc also when linking shared libraries
This is actually needed, otherwise libc won't be added at all. For
instance when building libclang.so all the l
On Mon, Sep 14, 2015 at 2:45 PM, Daniel Jasper wrote:
> By this point, I see that change might be profitable overall. However, lets
> completely map this out. Changing just cxxRecordDecl() can actually increase
> confusion in other areas. Right now, not a single AST matcher has the cxx
> prefix (a
On Mon, Sep 14, 2015 at 11:45 AM Daniel Jasper wrote:
> By this point, I see that change might be profitable overall. However,
> lets completely map this out. Changing just cxxRecordDecl() can actually
> increase confusion in other areas. Right now, not a single AST matcher has
> the cxx prefix (
xazax.hun created this revision.
xazax.hun added reviewers: zaks.anna, dcoughlin, jordan_rose.
xazax.hun added a subscriber: cfe-commits.
This patch turns on some of the nullability related patches by default. These
checks has low false positive rate.
http://reviews.llvm.org/D12858
Files:
li
Thanks!
On Mon, Sep 14, 2015 at 10:50 AM, Samuel F Antao wrote:
> Hi Evgeniy,
>
> I commit a small change to one of the regression tests to allow a signext to
> be generated: http://reviews.llvm.org/rL247584.
>
> It was causing an error in Power8 targets. In my view is an harmless change
> but yo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247598: [Static Analyzer] Relaxing a caching out related
assert. (authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D12818?vs=34579&id=34719#toc
Repository:
rL LLVM
http://reviews
Author: xazax
Date: Mon Sep 14 14:00:08 2015
New Revision: 247598
URL: http://llvm.org/viewvc/llvm-project?rev=247598&view=rev
Log:
[Static Analyzer] Relaxing a caching out related assert.
Differential Revision: http://reviews.llvm.org/D12818
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/Expr
Author: rjmccall
Date: Mon Sep 14 13:57:08 2015
New Revision: 247597
URL: http://llvm.org/viewvc/llvm-project?rev=247597&view=rev
Log:
Fix a nasty bug with the partial destruction of nested arrays;
it escaped notice because it's only used for heterogeneous
initialization.
rdar://21397946
Modifie
Author: xazax
Date: Mon Sep 14 13:48:55 2015
New Revision: 247595
URL: http://llvm.org/viewvc/llvm-project?rev=247595&view=rev
Log:
[Static Analyzer] Moving nullability checkers out of alpha.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/Checkers.td
cfe/trunk/test/Analysis/nullability.m
george.burgess.iv added inline comments.
Comment at: lib/AST/ExprConstant.cpp:4457-4460
@@ -4434,1 +4456,6 @@
+// Because we set the Base to be the MemberExpr instead of E->getBase(),
the
+// Offset should be from the MemberExpr instead of the MemberExpr's base.
+if
george.burgess.iv updated this revision to Diff 34710.
george.burgess.iv marked 4 inline comments as done.
george.burgess.iv added a comment.
Addressed all feedback -- added a walk of the Designator as suggested.
Regarding `isDesignatorAtObjectEnd`: I'm assuming that the Index returned by
`Field
By this point, I see that change might be profitable overall. However, lets
completely map this out. Changing just cxxRecordDecl() can actually
increase confusion in other areas. Right now, not a single AST matcher has
the cxx prefix (although a total of 28 stand for the corresponding CXX..
AST nod
1 - 100 of 148 matches
Mail list logo
