[libcxx] r246914 - Try and fix broken bugzilla link

2015-09-04 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Sep 5 01:57:29 2015 New Revision: 246914 URL: http://llvm.org/viewvc/llvm-project?rev=246914&view=rev Log: Try and fix broken bugzilla link Modified: libcxx/trunk/docs/index.rst Modified: libcxx/trunk/docs/index.rst URL: http://llvm.org/viewvc/llvm-project/libcxx/t

[libcxx] r246913 - Cleanup new documentation index and transfer more information from www/index.html

2015-09-04 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Sep 5 01:50:03 2015 New Revision: 246913 URL: http://llvm.org/viewvc/llvm-project?rev=246913&view=rev Log: Cleanup new documentation index and transfer more information from www/index.html Modified: libcxx/trunk/docs/index.rst Modified: libcxx/trunk/docs/index.rst

Re: [PATCH] D12169: Relax constexpr rules to improve __builtin_object_size's accuracy

2015-09-04 Thread Steven Wu via cfe-commits
steven_wu added a subscriber: steven_wu. steven_wu added a comment. This commit seems to cause miscompile in LNT testsuite with -O0 and -O3 http://lab.llvm.org:8080/green/job/perf_o0g_run/7070/warnings2Result/new/ http://lab.llvm.org:8080/green/job/perf_o3lto_run/15591/warnings2Result/new/ Looks

[libcxx] r246912 - Remove test commit.

2015-09-04 Thread Tanya Lattner via cfe-commits
Author: tbrethou Date: Sat Sep 5 00:38:50 2015 New Revision: 246912 URL: http://llvm.org/viewvc/llvm-project?rev=246912&view=rev Log: Remove test commit. Modified: libcxx/trunk/docs/README.txt Modified: libcxx/trunk/docs/README.txt URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/docs

[libcxx] r246911 - Test temporary commit.

2015-09-04 Thread Tanya Lattner via cfe-commits
Author: tbrethou Date: Sat Sep 5 00:34:27 2015 New Revision: 246911 URL: http://llvm.org/viewvc/llvm-project?rev=246911&view=rev Log: Test temporary commit. Modified: libcxx/trunk/docs/README.txt Modified: libcxx/trunk/docs/README.txt URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/

[libcxx] r246910 - Test commit for builder

2015-09-04 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Sep 5 00:29:23 2015 New Revision: 246910 URL: http://llvm.org/viewvc/llvm-project?rev=246910&view=rev Log: Test commit for builder Modified: libcxx/trunk/docs/Makefile.sphinx libcxx/trunk/docs/index.rst Modified: libcxx/trunk/docs/Makefile.sphinx URL: http://ll

[libcxx] r246909 - Add temporary Makefile.sphinx build file to get libcxx.llvm.org/docs going

2015-09-04 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Sep 5 00:12:04 2015 New Revision: 246909 URL: http://llvm.org/viewvc/llvm-project?rev=246909&view=rev Log: Add temporary Makefile.sphinx build file to get libcxx.llvm.org/docs going Added: libcxx/trunk/docs/Makefile.sphinx Added: libcxx/trunk/docs/Makefile.sphinx UR

Re: [PATCH] Expose diagnostic formatting to Python bindings

2015-09-04 Thread Omar Sandoval via cfe-commits
On Fri, Aug 07, 2015 at 11:35:26PM -0700, Omar Sandoval wrote: > This makes it easier for tools using the Python libclang bindings to > display diagnostics in a manner consistent with clang. Ping, any comments on this? Thanks. > --- > bindings/python/clang/cindex.py | 33 +++

Re: [PATCH] D12466: Fix empty -L Path on OSX hosts

2015-09-04 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. This looks fine, just make sure the indentation is right. Phab seems confused. Repository: rL LLVM http://reviews.llvm.org/D12466 ___ cfe-commits ma

[libcxx] r246906 - Try building docs again.

2015-09-04 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Sep 4 20:32:48 2015 New Revision: 246906 URL: http://llvm.org/viewvc/llvm-project?rev=246906&view=rev Log: Try building docs again. Modified: libcxx/trunk/docs/index.rst Modified: libcxx/trunk/docs/index.rst URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/doc

Re: [PATCH] D12435: [Concepts] Add diagnostic; invalid specifier on function or variable concept declaration

2015-09-04 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D12435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: [PATCH] D12087: always_inline codegen rewrite

2015-09-04 Thread Evgeniy Stepanov via cfe-commits
eugenis added inline comments. Comment at: lib/CodeGen/CodeGenModule.h:505 @@ +504,3 @@ + + llvm::SmallVector AlwaysInlineFunctions; + Right. Sorry I missed the comment. I've switched this to a vector. Repository: rL LLVM http://reviews.llvm.org/D12087 __

Re: [PATCH] D12087: always_inline codegen rewrite

2015-09-04 Thread Evgeniy Stepanov via cfe-commits
eugenis updated this revision to Diff 34095. Repository: rL LLVM http://reviews.llvm.org/D12087 Files: lib/CodeGen/CGCXX.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h lib/CodeGen/ItaniumCXXABI.cpp test/CodeGe

Re: [PATCH] D12087: always_inline codegen rewrite

2015-09-04 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/CodeGen/CodeGenModule.h:505 @@ +504,3 @@ + + llvm::SetVector AlwaysInlineFunctions; + Did you try making this a vector? It'd be nice to avoid the set overhead here if we can. Repository: rL LLVM http://reviews.l

Re: [PATCH] D12616: Failing test highlighting no poisoning if dtor undeclared.

2015-09-04 Thread Evgeniy Stepanov via cfe-commits
eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. I'd call the test sanitize-dtor-trivial.cpp http://reviews.llvm.org/D12616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

Re: [PATCH] D12616: Failing test highlighting no poisoning if dtor undeclared.

2015-09-04 Thread Naomi Musgrave via cfe-commits
nmusgrave updated this revision to Diff 34094. nmusgrave marked an inline comment as done. nmusgrave added a comment. - Only check simplest object for existence of sanitizing callback. http://reviews.llvm.org/D12616 Files: test/CodeGenCXX/sanitize-dtor-generated.cpp Index: test/CodeGenCXX/sa

Re: [PATCH] D12453: [CUDA] Allow function overloads based on host/device attributes.

2015-09-04 Thread Richard Smith via cfe-commits
rsmith accepted this revision. Comment at: lib/AST/ItaniumMangle.cpp:504 @@ +503,3 @@ + if (FD->hasAttr() && FD->hasAttr()) +Out << "Ua6deviceUa4host"; + If we have `enable_if` on a `__host__` `__device__` function, I think we should mangle as `Ua6deviceUa9e

[libcxx] r246895 - Test commit for sphinx docs try2

2015-09-04 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Sep 4 18:19:11 2015 New Revision: 246895 URL: http://llvm.org/viewvc/llvm-project?rev=246895&view=rev Log: Test commit for sphinx docs try2 Modified: libcxx/trunk/docs/index.rst Modified: libcxx/trunk/docs/index.rst URL: http://llvm.org/viewvc/llvm-project/libcxx/t

Re: [PATCH] D11397: [libcxx] Add first bits of

2015-09-04 Thread Eric Fiselier via cfe-commits
EricWF added a comment. @mclow.lists ping. Hopefully this should be a pretty simple review. http://reviews.llvm.org/D11397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r246893 - Test commit to see if libcxx.llvm.org/docs builds

2015-09-04 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Sep 4 17:57:00 2015 New Revision: 246893 URL: http://llvm.org/viewvc/llvm-project?rev=246893&view=rev Log: Test commit to see if libcxx.llvm.org/docs builds Modified: libcxx/trunk/TODO.TXT Modified: libcxx/trunk/TODO.TXT URL: http://llvm.org/viewvc/llvm-project/lib

Re: r245036 - Add structed way to express command line options in the compilation database.

2015-09-04 Thread Hans Wennborg via cfe-commits
On Fri, Aug 14, 2015 at 2:55 AM, Manuel Klimek via cfe-commits wrote: > Author: klimek > Date: Fri Aug 14 04:55:36 2015 > New Revision: 245036 > > URL: http://llvm.org/viewvc/llvm-project?rev=245036&view=rev > Log: > Add structed way to express command line options in the compilation database. > >

[PATCH] D12652: [Static Analyzer] Lambda support.

2015-09-04 Thread Gábor Horváth via cfe-commits
xazax.hun created this revision. xazax.hun added reviewers: dcoughlin, zaks.anna, jordan_rose, ted. xazax.hun added a subscriber: cfe-commits. This patch adds lambda support for the static analyzer. All of my initial tests are passed. Before this patch each time a LambdaExpr was encountered a sin

r246890 - Fix a bug in __builtin_object_size cast removal

2015-09-04 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Fri Sep 4 17:36:18 2015 New Revision: 246890 URL: http://llvm.org/viewvc/llvm-project?rev=246890&view=rev Log: Fix a bug in __builtin_object_size cast removal Apparently there are many cast kinds that may cause implicit pointer arithmetic to happen. In light of this, the cast

r246889 - Relax partial-init test case for ARM

2015-09-04 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Sep 4 17:32:51 2015 New Revision: 246889 URL: http://llvm.org/viewvc/llvm-project?rev=246889&view=rev Log: Relax partial-init test case for ARM Modified: cfe/trunk/test/CodeGenCXX/partial-init.cpp Modified: cfe/trunk/test/CodeGenCXX/partial-init.cpp URL: http://llvm.o

Re: [PATCH][www] Mention that libcxx is necessary on OS X

2015-09-04 Thread Yuri Gribov via cfe-commits
Oh, nice so this was actually done by Kuba to fix sanitizer unittests: "echo '#include ' | ${COMPILER_RT_TEST_COMPILER} -E -x c++ - > /dev/null" "if [ $? != 0 ] " " then echo" " echo 'Your just-built clang cannot find C++ headers, which are needed to build and run compile

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

2015-09-04 Thread Ismail Pazarbasi via cfe-commits
ismailp added a comment. Thank you for the feedback! I have added the test in a C file, so we can get the first part of the patch in -- between lines 778-780. I think self-loop is a different problem, and that requires its own patch. I'll see what I can do about self-loop, if someone else isn't

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

2015-09-04 Thread Ismail Pazarbasi via cfe-commits
ismailp updated this revision to Diff 34082. ismailp added a comment. - Rolled back to the first version of patch, where only parameter `Out` is renamed to `OutStream` - Use a different test that doesn't trigger the self-loop assertion. http://reviews.llvm.org/D12119 Files: lib/StaticAnalyze

r246882 - Don't crash on a self-alias declaration

2015-09-04 Thread Hal Finkel via cfe-commits
Author: hfinkel Date: Fri Sep 4 16:49:21 2015 New Revision: 246882 URL: http://llvm.org/viewvc/llvm-project?rev=246882&view=rev Log: Don't crash on a self-alias declaration We were crashing in CodeGen given input like this: int self_alias(void) __attribute__((weak, alias("self_alias"))); suc

r246881 - Fix crash on invalid if we can't find a suitable PCH file in a specified

2015-09-04 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Sep 4 16:44:32 2015 New Revision: 246881 URL: http://llvm.org/viewvc/llvm-project?rev=246881&view=rev Log: Fix crash on invalid if we can't find a suitable PCH file in a specified directory, and our frontend action cares whether the frontend setup actually succeeded. Mod

Re: [PATCH] D12508: [libcxx] Make it drastically simpler to link libc++.

2015-09-04 Thread Jonathan Roelofs via cfe-commits
jroelofs added a comment. I trust your judgement. http://reviews.llvm.org/D12508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12462: [PATCH] [clang-tidy] Add inconsistent declaration parameter name check

2015-09-04 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Sorry for the long delay. This version looks significantly better. Thank you for the updates! Comment at: clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp:1 @@ +1,2 @@ +//===--- InconsistentDeclarationParameterNameCheck.cpp - +//clan

Re: [PATCH] D12412: [CodeGen] Point empty %invoke.cont block to successor

2015-09-04 Thread Reid Kleckner via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246880: Don't use unreachable as a placeholder, it confuses EmitBlock (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D12412?vs=33347&id=34080#toc Repository: rL LLVM http://revi

Re: [PATCH] D12508: [libcxx] Make it drastically simpler to link libc++.

2015-09-04 Thread Eric Fiselier via cfe-commits
EricWF added inline comments. Comment at: utils/gen_link_script/gen_link_script.py:1 @@ +1,2 @@ +#!/usr/bin/env python +import os jroelofs wrote: > Do you foresee these linker scripts being significantly more complicated for > other platforms? ISTM that it would

r246880 - Don't use unreachable as a placeholder, it confuses EmitBlock

2015-09-04 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Sep 4 16:39:15 2015 New Revision: 246880 URL: http://llvm.org/viewvc/llvm-project?rev=246880&view=rev Log: Don't use unreachable as a placeholder, it confuses EmitBlock This fixes an issue raised in D12412, where we generated invalid IR. Thanks to Vedant Kumar for coming u

[clang-tools-extra] r246879 - Avoid repeated replacements on loop-convert check.

2015-09-04 Thread Angel Garcia Gomez via cfe-commits
Author: angelgarcia Date: Fri Sep 4 16:37:05 2015 New Revision: 246879 URL: http://llvm.org/viewvc/llvm-project?rev=246879&view=rev Log: Avoid repeated replacements on loop-convert check. Summary: The InitListExpr subtree is visited twice, this caused the check to do multiple replacements. Adde

Re: [PATCH] D12169: Relax constexpr rules to improve __builtin_object_size's accuracy

2015-09-04 Thread George Burgess IV via cfe-commits
george.burgess.iv closed this revision. george.burgess.iv marked 2 inline comments as done. george.burgess.iv added a comment. r246877. Thanks for the review! (Also: Forgot to submit comments with the most recent revision, so you're getting them all now. Sorry. :) ) Comment at

r246877 - Increase accuracy of __builtin_object_size.

2015-09-04 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Fri Sep 4 16:28:13 2015 New Revision: 246877 URL: http://llvm.org/viewvc/llvm-project?rev=246877&view=rev Log: Increase accuracy of __builtin_object_size. Improvements: - For all types, we would give up in a case such as: __builtin_object_size((char*)&foo, N); even if w

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

2015-09-04 Thread Eric Fiselier via cfe-commits
EricWF added a comment. In http://reviews.llvm.org/D12512#237175, @joerg wrote: > Please don't commit this as is. Many platforms have posix_memalign or > equivalent, which makes this both simpler and potentially without wasting > memory. Compare e.g. http://reviews.llvm.org/D12001. Will do. A

Re: [PATCH] D11380: Implement LFTS searchers. Boyer_Moore and Boyer_Moore_Horspool

2015-09-04 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM modulo handling C++03. Currently compiles w/ clang in C++03. Please either ensure your portions of the searchers also compile in C++03 and change the tests or #ifdef them out before comm

Re: [PATCH] D12412: [CodeGen] Point empty %invoke.cont block to successor

2015-09-04 Thread Reid Kleckner via cfe-commits
rnk added a subscriber: rnk. rnk added a comment. I think a better fix would be to insert a non-terminator placeholder that doesn't confuse EmitBlock. http://reviews.llvm.org/D12412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

Re: [PATCH] D12631: Avoid repeated replacements on loop-convert check.

2015-09-04 Thread Angel Garcia via cfe-commits
angelgarcia updated this revision to Diff 34076. angelgarcia added a comment. Wooops, solved. http://reviews.llvm.org/D12631 Files: clang-tidy/modernize/LoopConvertUtils.cpp clang-tidy/modernize/LoopConvertUtils.h test/clang-tidy/modernize-loop-convert-extra.cpp Index: test/clang-tidy/mo

Re: [PATCH] D12631: Avoid repeated replacements on loop-convert check.

2015-09-04 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a reviewer: alexfh. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a comment. Comment at: clang-tidy/modernize/LoopConvertUtils.h:211 @@ -210,3 +210,3 @@ /// \brief A class to encapsulate lowe

Re: [PATCH][www] Mention that libcxx is necessary on OS X

2015-09-04 Thread Jonathan Roelofs via cfe-commits
On 9/4/15 2:55 PM, Yuri Gribov wrote: On Fri, Sep 4, 2015 at 11:49 PM, Jonathan Roelofs mailto:jonat...@codesourcery.com>> wrote: On 9/4/15 2:45 PM, Yuri Gribov via cfe-commits wrote: Hi all, According to https://llvm.org/bugs/show_bug.cgi?id=17821 , when Clang

Re: [PATCH][www] Mention that libcxx is necessary on OS X

2015-09-04 Thread Yuri Gribov via cfe-commits
On Fri, Sep 4, 2015 at 11:49 PM, Jonathan Roelofs wrote: > On 9/4/15 2:45 PM, Yuri Gribov via cfe-commits wrote: > >> Hi all, >> >> According to https://llvm.org/bugs/show_bug.cgi?id=17821 , when Clang >> gets built on OS X we need to build it with libcxx and libcxxabi >> (otherwise tests will fa

Re: [PATCH] D12644: Using -isysroot on Apple platform

2015-09-04 Thread Steven Wu via cfe-commits
steven_wu updated this revision to Diff 34073. steven_wu added a comment. Sorry, made a typo on the previous patch. A little background information. When the greendragon jenkins make an system upgrade in the future, it will need this flag as well to build and test libcxx through cmake/ninja. ht

[PATCH] D12646: Add libc++ header path for DarwinClang builds

2015-09-04 Thread don hinton via cfe-commits
hintonda created this revision. hintonda added a reviewer: rsmith. hintonda added a subscriber: cfe-commits. Current behavior doesn't add c++ header path if libc++ wasn't installed via macports in /usr. This change will try to locate c++ headers from various locations, including in tree, via ma

Re: [PATCH] D12644: Using -isysroot on Apple platform

2015-09-04 Thread Eric Fiselier via cfe-commits
EricWF added a reviewer: danalbert. EricWF added a subscriber: danalbert. EricWF added a comment. @danalbert actually uses this option. I would like him to confirm this change. http://reviews.llvm.org/D12644 ___ cfe-commits mailing list cfe-commits@

Re: [PATCH][www] Mention that libcxx is necessary on OS X

2015-09-04 Thread Jonathan Roelofs via cfe-commits
On 9/4/15 2:45 PM, Yuri Gribov via cfe-commits wrote: Hi all, According to https://llvm.org/bugs/show_bug.cgi?id=17821 , when Clang gets built on OS X we need to build it with libcxx and libcxxabi (otherwise tests will fail to link with "can't find iostream". This patch adds a note to getting

Re: [PATCH] D12412: [CodeGen] Point empty %invoke.cont block to successor

2015-09-04 Thread Vedant Kumar via cfe-commits
vsk added a comment. Ping http://reviews.llvm.org/D12412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH][www] Mention that libcxx is necessary on OS X

2015-09-04 Thread Yuri Gribov via cfe-commits
Hi all, According to https://llvm.org/bugs/show_bug.cgi?id=17821 , when Clang gets built on OS X we need to build it with libcxx and libcxxabi (otherwise tests will fail to link with "can't find iostream". This patch adds a note to getting started page. Ok to apply? Best regards, Yury Gribov li

Re: [PATCH] D12326: [Modules] Emit warning if module cannot instantiate static class member.

2015-09-04 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. rsmith added a comment. I don't really see this as being specific to modules, nor to static data members. The natural generalization of this is: - at the end of a translation unit (including at the end of a module), warn on any implicit instantiations that are

[PATCH] D12644: Using -isysroot on Apple platform

2015-09-04 Thread Steven Wu via cfe-commits
steven_wu created this revision. steven_wu added a reviewer: EricWF. steven_wu added a subscriber: cfe-commits. --sysroot might cause inconsistency between the header gets used and the library gets linked on Apple platform. Use -isysroot instead. http://reviews.llvm.org/D12644 Files: CMakeList

r246864 - Don't allow dllexport/import on static local variables

2015-09-04 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Sep 4 14:59:39 2015 New Revision: 246864 URL: http://llvm.org/viewvc/llvm-project?rev=246864&view=rev Log: Don't allow dllexport/import on static local variables They might technically have external linkage, but it still doesn't make sense for the user to try and export su

Re: [PATCH] D12326: [Modules] Emit warning if module cannot instantiate static class member.

2015-09-04 Thread Sean Silva via cfe-commits
silvas added a subscriber: silvas. silvas added a comment. How expensive is this check? http://reviews.llvm.org/D12326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12435: [Concepts] Add diagnostic; invalid specifier on function or variable concept declaration

2015-09-04 Thread Nathan Wilson via cfe-commits
nwilson added a comment. Ping http://reviews.llvm.org/D12435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12453: [CUDA] Allow function overloads based on host/device attributes.

2015-09-04 Thread Artem Belevich via cfe-commits
tra updated this revision to Diff 34059. tra marked 2 inline comments as done. tra added a comment. Added more test cases to cover constructor/destructor/new/delete. Refactored code to remove unwanted CUDA functions from Lookup match results. Disabled HD overloading of H or H destructors to guaran

Re: [PATCH] D12624: Top-level anonymous namespaces are missing import DW_TAG_imported_module and nested anonymous namespaces are not

2015-09-04 Thread Richard Smith via cfe-commits
rsmith added a comment. I think this is fundamentally the right approach. Anonymous namespaces do inject a using directive, and we should not forget to pass it to the AST consumer. Comment at: lib/CodeGen/CGDebugInfo.cpp:3263-3264 @@ +3262,4 @@ + const NamespaceDecl *NSDecl =

Re: [PATCH] D12169: Relax constexpr rules to improve __builtin_object_size's accuracy

2015-09-04 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This essentially looks fine. Let me know if you want me to take another look once you've fixed the `ignorePointerCastsAndParens` bug with derived-to-base conversions, otherwise go ahead. ===

Re: [PATCH] D12631: Avoid repeated replacements on loop-convert check.

2015-09-04 Thread Angel Garcia via cfe-commits
angelgarcia updated this revision to Diff 34054. angelgarcia added a comment. Yes, with SpellingLoc works as well, and it should be better. http://reviews.llvm.org/D12631 Files: clang-tidy/modernize/LoopConvertUtils.cpp clang-tidy/modernize/LoopConvertUtils.h test/clang-tidy/modernize-loo

r246860 - Fixing a bug where hasType(decl()) would fail to match on C code involving structs or unions.

2015-09-04 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri Sep 4 13:34:48 2015 New Revision: 246860 URL: http://llvm.org/viewvc/llvm-project?rev=246860&view=rev Log: Fixing a bug where hasType(decl()) would fail to match on C code involving structs or unions. Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchersIn

recordDecl() AST matcher

2015-09-04 Thread Aaron Ballman via cfe-commits
It turns out that the recordDecl() AST matcher doesn't match RecordDecl objects; instead, it matches CXXRecordDecl objects. This is... unfortunate... as it makes writing AST matchers more complicated because of having to translate between recordDecl()/CXXRecordDecl. It also makes it impossible to m

Re: [PATCH] D12631: Avoid repeated replacements on loop-convert check.

2015-09-04 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: clang-tidy/modernize/LoopConvertUtils.cpp:463-470 @@ -462,1 +462,10 @@ +void ForLoopIndexUseVisitor::addUsage(const Usage &U) { + SourceLocation Begin = U.Range.getBegin(); + if (Begin.isMacroID()) +Begin = Context->getSourceManage

Re: [PATCH] D12631: Avoid repeated replacements on loop-convert check.

2015-09-04 Thread Angel Garcia via cfe-commits
angelgarcia updated this revision to Diff 34039. angelgarcia marked 2 inline comments as done. angelgarcia added a comment. Ok! I wasn't sure, and a while would be correct in both cases :) http://reviews.llvm.org/D12631 Files: clang-tidy/modernize/LoopConvertUtils.cpp clang-tidy/modernize/L

Re: [PATCH] D12631: Avoid repeated replacements on loop-convert check.

2015-09-04 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: clang-tidy/modernize/LoopConvertUtils.cpp:465 @@ +464,3 @@ + SourceLocation Begin = U.Range.getBegin(); + while (Begin.isMacroID()) +Begin = Context->getSourceManager().getExpansionLoc(Begin); There should be no need

r246857 - Put ext_implicit_lib_function_decl in ImplicitFunctionDeclare.

2015-09-04 Thread Ed Schouten via cfe-commits
Author: ed Date: Fri Sep 4 11:07:39 2015 New Revision: 246857 URL: http://llvm.org/viewvc/llvm-project?rev=246857&view=rev Log: Put ext_implicit_lib_function_decl in ImplicitFunctionDeclare. If we build with -Werror=implicit-function-declaration, only implicit function declarations of non-librar

Re: [PATCH] D12631: Avoid repeated replacements on loop-convert check.

2015-09-04 Thread Angel Garcia via cfe-commits
angelgarcia updated this revision to Diff 34035. angelgarcia added a comment. I think this solves the duplication problem. And I think is clearer and cheaper than what I was trying to do before. http://reviews.llvm.org/D12631 Files: clang-tidy/modernize/LoopConvertUtils.cpp clang-tidy/mode

[clang-tools-extra] r246856 - [clang-tidy] Fix llvm-include-order check on Windows.

2015-09-04 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Fri Sep 4 10:46:51 2015 New Revision: 246856 URL: http://llvm.org/viewvc/llvm-project?rev=246856&view=rev Log: [clang-tidy] Fix llvm-include-order check on Windows. IncludeDirectives struct used a StringRef that pointed to a stack variable (SmallString<128> FilenameBuffer fr

[clang-tools-extra] r246854 - [clang-tidy] Fix add_new_check.py.

2015-09-04 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Fri Sep 4 09:56:57 2015 New Revision: 246854 URL: http://llvm.org/viewvc/llvm-project?rev=246854&view=rev Log: [clang-tidy] Fix add_new_check.py. This fixes the case where the check should be added at the end of the list of checks in CMakeLists.txt of the corresponding modul

[PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

2015-09-04 Thread Alexandros Lamprineas via cfe-commits
labrinea created this revision. labrinea added reviewers: rengolin, richard.barton.arm. labrinea added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. Added the remaining macros and corresponding regression tests. http://reviews.llvm.org/D12633 Files: lib/Basic/Targets

Re: [PATCH] D12631: Avoid repeated replacements on loop-convert check.

2015-09-04 Thread Angel Garcia via cfe-commits
angelgarcia added a comment. Anyway, I just found that this needs a few more changes (it still does duplicated replacementes inside some macros, and I have to find out why), so don't bother with this for now. Comment at: clang-tidy/modernize/LoopConvertUtils.cpp:465 @@ +464,3

Re: [PATCH] D12619: [Static Analyzer] Minor cleanups for the nullability checker.

2015-09-04 Thread Daniel Marjamäki via cfe-commits
danielmarjamaki added a subscriber: danielmarjamaki. danielmarjamaki added a comment. Overall.. LGTM Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:78 @@ -78,2 +77,3 @@ + llvm_unreachable("Unexpected enumeration."); return ""; } After llvm_u

Re: [PATCH] D12631: Avoid repeated replacements on loop-convert check.

2015-09-04 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/modernize/LoopConvertUtils.cpp:465 @@ +464,3 @@ + if (UsageSet.insert(U).second) { +Usages.push_back(U); +return true; Do you need both `Usages` and `UsageSet`? Comment at: clang-tidy/

r246853 - [OPENMP] Fix false diagnostic on instantiation-dependent exprs for atomic constructs.

2015-09-04 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Sep 4 07:55:50 2015 New Revision: 246853 URL: http://llvm.org/viewvc/llvm-project?rev=246853&view=rev Log: [OPENMP] Fix false diagnostic on instantiation-dependent exprs for atomic constructs. Some of instantiation-dependent expressions could cause false diagnostic to b

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

2015-09-04 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld added a comment. I think this has to be updated for the current trunk... http://reviews.llvm.org/D9888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

2015-09-04 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld added a comment. Needs two small changes to work with current trunk Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2135-2136 @@ +2134,4 @@ + const Expr *IfCond = nullptr; + if (auto C = S.getSingleClause(OMPC_if)) { +IfCond = cast(C)->getCondition(); + } --

[PATCH] D12631: Avoid repeated replacements on loop-convert check.

2015-09-04 Thread Angel Garcia via cfe-commits
angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: alexfh, cfe-commits. The InitListExpr subtree is visited twice, this caused the check to do multiple replacements. Added a set to avoid it. http://reviews.llvm.org/D12631 Files: clang-tidy/

Re: [PATCH] D12326: [Modules] Emit warning if module cannot instantiate static class member.

2015-09-04 Thread Serge Pavlov via cfe-commits
Any feedback? Thanks, --Serge 2015-08-26 0:26 GMT+06:00 Serge Pavlov : > sepavloff created this revision. > sepavloff added a subscriber: cfe-commits. > > Instantiation of static class members can be not obvious in some cases. > Using > modules can cause problems even more difficult to diagnose.

r246850 - clang/test/SemaCXX/sourceranges.cpp: Fix silly expressions. Sorry for the breakage.

2015-09-04 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Fri Sep 4 06:49:36 2015 New Revision: 246850 URL: http://llvm.org/viewvc/llvm-project?rev=246850&view=rev Log: clang/test/SemaCXX/sourceranges.cpp: Fix silly expressions. Sorry for the breakage. Modified: cfe/trunk/test/SemaCXX/sourceranges.cpp Modified: cfe/trunk/tes

r246849 - clang/test/SemaCXX/sourceranges.cpp: Appease win32. Class method is thiscall for targeting i686-(msvc|mingw32).

2015-09-04 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Fri Sep 4 06:40:31 2015 New Revision: 246849 URL: http://llvm.org/viewvc/llvm-project?rev=246849&view=rev Log: clang/test/SemaCXX/sourceranges.cpp: Appease win32. Class method is thiscall for targeting i686-(msvc|mingw32). Modified: cfe/trunk/test/SemaCXX/sourceranges.

r246846 - [OPENMP] Fix for http://llvm.org/PR24674: assertion failed and and abort trap

2015-09-04 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Sep 4 06:26:21 2015 New Revision: 246846 URL: http://llvm.org/viewvc/llvm-project?rev=246846&view=rev Log: [OPENMP] Fix for http://llvm.org/PR24674: assertion failed and and abort trap Fix processing of shared variables with reference types in OpenMP constructs. Previou

Re: [PATCH] D12492: [Clang-Format] Add AlwaysBreakBeforeElse and AlwaysBreakBeforeCatch Style to avoid cuddled else/catch

2015-09-04 Thread Paul Hoad via cfe-commits
MyDeveloperDay retitled this revision from "[Clang-Format] Add AlwaysBreakBeforeElse Style to avoid cuddled else" to "[Clang-Format] Add AlwaysBreakBeforeElse and AlwaysBreakBeforeCatch Style to avoid cuddled else/catch". MyDeveloperDay updated the summary for this revision. MyDeveloperDay updat

r246844 - Fix the perentheses location when the constructor is called on a class that has a destructor

2015-09-04 Thread Olivier Goffart via cfe-commits
Author: ogoffart Date: Fri Sep 4 05:17:10 2015 New Revision: 246844 URL: http://llvm.org/viewvc/llvm-project?rev=246844&view=rev Log: Fix the perentheses location when the constructor is called on a class that has a destructor Modified: cfe/trunk/lib/Sema/SemaCast.cpp cfe/trunk/test/Sem

Re: [PATCH] D11797: [LIbClang] Report the named type for ElaboratedType

2015-09-04 Thread Sergey Kalinichev via cfe-commits
skalinichev updated this revision to Diff 34019. skalinichev added a comment. Rebased. Yes, now it's ready. http://reviews.llvm.org/D11797 Files: test/Index/print-type.c test/Index/print-type.cpp tools/libclang/CXType.cpp Index: tools/libclang/CXType.cpp

Re: [PATCH][Solaris] Add -lc also when linking shared libraries

2015-09-04 Thread Xan López via cfe-commits
On Fri, Aug 28, 2015 at 07:53:40PM +0200, Xan López via cfe-commits wrote: > This is actually needed, otherwise libc won't be added at all. For > instance when building libclang.so all the libc symbols won't be > found, with ld warning about libc being an "implicit dependency". > > ((This patch si

Re: [PATCH][Solaris] Default to -fno-cxa-finalize

2015-09-04 Thread Xan López via cfe-commits
On Fri, Aug 28, 2015 at 07:52:17PM +0200, Xan López via cfe-commits wrote: > There is no __cxa_finalize symbol available on recent Solaris OS > versions, so we need this flag to make non trivial C++ programs run. > > Also stop looking for cxa_finalize.o, since it won't be there. > > (This patch s