Author: echristo
Date: Fri Aug 28 21:59:37 2015
New Revision: 246355
URL: http://llvm.org/viewvc/llvm-project?rev=246355&view=rev
Log:
Add a check for a function we're not testing.
Modified:
cfe/trunk/test/CodeGen/attr-target-x86.c
Modified: cfe/trunk/test/CodeGen/attr-target-x86.c
URL:
htt
martell created this revision.
martell added reviewers: rnk, yaron.keren.
martell added a subscriber: cfe-commits.
martell set the repository for this revision to rL LLVM.
Not quite sure if this is the proper way to fix this.
This is currently my work around when working from an OSX host though.
rsmith added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:3387-3392
@@ -3386,4 +3386,8 @@
- llvm::Value *ArgValue = CGF.EmitVAListRef(VE->getSubExpr());
- llvm::Value *ArgPtr = CGF.EmitVAArg(ArgValue, VE->getType());
+ llvm::Value *ArgValue = VE->isMicrosoftABI()
rsmith added inline comments.
Comment at: include/clang/AST/Expr.h:3709
@@ -3708,3 +3708,3 @@
VAArgExpr(SourceLocation BLoc, Expr* e, TypeSourceInfo *TInfo,
-SourceLocation RPLoc, QualType t)
+SourceLocation RPLoc, QualType t, bool IsMS = false)
: E
piotrdz created this revision.
piotrdz added a subscriber: cfe-commits.
piotrdz set the repository for this revision to rL LLVM.
This is first of series of patches, porting code from my project colobot-lint,
as I mentioned recently in cfe-dev mailing list.
This patch adds a new check in readabil
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:395
@@ +394,3 @@
+ // reaped.
+ if (!State->get()) {
+ProgramStateRef NewState =
zaks.anna wrote:
> Maybe you should only do this if there was at least one symbol
xazax.hun updated this revision to Diff 33501.
xazax.hun marked 6 inline comments as done.
xazax.hun added a comment.
Addressed the comments.
http://reviews.llvm.org/D12445
Files:
lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp
test/Analysis/nullability.mm
Index: test/Analysis/nullabili
alexfh added a comment.
> 1. If is included, then static_assert() is also fine to use.
> Presumably, in order for the assert() check to trigger, has to be
> included, but I don't feel particularly comfortable with that assumption.
Do you have any C11 code that uses `assert()`, but doesn't in
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:166
@@ +165,3 @@
+ // nullability precondition is violated it will not report any bugs at all.
+ void reportBug(ErrorKind Error, ExplodedNode *N, const MemRegion *Region,
+
spatel created this revision.
spatel added reviewers: hfinkel, kbsmith1, kparzysz, reames, silvas.
spatel added a subscriber: cfe-commits.
spatel added a dependency: D12341: add unpredictable metadata type for control
flow.
This patch depends on D12341 ('unpredictable' metadata type for LLVM).
mzolotukhin added a comment.
Hi Hal,
I added `Nontemporal` field to LValue and started to use it in
`EmitStoreOfScalar`/`EmitLoadOfScalar`. Does it look like something you had in
mind?
Thanks,
Michael
http://reviews.llvm.org/D12313
___
cfe-commi
mzolotukhin updated this revision to Diff 33492.
mzolotukhin added a comment.
- Use EmitStoreOfScalar and EmitLoadOfScalar for generating nontemporal loads
and stores.
- Rebase on TOT.
http://reviews.llvm.org/D12313
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/DiagnosticSema
cdavis5x updated this revision to Diff 33490.
cdavis5x added a comment.
- Rebase onto http://reviews.llvm.org/rL246348.
- Register the `__builtin_ms_va_list` predef decl. Fixes a nasty interaction
with modules.
- Mark `__builtin_ms_va_start` builtin as manually type-checked.
http://reviews.llvm
Author: hans
Date: Fri Aug 28 17:56:21 2015
New Revision: 246348
URL: http://llvm.org/viewvc/llvm-project?rev=246348&view=rev
Log:
Follow-up to r246338: use getParentFunctionOrMethod
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
URL:
http://llvm.org/vie
tra created this revision.
tra added reviewers: eliben, rsmith, jholewinski, echristo, jingyue.
tra added a subscriber: cfe-commits.
The patch makes it possible to parse CUDA files that contain host/device
functions with identical signatures, but different attributes without having
to physicall
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Fri Aug 28 17:33:53 2015
New Revision: 246347
URL: http://llvm.org/viewvc/llvm-project?rev=246347&view=rev
Log:
PR24612: Don't bail out of checking a constexpr function before checking
whether it can ever produce a constant expression in the case where it has a
void return typ
Author: echristo
Date: Fri Aug 28 17:32:01 2015
New Revision: 246346
URL: http://llvm.org/viewvc/llvm-project?rev=246346&view=rev
Log:
Fold TargetInfo::handleUserFeatures into TargetInfo::initFeatureMap.
Modified:
cfe/trunk/include/clang/Basic/TargetInfo.h
cfe/trunk/lib/Basic/Targets.cpp
Author: dcoughlin
Date: Fri Aug 28 17:26:05 2015
New Revision: 246345
URL: http://llvm.org/viewvc/llvm-project?rev=246345&view=rev
Log:
[analyzer] When memcpy'ing into a fixed-size array, do not invalidate entire
region.
Change the analyzer's modeling of memcpy to be more precise when copying in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246345: [analyzer] When memcpy'ing into a fixed-size array,
do not invalidate entire… (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D11832?vs=33402&id=33478#toc
Repository:
hubert.reinterpretcast added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1982
@@ -1981,1 +1981,3 @@
"function concept cannot have exception specification">;
+def err_concept_decl_invalid_sepcifiers : Error<
+ "%select{variable|function}0 concept can
rjmccall added a comment.
Yes, please make it an error. And the obvious test changes are fine. :)
http://reviews.llvm.org/D11297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246338: Allow TLS vars in dllimport/export functions; only
inline dllimport functions… (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D12422?vs=33388&id=33471#toc
Repository:
rL
Author: hans
Date: Fri Aug 28 16:47:01 2015
New Revision: 246338
URL: http://llvm.org/viewvc/llvm-project?rev=246338&view=rev
Log:
Allow TLS vars in dllimport/export functions; only inline dllimport functions
when safe (PR24593)
This patch does two things:
1) Don't error about dllimport/export
nwilson added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1982
@@ -1981,1 +1981,3 @@
"function concept cannot have exception specification">;
+def err_concept_decl_invalid_sepcifiers : Error<
+ "%select{variable|function}0 concept cannot be declared
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
We should probably do something about lambdas, they can't be imported or
exported but this can be done in a follow up patch.
http://reviews.llvm.org/D12422
__
On Tue, Aug 25, 2015 at 10:27 AM, Abramo Bagnara wrote:
> Comparing the result of InitListExpr::getSyntacticForm between r224986
> and r245836 I've discovered that integer to char implicit cast for
> integer literal 3 is no longer added to AST for C++ (while it is present
> in C).
>
> This is the
nmusgrave updated this revision to Diff 33463.
nmusgrave marked an inline comment as done.
nmusgrave added a comment.
- Alias-repressing test case ignores casting of pointers.
http://reviews.llvm.org/D12022
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenModule.h
aaron.ballman created this revision.
aaron.ballman added reviewers: alexfh, djasper.
aaron.ballman added a subscriber: cfe-commits.
This patch adds support for the C11 _Static_assert macro to clang-tidy's
misc-static-assert checker. There are a few things I'm not overly satisfied
with, and welco
Thanks!
On 28 Aug 2015 9:33 pm, "Simon Pilgrim" wrote:
> Thanks for the heads up Renato. I've a candidate fix (it was missing
> REQUIRES: x86-registered-target) and will commit it later and keep an extra
> eye on the non-x86 buildbots.
>
> On 28/08/2015 20:41, Renato Golin wrote:
>
>> And finally
xazax.hun created this revision.
xazax.hun added reviewers: zaks.anna, dcoughlin, krememek, jordan_rose.
xazax.hun added a subscriber: cfe-commits.
With this patch a nullability violation no longer generates a sink node, so it
does not cause any coverage loss for other checkers.
>From now on, it
Thanks for the heads up Renato. I've a candidate fix (it was missing
REQUIRES: x86-registered-target) and will commit it later and keep an
extra eye on the non-x86 buildbots.
On 28/08/2015 20:41, Renato Golin wrote:
And finally this one in r246323.
Please, move all those tests to an X86 speci
ahatanak updated this revision to Diff 33456.
ahatanak added a comment.
This updated patch changes the handling of driver option
-mstackrealign/-mno-stackrealign. -mno-stackrealign no longer indicates stack
realignment should be disallowed and clang no longer attaches function
attribute "no-rea
And finally this one in r246323.
Please, move all those tests to an X86 specific area and check the
AArch64 bots after commit to make sure it passes.
You probably didn't get the email because the bot was broken when you
committed, then all your other commits were breaking a broken bot. :)
cheers
Author: aaronballman
Date: Fri Aug 28 14:40:30 2015
New Revision: 246325
URL: http://llvm.org/viewvc/llvm-project?rev=246325&view=rev
Log:
Updated to make use of the AST matcher instead of a custom matcher; NFC.
Modified:
clang-tools-extra/trunk/clang-tidy/misc/UnusedAliasDeclsCheck.cpp
Modi
Author: aaronballman
Date: Fri Aug 28 14:39:56 2015
New Revision: 246324
URL: http://llvm.org/viewvc/llvm-project?rev=246324&view=rev
Log:
Updating the AST matcher documentation with a new entry; NFC.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Modified: cfe/trunk/docs/LibASTMatche
Author: rengolin
Date: Fri Aug 28 14:39:29 2015
New Revision: 246323
URL: http://llvm.org/viewvc/llvm-project?rev=246323&view=rev
Log:
Revert "[X86][3DNow] Added debug codegen test for 3DNow! intrinsics"
This reverts commit r246223, as it broke all ARM/AArch64 bots.
Modified:
cfe/trunk/test/
Author: aaronballman
Date: Fri Aug 28 14:39:21 2015
New Revision: 246322
URL: http://llvm.org/viewvc/llvm-project?rev=246322&view=rev
Log:
Adding an AST matcher for namespaceAliasDecl.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Author: rengolin
Date: Fri Aug 28 14:38:05 2015
New Revision: 246321
URL: http://llvm.org/viewvc/llvm-project?rev=246321&view=rev
Log:
Revert "[X86][XOP] Added debug codegen test for XOP intrinsics"
This reverts commit r246211, as it broke all ARM/AArch64 bots.
Modified:
cfe/trunk/test/CodeG
And this one, too, in r246321.
--renato
On 27 August 2015 at 22:32, Simon Pilgrim via cfe-commits
wrote:
> Author: rksimon
> Date: Thu Aug 27 16:32:03 2015
> New Revision: 246211
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246211&view=rev
> Log:
> [X86][XOP] Added debug codegen test for XOP
Hi Simon,
This one too, reverted in r246320.
cheers,
--renato
On 27 August 2015 at 21:41, Simon Pilgrim via cfe-commits
wrote:
> Author: rksimon
> Date: Thu Aug 27 15:41:45 2015
> New Revision: 246206
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246206&view=rev
> Log:
> [X86][FMA4] Added de
Author: rengolin
Date: Fri Aug 28 14:36:27 2015
New Revision: 246320
URL: http://llvm.org/viewvc/llvm-project?rev=246320&view=rev
Log:
Revert "[X86][FMA4] Added debug codegen test for FMA4 intrinsics"
This reverts commit r246206, as it broke all ARM/AArch64 bots.
Modified:
cfe/trunk/test/Cod
Hi Simon,
I've reverted this commit in r246319, as it broke all ARM/AArch64 bots
and lots of other errors accumulated.
cheers,
--renato
On 27 August 2015 at 21:34, Simon Pilgrim via cfe-commits
wrote:
> Author: rksimon
> Date: Thu Aug 27 15:34:02 2015
> New Revision: 246204
>
> URL: http://llv
Author: rengolin
Date: Fri Aug 28 14:34:53 2015
New Revision: 246319
URL: http://llvm.org/viewvc/llvm-project?rev=246319&view=rev
Log:
Revert "[X86][F16C] Added debug codegen test for F16C intrinsics"
This reverts commit r246204, as it was breaking all ARM/AArch64 bots.
Modified:
cfe/trunk/t
Author: aaronballman
Date: Fri Aug 28 14:27:19 2015
New Revision: 246318
URL: http://llvm.org/viewvc/llvm-project?rev=246318&view=rev
Log:
Disable clang-tidy misc checkers when not compiling in C++ mode. Many of the
checkers do not require additional testing as the tests will not compile for
oth
zaks.anna added a comment.
Please, make sure to include a very specific commit title/message.
http://reviews.llvm.org/D6551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin accepted this revision.
dcoughlin added a comment.
I ran our build-bot scripts with this and it looks good to me, although I've
noted two places with trailing whitespace. Thanks for your patience!
Comment at: tools/scan-build/scan-build:1403
@@ +1402,3 @@
+ my $Args
vsk created this revision.
vsk added a subscriber: cfe-commits.
We currently assert-fail on the following input:
enum Color { R, G, B };
typedef struct Color C;
This patch just changes the assert to a conditional.
https://llvm.org/bugs/show_bug.cgi?id=24610
http://reviews.llvm.org/D12444
File
ahatanak added inline comments.
Comment at: lib/Driver/Tools.cpp:4232
@@ +4231,3 @@
+ false))
+CmdArgs.push_back(Args.MakeArgString("-force-align-stack"));
+
hfinkel wrote:
> ahatanak wrote:
> > echristo wrote:
> > > hfinkel wrote:
> > > > ec
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
I will commit. Thanks for your work on this, Pierre!
http://reviews.llvm.org/D11832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: aaronballman
Date: Fri Aug 28 12:58:10 2015
New Revision: 246310
URL: http://llvm.org/viewvc/llvm-project?rev=246310&view=rev
Log:
Disable several more clang-tidy modernize checkers when not compiling in C++
mode. Loop conversion would make recommendations for C code, so added a test to
This is actually needed, otherwise libc won't be added at all. For
instance when building libclang.so all the libc symbols won't be
found, with ld warning about libc being an "implicit dependency".
((This patch sits on top of a couple of unreviewed patches that make clang
actually work on Solaris
There is no __cxa_finalize symbol available on recent Solaris OS
versions, so we need this flag to make non trivial C++ programs run.
Also stop looking for cxa_finalize.o, since it won't be there.
(This patch sits on top of a couple of unreviewed patches that make clang
actually work on Solaris,
hubert.reinterpretcast added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1982
@@ -1981,1 +1981,3 @@
"function concept cannot have exception specification">;
+def err_concept_decl_invalid_sepcifiers : Error<
+ "%select{variable|function}0 concept can
nmusgrave added inline comments.
Comment at: test/CodeGenCXX/sanitize-dtor-repress-aliasing.cpp:30
@@ +29,2 @@
+// Definition of virtual function table
+// CHECK: @_ZTV7Derived = {{.*}}(void (%struct.Derived*)* @_ZN7DerivedD1Ev to
i8*){{.*}}(void (%struct.Derived*)* @_ZN7DerivedD
nmusgrave marked 3 inline comments as done.
nmusgrave added a comment.
http://reviews.llvm.org/D12022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nmusgrave updated this revision to Diff 33436.
nmusgrave added a comment.
- Checking for existence of fields to poison in alias emission.
http://reviews.llvm.org/D12022
Files:
lib/CodeGen/CGCXX.cpp
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenModule.h
test/CodeGenCXX/sanitize-dtor-nontriv
nwilson created this revision.
nwilson added reviewers: rsmith, hubert.reinterpretcast, aaron.ballman,
faisalv, fraggamuffin.
nwilson added a subscriber: cfe-commits.
Diagnose variable and function concept declarations when an invalid specifier
appears
http://reviews.llvm.org/D12435
Files:
i
Ping.
Il 25/08/2015 19:27, Abramo Bagnara ha scritto:
> Comparing the result of InitListExpr::getSyntacticForm between r224986
> and r245836 I've discovered that integer to char implicit cast for
> integer literal 3 is no longer added to AST for C++ (while it is present
> in C).
>
> This is the s
Author: spatel
Date: Fri Aug 28 09:42:54 2015
New Revision: 246303
URL: http://llvm.org/viewvc/llvm-project?rev=246303&view=rev
Log:
fix typo; NFC
Modified:
cfe/trunk/lib/Sema/SemaStmt.cpp
Modified: cfe/trunk/lib/Sema/SemaStmt.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/
jroelofs added a comment.
In http://reviews.llvm.org/D11963#234789, @EricWF wrote:
> Copy the headers to the build directory during every build instead of just
> during CMake configuration.
Sounds like this would cause every build to effectively be a full build. I
don't think we want that...
Author: aaronballman
Date: Fri Aug 28 08:20:46 2015
New Revision: 246298
URL: http://llvm.org/viewvc/llvm-project?rev=246298&view=rev
Log:
Reapplying r246209, which exposed language options to the checkers. This time
disable UseNullptrCheck when not compiling in C++ mode, but still allow in
C++1
seaneveson added a comment.
In http://reviews.llvm.org/D12358#234949, @zaks.anna wrote:
> We try to avoid false positives as much as possible. They are very painful
> for users to deal with.
> You should develop this feature behind a flag. This would allow for
> incremental development and
andreybokhanko added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2323
@@ -2323,1 +2322,3 @@
+ "definition with same mangled name as another definition">,
+ InGroup;
def err_cyclic_alias : Error<
rjmccall wrote:
> I'm sorry to bring t
Author: sylvestre
Date: Fri Aug 28 07:26:09 2015
New Revision: 246295
URL: http://llvm.org/viewvc/llvm-project?rev=246295&view=rev
Log:
Support Debian s390x multiarch paths
Summary: Patch by Steven Chamberlain
Reviewers: uweigand
Differential Revision: http://reviews.llvm.org/D12430
Modified:
On Thu, Aug 27, 2015 at 7:36 PM, Alexander Kornienko wrote:
> On Fri, Aug 28, 2015 at 1:23 AM, Aaron Ballman
> wrote:
>>
>> On Thu, Aug 27, 2015 at 7:20 PM, Alexander Kornienko
>> wrote:
>> > alexfh added a comment.
>> >
>> > In http://reviews.llvm.org/D12081#234614, @aaron.ballman wrote:
>> >
>
sylvestre.ledru added a comment.
Anton, I think you should just commit it. We can always iterate on this later
if it breaks anything.
The patch is big and rebasing is time consuming.
http://reviews.llvm.org/D6551
___
cfe-commits mailing list
cfe-co
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2991-3005
@@ +2990,17 @@
+
+/// \brief Values for bit flags used to specify the mapping type for
+/// offloading.
+enum OpenMPOffloadMappingFlags {
+ /// \brief Allocate memory on the device and move data
rjmccall added a comment.
This looks great, thanks! One last comment; if you agree with me, go ahead and
fix it and then commit.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2323
@@ -2323,1 +2322,3 @@
+ "definition with same mangled name as another definition">,
+
pgousseau updated this revision to Diff 33402.
pgousseau added a comment.
Replace 'dyn_cast' by 'cast' following Devin's review.
If all looks good could someone commit this patch for me ?
Regards,
Pierre
http://reviews.llvm.org/D11832
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/
pgousseau added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:863
@@ +862,3 @@
+
+ const ElementRegion *ER = dyn_cast(R);
+ // Cast is safe as BufVal's region is a FieldRegion.
dcoughlin wrote:
> You can use cast(R) here, which will
andreybokhanko updated this revision to Diff 33401.
andreybokhanko added a comment.
Fixed last note from John McCall.
John, please re-review.
Yours,
Andrey
http://reviews.llvm.org/D11297
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGe
Author: djasper
Date: Fri Aug 28 03:42:22 2015
New Revision: 246288
URL: http://llvm.org/viewvc/llvm-project?rev=246288&view=rev
Log:
Revert "[OPENMP 4.0] Codegen for array sections."
The test is currently failing on bots:
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check
I am pretty sure this commit and r246213 causes llvm LTO bootstrap to hang in
ScalarEvolution. Doesn’t look like a bug introduced in the commit but
definitely triggered something bad. I reverted both commit in r246282.
You should able to reproduce the hang by building llvm-cov using LTO. Let me
Author: steven_wu
Date: Fri Aug 28 02:14:10 2015
New Revision: 246282
URL: http://llvm.org/viewvc/llvm-project?rev=246282&view=rev
Log:
Revert r246214 and r246213
These two commits causes llvm LTO bootstrap to hang in ScalarEvolution.
Removed:
cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp
Sorry, totally forgot that your are in the right timezone. Will not revert
for now and hope that you can figure this out :-)
On Fri, Aug 28, 2015 at 9:10 AM, Daniel Jasper wrote:
> This fails on the bot, reverting:
>
> http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/12
krememek added a comment.
In http://reviews.llvm.org/D12358#234975, @krememek wrote:
>
>
>
> 1. We need to consult the number of times a loop has been executed to
> determine when to apply this widening. We can look at the basic block
> counts, which are already used to cull off too ma
This fails on the bot, reverting:
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/12747/
On Fri, Aug 28, 2015 at 8:09 AM, Alexey Bataev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: abataev
> Date: Fri Aug 28 01:09:05 2015
> New Revision: 246278
>
> URL
Author: ericwf
Date: Fri Aug 28 02:02:42 2015
New Revision: 246280
URL: http://llvm.org/viewvc/llvm-project?rev=246280&view=rev
Log:
Fix most GCC warnings during build. Only -Wattribute left.
Modified:
libcxx/trunk/include/string
libcxx/trunk/include/system_error
Modified: libcxx/trunk/i
Hi Sean,
I responded with some more feedback. Conceptually the patch is quite simple,
but I think Anna’s points are all spot on. I think we’d all be quite amendable
for this work to go in under a flag, with further improvements going in on top
of that. That way we can all collectively start
80 matches
Mail list logo
