Prazek updated this revision to Diff 32509.
Prazek added a comment.
Added tests, and changed the VTableComponent code which was wrong on so many
levels. Sorry
http://reviews.llvm.org/D12128
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/vtable-avai
Author: dim
Date: Wed Aug 19 01:43:33 2015
New Revision: 245421
URL: http://llvm.org/viewvc/llvm-project?rev=245421&view=rev
Log:
Fix warnings about pessimizing return moves for C++11 and higher
Summary:
Throughout the libc++ headers, there are a few instances where
_VSTD::move() is used to retur
EricWF added a comment.
Added more inline comments.
Comment at: include/__mutex_base:36
@@ -35,3 +37,3 @@
#else
- mutex() _NOEXCEPT {__m_ = (pthread_mutex_t)PTHREAD_MUTEX_INITIALIZER;}
#endif
Why was the cast insignificant?
Comment at: in
dim added a comment.
@ericwf, no, this just dropped off my radar, sorry. I will commit it now. :)
http://reviews.llvm.org/D11394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
loverszhaokai created this revision.
loverszhaokai added a reviewer: cfe-commits.
Fix 4 typos:
"targetted" -> "targeted"
"becuase" -> "because"
"staically" -> "statically"
"vitual" -> "virtual"
http://reviews.llvm.org/D12137
Files:
test/CodeGenCXX/ctor-globalopt.cpp
test/Code
EricWF added a reviewer: EricWF.
EricWF added a comment.
This patch has a long way to go but it has also come a long way. Here are a
couple of problems I see with it.
1. There are still plenty of ABI breaks. I'll try and point them all out.
2. This patch adds a lot of headers. libc++ has histori
EricWF added a comment.
I also just realized that this change will currently likely play havoc with how
libc++ and libc++abi build together. In order to build libc++ and libc++abi
together we would need to
1. Configure libc++ pointing to the libc++abi headers in order to generate the
__config_
EricWF added a comment.
@mclow.lists: Do other containers need this update as well? If so it might be
worth while writing noexcept traits that handle the `#ifdef` hell in one spot
instead of repeating it throughout.
http://reviews.llvm.org/D10963
EricWF added a comment.
I think we can avoid requiring the need to rebuild every time the headers
change but it's not the cleanest. We could
1. Have an empty `__config_site` file in `libcxx/include`. This `__config_site`
file does not get copied into the build directory.
2. Generate `__config_s
EricWF added a comment.
@dim Has this been committed or is there something holding you back?
http://reviews.llvm.org/D11394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Aug 19 00:00:36 2015
New Revision: 245415
URL: http://llvm.org/viewvc/llvm-project?rev=245415&view=rev
Log:
Use TestAtomic instead of std::atomic so the test can run in C++03
Modified:
libcxx/trunk/test/std/thread/thread.threads/thread.thread.class/thread.thread.memb
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added subscribers: cfe-commits, mclow.lists.
This patch marks *most* tests for `std::promise`, `std::future` and
`std::shared_future` as unsupported in C++03. These tests fail in C++03 mode
because they attempt to copy a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245414: [OPENMP] Link libomp.lib on Windows (authored by
ABataev).
Changed prior to commit:
http://reviews.llvm.org/D11932?vs=32275&id=32502#toc
Repository:
rL LLVM
http://reviews.llvm.org/D11932
F
Author: abataev
Date: Tue Aug 18 23:49:01 2015
New Revision: 245414
URL: http://llvm.org/viewvc/llvm-project?rev=245414&view=rev
Log:
[OPENMP] Link libomp.lib on Windows
Adds libomp.lib for -fopenmp=libomp and libiomp5md.lib for -fopenmp=libiomp5 on
Windows
Differential Revision: http://reviews.
Author: ericwf
Date: Tue Aug 18 23:10:15 2015
New Revision: 245413
URL: http://llvm.org/viewvc/llvm-project?rev=245413&view=rev
Log:
Mark std::packaged_task tests as unsupported in C++03.
std::packaged_task requires variadic templates and is #ifdef out in C++03.
This patch silences the tests in C
ABataev created this revision.
ABataev added reviewers: echristo, rjmccall, rsmith.
ABataev added a subscriber: cfe-commits.
When variables are implicitly captured in lambdas, debug info generated for
captured variables points to location where they are used first. This patch
makes debug info t
Author: ericwf
Date: Tue Aug 18 22:48:08 2015
New Revision: 245411
URL: http://llvm.org/viewvc/llvm-project?rev=245411&view=rev
Log:
Remove commented out TODOs. They defined unneeded methods.
Modified:
libcxx/trunk/include/experimental/any
libcxx/trunk/src/any.cpp
Modified: libcxx/trunk/
Author: ericwf
Date: Tue Aug 18 22:38:41 2015
New Revision: 245410
URL: http://llvm.org/viewvc/llvm-project?rev=245410&view=rev
Log:
Fix use of static_assert macro with nested commas
Modified:
libcxx/trunk/include/thread
Modified: libcxx/trunk/include/thread
URL:
http://llvm.org/viewvc/llvm
On Tue, Aug 18, 2015 at 8:28 PM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> dblaikie added inline comments.
>
>
> Comment at: include/clang/Basic/Diagnostic.h:936-937
> @@ -935,3 +935,4 @@
> public:
>/// Copy constructor. When copied, this "takes" t
dblaikie updated this revision to Diff 32495.
dblaikie marked 2 inline comments as done.
dblaikie added a comment.
Addressed Richard's code review feedback
http://reviews.llvm.org/D12131
Files:
include/clang/Basic/Diagnostic.h
include/clang/Sema/Sema.h
lib/ARCMigrate/TransformActions.cpp
dblaikie added inline comments.
Comment at: include/clang/Basic/Diagnostic.h:936-937
@@ -935,3 +935,4 @@
public:
/// Copy constructor. When copied, this "takes" the diagnostic info from the
/// input and neuters it.
+ DiagnosticBuilder(DiagnosticBuilder &&D) {
---
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Not really but I would add a `// UNSUPPORTED: clang-3.5, clang-3.6, clang-3.7`
line to prevent the failures from appearing.
http://reviews.llvm.org/D12117
_
samsonov added a comment.
Yes. Is this is an issue?
http://reviews.llvm.org/D12117
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi,
This is my first patch for clang. It fixes 4 typos:
"targetted" -> "targeted"
"becuase" -> "because"
"staically" -> "statically"
"vitual" -> "virtual"
The svn diff file is attached. Thanks for your advice!
Author: Kai Zhao
Date: Wed Aug 19 10:10:08 2015
New Revision:
Log:
Fix 4 typos:
Author: rsmith
Date: Tue Aug 18 21:30:28 2015
New Revision: 245406
URL: http://llvm.org/viewvc/llvm-project?rev=245406&view=rev
Log:
[modules] Don't eagerly deserialize so many ImportDecls. CodeGen basically
ignores ImportDecls imported from modules, so only eagerly deserialize the ones
from a P
Author: echristo
Date: Tue Aug 18 21:24:21 2015
New Revision: 245405
URL: http://llvm.org/viewvc/llvm-project?rev=245405&view=rev
Log:
Rename getDefaultFeatures -> initDefaultFeatures and update comment
with the current behavior as the name seems to match what's going on.
Modified:
cfe/trunk/
Author: davide
Date: Tue Aug 18 21:21:12 2015
New Revision: 245404
URL: http://llvm.org/viewvc/llvm-project?rev=245404&view=rev
Log:
[SemaExpr] Re-enable missing assertion.
This has been disabled for a long time, but:
1) Initializers work (and apparently they're re reason why this was disabled).
Author: gbiv
Date: Tue Aug 18 21:19:07 2015
New Revision: 245403
URL: http://llvm.org/viewvc/llvm-project?rev=245403&view=rev
Log:
Make __builtin_object_size always answer correctly
__builtin_object_size would return incorrect answers for many uses where
type=3. This fixes the inaccuracy by makin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245401: Insert override at the same line as the end of the
function declaration (authored by ehsan).
Changed prior to commit:
http://reviews.llvm.org/D9286?vs=24449&id=32492#toc
Repository:
rL LLVM
Author: ehsan
Date: Tue Aug 18 21:05:37 2015
New Revision: 245401
URL: http://llvm.org/viewvc/llvm-project?rev=245401&view=rev
Log:
Insert override at the same line as the end of the function declaration
Summary:
The existing check converts the code pattern below:
void f()
{
}
to:
void
EricWF added a comment.
I don't think the tricky part of this patch is actually implementing the ABI
macros. The tricky part is defining how libc++ should use the macros. Some
questions I would like to see answered:
1. How long is a major and minor ABI version supported?
2. When is the major a
EricWF added a comment.
Is this going to break this test with older versions of compiler-rt?
http://reviews.llvm.org/D12117
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
I've uploaded a version of the docs built with the "haiku" theme to
http://efcs.ca/libcxx-haiku-docs. I would like other's input on which style
they prefer (Note: The LLVM themed docs are here http://efcs.ca/libcxx-docs).
http://reviews.llvm.org/D12129
__
EricWF added a comment.
In http://reviews.llvm.org/D12129#227320, @silvas wrote:
> From a Sphinx perspective, this looks fine to me. You may want to consider
> using `html_theme = 'haiku'` for consistency with clang, but reusing LLVM's
> is fine. (the reason I had clang use 'haiku' is that it i
silvas added a subscriber: silvas.
silvas added a comment.
From a Sphinx perspective, this looks fine to me. You may want to consider
using `html_theme = 'haiku'` for consistency with clang, but reusing LLVM's is
fine. (the reason I had clang use 'haiku' is that it is a bit better put
together
rsmith added inline comments.
Comment at: include/clang/Basic/Diagnostic.h:936-937
@@ -935,3 +935,4 @@
public:
/// Copy constructor. When copied, this "takes" the diagnostic info from the
/// input and neuters it.
+ DiagnosticBuilder(DiagnosticBuilder &&D) {
-
On Tue, Aug 18, 2015 at 4:46 PM, Richard Smith
wrote:
> On Tue, Aug 18, 2015 at 2:03 PM, David Blaikie wrote:
>
>> Richard, do you think there's anything we could do better here?
>>
>> It seems difficult to support proper move semantic behavior for
>> [Sema]DiagnosticBuilder across the two commo
dblaikie created this revision.
dblaikie added a reviewer: rsmith.
dblaikie added a subscriber: cfe-commits.
While there wasn't much use of "return Diag(...) << x" outside Sema (one
each in ARCMigrate, Lex, Parse, and 5 in ClangTidy - which were all just
changed to use named local variables, then
On Tue, Aug 18, 2015 at 10:05 AM, Serge Pavlov wrote:
> sepavloff added inline comments.
>
>
> Comment at: lib/AST/DeclBase.cpp:273
> @@ +272,3 @@
> +return true;
> + if (const CXXRecordDecl *ClassD = dyn_cast(LDC))
> +return ClassD->isLocalClass() && !ClassD->isLambda()
sunfish updated this revision to Diff 32485.
sunfish marked an inline comment as done.
sunfish added a comment.
The patch evolved enough to prompt posting one more new version; major changes:
- make constructors and destructors return this
- enable -fuse-init-array
- enable -fno-common
- disable
On Tue, Aug 18, 2015 at 3:01 PM, Hans Wennborg wrote:
> Richard, I tried to ping you on the review thread but I'm not sure it
> got through. Martell requested this be merged to 3.7. What do you
> think?
LGTM
> On Fri, Aug 14, 2015 at 12:05 PM, Martell Malone via cfe-commits
> wrote:
> > Auth
EricWF created this revision.
EricWF added reviewers: jroelofs, chandlerc, danalbert, mclow.lists.
EricWF added a subscriber: cfe-commits.
This patch adds Sphinx based documentation to libc++. The goal is to make it
easier to write documentation for libc++ since writing new documentation in
HTML
rsmith added a comment.
This looks fine; can you add a testcase?
http://reviews.llvm.org/D12128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
@beanz I tested installing both libc++abi.so and libc++abi.a at the same time
with different destinations. They both installed into the correct destinations.
http://reviews.llvm.org/D11682
___
cfe-commits mailing list
cfe-co
On Tue, Aug 18, 2015 at 4:52 PM, Richard Smith wrote:
> On Tue, Aug 18, 2015 at 3:00 PM, Hans Wennborg via cfe-commits
> wrote:
>>
>> Richard, I tried to ping you on the review thread but I'm not sure it
>> got through. Martell requested this be merged to 3.7. What do you
>> think?
>
>
> Sure, th
EricWF added a comment.
What about the extra `[` at the beginning of `ARCHIVE` that spans all the way
down to the last line. It seems to me that `DESTINATION` can be supplied for
each library type. There is also an example in the docs that shows using two
library types in one install command.
tra marked an inline comment as done.
Comment at: lib/Sema/SemaDecl.cpp:11166
@@ +11165,3 @@
+!FD->hasAttr() && !FD->hasAttr()) {
+ if (getLangOpts().CUDAIsDevice)
+FD->addAttr(CUDADeviceAttr::CreateImplicit(Context,
FD->getLocation()));
elib
tra updated this revision to Diff 32481.
tra added a comment.
Added a comment explaining reasoning behind attribute choice for
target-specific builtins.
http://reviews.llvm.org/D12122
Files:
include/clang/Basic/Builtins.h
lib/Sema/SemaChecking.cpp
lib/Sema/SemaDecl.cpp
test/SemaCUDA/bu
Prazek created this revision.
Prazek added reviewers: rsmith, majnemer, rjmccall.
Prazek added a subscriber: cfe-commits.
Bugfix revealed in r245264.
http://reviews.llvm.org/D12128
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/ItaniumCXXABI.cpp
Index: lib/CodeGen/ItaniumCXXABI.cpp
==
Author: dblaikie
Date: Tue Aug 18 18:56:00 2015
New Revision: 245392
URL: http://llvm.org/viewvc/llvm-project?rev=245392&view=rev
Log:
unique_ptrify CXXBasePaths::DeclsFound & remove the then-unnecessary
user-defined dtor
Maybe this and the NumDeclsFound member should just be a std::vector
inste
beanz added a comment.
The signature is:
install(TARGETS targets... [EXPORT ]
[[ARCHIVE|LIBRARY|RUNTIME|FRAMEWORK|BUNDLE|
PRIVATE_HEADER|PUBLIC_HEADER|RESOURCE]
[DESTINATION ]
[INCLUDES DESTINATION [ ...]]
[PERMISSIONS permissions...]
On Tue, Aug 18, 2015 at 3:00 PM, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Richard, I tried to ping you on the review thread but I'm not sure it
> got through. Martell requested this be merged to 3.7. What do you
> think?
Sure, this looks fine for branch.
> On Thu, A
tra updated this revision to Diff 32478.
tra marked an inline comment as done.
tra added a comment.
used isTSBuiltin in SemaChecking.cpp
http://reviews.llvm.org/D12122
Files:
include/clang/Basic/Builtins.h
lib/Sema/SemaChecking.cpp
lib/Sema/SemaDecl.cpp
test/SemaCUDA/builtins.cu
test/
rsmith added a subscriber: rsmith.
rsmith added a comment.
LGTM
http://reviews.llvm.org/D12110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, Aug 18, 2015 at 2:03 PM, David Blaikie wrote:
> Richard, do you think there's anything we could do better here?
>
> It seems difficult to support proper move semantic behavior for
> [Sema]DiagnosticBuilder across the two common use cases:
>
> DiagnosticBuilder D;
> D << x;
> D << y;
Author: rsmith
Date: Tue Aug 18 18:42:23 2015
New Revision: 245390
URL: http://llvm.org/viewvc/llvm-project?rev=245390&view=rev
Log:
[modules] Fix HeaderFileInfo serialization to store all the known owning
modules for a header, not just the current favourite.
Modified:
cfe/trunk/include/clan
Author: rsmith
Date: Tue Aug 18 18:42:50 2015
New Revision: 245391
URL: http://llvm.org/viewvc/llvm-project?rev=245391&view=rev
Log:
[modules] Tests for r245390.
Added:
cfe/trunk/test/Modules/Inputs/explicit-build-overlap/
cfe/trunk/test/Modules/Inputs/explicit-build-overlap/a.h
cfe/t
xazax.hun added a comment.
Looks good to me. There are some minor nits inline.
Comment at: include/clang/StaticAnalyzer/Core/CheckerManager.h:96
@@ -95,1 +95,3 @@
+enum class ObjCCheckerKind {
+ PreVisit,
I do not really like the name ObjCCheckerKind, because
EricWF added a comment.
Followup on @beanz comments.
Comment at: src/CMakeLists.txt:123
@@ -124,1 +122,3 @@
+ LIBRARY DESTINATION lib${LIBCXXABI_LIBDIR_SUFFIX} COMPONENT libcxxabi
+ ARCHIVE DESTINATION lib${LIBCXXABI_LIBDIR_SUFFIX} COMPONENT libcxxabi
)
bea
Author: ericwf
Date: Tue Aug 18 18:29:59 2015
New Revision: 245389
URL: http://llvm.org/viewvc/llvm-project?rev=245389&view=rev
Log:
[libcxx] Add Atomic test helper and fix TSAN failures.
Summary:
This patch attempts to fix the last 3 TSAN failures on the libc++ bot
(http://lab.llvm.org:8011/bui
Awesome, thanks!
On Tue, Aug 18, 2015 at 4:27 PM, Reid Kleckner wrote:
> I merged both of them and tweaked the test case to make it work.
>
> On Tue, Aug 18, 2015 at 2:55 PM, Hans Wennborg wrote:
>>
>> On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg wrote:
>> > On Mon, Aug 10, 2015 at 12:39 PM,
I merged both of them and tweaked the test case to make it work.
On Tue, Aug 18, 2015 at 2:55 PM, Hans Wennborg wrote:
> On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg wrote:
> > On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits
> > wrote:
> >> Author: rnk
> >> Date: Mon Aug 10 1
EricWF updated this revision to Diff 32473.
EricWF added a comment.
Fix more failing TSAN tests.
http://reviews.llvm.org/D11046
Files:
test/std/thread/thread.condition/notify_all_at_thread_exit.pass.cpp
test/std/thread/thread.condition/thread.condition.condvar/notify_one.pass.cpp
test/st
eliben added inline comments.
Comment at: include/clang/Basic/Builtins.h:85
@@ +84,3 @@
+ /// \brief Return true if this function is a target-specific builtin
+ bool isTSBuiltin(unsigned ID) const {
+return ID >= Builtin::FirstTSBuiltin;
You can also use it
On Tue, Aug 18, 2015 at 3:00 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Aug 14, 2015 at 11:27 AM, Hans Wennborg via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Tue, Aug 11, 2015 at 1:41 PM, Hans Wennborg wrote:
>> > On Thu, Aug 6, 2015 at 1:56
krememek added a subscriber: krememek.
krememek added a comment.
I think this is a great refinement overall, with a few minor nits. It also
isn't clear what the test does.
Comment at: include/clang/StaticAnalyzer/Core/CheckerManager.h:577
@@ -559,1 +576,3 @@
+ const std::ve
Author: dblaikie
Date: Tue Aug 18 17:40:54 2015
New Revision: 245378
URL: http://llvm.org/viewvc/llvm-project?rev=245378&view=rev
Log:
Devirtualize EHScopeStack::Cleanup's dtor because it's never destroyed
polymorphically
Modified:
cfe/trunk/lib/CodeGen/CGBlocks.cpp
cfe/trunk/lib/CodeGen
dcoughlin created this revision.
dcoughlin added reviewers: zaks.anna, jordan_rose, xazax.hun.
dcoughlin added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
In Objective-C, method calls with nil receivers are essentially no-ops. They
do not fault (although the returned value may
tra created this revision.
tra added reviewers: eliben, echristo.
tra added a subscriber: cfe-commits.
The patch adds appropriate __host__ or __device__ attributes to target-specific
builtins
so we can properly check whether they may or may not be called from particular
context.
http://review
krememek added inline comments.
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:749
@@ -748,3 +748,3 @@
assert (Src != Dst && "Self-edges are not allowed.");
ismailp wrote:
> Is Ubigraph generator actively maintained? If I run tests with
> '-a
krememek added inline comments.
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:784
@@ -783,3 +783,3 @@
- *Out << "('vertex_style_attribute', 0, ('shape', 'icosahedron'))\n";
- *Out << "('vertex_style', 1, 0, ('shape', 'sphere'), ('color', '#ffcc66'),"
+ *this->O
Author: dblaikie
Date: Tue Aug 18 17:10:49 2015
New Revision: 245368
URL: http://llvm.org/viewvc/llvm-project?rev=245368&view=rev
Log:
Fix for MSVC
Modified:
cfe/trunk/lib/CodeGen/EHScopeStack.h
Modified: cfe/trunk/lib/CodeGen/EHScopeStack.h
URL:
http://llvm.org/viewvc/llvm-project/cfe/trun
Author: dblaikie
Date: Tue Aug 18 17:09:28 2015
New Revision: 245367
URL: http://llvm.org/viewvc/llvm-project?rev=245367&view=rev
Log:
Wdeprecated: Support movability of EHScopeStack::Cleanup objects as they are
move constructed in ConditionalCleanup::restore
Modified:
cfe/trunk/lib/CodeGen/
On 18 August 2015 at 14:46, Richard Smith wrote:
> On Tue, Aug 18, 2015 at 1:52 PM, Gábor Horváth
> wrote:
>
>> On 18 August 2015 at 13:41, Richard Smith wrote:
>>
>>> On Tue, Aug 18, 2015 at 12:59 PM, Gábor Horváth
>>> wrote:
>>>
Hi!
In r244416 you made createModuleManager to c
ismailp added inline comments.
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:749
@@ -748,3 +748,3 @@
assert (Src != Dst && "Self-edges are not allowed.");
Is Ubigraph generator actively maintained? If I run tests with
'-analyzer-viz-egraph-u
Richard, I tried to ping you on the review thread but I'm not sure it
got through. Martell requested this be merged to 3.7. What do you
think?
On Fri, Aug 14, 2015 at 12:05 PM, Martell Malone via cfe-commits
wrote:
> Author: martell
> Date: Fri Aug 14 14:05:56 2015
> New Revision: 245084
>
> URL:
ismailp created this revision.
ismailp added reviewers: zaks.anna, krememek.
ismailp added a subscriber: cfe-commits.
Name `Out` refers to the parameter. It is moved into the member `Out`
in ctor-init. Dereferencing null pointer will crash clang, if user
passes '-analyzer-viz-egraph-ubigraph' argu
On Fri, Aug 14, 2015 at 11:27 AM, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Aug 11, 2015 at 1:41 PM, Hans Wennborg wrote:
> > On Thu, Aug 6, 2015 at 1:56 PM, David Majnemer via cfe-commits
> > wrote:
> >> Author: majnemer
> >> Date: Thu Aug 6 15:56:55 2015
> >
Richard, I tried to ping you on the review thread but I'm not sure it
got through. Martell requested this be merged to 3.7. What do you
think?
On Thu, Aug 13, 2015 at 8:41 AM, Martell Malone via cfe-commits
wrote:
> Author: martell
> Date: Thu Aug 13 10:41:04 2015
> New Revision: 244902
>
> URL:
On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg wrote:
> On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits
> wrote:
>> Author: rnk
>> Date: Mon Aug 10 14:39:01 2015
>> New Revision: 244488
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=244488&view=rev
>> Log:
>> [dllimport] A non
Author: rsmith
Date: Tue Aug 18 16:53:42 2015
New Revision: 245361
URL: http://llvm.org/viewvc/llvm-project?rev=245361&view=rev
Log:
Range-based-for-convert some loops in ASTWriter. No functionality change
intended.
Modified:
cfe/trunk/include/clang/Basic/Module.h
cfe/trunk/lib/Serializa
On Tue, Aug 18, 2015 at 1:52 PM, Gábor Horváth wrote:
> On 18 August 2015 at 13:41, Richard Smith wrote:
>
>> On Tue, Aug 18, 2015 at 12:59 PM, Gábor Horváth
>> wrote:
>>
>>> Hi!
>>>
>>> In r244416 you made createModuleManager to call the Initialize method
>>> of the ASTConsumer.
>>> Because of
samsonov created this revision.
samsonov added a reviewer: EricWF.
samsonov added a subscriber: cfe-commits.
We are going to remove the former soon.
http://reviews.llvm.org/D12117
Files:
test/libcxx/containers/sequences/vector/asan.pass.cpp
Index: test/libcxx/containers/sequences/vector/asan.
EricWF updated this revision to Diff 32454.
EricWF added a comment.
Add more explanation to the wait tests.
http://reviews.llvm.org/D11046
Files:
test/std/thread/thread.condition/notify_all_at_thread_exit.pass.cpp
test/std/thread/thread.condition/thread.condition.condvarany/wait.exception.
Wow! Thank you for catching that!
Fixed in r245359.
-Chris
> On Aug 18, 2015, at 2:15 PM, Hal Finkel wrote:
>
> - Original Message -
>> From: "Chris Bieneman via cfe-commits"
>> To: cfe-commits@lists.llvm.org
>> Sent: Tuesday, August 18, 2015 11:15:44 AM
>> Subject: r245304 - We shoul
Author: cbieneman
Date: Tue Aug 18 16:23:44 2015
New Revision: 245359
URL: http://llvm.org/viewvc/llvm-project?rev=245359&view=rev
Log:
[autoconf] Fixing reversed logic introduced r245304.
Thanks for the catch Hal!
Modified:
cfe/trunk/Makefile
Modified: cfe/trunk/Makefile
URL:
http://llvm.
- Original Message -
> From: "Chris Bieneman via cfe-commits"
> To: cfe-commits@lists.llvm.org
> Sent: Tuesday, August 18, 2015 11:15:44 AM
> Subject: r245304 - We shouldn't need to pass -fno-strict-aliasing when
> building clang with clang.
>
> Author: cbieneman
> Date: Tue Aug 18 11:15
Author: ericwf
Date: Tue Aug 18 16:08:54 2015
New Revision: 245354
URL: http://llvm.org/viewvc/llvm-project?rev=245354&view=rev
Log:
Move atomic_support.h and config_elast.h into src/include
Added:
libcxx/trunk/src/include/
libcxx/trunk/src/include/atomic_support.h
libcxx/trunk/src/in
Richard, do you think there's anything we could do better here?
It seems difficult to support proper move semantic behavior for
[Sema]DiagnosticBuilder across the two common use cases:
DiagnosticBuilder D;
D << x;
D << y;
return D;
and
return DiagnosticBuilder() << x << y;
The only t
Author: dblaikie
Date: Tue Aug 18 15:54:26 2015
New Revision: 245352
URL: http://llvm.org/viewvc/llvm-project?rev=245352&view=rev
Log:
Workaround -Wdeprecated on SemDiagnosticConsumer's tricksy copy ctor.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
Modified: cfe/trunk/include/clang/Sema/Se
Author: rsmith
Date: Tue Aug 18 15:39:29 2015
New Revision: 245346
URL: http://llvm.org/viewvc/llvm-project?rev=245346&view=rev
Log:
Initialize the AST consumer as soon as we have both an ASTConsumer and an
ASTContext. Fixes some cases where we could previously initialize the AST
consumer more tha
Author: eugenis
Date: Tue Aug 18 15:36:11 2015
New Revision: 245344
URL: http://llvm.org/viewvc/llvm-project?rev=245344&view=rev
Log:
[sanitizer] Add -lutil to static runtime link flags.
This is needed to prevent breakage of -Wl,-as-needed link when
interceptors for functions in libutil are added
Author: joerg
Date: Tue Aug 18 15:34:33 2015
New Revision: 245343
URL: http://llvm.org/viewvc/llvm-project?rev=245343&view=rev
Log:
GC empty directory.
Removed:
libcxx/trunk/src/support/newlib/
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Author: nico
Date: Tue Aug 18 15:32:55 2015
New Revision: 245342
URL: http://llvm.org/viewvc/llvm-project?rev=245342&view=rev
Log:
Revert r245323, it caused PR24493.
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
cfe/trunk/test/CodeGen/object-size.c
cfe/trunk/test/Sema/const-eval.c
Mod
Author: aaronballman
Date: Tue Aug 18 15:27:44 2015
New Revision: 245340
URL: http://llvm.org/viewvc/llvm-project?rev=245340&view=rev
Log:
We no longer need a custom matcher for this; use the builtin AST matcher
instead. NFC, and existing tests should cover this change.
Modified:
clang-tools
Author: dblaikie
Date: Tue Aug 18 15:24:06 2015
New Revision: 245339
URL: http://llvm.org/viewvc/llvm-project?rev=245339&view=rev
Log:
Simplify Diagnostic's ctors a bit by using in-class initializers for its members
Modified:
cfe/trunk/include/clang/Basic/Diagnostic.h
Modified: cfe/trunk/inc
Sorry, I sent the original message to the wrong list.
-- Forwarded message --
From: Gábor Horváth
Date: 18 August 2015 at 12:59
Subject: Re: r244416 - [modules] PR22534: Load files specified by
-fmodule-file= eagerly. In particular, this avoids the need to re-parse
module map file
While at it, maybe the assertion can be modernized removing the != 0 part.
On Tue, Aug 18, 2015 at 3:09 PM, Davide Italiano wrote:
> davide created this revision.
> davide added a reviewer: rsmith.
> davide added a subscriber: cfe-commits.
>
> This has been disabled for a long time, but:
> 1) Ini
Author: marshall
Date: Tue Aug 18 14:51:37 2015
New Revision: 245336
URL: http://llvm.org/viewvc/llvm-project?rev=245336&view=rev
Log:
Broke C++03 compatibility in 245330. Fix that.
Modified:
libcxx/trunk/include/memory
Modified: libcxx/trunk/include/memory
URL:
http://llvm.org/viewvc/llvm-
Author: ericwf
Date: Tue Aug 18 14:41:51 2015
New Revision: 245335
URL: http://llvm.org/viewvc/llvm-project?rev=245335&view=rev
Log:
[libcxx] Fix PR23589: std::function doesn't recognize null pointer to varargs
function.
Summary:
This patch fixes __not_null's detection of nullptr by breaking it
1 - 100 of 136 matches
Mail list logo
