Re: r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

2015-08-12 Thread Yaron Keren via cfe-commits
Hi Ivan, CHECK-EIGHT is failing bots, see http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/24306/steps/check-all/logs/FAIL%3A%20Clang%3A%3Adependency-gen.c I disabled it in r244869. Yaron 2015-08-13 7:04 GMT+03:00 Ivan Krasin via cfe-commits < cfe-commits@lists.llvm.org>:

r244869 - Disable failing check in bots from r244867.

2015-08-12 Thread Yaron Keren via cfe-commits
Author: yrnkrn Date: Thu Aug 13 01:12:49 2015 New Revision: 244869 URL: http://llvm.org/viewvc/llvm-project?rev=244869&view=rev Log: Disable failing check in bots from r244867. Modified: cfe/trunk/test/Frontend/dependency-gen.c Modified: cfe/trunk/test/Frontend/dependency-gen.c URL: http:/

Re: [PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

2015-08-12 Thread Yaron Keren via cfe-commits
yaron.keren added a comment. Yes, go ahead. http://reviews.llvm.org/D11808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11297: PR17829: Functions declared extern "C" with a name matching a mangled C++ function are allowed

2015-08-12 Thread John McCall via cfe-commits
rjmccall added a comment. You only have one attempt to define the function here; I don't see the problem. Recall that I said to add a flag to getOrCreateLLVMFunction that says whether the caller intends to define the function. The rule should be that only callers that pass "true" should be al

r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

2015-08-12 Thread Ivan Krasin via cfe-commits
Author: krasin Date: Wed Aug 12 23:04:37 2015 New Revision: 244867 URL: http://llvm.org/viewvc/llvm-project?rev=244867&view=rev Log: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD. Summary: Clang sanitizers, such as AddressSanitizer, ThreadSanitizer, MemorySanitizer, Control

Re: [PATCH] D12002: Initial WebAssembly support in clang

2015-08-12 Thread Dan Gohman via cfe-commits
sunfish updated this revision to Diff 32025. sunfish marked 3 inline comments as done. sunfish added a comment. Minor changes to address review comments. Repository: rL LLVM http://reviews.llvm.org/D12002 Files: include/clang/Basic/BuiltinsWebAssembly.def include/clang/Basic/TargetBuilti

Re: [PATCH] D12002: Initial WebAssembly support in clang

2015-08-12 Thread Dan Gohman via cfe-commits
sunfish planned changes to this revision. sunfish marked 3 inline comments as done. Comment at: lib/Basic/Targets.cpp:6935 @@ +6934,3 @@ +NoAsmVariants = true; +LongDoubleWidth = LongDoubleAlign = 64; +SuitableAlign = 128; jfb wrote: > That's already t

Re: [PATCH] D7642: Introduce the idea of a minimum libc version

2015-08-12 Thread Saleem Abdulrasool via cfe-commits
compnerd added a comment. Okay, if thats the general pattern, then we can stick it in the triple. Though, that means that the use of the triple for determining the MS compatibility needs to be undone. If the version in the triple is the libc version, then it can differ from the MS compatibili

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

2015-08-12 Thread Sean Silva via cfe-commits
On Wed, Aug 12, 2015 at 6:05 PM, Richard Smith wrote: > On Wed, Aug 12, 2015 at 6:00 PM, Sean Silva wrote: > >> >> >> On Wed, Aug 12, 2015 at 2:43 PM, Richard Smith >> wrote: >> >>> On Wed, Aug 12, 2015 at 12:08 AM, Sean Silva >>> wrote: >>> silvas added a subscriber: silvas. ==

Re: [PATCH] D12002: Initial WebAssembly support in clang

2015-08-12 Thread JF Bastien via cfe-commits
jfb added a subscriber: rengolin. Comment at: include/clang/Basic/TargetCXXABI.h:166 @@ +165,3 @@ +case GenericMIPS: + // TODO: ARM-style pointers to member functions put the discriminator in + // the this adjustment, so they don't require functions to have any

r244855 - Update for llvm api change.

2015-08-12 Thread Rafael Espindola via cfe-commits
Author: rafael Date: Wed Aug 12 20:07:06 2015 New Revision: 244855 URL: http://llvm.org/viewvc/llvm-project?rev=244855&view=rev Log: Update for llvm api change. Modified: cfe/trunk/tools/driver/driver.cpp Modified: cfe/trunk/tools/driver/driver.cpp URL: http://llvm.org/viewvc/llvm-project/c

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

2015-08-12 Thread Richard Smith via cfe-commits
On Wed, Aug 12, 2015 at 6:00 PM, Sean Silva wrote: > > > On Wed, Aug 12, 2015 at 2:43 PM, Richard Smith > wrote: > >> On Wed, Aug 12, 2015 at 12:08 AM, Sean Silva >> wrote: >> >>> silvas added a subscriber: silvas. >>> >>> >>> Comment at: lib/Parse/Parser.cpp:2003 >>> @@ +2002,

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

2015-08-12 Thread Sean Silva via cfe-commits
On Wed, Aug 12, 2015 at 2:43 PM, Richard Smith wrote: > On Wed, Aug 12, 2015 at 12:08 AM, Sean Silva > wrote: > >> silvas added a subscriber: silvas. >> >> >> Comment at: lib/Parse/Parser.cpp:2003 >> @@ +2002,3 @@ >> +Diag(Tok, diag::err_unexpected_module_start); >> +//

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

2015-08-12 Thread Sean Silva via cfe-commits
On Wed, Aug 12, 2015 at 6:00 PM, Sean Silva wrote: > > > On Wed, Aug 12, 2015 at 2:43 PM, Richard Smith > wrote: > >> On Wed, Aug 12, 2015 at 12:08 AM, Sean Silva >> wrote: >> >>> silvas added a subscriber: silvas. >>> >>> >>> Comment at: lib/Parse/Parser.cpp:2003 >>> @@ +2002,

r244852 - Add SourceManager::dump() to dump the current set of SLocEntries.

2015-08-12 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Aug 12 19:45:11 2015 New Revision: 244852 URL: http://llvm.org/viewvc/llvm-project?rev=244852&view=rev Log: Add SourceManager::dump() to dump the current set of SLocEntries. Modified: cfe/trunk/include/clang/Basic/SourceManager.h cfe/trunk/lib/Basic/SourceManager.

[PATCH] D12002: Initial WebAssembly support in clang

2015-08-12 Thread Dan Gohman via cfe-commits
sunfish created this revision. sunfish added subscribers: cfe-commits, jfb. sunfish set the repository for this revision to rL LLVM. This patch adds initial WebAssembly support in clang. The WebAssembly target is currently experimental. Repository: rL LLVM http://reviews.llvm.org/D12002 File

Re: [PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

2015-08-12 Thread Ivan Krasin via cfe-commits
krasin added a comment. Thank you, Peter. I will commit once I have restored my password (the email to Chris is sent) http://reviews.llvm.org/D11968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

2015-08-12 Thread Hal Finkel via cfe-commits
- Original Message - > From: "Dan Albert via cfe-commits" > To: "Marshall Clow" > Cc: "Joerg Sonnenberger" , "cfe-commits" > > Sent: Wednesday, August 12, 2015 6:03:30 PM > Subject: Re: [PATCH] D11948: Add some macros to abstract marking of > parameters as "not null", and use them in >

Re: [PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

2015-08-12 Thread Martell Malone via cfe-commits
martell updated this revision to Diff 32007. martell added a comment. Updated to address yaron's comments. Okay for me to merge now ? http://reviews.llvm.org/D11808 Files: lib/Driver/MinGWToolChain.cpp test/Driver/Inputs/mingw_clang_tree/mingw32/i686-w64-mingw32/include/.keep test/Driver

[PATCH] D12000: Bugfix - Clang handles __builtin_object_size in wrong way

2015-08-12 Thread George Burgess IV via cfe-commits
george.burgess.iv created this revision. george.burgess.iv added a subscriber: cfe-commits. Attached is a fix for https://llvm.org/bugs/show_bug.cgi?id=15212 . Summary: Tighten up some of the results for __builtin_object_size(ptr, type) when given type == 1 or type == 3 + fixed a bug where we wo

Re: r220305 - Driver: Move crash report command mangling into Command::Print

2015-08-12 Thread Justin Bogner via cfe-commits
On Wed, Aug 12, 2015 at 3:09 PM, David Blaikie wrote: > On Tue, Oct 21, 2014 at 10:24 AM, Justin Bogner > wrote: >> Author: bogner >> Date: Tue Oct 21 12:24:44 2014 >> New Revision: 220305 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=220305&view=rev >> Log: >> Driver: Move crash report comm

Re: [PATCH] D10356: scan-build: Add --analyzer-target option

2015-08-12 Thread Honggyu Kim via cfe-commits
honggyu.kim accepted this revision. honggyu.kim added a reviewer: honggyu.kim. honggyu.kim added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D10356#219772, @krememek wrote: > Committed r244400 Thanks for accepting it! http://reviews.llvm.org/D10356

r244843 - Wdeprecated: LambdaScopeInfos need to be copied, so make the ScopeInfo hierarchy safely copyable

2015-08-12 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Wed Aug 12 18:59:02 2015 New Revision: 244843 URL: http://llvm.org/viewvc/llvm-project?rev=244843&view=rev Log: Wdeprecated: LambdaScopeInfos need to be copied, so make the ScopeInfo hierarchy safely copyable Making the base class's copy ctor protected and the derived clas

r244838 - Wdeprecated: ApplyDebugLocation is returned by value yet if it is ever copied (rather than RVO'd) that would be broken, make it movable instead

2015-08-12 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Wed Aug 12 18:49:57 2015 New Revision: 244838 URL: http://llvm.org/viewvc/llvm-project?rev=244838&view=rev Log: Wdeprecated: ApplyDebugLocation is returned by value yet if it is ever copied (rather than RVO'd) that would be broken, make it movable instead Modified: cfe

r244831 - Wdeprecated: CGBuilderInserter is copy constructed in some contexts - remove the unnecessarily disabling copy assignment to enable this

2015-08-12 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Wed Aug 12 18:16:55 2015 New Revision: 244831 URL: http://llvm.org/viewvc/llvm-project?rev=244831&view=rev Log: Wdeprecated: CGBuilderInserter is copy constructed in some contexts - remove the unnecessarily disabling copy assignment to enable this The object has very simpl

r244829 - -Wdeprecated: Job objects are stored in a vector yet are not really copyable, make them movable instead

2015-08-12 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Wed Aug 12 18:09:24 2015 New Revision: 244829 URL: http://llvm.org/viewvc/llvm-project?rev=244829&view=rev Log: -Wdeprecated: Job objects are stored in a vector yet are not really copyable, make them movable instead Modified: cfe/trunk/lib/AST/ExprConstant.cpp Modifie

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

2015-08-12 Thread Dan Albert via cfe-commits
My testing was varied. I could not get GCC or clang to optimize it away for Linux, but both did for ARM Android. Regardless, the fact that GCC is already doing this doesn't mean it's desirable. We end up hunting and fixing bugs from this optimization this every release, and our time could be bette

r244826 - -Wdeprecated: SavedInstanceContext is returned by value but isn't really copyable, but it can be made movable

2015-08-12 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Wed Aug 12 17:58:10 2015 New Revision: 244826 URL: http://llvm.org/viewvc/llvm-project?rev=244826&view=rev Log: -Wdeprecated: SavedInstanceContext is returned by value but isn't really copyable, but it can be made movable Modified: cfe/trunk/lib/Sema/SemaAccess.cpp Mo

Re: [PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

2015-08-12 Thread Peter Collingbourne via cfe-commits
pcc accepted this revision. pcc added a reviewer: pcc. pcc added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D11968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [PATCH] D11658: [Sema] main can't be declared as global variable

2015-08-12 Thread Richard Smith via cfe-commits
rsmith added a comment. Looks good other than the diagnostic wording. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:513 @@ -512,1 +512,3 @@ "platform-specific data}0) must be of type %1">; +def err_main_global_variable : Error<"main can't be declared as global var

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

2015-08-12 Thread Marshall Clow via cfe-commits
On Tue, Aug 11, 2015 at 2:28 PM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Aug 11, 2015 at 02:06:58PM -0700, Marshall Clow via cfe-commits > wrote: > > On Tue, Aug 11, 2015 at 1:34 PM, Dan Albert > wrote: > > > > > Yeah, those sound like exactly what we wan

r244822 - [modules] If loading a .pcm file would cause us to run out of source locations, attempt to fail more gracefully. (No test; this requires >= 4GB of preprocessed input...)

2015-08-12 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Aug 12 17:25:24 2015 New Revision: 244822 URL: http://llvm.org/viewvc/llvm-project?rev=244822&view=rev Log: [modules] If loading a .pcm file would cause us to run out of source locations, attempt to fail more gracefully. (No test; this requires >= 4GB of preprocessed inp

Re: r244820 - Revert "Implement poisoning of only class members in dtor, as opposed to also poisoning fields inherited from base classes."

2015-08-12 Thread David Blaikie via cfe-commits
On Wed, Aug 12, 2015 at 3:17 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Wed, Aug 12, 2015 at 6:07 PM, Naomi Musgrave via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: nmusgrave >> Date: Wed Aug 12 17:07:24 2015 >> New Revision: 244820 >> >> U

Re: r244820 - Revert "Implement poisoning of only class members in dtor, as opposed to also poisoning fields inherited from base classes."

2015-08-12 Thread David Majnemer via cfe-commits
On Wed, Aug 12, 2015 at 6:07 PM, Naomi Musgrave via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: nmusgrave > Date: Wed Aug 12 17:07:24 2015 > New Revision: 244820 > > URL: http://llvm.org/viewvc/llvm-project?rev=244820&view=rev > Log: > Revert "Implement poisoning of only class membe

Re: r220305 - Driver: Move crash report command mangling into Command::Print

2015-08-12 Thread David Blaikie via cfe-commits
(switching over to the new mailing list) On Wed, Aug 12, 2015 at 3:09 PM, David Blaikie wrote: > > > On Tue, Oct 21, 2014 at 10:24 AM, Justin Bogner > wrote: > >> Author: bogner >> Date: Tue Oct 21 12:24:44 2014 >> New Revision: 220305 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=220305&v

r244820 - Revert "Implement poisoning of only class members in dtor, as opposed to also poisoning fields inherited from base classes."

2015-08-12 Thread Naomi Musgrave via cfe-commits
Author: nmusgrave Date: Wed Aug 12 17:07:24 2015 New Revision: 244820 URL: http://llvm.org/viewvc/llvm-project?rev=244820&view=rev Log: Revert "Implement poisoning of only class members in dtor, as opposed to also poisoning fields inherited from base classes." This reverts commit 8dbbf3578a9a5d0

Re: [PATCH] RE: [cfe-dev] missing return statement for non-void functions in C++

2015-08-12 Thread Richard Smith via cfe-commits
This patch seems a bit confused. You warn that the flag is ignored in C++, but it only has an effect in C++. You have a testcase with a .c extension that is built with -x c++. On Wed, Aug 12, 2015 at 5:23 AM, Sjoerd Meijer wrote: > [ + cfe-commits@lists.llvm.org ] > > > > Hi, > > The functionali

Re: [PATCH] D11993: [CUDA] Make sure we emit all templated __global__ functions on device side. Again.

2015-08-12 Thread Eli Bendersky via cfe-commits
eliben accepted this revision. eliben added a comment. lgtm Comment at: test/CodeGenCUDA/ptx-kernels.cu:26 @@ -16,1 +25,2 @@ // CHECK: !{{[0-9]+}} = !{void ()* @global_function, !"kernel", i32 1} +// CHECK: !{{[0-9]+}} = !{void (i32)* @_Z16templated_kernelIiEvT_, !"kernel", i3

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

2015-08-12 Thread Richard Smith via cfe-commits
On Wed, Aug 12, 2015 at 12:08 AM, Sean Silva wrote: > silvas added a subscriber: silvas. > > > Comment at: lib/Parse/Parser.cpp:2003 > @@ +2002,3 @@ > +Diag(Tok, diag::err_unexpected_module_start); > +// Recover by skipping content of the included submodule. > +unsign

r244819 - Implement poisoning of only class members in dtor, as opposed to also poisoning fields inherited from base classes.

2015-08-12 Thread Naomi Musgrave via cfe-commits
Author: nmusgrave Date: Wed Aug 12 16:37:40 2015 New Revision: 244819 URL: http://llvm.org/viewvc/llvm-project?rev=244819&view=rev Log: Implement poisoning of only class members in dtor, as opposed to also poisoning fields inherited from base classes. Verify emitted code for derived class with vi

Re: [PATCH] D11993: [CUDA] Make sure we emit all templated __global__ functions on device side. Again.

2015-08-12 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks for working on this. -eric http://reviews.llvm.org/D11993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D11993: [CUDA] Make sure we emit all templated __global__ functions on device side. Again.

2015-08-12 Thread Artem Belevich via cfe-commits
tra created this revision. tra added reviewers: echristo, rsmith, eliben. tra added a subscriber: cfe-commits. This is a somewhat different way to do it than D11666 which got rolled back. Codegen postpones emitting instantiated kernel function template until it's used. If kernel is used only fro

Re: [PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

2015-08-12 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. rsmith added a comment. LGTM http://reviews.llvm.org/D11968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

2015-08-12 Thread Ivan Krasin via cfe-commits
krasin updated this revision to Diff 31983. krasin added a comment. More tests / fix tests. http://reviews.llvm.org/D11968 Files: include/clang/Frontend/DependencyOutputOptions.h include/clang/Frontend/Utils.h lib/Frontend/CompilerInstance.cpp lib/Frontend/CompilerInvocation.cpp lib/F

Re: [PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

2015-08-12 Thread Ivan Krasin via cfe-commits
krasin marked an inline comment as done. krasin added a comment. Please, take another look. The test for --show-includes is on the way. http://reviews.llvm.org/D11968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

2015-08-12 Thread Ivan Krasin via cfe-commits
krasin updated this revision to Diff 31979. krasin added a comment. Windows compat http://reviews.llvm.org/D11968 Files: include/clang/Frontend/DependencyOutputOptions.h include/clang/Frontend/Utils.h lib/Frontend/CompilerInstance.cpp lib/Frontend/CompilerInvocation.cpp lib/Frontend/D

[PATCH] D11991: Represent 2 parallel string arrays as one string[][2] array.

2015-08-12 Thread Douglas Katzman via cfe-commits
dougk created this revision. dougk added a reviewer: chandlerc. dougk added a subscriber: cfe-commits. I think this conveys the intent better. Alternatively, since it's effectively trying to take llvm::sys::path::parent_path() for a number of times determined by the occurrences of '/' in one str

Re: [PATCH] D11940: don't diagnose -Wunused-parameter in virtual method or method that overrides base class method

2015-08-12 Thread Nico Weber via cfe-commits
On Wed, Aug 12, 2015 at 11:16 AM, David Blaikie wrote: > > > On Wed, Aug 12, 2015 at 11:12 AM, Nico Weber wrote: > >> On Wed, Aug 12, 2015 at 11:06 AM, David Blaikie >> wrote: >> >>> >>> >>> On Wed, Aug 12, 2015 at 10:11 AM, Nico Weber >>> wrote: >>> On Tue, Aug 11, 2015 at 10:15 PM, Dani

r244802 - Switching from an explicit loop to DeleteContainerSeconds; NFC.

2015-08-12 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Aug 12 15:05:18 2015 New Revision: 244802 URL: http://llvm.org/viewvc/llvm-project?rev=244802&view=rev Log: Switching from an explicit loop to DeleteContainerSeconds; NFC. Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp Modified: cfe/trunk/lib/ASTMatch

Re: r244792 - RangRangify some more for loops; NFC.

2015-08-12 Thread David Blaikie via cfe-commits
On Wed, Aug 12, 2015 at 1:03 PM, Aaron Ballman wrote: > On Wed, Aug 12, 2015 at 3:37 PM, David Blaikie wrote: > > > > > > On Wed, Aug 12, 2015 at 12:00 PM, Aaron Ballman via cfe-commits > > wrote: > >> > >> Author: aaronballman > >> Date: Wed Aug 12 14:00:39 2015 > >> New Revision: 244792 > >>

Re: r244792 - RangRangify some more for loops; NFC.

2015-08-12 Thread Aaron Ballman via cfe-commits
On Wed, Aug 12, 2015 at 3:37 PM, David Blaikie wrote: > > > On Wed, Aug 12, 2015 at 12:00 PM, Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Wed Aug 12 14:00:39 2015 >> New Revision: 244792 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=244792&view=rev >> Log: >> R

r244797 - Docs: keep copyright years up-to-date

2015-08-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 12 14:45:01 2015 New Revision: 244797 URL: http://llvm.org/viewvc/llvm-project?rev=244797&view=rev Log: Docs: keep copyright years up-to-date Modified: cfe/trunk/docs/conf.py Modified: cfe/trunk/docs/conf.py URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/

Re: r244792 - RangRangify some more for loops; NFC.

2015-08-12 Thread David Blaikie via cfe-commits
On Wed, Aug 12, 2015 at 12:00 PM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Wed Aug 12 14:00:39 2015 > New Revision: 244792 > > URL: http://llvm.org/viewvc/llvm-project?rev=244792&view=rev > Log: > RangRangify some more for loops; NFC. > > Mo

r244795 - Options.td: Drop trailing space in -fsanitize= help text

2015-08-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 12 14:35:05 2015 New Revision: 244795 URL: http://llvm.org/viewvc/llvm-project?rev=244795&view=rev Log: Options.td: Drop trailing space in -fsanitize= help text Modified: cfe/trunk/include/clang/Driver/Options.td Modified: cfe/trunk/include/clang/Driver/Options.td

r244794 - Docs: update clang-cl command-line documentation

2015-08-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 12 14:35:01 2015 New Revision: 244794 URL: http://llvm.org/viewvc/llvm-project?rev=244794&view=rev Log: Docs: update clang-cl command-line documentation Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL: http://llvm.org/viewvc/l

Re: [PATCH] Fix types of size_t, intptr_t, and ptrdiff_t on OpenBSD/sparc.

2015-08-12 Thread Brad Smith via cfe-commits
On 08/12/15 11:24, James Y Knight wrote: Sorry for the miscommunication, I thought you were going to commit it already. LGTM. Oh, I was waiting for someone to say something. Thanks. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.

[clang-tools-extra] r244793 - [clang-tidy] Make FileOptionsProvider fields protected to make extending it easier

2015-08-12 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Wed Aug 12 14:29:57 2015 New Revision: 244793 URL: http://llvm.org/viewvc/llvm-project?rev=244793&view=rev Log: [clang-tidy] Make FileOptionsProvider fields protected to make extending it easier Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyOptions.h Modified: c

r244792 - RangRangify some more for loops; NFC.

2015-08-12 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Aug 12 14:00:39 2015 New Revision: 244792 URL: http://llvm.org/viewvc/llvm-project?rev=244792&view=rev Log: RangRangify some more for loops; NFC. Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp U

Re: [PATCH] D11946: Create clang-tidy module modernize. Add pass-by-value check.

2015-08-12 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/modernize/PassByValueCheck.cpp:158 @@ +157,3 @@ + Compiler.getLangOpts(), + IncludeSorter::IS_LLVM)); + Compiler.getPreprocessor().addPPCallbacks(Inserter-

Re: [PATCH] D11944: Nativize filename in FileManager::getFile().

2015-08-12 Thread Richard Smith via cfe-commits
rsmith added a comment. In principle, normalizing slashes on Windows makes sense here. But we shouldn't use `llvm::sys::path::native`, because it's just too broken. Comment at: lib/Basic/FileManager.cpp:221-222 @@ -220,1 +220,4 @@ + SmallString<1024> NativeFilename; + llvm:

Re: [PATCH] D11983: Make getToolChain actually cache its result, as documented in Driver.h

2015-08-12 Thread Chandler Carruth via cfe-commits
chandlerc added a comment. This isn't necessary. The TC that we assign to is a reference to the pointer in the map. It should already be caching. http://reviews.llvm.org/D11983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

r244791 - Don't compare getArchName() to "tce" as a string. NFC.

2015-08-12 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Wed Aug 12 13:36:12 2015 New Revision: 244791 URL: http://llvm.org/viewvc/llvm-project?rev=244791&view=rev Log: Don't compare getArchName() to "tce" as a string. NFC. Modified: cfe/trunk/lib/Driver/Driver.cpp Modified: cfe/trunk/lib/Driver/Driver.cpp URL: http://llvm.org

Re: [PATCH] D11403: [Modules] Add Darwin-specific compatibility module map parsing hacks

2015-08-12 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks fine, go ahead once you're satisfied that the performance is OK for the `requires excluded` / umbrella dir hack. Comment at: include/clang/Basic/Module.h:363 @@ +362,3

Re: [PATCH] D11916: [CONCEPTS] Add diagnostic; invalid tag when concept specified

2015-08-12 Thread Aaron Ballman via cfe-commits
LGTM! ~Aaron On Wed, Aug 12, 2015 at 1:40 PM, Nathan Wilson wrote: > nwilson updated this revision to Diff 31957. > nwilson added a comment. > > Addressing comments which were discussed on the mailing list - Apply the same > text when diagnosing a free standing declaration as suggested by Aaron

Re: [PATCH] D11778: Improvements on Diagnostic in Macro Expansions

2015-08-12 Thread Richard Trieu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL244788: Stop printing macro backtraces that don't help diagnostics. (authored by rtrieu). Changed prior to commit: http://reviews.llvm.org/D11778?vs=31425&id=31965#toc Repository: rL LLVM http://rev

r244788 - Stop printing macro backtraces that don't help diagnostics.

2015-08-12 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Wed Aug 12 13:24:59 2015 New Revision: 244788 URL: http://llvm.org/viewvc/llvm-project?rev=244788&view=rev Log: Stop printing macro backtraces that don't help diagnostics. When displaying the macro backtrace, ignore some of the backtraces that do not provide extra information

Re: [PATCH] D11940: don't diagnose -Wunused-parameter in virtual method or method that overrides base class method

2015-08-12 Thread David Blaikie via cfe-commits
On Wed, Aug 12, 2015 at 11:12 AM, Nico Weber wrote: > On Wed, Aug 12, 2015 at 11:06 AM, David Blaikie > wrote: > >> >> >> On Wed, Aug 12, 2015 at 10:11 AM, Nico Weber wrote: >> >>> On Tue, Aug 11, 2015 at 10:15 PM, Daniel Marjamäki < >>> daniel.marjam...@evidente.se> wrote: >>> ideall

Re: [PATCH] D11778: Improvements on Diagnostic in Macro Expansions

2015-08-12 Thread Richard Trieu via cfe-commits
rtrieu accepted this revision. rtrieu added a comment. This revision is now accepted and ready to land. This is a first step towards making macro diagnostics better. http://reviews.llvm.org/D11778 ___ cfe-commits mailing list cfe-commits@lists.llvm.

Re: [PATCH] D11940: don't diagnose -Wunused-parameter in virtual method or method that overrides base class method

2015-08-12 Thread Nico Weber via cfe-commits
On Wed, Aug 12, 2015 at 11:06 AM, David Blaikie wrote: > > > On Wed, Aug 12, 2015 at 10:11 AM, Nico Weber wrote: > >> On Tue, Aug 11, 2015 at 10:15 PM, Daniel Marjamäki < >> daniel.marjam...@evidente.se> wrote: >> >>> >>> ideally there should be no -Wunused-parameter compiler warning when the >>

Re: [PATCH] D11940: don't diagnose -Wunused-parameter in virtual method or method that overrides base class method

2015-08-12 Thread David Blaikie via cfe-commits
On Wed, Aug 12, 2015 at 10:11 AM, Nico Weber wrote: > On Tue, Aug 11, 2015 at 10:15 PM, Daniel Marjamäki < > daniel.marjam...@evidente.se> wrote: > >> >> ideally there should be no -Wunused-parameter compiler warning when the >> parameter is used. >> >> would it feel better to move the "FP" warni

[PATCH] D11983: Make getToolChain actually cache its result, as documented in Driver.h

2015-08-12 Thread Douglas Katzman via cfe-commits
dougk created this revision. dougk added a reviewer: chandlerc. dougk added a subscriber: cfe-commits. http://reviews.llvm.org/D11983 Files: lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === --- lib/Driver/Driver.cpp +++ lib/

Re: [PATCH] D11916: [CONCEPTS] Add diagnostic; invalid tag when concept specified

2015-08-12 Thread Nathan Wilson via cfe-commits
nwilson updated this revision to Diff 31957. nwilson added a comment. Addressing comments which were discussed on the mailing list - Apply the same text when diagnosing a free standing declaration as suggested by Aaron. Replace diagnostic identifier err_concept_decl_non_template with err_concep

LLVM buildmaster will be restarted tonight

2015-08-12 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] r244774 - Merging r244005:

2015-08-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 12 12:16:39 2015 New Revision: 244774 URL: http://llvm.org/viewvc/llvm-project?rev=244774&view=rev Log: Merging r244005: r244005 | tbrethou | 2015-08-04 21:01:47 -0700 (Tue, 04 Aug 2015) | 2 lines

[libcxxabi] r244773 - Merging r244004:

2015-08-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 12 12:16:15 2015 New Revision: 244773 URL: http://llvm.org/viewvc/llvm-project?rev=244773&view=rev Log: Merging r244004: r244004 | tbrethou | 2015-08-04 21:01:26 -0700 (Tue, 04 Aug 2015) | 2 lines

[libcxx] r244772 - Merging r244003:

2015-08-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 12 12:15:27 2015 New Revision: 244772 URL: http://llvm.org/viewvc/llvm-project?rev=244772&view=rev Log: Merging r244003: r244003 | tbrethou | 2015-08-04 20:59:14 -0700 (Tue, 04 Aug 2015) | 2 lines

Re: [PATCH] D11940: don't diagnose -Wunused-parameter in virtual method or method that overrides base class method

2015-08-12 Thread Nico Weber via cfe-commits
On Tue, Aug 11, 2015 at 10:15 PM, Daniel Marjamäki < daniel.marjam...@evidente.se> wrote: > > ideally there should be no -Wunused-parameter compiler warning when the > parameter is used. > > would it feel better to move the "FP" warnings about virtual functions, > for instance to clang-tidy? > > >

Re: r244719 - [OPENMP] Fix for http://llvm.org/PR24430: clang hangs on invalid input with openmp directive

2015-08-12 Thread Hans Wennborg via cfe-commits
On Wed, Aug 12, 2015 at 12:10 AM, Alexey Bataev via cfe-commits wrote: > Author: abataev > Date: Wed Aug 12 02:10:54 2015 > New Revision: 244719 > > URL: http://llvm.org/viewvc/llvm-project?rev=244719&view=rev > Log: > [OPENMP] Fix for http://llvm.org/PR24430: clang hangs on invalid input with >

Re: [PATCH] D10365: Add cmd to compilation database file format

2015-08-12 Thread Daniel Dilts via cfe-commits
diltsman updated this revision to Diff 31952. diltsman marked an inline comment as done. http://reviews.llvm.org/D10365 Files: ../llvm/tools/clang/include/clang/Tooling/JSONCompilationDatabase.h ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp ../llvm/tools/clang/unittests/Toolin

Re: [PATCH] D10365: Add cmd to compilation database file format

2015-08-12 Thread Daniel Dilts via cfe-commits
diltsman added inline comments. Comment at: ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp:299 @@ +298,3 @@ +if (CommandFound) { + ErrorMessage = "Multiple command and arguments found"; + return false; klimek wrote: > Any rea

r244761 - ReleaseNotes: Small version nbr fix

2015-08-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Aug 12 11:40:42 2015 New Revision: 244761 URL: http://llvm.org/viewvc/llvm-project?rev=244761&view=rev Log: ReleaseNotes: Small version nbr fix Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/llvm-project

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

2015-08-12 Thread Jonathan Roelofs via cfe-commits
jroelofs updated this revision to Diff 31949. jroelofs added a comment. Add license text to the new file, and move the two has-no-threads tests to test/libcxx. http://reviews.llvm.org/D11963 Files: CMakeLists.txt include/CMakeLists.txt include/__config include/__config_site.in test/l

Re: [PATCH] D11946: Create clang-tidy module modernize. Add pass-by-value check.

2015-08-12 Thread Angel Garcia via cfe-commits
angelgarcia updated this revision to Diff 31948. angelgarcia marked 20 inline comments as done. angelgarcia added a comment. Fix tests and minor issues (auto, punctuation, etc). http://reviews.llvm.org/D11946 Files: clang-tidy/CMakeLists.txt clang-tidy/Makefile clang-tidy/modernize/CMakeL

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

2015-08-12 Thread Eric Fiselier via cfe-commits
EricWF added a reviewer: EricWF. EricWF added a comment. @jroelofs Thanks for this patch. I've needed this for a while. Comment at: include/__config:19 @@ -18,1 +18,3 @@ +#include <__config_site> + #ifdef __GNUC__ jroelofs wrote: > jroelofs wrote: > > mclow.lis

Re: [PATCH] D11403: [Modules] Add Darwin-specific compatibility module map parsing hacks

2015-08-12 Thread Ben Langmuir via cfe-commits
benlangmuir updated this revision to Diff 31947. benlangmuir added a comment. Changes per review. I still need to check performance of code-completing import statements to make sure the extra directory iteration isn't a big regression. Repository: rL LLVM http://reviews.llvm.org/D11403 Fi

r244760 - The alias.c test now requires arm-registered-target

2015-08-12 Thread John Brawn via cfe-commits
Author: john.brawn Date: Wed Aug 12 10:55:55 2015 New Revision: 244760 URL: http://llvm.org/viewvc/llvm-project?rev=244760&view=rev Log: The alias.c test now requires arm-registered-target This should fix a buildbot failure Modified: cfe/trunk/test/CodeGen/alias.c Modified: cfe/trunk/test/C

Re: [PATCH] Fix types of size_t, intptr_t, and ptrdiff_t on OpenBSD/sparc.

2015-08-12 Thread James Y Knight via cfe-commits
Sorry for the miscommunication, I thought you were going to commit it already. LGTM. On Wed, Aug 12, 2015 at 6:37 AM, Brad Smith wrote: > On 06/05/2015 08:30 PM, Brad Smith wrote: > >> On 06/05/15 01:33, James Y Knight wrote: >> >>> Thanks. Openbsd doesn't seem to have a gcc spec file with it ov

r244756 - Add test for PR24379

2015-08-12 Thread John Brawn via cfe-commits
Author: john.brawn Date: Wed Aug 12 10:15:27 2015 New Revision: 244756 URL: http://llvm.org/viewvc/llvm-project?rev=244756&view=rev Log: Add test for PR24379 The fix for this is in LLVM but it depends on how clang handles the alias attribute, so add a test to the clang tests to make sure everythi

Re: [PATCH] D11980: Add test for PR24379

2015-08-12 Thread John Brawn via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL244756: Add test for PR24379 (authored by john.brawn). Changed prior to commit: http://reviews.llvm.org/D11980?vs=31939&id=31942#toc Repository: rL LLVM http://reviews.llvm.org/D11980 Files: cfe/t

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

2015-08-12 Thread Jonathan Roelofs via cfe-commits
jroelofs added inline comments. Comment at: include/__config:19 @@ -18,1 +18,3 @@ +#include <__config_site> + #ifdef __GNUC__ jroelofs wrote: > mclow.lists wrote: > > espositofulvio wrote: > > > mclow.lists wrote: > > > > I'm reluctant to do this; because every i

Re: [PATCH] D11832: [Patch] [Analyzer] false positive: Potential leak connected with memcpy (PR 22954)

2015-08-12 Thread pierre gousseau via cfe-commits
pgousseau updated this revision to Diff 31940. pgousseau added a comment. Removed 'return' statements and added tests for empty arrays following Anna review. Refactored parameter passing of 'TK_DoNotInvalidateSuperRegion' following Anton review, by adding a new member function 'hasTrait' to 'Clu

r244751 - The version of libxml2 required by c-index-test must be at least 2.5.3. Considering that this version was released in 2003, you might think the check a bit ridiculous. Unfortunately, GnuWin3

2015-08-12 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Aug 12 10:01:15 2015 New Revision: 244751 URL: http://llvm.org/viewvc/llvm-project?rev=244751&view=rev Log: The version of libxml2 required by c-index-test must be at least 2.5.3. Considering that this version was released in 2003, you might think the check a bit r

Re: [PATCH] D11980: Add test for PR24379

2015-08-12 Thread Rafael Ávila de Espíndola via cfe-commits
rafael accepted this revision. rafael added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D11980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [PATCH] D9407: [Profile] Clang support for setting profile output from command line

2015-08-12 Thread Teresa Johnson via cfe-commits
tejohnson closed this revision. tejohnson added a comment. Committed awhile back as r236289, closing manually. http://reviews.llvm.org/D9407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D9717: [Patch] Temporarily revert test to prepare for LLVM -fprofile-instr-generate= fix

2015-08-12 Thread Teresa Johnson via cfe-commits
tejohnson abandoned this revision. tejohnson added a comment. Obsolete, didn't need to do this. http://reviews.llvm.org/D9717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11582: Fix assertion failure in TransformOpaqueValueExpr

2015-08-12 Thread Rachel Craik via cfe-commits
rcraik added a comment. ping 2! http://reviews.llvm.org/D11582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

2015-08-12 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: include/__config:19 @@ -18,1 +18,3 @@ +#include <__config_site> + #ifdef __GNUC__ espositofulvio wrote: > mclow.lists wrote: > > I'm reluctant to do this; because every include file slows down compilation > > - for

[PATCH] D11980: Add test for PR24379

2015-08-12 Thread John Brawn via cfe-commits
john.brawn created this revision. john.brawn added reviewers: rafael, ab. john.brawn added a subscriber: cfe-commits. john.brawn set the repository for this revision to rL LLVM. The fix for this is in LLVM but it depends on how clang handles the alias attribute, so add a test to the clang tests t

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

2015-08-12 Thread Jonathan Roelofs via cfe-commits
jroelofs added inline comments. Comment at: include/__config:19 @@ -18,1 +18,3 @@ +#include <__config_site> + #ifdef __GNUC__ espositofulvio wrote: > mclow.lists wrote: > > I'm reluctant to do this; because every include file slows down compilation > > - for eve

r244749 - Rangify some for loops; NFC.

2015-08-12 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Aug 12 08:38:59 2015 New Revision: 244749 URL: http://llvm.org/viewvc/llvm-project?rev=244749&view=rev Log: Rangify some for loops; NFC. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp URL: http://llvm.org/viewvc/llvm-projec

  1   2   >