[libcxx] r244717 - Fix CMake error whet llvm-config reports a non-existent source directory.

Author: ericwf Date: Wed Aug 12 01:36:19 2015 New Revision: 244717 URL: http://llvm.org/viewvc/llvm-project?rev=244717&view=rev Log: Fix CMake error whet llvm-config reports a non-existent source directory. Modified: libcxx/trunk/cmake/Modules/HandleOutOfTreeLLVM.cmake Modified: libcxx/trunk

SV: [PATCH] D11940: don't diagnose -Wunused-parameter in virtual method or method that overrides base class method

ideally there should be no -Wunused-parameter compiler warning when the parameter is used. would it feel better to move the "FP" warnings about virtual functions, for instance to clang-tidy? > If you enable this warning, you probably want to know about unused > parameters, independent of if y

Re: [PATCH] D11781: Refactored pthread usage in libcxx

mclow.lists added a comment. How does this change interact with http://reviews.llvm.org/D11963 ? Repository: rL LLVM http://reviews.llvm.org/D11781 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

mclow.lists added inline comments. Comment at: include/__config:19 @@ -18,1 +18,3 @@ +#include <__config_site> + #ifdef __GNUC__ I'm reluctant to do this; because every include file slows down compilation - for every program that we compile. However, this may b

Re: [PATCH] D11772: [libclang] Add period to typedef kind docblock

compnerd closed this revision. compnerd added a comment. Committed as SVN r244715. http://reviews.llvm.org/D11772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r244715 - libclang: Add period to typedef kind docblock

Author: compnerd Date: Tue Aug 11 22:21:44 2015 New Revision: 244715 URL: http://llvm.org/viewvc/llvm-project?rev=244715&view=rev Log: libclang: Add period to typedef kind docblock All of the other docblocks for the CXCursor_* cursor kind enum values include documentation that ends with a period.

r244714 - [modules] Fix thread safety analysis to cope with merging of FieldDecls across modules.

Author: rsmith Date: Tue Aug 11 21:17:52 2015 New Revision: 244714 URL: http://llvm.org/viewvc/llvm-project?rev=244714&view=rev Log: [modules] Fix thread safety analysis to cope with merging of FieldDecls across modules. Added: cfe/trunk/test/Modules/Inputs/thread-safety/ cfe/trunk/test/

Re: [PATCH] D11772: [libclang] Add period to typedef kind docblock

modocache added a comment. I do! Thanks, @compnerd! http://reviews.llvm.org/D11772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11773: [libclang] Document IB attribute cursor kinds

modocache added a comment. Because I happen to know what these kinds are! ;) But I agree--they should all be documented. I can look into what the other kinds mean and add appropriate documentation for those as well. Maybe in another commit? http://reviews.llvm.org/D11773 __

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

kulpreet updated this revision to Diff 31894. kulpreet added a comment. Moved UIMethods over to StringMap so it should compile on Windows now. http://reviews.llvm.org/D11572 Files: lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checke

Re: [PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

pcc added a comment. > should include the default blacklist (and any explicit blacklists, if they > were specified)? Yes, exactly. Comment at: lib/Frontend/DependencyFile.cpp:416-420 @@ -413,2 +415,7 @@ + // Add extra dependencies to the end of the list. + for (auto Extra

Re: [PATCH] D11693: clang-format: Support generalized lambda captures.

strager planned changes to this revision. Comment at: lib/Format/UnwrappedLineParser.cpp:1057-1058 @@ +1056,4 @@ + while (!eof()) { +// FIXME: Once we have an expression parser in the UnwrappedLineParser, +// replace this by using parseAssigmentExpression() in

Re: [PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

krasin updated this revision to Diff 31895. krasin marked an inline comment as done. krasin added a comment. Add more test cases. http://reviews.llvm.org/D11968 Files: include/clang/Frontend/DependencyOutputOptions.h lib/Frontend/CompilerInvocation.cpp lib/Frontend/DependencyFile.cpp te

Re: [PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

krasin added a comment. In http://reviews.llvm.org/D11968#222338, @pcc wrote: > We should also make blacklists appear in the `--show-includes` output. Is it about Windows compatibility? Do you mean that the output of bin/clang-cl /Zs /showIncludes ~/lala.cc -fsanitize=address should include

Re: [Patch][LoopVectorize] Print vectorization analysis when loop hint pragma is specified

Thanks! Tyler > On Aug 11, 2015, at 3:27 PM, Mark Heffernan wrote: > > Nice! > > On Mon, Aug 10, 2015 at 6:57 PM, Tyler Nowicki > wrote: > Mark: Would you be interested in extending this to the loop unroller as well? > > I'd be happy to. I'm about to head off on va

Re: [PATCH] D11928: Deleted old fixme.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D11928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

pcc added a comment. We should also make blacklists appear in the `--show-includes` output. Comment at: lib/Frontend/DependencyFile.cpp:416-420 @@ -413,2 +415,7 @@ + // Add extra dependencies to the end of the list. + for (auto ExtraDep : ExtraDeps) { +AddFilename(ExtraD

Re: [PATCH] D11928: Deleted old fixme.

Prazek retitled this revision from "Small fixup" to "Deleted old fixme.". Prazek updated this revision to Diff 31891. http://reviews.llvm.org/D11928 Files: include/clang/AST/VTableBuilder.h Index: include/clang/AST/VTableBuilder.h ===

[PATCH] D11968: Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

krasin created this revision. krasin added subscribers: cfe-commits, pcc. Clang sanitizers, such as AddressSanitizer, ThreadSanitizer, MemorySanitizer, Control Flow Integrity and others, use blacklists to specify which types / functions should not be instrumented to avoid false positives or suppr

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs updated this revision to Diff 31885. jroelofs added a comment. @danalbert: sigh, yes. http://reviews.llvm.org/D11963 Files: CMakeLists.txt include/CMakeLists.txt include/__config include/__config_site.in test/libcxx/test/config.py test/std/atomics/libcpp-has-no-threads.pass

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

danalbert added inline comments. Comment at: CMakeLists.txt:304 @@ +303,3 @@ +configure_file( + include/__config_site.in + ${CMAKE_BINARY_DIR}/include/c++/v1/__config_site Did you forget to upload this? http://reviews.llvm.org/D11963 ___

Re: [PATCH] D11928: Small fixup

nwilson added a subscriber: nwilson. nwilson added a comment. Hi Piotr, Would you mind renaming the title of the Patch since the title will be committed as such? Thanks! http://reviews.llvm.org/D11928 ___ cfe-commits mailing list cfe-commits@lists

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs updated this revision to Diff 31878. jroelofs added a comment. fix typo http://reviews.llvm.org/D11963 Files: CMakeLists.txt include/CMakeLists.txt include/__config test/libcxx/test/config.py test/std/atomics/libcpp-has-no-threads.pass.cpp test/std/utilities/date.time/teste

[PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs created this revision. jroelofs added reviewers: mclow.lists, danalbert. jroelofs added subscribers: EricWF, ed, espositofulvio, cfe-commits, mclow.lists. This also means that we no longer have to teach lit how to define them when running tests. I have a corresponding patch for libcxxa

r244695 - Untabify.

Author: echristo Date: Tue Aug 11 18:17:31 2015 New Revision: 244695 URL: http://llvm.org/viewvc/llvm-project?rev=244695&view=rev Log: Untabify. Modified: cfe/trunk/lib/CodeGen/CGCall.cpp Modified: cfe/trunk/lib/CodeGen/CGCall.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeG

Re: [PATCH] D11781: Refactored pthread usage in libcxx

jroelofs added inline comments. Comment at: include/__config:744 @@ +743,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# ifndef _LIBCPP_THREAD_API +# error "No thread API" The reason to use `CMAKE_BINARY_DIR` over `CMAKE_CURRENT_SOURCE_DIR` as the location for this buil

Re: [PATCH] D11916: [CONCEPTS] Add diagnostic; invalid tag when concept specified

On Tue, Aug 11, 2015 at 5:46 PM, Richard Smith wrote: > On Tue, Aug 11, 2015 at 3:35 PM, Nathan Wilson > wrote: > >> >> >> On Tue, Aug 11, 2015 at 4:54 PM, Richard Smith >> wrote: >> >>> On Tue, Aug 11, 2015 at 2:46 PM, Nathan Wilson >>> wrote: >>> Okay, I'll make the change. Hm

Re: [PATCH] D11916: [CONCEPTS] Add diagnostic; invalid tag when concept specified

On Tue, Aug 11, 2015 at 3:35 PM, Nathan Wilson wrote: > > > On Tue, Aug 11, 2015 at 4:54 PM, Richard Smith > wrote: > >> On Tue, Aug 11, 2015 at 2:46 PM, Nathan Wilson >> wrote: >> >>> Okay, I'll make the change. >>> >>> Hmm, do you guys have any suggestions as far as renaming >>> err_concept_

Re: [PATCH] D11928: Small fixup

Prazek added inline comments. Comment at: include/clang/AST/VTableBuilder.h:54 @@ -53,3 +53,3 @@ - VTableComponent() { } + VTableComponent() = default; rnk wrote: > Is this ctor used? It leaves Value uninitialized. Maybe we should delete it > to ensure that

Re: [PATCH] D11781: Refactored pthread usage in libcxx

espositofulvio removed rL LLVM as the repository for this revision. espositofulvio updated this revision to Diff 31874. espositofulvio added a comment. Thread library selection is done at configure time by CMake now. http://reviews.llvm.org/D11781 Files: .gitignore CMakeLists.txt include/

Re: [PATCH] D11916: [CONCEPTS] Add diagnostic; invalid tag when concept specified

On Tue, Aug 11, 2015 at 4:54 PM, Richard Smith wrote: > On Tue, Aug 11, 2015 at 2:46 PM, Nathan Wilson > wrote: > >> Okay, I'll make the change. >> >> Hmm, do you guys have any suggestions as far as renaming >> err_concept_decl_non_template? >> How about err_concept_specifier_non_template? >> >

Re: [PATCH] D11781: Refactored pthread usage in libcxx

espositofulvio added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ jroelofs wrote: > jroelofs wrote: > > espositofulvio wrote: > > > theraven wrote: > >

Re: [PATCH] D11928: Small fixup

rnk added inline comments. Comment at: include/clang/AST/VTableBuilder.h:54 @@ -53,3 +53,3 @@ - VTableComponent() { } + VTableComponent() = default; Is this ctor used? It leaves Value uninitialized. Maybe we should delete it to ensure that it isn't called,

Re: [Patch][LoopVectorize] Print vectorization analysis when loop hint pragma is specified

Nice! On Mon, Aug 10, 2015 at 6:57 PM, Tyler Nowicki wrote: > Mark: Would you be interested in extending this to the loop unroller as > well? > I'd be happy to. I'm about to head off on vacation, but I'll get to it when I return. Mark > > P.S. I assume we should add similar logic to the loop

Re: [PATCH] D11781: Refactored pthread usage in libcxx

jroelofs added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ jroelofs wrote: > espositofulvio wrote: > > theraven wrote: > > > espositofulvio wrote: > >

Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

pcc added a comment. > The documentation would probably benefit from some advice about when to use > each and how they compare. Added. Comment at: lib/AST/ItaniumMangle.cpp:4119-4126 @@ +4118,10 @@ +raw_ostream &Out) { + if

Re: [PATCH] D6551: Improvements to scan-build.

ayartsev added a reviewer: zaks.anna. ayartsev removed a subscriber: zaks.anna. ayartsev updated this revision to Diff 31868. ayartsev added a comment. Hi Honggyu, thanks for updating the patch! The new patch contains changes introduced by r244400 (http://reviews.llvm.org/D10356) and r244673 pl

r244682 - [modules] When instantiating the contents of an imported CXXRecordDecl, we can

Author: rsmith Date: Tue Aug 11 17:00:24 2015 New Revision: 244682 URL: http://llvm.org/viewvc/llvm-project?rev=244682&view=rev Log: [modules] When instantiating the contents of an imported CXXRecordDecl, we can emit lexical contents for a declaration for another module. Track which module those c

Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

pcc updated this revision to Diff 31871. pcc added a comment. - Create distinct MDNodes for types with internal linkage; replace custom bit set mangling with mangleTypeName throughout - Add documentation explaining the difference between this and -fsanitize=function http://reviews.llvm.org/D11

Re: [PATCH] D11916: [CONCEPTS] Add diagnostic; invalid tag when concept specified

On Tue, Aug 11, 2015 at 2:46 PM, Nathan Wilson wrote: > Okay, I'll make the change. > > Hmm, do you guys have any suggestions as far as renaming > err_concept_decl_non_template? > How about err_concept_specifier_non_template? > Maybe err_concept_wrong_decl_kind? > We'd have to keep in mind th

Re: r244670 - Fixing a few C++0x comments to be C++11; NFC.

On Tue, Aug 11, 2015 at 5:47 PM, Richard Smith wrote: > On Tue, Aug 11, 2015 at 2:17 PM, Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Tue Aug 11 16:17:53 2015 >> New Revision: 244670 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=244670&view=rev >> Log: >> Fixing

Re: r244670 - Fixing a few C++0x comments to be C++11; NFC.

On Tue, Aug 11, 2015 at 2:17 PM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Tue Aug 11 16:17:53 2015 > New Revision: 244670 > > URL: http://llvm.org/viewvc/llvm-project?rev=244670&view=rev > Log: > Fixing a few C++0x comments to be C++11; NFC.

Re: [PATCH] D11916: [CONCEPTS] Add diagnostic; invalid tag when concept specified

Okay, I'll make the change. Hmm, do you guys have any suggestions as far as renaming err_concept_decl_non_template? How about err_concept_specifier_non_template? We'd have to keep in mind that err_concept_decl_non_template is also used outside of this check, i.e. `concept bool = true`. On Tue, A

Re: [PATCH] D11928: Small fixup

rsmith added a comment. This change now disables the move constructor and move assignment. I think just removing the comment is better. http://reviews.llvm.org/D11928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [PATCH] D11949: [MIPS] Use arch values for lock-free atomic operations

This revision was automatically updated to reflect the committed changes. Closed by commit rL244675: [MIPS] Use arch values for lock-free atomic operations (authored by petarj). Changed prior to commit: http://reviews.llvm.org/D11949?vs=31830&id=31864#toc Repository: rL LLVM http://reviews.

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

On Tue, Aug 11, 2015 at 02:06:58PM -0700, Marshall Clow via cfe-commits wrote: > On Tue, Aug 11, 2015 at 1:34 PM, Dan Albert wrote: > > > Yeah, those sound like exactly what we want. Helping people find UB is > > good, but optimizing assuming we've fixed all of the UB isn't something we > > can d

r244675 - [MIPS] Use arch values for lock-free atomic operations

Author: petarj Date: Tue Aug 11 16:27:39 2015 New Revision: 244675 URL: http://llvm.org/viewvc/llvm-project?rev=244675&view=rev Log: [MIPS] Use arch values for lock-free atomic operations Let NaClMips32ELTargetInfo inherit arch values for maximum width lock-free atomic operations. Differential R

Re: [PATCH] D11772: [libclang] Add period to typedef kind docblock

compnerd added a subscriber: compnerd. compnerd accepted this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision is now accepted and ready to land. Do you need this committed on your behalf? http://reviews.llvm.org/D11772 ___

Re: [PATCH] D11773: [libclang] Document IB attribute cursor kinds

compnerd added a subscriber: compnerd. compnerd added a comment. Why add docs for these but not the others around it? http://reviews.llvm.org/D11773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D11928: Small fixup

Prazek updated this revision to Diff 31863. http://reviews.llvm.org/D11928 Files: include/clang/AST/VTableBuilder.h Index: include/clang/AST/VTableBuilder.h === --- include/clang/AST/VTableBuilder.h +++ include/clang/AST/VTableBui

r244673 - [analyzer] Incorrect env variable replaced.

Author: ayartsev Date: Tue Aug 11 16:24:19 2015 New Revision: 244673 URL: http://llvm.org/viewvc/llvm-project?rev=244673&view=rev Log: [analyzer] Incorrect env variable replaced. Modified: cfe/trunk/tools/scan-build/scan-build Modified: cfe/trunk/tools/scan-build/scan-build URL: http://llvm

r244671 - Add an assert to catch lexical decl deserialization bugs.

Author: rsmith Date: Tue Aug 11 16:21:20 2015 New Revision: 244671 URL: http://llvm.org/viewvc/llvm-project?rev=244671&view=rev Log: Add an assert to catch lexical decl deserialization bugs. Modified: cfe/trunk/lib/Serialization/ASTReader.cpp Modified: cfe/trunk/lib/Serialization/ASTReader.c

Re: [PATCH] D11916: [CONCEPTS] Add diagnostic; invalid tag when concept specified

>From Aaron's description of the user experience, I think the err_concept_decl_non_template message text is good (although err_concept_decl_non_template might need to be renamed). -- HT On Tue, Aug 11, 2015 at 4:01 PM, Aaron Ballman wrote: > On Tue, Aug 11, 2015 at 3:36 PM, Nathan Wilson > wro

r244670 - Fixing a few C++0x comments to be C++11; NFC.

Author: aaronballman Date: Tue Aug 11 16:17:53 2015 New Revision: 244670 URL: http://llvm.org/viewvc/llvm-project?rev=244670&view=rev Log: Fixing a few C++0x comments to be C++11; NFC. Modified: cfe/trunk/include/clang/AST/DeclCXX.h Modified: cfe/trunk/include/clang/AST/DeclCXX.h URL: http:

Re: [PATCH] D11928: Small fixup

rnk added a comment. I added this code before C++11 migration. I wanted to explicitly default the copy ctor to document that it's a value type, rather than defaulting it implicitly. You can nuke both comments and uncomment the definition. http://reviews.llvm.org/D11928 _

r244669 - Add missing documentation for conversionDecl; NFC.

Author: aaronballman Date: Tue Aug 11 16:12:46 2015 New Revision: 244669 URL: http://llvm.org/viewvc/llvm-project?rev=244669&view=rev Log: Add missing documentation for conversionDecl; NFC. Modified: cfe/trunk/docs/LibASTMatchersReference.html Modified: cfe/trunk/docs/LibASTMatchersReference

r244666 - Add a polymorphic AST matcher for testing whether a constructor or a conversion declaration is marked as explicit or not.

Author: aaronballman Date: Tue Aug 11 16:09:52 2015 New Revision: 244666 URL: http://llvm.org/viewvc/llvm-project?rev=244666&view=rev Log: Add a polymorphic AST matcher for testing whether a constructor or a conversion declaration is marked as explicit or not. Modified: cfe/trunk/docs/LibAST

Re: [PATCH] D11928: Small fixup

rsmith added a comment. Reid, do you remember what this FIXME was for? (Added in r198462.) http://reviews.llvm.org/D11928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

- Original Message - > From: "Marshall Clow via cfe-commits" > To: "mclow lists" , chandl...@gmail.com, > rich...@metafoo.co.uk, e...@efcs.ca > Cc: jo...@netbsd.org, cfe-commits@lists.llvm.org > Sent: Tuesday, August 11, 2015 3:30:10 PM > Subject: Re: [PATCH] D11948: Add some macros to ab

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

On Tue, Aug 11, 2015 at 1:34 PM, Dan Albert wrote: > Yeah, those sound like exactly what we want. Helping people find UB is > good, but optimizing assuming we've fixed all of the UB isn't something we > can do. > Dan -- that's the situation you're in today. GCC has done that kind of optimization

Re: [PATCH] D10371: clang-format: Support @synchronized.

strager added a comment. ping http://reviews.llvm.org/D10371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl created this revision. aprantl added reviewers: dblaikie, echristo. aprantl added a subscriber: cfe-commits. aprantl set the repository for this revision to rL LLVM. This patch adds a -gmodules option to the driver and a -dwarf-ext-refs to cc1 to enable the use of external type references

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

joerg added a comment. LLVM makes the assumptions only if the prototype has them too? Attribute nonnull is certainly changing optimiser behavior with GCC... http://reviews.llvm.org/D11948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

r244662 - Add an AST matcher to match member intializers of a CXXCtorInitializer.

Author: aaronballman Date: Tue Aug 11 15:42:00 2015 New Revision: 244662 URL: http://llvm.org/viewvc/llvm-project?rev=244662&view=rev Log: Add an AST matcher to match member intializers of a CXXCtorInitializer. Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/include/clang/

Re: r244266 - [ItaniumCXXABI] Don't import RTTI data for classes with key functions

On Thu, Aug 6, 2015 at 1:56 PM, David Majnemer via cfe-commits wrote: > Author: majnemer > Date: Thu Aug 6 15:56:55 2015 > New Revision: 244266 > > URL: http://llvm.org/viewvc/llvm-project?rev=244266&view=rev > Log: > [ItaniumCXXABI] Don't import RTTI data for classes with key functions > > MinGW

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

Yeah, those sound like exactly what we want. Helping people find UB is good, but optimizing assuming we've fixed all of the UB isn't something we can do. Our bugs end up being rather permanent so we need to be defensive. On Tue, Aug 11, 2015 at 1:18 PM, Aaron Ballman wrote: > On Tue, Aug 11, 201

Re: [PATCH] D11957: SpaceBeforeParens (Always) with overloaded operators

djasper closed this revision. djasper added a comment. Submitted as r244660. Thank you. Repository: rL LLVM http://reviews.llvm.org/D11957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH][Solaris] Clang/Driver, stop hardcoding GCC paths in crt/ld.so lookup

Hi, thanks for the review, I was not even aware that this could be tested. Adding a test helped to fix me a couple extra issues (plus the one you already mentioned). New patch attached. Xan On Wed, Aug 05, 2015 at 09:14:30AM -0400, Rafael Espíndola wrote: > Please git-clang-format this patch. >

r244660 - clang-format: Make SpaceBeforeParens work with overloaded operators.

Author: djasper Date: Tue Aug 11 15:32:24 2015 New Revision: 244660 URL: http://llvm.org/viewvc/llvm-project?rev=244660&view=rev Log: clang-format: Make SpaceBeforeParens work with overloaded operators. Patch by Jon Chesterfield, thank you! Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp

Re: [PATCH] D11845: Properly pass through the PIC mode to the integrated assembler when doing assembly-only, and unify the Driver's PIC argument parsing.

joerg added a subscriber: joerg. joerg added a comment. I agree in principle. The "-static" thing is already in the initial code, but doesn't make sense to me. Comment at: lib/Driver/Tools.cpp:2928 @@ +2927,3 @@ +/// Parses the various -fpic/-fPIC/-fpie/-fPIE arguments. Then,

Re: [PATCH] D3583: Sema: Implement DR244

rsmith added a comment. This will be in 3.7. Repository: rL LLVM http://reviews.llvm.org/D3583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

mclow.lists added a comment. In http://reviews.llvm.org/D11948#221991, @joerg wrote: > No, it doesn't. It tells the compiler that it is free to make such > assumptions. Again, I disagree. The compiler already knows it is free to make such assumptions. (LLVM has an entire optimizer pass devote

Re: [PATCH] D11957: SpaceBeforeParens (Always) with overloaded operators

JonChesterfield added a comment. Thanks. I have no commit access. Repository: rL LLVM http://reviews.llvm.org/D11957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11957: SpaceBeforeParens (Always) with overloaded operators

djasper added a subscriber: djasper. djasper accepted this revision. djasper added a reviewer: djasper. djasper added a comment. This revision is now accepted and ready to land. Looks good. Do you have commit access? Repository: rL LLVM http://reviews.llvm.org/D11957 __

[clang-tools-extra] r244658 - Revert the diagnostic improvements in r244602 as they introduced a problematic dependency

Author: dblaikie Date: Tue Aug 11 15:21:45 2015 New Revision: 244658 URL: http://llvm.org/viewvc/llvm-project?rev=244658&view=rev Log: Revert the diagnostic improvements in r244602 as they introduced a problematic dependency Seems we had some internal uses that include ClangTidyTest.h and weren'

[PATCH] D11957: SpaceBeforeParens (Always) with overloaded operators

JonChesterfield created this revision. JonChesterfield added a subscriber: cfe-commits. JonChesterfield set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. The clang-format option SpaceBeforeParens "Always" does not insert a space before the opening parenthesis of

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

On Tue, Aug 11, 2015 at 4:10 PM, Dan Albert wrote: >> Would you be opposed to annotations that tell the programmer they have >> UB in their code, but *do not* effect the code generation? > > > Not on our end. This would be great. I ask because the new nullability attributes do not affect codegen

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

> > Would you be opposed to annotations that tell the programmer they have > UB in their code, but *do not* effect the code generation? Not on our end. This would be great. On Tue, Aug 11, 2015 at 12:56 PM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Aug 11, 201

Re: [PATCH] D11916: [CONCEPTS] Add diagnostic; invalid tag when concept specified

On Tue, Aug 11, 2015 at 3:36 PM, Nathan Wilson wrote: > > > On Tue, Aug 11, 2015 at 8:54 AM, Aaron Ballman > wrote: >> >> On Mon, Aug 10, 2015 at 3:00 PM, Nathan Wilson >> wrote: >> > nwilson created this revision. >> > nwilson added reviewers: rsmith, hubert.reinterpretcast, fraggamuffin, >> >

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

On Tue, Aug 11, 2015 at 3:32 PM, Joerg Sonnenberger via cfe-commits wrote: > joerg added a comment. > > No, it doesn't. It tells the compiler that it is free to make such > assumptions. Take a step back from the standard. Can you think of any > reasonable and efficient implementation of memcpy a

Re: [PATCH] D11916: [CONCEPTS] Add diagnostic; invalid tag when concept specified

On Tue, Aug 11, 2015 at 8:54 AM, Aaron Ballman wrote: > On Mon, Aug 10, 2015 at 3:00 PM, Nathan Wilson > wrote: > > nwilson created this revision. > > nwilson added reviewers: rsmith, hubert.reinterpretcast, fraggamuffin, > faisalv, aaron.ballman. > > nwilson added a subscriber: cfe-commits. > >

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked 4 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D11859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

joerg added a comment. No, it doesn't. It tells the compiler that it is free to make such assumptions. Take a step back from the standard. Can you think of any reasonable and efficient implementation of memcpy and friends, which fails for size 0? Adding the annotations (whether here or in strin

Re: [PATCH] D11950: [CUDA] Check register names on appropriate side of cuda compilation only.

eliben added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5944 @@ -5943,3 +5943,3 @@ ProcessDeclAttributes(S, NewVD, D); - + bool ShouldHandleTargetErrors = DeclAttrsMatchCUDAMode(getLangOpts(), NewVD); if (getLangOpts().CUDA) { Since this is a CUDA-o

r244650 - [MSVC Compatibility] Classify ext_ms_cast_fn_obj as DefaultError

Author: majnemer Date: Tue Aug 11 14:25:13 2015 New Revision: 244650 URL: http://llvm.org/viewvc/llvm-project?rev=244650&view=rev Log: [MSVC Compatibility] Classify ext_ms_cast_fn_obj as DefaultError This non-conforming extension was introduced to make it possible for us to correctly compile in

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

mclow.lists added a comment. In http://reviews.llvm.org/D11948#221936, @joerg wrote: > I'm against doing this unconditionally. IMO it creates bugs without > reasonable compensation. Just because glibc wants to hurt people doesn't mean > anyone should get hurt. Really? I see it as: It tells

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

mclow.lists added inline comments. Comment at: include/cstring:96 @@ +95,3 @@ +int strncmp(const char* __s1, const char* __s2, size_t __n) +{ return ::memcmp(__s1, __s2, __n); } + nlopes wrote: > typo here. Oops. Thanks! http://reviews.llvm.org/D11948 ___

Re: r232721 - Add option to switch off putting header modules into the dependency file.

On Tue, Aug 11, 2015 at 11:49 AM, Manuel Klimek wrote: > Back in the day I'm pretty sure you agreed with the general concept :) > Yeah, I don't think I fully understood the reason for having a cc1 -module-file-deps flag at the time. http://reviews.llvm.org/D8378 > I remember that we had problem

Re: [PATCH] D11859: Generating vptr assume loads

Prazek updated this revision to Diff 31846. http://reviews.llvm.org/D11859 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/ItaniumCXXABI.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGen/available-externally-hidden.cpp test/CodeGenCXX/c

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked 3 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D11859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked 4 inline comments as done. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:193-194 @@ -192,1 +192,4 @@ + bool isVirtualOffsetNeeded(CodeGenFunction &CGF, + const CXXRecordDecl *NearestVBase) override; + isVirtualOffsetNeededF

Re: [PATCH] D11940: don't diagnose -Wunused-parameter in virtual method or method that overrides base class method

On Tue, Aug 11, 2015 at 11:32 AM, David Blaikie wrote: > > > On Tue, Aug 11, 2015 at 8:46 AM, Nico Weber via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Can't you just change your signature to >> >> virtual void a(int /* x */) {} >> >> in these cases? >> > > You could - does it add

Re: r232721 - Add option to switch off putting header modules into the dependency file.

Back in the day I'm pretty sure you agreed with the general concept :) http://reviews.llvm.org/D8378 I remember that we had problems with absolute paths ending up in the .d file (which should not happen if none of the paths provided are absolute), but I don't remember why we went for not writing th

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

danalbert added a comment. In http://reviews.llvm.org/D11948#221936, @joerg wrote: > I'm against doing this unconditionally. IMO it creates bugs without > reasonable compensation. Just because glibc wants to hurt people doesn't mean > anyone should get hurt. +1. We don't want this in Android.

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

joerg added a subscriber: joerg. joerg added a comment. I'm against doing this unconditionally. IMO it creates bugs without reasonable compensation. Just because glibc wants to hurt people doesn't mean anyone should get hurt. http://reviews.llvm.org/D11948 __

Fwd: r232721 - Add option to switch off putting header modules into the dependency file.

On Thu, Mar 19, 2015 at 5:00 AM, Manuel Klimek wrote: > Author: klimek > Date: Thu Mar 19 07:00:22 2015 > New Revision: 232721 > > URL: http://llvm.org/viewvc/llvm-project?rev=232721&view=rev > Log: > Add option to switch off putting header modules into the dependency file. > Why? It is not corr

Re: r244413 - [modules] When building a dependency file, include module maps parsed in the

On Tue, Aug 11, 2015 at 8:38 PM Richard Smith wrote: > Those files were parsed as part of building the output, and are legitimate > dependencies of the compilation process; why do you want to suppress them > from the .d file? (I think adding a whole bunch of -fno-*-deps flags is > going in the wr

Re: r244413 - [modules] When building a dependency file, include module maps parsed in the

Those files were parsed as part of building the output, and are legitimate dependencies of the compilation process; why do you want to suppress them from the .d file? (I think adding a whole bunch of -fno-*-deps flags is going in the wrong direction, and would like to understand if there's some hig

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticParseKinds.td:1018-1019 @@ -1017,2 +1017,4 @@ "expected ';' after module name">; +def err_unexpected_module_end : Error<"unexpected module end">; +def err_unexpected_module_start : Error<"submodule cannot b

Re: [PATCH] D9741: Reject multiplication by zero cases in MallocOverflowSecurityChecker

hiraditya abandoned this revision. hiraditya added a comment. Duplicate of: http://reviews.llvm.org/D9924 http://reviews.llvm.org/D9741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

  1   2   >