Re: [PATCH] D11752: [X86] Pre-define __MOVBE__ when the target supports it.

craig.topper added a comment. What utility does __MOVBE__ serve? We don't have an instrinsic headers that needs this like the others. As far as I can tell gcc doesn't define this. http://reviews.llvm.org/D11752 ___ cfe-commits mailing list cfe-comm

Re: [PATCH] D11784: [PATCH] clang-tidy check for incorrect move constructor initializers

alexfh added a comment. In http://reviews.llvm.org/D11784#220654, @aaron.ballman wrote: > Ping? Sorry for the delay. I'm on vacation currently. Will be back tomorrow. - Alex http://reviews.llvm.org/D11784 ___ cfe-commits mailing list cfe-commits

Re: [PATCH] D11859: Generating vptr assume loads

nwilson added inline comments. Comment at: lib/CodeGen/CGClass.cpp:2155 @@ +2154,3 @@ +if (CGM.getCXXABI().canInitializeVPtr(Vptr.VTableClass, Vptr.Base.getBase(), + Vptr.NearestVBase)) + InitializeVTablePointer(Vptr);

Re: [PATCH] D11859: Generating vptr assume loads

djasper added inline comments. Comment at: lib/CodeGen/CGClass.cpp:2155 @@ +2154,3 @@ +if (CGM.getCXXABI().canInitializeVPtr(Vptr.VTableClass, Vptr.Base.getBase(), + Vptr.NearestVBase)) + InitializeVTablePointer(Vptr);

Re: [PATCH] D11475: [OPENMP] fix the assert in emitting captured code inside the target data construct

fraggamuffin added a comment. This patch has landed. Commit C:\llvmtrunk\tools\clang\lib\CodeGen\CGStmtOpenMP.cpp C:\llvmtrunk\tools\clang\lib\CodeGen\CGStmtOpenMP.cpp At revision: 244569 http://reviews.llvm.org/D11475 ___ cfe-commits mailing list c

r244569 - This patch fixes the assert in emitting captured code in the target data construct.

Author: fraggamuffin Date: Mon Aug 10 23:52:01 2015 New Revision: 244569 URL: http://llvm.org/viewvc/llvm-project?rev=244569&view=rev Log: This patch fixes the assert in emitting captured code in the target data construct. This is on behalf of Kelvin Li. http://reviews.llvm.org/D11475 Modified:

Re: [PATCH] D11859: Generating vptr assume loads

nwilson added a subscriber: nwilson. Comment at: lib/CodeGen/CGClass.cpp:1862 @@ +1861,3 @@ +if (CGM.getCXXABI().canInitializeVPtr(vptr.VTableClass, vptr.Base.getBase(), + vptr.NearestVBase)) + EmitVTableAssumptionLoad(vptr, This);

Re: [PATCH] D11859: Generating vptr assume loads

Prazek updated this revision to Diff 31768. http://reviews.llvm.org/D11859 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/ItaniumCXXABI.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGen/available-externally-hidden.cpp test/CodeGenCXX/c

[PATCH] D11928: Small fixup

Prazek created this revision. Prazek added reviewers: rsmith, majnemer. Prazek added a subscriber: cfe-commits. http://reviews.llvm.org/D11928 Files: include/clang/AST/VTableBuilder.h Index: include/clang/AST/VTableBuilder.h === -

Re: [PATCH] D11859: Generating vptr assume loads

Prazek updated this revision to Diff 31766. http://reviews.llvm.org/D11859 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/ItaniumCXXABI.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGen/available-externally-hidden.cpp test/CodeGenCXX/c

Re: [PATCH] D11757: Propagate SourceLocations through to get a Loc on float_cast_overflow

This revision was automatically updated to reflect the committed changes. Closed by commit rL244568: Propagate SourceLocations through to get a Loc on float_cast_overflow (authored by filcab). Changed prior to commit: http://reviews.llvm.org/D11757?vs=31429&id=31765#toc Repository: rL LLVM

r244568 - Propagate SourceLocations through to get a Loc on float_cast_overflow

Author: filcab Date: Mon Aug 10 23:19:28 2015 New Revision: 244568 URL: http://llvm.org/viewvc/llvm-project?rev=244568&view=rev Log: Propagate SourceLocations through to get a Loc on float_cast_overflow Summary: float_cast_overflow is the only UBSan check without a source location attached. This

Re: [PATCH] D11859: Generating vptr assume loads

Prazek added inline comments. Comment at: lib/CodeGen/CodeGenFunction.h:1328-1334 @@ -1320,8 +1327,9 @@ typedef llvm::SmallPtrSet VisitedVirtualBasesSetTy; - void InitializeVTablePointers(BaseSubobject Base, -const CXXRecordDecl *NearestVBase, -

r244564 - [MSVC Compat] Implement __is_destructible, __is_nothrow_destructible

Author: majnemer Date: Mon Aug 10 22:03:28 2015 New Revision: 244564 URL: http://llvm.org/viewvc/llvm-project?rev=244564&view=rev Log: [MSVC Compat] Implement __is_destructible, __is_nothrow_destructible Our implementations of these type trait intrinsics simply mapped them to __has_trivial_destru

Re: [PATCH] D11859: Generating vptr assume loads

Prazek added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1842 @@ +1841,3 @@ + CGM.getCXXABI().getVTableAddressPoint(vptr.Base, vptr.VTableClass); + if (!VTableGlobal) return; + djasper wrote: > Prazek wrote: > > majnemer wrote: > > > The return shou

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked 9 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D11859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

patch: clarify diagnostic when returned value doesn't match function return type

This simple-minded patch extends the case where we report "no viable conversion from 'X' to 'Y'" to emit a more useful diagnostic "no viable conversion from returned value of type 'X' to function return type 'Y'" when used in that context. In lieu of adding tests for this diagnostic explicitly, I'

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

honggyu.kim added a comment. In http://reviews.llvm.org/D10305#221121, @zaks.anna wrote: > honggyu.kim, > > You are right, CmpRuns.py does not work with HTML files. > > The list of HTML reports is produced by scan-build and there is no facility > there to search for newly generated reports. Th

Re: [Patch][LoopVectorize] Print vectorization analysis when loop hint pragma is specified

Hi Hal, Mark, These patches solve the problem of having to explicitly enable analysis when specifying a loop hint pragma to get the diagnostics. Passing AlwasyPrint as the pass name (see below) causes the front-end to print the diagnostic if the user has specified '-Rpass-analysis' without an '

r244561 - Make the analysis reporting test with x86 to fix the hexagon build.

Author: tnowicki Date: Mon Aug 10 20:54:48 2015 New Revision: 244561 URL: http://llvm.org/viewvc/llvm-project?rev=244561&view=rev Log: Make the analysis reporting test with x86 to fix the hexagon build. Modified: cfe/trunk/test/Frontend/optimization-remark-analysis.c Modified: cfe/trunk/test

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

On Mon, Aug 10, 2015 at 5:43 PM, Reid Kleckner wrote: > On Mon, Aug 10, 2015 at 5:00 PM, Richard Smith > wrote: > >> On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: rnk >>> Date: Mon Aug 10 14:39:01 2015 >>> New Revision: 244

Re: [PATCH] D11778: Improvements on Diagnostic in Macro Expansions

zhengkai added a comment. The example our method doesn't work: https://llvm.org/bugs/show_bug.cgi?id=24424 http://reviews.llvm.org/D11778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D11778: Improvements on Diagnostic in Macro Expansions

rtrieu added a comment. > There are still a lot of other cases in which my method still works as the > old version did. > And I think there are several bugs in the existing functions like > "emitDiagnostic" and "mapDiagnosticRanges". > This is issued as a bug, the link is > https://llvm.or

Re: [PATCH] D11778: Improvements on Diagnostic in Macro Expansions

zhengkai added a comment. The helper function checkRangesForMacroArgExpansion is to check if the current Loc and Ranges are expansions of a macro's arguments. If so, the IgnoredEnd will record this position and thus omitting all later expanded macros (Later expanded macros are showed on top of t

r244556 - Print vectorization analysis when loop hint is specified.

Author: tnowicki Date: Mon Aug 10 20:10:08 2015 New Revision: 244556 URL: http://llvm.org/viewvc/llvm-project?rev=244556&view=rev Log: Print vectorization analysis when loop hint is specified. This patche and a related llvm patch solve the problem of having to explicitly enable analysis when spe

Re: [PATCH] D11700: Added remove taint support to ProgramState.

franchiotta updated this revision to Diff 31756. franchiotta added a comment. Updated refactoring. http://reviews.llvm.org/D11700 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h lib/StaticAnalyzer/Core/ProgramState.cpp Index: lib/StaticAnalyzer/Core/ProgramState.cpp =

Re: [libcxx] r244462 - Protect template argument from user interference.

On Mon, Aug 10, 2015 at 5:26 PM, Marshall Clow wrote: > On Mon, Aug 10, 2015 at 11:12 AM, Hans Wennborg wrote: >> >> On Mon, Aug 10, 2015 at 11:09 AM, Joerg Sonnenberger via cfe-commits >> wrote: >> > On Mon, Aug 10, 2015 at 04:58:04PM -, Joerg Sonnenberger via >> > cfe-commits wrote: >> >>

[libcxx] r244553 - Merging r244462:

Author: hans Date: Mon Aug 10 19:55:30 2015 New Revision: 244553 URL: http://llvm.org/viewvc/llvm-project?rev=244553&view=rev Log: Merging r244462: r244462 | joerg | 2015-08-10 09:58:04 -0700 (Mon, 10 Aug 2015) | 2 lines Pro

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

On Mon, Aug 10, 2015 at 5:00 PM, Richard Smith wrote: > On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rnk >> Date: Mon Aug 10 14:39:01 2015 >> New Revision: 244488 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=244488&view=

r244547 - [modules] Don't suggest deleting the module cache on an error if there is no module cache for this build.

Author: rsmith Date: Mon Aug 10 19:32:42 2015 New Revision: 244547 URL: http://llvm.org/viewvc/llvm-project?rev=244547&view=rev Log: [modules] Don't suggest deleting the module cache on an error if there is no module cache for this build. Modified: cfe/trunk/test/Modules/explicit-build-missi

Re: [libcxx] r244462 - Protect template argument from user interference.

On Mon, Aug 10, 2015 at 11:12 AM, Hans Wennborg wrote: > On Mon, Aug 10, 2015 at 11:09 AM, Joerg Sonnenberger via cfe-commits > wrote: > > On Mon, Aug 10, 2015 at 04:58:04PM -, Joerg Sonnenberger via > cfe-commits wrote: > >> Author: joerg > >> Date: Mon Aug 10 11:58:04 2015 > >> New Revisio

Re: [PATCH] D11922: Add NaCl to long double/fp128 mangling test

chh added a comment. If there were only two different types, we should have mangled name 'd' for double and 'e' for long double, even if their implementations are the same. The problem came when g++ has __float80 and __float128 types, and long double could be implemented as __float80 or __float12

Re: r244526 - Append options for vectorization when pointer checking threshold is exceeded.

Oh, sorry about that! I'll make that change. Tyler On Mon, Aug 10, 2015 at 4:35 PM, Hal Finkel wrote: > - Original Message - > > From: "Tyler Nowicki via cfe-commits" > > To: cfe-commits@lists.llvm.org > > Sent: Monday, August 10, 2015 6:05:17 PM > > Subject: r244526 - Append options f

r244541 - Add NaCl to long double/fp128 mangling test

Author: dschuff Date: Mon Aug 10 19:19:53 2015 New Revision: 244541 URL: http://llvm.org/viewvc/llvm-project?rev=244541&view=rev Log: Add NaCl to long double/fp128 mangling test Summary: NaCl is a platform where long double is the same as double. Its mangling is spelled with "long double" but its

r244542 - add comment

Author: dschuff Date: Mon Aug 10 19:19:54 2015 New Revision: 244542 URL: http://llvm.org/viewvc/llvm-project?rev=244542&view=rev Log: add comment Modified: cfe/trunk/test/CodeGen/long_double_fp128.cpp Modified: cfe/trunk/test/CodeGen/long_double_fp128.cpp URL: http://llvm.org/viewvc/llvm-pr

Re: [PATCH] D11922: Add NaCl to long double/fp128 mangling test

This revision was automatically updated to reflect the committed changes. Closed by commit rL244541: Add NaCl to long double/fp128 mangling test (authored by dschuff). Changed prior to commit: http://reviews.llvm.org/D11922?vs=31744&id=31747#toc Repository: rL LLVM http://reviews.llvm.org/D

Re: [PATCH] D11658: [Sema] main can't be declared as global variable

rsmith added a comment. Maybe you could refactor the check to something like: if (Name.isIdentifier() && Name.getAsIdentifierInfo()->isStr("main") NewVD->getDeclContext()->getRedeclContext()->isTranslationUnit() && !getLangOpts().Freestanding && !NewVD->getDescribedVarTemplate()) {

Re: [PATCH] D11922: Add NaCl to long double/fp128 mangling test

dschuff added a comment. Looks like all the other unix targets that use IEEEDouble as their format do this too, including all the NaCl compilers. http://reviews.llvm.org/D11922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

r244538 - [modules] Properly diagnose errors in module files for which we have no

Author: rsmith Date: Mon Aug 10 19:05:21 2015 New Revision: 244538 URL: http://llvm.org/viewvc/llvm-project?rev=244538&view=rev Log: [modules] Properly diagnose errors in module files for which we have no corresponding include location (those specified on the command line). Modified: cfe/trun

r244537 - Fix some tabs.

Author: rsmith Date: Mon Aug 10 19:03:28 2015 New Revision: 244537 URL: http://llvm.org/viewvc/llvm-project?rev=244537&view=rev Log: Fix some tabs. Modified: cfe/trunk/lib/Frontend/CompilerInstance.cpp Modified: cfe/trunk/lib/Frontend/CompilerInstance.cpp URL: http://llvm.org/viewvc/llvm-pr

Re: [PATCH] Have clang list the imported modules in the debug info

[resending because I accidentally sent this to the old mailing list]. > On Jul 24, 2015, at 12:33 PM, David Blaikie > wrote: > > *reads back through the thread* appreciated, it’s long :-) > So what I originally had in mind about a year ago when we discussed this, was

Re: [Patch][LoopVectorize] Late evaluate of runtime pointer check's threshold

- Original Message - > From: "Tyler Nowicki" > To: "Hal Finkel" > Cc: "Gerolf Hoflehner" , "Commit Messages and Patches > for LLVM" , > "llvm cfe" > Sent: Monday, August 10, 2015 6:06:24 PM > Subject: Re: [Patch][LoopVectorize] Late evaluate of runtime pointer check's > threshold > >

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Mon Aug 10 14:39:01 2015 > New Revision: 244488 > > URL: http://llvm.org/viewvc/llvm-project?rev=244488&view=rev > Log: > [dllimport] A non-imported class with an imported key

Re: [PATCH] D11832: [Patch] [Analyzer] false positive: Potential leak connected with memcpy (PR 22954)

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1098 @@ +1097,3 @@ + if (!NumElements) +return; + QualType ElementTy = AT->getElementType(); What happens on early returns? Here and the one below. Are there tes

Re: r244526 - Append options for vectorization when pointer checking threshold is exceeded.

- Original Message - > From: "Tyler Nowicki via cfe-commits" > To: cfe-commits@lists.llvm.org > Sent: Monday, August 10, 2015 6:05:17 PM > Subject: r244526 - Append options for vectorization when pointer checking > threshold is exceeded. > > Author: tnowicki > Date: Mon Aug 10 18:05:16 2

r244530 - Remove some dead code.

Author: rsmith Date: Mon Aug 10 18:26:54 2015 New Revision: 244530 URL: http://llvm.org/viewvc/llvm-project?rev=244530&view=rev Log: Remove some dead code. Modified: cfe/trunk/include/clang/Serialization/ASTReader.h cfe/trunk/lib/Serialization/ASTReader.cpp Modified: cfe/trunk/include/cl

Re: [PATCH] D11922: Add NaCl to long double/fp128 mangling test

rnk added a comment. In http://reviews.llvm.org/D11922#221185, @dschuff wrote: > I'm not an expert in mangling, and I'm not 100% sure if this is right. The > Itanium ABI's spec lists "long double" as the same as __float80. Should we > use "double" in mangling instead? If you can have differen

Re: [PATCH] D11922: Add NaCl to long double/fp128 mangling test

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Feel free to commit more test coverage like this with just post-commit review. http://reviews.llvm.org/D11922 ___ cfe-commits mailing list cfe-co

Re: [PATCH] D11922: Add NaCl to long double/fp128 mangling test

dschuff added a comment. I'm not an expert in mangling, and I'm not 100% sure if this is right. The Itanium ABI's spec lists "long double" as the same as __float80. Should we use "double" in mangling instead? http://reviews.llvm.org/D11922 ___ cfe

[PATCH] D11922: Add NaCl to long double/fp128 mangling test

dschuff created this revision. dschuff added reviewers: rnk, chh. dschuff added a subscriber: cfe-commits. Herald added subscribers: dschuff, jfb. NaCl is a platform where long double is the same as double. Its mangling is spelled with "long double" but its ABI lowering is the same as double. htt

Re: [PATCH] D11781: Refactored pthread usage in libcxx

espositofulvio added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ jroelofs wrote: > espositofulvio wrote: > > jroelofs wrote: > > > jroelofs wrote: > >

Re: [Patch][LoopVectorize] Late evaluate of runtime pointer check's threshold

Hi Hal, Thanks, the patches are committed in r244523 and r244526. There are two possibilities to give the user control over pointer checking. We could add a loop hint option like vectorize(check_safety) that would be a safe version of ‘assume_safety’ or we could simply make it always emit the n

r244526 - Append options for vectorization when pointer checking threshold is exceeded.

Author: tnowicki Date: Mon Aug 10 18:05:16 2015 New Revision: 244526 URL: http://llvm.org/viewvc/llvm-project?rev=244526&view=rev Log: Append options for vectorization when pointer checking threshold is exceeded. Following one of the appended options will allow the loop to be vectorized. We do n

Re: [PATCH] D11921: Add NaCl (a target where long double = double) to long double ABI test

dschuff added a comment. In http://reviews.llvm.org/D11921#221172, @chh wrote: > Please rebase the change to r244502 or newer, to run with -Asserts builds. Did that; Not sure it's reflected on Phabricator, but I did check the diff. Thanks! Repository: rL LLVM http://reviews.llvm.org/D11921

Re: [PATCH] D11921: Add NaCl (a target where long double = double) to long double ABI test

chh added a comment. Please rebase the change to r244502 or newer, to run with -Asserts builds. Thanks. Repository: rL LLVM http://reviews.llvm.org/D11921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: [PATCH] D11921: Add NaCl (a target where long double = double) to long double ABI test

This revision was automatically updated to reflect the committed changes. Closed by commit rL244524: Add NaCl (a target where long double = double) to long double ABI test (authored by dschuff). Changed prior to commit: http://reviews.llvm.org/D11921?vs=31741&id=31743#toc Repository: rL LLVM

r244524 - Add NaCl (a target where long double = double) to long double ABI test

Author: dschuff Date: Mon Aug 10 18:02:37 2015 New Revision: 244524 URL: http://llvm.org/viewvc/llvm-project?rev=244524&view=rev Log: Add NaCl (a target where long double = double) to long double ABI test A test was recently (r244468) added to cover long double calling convention codegen, disting

Re: [PATCH] D11921: Add NaCl (a target where long double = double) to long double ABI test

dschuff updated this revision to Diff 31741. dschuff added a comment. Herald added a subscriber: dschuff. - rename to x86_64-longdouble.c http://reviews.llvm.org/D11921 Files: test/CodeGen/x86_64-fp128.c test/CodeGen/x86_64-longdouble.c Index: test/CodeGen/x86_64-longdouble.c =

Re: [PATCH] D11921: Add NaCl (a target where long double = double) to long double ABI test

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm In http://reviews.llvm.org/D11921#221136, @dschuff wrote: > Should this test be renamed to x86_longdouble.c or some such instead of fp128? Yeah, x86_64-longdouble.c is probably better. http

Re: [PATCH] D11921: Add NaCl (a target where long double = double) to long double ABI test

dschuff added a comment. Should this test be renamed to x86_longdouble.c or some such instead of fp128? http://reviews.llvm.org/D11921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D11921: Add NaCl (a target where long double = double) to long double ABI test

dschuff created this revision. dschuff added reviewers: rnk, chh, majnemer, echristo. dschuff added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer, jfb. A test was recently (r244468) added to cover long double calling convention codegen, distinguishing between

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

zaks.anna added a comment. honggyu.kim, You are right, CmpRuns.py does not work with HTML files. The list of HTML reports is produced by scan-build and there is no facility there to search for newly generated reports. It is also not clear that there should be one HTML file per report. This is

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

zaks.anna added a comment. We need a way to test this functionality. One way of testing this would be to write unit tests. Gabor has already added such tests for the static analyzer. http://reviews.llvm.org/D10305 ___ cfe-commits mailing list cfe-c

Re: [PATCH] D11781: Refactored pthread usage in libcxx

jroelofs added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ espositofulvio wrote: > jroelofs wrote: > > jroelofs wrote: > > > @espositofulvio: @ed meant

r244517 - Make frontend floating-point commutivity test X86 specific to avoid cost-model related problems on arm-thumb and hexagon.

Author: tnowicki Date: Mon Aug 10 17:17:40 2015 New Revision: 244517 URL: http://llvm.org/viewvc/llvm-project?rev=244517&view=rev Log: Make frontend floating-point commutivity test X86 specific to avoid cost-model related problems on arm-thumb and hexagon. Modified: cfe/trunk/test/Frontend/o

Re: [PATCH] D11781: Refactored pthread usage in libcxx

espositofulvio added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ jroelofs wrote: > jroelofs wrote: > > @espositofulvio: @ed meant this: > > > > ``` >

r244515 - If a variable template is inside a context with template arguments that is being instantiated, and that instantiation fails, fail our instantiation instead of crashing. Errors have already b

Author: nicholas Date: Mon Aug 10 16:54:08 2015 New Revision: 244515 URL: http://llvm.org/viewvc/llvm-project?rev=244515&view=rev Log: If a variable template is inside a context with template arguments that is being instantiated, and that instantiation fails, fail our instantiation instead of cr

Re: [PATCH] D11859: Generating vptr assume loads

djasper added a subscriber: djasper. Comment at: lib/CodeGen/CGClass.cpp:1842 @@ +1841,3 @@ + CGM.getCXXABI().getVTableAddressPoint(vptr.Base, vptr.VTableClass); + if (!VTableGlobal) return; + Prazek wrote: > majnemer wrote: > > The return should be on it's

Re: r244492 - Append options for floating-point commutivity when related diagnostics are produced.

Thanks Aaron! Fixed in r244506. Tyler On Mon, Aug 10, 2015 at 12:58 PM, Aaron Ballman wrote: > On Mon, Aug 10, 2015 at 3:56 PM, Tyler Nowicki via cfe-commits > wrote: > > Author: tnowicki > > Date: Mon Aug 10 14:56:40 2015 > > New Revision: 244492 > > > > URL: http://llvm.org/viewvc/llvm-proj

r244506 - Remove non-ascii characters.

Author: tnowicki Date: Mon Aug 10 16:18:01 2015 New Revision: 244506 URL: http://llvm.org/viewvc/llvm-project?rev=244506&view=rev Log: Remove non-ascii characters. Modified: cfe/trunk/include/clang/Basic/DiagnosticFrontendKinds.td cfe/trunk/test/Frontend/optimization-remark-options.c Mod

Re: [Patch][LoopVectorize]Late evaluation of vectorization requirements

Thanks! Committed in clang r244492, llvm r244489/r244505/r244494. Tyler > On Aug 9, 2015, at 9:33 PM, Hal Finkel wrote: > > Hi Tyler, > > These LGTM, thanks! > > -Hal > > - Original Message - >> From: "Tyler Nowicki" >> To: "Hal J. Finkel" , "Gerolf Hoflehner" >> >> Cc: "Commit M

Re: r244468 - Correct x86_64 fp128 calling convention

I submitted a new patch into r244502. Please let me know if there is any other error. Thanks. On Mon, Aug 10, 2015 at 12:46 PM, David Blaikie wrote: > > > On Mon, Aug 10, 2015 at 10:33 AM, Chih-Hung Hsieh via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: chh >> Date: Mon Aug 1

r244502 - Fix test case to work with -Asserts builds.

Author: chh Date: Mon Aug 10 15:58:54 2015 New Revision: 244502 URL: http://llvm.org/viewvc/llvm-project?rev=244502&view=rev Log: Fix test case to work with -Asserts builds. When clang is built with -DLLVM_ENABLE_ASSERTIONS=Off, it does not create names for IR values. Differential Revision: http

Re: [PATCH] D11666: [CUDA] Make sure we emit all templated __global__ functions on device side.

This revision was automatically updated to reflect the committed changes. Closed by commit rL244501: [CUDA] Add implicit __attribute__((used)) to all __global__ functions. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D11666?vs=31128&id=31718#toc Repository: rL LLVM ht

r244501 - [CUDA] Add implicit __attribute__((used)) to all __global__ functions.

Author: tra Date: Mon Aug 10 15:57:02 2015 New Revision: 244501 URL: http://llvm.org/viewvc/llvm-project?rev=244501&view=rev Log: [CUDA] Add implicit __attribute__((used)) to all __global__ functions. This allows emitting kernels that were instantiated from the host code and which would never be

Re: [PATCH] D11781: Refactored pthread usage in libcxx

jroelofs added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ jroelofs wrote: > @espositofulvio: @ed meant this: > > ``` > #ifndef _WIN32 > # include >

Re: [PATCH] D11781: Refactored pthread usage in libcxx

jroelofs added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ @espositofulvio: @ed meant this: ``` #ifndef _WIN32 # include # if _POSIX_THREADS > 0 ..

Re: [PATCH] D11781: Refactored pthread usage in libcxx

espositofulvio marked 5 inline comments as done. espositofulvio added a comment. Repository: rL LLVM http://reviews.llvm.org/D11781 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11781: Refactored pthread usage in libcxx

espositofulvio updated this revision to Diff 31716. espositofulvio added a comment. Added __CloudABI__ to the list of platform using pthread Repository: rL LLVM http://reviews.llvm.org/D11781 Files: include/__config include/__mutex_base include/mutex include/support/condition_variabl

r244497 - [CUDA] Added stubs for new attributes used by CUDA headers.

Author: tra Date: Mon Aug 10 15:33:56 2015 New Revision: 244497 URL: http://llvm.org/viewvc/llvm-project?rev=244497&view=rev Log: [CUDA] Added stubs for new attributes used by CUDA headers. The main purpose is to avoid errors and warnings while parsing CUDA header files. The attributes are curren

Re: [PATCH] D11781: Refactored pthread usage in libcxx

espositofulvio added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__linux__) || defined(__APPLE__) +# define _LIBCPP_THREAD_API _LIBCPP_PTHREAD ed wrot

Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

samsonov added a comment. Driver changes look good. http://reviews.llvm.org/D11857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11690: [CUDA] Added stubs for new attributes used by CUDA headers.

tra added a comment. LGTM'ed by Aaron Ballman via email that didn't make it to Phabricator. http://reviews.llvm.org/D11690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r244492 - Append options for floating-point commutivity when related diagnostics are produced.

On Mon, Aug 10, 2015 at 3:56 PM, Tyler Nowicki via cfe-commits wrote: > Author: tnowicki > Date: Mon Aug 10 14:56:40 2015 > New Revision: 244492 > > URL: http://llvm.org/viewvc/llvm-project?rev=244492&view=rev > Log: > Append options for floating-point commutivity when related diagnostics are > p

r244492 - Append options for floating-point commutivity when related diagnostics are produced.

Author: tnowicki Date: Mon Aug 10 14:56:40 2015 New Revision: 244492 URL: http://llvm.org/viewvc/llvm-project?rev=244492&view=rev Log: Append options for floating-point commutivity when related diagnostics are produced. With this patch clang appends the command line options that would allow vec

r244490 - Fix typo.

Author: nicholas Date: Mon Aug 10 14:54:11 2015 New Revision: 244490 URL: http://llvm.org/viewvc/llvm-project?rev=244490&view=rev Log: Fix typo. Modified: cfe/trunk/docs/LanguageExtensions.rst Modified: cfe/trunk/docs/LanguageExtensions.rst URL: http://llvm.org/viewvc/llvm-project/cfe/trunk

Re: r244468 - Correct x86_64 fp128 calling convention

On Mon, Aug 10, 2015 at 10:33 AM, Chih-Hung Hsieh via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chh > Date: Mon Aug 10 12:33:31 2015 > New Revision: 244468 > > URL: http://llvm.org/viewvc/llvm-project?rev=244468&view=rev > Log: > Correct x86_64 fp128 calling convention > > These c

Re: r243851 - Fix invalid shufflevector operands

On Fri, Aug 7, 2015 at 11:57 AM, Simon Pilgrim wrote: > On 06/08/2015 18:05, Hans Wennborg wrote: >> >> On Sun, Aug 2, 2015 at 8:28 AM, Simon Pilgrim >> wrote: >>> >>> Author: rksimon >>> Date: Sun Aug 2 10:28:10 2015 >>> New Revision: 243851 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=

r244488 - [dllimport] A non-imported class with an imported key can't have a key

Author: rnk Date: Mon Aug 10 14:39:01 2015 New Revision: 244488 URL: http://llvm.org/viewvc/llvm-project?rev=244488&view=rev Log: [dllimport] A non-imported class with an imported key can't have a key Summary: The vtable takes its DLL storage class from the class, not the key function. When they

Re: [PATCH] D11913: [dllimport] A non-imported class with an imported key can't have a key

This revision was automatically updated to reflect the committed changes. Closed by commit rL244488: [dllimport] A non-imported class with an imported key can't have a key (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D11913?vs=31697&id=31710#toc Repository: rL LLVM ht

Re: [PATCH] D11859: Generating vptr assume loads

rsmith added inline comments. Comment at: lib/CodeGen/CGClass.cpp:2098 @@ -2063,3 +2097,3 @@ // Initialize the vtable pointer for this base. -InitializeVTablePointer(Base, NearestVBase, OffsetFromNearestVBase, -VTableClass); +VPtr vptr{Base

Re: [PATCH] D11859: Generating vptr assume loads

rsmith added inline comments. Comment at: include/clang/AST/VTableBuilder.h:387-391 @@ -386,7 +386,3 @@ - // Copy constructor. - // FIXME: Uncomment when we've moved to C++11. - // VPtrInfo(const VPtrInfo &) = default; - /// The vtable will hold all of the virtual bases or

Re: [PATCH] D11859: Generating vptr assume loads

Prazek added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1842 @@ +1841,3 @@ + CGM.getCXXABI().getVTableAddressPoint(vptr.Base, vptr.VTableClass); + if (!VTableGlobal) return; + majnemer wrote: > The return should be on it's own line, please clang-fo

Re: [PATCH] D11658: [Sema] main can't be declared as global variable

On Thu, Jul 30, 2015 at 07:01:22PM +, Davide Italiano wrote: > Index: test/CXX/basic/basic.start/basic.start.main/p3.cpp > === > --- test/CXX/basic/basic.start/basic.start.main/p3.cpp > +++ test/CXX/basic/basic.start/basic.start.ma

Re: [PATCH] D11859: Generating vptr assume loads

majnemer added a comment. Some first round review comments. Comment at: lib/CodeGen/CGClass.cpp:1831-1832 @@ +1830,4 @@ + + // generate vtable assumptions if we are not in another ctor and + // if we calling dynamic class ctor + if (CGM.getCodeGenOpts().OptimizationLevel > 0

Re: [PATCH] D10365: Add cmd to compilation database file format

diltsman added a subscriber: diltsman. diltsman added a comment. I'm trying to upload a new patch and I get an error from Phabricator: 'Unhandled Exception ("Exception")'. Any ideas how to get this to work? I have attached the diff file. - F722854: Arguments.patch

[PATCH] D11916: [CONCEPTS] Add diagnostic; invalid tag when concept specified

nwilson created this revision. nwilson added reviewers: rsmith, hubert.reinterpretcast, fraggamuffin, faisalv, aaron.ballman. nwilson added a subscriber: cfe-commits. Adding check to emit diagnostic for invalid tag when concept is specified and associated tests. http://reviews.llvm.org/D11916

Re: [PATCH] D11913: [dllimport] A non-imported class with an imported key can't have a key

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D11913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D11913: [dllimport] A non-imported class with an imported key can't have a key

rnk created this revision. rnk added reviewers: majnemer, hans. rnk added a subscriber: cfe-commits. The vtable takes its DLL storage class from the class, not the key function. When they disagree, the vtable won't be exported by the DLL that defines the key function. The easiest way to ensure tha

Re: [libcxx] r244462 - Protect template argument from user interference.

This is my mistake and I would like to see it merged. On Aug 10, 2015 2:13 PM, "Hans Wennborg via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > On Mon, Aug 10, 2015 at 11:09 AM, Joerg Sonnenberger via cfe-commits > wrote: > > On Mon, Aug 10, 2015 at 04:58:04PM -, Joerg Sonnenberger via

  1   2   >