This issue is surfacing regulary. In cases where clang prints the escaped
path we have to use {{/} which is not very readable, for example in
mingw driver case:
// CHECK_MINGW_ORG_TREE:
"{{.*}}/Inputs/mingw_mingw_org_tree/mingw{{/|}}lib{{/|}}gcc{{/|}}mingw32{{/|}}4.8.1{{/|}
Hi Tyler,
Thanks for working on this!
+// If a loop hint is provided the diagnostic is always produced.
+const char *name = Hints.isForced() ? DiagnosticInfo::AlwaysPrint :
LV_NAME;
name -> Name
These LGTM.
P.S. I assume we should add similar logic to the loop unroller (please add a
Hi Tyler,
This looks very useful.
Please don't mention '-mllvm -runtime-memory-check-threshold=' in the error
message. We should add some clause to #pragma clang loop to control this
feature with some associated metadata. '-mllvm' things should not be part of
the advertised interface to end us
Hi Tyler,
These LGTM, thanks!
-Hal
- Original Message -
> From: "Tyler Nowicki"
> To: "Hal J. Finkel" , "Gerolf Hoflehner"
>
> Cc: "Commit Messages and Patches for LLVM" ,
> "llvm cfe"
> Sent: Thursday, August 6, 2015 3:12:29 PM
> Subject: Re: [Patch][LoopVectorize]Late evaluation
modocache accepted this revision.
modocache added a reviewer: modocache.
modocache added a comment.
This revision is now accepted and ready to land.
Looks good to me! I don't have commit access, though, so you'll probably have
to find a committer to review/commit for you, @skalinichev.
http://r
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM, but obviously any necessary CodeGen changes must be done first (or at the
same time).
http://reviews.llvm.org/D11738
___
cfe-commits mai
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244428: [MSVC] Crash fix: assigning of overloaded member
function pointer caused… (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D11828?vs=31631&id=31632#toc
Repository:
rL L
Author: abataev
Date: Sun Aug 9 23:07:49 2015
New Revision: 244428
URL: http://llvm.org/viewvc/llvm-project?rev=244428&view=rev
Log:
[MSVC] Crash fix: assigning of overloaded member function pointer caused
assertion
Original class was not marked with inheritance attribute and it causes a crash
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D11828
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
ABataev updated the summary for this revision.
ABataev updated this revision to Diff 31631.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D11828
Files:
lib/Sema/SemaCast.cpp
test/CodeGenCXX/microsoft-abi-member-pointers.cpp
Index: lib/Sema/SemaCast.cpp
==
Hi Anton,
Since D10356 is committed first, your patch(D6551) has to be modified based on
it.
So I just did some modification to resolve a conflict.
I was trying to upload the patch in phabricator, but I don't have a permission
to update your patch.
I just attached the modified version so that y
On Aug 9, 2015 3:56 PM, "NAKAMURA Takumi via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> Author: chapuni
> Date: Sun Aug 9 17:55:50 2015
> New Revision: 244427
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244427&view=rev
> Log:
> clang/test/Modules: Satisfy win32 hosts due to dospath
majnemer added a comment.
I think it would be inconsistent with the other platforms which have this
version information. The platforms which have an environment version stick it
in the triple (Android, MSVC) and the platforms which have an OS version also
stick it in the triple (Darwin, iOS, O
compnerd added a comment.
Yes, we *could*. Its just a matter of how it is being specified. I find that
having the separate option is potentially cleaner than stuffing it in the
triple (which does get pushed into the metadata), and then parsing it back out
as a value. I think that this is som
majnemer added a comment.
We already support a version for the environment in the triple, can we just use
that?
Repository:
rL LLVM
http://reviews.llvm.org/D7642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Author: chapuni
Date: Sun Aug 9 17:55:50 2015
New Revision: 244427
URL: http://llvm.org/viewvc/llvm-project?rev=244427&view=rev
Log:
clang/test/Modules: Satisfy win32 hosts due to dospath issue.
Modified:
cfe/trunk/test/Modules/dependency-gen.modulemap
cfe/trunk/test/Modules/explicit-bui
compnerd added a comment.
-gnu implies GLIBC. Traditionally, -uclibc is used instead of -gnu for uclibc
environments, and many (most?) Linux distros use -musl to indicate a MUSL
environment. For Android, the environment is -android, and thus, assumed to be
bionic. If the OS is BSD, usually,
Author: rsmith
Date: Sun Aug 9 03:48:41 2015
New Revision: 244416
URL: http://llvm.org/viewvc/llvm-project?rev=244416&view=rev
Log:
[modules] PR22534: Load files specified by -fmodule-file= eagerly. In
particular, this avoids the need to re-parse module map files when using such a
module.
Adde
18 matches
Mail list logo
