Re: [PATCH] D11459: [Driver] Fix handling of -fbuiltin/-fcommon when combined with -mkernel

(resending with the list address fixed) John Brawn writes: > john.brawn created this revision. > john.brawn added reviewers: ddunbar, mcrosier. > john.brawn added a subscriber: cfe-commits. > john.brawn set the repository for this revision to rL LLVM. > > -mkernel enables -fno-builtin and -fno-co

Re: [PATCH] D10356: scan-build: Add --analyzer-target option

honggyu.kim added a comment. In http://reviews.llvm.org/D10356#219499, @krememek wrote: > I see. The problem is that the ad hoc interposition that scan-build uses > does not handle the case that the underlying compiler is built as a > cross-compiler, but does not take a direct target triple.

Re: r244389 - [analyzer] Add checkers for OS X / iOS localizability issues

NP, thanks for the quick fixes! On Fri, Aug 7, 2015 at 9:56 PM Anna Zaks wrote: > Sorry about the breakage! I’ve reverted the commit in r244394. > > Anna. > > On Aug 7, 2015, at 9:08 PM, Chandler Carruth wrote: > > Note that this is still failing on bots even after the windows fix: > > http://l

Re: r244389 - [analyzer] Add checkers for OS X / iOS localizability issues

Sorry about the breakage! I’ve reverted the commit in r244394. Anna. > On Aug 7, 2015, at 9:08 PM, Chandler Carruth wrote: > > Note that this is still failing on bots even after the windows fix: > > http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/24169 >

r244394 - Revert "[analyzer] Add checkers for OS X / iOS localizability issues"

Author: zaks Date: Fri Aug 7 23:53:04 2015 New Revision: 244394 URL: http://llvm.org/viewvc/llvm-project?rev=244394&view=rev Log: Revert "[analyzer] Add checkers for OS X / iOS localizability issues" This reverts commit fc885033a30b6e30ccf82398ae7c30e646727b10. Revert all localization checker c

Re: r244389 - [analyzer] Add checkers for OS X / iOS localizability issues

Note that this is still failing on bots even after the windows fix: http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/24169 On Fri, Aug 7, 2015 at 6:50 PM Anna Zaks via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: zaks > Date: Fri Aug 7 20:49:26 2015 > New Revisi

Re: [PATCH] D10225: [Static Analyzer] Remove ObjCContainersChecker size information when a CFMutableArrayRef escapes

dcoughlin added a comment. This was committed in r239709. http://reviews.llvm.org/D10225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D11859: Generating vptr assume loads

Prazek created this revision. Prazek added reviewers: rsmith, majnemer. Prazek added a subscriber: cfe-commits. Generating vptr assumption loads for better devirtualization. More here: http://lists.llvm.org/pipermail/cfe-dev/2015-July/044227.html http://reviews.llvm.org/D11859 Files: include/

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

zaks.anna added a comment. Committed in r244389. Thank you! http://reviews.llvm.org/D11572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r244386 - [analyzer] Don't issue alarm in ObjCSuperCallChecker for the super class itself.

Author: dcoughlin Date: Fri Aug 7 20:31:51 2015 New Revision: 244386 URL: http://llvm.org/viewvc/llvm-project?rev=244386&view=rev Log: [analyzer] Don't issue alarm in ObjCSuperCallChecker for the super class itself. The ObjCSuperCallChecker issues alarms for various Objective-C APIs that require

Re: [PATCH] D11850: Delay emitting members of dllexport classes until the class is fully parsed (PR23542)

hans updated this revision to Diff 31564. hans added a comment. Turns out ActOnFinishCXXMemberDefaultArgs needs to be re-entrant. http://reviews.llvm.org/D11850 Files: include/clang/Sema/Sema.h lib/Sema/Sema.cpp lib/Sema/SemaDeclCXX.cpp test/CodeGenCXX/dllexport.cpp Index: test/CodeGen

Re: [PATCH] D11797: [libclang] Expose the ElaboratedType

modocache added a subscriber: modocache. Comment at: bindings/python/clang/cindex.py:1875 @@ -1873,1 +1874,3 @@ +def getElabaratedTypeUnderlyingType(self): +""" Awesome, thanks for updating the Python bindings as well! As with the C function, I beli

Re: [PATCH] D11848: AST: Implement mangling support for function types without a prototype.

This revision was automatically updated to reflect the committed changes. Closed by commit rL244374: AST: Implement mangling support for function types without a prototype. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D11848?vs=31546&id=31557#toc Repository: rL LLVM h

Re: [PATCH] D11848: AST: Implement mangling support for function types without a prototype.

rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D11848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D2916: [libclang][python] Add test for Index read

modocache added a reviewer: ddunbar. modocache added a subscriber: ddunbar. modocache added a comment. Adding @ddunbar, who added the original FIXME, as a reviewer. http://reviews.llvm.org/D2916 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

r244370 - [Sparc] XFAIL CodeGen/atomic_ops test.

Author: jyknight Date: Fri Aug 7 17:52:34 2015 New Revision: 244370 URL: http://llvm.org/viewvc/llvm-project?rev=244370&view=rev Log: [Sparc] XFAIL CodeGen/atomic_ops test. Modified: cfe/trunk/test/CodeGen/atomic_ops.c Modified: cfe/trunk/test/CodeGen/atomic_ops.c URL: http://llvm.org/view

[PATCH] D11850: Delay emitting members of dllexport classes until the class is fully parsed (PR23542)

hans created this revision. hans added a reviewer: rsmith. hans added subscribers: cfe-commits, hansw. This enables Clang to correctly handle code such as: ``` struct __declspec(dllexport) S { int x = 42; }; ``` where it would otherwise assert due to trying to generate the default constructor

Re: [PATCH] D11693: clang-format: Support generalized lambda captures.

strager added a comment. ping http://reviews.llvm.org/D11693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

strager added a comment. (Sorry for the late feedback.) Comment at: docs/ClangFormatStyleOptions.rst:221 @@ -220,2 +220,3 @@ -**AlwaysBreakAfterDefinitionReturnType** (``DefinitionReturnTypeBreakingStyle``) +**AlwaysBreakAfterDeclarationReturnType** (``ReturnTypeBreakingStyle

Re: [PATCH] D10356: scan-build: Add --analyzer-target option

krememek added a comment. In http://reviews.llvm.org/D10356#217564, @honggyu.kim wrote: > > With --analyzer-target option, we can provide target info to clang static > analyzer as follows: > > $ scan-build -v -v -v --analyzer-target=arm-linux-gnueabi > --use-cc=arm-linux-gnueabi-gcc make

Re: [PATCH] D11848: AST: Implement mangling support for function types without a prototype.

pcc updated this revision to Diff 31546. pcc added a comment. - Use a mangling distinct from (...) as suggested by Richard http://reviews.llvm.org/D11848 Files: lib/AST/ItaniumMangle.cpp lib/AST/MicrosoftMangle.cpp test/CodeGen/mangle-ms.c test/CodeGen/overloadable.c Index: test/CodeGe

Re: [PATCH] D11848: AST: Implement mangling support for function types without a prototype.

rsmith added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:2060-2062 @@ -2058,2 +2059,5 @@ void CXXNameMangler::mangleType(const FunctionNoProtoType *T) { - llvm_unreachable("Can't mangle K&R function prototypes"); + // Function types without prototypes can arise when

Re: [PATCH] clang-format: Add "AllowShortNamespacesOnASingleLine" option

Would it be possible to send the patch through reviews.llvm.org? It makes review much easier for me. On Thu, Aug 6, 2015 at 6:18 PM, chris beck via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Rationale: > > I sometimes use a different clang tool, iwyu ("include what you use"), to > clean u

Re: [PATCH] D11848: AST: Implement mangling support for function types without a prototype.

pcc added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:2060-2062 @@ -2058,2 +2059,5 @@ void CXXNameMangler::mangleType(const FunctionNoProtoType *T) { - llvm_unreachable("Can't mangle K&R function prototypes"); + // Function types without prototypes can arise when man

Re: [PATCH] D11848: AST: Implement mangling support for function types without a prototype.

rsmith added a subscriber: rsmith. Comment at: lib/AST/ItaniumMangle.cpp:2060-2062 @@ -2058,2 +2059,5 @@ void CXXNameMangler::mangleType(const FunctionNoProtoType *T) { - llvm_unreachable("Can't mangle K&R function prototypes"); + // Function types without prototypes can arise

[Patch][LoopVectorize] Print vectorization analysis when loop hint pragma is specified

Hi,Currently, when loop hint is used but vectorization fails we generate a warning. To get the analysis the user needs to provide the command line option -Rpass-analysis= with the correct pass name. BUT we don’t tell the user which pass name they will need to get the analysis message. We should be

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

rsmith added a subscriber: rsmith. rsmith added a comment. This doesn't recover from the errors properly any more (leaving junk behind in the 'current module' stack), and somewhat breaks the original purpose of these checks, which is to detect and diagnose missing close braces. Here's what I su

[PATCH] D11845: Properly pass through the PIC mode to the integrated assembler when doing assembly-only, and unify the Driver's PIC argument parsing.

jyknight created this revision. jyknight added reviewers: rnk, echristo. jyknight added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer. On a few architectures, parsing of assembly files annoyingly depends on whether PIC is enabled or not. This was handled for

[PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

sepavloff created this revision. sepavloff added a subscriber: cfe-commits. If an import directive was put into wrong context, the error message was obscure, complaining on misbalanced braces. To get more descriptive messages, annotation tokens related to modules are processed where they must not

Re: r243851 - Fix invalid shufflevector operands

On 06/08/2015 18:05, Hans Wennborg wrote: On Sun, Aug 2, 2015 at 8:28 AM, Simon Pilgrim wrote: Author: rksimon Date: Sun Aug 2 10:28:10 2015 New Revision: 243851 URL: http://llvm.org/viewvc/llvm-project?rev=243851&view=rev Log: Fix invalid shufflevector operands This patch fixes bug 23800 (

Re: [PATCH] D11842: [analyzer]Don't issue alarm in ObjCSuperCallChecker for the super class itself.

jordan_rose accepted this revision. jordan_rose added a comment. This revision is now accepted and ready to land. Thanks for fixing this. http://reviews.llvm.org/D11842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D11842: [analyzer]Don't issue alarm in ObjCSuperCallChecker for the super class itself.

dcoughlin created this revision. dcoughlin added reviewers: zaks.anna, jordan_rose, xazax.hun. dcoughlin added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. The ObjCSuperCallChecker issues alarms for various Objective-C APIs that require a subclass to call to its supercl

r244342 - Move the cpu validating virtual method down to the feature routines

Author: echristo Date: Fri Aug 7 13:31:25 2015 New Revision: 244342 URL: http://llvm.org/viewvc/llvm-project?rev=244342&view=rev Log: Move the cpu validating virtual method down to the feature routines where it belongs. Modified: cfe/trunk/include/clang/Basic/TargetInfo.h Modified: cfe/trun

Re: [PATCH] D11781: Refactored pthread usage in libcxx

espositofulvio added inline comments. Comment at: include/__mutex_base:246 @@ -266,3 +245,3 @@ -class _LIBCPP_TYPE_VIS condition_variable +class _LIBCPP_TYPE_VIS condition_variable : private __libcxx_support::condition_variable { theraven wrote: > espositofulv

Re: [PATCH] D11797: [libclang] Expose the ElaboratedType

skalinichev updated this revision to Diff 31503. skalinichev added a comment. Fixed minor formatting issues. http://reviews.llvm.org/D11797 Files: bindings/python/clang/cindex.py include/clang-c/Index.h test/Index/print-type.c test/Index/print-type.cpp tools/libclang/CXType.cpp tool

Re: r244286 - Continue the work from r243908 by adding a Features field to Builtin::Info

Ah, but not in the autoconf build. *sigh* We only check and added -Wno-missing-field-initializers. I've attempted to fix this in r244330. -eric On Thu, Aug 6, 2015 at 10:44 PM Craig Topper wrote: > I think it is on by default for clang builds > > # Turn off missing field initializer warnin

[clang-tools-extra] r244329 - Silence gcc 5.1 unused variable warnings using LLVM_ATTRIBUTE_UNUSED.

Author: yrnkrn Date: Fri Aug 7 11:37:34 2015 New Revision: 244329 URL: http://llvm.org/viewvc/llvm-project?rev=244329&view=rev Log: Silence gcc 5.1 unused variable warnings using LLVM_ATTRIBUTE_UNUSED. Modified: clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp Modified: clang-tool

Re: [PATCH] D11469: [OPENMP] Parsing and sema support for device clause

fraggamuffin added a comment. This has landed. Commit C:\llvmtrunk\tools\clang\include\clang\AST\DataRecursiveASTVisitor.h C:\llvmtrunk\tools\clang\include\clang\AST\OpenMPClause.h C:\llvmtrunk\tools\clang\include\clang\AST\RecursiveASTVisitor.h C:\llvmtrunk\tools\clang\include\clang\Basic\OpenMPK

Re: r244312 - Silence tools/clang/lib/Tooling/CompilationDatabase.cpp:328:12: warning:

On Fri, Aug 7, 2015 at 3:15 AM, Yaron Keren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: yrnkrn > Date: Fri Aug 7 05:15:15 2015 > New Revision: 244312 > > URL: http://llvm.org/viewvc/llvm-project?rev=244312&view=rev > Log: > Silence tools/clang/lib/Tooling/CompilationDatabase.cp

[PATCH] D11837: Add Qt brace style configuration option.

lifted created this revision. lifted added a reviewer: djasper. lifted added subscribers: cfe-commits, klimek. Add Qt brace style as described on https://wiki.qt.io/Qt_Coding_Style : * Use attached braces: the opening brace goes on the same line as the start of the statement. If the closing br

[PATCH] D11834: s/NDEBUG/LLVM_NDEBUG/ in most places to match the same LLVM change.

tstellarAMD created this revision. tstellarAMD added reviewers: echristo, chandlerc, beanz. tstellarAMD added a subscriber: cfe-commits. Herald added a subscriber: klimek. http://reviews.llvm.org/D11834 Files: lib/ARCMigrate/TransProperties.cpp lib/AST/ASTContext.cpp lib/AST/CommentLexer.cp

[PATCH] D11832: [Patch] [Analyzer] false positive: Potential leak connected with memcpy (PR 22954)

pgousseau created this revision. pgousseau added reviewers: cfe-commits, ayartsev, xazax.hun. Dear All, I would like to propose a patch to avoid the false positive memory leak warning kindly reported by krzysztof in https://llvm.org/bugs/show_bug.cgi?id=22954 The issue seems originates from the

Re: [PATCH] D6551: Improvements to scan-build.

sylvestre.ledru added a comment. (if you commit it, please update the description, "Improvements to scan-build" is too general http://reviews.llvm.org/D6551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

r244312 - Silence tools/clang/lib/Tooling/CompilationDatabase.cpp:328:12: warning:

Author: yrnkrn Date: Fri Aug 7 05:15:15 2015 New Revision: 244312 URL: http://llvm.org/viewvc/llvm-project?rev=244312&view=rev Log: Silence tools/clang/lib/Tooling/CompilationDatabase.cpp:328:12: warning: ‘clang::tooling::JSONAnchorDest’ defined but not used [-Wunused-variable] from gcc 5.1. Mo

Re: [PATCH] D11781: Refactored pthread usage in libcxx

theraven added inline comments. Comment at: include/__mutex_base:246 @@ -266,3 +245,3 @@ -class _LIBCPP_TYPE_VIS condition_variable +class _LIBCPP_TYPE_VIS condition_variable : private __libcxx_support::condition_variable { espositofulvio wrote: > theraven wro

[libclc] r244310 - Require LLVM >=3.7 and bump version to 0.2.0

Author: jketema Date: Fri Aug 7 03:31:37 2015 New Revision: 244310 URL: http://llvm.org/viewvc/llvm-project?rev=244310&view=rev Log: Require LLVM >=3.7 and bump version to 0.2.0 v2: Also remove LLVM 3.6 traces from prepare-builtins.cpp Patch by: EdB Modified: libclc/trunk/configure.py