D18963: Improve KoModeBox display in horizontal Mode

2019-02-12 Thread Nathaniel Graham
ngraham accepted this revision as: VDG. ngraham added a comment. Certainly a visual improvement! +1! Wait for code review before landing, of course. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg Cc: ngraham, Calligra-Devel

D18963: Improve KoModeBox display in horizontal Mode

2019-02-12 Thread Nathaniel Graham
ngraham added a comment. The first image is the new version, not the old version. :) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg Cc: abetts, ngraham, Calligra-Devel-list, dcaliste, cochise, vandenoever

T12815: Create Calligra Framework by separating out applications and libraries

2020-03-13 Thread Nathaniel Graham
ngraham added a comment. I'm always in favor of moving shared content into frameworks, but just to be a miserable contrarian here (so feel free to ignore me), is the size of a git repo really an impediment to new contributors? In my experience, the opposite is true, that the more git repos o

T12815: Create Calligra Framework by separating out applications and libraries

2020-03-14 Thread Nathaniel Graham
ngraham added a comment. In T12815#223428 , @rempt wrote: > As an aside, I think splitting up kdepim into so many repositories was a huge mistake. Listening to David Faure at the onboarding sprint only confirmed that opinion. Having to work on h