Re: Review Request 124630: Use SHARE_INSTALL_PREFIX instead of {INSTALL_PREFIX, }share

://git.reviewboard.kde.org/r/124630/diff/ Testing --- tquiChecked that the affected files get installed into the desired location. Thanks, Heiko Becker ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request 127347: Fix build with glibc >= 2.23 by using std namespace

-- Builds. Thanks, Heiko Becker ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 127347: Fix build with glibc >= 2.23 by using qIsNaN

as not declared in this scope". Diffs (updated) - libs/widgets/KoUnitDoubleSpinBox.cpp 37f5415966e91ed543b22e5f50d04d7039f43f7d Diff: https://git.reviewboard.kde.org/r/127347/diff/ Testing --- Builds. Thanks, Heiko Becker ___ call

Re: Review Request 127347: Fix build with glibc >= 2.23 by using qIsNaN

marked as submitted. Review request for Calligra. Changes --- Submitted with commit 7634b8827778e8f5462e2b8fbcd7008499ae1b13 by Heiko Becker to branch master. Repository: calligra Description --- Otherwise I get "libs/widgets/KoUnitDoubleSpinBox.cpp:104:21: error: 'isna

D18866: Use check_symbol_exists instead of check_function_exists

heikobecker created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. heikobecker requested review of this revision. REVISION SUMMARY check_function_exists has some shortcomings, which fails to detect isnan when build against musl libc. The c

D18866: Use check_symbol_exists instead of check_function_exists

heikobecker updated this revision to Diff 51306. heikobecker added a comment. Replaced other check_function_exists invocations REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18866?vs=51220&id=51306 BRANCH master REVISION DETAIL https://phabricator.kde.

D18866: Use check_symbol_exists instead of check_function_exists

heikobecker added a comment. In D18866#408435 , @danders wrote: > What about the other ​check_function_exists, should they also be changed? Changed them, too. > Also, do you know when ​check_symbol_exists was introduced? > We still

D18866: Use check_symbol_exists instead of check_function_exists

heikobecker updated this revision to Diff 51307. heikobecker added a comment. Added missing "h". Thanks for noticing that. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18866?vs=51306&id=51307 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D18866: Use check_symbol_exists instead of check_function_exists

heikobecker marked an inline comment as done. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18866 To: heikobecker Cc: pino, danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18866: Use check_symbol_exists instead of check_function_exists

This revision was automatically updated to reflect the committed changes. Closed by commit R8:f43cb54c71d7: Use check_symbol_exists instead of check_function_exists (authored by heikobecker). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18866?vs=51307&id=5140

Re: Review Request 118172: wpg2odg import filter: add missing include dir

://git.reviewboard.kde.org/r/118172/#review61711 ------- On Mai 16, 2014, 6:46 nachm., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 118172: wpg2odg import filter: add missing include dir

- filters/flow/wpg/import/CMakeLists.txt 524d1b1e2ceab81a1cb06ecf213d3b2f31cb9f31 Diff: https://git.reviewboard.kde.org/r/118172/diff/ Testing --- successfully ran cmake and make Thanks, Heiko Becker ___ calligra-devel mailing list

Review Request 124630: Use DATA_INSTALL_DIR instead of INSTALL_PREFIX/share

. Thanks, Heiko Becker ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 124630: Use DATA_INSTALL_DIR instead of INSTALL_PREFIX/share

marked as submitted. Review request for Calligra. Changes --- Submitted with commit 59e7f697a5a91c0ad2c12cb6ba0238b2f131 by Heiko Becker to branch calligra/2.9. Repository: calligra Description --- Allowing to configure the install location, which is helpful with a multiarch

Re: Review Request 124630: Use DATA_INSTALL_DIR instead of INSTALL_PREFIX/share

: https://git.reviewboard.kde.org/r/124630/#review83653 --- On Aug. 5, 2015, 6:36 nachm., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 124630: Use SHARE_INSTALL_PREFIX instead of {INSTALL_PREFIX, }share

/124630/diff/ Testing (updated) --- tquiChecked that the affected files get installed into the desired location. Thanks, Heiko Becker ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 124630: Use SHARE_INSTALL_PREFIX instead of {INSTALL_PREFIX, }share

problem? IIRC (well, just looked up again) > > `FindKDE4Internal.cmake` derives `DATA_INSTALL_DIR` from > > `${CMAKE_INSTALL_PREFIX}`. > > Heiko Becker wrote: > Perhaps I was carried away by usage of ${DATA_INSTALL_DIR} everywhere > else. Sorry for that. > > And to ans

Review Request 118172: wpg2odg import filter: add missing include dir

: https://git.reviewboard.kde.org/r/118172/diff/ Testing --- successfully ran cmake and make Thanks, Heiko Becker ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

[Differential] [Request, 2 lines] D2702: flake: Include rather than

heikobecker created this revision. heikobecker added a reviewer: Calligra-Devel-list. heikobecker added a project: Calligra: 3.0. Restricted Application added a project: Kexi. REVISION SUMMARY With the latter I get an build error with gcc-5: "KoSnapStrategy.cpp:78:14: error: '__builtin_isfinit

[Differential] [Closed] D2702: flake: Include rather than

This revision was automatically updated to reflect the committed changes. heikobecker marked an inline comment as done. Closed by commit rCALLIGRA08b2bacdeeda: flake: Include rather than (authored by heikobecker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2702?vs=6525&id=6820#toc