D14975: Don't use obsolete QRectF functions

dcaliste created this revision. dcaliste added a reviewer: leinir. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Change deprecated function calls to QRectF::intersect() for QRectF::intersected(

D14975: Don't use obsolete QRectF functions

dcaliste added a comment. @anthonyfieroni Ok, will update the diff with other replacements of obsolete functions. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D14975 To: dcaliste, leinir Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D14975: Don't use obsolete QRectF functions

dcaliste updated this revision to Diff 40152. dcaliste added a comment. I've added replacements for QAbstractItemModel::reset(). This allow to "lock" the model during the reset. So I've tried to put the beginResetModel() before the change of the private members, and the endResetModel() after.

D14975: Don't use obsolete QRectF and QAbstractItemModel functions

dcaliste retitled this revision from "Don't use obsolete QRectF functions" to "Don't use obsolete QRectF and QAbstractItemModel functions". REVISION DETAIL https://phabricator.kde.org/D14975 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandeno

D14975: Don't use obsolete QRectF and QAbstractItemModel functions

dcaliste added a comment. @danders I agree with your remark, I was wondering exactly the same. It's safer to put the begin / end together. I'll update the diff and add a comment to suggest to move the end after the setCurrentIndex() after extensive testing. REVISION DETAIL https://phabrica

D14975: Don't use obsolete QRectF and QAbstractItemModel functions

dcaliste updated this revision to Diff 40193. dcaliste added a comment. Update the patch in stackChanged() call to have the exact behaviour than before in this method. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14975?vs=40152&id=40193 REVISION DETAIL https://phabricator.kde.o

D15053: Consistently use qreal in libs/pigment

dcaliste created this revision. dcaliste added reviewers: leinir, danders, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY On my ARM environment, qreal is interpreted as float, no

D15053: Consistently use qreal in libs/pigment

dcaliste added a comment. I'm crosscompiling in SailfishOS SDK. I'm in the process of upgrading Calligra there to latest version. @leinir have done it earlier with version 2.9.x. At that moment, pigment was not containing that kind of function to change luminosity... where the conversions ar

D15053: Consistently use qreal in libs/pigment

dcaliste added a comment. Ok, I'll try in the afternoon or during the week-end and comment here. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

dcaliste added a comment. After test (PRODUCTSET="KARBON"), it's not breaking karbon build on amd64. I cannot test easily on arm because karbon depends on KF5kdelibs4support, which is not available. But at least, proposed patch makes PART_WORDS and PART_STAGE compilable when qreal <=> fl

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

dcaliste created this revision. dcaliste added a reviewer: Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Replace QAbstractItemModel::reset() with the more recent {begin,end}Res

D15103: Replace deprecated use of QWeakPointer in favor of QPointer

dcaliste created this revision. dcaliste added a reviewer: Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY QWeakPointer has been deprecated to store pointers on QObject. QPointer

D15103: Replace deprecated use of QWeakPointer in favor of QPointer

dcaliste updated this revision to Diff 40514. dcaliste added a comment. Propagate changes into filters: missing conversion from QSharedPointer into QPointer. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15103?vs=40513&id=40514 REVISION DETAIL https://p

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

dcaliste added a comment. @leinir, thank you. Instead of compiling with deprecation off, it's better to correct them ;) I've finished making 3.1.0 compile in Sailfish SDK based on KF5 5.34.0 with minor tweaks, see http://git.merproject.org/dcaliste/calligra-bundle I'm commiting here al

D15103: Replace deprecated use of QWeakPointer in favor of QPointer

dcaliste added reviewers: leinir, danders. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15103 To: dcaliste, #calligra:_3.0, leinir, danders Cc: Calligra-Devel-list, cochise, vandenoever

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

dcaliste added a comment. @piggz thank you for the proposition. I've discussed with jpetrell, pvuorela and lbt on #sailfishos (see Tuesday 21th discussion, or the Tuesday before) and currently they prefer to have KF5 dependency packages within Calligra, not as standalone libraries in mer-cor

D15053: Consistently use qreal in libs/pigment

dcaliste updated this revision to Diff 40892. dcaliste added a comment. Update the patch not to use the form ```qBound(qreal(0.0), a, qreal(1.0))``` but ```qBound(0.0, a, 1.0)``` instead. For reference, original form was ```qBound(0.0, a, 1.0)``` which was causing issues when qreal <-> float,

D15231: Move to use QUrlQuery in favor of deprecated queryItemValue() from QUrl

dcaliste created this revision. dcaliste added a reviewer: leinir. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Some more deprecation upgrades: There is now in Qt a dedicated class for q

D15231: Move to use QUrlQuery in favor of deprecated queryItemValue() from QUrl

dcaliste added a reviewer: Calligra: 3.0. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15231 To: dcaliste, leinir, #calligra:_3.0 Cc: Calligra-Devel-list, cochise, vandenoever

D15232: Update deprecated use of setResizeMode()

dcaliste created this revision. dcaliste added reviewers: leinir, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Some additional deprecation updates. REPOSITORY R8 Calligra R

D15236: Add missing dependencies in CMakeLists.txt

dcaliste created this revision. dcaliste added reviewers: leinir, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Add missing dependencies in target_link_libraries() cmake macro h

D15236: Add missing dependencies in CMakeLists.txt

dcaliste edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15236 To: dcaliste, leinir, #calligra:_3.0 Cc: Calligra-Devel-list, cochise, vandenoever

D14975: Don't use obsolete QRectF and QAbstractItemModel functions

This revision was automatically updated to reflect the committed changes. Closed by commit R8:fe471acca71b: Don't use obsolete QRectF and QAbstractItemModel functions (authored by dcaliste). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14975?vs=40193&id=41961#toc REPOSITORY R8 Callig

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

This revision was automatically updated to reflect the committed changes. Closed by commit R8:e4a5dc4f46f2: Update deprecated QAbstractItemModel::reset() to use {begin,end}ResetModel()… (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1510

D15103: Replace deprecated use of QWeakPointer in favor of QPointer

This revision was automatically updated to reflect the committed changes. Closed by commit R8:4ebf41d68d71: Replace deprecated use of QWeakPointer in favor of QPointer (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D15231: Move to use QUrlQuery in favor of deprecated queryItemValue() from QUrl

This revision was automatically updated to reflect the committed changes. Closed by commit R8:5873bc9d963c: Move to use QUrlQuery in favor of deprecated queryItemValue() from QUrl (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15231?vs=4

D15232: Update deprecated use of setResizeMode()

This revision was automatically updated to reflect the committed changes. Closed by commit R8:bc9397bc9959: Update deprecated use of setResizeMode() (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15232?vs=40895&id=41968 REVISION DETAIL

D15236: Add missing dependencies in CMakeLists.txt

This revision was automatically updated to reflect the committed changes. Closed by commit R8:6b52b86ae29c: Add missing dependencies in CMakeLists.txt (authored by dcaliste). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15236?vs=40902&id=41970#toc REPOSITORY R8 Calligra CHANGES SINC

D15617: Move away from kdebug and kdelibs4 in filter/sheets

dcaliste created this revision. dcaliste added reviewers: leinir, danders, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Like done by commit https://phabricator.kde.org/R8:50c3

D15619: Remove use of kglobal.h in sheets

dcaliste created this revision. dcaliste added reviewers: leinir, danders, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Use QGlobalStatic instead of kdelibs4 kglobal. REPOSITO

D15620: Remove deprecated use of QDate::setYMD() and QFlag instead of QWindowFlag

dcaliste created this revision. dcaliste added reviewers: leinir, danders, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Some more deprecation changes. REPOSITORY R8 Calligra

D15617: Move away from kdebug and kdelibs4 in filter/sheets

dcaliste added a comment. @anthonyfieroni I see, like in filters/sheets/html for instance. I'm going to update the diff as soon as ready. Thanks for the comment. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15617 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: a

D15617: Move away from kdebug and kdelibs4 in filter/sheets

dcaliste updated this revision to Diff 41990. dcaliste added a comment. Update the patch, using categories for logging. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15617?vs=41981&id=41990 REVISION DETAIL https://phabricator.kde.org/D15617 AFFECTED FIL

D15622: Upgrade intersect() to intersected() calls

dcaliste created this revision. dcaliste added reviewers: leinir, anthonyfieroni, danders, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Some calls that I missed when upgrading

D15619: Remove use of kglobal.h in sheets

This revision was automatically updated to reflect the committed changes. Closed by commit R8:71363fdfd076: Remove use of kglobal.h in sheets (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15619?vs=41984&id=42032 REVISION DETAIL https

D15620: Remove deprecated use of QDate::setYMD() and QFlag instead of QWindowFlag

This revision was automatically updated to reflect the committed changes. Closed by commit R8:919c672526ef: Remove deprecated use of QDate::setYMD() and QFlag instead of QWindowFlag (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15620?vs

D15622: Upgrade intersect() to intersected() calls

This revision was automatically updated to reflect the committed changes. Closed by commit R8:427b182ebea1: Upgrade intersect() to intersected() calls (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15622?vs=41993&id=42051 REVISION DETAI

D15679: Add missing dependencies for PART_STAGE

dcaliste created this revision. dcaliste added reviewers: leinir, danders, anthonyfieroni, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Currently, KPrNotes is using the text sh

D15617: Move away from kdebug and kdelibs4 in filter/sheets

This revision was automatically updated to reflect the committed changes. Closed by commit R8:a06f24de8708: Move away from kdebug and kdelibs4 in filter/sheets (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15617?vs=41990&id=42234 REVIS

D15679: Add missing dependencies for PART_STAGE

This revision was automatically updated to reflect the committed changes. Closed by commit R8:5149f3864f5e: Add missing dependencies for PART_STAGE (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15679?vs=42088&id=42235 REVISION DETAIL

D15728: Try to avoid segfaults on shape factory not found

dcaliste created this revision. dcaliste added reviewers: leinir, anthonyfieroni, danders, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Try to catch every pattern of KoShapeReg

D15728: Try to avoid segfaults on shape factory not found

This revision was automatically updated to reflect the committed changes. Closed by commit R8:ccb647780104: Try to avoid segfaults on shape factory not found (authored by dcaliste). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15728?vs=42242&id=42258#toc REPOSITORY R8 Calligra CHANG

D15775: Make the item background color and page cache properties available from View component

dcaliste created this revision. dcaliste added reviewers: leinir, danders, anthonyfieroni, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY Currently, the item background color and

D15775: Make the item background color and page cache properties available from View component

dcaliste added a comment. Sorry, I was not clear in my description, I'm not setting the paper background color, but the item background color, i.e. the small area around and between the pages. In most desktop application it is light grey. But when using the KWCanvasItem in another context, i

D15775: Make the item background color and page cache properties available from View component

dcaliste added a comment. Thank you @leinir for your review. I've not disappeared, but I'm still thinking about a way not to expose the impl object from Document class, while not cluttering the Document API with methods like setBackgroundColor(), setPageCache() or any other future canvas met

D15053: Consistently use qreal in libs/pigment

This revision was automatically updated to reflect the committed changes. Closed by commit R8:560701ff2443: Consistently use qreal in libs/pigment (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15053?vs=40892&id=43312 REVISION DETAIL

D15053: Consistently use qreal in libs/pigment

dcaliste added a comment. Thank you all for the review. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: boemann, anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19884: Avoid deprecated QAbstractItemModel::reset()

dcaliste added inline comments. INLINE COMMENTS > TextDocumentStructureModel.cpp:308 > > -reset(); > } I did the same changes in https://phabricator.kde.org/D15102 at another place and I put the begin and end at the start and end of the routine, like you did. But I remember that I got r

D19884: Avoid deprecated QAbstractItemModel::reset()

This revision was automatically updated to reflect the committed changes. Closed by commit R8:b29f7aa31c5e: Avoid deprecated QAbstractItemModel::reset() (authored by pvuorela, committed by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19884?vs=54322

D19912: Implement logging category for rtf-qt

This revision was automatically updated to reflect the committed changes. Closed by commit R8:85b57f2e64bb: Implement logging category for rtf-qt (authored by pvuorela, committed by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19912?vs=54405&id=548

D19938: Avoid deprecated QRegion::subtract()

This revision was automatically updated to reflect the committed changes. Closed by commit R8:149cd73c722b: Avoid deprecated QRegion::subtract() (authored by pvuorela, committed by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19938?vs=54476&id=5484

D19761: Remove obsolete syncX() workaround

This revision was automatically updated to reflect the committed changes. Closed by commit R8:b0e185c8a3a6: Remove obsolete syncX() workaround (authored by pvuorela, committed by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19761?vs=53887&id=54843

D19885: Implement logging category for excel plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R8:5e9da957f156: Implement logging category for excel plugins (authored by pvuorela, committed by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19885?vs=54337

D19760: Support Qt <5.7 on KoShape flag usage

This revision was automatically updated to reflect the committed changes. Closed by commit R8:b08a4bac940d: Support Qt <5.7 on KoShape flag usage (authored by pvuorela, committed by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19760?vs=53886&id=548

D19973: MsooXmlCommonRead: protect member for double free

This revision was automatically updated to reflect the committed changes. Closed by commit R8:c06c5e01455f: MsooXmlCommonRead: protect member for double free (authored by pvuorela, committed by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19973?vs=

D19941: Avoid deprecated setSupportedDragActions

This revision was automatically updated to reflect the committed changes. Closed by commit R8:4f304e579fce: Avoid deprecated setSupportedDragActions (authored by pvuorela, committed by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19941?vs=54483&id=

D23492: Correct anchor detection in QML components.

dcaliste created this revision. dcaliste added reviewers: leinir, pvuorela, danders, boemann. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY The loop to translate the anchor shape position in T

D23492: Correct anchor detection in QML components.

dcaliste updated this revision to Diff 65201. dcaliste added a comment. Thank you pvuorela pointing out other places for this construct. I've updated the patch with a fix for the faulty loops for spreadsheets and presentations also. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https

D23679: Correct anchor detection in QML components.

dcaliste created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REPOSITORY R8 Calligra BRANCH anchors REVISION DETAIL https://phabricator.kde.org/D23679 AFFECTED FILES components/impl/Pres

D23679: Correct anchor detection in QML components.

dcaliste abandoned this revision. dcaliste added a comment. Sorry, made a mistake with arc… This differential revision is already D23492 . REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D23679 To: dcaliste Cc: Calligra-Devel-list,

D23492: Correct anchor detection in QML components.

This revision was automatically updated to reflect the committed changes. Closed by commit R8:f0f0eedf1e74: Correct anchor detection in QML components. (authored by dcaliste). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23492?vs=65201&id=65245 REVISION DETA

D24761: Asign correct column width when importing XLS file

dcaliste added a comment. Well, after reading the difference between the logical and physical DPI values: https://stackoverflow.com/questions/16561879/what-is-the-difference-between-logicaldpix-and-physicaldpix-in-qt (see the first answer), using the logical value is consistent with the hard

D24831: Migrate csv plugins from kdebug to qdebug

dcaliste accepted this revision. dcaliste added a comment. This revision is now accepted and ready to land. The patch looks fine, thank you. REPOSITORY R8 Calligra BRANCH csv_qdebug (branched from master) REVISION DETAIL https://phabricator.kde.org/D24831 To: pvuorela, dcaliste, leini

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

dcaliste added a comment. @davidllewellynjones, I hadn't time yet to test the patch, but the idea and implementation is already looking great in my opinion. Maybe, just one remark after looking at the proposed additions: not saving the formale, but the values should not be named read-only. I

D25715: Use RTF default color as default Qt format

dcaliste added a comment. Just a suggestion to avoid adding a variable which meaning may be redundant with the state of an already existing one. Otherwise LGTM. INLINE COMMENTS > ColorTableDestination.cpp:26 > ColorTableDestination::ColorTableDestination( Reader *reader, > AbstractRtfO

D25715: Use RTF default color as default Qt format

dcaliste added a comment. @pvuorela as you prefer, anyway, it's a question of taste, I find it myself easier to follow if the information is on one variable only. But your solution is good also, the file is small and is kept small so easy to follow. REPOSITORY R8 Calligra REVISION DETAIL

D26050: Fix build with poppler 82

dcaliste added a comment. I like the idea of trying to move away from the monolythic release. Not that my opinion matters much, but I'm willing to help in the endeavor. I'll try to participate in tasks in that direction as much as my free time will allow it. REPOSITORY R8 Calligra REVISIO

T12815: Create Calligra Framework by separating out applications and libraries

dcaliste added a comment. As a nobody, my opinion on the rightfullness to split or not the repository is of no interest. But what I like in the proposition of @leinir is the target to separate the "engine" from the UI (_i.e._ the widgetery). As an example (hopefully not outdated), the "find"