D19912: Implement logging category for rtf-qt

2019-03-20 Thread Dag Andersen
danders added a comment. In D19912#435067 , @pvuorela wrote: > In D19912#435058 , @danders wrote: > > > Strange indents, could you fix it? > > > That's what I commented on the summary. On some

D19938: Avoid deprecated QRegion::subtract()

2019-03-21 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19938 To: pvuorela, #calligra:_3.0, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19941: Avoid deprecated setSupportedDragActions

2019-03-22 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19941 To: pvuorela, #calligra:_3.0, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19973: MsooXmlCommonRead: protect member for double free

2019-03-25 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19973 To: pvuorela, #calligra:_3.0, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19884: Avoid deprecated QAbstractItemModel::reset()

2019-03-25 Thread Dag Andersen
danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. I think this should be ok REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19884 To: pvuorela, danders Cc: danders, dcaliste, Calligra-Devel-list, cochise, vandeno

D11971: Use same keyword separator for read and write

2019-03-25 Thread Dag Andersen
danders added a comment. Yes, looks sane, I'll deal with it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D11971 To: michaelh, #calligra:_3.0, leinir, danders Cc: Calligra-Devel-list, anthonyfieroni, dcaliste, cochise, vandenoever

D11971: Use same keyword separator for read and write

2019-03-25 Thread Dag Andersen
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:e52edfd1b50f: D11971: Use same keyword separator for read and write (authored by danders). CHANGED PRIOR TO COMMIT htt

T10760: Calligra website unwanted blog content

2019-04-05 Thread Dag Andersen
danders added a comment. It seems I have not the privileges to fix this. Can someone else have a look? TASK DETAIL https://phabricator.kde.org/T10760 To: danders Cc: danders, #sysadmin, Calligra-Devel-list, #calligra:_3.0, ongunkanat, sysadmin

D20400: Karbon: Enable multi page capability

2019-04-08 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. danders added a project: Calligra: 3.0. danders requested review of this revision. REVISION SUMMARY Since odg spec supports multiple pages, I feel karbon also needs to support it. The main things that has changed:

D20400: Karbon: Enable multi page capability

2019-04-09 Thread Dag Andersen
danders added a comment. Ooops, this didn't work as expected. This should have been a revision of D19327 . There is only small changes: 1. Updated commit message. 2. In karbon/ui/KarbonFactory.cpp: Loading of the calligra/pageapp tools. 3. In karb

D20400: Karbon: Enable multi page capability

2019-06-05 Thread Dag Andersen
danders added a comment. I have been pondering why we disagreed so much on the background color, and I *think* I have an answer. My take is it's because we have not been talking about quite the same thing: I have looked at karbon as an *odg* editor, since it uses odg as its native file fo

D20400: Karbon: Enable multi page capability

2019-06-06 Thread Dag Andersen
danders updated this revision to Diff 59256. danders added a comment. Add dependence on LIB_KOPAGEAPP REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20400?vs=55797&id=59256 BRANCH karbon_multipage_danders REVISION DETAIL https://phabricator.kde.org/D20

D20400: Karbon: Enable multi page capability

2019-06-07 Thread Dag Andersen
danders added a comment. In D20400#475477 , @anthonyfieroni wrote: > Now we have insert page, but we don't exports them :) If you think that's ok for now go for it. If you mean export to svg here, afaics there are no page element in svg.

D20400: Karbon: Enable multi page capability

2019-11-01 Thread Dag Andersen
danders updated this revision to Diff 69152. danders added a comment. Handle removing pages from a pageapp properly REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20400?vs=59256&id=69152 BRANCH karbon_multipage_danders REVISION DETAIL https://phabricat

D20400: Karbon: Enable multi page capability

2019-11-04 Thread Dag Andersen
danders updated this revision to Diff 69262. danders added a comment. SvgImport: Add the new layer to the page REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20400?vs=69152&id=69262 BRANCH karbon_multipage_danders REVISION DETAIL https://phabricator.kd

D20400: Karbon: Enable multi page capability

2019-11-04 Thread Dag Andersen
danders updated this revision to Diff 69263. danders added a comment. KarbonView: Add slot to handle replaceActivePage REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20400?vs=69262&id=69263 BRANCH karbon_multipage_danders REVISION DETAIL https://phabri

D20400: Karbon: Enable multi page capability

2019-11-05 Thread Dag Andersen
danders added a comment. In D20400#475477 , @anthonyfieroni wrote: > Now we have insert page, but we don't exports them :) If you think that's ok for now go for it. Just for the record: The pdf filter goes through the svg filter and as s

D20400: Karbon: Enable multi page capability

2019-11-05 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes. Closed by commit R8:5a9a18f484a4: Karbon: Enable multi page capability (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20400?vs=69263&id=69300 REVISION DETAIL htt

D25171: PDF Import: Add multipage support

2019-11-06 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Imports multipage pdf files as svg using poppler to generate an svg file pr

D25171: PDF Import: Add multipage support

2019-11-08 Thread Dag Andersen
danders updated this revision to Diff 69423. danders added a comment. Remove commented code REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25171?vs=69343&id=69423 BRANCH multipagepdf REVISION DETAIL https://phabricator.kde.org/D25171 AFFECTED FILES

D25171: PDF Import: Add multipage support

2019-11-08 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes. Closed by commit R8:c81c23998e09: PDF Import: Add multipage support (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25171?vs=69423&id=69424 REVISION DETAIL https:

D25214: Karbon image filter: Add multipage support

2019-11-08 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Adds ability to select page in the options dialog TEST PLAN Export to png

D25214: Karbon image filter: Add multipage support

2019-11-11 Thread Dag Andersen
danders updated this revision to Diff 69566. danders added a comment. Remove unused include REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25214?vs=69438&id=69566 BRANCH multipage_image_danders REVISION DETAIL https://phabricator.kde.org/D25214 AFFECT

D25214: Karbon image filter: Add multipage support

2019-11-11 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes. Closed by commit R8:0daf145a929a: Karbon image filter: Add multipage support (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25214?vs=69566&id=69567 REVISION DETAIL

D25254: Remove flow, not needed since karbon can do it all

2019-11-11 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Since karbon is multipage app and stencils docker can be used by all apps,

D25254: Remove flow, not needed since karbon can do it all

2019-11-11 Thread Dag Andersen
danders added a comment. Yeah, well. If flow had some special functionallity that made it much easier to crate flow charts, I would also be reluctant to just remove it. As it stands flow has nothing special, it is only a few line of code actually, and as I see it, the karbon ui is very si

D25254: Remove flow, not needed since karbon can do it all

2019-11-14 Thread Dag Andersen
danders added a comment. In D25254#561131 , @boemann wrote: > To be honest I kind of liked the idea of a dedicated flow drawing tool and a dedicated vector drawing tool, but since they have so little between them, and no one seem to be maintaini

D25664: [WIP]: Port away from deprecated QSignalMapper

2019-12-02 Thread Dag Andersen
danders added a comment. Afaik we still support qt5.3, I don't think qAsConst is availabel. Disregard if this has changed. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25664 To: ognarb, #calligra:_3.0, #kf6, dfaure Cc: danders, dfaure, Calligra-Devel-list, davidl

D27056: Stage: Add automatic slide transition

2020-01-31 Thread Dag Andersen
danders created this revision. danders added a reviewer: zachmann. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Introduces 2 modes for slide transitions: Manual: Slide transition and animation

D27056: Stage: Add automatic slide transition

2020-02-05 Thread Dag Andersen
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:4f4141727401: Stage: Add automatic slide transition (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST

D25254: Remove flow, not needed since karbon can do it all

2020-03-03 Thread Dag Andersen
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:f8786b001b75: Remove flow, not needed since karbon can do it all (authored by danders). REPOSITORY R8 Calligra CHANGE

D26221: Use QQC2 Dialog

2020-03-09 Thread Dag Andersen
danders added a comment. ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26221 To: ognarb, #calligra:_3.0, leinir Cc: danders, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26050: Fix build with poppler 82

2020-03-09 Thread Dag Andersen
danders added a comment. Ooops, seems I fixed this (+ 0.83) in separate commits, so this can be closed. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26050 To: tcanabrava, #calligra:_3.0 Cc: danders, rjvbb, awilcox, dcaliste, leinir, asturmlechner, ognarb, anthonyf

D25422: Handle custom-shapes to display text in ODP files

2020-03-09 Thread Dag Andersen
danders added a comment. ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25422 To: mphilippov, denexter, davidllewellynjones, pvuorela, dcaliste Cc: danders, denexter, pvuorela, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25423: Fill table cells with color for ODS and XLSX files

2020-03-09 Thread Dag Andersen
danders added a comment. ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25423 To: mphilippov, denexter, pvuorela, davidllewellynjones, dcaliste Cc: danders, dcaliste, davidllewellynjones, denexter, Calligra-Devel-list, #calligra:_3.0, ognarb, cochise, vandenoe

D26328: Calculate and display proper number for headings started with lower level for DOC, DOCX and ODT.

2020-03-09 Thread Dag Andersen
danders added a reviewer: boemann. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26328 To: mphilippov, pvuorela, denexter, dcaliste, davidllewellynjones, boemann Cc: davidllewellynjones, dcaliste, denexter, pvuorela, Calligra-Devel-list, #calligra:_3.0, ognarb, cochise

D26328: Calculate and display proper number for headings started with lower level for DOC, DOCX and ODT.

2020-03-12 Thread Dag Andersen
danders added a comment. Any comments, anyone? I have not tested and does not know if it is the right way to do it. If nobody have comments, I'm willing to trust the author and say go for it! REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26328 To: mphilippov, pv

D15428: [textlayout] Don't enter infinite loop when table is misfit

2020-03-12 Thread Dag Andersen
danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. There are unit tests that fail without this, so if somebody doas not come up with code that shows this is wrong, please commit. REPOSITORY R8 Calligra REVISION DETAIL https://phabric

D2577: KoResourcePaths: Fix handling of wildcards in directories and files

2020-03-12 Thread Dag Andersen
danders abandoned this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D2577 To: danders, #calligra:_3.0, staniek, Calligra-Devel-list Cc: anthonyfieroni, staniek, davidllewellynjones, dcaliste, ognarb, barman, cochise, vandenoever

D26050: Fix build with poppler 82

2020-03-12 Thread Dag Andersen
danders added a comment. @tcanabrava please abondone this. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26050 To: tcanabrava, #calligra:_3.0 Cc: danders, rjvbb, awilcox, dcaliste, leinir, asturmlechner, ognarb, anthonyfieroni, Calligra-Devel-list, davidllewellynjo

D24852: Remove list style from headings

2020-03-12 Thread Dag Andersen
danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Most seems to be positive, so go for it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0, boemann, danders Cc: dande

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

2020-03-12 Thread Dag Andersen
danders added a comment. ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25008 To: davidllewellynjones, #calligra:_3.0, pvuorela, dcaliste Cc: danders, anthonyfieroni, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25714: [WIP]: Port away from deprecated KHtml

2020-03-12 Thread Dag Andersen
danders added a comment. Still wip, or... REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25714 To: ognarb, #calligra:_3.0 Cc: danders, leinir, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D22545: Add missing include QDate

2020-03-13 Thread Dag Andersen
danders closed this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D22545 To: usta, #calligra:_3.0, Calligra-Devel-list, boemann Cc: dfaure, pino, boemann, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26050: Fix build with poppler 82

2020-03-13 Thread Dag Andersen
danders added a reviewer: danders. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26050 To: tcanabrava, #calligra:_3.0, danders Cc: danders, rjvbb, awilcox, dcaliste, leinir, asturmlechner, ognarb, anthonyfieroni, Calligra-Devel-list, davidllewellynjones, cochise, vande

D25034: Fix decoding of strings with wingdings/symbol characters in excel TxO records.

2020-03-13 Thread Dag Andersen
danders added a comment. ping REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25034 To: denexter, pvuorela, mkruisselbrink Cc: danders, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D15775: Make the item background color and page cache properties available from View component

2020-03-13 Thread Dag Andersen
danders added a comment. ping REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15775 To: dcaliste, leinir, danders, anthonyfieroni, #calligra:_3.0 Cc: boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D11191: Remove Plan dependencies from CMakeLists.txt

2020-03-13 Thread Dag Andersen
danders closed this revision. Herald added a subscriber: Calligra-Devel-list. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D11191 To: kavindap, #calligra:_3.0, staniek Cc: Calligra-Devel-list, staniek, danders, davidllewellynjones, dcaliste, ognarb, cochise, vandenoeve

D7228: SpellCheck: Fix markup rebasing when simple edits are done (one char added)

2020-03-13 Thread Dag Andersen
danders abandoned this revision. danders added a comment. Herald added a subscriber: Calligra-Devel-list. Has been comitted REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D7228 To: danders, boemann Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochis

T12815: Create Calligra Framework by separating out applications and libraries

2020-03-19 Thread Dag Andersen
danders added a comment. I think where leinir has landed is more doable than a frameworks. Also if compiletime is a big hurdle, I see a couple of things that can be done: - Remove pigment, see T5738 . - Make more finegrained productsets. Pt the on

D28820: Chart: Fix Bug 240520 - No axes lines when creating new chart

2020-04-14 Thread Dag Andersen
danders created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Turns out KChart needs a explicitly set pen to draw ruler lines. KChart 2.7.0 will have the option to set a pen int

D28820: Chart: Fix Bug 240520 - No axes lines when creating new chart

2020-04-17 Thread Dag Andersen
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:240fb4f60810: Chart: Fix Bug 240520 - No axes lines when creating new chart (authored by danders). REPOSITORY R8 Calli

D29542: Refactor MainWindow view

2020-05-11 Thread Dag Andersen
danders added a comment. Hmmm, it seems to me you are creating a leak in your lines 544, 545? (Have not tested, I might be wrong) Afaics the problem is that a focus event is issued that accesses the view after death. Possibly a deleteLater() would do it, but I tried with setting paret

D29542: Refactor MainWindow view

2020-05-11 Thread Dag Andersen
danders added a comment. In D29542#668076 , @anthonyfieroni wrote: > `d->rootPart->createView(doc, this);` Creates the view which parent is main window. Ahh, yes, but then... Why will it not crash if a new document is set so that d->

D29542: Refactor canvas event handling

2020-05-13 Thread Dag Andersen
danders added a comment. This seems to work fine, I also tested with only pageapp changes. Imho I would prefer to separate the pageapp and KoMainWindow changes into separate commits, The pageapp changes should go into 3.2 branch followed by a swift release. I don't think the KoMainWindow

Re: Unit test coverage

2010-12-12 Thread Dag Andersen
He, he, hope this is not true (that kplato has best coverage), there is really large areas not covered. Must be that kplato is small :) -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: problem linking plan

2010-12-22 Thread Dag Andersen
rsten, could you check if it links for you now? This is pure C code but it has // comments and uses inline so needs: gcc -std=c99 to compile. Does anyone know have to do this properly, so it works for gcc as well as other compilers? -- Mvh. Dag Andersen > > Thanks, > > Thorsten >

Re: kplato compile problem on windows

2011-01-24 Thread Dag Andersen
ltiMap AppointmentInterval> > > class KPLATO_EXPORT AppointmentIntervalList : public > AppointmentIntervalBase > > > Any further thought on this? Could it be a missing constructor in AppointmentIntervalList? -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: kplato compile problem on windows

2011-01-24 Thread Dag Andersen
t; { > // all your existing methods go here > private: > QMultiMap m_data; > }; > > Ciao Jan > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: kplato compile problem on windows

2011-01-24 Thread Dag Andersen
ui. > > (Personnally, I would go for Jan's solution and hide the QMap, because I > don't like to inherits from the containers, but I guess it is a matter of > taste :) ) -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

tools docker etc in plan

2011-01-25 Thread Dag Andersen
f you know their id. I'd rather have the possibility to *enable* those I use and have everything else disabled. Anybody knows how this could most easily be achived? -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.

crash in progress updater

2011-01-27 Thread Dag Andersen
n _start () -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: unittests

2011-02-07 Thread Dag Andersen
; 267 - shapes-text-TestDocumentLayout (Failed) > 268 - shapes-text-TestChangeListCommand (Failed) > 270 - shapes-text-TestStylesModel (Failed) > 271 - shapes-text-TestTableLayout (Failed) > 275 - ksprea

kdchart crash

2011-04-26 Thread Dag Andersen
not marked as deleted before it deletes its children, so setParent(0) does not confuse QObject. Could you have look and commit if ok, or find a better solution if possible? -- Mvh. Dag Andersen Index: KDChartChart.cpp === --- KDChartCh

koproperty/koreport: sizepolicy and expanding fields

2011-04-27 Thread Dag Andersen
o, imo the expansion should be limited to section size. Horizontally this would mean page right edge. Vertically I'm not sure, sections seems not to have a fixed height. I have a half working solution but I'd like a go ahead to put more time into it. -- Mvh. Dag Andersen

Re: koproperty/koreport: sizepolicy and expanding fields

2011-04-27 Thread Dag Andersen
Onsdag 27 april 2011 09:31:16 skrev du: > On 27 April 2011 09:07, Dag Andersen wrote: > > Hi, I'm wondering a bit about the properties "Can Grow" and "Word Wrap" > > used for the field item. I don't find the functionality very intuitive > > s

TableShape/reports crash

2011-05-26 Thread Dag Andersen
(spreadsheetshape TableShapeFactory.cpp) target_link_libraries(spreadsheetshape-deferred calligratablescommon) target_link_libraries(spreadsheetshape flake) Hence, TableShapeFactory does not know about TableShape. How can this be solved? -- Mvh. Dag Andersen

Unusable shapes in KoReportItemShape?

2011-05-26 Thread Dag Andersen
It seems to me this report item loads all available flake shape plugins so they can be added to a report. AFAICS nothing is diplayed in the report, and some of the shapes also crashes. Is this work in progress or should maybe this be disabled? -- Mvh. Dag Andersen

words crash, help needed

2011-06-15 Thread Dag Andersen
er to use when searching for frames on a page. I don't fully understand how it is meant to work so I need help with that. The att. hack seems to fix the problem but is, well, just a hack. -- Mvh. Dag Andersen diff --git a/words/part/KWRootAreaProvider.cpp b/words/part/KWRootAreaProvider

Re: words crash, help needed

2011-06-15 Thread Dag Andersen
posed to > do / how things are working together. OK, I'll await your solution then. -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

words: strange code KWFrame dtor

2011-06-16 Thread Dag Andersen
, something like the att patch should be applied. -- Mvh. Dag Andersen diff --git a/words/part/frames/KWFrame.cpp b/words/part/frames/KWFrame.cpp index ed9dde6fd..590c770 100644 --- a/words/part/frames/KWFrame.cpp +++ b/words/part/frames/KWFrame.cpp @@ -41,7 +41,8 @@ KWFrame::KWFrame(KoShape *shape

Switching shapes and tools: is it broken?

2011-06-20 Thread Dag Andersen
for this check? Surface testing shows that disabling it works. -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: words: strange code KWFrame dtor

2011-06-20 Thread Dag Andersen
Fredag 17 juni 2011 23:13:55 skrev C. Boemann: > On Friday 17 June 2011 19:42:31 Sebastian Sauer wrote: > > Dag Andersen wrote: > > > The code indicates that the last frame should delete its frameset. This > > > never happens though, as when the frame removes itself f

Re: Switching shapes and tools: is it broken?

2011-06-20 Thread Dag Andersen
Mandag 20 juni 2011 11:37:13 skrev du: > On 20.06.2011 10:34, Dag Andersen wrote: > > Before the weekend I fixed a crash in ArtisticTextShape and, as Jan > > Hambrect pointed out, I unvittingly removed the functionallity to go > > direct between shapes. So I thought I'd

Fwd: Re: Switching shapes and tools: is it broken?

2011-06-20 Thread Dag Andersen
This was meant for the list, sorry Jan. --- Videresendt brev Emne: Re: Switching shapes and tools: is it broken? Dato: Mandag 20 juni 2011, 13:02:12 Fra: Dag Andersen Til: ja...@gmx.net Mandag 20 juni 2011 11:37:13 skrev du: > On 20.06.2011 10:34, Dag Ander

Re: Switching shapes and tools: is it broken?

2011-06-20 Thread Dag Andersen
Mandag 20 juni 2011 13:17:27 skrev Dag Andersen: > Mandag 20 juni 2011 11:37:13 skrev du: > > On 20.06.2011 10:34, Dag Andersen wrote: > > > Before the weekend I fixed a crash in ArtisticTextShape and, as Jan > > > Hambrect pointed out, I unvittingly removed the functi

Re: Switching shapes and tools: is it broken?

2011-06-21 Thread Dag Andersen
Mandag 20 juni 2011 22:37:10 skrev ja...@gmx.net: > On Monday 20 June 2011 15:31:28 Dag Andersen wrote: > > Mandag 20 juni 2011 15:20:27 skrev du: > > > On 20.06.2011 13:02, Dag Andersen wrote: > > > > Mandag 20 juni 2011 11:37:13 skrev du: > > > >

krita shape selection strategy

2011-06-21 Thread Dag Andersen
shape to editing another with one click. -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: krita shape selection strategy

2011-06-23 Thread Dag Andersen
Tirsdag 21 juni 2011 20:13:14 skrev Cyrille Berger Skott: > On Tuesday 21 June 2011, Dag Andersen wrote: > > It seems krita has its own shape selection strategy. > > When editing one shape, clicking on a different shape selcets the new > > shape activating the interactio

Review request: Do not loose DDE text

2011-07-01 Thread Dag Andersen
Hi, a small patch to load text inside a dde connection. Atm this is all it does, it does not resolve the connection or even preserve the declaration. This is *only* to not loose the text. And, it comes with a unit test. (not in the diff) -- Mvh. Dag Andersen diff --git a/libs/kotext

Review Request: Page breaks are not saved to odt document

2011-07-05 Thread Dag Andersen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101854/ --- Review request for Calligra. Summary --- Set page break adding setPro

Review Request: Do not loose DDE text

2011-07-05 Thread Dag Andersen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101855/ --- Review request for Calligra. Summary --- Load text inside a dde conne

Re: Review Request: Page breaks are not saved to odt document

2011-07-07 Thread Dag Andersen
27;ve now commited the more elaborate fix, so please close this request Great. Done. -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Do not loose DDE text

2011-07-07 Thread Dag Andersen
gt; text:dde-connection field and reads the text too. > > Do you have a document where this is used? If yes I would be very > interested in it as I like to add that to my test files I use for > cstester. There is one here: kotext/opendocument/tests/data/DDE/dde.odt or else it is ea

Re: Review Request: Cleanup documentation and help calls

2011-07-24 Thread Dag Andersen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102056/#review5021 --- Ship it! For plan/planwork, too. - Dag On July 23, 2011, 8:5

Re: Random test failures...

2011-08-30 Thread Dag Andersen
2 ref= 0 ... knotify(24532) KNotify::event: 272 ref= 0 knotify(24532) KNotify::event: 273 ref= 0 kdeinit4: preparing to launch /usr/lib/kde4/libexec/drkonqi -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Random test failures...

2011-09-01 Thread Dag Andersen
Tirsdag 30 august 2011 16:20:09 skrev Cyrille Berger Skott: > On Tuesday 30 August 2011, Dag Andersen wrote: > > Tirsdag 30 august 2011 09:58:33 skrev Cyrille Berger Skott: > > > Hi, > > > > > > It actually seems we get a lot of random test failures this day

Re: Random test failures...

2011-09-05 Thread Dag Andersen
Fredag 02 september 2011 18:59:22 skrev Cyrille Berger Skott: > On Thursday 01 September 2011, Dag Andersen wrote: > > > The weird thing is that it seems to only affect a limited subset of > > > test. > > > > Yes, I've only seen the calendar test for plan,

Re: Features changelog for Calligra 2.4 Beta

2011-09-13 Thread Dag Andersen
has improved protection when the project is baselined. -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Tables scripting

2011-09-13 Thread Dag Andersen
I see that the tables scripting module is still KSpread. Should this be renamed or should it stay? -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: news from Debian packaging

2011-09-18 Thread Dag Andersen
ned-soname ยป : > http://lintian.debian.org/tags/shlib-without-versioned-soname.html Ahh yes, missing set properties. Patch attatched. (...) -- Mvh. Dag Andersen diff --git a/plan/plugins/schedulers/rcps/libs/src/CMakeLists.txt b/plan/plugins/schedulers/rcps/libs/src/CMakeLists.txt index 08a600e..49397fa 1

words crash (assert in texttool)

2011-09-21 Thread Dag Andersen
x27;t have full understanding of the logic so I do not know if this introduces problems. Could somebody in the know commit if it is ok, or maybe find a proper solution :) -- Mvh. Dag Andersen diff --git a/plugins/textshape/TextTool.cpp b/plugins/textshape/TextTool.cpp index 3917066..142d934 1

Re: news from Debian packaging

2011-09-22 Thread Dag Andersen
I also found liblibwmf.so -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Making scripts available to the public

2011-11-04 Thread Dag Andersen
Do we (and users) have anywhere to put scripts that one wants to be available to the public? For koffice we used kde-files.org but I don't know if that's the best place. -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde

words broken?

2011-11-10 Thread Dag Andersen
positioning error as described above. Any thoughts? -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: words broken?

2011-11-10 Thread Dag Andersen
Torsdag 10 november 2011 11:29:54 skrev C. Boemann: > On Thursday 10 November 2011 11:07:14 Dag Andersen wrote: > > I see a number of strange things: > > > > * I do not get any Tools docker > > Yes the ui has changed. The tools docker and tool optons docker has

Re: [calligra] plan/libs/ui: Remove depreciated KABC, use akonadi.

2011-11-17 Thread Dag Andersen
Onsdag 16 november 2011 19:18:01 skrev Cyrille Berger Skott: > Hi, > > I get the following compilation error with KDE 4.4 : > http://my.cdash.org/viewBuildError.php?buildid=259809 Yes indeed, akonadi first introduced in 4.5. Added conditionals. > -- Mv

Re: [calligra] plan/libs/ui: Remove depreciated KABC, use akonadi.

2011-11-17 Thread Dag Andersen
Torsdag 17 november 2011 10:34:30 skrev Cyrille Berger Skott: > On Thursday 17 November 2011, Dag Andersen wrote: > > Onsdag 16 november 2011 19:18:01 skrev Cyrille Berger Skott: > > > Hi, > > > > > > I get the following compilation error with

Review Request: Bug in KoXml* to QDom* conversion

2012-01-11 Thread Dag Andersen
r/103674/diff/diff Testing --- Unit test passes (but it did before too). No crash in Plan. Thanks, Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Bug in KoXml* to QDom* conversion

2012-01-11 Thread Dag Andersen
pp 6631b64 libs/odf/tests/TestXmlReaderWithoutSpaces.cpp 5179846 Diff: http://git.reviewboard.kde.org/r/103674/diff/diff Testing --- Unit test passes (but it did before too). No crash in Plan. Thanks, Dag Andersen ___ calligra-devel mailing list

<    1   2   3   >