Plan freeze

2018-10-29 Thread Dag
I'm working on moving plan into separate repository to ease release work. Please do not do any work on plan until futher notice. -- Cheers, Dag

Re: Plan freeze

2018-11-09 Thread Dag
Dag skrev den 2018-10-29 14:29: I'm working on moving plan into separate repository to ease release work. Please do not do any work on plan until futher notice. Done, named calligraplan, so open for contributions :)

karbon and multi page docs

2018-11-14 Thread Dag
@anthony I think karbon should be able to handle docs with more than one page as this is valid odf. This would also mean we can axe flow, as prev flow maintainer planned. What do you think? -- Cheers, Dag

Re: New website

2020-03-03 Thread Dag
more maintainers would like access, but I'm sure they can speak up for themselves :) --- Cheers, Dag Carl Schwan skrev den 2020-03-02 16:42: > Hello, > the website progressed a lot during Season of KDE and it was completly > updated. Thanks a lot to Anuj Bansal for his work

Re: Translation issues with the calligraplan documentation

2020-03-26 Thread Dag
I have adjusted the structure so now xml2po extracts all texts, at least. Haven't tested if xml2po works. Also noted there are problems with keycode/keycap, but let's see if my changes is enough to generate translated docs. --- Cheers, Dag Luigi Toscano skrev den 2020-03-24 23

Re: stable branch

2020-03-26 Thread Dag
Jonathan Riddell skrev den 2020-03-26 17:44: The stable branch for calligra is still set to calligra/3.1 but the current release series is 3.2 from master. Can this be fixed? Calligra stable is still 3.1. Could this be a mixup with calligraplan? Dag Jonathan

Re: Translation issues with the calligraplan documentation

2020-03-26 Thread Dag
Dag skrev den 2020-03-26 09:57: I have adjusted the structure so now xml2po extracts all texts, at least. Haven't tested if xml2po works. Also noted there are problems with keycode/keycap, but let's see if my changes is enough to generate translated docs. After further invest

Calligra release 3.2 next Thursday 23.

2020-04-16 Thread Dag
We plan to release calligra next Thursday 23rd and string freeze is in effect. There are not a lot of new strings so I hope the time frame is ok. Any protests, and we will dealy. -- Cheers, Dag

Re: Calligra release 3.2 next Thursday 23.

2020-04-16 Thread Dag
On 16-04-2020 11:31, Dag wrote: We plan to release calligra next Thursday 23rd and string freeze is in effect. There are not a lot of new strings so I hope the time frame is ok. Any protests, and we will dealy. Ahhh, release from trunk.

Version 3.2.0 released, changelog

2020-04-24 Thread Dag
Freezes lifted. I have extracted changes from git log and tried to weed out everything not interresting to a user. Please check it out and correct mistakes, omissions etc. @leinir clueless on gemini, so please review. -- Cheers, Dag Gemini: --- Author: Andrew den Exter Add a readOnly

Bugfix release 3.2.1 planned tomorrow Thursday 2020-05-14

2020-05-13 Thread Dag
Release needs to be tomorrow because of move to invent.kde.org -- Cheers, Dag

Merge request sheets

2020-06-11 Thread Dag
Hi, added my first merge request to invent. Doesn't seem to produce any notifications and I have not figured out how to add reviewers, hence this mail. The request: https://invent.kde.org/office/calligra/-/merge_requests/1 -- Cheers, Dag

Re: Merge request sheets

2020-06-11 Thread Dag
To be notified, everyone interested should star the repo (right top part of the repo's main page) and make it watched (the bell icon). Ahh, thanks. Best regards, Yuri

Annotation shape

2020-06-16 Thread Dag
y' (Don't quite know what that means) -- Mvh Dag

Re: Annotation shape

2020-06-17 Thread Dag
tirsdag den 16. juni 2020 12.30.00 CEST skrev Dag: The annotation shape seems only to be usable as a comment in words. Adding it as a plain shape does not make sence as it will behave as any shape with run-around text etc, but it will never be printed: Goodby wysiwyg. I can also add it as a

Merge requests

2020-07-17 Thread Dag
https://invent.kde.org/office/calligra/-/merge_requests -- Mvh Dag

Words and large files

2021-03-22 Thread Dag
ayout by e.g. only re-layout dirty pages before and including the displayed page(s). -- Mvh Dag

Re: Krita donation proposal

2021-11-17 Thread Dag
ds to spend that money, so what should we do? Not that I want to be greedy, but if Calligra cannot spend it on anything, I'm find with taking a larger share for Krita... No objections from me. And is there a way to spend it on Plan? No, I don't think so. Mvh, Dag Cheers,

Release

2021-12-12 Thread Dag
@pierre: If I'm not mistaken you are planning a new release soon? I cannot see that you have created a release branch, so presumely string- and feature freeze are in effect? Do you have a target date in mind? Also I have created a few merge requests that you might want to get in. -- Mvh Dag

Re: Release

2021-12-15 Thread Dag
tirsdag den 14. december 2021 12.08.46 CET skrev Pierre: On Monday, December 13, 2021 8:28:44 AM CET Dag wrote: @pierre: If I'm not mistaken you are planning a new release soon? I cannot see that you have created a release branch, so presumely string- and feature freeze are in effect? D

Re: How do I install and use Calligra Plan?

2022-07-27 Thread Dag
://binary-factory.kde.org/ But note that it is a development version so bugs must be expected. That said, any testing/feedback is appreciated. Mvh Dag Thank you. Regards, Mr. Turritopsis Dohrnii Teo En Ming Targeted Individual in Singapore 20 July 2022 Wed Blogs: https://tdtemcerts.blogspot.com

Re: Autocorrect functionality

2022-10-26 Thread Dag
Install both calligra data and LO data. . Copy data automatically from LO at release time keeping data format, Install both calligra data and LO data. I don't particulary like any of these, but trying to be practical... -- Mvh Dag

Re: Calligra Downloads not working

2023-01-23 Thread Dag
://binary-factory.kde.org/job/Calligra_Nightly_win32/ I know why you want to remove the downloads. Probably because to save bandwidth. Not quite, they were removed because calligra does not build atm and has not for quite some time. We need somebody with windows/mac knowledge to fix it. -- Mvh Dag

Re: Usability Testing for Calligra as part of study project

2023-04-04 Thread Dag
o the amount of support may be limited. @thomas Is it something you would be interrested in? It would be interresting to hear your reasons for selecting calligra for this study. -- Mvh Dag

Re: Download the calligra suite.

2023-04-30 Thread Dag
ERROR 404 Not Found URI: /job/Calligra_Nightly_win64/ STATUS: 404 MESSAGE: Not Found SERVLET: Stapler -- Powered by Jetty:// 9.4.33.v20201020 <https://eclipse.org/jetty> Could you please put back the windows downloads please? Thank you! -- Mvh Dag

2.4 branch

2012-03-13 Thread Dag
AFAICS two branches exists: 2.4 and calligra/2.4 Some commit to one, others to the other. Have I missed a trick? -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

calligra/2.4 build fails

2012-03-16 Thread Dag
If I'm not mistaken, something is missing from the 2.4 -> calligra/2.4 conversion in sheets/part/View.cpp:1179 Att patch fixes, but could you check it out Boudewijn, it seems you were the last to touch this code. -- Mvh. Dag Andersendiff --git a/sheets/part/View.cpp b/sheets/part/

Re: New test failure

2012-03-26 Thread Dag
e problem, I'm quite sure it is totally unrelated to my > changes. It might be caused by now being summer time? Yes, indeed. Fixed. -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: commits to master

2012-04-06 Thread Dag
d. > > I don't think we have taken that to heart yet. Master is currently broken > (hello Dag), Hello ;) Got cheated by a .gitignore, and lost my internet hence the late response. But yes, should have used a branch for this. > and we commit stuff without review just like we always h

help needed debugging a crash

2012-04-16 Thread Dag
I cannot find any use of declaratives in dbus, but I might not have looked in the right place. The only theory I have is that there a bug somewhere that overwrites d->declarativeData. How to catch this? Anybody? -- Mvh. Dag Andersen ___ calligra-d

Re: help needed debugging a crash

2012-04-16 Thread Dag
Mandag den 16. april 2012 12:52:39 Jaroslaw Staniek skrev: > On 16 April 2012 12:42, Dag wrote: > > :Hi, I have a crash in plan on exit which I don't know how to squash. > > > > https://bugs.kde.org/show_bug.cgi?id=298075 > > > > It happends sometimes (toda

Re: help needed debugging a crash

2012-04-16 Thread Dag
Mandag den 16. april 2012 13:36:17 Jaroslaw Staniek skrev: > On 16 April 2012 13:10, Dag wrote: > > Mandag den 16. april 2012 12:52:39 Jaroslaw Staniek skrev: > >> On 16 April 2012 12:42, Dag wrote: > >> > :Hi, I have a crash in plan on exit which I don't know

Re: KoReport ODT Renderer

2012-04-23 Thread Dag
Søndag den 22. april 2012 16:35:34 Adam Pigg skrev: > Dag > > In Plan, i see you have your own ODT renderer. Yes, I tried to make something that words could cope with and that at least looked similar to the generated report. > It appears to be more > featureful than the one in li

Re: KoReport ODT Renderer

2012-04-25 Thread Dag
Søndag den 22. april 2012 16:35:34 Adam Pigg skrev: > Dag > > In Plan, i see you have your own ODT renderer. It appears to be more > featureful than the one in libs/koreport, so perhaps you could move it > there? Done, branch: report_odt_danders > Can you post a sample of w

Re: KoReport ODT Renderer

2012-04-25 Thread Dag
? Ahh, you mean user decides. See below. The html generator works like this..there are 2, one that outputs as a table, the other outputs div blocks with css. Imo it must be possible to mix in same report. -- Sent from my Nokia N9 -- Mvh. Dag Andersen On 25/04/2012 9:51 Dag wrote: Søndag d

Re: Important must read: Splitting UI out of KoDocument

2012-05-23 Thread Dag
the code saving view settings should be trivial (is Sheets the only > > application that stores some of the view state in files?) > > > > Marijn > > Mostly what Boud said. My suggestion/idea is to do the settings saving in > view or split it between kodocment

Re: Build error

2012-06-12 Thread Dag
ake: *** [all] Error 2 > make: Target `default_target' not remade because of errors. > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Build error

2012-06-12 Thread Dag
Tirsdag den 12. juni 2012 13:40:17 Boudewijn Rempt skrev: > On Tuesday 12 June 2012 Jun, Dag wrote: > > Mandag den 11. juni 2012 11:35:50 Inge Wallin skrev: > > > There is a build error in the current master that seems to have snuck > > > past > > > most people

Re: [PATCH] bad icon name in ReportDesignDialog( ReportView *, QWidget *)

2012-07-22 Thread Dag
Søndag den 22. juli 2012 15:27:58 Friedrich W. H. Kossebau skrev: > Hi Dag, > > seems that in ReportDesignDialog the icon used should be always "window-new" > for the "Save To View" button, also in case of constructor > "ReportDesignDialog( ReportView *,

Re: [REVIEW REQUEST] Cleanup of unused or duplicated icons

2012-08-16 Thread Dag
.png > used in plan/kptview.cpp, plan/libs/ui/kptscheduleeditor.cpp, > plan/libs/models/kptschedulemodel.cpp If you mean duplicated as in "also present in oxygen", that is true. All hi- color icons in plan is copies of oxygen, I thought we were obliged to provide them as backup in ca

Re: [REVIEW REQUEST] Cleanup of unused or duplicated icons

2012-08-16 Thread Dag
Torsdag den 16. august 2012 16:19:29 Friedrich W. H. Kossebau skrev: > Am Donnerstag, 16. August 2012, 11:38:39 schrieb Dag: > > Torsdag den 16. august 2012 07:59:07 Friedrich W. H. Kossebau skrev: > > > Hi, > > > > > > looking for icons which are not nee

Re: Calligra 2.6 Beta changelog

2012-10-29 Thread Dag
ve" mouse cursor for wiring tasks in the graphic * Bug 286332 - Auto allocate selected resources to new tasks * Improve printing: Add printing options to view configuration dialog Save/load option settings -- Mvh. Dag Andersen___ calligra-d

Review request: undo stack not cleaned on saving

2012-11-05 Thread Dag
Reviewboard refuses my patch... The result is that [modified] indication is not in sync with file content, so user may accidently loose data. -- Mvh. Dag Andersendiff --git a/libs/main/KoDocument.cpp b/libs/main/KoDocument.cpp index c3158ea..0291e12 100644 --- a/libs/main/KoDocument.cpp +++ b

Re: Review request: undo stack not cleaned on saving

2012-11-05 Thread Dag
Mandag den 5. november 2012 16:35:51 skrev C. Boemann: > On Monday 05 November 2012 16:26:06 Dag wrote: > > Reviewboard refuses my patch... > > > > The result is that [modified] indication is not in sync with file content, > > so user may accidently loose data. >

Re: Review request: undo stack not cleaned on saving

2012-11-05 Thread Dag
Mandag den 5. november 2012 17:03:00 skrev C. Boemann: > On Monday 05 November 2012 16:46:26 Dag wrote: > > Mandag den 5. november 2012 16:35:51 skrev C. Boemann: > > > On Monday 05 November 2012 16:26:06 Dag wrote: > > > > Reviewboard refuses my patch... >

Crash in autosave

2012-11-06 Thread Dag
ware users that can help verify this? -- Mvh. Dag Andersen___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: kdgantt

2012-11-14 Thread Dag
t want to include all of them anyway, I suspect). My mails suddenly was not answered, probably the maintainer was put on something else, quit or whatever, so I sort of gave up... Anyway, I doubt kdgantt is *very* high on their priority list, I don't think they make much money on it (just a

Re: -Wint-to-pointer-cast in plan

2012-11-29 Thread Dag
Torsdag den 29. november 2012 00:22:59 skrev Jaroslaw Staniek: > Hi, > Are these safe warnings? Yes, think so. Removing the parameters though, as they are not really needed anymore. -- Mvh. Dag Andersen ___ calligra-devel mailing list calligra

Signing off

2013-03-04 Thread Dag
Hi everybody. Life turns a corner these days and it is clear that there is no room for calligra afaics into the future, as it has not been the last months. I thank you all for an enjoyable time, and wish you all an exiting future. -- Mvh. Dag Andersen

Re: Review Request 129512: [stencil] Follow system color for stencilsdocker icons

2016-11-24 Thread Dag Andersen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129512/#review101106 --- Ship it! Ship It! - Dag Andersen On Nov. 21, 2016, 4

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

2017-01-16 Thread Dag Andersen
ix: > https://cgit.kde.org/calligra.git/commit/?id=a8fd10d8b0a24e581eeb4754b458ba98ddbf0167) > > René J.V. Bertin wrote: > Sheets works nicely too! > > Anthony Fieroni wrote: > I response for only Karbon, wait for Camilla and Dag Andersen. > > René J.V. Berti

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

2017-01-17 Thread Dag Andersen
ix: > https://cgit.kde.org/calligra.git/commit/?id=a8fd10d8b0a24e581eeb4754b458ba98ddbf0167) > > René J.V. Bertin wrote: > Sheets works nicely too! > > Anthony Fieroni wrote: > I response for only Karbon, wait for Camilla and Dag Andersen. > > René J.V. Berti

D8310: Port Calligra Gemini for 3.x

2017-10-16 Thread Dag Andersen
danders added a comment. I'm clueless on qtquick, but unless somebody else has comments I'd say ship it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D8310 To: leinir, Calligra-Devel-list Cc: danders, vandenoever

D8310: Port Calligra Gemini for 3.x

2017-10-31 Thread Dag Andersen
danders added a comment. Dan Leinir Turthra Jensen skrev den 2017-10-30 12:06: I hope ppl have just taken an extended summer vacation ;) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D8310 To: leinir, Calligra-Devel-list Cc: danders, vandenoever

D2577: KoResourcePaths: Fix handling of wildcards in directories and files

2017-11-20 Thread Dag Andersen
danders added a comment. The background was it failed for one case in Plan, and I found a possible failure in KoMainWindow (I think it was), but that was a "if all else fails" case and I doubt the code will ever be executed. Also, I have seen that not all places uses KoResourcePaths so a ca

D9253: Make Plan build on Windows

2017-12-08 Thread Dag Andersen
danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Surprised it was *that* easy... REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D9253 To: leinir, #calligra:_3.0, danders Cc: Calligra-Devel-list, cochise, vandeno

D11505: Plan: fix build with Qt 5.6

2018-03-20 Thread Dag Andersen
danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Hmm, it should have been i18n'ed also. I'll fix that later, just land it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D11505 To: wbauer, danders Cc: Calligra-D

D9537: [kotextlayoutarea] Make percentage line height relative to the default height

2018-07-25 Thread Dag Andersen
danders added a comment. Yeah :) Seems a unit test needs adjustments, could you have a look? https://build.kde.org/view/Calligra/job/Calligra%20calligra%20kf5-qt5%20FreeBSDQt5.10/lastCompletedBuild/testReport/(root)/TestSuite/libs_kotextlayout_TestBlockLayout/ REPOSITORY R8 Calligra RE

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

2018-08-17 Thread Dag Andersen
danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY There is a couple of failing tests now marked as XFAIL. I am afrai

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

2018-08-17 Thread Dag Andersen
danders marked an inline comment as done. danders added a comment. What to change depends on what the number means ;) Well in general all numbers that depends on fontsize should be changed, the rest should stay the same, but yes it is a puzzle. REPOSITORY R8 Calligra REVISION DETAIL ht

D14916: [ArtisticTextShape] Merge text ranges with same style

2018-08-19 Thread Dag Andersen
danders added a comment. The change in appendText(const QString &text): The original appended to an existing range while you add a new range. I would think you could just leave the old code untouched, no? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D14916 To:

D14916: [ArtisticTextShape] Merge text ranges with same style

2018-08-19 Thread Dag Andersen
danders added a comment. Hmm, I assumed it only got in here when appending a text to a) an empty shape (no need for merging), b) at the end of an existing text, in which case using the the existing formatting of the last range should ok. I just can't see why using a defaultfont in this ca

D14916: [ArtisticTextShape] Merge text ranges with same style

2018-08-20 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D14916 To: anthonyfieroni, boemann, danders, #calligra:_3.0 Cc: Calligra-Devel-list, cochise, vandenoever

D14975: Don't use obsolete QRectF and QAbstractItemModel functions

2018-08-22 Thread Dag Andersen
danders added a comment. I'm not 100% sure of stackChanged() change. Probably ok, but the original would call both begin and end before calling the selection model. To get exactly the same behaviour you could do the same. It depends on how the selction model handles reset and setCurrentI

D14975: Don't use obsolete QRectF and QAbstractItemModel functions

2018-08-22 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D14975 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D15056: [EnhancedPathShape] Keep correct aspect ratio of shapes in odf files

2018-08-28 Thread Dag Andersen
danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Haven't tested, but sounds sane :) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15056 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-l

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

2018-08-28 Thread Dag Andersen
danders added a reviewer: leinir. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15102 To: dcaliste, #calligra:_3.0, leinir Cc: Calligra-Devel-list, cochise, vandenoever

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

2018-08-31 Thread Dag Andersen
danders added a comment. Ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D14901 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, cochise, vandenoever

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

2018-09-01 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes. Closed by commit R8:705d0ae50923: Fix blocklayout unittest after percentage lineheight was fixed in D9537 (authored by danders). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14901?vs=39919&id=40803#toc REPOSITORY

D15403: {Style] Default sheets to white background

2018-09-10 Thread Dag Andersen
danders added a comment. Hmm, imo styling odf apps content area should be considdered a bug :=) Because: All info pertaining to presentation of content is stored in odf file and is controllable by user, so styling it would often create strange resullts. (And it would not be much wysiwyg ab

D15403: {Style] Default sheets to white background

2018-09-10 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15403 To: anthonyfieroni, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15412: [filters] Extend table lifetime

2018-09-13 Thread Dag Andersen
danders added a comment. Sorry, don't have any qualified opinons, I don't quite understand the original code either, so... Imo if you think it is good, land it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15412 To: anthonyfieroni, danders, boemann, #calligra:_3

D15549: Words: Save anchor info also for page-anchored shapes

2018-09-16 Thread Dag Andersen
danders created this revision. danders added a reviewer: boemann. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY LO needs anchor info to position shapes correctly. REPOSITORY R8 Calligra BRANC

D15549: Words: Save anchor info also for page-anchored shapes

2018-09-16 Thread Dag Andersen
danders added a comment. After reading the fine print, see: http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#__RefHeading__1420028_253892949 it seems to me a shape can be anchored to a page in different ways. Note this: "If the attribute value is not from-left and

D15567: Words: Do not popup contextmenu twice

2018-09-17 Thread Dag Andersen
danders created this revision. danders added a reviewer: boemann. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Popup menu was called from mousePressEvent. No need as it is handled in contextMe

D15549: Words: Save anchor info also for page-anchored shapes

2018-09-17 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes. Closed by commit R8:02f34b05723a: Words: Save anchor info also for page-anchored shapes (authored by danders). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15549?vs=41737&id=41811#toc REPOSITORY R8 Calligra CH

D15622: Upgrade intersect() to intersected() calls

2018-09-20 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15622 To: dcaliste, leinir, anthonyfieroni, danders, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15620: Remove deprecated use of QDate::setYMD() and QFlag instead of QWindowFlag

2018-09-20 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15620 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15619: Remove use of kglobal.h in sheets

2018-09-20 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15619 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15567: Words: Do not popup contextmenu twice

2018-09-21 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes. Closed by commit R8:7bd9b921826e: Words: Do not popup contextmenu twice (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15567?vs=41797&id=42052 REVISION DETAIL ht

D15775: Make the item background color and page cache properties available from View component

2018-10-04 Thread Dag Andersen
danders added inline comments. INLINE COMMENTS > View.h:118 > + */ > +bool pageCache() const; > +/** Could you rename pageCache() to pageCacheEnabled() and d:o setPageChache() REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15775 To: dcaliste, leinir, dande

D15053: Consistently use qreal in libs/pigment

2018-10-09 Thread Dag Andersen
danders accepted this revision as: danders. danders added a comment. This revision is now accepted and ready to land. Fine with me. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: boemann, anthonyfieroni, Calligr

D16127: Annotation: Block adding comment to an annotation shape

2018-10-11 Thread Dag Andersen
danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY To reproduce crash: 1. Add a text shape 2. Add an annotation

D16127: Annotation: Block adding comment to an annotation shape

2018-10-11 Thread Dag Andersen
danders marked an inline comment as done. danders added a comment. No, it should not be possible to activate a tool without a shape. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16127 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise,

D16127: Annotation: Block adding comment to an annotation shape

2018-10-16 Thread Dag Andersen
danders updated this revision to Diff 43721. danders added a comment. - DefaultTool: Do not considder parent flags when checking Move-/ResizeAllowd - DefaultTool: MoveStrategy: Check if shape is movable - DefaultTool: ResizeStrategy: Check if shape is resizeable - DefaultTool: ShareStrate

D16127: Annotation: Block adding comment to an annotation shape

2018-10-16 Thread Dag Andersen
danders added a comment. Arghh, accidentally propt a new diff on top of this, howto undo this? (arc is fine, but do not do anything wrong) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16127 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, c

D16127: Annotation: Block adding comment to an annotation shape

2018-10-16 Thread Dag Andersen
danders abandoned this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16127 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16127: Annotation: Block adding comment to an annotation shape

2018-10-16 Thread Dag Andersen
danders updated this revision to Diff 43724. danders added a comment. - If no textshape is editied, select the first found text shape REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16127?vs=43721&id=43724 BRANCH danders_annotation_crash REVISION DETAIL

D16127: Annotation: Block adding comment to an annotation shape

2018-10-16 Thread Dag Andersen
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:d4744090e8c6: Annotation: Block adding comment to an annotation shape (authored by danders). REPOSITORY R8 Calligra C

D16289: Karbon: Add Anthony as maintainer and remove unmaintained

2018-10-17 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REPOSITORY R8 Calligra BRANCH karbon_danders REVISION DETAIL https://phabricator.kde.or

D16289: Karbon: Add Anthony as maintainer and remove unmaintained

2018-10-18 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes. Closed by commit R8:99527b565f59: Karbon: Add Anthony as maintainer and remove unmaintained (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16289?vs=43840&id=43844

D16367: EnhancedPathShape: Shape is moved/resized on save/load

2018-10-22 Thread Dag Andersen
danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Remove all code that uses viewbox to affect position and size.

D16367: EnhancedPathShape: Shape is moved/resized on save/load

2018-10-22 Thread Dag Andersen
danders added a comment. I have tested with LO: Create with flow, Open in LO, Save in LO, Open in flow. And it seems to work, so there must be some special case? The only workaround I've seen is for ellipses. No chance for a testdoc I guess... REPOSITORY R8 Calligra REVISION D

D16367: EnhancedPathShape: Shape is moved/resized on save/load

2018-10-23 Thread Dag Andersen
danders added a comment. Yes, found it: https://bugs.kde.org/show_bug.cgi?id=289646 Afaics this affects only callout shapes where OO/LO breaks the intention of the odf spec by using the shape size and position as text area. This is ok (sort of) when text area and shape area overlap but n

D16367: EnhancedPathShape: Shape is moved/resized on save/load

2018-10-29 Thread Dag Andersen
danders abandoned this revision. danders added a comment. Ok, after some more investigation, I've found a number of problems around these things. This was really just a bug in the stencil database.odg file. The callout stuff is the big one, because it abuses odf so needs special treatment

D16679: Words: Fix interop problem with LO/OO

2018-11-05 Thread Dag Andersen
danders created this revision. danders added a reviewer: boemann. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Words creates pagestyles with name "Standard" and displayname "Default". Afaics t

D16679: Words: Fix interop problem with LO/OO

2018-11-05 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes. Closed by commit R8:caffa566d8d2: Words: Fix interop problem with LO/OO (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16679?vs=44892&id=44896 REVISION DETAIL ht

D16756: CalloutShape: Add a new shape to handle callouts

2018-11-08 Thread Dag Andersen
danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY This is the start of a dedicated callout shape. It uses draw:type

D16756: CalloutShape: Add a new shape to handle callouts

2018-11-14 Thread Dag Andersen
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:2e1aaae999f3: CalloutShape: Add a new shape to handle callouts (authored by danders). REPOSITORY R8 Calligra CHANGES

D15428: [textlayout] Don't enter infinite loop when table is misfit

2018-12-09 Thread Dag Andersen
danders added a comment. Would it be possible to make a unit test? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

<    1   2   3   4   >