D15111: [KoUnit] Let's show pixel units

2020-05-15 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > anthonyfieroni wrote in KoUnit.h:59-60 > @ndavis, DPI is 96, it's not configurable for now. Was it already like that when I made the comment? When I export an SVG, it's proportioned like the DPI was 72 if I open it in Gwenview or Inkscape. 48x48

D15111: [KoUnit] Let's show pixel units

2020-05-15 Thread Camilla Boemann
boemann added a comment. And that is why this proposal should be rejected as is pixels is not a unit unless assigned a ppi on a case by case basis and thus it needs to be something requested and not EVER something that is always available ! REPOSITORY R8 Calligra REVISION DETAIL

D15111: [KoUnit] Let's show pixel units

2020-05-15 Thread Noah Davis
ndavis added a comment. In D15111#671492 , @boemann wrote: > And that is why this proposal should be rejected as is > > pixels is not a unit unless assigned a ppi on a case by case basis > > and thus it needs to be something requested and

D15111: [KoUnit] Let's show pixel units

2020-05-15 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > ndavis wrote in KoUnit.h:59-60 > Was it already like that when I made the comment? When I export an SVG, it's > proportioned like the DPI was 72 if I open it in Gwenview or Inkscape. 48x48 > becomes 36x36. Are you using HiDPI resolution?

D15111: [KoUnit] Let's show pixel units

2020-05-15 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > anthonyfieroni wrote in KoUnit.h:59-60 > Are you using HiDPI resolution? Scale factor, Calligra is not hidpi > compatible, i think I am using 96 font DPI (not forced) and 1x scaling at 1920x1080. REPOSITORY R8 Calligra REVISION DETAIL https:

D15111: [KoUnit] Let's show pixel units

2020-05-15 Thread Camilla Boemann
boemann added a comment. Nothing prevents Karbon from having a m_pixelUnit with ppi collected from a widget for user control and the use that unit like inkscape does. But what this patch does is enable it in general with an arbitrary chosen ppi value Why not measure in apples t

D15111: [KoUnit] Let's show pixel units

2020-05-15 Thread Noah Davis
ndavis added a comment. In D15111#671510 , @boemann wrote: > Nothing prevents Karbon from having a m_pixelUnit with ppi collected from a widget for user control > > and the use that unit like inkscape does. > > But what this patch does is